bf07f65e93
Bug 1810717 - De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D167012
2023-01-19 16:17:29 +00:00
c5cbcf0a2e
Backed out changeset 218b12b92ccb (bug 1352757) for causing failures on test_transitions_per_property.html.
2023-01-19 19:34:50 +02:00
edd09f1f0f
Backed out 2 changesets (bug 1810717) for causing test_transitions_per_property.html failures. CLOSED TREE
...
Backed out changeset 51d5319d3ce9 (bug 1810717)
Backed out changeset 17729df522e3 (bug 1810717)
2023-01-19 19:13:31 +02:00
3102bb184e
Bug 1810717 - De-dup items with the same tag in the computed value of font-feature-settings and font-variation-settings. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D167012
2023-01-19 16:17:29 +00:00
bb0657c1b2
Bug 1352757 - Add lab(), lch(), oklab(), oklch() to specified colors. r=supply-chain-reviewers,emilio
...
Use new changes from cssparser and use the new lab/lch/oklab/oklch color
formats.
Introduced a new color type AbsoluteColor. It represents any kind of
color that has absolute numerical values. It is also tied to a color
space and therefore can be trivially converted to another color space.
Differential Revision: https://phabricator.services.mozilla.com/D163579
2023-01-19 16:17:15 +00:00
43310da9b1
Bug 1810946 - Remove some duplicated code for coordinated properties. r=boris
...
Differential Revision: https://phabricator.services.mozilla.com/D167130
2023-01-19 10:06:39 +00:00
391ea11d99
Bug 1810946 - Use the same computed time representation between Servo and Gecko. r=boris
...
Same as above.
Differential Revision: https://phabricator.services.mozilla.com/D167126
2023-01-19 10:06:38 +00:00
b830123d55
Bug 1810946 - Share computed animation-iteration-count representation between Servo and Gecko. r=boris
...
This removes the special AnimationIterationCount -> f32 conversion from
gecko.mako.rs which will be useful to simplify coordinated properties.
Differential Revision: https://phabricator.services.mozilla.com/D167123
2023-01-19 10:06:38 +00:00
148d5639c3
Backed out 4 changesets (bug 1810946) for causing bustages in nsStyleStruct.cpp. CLOSED TREE
...
Backed out changeset 8bc18b0e7a91 (bug 1810946)
Backed out changeset 1d02bd23dabe (bug 1810946)
Backed out changeset 258c2f8c1bc9 (bug 1810946)
Backed out changeset bd491b11178a (bug 1810946)
2023-01-19 04:40:39 +02:00
bd07f4824b
Bug 1810946 - Remove some duplicated code for coordinated properties. r=boris
...
Differential Revision: https://phabricator.services.mozilla.com/D167130
2023-01-19 02:06:08 +00:00
57f3c8cbfe
Bug 1810946 - Use the same computed time representation between Servo and Gecko. r=boris
...
Same as above.
Differential Revision: https://phabricator.services.mozilla.com/D167126
2023-01-19 02:06:07 +00:00
a31e191b95
Bug 1810946 - Share computed animation-iteration-count representation between Servo and Gecko. r=boris
...
This removes the special AnimationIterationCount -> f32 conversion from
gecko.mako.rs which will be useful to simplify coordinated properties.
Differential Revision: https://phabricator.services.mozilla.com/D167123
2023-01-19 02:06:07 +00:00
f43e60b229
Bug 1808228 - Reuse list_matches_complex_selector() where possible r=emilio
...
It can be reused for the Is, Where, and Negation components.
Differential Revision: https://phabricator.services.mozilla.com/D166267
2023-01-18 21:20:02 +00:00
4e80d75bce
Bug 1810657 - Apply slow selector flags before matching r=emilio
...
This patch fixes a bug introduced by bug 1808228/D166266, where, if an
element does not initially match :nth-child(An+B of selector list) or
:nth-last-child(An+B of selector list), changing a sibling or ancestor
will not invalidate that element.
Differential Revision: https://phabricator.services.mozilla.com/D166982
2023-01-18 00:36:42 +00:00
43752f0573
Bug 1798323 - Style changes to support the 'page-orientation' property. r=AlaskanEmily
...
Differential Revision: https://phabricator.services.mozilla.com/D161800
2023-01-16 15:03:44 +00:00
ddca3821de
Bug 1808228 - Implement selector matching for :nth-child(An+B of selector list) and :nth-last-child(An+B of selector list) r=emilio
...
Since we have been using a single hash map to cache all :nth-child
indices (with no selector list), each different selector will need its
own cache.
As a side note, this patch does not address invalidation.
Differential Revision: https://phabricator.services.mozilla.com/D166266
2023-01-16 11:26:41 +00:00
3ad7017163
Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
...
They have been disabled since bug 1688695. There's a variety of
table-caption bugs that would be easier to fix if we didn't have to
account for side-captions.
Differential Revision: https://phabricator.services.mozilla.com/D165690
2023-01-09 18:02:23 +00:00
4ab6fc29e0
Backed out changeset c34c31220275 (bug 1807963) for causing reftest unexpected passes on 446100-1c.html.
2023-01-09 15:01:55 +02:00
7b821c0133
Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
...
They have been disabled since bug 1688695. There's a variety of
table-caption bugs that would be easier to fix if we didn't have to
account for side-captions.
Differential Revision: https://phabricator.services.mozilla.com/D165690
2023-01-09 10:39:44 +00:00
fde4a37863
Bug 1800394 - Serialization differences with "columns" with one or more `auto` value. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D166087
2023-01-09 10:17:25 +00:00
81bfc93257
Backed out changeset e018ba23c07d (bug 1807963) for causing wpt failures in caption.html. CLOSED TREE
2023-01-09 10:42:21 +02:00
476cccc35c
Bug 1808888 - [refactor] Migrate NS_STYLE_LIST_STYLE_POSITION_* defines r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D166140
2023-01-09 07:07:13 +00:00
5b925c72c8
Bug 1807963 - Remove non-standard values of caption-side for good. r=TYLin,layout-reviewers
...
They have been disabled since bug 1688695. There's a variety of
table-caption bugs that would be easier to fix if we didn't have to
account for side-captions.
Differential Revision: https://phabricator.services.mozilla.com/D165690
2023-01-09 07:05:14 +00:00
7ca882f84e
Bug 1809091 - Move nth-related logic to the NthSelectorData type for reuse r=emilio
...
Drive-by, but selector_list_specificity() was also renamed to
max_selector_list_specificity().
Differential Revision: https://phabricator.services.mozilla.com/D166263
2023-01-09 06:06:27 +00:00
d2cd09a679
Bug 1808227 - Implement parsing and serialization for nth-child(An+B of selector list) and :nth-last-child(An+B of selector list) r=emilio
...
:nth-{,last-}child parsing is disabled by default for now by pref
layout.css.nth-child-of.enabled.
Differential Revision: https://phabricator.services.mozilla.com/D165895
2023-01-07 14:32:42 +00:00
1be379c873
Bug 1808811 - Animate the 'normal' value of font-style as 'oblique 0deg'. r=firefox-style-system-reviewers,emilio
...
This matches what the spec[1] says for font-style:
> Animation type: by computed value type; normal animates as oblique 0deg
A bunch of WPT tests for font-style animation are landing in https://github.com/web-platform-tests/wpt/pull/37570 .
Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests.
[1] https://drafts.csswg.org/css-fonts-4/#font-style-prop
Differential Revision: https://phabricator.services.mozilla.com/D166128
2023-01-06 16:50:14 +00:00
3ed20ecd38
Bug 1808811 - Remove spurious mention of FontStyleAdjust from style/properties/data.py r=emilio
...
There's no font-style-adjust property, and no FontStyleAdjust type anywhere I can see.
So the mention in data.py is redundant (and potentially confusing).
Differential Revision: https://phabricator.services.mozilla.com/D166127
2023-01-06 16:50:14 +00:00
fe537628b8
Backed out 2 changesets (bug 1808811) for causing failures on test_smilCSSFromTo.xhtml. CLOSED TREE
...
Backed out changeset 9b93cb8944d8 (bug 1808811)
Backed out changeset 05ad5582eed7 (bug 1808811)
2023-01-06 17:31:41 +02:00
2f90a64adf
Bug 1808811 - Animate the 'normal' value of font-style as 'oblique 0deg'. r=firefox-style-system-reviewers,emilio
...
This matches what the spec[1] says for font-style:
> Animation type: by computed value type; normal animates as oblique 0deg
A bunch of WPT tests for font-style animation are landing in https://github.com/web-platform-tests/wpt/pull/37570 .
Current Gecko passes 66/129 of the testcases there; with this patch applied it passes all the tests.
[1] https://drafts.csswg.org/css-fonts-4/#font-style-prop
Differential Revision: https://phabricator.services.mozilla.com/D166128
2023-01-06 11:06:43 +00:00
3d4efc99fd
Bug 1808811 - Remove spurious mention of FontStyleAdjust from style/properties/data.py r=emilio
...
There's no font-style-adjust property, and no FontStyleAdjust type anywhere I can see.
So the mention in data.py is redundant (and potentially confusing).
Differential Revision: https://phabricator.services.mozilla.com/D166127
2023-01-06 11:06:43 +00:00
ed0e1ea9db
Bug 1808180 - Compute font-size-adjust early, so that we get the correct used font size for font-dependent units. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D165842
2023-01-04 07:55:12 +00:00
97f67b9a24
Backed out 2 changesets (bug 1808180) for wpt failures on fill-and-stroke-styles/2d.pattern.paint.repeat.outside.html. CLOSED TREE
...
Backed out changeset d47c053defd1 (bug 1808180)
Backed out changeset bdc44df90cd9 (bug 1808180)
2023-01-04 11:36:56 +02:00
b38597e3e9
Bug 1808180 - Compute font-size-adjust early, so that we get the correct used font size for font-dependent units. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D165842
2023-01-04 07:55:12 +00:00
c2df0ac6a5
Backed out 2 changesets (bug 1808180) for causing failures on 569193-1.html. CLOSED TREE
...
Backed out changeset 31dd36f707b4 (bug 1808180)
Backed out changeset 6cd04e4e9efe (bug 1808180)
2023-01-04 06:01:29 +02:00
38556e307d
Bug 1807685 - Rename scroll-linked (animations) to scroll-driven (excluding WPT tests). r=dholbert
...
The spec is still using `Scroll-linked`, so we exclude the change of WPT tests.
I believe WPT will get updates once the spec doc is renamed.
Differential Revision: https://phabricator.services.mozilla.com/D165914
2023-01-04 00:50:45 +00:00
e7d8cb8d1f
Bug 1808180 - Compute font-size-adjust early, so that we get the correct used font size for font-dependent units. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D165842
2023-01-04 00:23:43 +00:00
af8c7f62d0
Backed out 2 changesets (bug 1808180) for causing failures on 569193-1.html.
...
Backed out changeset 4ea6661cbff9 (bug 1808180)
Backed out changeset 42ec51c382ab (bug 1808180)
2023-01-03 20:26:28 +02:00
e8a83450cc
Bug 1808304 - Minor clean-ups and fixes on top of the previous patch. r=zrhoffman
...
This makes the matching / parsing more self-contained, and I believe
it's generally easier to follow. Also addresses review comments from the
previous patch.
Differential Revision: https://phabricator.services.mozilla.com/D165861
2023-01-03 15:30:20 +00:00
bc4a80416a
Bug 1808304 - Represent FirstChild, FirstOfType, LastChild, LastOfType, OnlyChild, and OnlyOfType as functionless Nth variants r=emilio
...
Like bug 1808226, this doesn't change any behavior, it just simplifies matching.
I also added a WPT JavaScript test for :only-of-type, since dedicated WPT
JavScript tests already exist for the other pseudo-classes this patch
touches.
Differential Revision: https://phabricator.services.mozilla.com/D165859
2023-01-03 15:30:19 +00:00
a750039065
Bug 1808180 - Compute font-size-adjust early, so that we get the correct used font size for font-dependent units. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D165842
2023-01-03 13:14:36 +00:00
8b3a740547
Bug 1805097 - [refactor] Migrate NS_STYLE_MASONRY_* defines r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D164422
2023-01-03 12:14:56 +00:00
5f7dd7fd11
Backed out 2 changesets (bug 1808180) for causing failures in font-size-adjust-order-001.html CLOSED TREE
...
Backed out changeset cce81bd0ed5a (bug 1808180)
Backed out changeset cf3fd870adb4 (bug 1808180)
2023-01-03 14:27:19 +02:00
77b9157e5d
Bug 1808180 - Compute font-size-adjust early, so that we get the correct used font size for font-dependent units. r=emilio
...
Differential Revision: https://phabricator.services.mozilla.com/D165842
2023-01-03 09:39:52 +00:00
a279e5f075
Bug 1808226 - Store values for :nth- selectors in dedicated struct NthSelectorData r=emilio
...
To accomplish this, all :nth- Components were replaced with type Nth,
which uses NthSelectorData.
Using NthSelectorData will make it easier to add selector lists for :nth
selectors later on, but this change by itself shouldn't change any
behavior.
Differential Revision: https://phabricator.services.mozilla.com/D165831
2023-01-03 08:35:20 +00:00
8847a0669e
Bug 1800952 - Compute column-rule-width to 0 when column-rule-style is none. r=emilio
...
Depends on D164554
Differential Revision: https://phabricator.services.mozilla.com/D164549
2023-01-02 21:11:30 +00:00
3cfb4f60c1
Bug 1503662 - Use used, rather than computed font-size for font-metric dependent units. r=jfkthame
...
Differential Revision: https://phabricator.services.mozilla.com/D165737
2023-01-02 02:29:30 +00:00
b535975ae1
Bug 1768905 - Remove dead test file.
...
No review (dead code removal that I noticed while reviewing some other
stuff).
DONTBUILD
MANUAL PUSH: Trivial, dead test-only file removal.
2023-01-02 01:28:06 +01:00
4b8b967fcd
Bug 1806322 - Fix container orientation evaluation. r=Oriol
...
Allow keyword evaluators to return unknown.
Do you know of a good test to extend here? Otherwise I can add a new
one, though I gotta run atm.
Differential Revision: https://phabricator.services.mozilla.com/D165630
2022-12-29 13:02:37 +00:00
218c654e19
Bug 1806273 - Avoid generic soup and extra reference count bumps. r=dshin
...
This makes me a bit happier about the previous patch :)
Differential Revision: https://phabricator.services.mozilla.com/D165236
2022-12-29 00:23:28 +00:00
429af26654
Bug 1807789 - Update darling to 0.14.2. r=emilio,supply-chain-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D165598
2022-12-28 20:53:26 +00:00
Jonathan Kew
Cosmin Sabou
Tiaan Louw
Emilio Cobos Álvarez
Stanca Serban
Zach Hoffman
Jonathan Watt
Ziran Sun
Ben Freist
Iulian Moraru
Boris Chiou
Noemi Erli
Oriol Brufau
Mike Hommey