Ava Katushka ava8katushka
89f2c5883c
Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-05 20:12:43 +00:00
Agi Sferro
8c6612b46b
Bug 1738966 - Pass in argc, argv in GreOmniPath. r=kershaw,valentin
...
A call to InitCommandLine was added in Bug 1727180 where gArgc and gArgv are
not defined.
The same bug also re-enabled some tests that appeared to pass (but really they
were just silently crashing), this patch fixes that too.
Differential Revision: https://phabricator.services.mozilla.com/D130223
2021-11-03 16:31:06 +00:00
Cristian Tuns
33910a7b41
Backed out changeset b855af57f71a (bug 1725354) for causing mochitest failures on test_third_party_iframes.html CLOSED TREE
2021-11-03 12:45:48 -04:00
Ava Katushka ava8katushka
21c6ae4572
Bug 1725354 - Download panel shows blocked download item. r=mtigley,fluent-reviewers,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D123943
2021-11-03 15:31:13 +00:00
Gijs Kruitbosch
39b09ddee9
Bug 1737926 - cope with the default downloads directory not existing on some Linux systems, r=mtigley,mhowell
...
This doesn't break without the download improvement pref because
in that case we don't save the file immediately to the downloads
dir. Instead, it gets moved there by toolkit code, which has
fallback logic: https://searchfox.org/mozilla-central/rev/4cfc1d8874e5409e7475c6cbb0409e3f566a162e/toolkit/components/downloads/DownloadIntegration.jsm#317,336
This patch fixes the uriloader code to employ the same fallback.
Differential Revision: https://phabricator.services.mozilla.com/D129996
2021-11-03 00:08:06 +00:00
Sandor Molnar
9c788583c9
Backed out changeset 087b77b0d061 (bug 1737926) for causing browser-chrome failures in browser_bad_download_dir. CLOSED TREE
2021-11-03 01:23:54 +02:00
Gijs Kruitbosch
9f898868d4
Bug 1737926 - cope with the default downloads directory not existing on some Linux systems, r=mtigley,mhowell
...
This doesn't break without the download improvement pref because
in that case we don't save the file immediately to the downloads
dir. Instead, it gets moved there by toolkit code, which has
fallback logic: https://searchfox.org/mozilla-central/rev/4cfc1d8874e5409e7475c6cbb0409e3f566a162e/toolkit/components/downloads/DownloadIntegration.jsm#317,336
This patch fixes the uriloader code to employ the same fallback.
Differential Revision: https://phabricator.services.mozilla.com/D129996
2021-11-02 22:20:17 +00:00
Kershaw Chang
34f9cb2633
Bug 1727180 - Call XRE_InitCommandLine for xpcshell, r=glandium
...
Differential Revision: https://phabricator.services.mozilla.com/D124890
2021-11-02 16:01:10 +00:00
Sam Foster
70d1f98445
Bug 1736749 - ensure we alwaysAskBeforeHandling downloads in browser_download_open_with_internal_handler.js to verify unknown-content-type dialog behavior when download improvements are flipped on. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D129095
2021-10-21 10:37:16 +00:00
Gijs Kruitbosch
f6fb4363bc
Bug 1736103 - fix download file extension correction test some more for the no-download-modal case, r=sfoster
...
On try and on my machine, after D128648 the test still times out because
for the test_broken_saved_handlerinfo_and_useless_mimetypes test, first
awaiting the `task` that gets passed means that the download has already
finished by the time we create the download finished promise.
This patch moves creating that promise before the `task` is started.
It also broadens the conditions in which we await this promise, because
in the case without file extensions and without a dialog, we were otherwise
no longer awaiting anything, which meant that the next test's check for
a finished download would resolve with the previous test's download, causing
confusion/breakage.
Differential Revision: https://phabricator.services.mozilla.com/D128916
2021-10-20 09:38:27 +00:00
Joel Maher
fed2831742
Bug 1727943 - turn on mochitest* tests that were skipped on win10-ccov and now pass. r=MasterWayZ
...
Differential Revision: https://phabricator.services.mozilla.com/D128817
2021-10-19 20:01:29 +00:00
Molly Howell
3a5d8adfe1
Bug 1736103 - Fix the download file extension correction test to not depend on the download modal when it is disabled. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D128648
2021-10-19 14:48:30 +00:00
Gijs Kruitbosch
7fa72ca48d
Bug 1735368 - ensure we also test saving closing windows when saving downloads to disk, r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D128629
2021-10-19 10:35:47 +00:00
Gijs Kruitbosch
d197b20357
Bug 1735368 - fix browser_auto_close_window.js so it passes with download improvements enabled and when asking for all downloads, r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D128628
2021-10-19 10:35:46 +00:00
Paul Zuehlcke
fa3d978f5d
Bug 1696685 - r=xpcom-reviewers,necko-reviewers,valentin,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D128630
2021-10-19 10:17:03 +00:00
criss
2ee81d4656
Backed out changeset 346bcc20a94e (bug 1696685) for causing bustages on nsEscape.h. CLOSED TREE
2021-10-19 12:59:41 +03:00
Paul Zuehlcke
54d4322ca1
Bug 1696685 - r=xpcom-reviewers,necko-reviewers,valentin,nika
...
Differential Revision: https://phabricator.services.mozilla.com/D128630
2021-10-19 09:34:08 +00:00
Evgenia Kotovich
0d0980ee0d
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-18 09:26:33 +00:00
Noemi Erli
2bba3cec69
Backed out changeset 2ab6bb03dcc1 (bug 1576768) for causing failures in test_double_submit.html CLOSED TREE
2021-10-18 02:05:57 +03:00
Noemi Erli
13f49dc940
Backed out 2 changesets (bug 1735368) for causing failures in browser_extension_correction.js
...
Backed out changeset 76af648f5fb2 (bug 1735368)
Backed out changeset 609299c8386b (bug 1735368)
2021-10-18 01:59:00 +03:00
Gijs Kruitbosch
ebea326363
Bug 1735368 - ensure we also test saving closing windows when saving downloads to disk, r=sfoster
...
Depends on D128628
Differential Revision: https://phabricator.services.mozilla.com/D128629
2021-10-17 21:31:20 +00:00
Gijs Kruitbosch
0931eaffcf
Bug 1735368 - fix browser_auto_close_window.js so it passes with download improvements enabled and when asking for all downloads, r=sfoster
...
Differential Revision: https://phabricator.services.mozilla.com/D128628
2021-10-17 21:31:20 +00:00
Evgenia Kotovich
3e3dff109c
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-17 14:59:14 +00:00
Katherine Patenio
8b992356e1
Bug 1724319 - fix browser_open_internal_choice_persistence when downloads pref is enabled. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D125485
2021-10-15 19:32:38 +00:00
Sam Foster
918f63c73f
Bug 1735843 - Fix handler logic in HandlerServiceTestUtils and browser_externalLinkBlanksPage.js to work when download improvements are enabled. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D128548
2021-10-15 18:43:07 +00:00
Alexandru Michis
dac6815201
Backed out changeset 7c08aa027893 (bug 1576768) for causing multiple failures.
...
CLOSED TREE
2021-10-15 16:52:43 +03:00
Evgenia Kotovich
a8b32926fa
Bug 1576768 - Automatically format .sjs files using prettier. r=Standard8,agi,zombie,extension-reviewers
...
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D128482
2021-10-15 12:58:11 +00:00
Molly Howell
04fb36a97c
Bug 1735877 - Check for the download improvements pref in a couple of places where it changes behaviors that are verified by this test. r=Gijs
...
I also added a comment to try and keep anyone else from spending as long as I
did fretting over one particular check in this test.
Differential Revision: https://phabricator.services.mozilla.com/D128506
2021-10-14 22:54:54 +00:00
Micah Tigley
2c43dd5982
Bug 1735414 - Protocol handlers should be set to always ask before handling. r=mhowell,NeilDeakin
...
Differential Revision: https://phabricator.services.mozilla.com/D128495
2021-10-14 17:05:18 +00:00
Gijs Kruitbosch
c062f5bab3
Bug 1734687 - fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D127871
2021-10-12 08:31:29 +00:00
Cristian Tuns
b16dce3922
Backed out changeset c15b48000571 (bug 1734687) for causing mochitest failures on test_nullCharFile.xhtml CLOSED TREE
2021-10-11 12:22:14 -04:00
Gijs Kruitbosch
0aeb302c8a
Bug 1734687 - fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D127871
2021-10-11 15:02:24 +00:00
Neil Deakin
927d35d601
Bug 1733492, unknown content type dialog not always appearing when always ask is set in preferences for a type, r=mtigley
...
This defaults the always ask setting for a type to false when the download panel improvements preference is enabled, and adjusts the external helper apps service so that it properly uses the always ask flag in all cases
Differential Revision: https://phabricator.services.mozilla.com/D127850
2021-10-08 00:17:12 +00:00
Noemi Erli
359bdcc7a2
Backed out changeset 4a54d16de0c1 (bug 1734687) for causing failures in test_nullCharFile.xhtml
2021-10-08 03:04:31 +03:00
Gijs Kruitbosch
5508a54a1a
Bug 1734687 - fix mochitest plain tests to pass with/without improvements_to_downloads changes, r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D127871
2021-10-07 20:14:39 +00:00
Jens Stutte
29908b27d6
Bug 1731564: Use motivated SpinEventLoopUntil inside uriloader/*. r=smaug
...
Depends on D127234
Differential Revision: https://phabricator.services.mozilla.com/D127235
2021-10-07 08:06:15 +00:00
Marian-Vasile Laza
18fb16c542
Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
...
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte
8928410e6c
Bug 1731564: Use motivated SpinEventLoopUntil inside uriloader/*. r=smaug
...
Depends on D127234
Differential Revision: https://phabricator.services.mozilla.com/D127235
2021-10-06 19:45:17 +00:00
Gijs Kruitbosch
aba02e9455
Bug 1724319 - fix storing of user preferences for protocol handler registrations with download improvements pref, r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D127463
2021-10-05 10:48:52 +00:00
Michelle Goossens
c159e29e05
Bug 1727943 - Part 2: Migrate mochitest, reftest and crashtest Windows 10 ccov suites from AWS to Azure r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D125350
2021-09-28 15:27:39 +00:00
Micah Tigley
0743fa1388
Bug 1731668 - Move downloads spam prevention work behind a pref. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D126296
2021-09-22 22:38:17 +00:00
Cristian Tuns
676acd6c27
Backed out changeset 03a33d194255 (bug 1731668) for causing mochitest failures on browser_download_spam_permissions.js. CLOSED TREE
2021-09-22 12:23:56 -04:00
Micah Tigley
5ecbe6bdff
Bug 1731668 - Move downloads spam prevention work behind a pref. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D126296
2021-09-22 15:26:59 +00:00
Molly Howell
891f5f0e2f
Bug 1724319 - Fix test_handlerService_store.js when new download changes are enabled. r=mtigley
...
Differential Revision: https://phabricator.services.mozilla.com/D125772
2021-09-16 17:42:07 +00:00
Micah Tigley
136593a67b
Bug 1730891 - Set default preferredAction for handling files to save directly to disk on GNOME environments. r=mhowell
...
Differential Revision: https://phabricator.services.mozilla.com/D125687
2021-09-15 17:36:14 +00:00
Mark Banner
14aedbb785
Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 12:09:49 +00:00
Noemi Erli
e0f4b9b5fe
Backed out 2 changesets (bug 1729460) for causing newtab failures CLOSED TREE
...
Backed out changeset 5617839462be (bug 1729460)
Backed out changeset 6d52fde3ee0e (bug 1729460)
2021-09-10 13:14:12 +03:00
Mark Banner
3cfdb5c41a
Bug 1729460 - Change users of defineLazyServiceGetter(s) to use Services.* where appropriate. r=mossop,webdriver-reviewers,extension-reviewers,whimboo,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D124838
2021-09-10 09:38:42 +00:00
Florian Quèze
998adb18ea
Bug 1728760 - require all nsITimerCallback native implementations to also implement nsINamed, r=smaug.
...
Differential Revision: https://phabricator.services.mozilla.com/D124349
2021-09-07 08:01:18 +00:00
Mark Banner
11bfa90d06
Bug 1602940 - Automated replacements to use Services.uuid. r=Gijs,necko-reviewers,preferences-reviewers,kershaw
...
Depends on D124391
Differential Revision: https://phabricator.services.mozilla.com/D124392
2021-09-06 09:53:52 +00:00