The annotated methods were using @JNITarget, which would do the same thing.
However, @ReflectionTarget is clearer (like a good variable name).
proguard.cfg states a class with an annotated member will be kept so we
shouldn't need to worry about not being able to retrieve the class via
reflection.
--HG--
extra : commitid : 9ji4YNIP4GE
extra : rebase_source : 780f1d1dd4fcc95545152d19896db0a376f38d48
This is a clone of @JNITarget and @RobocopTarget.
--HG--
extra : commitid : AhiQ1OmtCY0
extra : rebase_source : 6fb3880e2368a163292b968084991ca965a12211
extra : source : 62dbceeb9f18238ed2725564db03a2a2c6491f94
I previously set this for tablet but didn't (for an unknown reason) set this
for phones as well.
--HG--
rename : mobile/android/base/resources/color-large-v11/action_bar_secondary_menu_item_colors.xml => mobile/android/base/resources/color/action_bar_secondary_menu_item_colors.xml
extra : commitid : 9xV13qVkTCr
extra : rebase_source : f5c310d1ac68096be557a8992ba366bb0c99df0a
This doesn't appear in Fennec builds and I don't know which web apps "quit"
could appear in so I didn't test this in a web app. I can confirm no issues
with a typical Fennec build, however.
--HG--
extra : commitid : LbNepxFEs3P
extra : rebase_source : 687af1c7750c4fb0f3c866dfcaae8291494e146c
This also removes code to set an icon from an addon, which is unused because,
afaik, addons' icons are also hidden. iirc, there was a bug open on whether we
want addons to be able to show icons (e.g. could be used to show status), but
we can reimplement this if that bug is ever decided.
I was not able to test this with an addon that sets an icon but I did test that
the application did not crash with no addons installed.
--HG--
extra : commitid : BI54BWOip3Y
extra : rebase_source : d170349006588ebcecab4817bb5d3388467106e7
On GB devices, ic_menu_new_*tab is in the base menu, unlike the other
configurations, so it stayed on GB.
More complex removals to follow.
I tested this by clicking on all of the base menu items on a Lollipop phone,
KitKat large tablet, and a GB phone.
--HG--
extra : commitid : EBgTEO7y9qt
extra : rebase_source : 30c880c2d36c5f5336af50a5460f3bb1d6578117
Moving speculative connection from CLH to GeckoApp allows us to start
the speculative connection very early in the startup process rather
than later in startup.
One thing we do in the Fennec CLH is to make a speculative connection
based on the URI that's passed in. However, by the time the CLH runs,
we're far along into startup, and the advantage of a speculative
connection is reduced. This patch implements making speculative
connection as a method in GeckoThread, so that Fennec can make a
speculative connection without relying on the Fennec CLH.
Many Gecko operations depend on the profile being available. This
patch adds a PROFILE_READY Gecko state so that we can queue calls
until profile is loaded.
Many calls are associated with a Gecko state when they become available.
For example, calls that only depend on XPCOM become available very early
in startup, at the JNI_READY state. However, calls that depend on JS
components may only be available at the end of startup, at the RUNNING
state.
This patch adds an available state to every queued call, so that calls
can be made as soon as they become available, which is important for
calls like making speculative connections.
The enabled/disabled colors are set via ColorStateLists so the alpha
is unnecessary.
--HG--
extra : commitid : 3u4xoGQlD3E
extra : rebase_source : 0b9868ed14ad54d8de17f2b4cd12185b78e1c22a
This patch has a side effect of changing the color of the forward
button as it animates forward and back, but it's minimal enough
that I'm okay with it, and it cleans up disabled/private state color
management (particularly after the following patch).
--HG--
extra : commitid : B1r30FDcCZv
extra : rebase_source : 1107016d428ac01c6331048b415736b79c634529
Previously, it was available in MenuItemActionBar, which extends
ThemedImageButton.
Additionally, fix a bug about using android:tint when drawableTintList was not
used.
--HG--
extra : commitid : AZiAsNQkD4c
extra : rebase_source : c54b361b27aa6b7d14c030409ad86531a9516549
Jordan Lund
Mantaroh Yoshinaga
Mark Finkle
Myk Melez
Nick Alexander
Fabrice Desré
Allison Naaktgeboren
Michael Comella
Ryan VanderMeulen
Sebastian Kaspari
Martyn Haigh
Ahmed Khalil
Chenxia Liu
Margaret Leibovic
Justin Inouye
Yury Delendik
James Willcox
Jim Chen
Kartikaya Gupta
Jonathan Almeida [:jonalmeida]