Граф коммитов

94 Коммитов

Автор SHA1 Сообщение Дата
Morgan Reschenberg a3da1e4b03 Bug 1735868: Map roles::switch to mozCheckboxAccessible r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D128639
2021-10-15 21:48:29 +00:00
Eitan Isaacson f840fc077c Bug 1726845 - P1: Remove special summary MOX class and update test. r=morgan
The summary class just had a moxExpanded which we already have in mozAccessible.
I think the former was added before the latter was generalized for aria-expanded usage.

Differential Revision: https://phabricator.services.mozilla.com/D123516
2021-08-24 22:22:25 +00:00
Morgan Reschenberg 5c59e82313 Bug 1716828: Notify VoiceOver of announcements from a11yUtils with AXAnnouncementRequested r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D119300
2021-07-15 19:12:09 +00:00
Eitan Isaacson 4fc2c36ea8 Bug 1714390 - P5: Use static aria_* atoms for aria attributes. r=Jamie
ATK, Windows and XPCOM expect aria attribute keys to be stripped of
their aria- prefix. We should still store the item using the aria_ atom
and then strip the prefix when converting the key to a string.

Differential Revision: https://phabricator.services.mozilla.com/D116786
2021-06-10 23:07:07 +00:00
Eitan Isaacson 6e49732365 Bug 1693597 - P1: Rename Accessible to LocalAccessible. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D105670
2021-02-19 23:14:32 +00:00
Markus Stange 9bc888af4a Bug 1692391 - Replace NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NIL with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(nil). r=haik
This patch was generated automatically, using the following commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NIL' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NIL/NS_OBJC_END_TRY_BLOCK_RETURN(nil)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104959
2021-02-16 22:55:21 +00:00
Markus Stange 56051da2d0 Bug 1692391 - Replace the NS_OBJC_BEGIN/END_TRY_ABORT_BLOCK_NSRESULT macros with the functionally identical NS_OBJC_BEGIN/END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE). r=haik
This patch was generated with the commands:

```
rg -l 'NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_BEGIN_TRY_BLOCK_RETURN/g'
rg -l 'NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT' . | xargs sed -i '' -e 's/NS_OBJC_END_TRY_ABORT_BLOCK_NSRESULT/NS_OBJC_END_TRY_BLOCK_RETURN(NS_ERROR_FAILURE)/g'
```

Differential Revision: https://phabricator.services.mozilla.com/D104957
2021-02-16 22:55:20 +00:00
Eitan Isaacson 8c842a59e3 Bug 1692523 - P1: Prefix local heirarchy functions with 'Local'. r=Jamie
Parent -> LocalParent
GetChildAt -> LocalChildAt
FirstChild -> LocalFirstChild
LastChild -> LocalLastChild
NextSibling -> LocalNextSibling
PrevSibling -> LocalPrevSibling

Differential Revision: https://phabricator.services.mozilla.com/D105034
2021-02-16 20:05:10 +00:00
Morgan Reschenberg b6cdc22e2b Bug 1680840: Introduce table style changed event to mac platform, update caching r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D103698
2021-02-04 20:50:12 +00:00
Morgan Reschenberg 62aed9ef20 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-02 21:30:58 +00:00
Butkovits Atila 2af3edc6b9 Backed out 2 changesets (bug 1688730) for causing mochitest failures. CLOSED TREE
Backed out changeset 677c17ec48ea (bug 1688730)
Backed out changeset a7d0770117c8 (bug 1688730)
2021-02-02 02:04:28 +02:00
Morgan Reschenberg 876affb062 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 20:23:23 +00:00
Butkovits Atila e13215fdec Backed out 2 changesets (bug 1688730) for causing build bustage on mozTableAccessible.mm. CLOSED TREE
Backed out changeset bd6d78d36cee (bug 1688730)
Backed out changeset dd03939b850e (bug 1688730)
2021-02-01 21:44:02 +02:00
Morgan Reschenberg 3b5f7255b1 Bug 1688730: Cache table layout status on mac, invalidate on reorder, attr changed r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D102994
2021-02-01 17:54:13 +00:00
Eitan Isaacson 135c36619d Bug 1686995 - Add AXTextSelectionDirection and AXTextSelectionGranularity to text selection events. r=morgan
.. and also add AXTextSelectionChangedFocus and AXTextStateSync when needed.

Differential Revision: https://phabricator.services.mozilla.com/D102509
2021-01-22 21:12:56 +00:00
Eitan Isaacson 720902efa2 Bug 1686839 - Apply MustPrune dynamically and not at creation time. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D101853
2021-01-19 17:15:05 +00:00
Morgan Reschenberg c19d6d89b4 Bug 1682865: Map roles::EDITCOMBOBOX to mozTextAccessible r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D101407
2021-01-11 22:04:13 +00:00
Eitan Isaacson 4537ab3655 Bug 1681909 - P2: Implement post filter for non-e10s case. r=morgan
Introducing this as a separate patch to simplify this changeset and first introduce a straightforward-ish implementation.

Differential Revision: https://phabricator.services.mozilla.com/D100731
2021-01-05 20:35:35 +00:00
Eitan Isaacson c2532de498 Bug 1680329 - Add AXTextStateChangeType to selection events. r=morgan
It seems that VoiceOver depends on that property to know if a selection is be extended or moved. This manifests in several places in Slack when the user combines VO navigation with Slack's keyboard navigation.

Also changed where we retrieve the editable ancestor to simplify the notification dispatching block.

Differential Revision: https://phabricator.services.mozilla.com/D100452
2021-01-04 22:37:46 +00:00
Marco Zehe 73147045b1 Bug 1678015 - Expose assertive live region attributes for ARIA alerts on Mac, r=Jamie,eeejay
This is done via an ifdef in the ARIAMap. Provisions, however, are there to simply remove the ifdef and if clauses from here and the test file to enable this on other platforms once alert double-speaking and other unwanted side effects are fixed on said platforms.

Differential Revision: https://phabricator.services.mozilla.com/D97584
2020-12-02 20:54:41 +00:00
Morgan Reschenberg 944f8f156b Bug 1649711: Map rich list box item to selectable acc class r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D96906
2020-11-16 18:27:26 +00:00
Eitan Isaacson 673de157fa Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Depends on D96293

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-16 20:16:52 +00:00
Eitan Isaacson df739e1daf Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-16 20:16:33 +00:00
Butkovits Atila 119d8f1aa7 Backed out 4 changesets (bug 1198336) for bustage on rules.mk. CLOSED TREE
Backed out changeset 26ad5bb8e1ed (bug 1198336)
Backed out changeset 852dc98e8cf5 (bug 1198336)
Backed out changeset 823511f4191b (bug 1198336)
Backed out changeset 67f5a42ed170 (bug 1198336)
2020-11-13 11:06:12 +02:00
Eitan Isaacson b538315d73 Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Depends on D96293

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-13 03:49:11 +00:00
Eitan Isaacson ae837aea6e Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-13 04:04:45 +00:00
Morgan Reschenberg e45400e5b3 Bug 1644810: Implement accessible subclasses for AXOutline and AXOutlineItem r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D96074
2020-11-12 06:16:58 +00:00
Csoregi Natalia 6ddec72329 Backed out 4 changesets (bug 1198336) for causing leaks. CLOSED TREE
Backed out changeset faa35ea77d35 (bug 1198336)
Backed out changeset 821f94bae182 (bug 1198336)
Backed out changeset ee78c1e8cc3b (bug 1198336)
Backed out changeset 2c56e36b869d (bug 1198336)
2020-11-12 01:46:52 +02:00
Eitan Isaacson 29037361ba Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-11 21:12:46 +00:00
Eitan Isaacson 4757842fcf Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-11 21:12:18 +00:00
Butkovits Atila 7c83560854 Backed out 4 changesets (bug 1198336) for bustages on rules.mk. CLOSED TREE
Backed out changeset 8399406e5f2e (bug 1198336)
Backed out changeset 7a2dbe67b6a6 (bug 1198336)
Backed out changeset fd45661dd659 (bug 1198336)
Backed out changeset 68cf7e4b16f2 (bug 1198336)
2020-11-11 02:40:30 +02:00
Eitan Isaacson eb929d7c1e Bug 1676509 - Remove AXTitle from list item groups. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D96632
2020-11-10 23:14:59 +00:00
Eitan Isaacson 75c203c933 Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-10 23:07:45 +00:00
Eitan Isaacson 85740d386d Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-10 23:07:20 +00:00
Eitan Isaacson cbc4bcfaba Bug 1675292 - Add 'application' root group when body gets role of application. r=morgan
Both chrome and safari preserve the AXWebArea with no subroles, and apply the application subrole to the root group. Not doing so apparently breaks web applications badly.

Differential Revision: https://phabricator.services.mozilla.com/D96475
2020-11-10 17:49:01 +00:00
smolnar 17d3157e82 Backed out 1 changesets (bug 1675292) for causing failures in browser_roles_elements. CLOSED TREE DONTBUILD
Backed out changeset f4cdad3fae02 (bug 1675292)
2020-11-10 09:12:15 +02:00
Eitan Isaacson 6ac3c7496b Bug 1675292 - Add 'application' root group when body gets role of application. r=morgan
Both chrome and safari preserve the AXWebArea with no subroles, and apply the application subrole to the root group. Not doing so apparently breaks web applications badly.

Differential Revision: https://phabricator.services.mozilla.com/D96475
2020-11-09 23:53:00 +00:00
Morgan Reschenberg c5126eab79 Bug 1661504: Introduce MOXLandmarkAccessible class and AXLandmarkSearchKey r=eeejay"
Differential Revision: https://phabricator.services.mozilla.com/D88445
2020-08-31 18:36:48 +00:00
Eitan Isaacson 2a6f71babd Bug 1660906 - Introduce .clang-format file for Objective C rules. r=morgan
I also altered the mode line in all the file headers so that editors use the correct syntax features.

Differential Revision: https://phabricator.services.mozilla.com/D88081
2020-08-25 21:40:32 +00:00
Eitan Isaacson 80f99b2bcb Bug 1654603 - Support text entry in contenteditable nested nodes. r=morgan
VoiceOver expects text value change events to originate from the editable ancestor.

Differential Revision: https://phabricator.services.mozilla.com/D85050
2020-07-27 22:20:06 +00:00
Eitan Isaacson 70a126786a Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-27 21:08:20 +00:00
Mihai Alexandru Michis 13e26846d7 Backed out changeset 47667fbae734 (bug 1654679) for causing failures in browser_text_input.js 2020-07-24 03:16:52 +03:00
Eitan Isaacson fd819b55c1 Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 21:31:35 +00:00
Dorel Luca 784df221cc Backed out changeset 8848caa5b125 (bug 1654679) for Browser-chrome failures in accessible/tests/browser/mac/browser_text_input.js. CLOSED TREE 2020-07-23 20:44:22 +03:00
Eitan Isaacson c4c117984b Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 16:29:19 +00:00
Bogdan Tara c61d07ee89 Backed out changeset 290c72f07e0c (bug 1654679) for es lint failure on browser_text_input.js CLOSED TREE 2020-07-23 09:05:54 +03:00
Eitan Isaacson 089db2c536 Bug 1654679 - Add selected text marker range to text selection changed events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D84616
2020-07-23 04:52:00 +00:00
Eitan Isaacson 42dcf89b84 Bug 1653421 - Part 4: Pass data with text value change events. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D84056
2020-07-21 23:03:00 +00:00
Eitan Isaacson 66653fbad1 Bug 1653421 - Part 1: Refactor AccessibleWrap event handling. r=morgan
I split the switch statement into two: the first switch determines the
MOX target accessible. The second one does all the rest. This makes it more
readable and scalable when we add more events that need to be accompanied with
data.

Differential Revision: https://phabricator.services.mozilla.com/D84053
2020-07-21 23:02:53 +00:00
Eitan Isaacson 8b130be2bb Bug 1226473 - Support AXSelectedTextMarkerRange. r=morgan
To do this well we need to cache the text selection in the top level process.

Differential Revision: https://phabricator.services.mozilla.com/D82111
2020-07-06 17:32:45 +00:00