While not related, it turns out this test was opted in by ourselves,
while it's practically useless. Recent autoconf documentation says it's
obsolescent, and even autoconf 2.13 documentation said with "recent
versions of the GNU C compiler", the issue it's detecting "is becoming
a less prevalent problem". Recent as of 20 years ago.
Differential Revision: https://phabricator.services.mozilla.com/D18054
--HG--
extra : moz-landing-system : lando
Iteration becomes wrong when ImageBridgeParent::GetInstance() fails in NotifyImageComposites().
Differential Revision: https://phabricator.services.mozilla.com/D18172
--HG--
extra : moz-landing-system : lando
TODO: the first lazy tab is not moved using gBrowser.adoptTab, so it's still unlazified.
Differential Revision: https://phabricator.services.mozilla.com/D17084
--HG--
extra : moz-landing-system : lando
After the fix for bug 646216, we no longer create divs with no text and only a br element for a line break. This breaks blank lines in contentEditables such as Gmail.
To fix, always create accessibles for divs if such a div contains a br element either as its first or last child.
Differential Revision: https://phabricator.services.mozilla.com/D18074
--HG--
extra : moz-landing-system : lando
There can be a slight delay (in rapport with actually loading the page) until
the ContentBlockingEvent is received.
To account for this, we'll use an overly generous 500ms timeout before
actually checking if we have the right tracking status.
Differential Revision: https://phabricator.services.mozilla.com/D17344
--HG--
extra : moz-landing-system : lando
Summary:
Currently, if a test fails to clean up a service worker, we report every test
that runs after it as having failed to clean up their service workers as well.
That fills up the logs and makes it harder to figure out what's going on. This
patch removes the left-over service workers automatically, reducing the log
output and pointing the finger more precisely to the failing test.
I believe this patch is correct because afterCleanup is responsible for
continuing the test run by calling a function (either
`parentRunner.testFinished` or `SimpleTest.showReport`). Therefore, we can
safely make it async and wait if we need to clean up after a poorly-written
test.
Reviewers: asuth
Reviewed By: asuth
Bug #: 1517406
Differential Revision: https://phabricator.services.mozilla.com/D15638
--HG--
extra : rebase_source : 6ff8033ab2ea291a57ae717d03575feed5820899
Summary:
This test first creates a service worker and then an iframe. It expects the
iframe's first load to be through the network (and for the page's script to
fail to load). Once the page is set up and controlled by the SW, it reloads it
(a soft reload) and the script load is intercepted by the service worker and
we load a script that calls back into the test. However, there is currently no
guarantee that the service worker won't activate before the iframe load and
end up controlling the first load of the iframe.
With this patch, we delay the service worker's activation until we start
loading the iframe, allowing the first load to always be uncontrolled, thereby
resolving the race.
Reviewers: asuth
Reviewed By: asuth
Bug #: 1517406
Differential Revision: https://phabricator.services.mozilla.com/D15637
--HG--
extra : rebase_source : ff63b131b1a395289cda85ec4b46daa3022b08b4
Summary:
Most of these tests pass now, so enable them and only disable the tests that
don't pass. This should make driving these tests to all passing easier to do
and prevent regressions.
Reviewers: asuth
Reviewed By: asuth
Bug #: 1517406
Differential Revision: https://phabricator.services.mozilla.com/D15636
--HG--
extra : rebase_source : 252502cb5d8d43fd8a2e7b50a97ea4d64e2ef07d
Summary:
This test listens for an observer service notification from the
`ServiceWorkerManager`, but with parent-intercept on, it listens in the wrong
process. This uses the magic of SpecialPowers to listen in the correct
process.
Unfortunately, this test still fails because it leaks.
Reviewers: asuth
Reviewed By: asuth
Bug #: 1517406
Differential Revision: https://phabricator.services.mozilla.com/D15635
--HG--
extra : rebase_source : 7aa62832c7c577275c8eaa5fd2146885e393fc6b
Summary:
The push notifier needs to proxy its calls to the proper process in order to
notify service workers. With parent-intercept enabled, that means making sure
we notify in the parent and without it, that we notify in the content process.
Fortunately, we already have to do this proxying for the observer
notifications, so we can just piggyback on top of that code to make things
work for service workers.
Reviewers: asuth
Reviewed By: asuth
Bug #: 1517406
Differential Revision: https://phabricator.services.mozilla.com/D15634
--HG--
extra : rebase_source : a29216f3a6638592a784e7e830fe9f7842cce7e9
This code has gotten tweaked a number of times over the years to support
new log formats, but there's always the risk that a tweak will break old
log formats. So this patch adds a small test function that can be run by
anybody making changes to ensure old logs still parse fine. A few
current log samples are tested thusly.
Differential Revision: https://phabricator.services.mozilla.com/D15576
--HG--
extra : moz-landing-system : lando
glBlitFramebuffer ignores glColorMask, unlike glClear, so we have to do
a fix-up.
Eventually we should drop mNeedsFakeNoAlpha, though.
Differential Revision: https://phabricator.services.mozilla.com/D17717
--HG--
extra : moz-landing-system : lando
Make toolkit/components/passwordmgr/test/test_xml_load.html work with e10s
Differential Revision: https://phabricator.services.mozilla.com/D17715
--HG--
rename : toolkit/components/passwordmgr/test/test_xml_load.html => toolkit/components/passwordmgr/test/mochitest/test_xml_load.html
extra : moz-landing-system : lando
* Added browser_private_window.js - which is a port of chrome/privbrowsing_perwindowpb.html
* Moved onload/form submit from the form documents to the test via ContentTask.spawn
* The test which verifies autofill doesnt work in private windows, but autocomplete does - is disabled for now and bug 1523777 filed to re-enable it.
Differential Revision: https://phabricator.services.mozilla.com/D17676
--HG--
extra : moz-landing-system : lando
It turns out that setting the parent link on a clip chain is no longer
needed (and probably hasn't been since WR started applying a stacking
context's clip to the SC's contents). In fact it can produce incorrect
behaviour in some cases, because it doesn't match the semantics of
Gecko's clip chains. This removes the parent link on the Gecko side and
adds a test for this scenario.
Differential Revision: https://phabricator.services.mozilla.com/D18101
--HG--
extra : moz-landing-system : lando
The API to create a sticky spatial node doesn't allow us to set a clip
chain that will apply to all the contents of the sticky node. This means
that when the ClipManager sets up the clip state for the sticky node,
the clip chain for it is dropped. Everything still works currently
because the contents of the sticky node have their own clip chains whose
parent link will include the sticky node's clip chain. However, in the
next patch we're going to sever that parent link to fix other issues,
and so we will break this mechanism. This patch fixes it up by
explicitly applying the sticky node's clip chain to the stacking context
that contains all the sticky contents. This ensures all those items pick
up the clip chain.
Differential Revision: https://phabricator.services.mozilla.com/D18100
--HG--
extra : moz-landing-system : lando
This gcc 4.8.2 workaround (from bug 1219050) is no longer needed because Firefox currently requires gcc 6.1 or later (as of bug 1444274).
Differential Revision: https://phabricator.services.mozilla.com/D5506
--HG--
extra : moz-landing-system : lando
Fixes leak where the return value of GetManifestContents in updater.cpp is not freed
Fixes leak where the return value of get_quoted_path in updater.cpp is not freed
Fixes leak in nsUpdateDriver.cpp ApplyUpdate
With these leaks fixed the UI tests that stage updates can run on Linux asan
Differential Revision: https://phabricator.services.mozilla.com/D17910
--HG--
extra : moz-landing-system : lando
This includes deleting several unused functions. Our own code does a better job
of using the preferred platform APIs for random numbers.
Differential Revision: https://phabricator.services.mozilla.com/D18120
--HG--
extra : moz-landing-system : lando
There's a strong cycle of references between SamplesWaitingForKey and
CDMProxy that does not get cleared unless keys actually come in. This
causes a leak. One way to avoid that leak is to clear the proxy
reference when the things holding the SamplesWaitingForKey is shut
down.
Differential Revision: https://phabricator.services.mozilla.com/D17960
--HG--
extra : moz-landing-system : lando
Now that everything is lined up nicely, we don't need those anymore.
We can fill cargo-linker.bat with HOST_LINKER and HOST_LINKER_LIBPATHS,
which, unfortunately, can't be used as is, so we add a variant for
substitution in .bat files.
Differential Revision: https://phabricator.services.mozilla.com/D18034
--HG--
extra : moz-landing-system : lando
Bug 730495 broke them by moving the code to another directory without
moving the corresponding #define, but it also fixed why this was
disabled in some configurations so we can now just enable when
MOZ_MEMORY is defined (jemalloc used).
Differential Revision: https://phabricator.services.mozilla.com/D18049
--HG--
extra : moz-landing-system : lando
The addition of the Carbon.h include to CreateAppData.cpp is to ensure that
The OSX API headers are used before conflicting symbols are declared in the
mozilla namespace.
Differential Revision: https://phabricator.services.mozilla.com/D16718
--HG--
rename : toolkit/xre/nsCommandLineServiceMac.cpp => toolkit/xre/nsCommandLineServiceMac.mm
extra : moz-landing-system : lando
But enable it in all tests because a lot of them rely on using it in the
style="" attribute for example, or in inline stylesheets, which will no longer
parse this (even in chrome documents), and we don't want to rewrite all the XUL
and XBL tests.
Differential Revision: https://phabricator.services.mozilla.com/D18027
--HG--
extra : moz-landing-system : lando
Mike Hommey
Oana Pop Rus
Narcis Beleuzu
Glenn Watson
sotaro
Matt Woodrow
Oriol Brufau
Marco Zehe
Petru Lingurar
Benjamin Bouvier
Andrea Marchesini
Blake Kaplan
Steve Fink
Kartikaya Gupta
Jeff Gilbert
prathiksha
Sam Foster
Robert Strong
Chris Peterson
Michael Kaply
Alex Gaynor
Andrew McCreight
Eric Rahm
Dave Townsend
Daniel Varga
Dorel Luca
Eric Faust
Ehsan Akhgari
Emilio Cobos Álvarez
Brian Hackett
Myk Melez
Tom Prince