Mats Palmgren
357e4b9560
bug 1368547 part 2 - Remove nsFrameManager/PresShell methods dealing with placeholders and introduce a nsIFrame::GetPlaceholderFrame() convenience method. r=jfkthame
...
MozReview-Commit-ID: GBUiUBqJxhQ
2017-05-31 21:29:49 +02:00
Mats Palmgren
2cecf134ac
bug 1368547 part 1 - Remove nsFrameManagerBase::mPlaceholderMap and store the placeholder on a frame property on the out-of-flow instead. r=jfkthame
...
MozReview-Commit-ID: 6AOxc2XgtO1
2017-05-31 21:29:49 +02:00
Daniel Holbert
74687b05c2
Bug 1361086: Simplify UndisplayedMap::GetListFor/GetOrCreateListFor to take nsIContent* rather than nsIContent**. r=emilio
...
This patch shouldn't affect behavior -- it just takes a latent opportunity for
simplification and removes an unused layer of indirection. These functions were
set up to look like they took outparams, but none of the callers were using the
value left in the outparam.
MozReview-Commit-ID: LaL7YiyVYS2
--HG--
extra : rebase_source : 28466d6ab36da2e3609e7ed0fdb51618e652c7f7
2017-05-01 09:57:55 -07:00
Emilio Cobos Álvarez
e44543aad4
Bug 1360241: Devirtualize nsIFrame::GetType. r=heycam
...
MozReview-Commit-ID: 5Nzhyta5Hle
--HG--
extra : rebase_source : c2e9d4bfb9239f5e851d110cd7dff98c1e1a8d8b
2017-04-30 17:30:08 +02:00
Emilio Cobos Álvarez
c8a5bc5165
Bug 1296516: Convert UndisplayedMap to a typed hashtable. r=heycam
...
MozReview-Commit-ID: g54ekayP2y
2017-03-20 22:28:15 +01:00
Bobby Holley
e3456a507a
Bug 1343388 - Don't write to undisplayed contents map cache during servo traversal. r=emilio
...
MozReview-Commit-ID: 732bV0X80Gk
2017-02-28 18:07:48 -08:00
Emilio Cobos Álvarez
b903e8dcf2
Bug 1341083: Don't fall back to reframing with display: contents. r=heycam
...
MozReview-Commit-ID: KD3QBiU7M5f
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-02-25 19:15:43 +01:00
Emilio Cobos Álvarez
2cbefa7db5
Bug 1341083: Implement dynamic restyling for display: contents. r=heycam
...
MozReview-Commit-ID: KimTU2j4V4p
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-02-25 19:15:38 +01:00
Emilio Cobos Álvarez
d449269afd
Bug 1329200: Remove unused FrameManager global generation counter. r=xidorn
...
MozReview-Commit-ID: AXkaZYxpK2y
--HG--
extra : rebase_source : a02753e044fb89d4ea6a476e4b8f3e9fc0e4eb0c
2017-01-06 16:03:41 +01:00
Mats Palmgren
c57b9fd7a3
Bug 731096 - Make nsFrameManager::RegisterPlaceholderFrame infallible. r=dholbert
2017-01-04 00:56:19 +01:00
William Chen
eaa69e20b2
Bug 1274539 - Use GetParentCrossingShadowRoot() instead of GetParent() in GetStyleContextInMap when looking up undisplayed nodes. r=dbaron
...
--HG--
extra : rebase_source : 99e0430bf0450047a18ee4e6376360a201b53a25
2016-05-26 19:52:11 -07:00
Kyle Huey
faf4b58dd6
Bug 1261351: Look past ShadowRoots when looking for the parent for the UndisplayedMap. r=dbaron
...
--HG--
extra : rebase_source : b4cac0077527a298cd53fc252b0aa32ee5372f81
2016-06-07 14:09:22 -07:00
Jonathan Watt
9480920b04
Bug 1263785 - Kill off the deprecated nsINode::GetCurrentDoc. r=baku
2016-03-31 12:46:32 +01:00
Nicholas Nethercote
a2f068b2ad
Bug 1253085 - Remove the |PLDHashTable*| argument from PLDHash{HashKey,MatchEntry}. r=froydnj.
...
This is easy because it's never needed.
--HG--
extra : rebase_source : 78830dab41c40a1544fa55fc69ca9c1c6709d767
2016-03-16 15:33:44 +11:00
Chris H-C
550ae0a515
Bug 1249664 - Make stateful frames responsible for their own keys r=dbaron
...
nsFrameManager::CaptureFrameStateFor generates keys for stateful frames that
only take into account the document and element. This precluded saving pieces
of information coming from different frames responsible for the same element.
MozReview-Commit-ID: 29x3Gj66wAy
--HG--
extra : rebase_source : 9f6fc24ce88009b31dae9fc37bb2187cad8164f2
2016-03-10 10:14:37 -05:00
Cameron McCormack
edcec9eefe
Bug 1223228 - Remove unused nsFrameManagerBase::mStyleSet. r=dholbert
2015-11-10 12:27:47 +11:00
Nicholas Nethercote
647b520991
Bug 1201135 - Rename pldhash.{h,cpp} to PLDHashTable.{h,cpp}. r=mccr8.
...
--HG--
rename : xpcom/glue/pldhash.cpp => xpcom/glue/PLDHashTable.cpp
rename : xpcom/glue/pldhash.h => xpcom/glue/PLDHashTable.h
extra : rebase_source : 06b9d30db96ed78500fd44d9c0b51609103508a3
2015-09-15 20:49:53 -07:00
Nicholas Nethercote
2ee4fd783b
Bug 1121760 (part 6) - Move all remaining PL_DHash*() functions into PLDHashTable. r=poiru.
...
--HG--
extra : rebase_source : 3cdc975507170d783b02d70f7c7d95c6bf2e1bcd
2015-09-14 14:23:47 -07:00
Nicholas Nethercote
59683492e5
Bug 1121760 (part 3) - Remove PL_DHashTableRemove(). r=poiru.
...
--HG--
extra : rebase_source : c34d693de4aca45f2ea05c2767c8b1007c89df29
2015-09-14 14:23:24 -07:00
Nicholas Nethercote
479244f7c9
Bug 1121760 (part 2) - Remove PL_DHashTableAdd(). r=poiru.
...
--HG--
extra : rebase_source : 41eb939bfb5c925cba58b1af57abce9a4e5fdb30
2015-09-14 14:23:12 -07:00
Nicholas Nethercote
fcfdd8f54b
Bug 1121760 (part 1) - Remove PL_DHashTableSearch(). r=poiru.
...
--HG--
extra : rebase_source : 770e1f49a451ecbadd778e071b204611e27cf701
2015-05-21 00:34:25 -07:00
Nicholas Nethercote
0eacf28b46
Bug 1174631 (part 4) - Replace nsFrameManager's uses of PL_DHashTableEnumerate() with PLDHashTable::Iterator. r=dholbert.
...
--HG--
extra : rebase_source : a328e9bceffb9940108fdebca8cca7c70e9cea58
2015-06-16 21:09:39 -07:00
Nicholas Nethercote
383a496bf6
Bug 1170416 (part 5) - Remove PLDHashTable::IsInitialized(). r=froydnj.
...
|mOps| is always non-null now, and there's no longer any distinction between
and uninitialized and initialized table. Yay.
--HG--
extra : rebase_source : 3d1fb72aee4dd21ff20db0ff3166d4e932ade897
2015-05-20 21:23:55 -07:00
Nicholas Nethercote
e849e6588b
Bug 1170416 (part 3) - Remove the PLDHashTable2 typedef. r=froydnj.
...
--HG--
extra : rebase_source : 9510ea47204fffa163cac43aeaaac6ae1ad80419
2015-05-19 16:46:17 -07:00
Nicholas Nethercote
d36fc10f20
Bug 1168007 (part 2) - Use PLDHashTable2 in nsFrameManagerBase. r=froydnj.
...
--HG--
extra : rebase_source : 2ff5ea3eab7be1a894af595c746aee6dec2e249b
2015-05-18 19:24:34 -07:00
Nicholas Nethercote
3a7b0a9f57
Bug 1131901 (part 1) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : 526d96ab65e4d7d71197b90d086d19fbdd79b7b5
2015-02-02 14:48:58 -08:00
Nicholas Nethercote
63e3218e4c
Back out changesets 2fcef6b54be7, 2be07829fefc, 66dfe37b8532, df3fcd2be8fd, 0a436bce77a6 (bug 1050035) for causing intermittent crashes and assertion failures.
...
--HG--
extra : rebase_source : eb30be83c3143c6c203585a80a18f180025efaba
2015-02-10 14:39:49 -08:00
Nicholas Nethercote
b5913e0b3d
Bug 1050035 (part 4) - Make PL_DHashTableAdd() infallible by default, and add a fallible alternative. r=froydnj.
...
I kept all the existing PL_DHashTableAdd() calls fallible, in order to be
conservative, except for the ones in nsAtomTable.cpp which already were
followed immediately by an abort on failure.
--HG--
extra : rebase_source : eeba14d732077ef2e412f4caca852de6b6b85f55
2015-02-02 14:48:58 -08:00
Nicholas Nethercote
3163cfc2c1
Bug 1124973 (part 2) - Introduce PL_DHashTableSearch(), and replace most PL_DHashTableLookup() calls with it. r=froydnj.
...
It feels safer to use a function with a new name, rather than just changing the
behaviour of the existing function.
For most of these cases the PL_DHashTableLookup() result was checked with
PL_DHASH_ENTRY_IS_{FREE,BUSY} so the conversion was easy. A few of them
preceded that check with a useless null check, but the intent of these was
still easy to determine.
I'll do the trickier ones in subsequent patches.
--HG--
extra : rebase_source : ab37a7a30be563861ded8631771181aacf054fd4
2015-01-22 21:06:55 -08:00
Nicholas Nethercote
8bd1f6f072
Bug 1123151 (part 2) - Add PLDHashTable::IsInitialized(). r=froydnj.
...
This encapsulates most of the uses of PLDHashTable::ops.
--HG--
extra : rebase_source : 7760ce8e46a37e87dcfe590e809a21df01fe510f
2015-01-19 16:11:34 -08:00
Nicholas Nethercote
bd573c9b9c
Bug 1123151 (part 1) - Set PLDHashTable::ops consistently. r=froydnj.
...
Currently the setting of PLDHashTable::ops is very haphazard.
- PLDHashTable has no constructor, so it's not auto-nulled, so lots of places
null it themselves.
- In the fallible PLDHashTable::Init() function, if the entry storage
allocation fails we'll be left with a table that has |ops| set -- indicating
it's been initialized -- but has null entry storage. I'm not certain this can
cause problems but it feels unsafe, and some (but not all) callers of Init()
null it on failure.
- PLDHashTable does not null |ops| in Finish(), so some (but not all) callers
do this themselves.
This patch makes things simpler.
- It adds a constructor that zeroes |ops|.
- It modifies Init() so that it only sets |ops| once success is ensured.
- It zeroes |ops| in Finish().
- Finally, it removes all the now-unnecessary |ops| nulling done by the users
of PLDHashTable.
--HG--
extra : rebase_source : bb34979c218d152562a2f9c7e5215256c111cc5b
2015-01-19 16:01:24 -08:00
Nicholas Nethercote
69fe655b04
Bug 1121304 (part 2, attempt 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
...
--HG--
extra : rebase_source : bc119bd0d3b6944e8c5a000950e0c4052cb70aef
2015-01-14 14:35:56 -08:00
Phil Ringnalda
e39f0adeca
Backed out 2 changesets (bug 1121304) for consistent b2g hangs in webgl-color-test.html?frame=1&__&preserve&premult&_____
...
Backed out changeset 20651ac19549 (bug 1121304)
Backed out changeset 758afec77c95 (bug 1121304)
2015-01-14 22:02:23 -08:00
Nicholas Nethercote
e9735966fa
Bug 1121304 (part 2) - Remove PLDHashTableOps::{alloc,free}Table. r=froydnj.
2015-01-14 14:35:56 -08:00
Nicholas Nethercote
47221bc7f9
Bug 1120476 (part 4) - Remove PLDHashTableOps::finalize. r=froydnj.
...
--HG--
extra : rebase_source : b14dda8cdd5cd896d1e32950e38b2a9f7da4d99e
2015-01-13 19:02:35 -08:00
Nicholas Nethercote
c7538c9776
Bug 1120476 (part 3) - Remove PLDHashTable::data. r=froydnj.
...
--HG--
extra : rebase_source : 24d10af3dbce3ada5252503bc80bb1a4e31bc1c9
2015-01-13 16:42:13 -08:00
Michael Pruett
411a94b05a
Bug 1118024 - Use new PL_DHashTable{Add,Lookup,Remove} functions. r=nfroyd
2015-01-05 20:27:28 -06:00
Mats Palmgren
994ddfd821
Bug 907396 - Frame manager support for display:contents. r=bzbarsky
2014-11-20 18:24:09 +00:00
Ehsan Akhgari
60360fc645
Bug 1060985 - Fix more bad implicit constructors in layout; r=roc
2014-08-31 23:36:37 -04:00
Nicholas Nethercote
a7cf4142b4
Bug 1050009 - Initialize pldhash tables with a length, not a capacity. r=roc.
...
* * *
imported patch rm-dummy-params
--HG--
extra : rebase_source : c25987eb11bae197218d5fc53b77def19afa36ac
2014-08-06 06:31:21 -07:00
Robert O'Callahan
2a92625af7
Bug 1015664
. Part 2: Remove some NS_HIDDEN usage. r=bsmedberg
2014-06-03 00:08:24 +12:00
Robert O'Callahan
cbb8fdebfc
Bug 1015664
. Part 1: Remove NS_HIDDEN_() usage. r=bsmedberg
2014-06-03 00:08:21 +12:00
Mats Palmgren
f08f841973
Bug 1015781 - part 1+2, Make the SetInitialChildList/AppendFrames/InsertFrames/RemoveFrame methods return void (scripted change). Remove code handling the return values. r=roc
2014-05-28 19:36:58 +00:00
Mats Palmgren
05d8c81f4e
Bug 508665 - part 7, Require a nsContainerFrame* for aParent in nsFrameManager methods. r=roc
2014-05-24 22:20:40 +00:00
Mats Palmgren
a6feda0f22
Bug 508665 - part 1, Change the signature of SetParent/GetParent from nsIFrame* to nsContainerFrame*. r=roc
2014-05-24 22:20:39 +00:00
Andrew McCreight
0353960345
Bug 962608 - Make PL_DHashTableInit infallible by default. r=briansmith,bsmedberg,ehsan,froydnj,jduell,jfkthame,roc,smaug
2014-02-27 10:04:09 -08:00
William Chen
ad649152bc
Bug 929885 - Implement web components ShadowRoot style sheet behavior. r=mrbkap
2013-12-02 02:26:12 -08:00
Nathan Froyd
b438a08286
Bug 940170 - part 1 - constify PLDHashTableOps in layout/; r=bz
2013-11-18 21:51:48 -05:00
Birunthan Mohanathas
e3709383ec
Bug 784739 - Switch from NULL to nullptr in layout/; r=ehsan
...
--HG--
extra : rebase_source : 0d0d9e11be9d39e4457bddd0bac7e19a50b91b0b
2013-10-08 14:47:21 -04:00
Ehsan Akhgari
2621b190f1
Bug 906790 - Minimize layout/base #includes; r=roc
2013-08-19 18:55:18 -04:00