498185f3f0
Bug 619273 - Move the selection state bit from frames to content nodes. r=smaug
2011-12-20 10:15:41 +01:00
92064e6d3f
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
cb8c38f547
Bug 691824 - Return the principal child list for outer table frames only once; r=roc
2011-10-06 18:03:45 -04:00
4b84fe41d5
Bug 659828 - Part 1: Apply table margins to the outer table frame instead of the inner table frame (also fixes bug 87277); r=dbaron
...
Outer table frames act as CSS2.1 table wrapper boxes. We used to lay them out
without taking their margins into the account, which meant that their width was
always equal to the available width. This breaks horizontal positioning of
absolutely positioned kids of a table frame.
The main purpose of this patch is to apply the margins of tables to their outer
frame, instead of the inner frame. This means that the inner table frame will
always have a zero margin, which means that a lot of the stuff which used to
rely on the fact that table margins are applied to the inner frame need to
change.
In particular, in order to get the computed margins of a table, we used to query
the inner table frame, and this patch corrects that. Also, when shrink wrapping
tables, we used to not take the margins of the inner table frame into account,
which is fixed by this patch too. nsBlockReflowState::
ComputeReplacedBlockOffsetsForFloats also needed to be changed to read the
margin values from the outer frame too.
Also, as part of this patch, we start to respect the CSS2.1 margin model for
captions on all sides. This means that in particular, the top/bottom margins on
the top-outside and bottom-outside captions will not be collapsed with the
top/bottom margins of the table, and that the margins of the caption element
contribute to the width and height of the outer table frame. The
427129-table-caption reftest has been modified to match this new behavior.
Another side effect of this bug is fixing bug 87277, and the reftests for that
bug are marked as passing in this patch.
2011-05-31 19:02:56 -04:00
2b29cd6201
Bug 10209 - Part 6: Implement the CSS "containing block" concept correctly as a binary relation, as opposed to a unary relation; r=bzbarsky
2011-05-12 00:04:30 -04:00
59e7e67254
Bug 10209 - Part 5: Allow table elements to act as absolute positioning containers; r=roc
2011-05-09 20:36:10 -04:00
461fab9117
Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc
2011-04-29 19:02:33 -04:00
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
c2d66bf09f
Bug 685901 - Remove the nsTableOuterFrame::mInnerTableFrame and mCaptionFrame members in favor of accessing the child frame lists directly. r=roc
2011-09-12 09:08:07 -07:00
15fc2f321d
Bug 685154 - Cleanup nsIFrame::GetParentStyleContextFrame and related code. r=roc
...
Make nsCSSFrameConstructor::ConstructTable return a null frame if
creating the inner table frame fails. Simplify some code since we can
now depend on the invariant that a properly created outer table frame
always has a non-null inner table frame.
2011-09-12 09:08:07 -07:00
37e14b15b9
Bug 685154 - Cleanup nsIFrame::GetParentStyleContextFrame and related code. r=roc
...
Make nsIFrame::GetParentStyleContextFrame return the frame directly
instead of indirectly through an out parameter. Remove the unused
nsPresContext parameter.
2011-09-12 09:08:07 -07:00
f1c56f2e22
Bug 653649 - New way of getting child lists from frames. (part 4/5) r=roc
...
Remove the nsIAtom* child list names and use child list ID enum instead.
2011-08-24 22:54:30 +02:00
605a290f3b
Bug 653649 - New way of getting child lists from frames. (part 2/5) r=roc sr=dbaron
...
Implement GetChildList(ChildListID) and GetChildLists(nsTArray<ChildList>*)
for various frame classes. Remove GetAdditionalChildListName(PRInt32)
methods and associated macros and list index constants.
2011-08-24 22:54:29 +02:00
4fdc3501bb
Bug 642088 - Subtract the caption height and vertical margins from the available height before reflowing the inner table frame. r=bzbarsky
2011-07-26 19:22:46 +02:00
2a3dbb4205
Back out bug 10209 and bug 656875 (its regression fix) from Aurora because the work on this bug has not been finished yet
...
--HG--
extra : transplant_source : t%9F%EB%2Aa%A4%C0%9Ab%A5%DDQ%3EMD%5E%01h%E7%2A
2011-06-01 16:18:15 -04:00
e66b9024c8
Bug 10209 - Part 2: Implement the absolute positioning support for all frames; r=roc
2011-04-29 19:02:33 -04:00
1628ea1551
Bug 266236 part 9: Move nsBoundingMetrics to its own header and prune inclusions of nsRenderingContext.h.
...
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
rename : gfx/src/nsThebesRenderingContext.h => gfx/src/nsRenderingContext.h
extra : rebase_source : 92660748436f03475e011184e2828f1db0ad63e0
2011-04-07 18:04:40 -07:00
c510bc3046
Bug 266236 part 3: Mechanical rename of nsIRenderingContext and nsThebesRenderingContext to nsRenderingContext. Mechanical substitution of nsRefPtr<nsRenderingContext> for nsCOMPtr<nsRenderingContext>.
...
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
extra : rebase_source : 34884bfcafd885feaf73300bc7246cd192062a48
2011-04-07 18:04:40 -07:00
5029052452
Bug 628922 - layout should use cached nsIAccessibilityService, r=davidb, sr=roc, a=roc
2011-01-28 12:38:14 +08:00
5a012f3090
Fix miscellaneous reflow methods to use new overflow area APIs. (Bug 542595, patch 19) r=roc a2.0=blocking2.0:beta8
2010-10-06 21:25:46 -07:00
48071dc6a3
Make parameters to nsTableFrame::InvalidateFrame, nsTableFrame::PlaceChild, and nsTableRowGroupFrame::PlaceChild be the visual overflow rect. (Bug 542595, patch 17) r=roc a2.0=blocking2.0:beta8
2010-10-06 21:25:46 -07:00
65c355c8a7
Bug 573706 - make frame based accessible creation more pellucid, r=davidb, sr=roc
2010-06-28 21:02:03 +09:00
a791e19cc4
Bug 556446: Remove dead code in layout. r=roc,bz
2010-04-03 07:36:19 -04:00
3027a2127b
Bug 508473 part III: Pass destruction root to frame destruction methods r=bz sr=roc
2009-12-24 00:21:15 -05:00
8454bd049e
Bug 536463: Rename nsTableOuterFrame::GetMargin to 'GetChildMargin', so it won't hide unrelated inherited method. r=dbaron
2009-12-22 18:59:29 -08:00
7813eeb6d1
Bug 525295. Rename nsStyleContext::GetPseudoType to GetPseudo. r=dbaron
2009-10-29 17:17:56 -04:00
dea07412a1
Replace PR_MIN/PR_MAX with NS_MIN/NS_MAX. b=512106 r=roc
2009-09-16 17:01:36 +02:00
d47e0f433b
Bug 497495 part 3: Add methods to every nsFrame subclass that expose the as-allocated identity of every frame object. Also some cleanups to the QueryFrame implementation. r=dbaron sr=roc
2009-09-12 17:49:24 +01:00
811394b5da
Bug 281387. Make nsIFrame::Append/InsertFrames use nsFrameList. r=bernd,roc, sr=dbaron
2009-07-30 13:23:32 -04:00
1ef12b64a7
Bug 504221 part 12. Switch SetInitialChildList to nsFrameList. r=fantasai, r+sr=roc
2009-07-28 08:53:20 -04:00
cf7d0b6141
Bug 504221 part 5. Switch from GetFirstChild to GetChildList (returning an nsFrameList). For now, keep a GetFirstChild shim so callers don't have to be updated. r=fantasai, r+sr=roc
2009-07-28 08:51:09 -04:00
8bab94a96a
Bug 371839. Simplify SetSelected signature and semantics, and reimplement it in nsTextFrame much more efficiently. r=bzbarsky
...
--HG--
extra : rebase_source : 18c390e3ebd09de82b1a23699c56b741f928ca37
2009-07-27 10:05:41 +12:00
3f6c44858d
Bug 503376 - Remove unused CalcAutoMargin function which stopped being used in bug 478614, r=bernd
2009-07-13 12:31:32 -04:00
d0faab8b9c
adopt caption vertical margins to latest CSS2.1 revision, bug 478614, r/sr=dbaron
2009-06-28 15:51:46 +02:00
42f2f94d22
Bug 490909: Remove old layout debugging code, patch #2 : remove 'VerifyTree' & related code. r+sr=dbaron
2009-05-12 12:03:09 -07:00
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
ad5d856ae6
Rename flags and methods from space manager to float manager. (Bug 191448) r+sr=roc
2009-01-04 19:39:54 -05:00
2fd04858fe
bug 360422 remove obsolete code r/sr=bzbarsky
2008-10-26 10:24:59 +01:00
bc94c13609
Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc
2008-09-07 16:12:50 +02:00
7644127121
Bug 444688. Use an IsFrameOfType check instead of a frame state bit to detect whether a frame excludes ignorable whitespace children. r+sr=dbaronlayout
2008-07-14 10:41:18 +12:00
7eb9d4fe30
Invalidate things correctly when the caption or inner table is resized. Bug 424465, r=bernd, sr=roc
2008-04-01 14:53:19 -07:00
00aedc3553
Compute the shrink-wrapping size of table outer frames correctly. b=363402 r+sr=roc a1.9b4=beltzner
2008-02-28 09:55:04 -08:00
c07735665d
Fix horizontal positions of top and bottom captions in the presence of non-left-aligned tables. b=363248,386704 r+sr=roc a=blocking1.9+
2008-02-26 18:03:11 -08:00
d98a9e860e
Make 'top' and 'bottom' captions follow the CSS2.1 behavior and put the old behavior into 'top-outside' and 'bottom-outside'. b=363248,386704 r+sr=roc a=blocking1.9+
2008-02-26 18:02:20 -08:00
911901b1f3
Split nsTableOuterFrame::OuterReflowChild. b=363248,386704 r+sr=roc a=blocking1.9+
2008-02-26 18:01:33 -08:00
2f230818c7
switch GetOverflowAreaProperty callers to GetOverflowRect b=417116 r+sr=roc a=roc
2008-02-19 23:08:55 -08:00
5b9aa836b8
Bug 410052 - bustage fix on windows
2008-02-06 23:23:00 -08:00
d8aebfb510
Bug 410052 - Fix our nsHTMLAccessibleTable class so GetIndexAt and GetRowAtIndex and GetColumnAtIndex behave consistently, patch=me, marcoz, r=marcoz, me, bernd, sr=roc, blocking1.9+=dsicore
2008-02-06 23:03:26 -08:00
fe17447110
remove dead code, bug 282009 r/sr=roc a=mtschrep
2008-01-19 22:34:03 -08:00
4cedbfdd70
Bug 408749. Reflow captions with unconstrained height, because we have no logic to reflow their continuations. r+sr=bzbarsky
2007-12-20 19:25:36 -08:00
dac3d16a14
If we moved but did not reflow either the caption or the inner table, invalidate the relevant area. Bug 379353, r=bernd, sr=roc
2007-11-07 09:17:30 -08:00
725f9f32fc
Make sure to reflow the caption if it gets inserted into our table before another caption. Bug 389924, r=bernd, sr+a=dbaron
2007-08-02 14:34:58 -07:00
9c59e9e4cc
Introduce a setter for nsHTMLReflowState::mComputedHeight so that we're sure to
...
update the resize flags properly. Bug 388084, r+sr+a=dbaron
2007-08-02 11:08:05 -07:00
6d7584839a
Bug 348748 - Replace all instances of NS_STATIC_CAST and friends with C++ casts (and simultaneously bitrot nearly every patch in existence). r=bsmedberg on the script that did this. Tune in next time for Macro Wars: Episode II: Attack on the LL_* Macros.
2007-07-08 00:08:04 -07:00
4ff6072f7d
Bug 377783. Fix crash and clean up table a11y. r=evan.yan
2007-07-05 08:39:29 -07:00
42a227c78a
Cleanup implementations of QueryInterface. b=385750 r+sr=dbaron r+sr=jst
2007-07-03 19:15:31 -07:00
bc29535f04
Fix determination of the style context parent for the inner table frame of aroot table. Bug 379386, r+sr=roc
2007-05-07 20:59:12 -07:00
1b5f6b30b6
Change the FrameNeedsReflow API to pass the dirty flags to be added directly tothe method, instead of setting them before calling the method. That way we canavoid reflowing the ancestor of a reflow root which is not itself dirty but hasdirty children. This also makes it harder to set dirty bits inconsistentlywith the FrameNeedsReflow call. Bug 378784, r+sr=dbaron, pending rbs' reviewon the mathml parts.
2007-05-06 12:16:51 -07:00
487d95825a
Fix bug 379229, r+sr=dbaron
2007-04-29 23:17:03 -07:00
9a93ae1b49
Give captions the right style context parent when dynamically restyling. Bug378240, r=bernd, sr=dbaron
2007-04-22 12:15:24 -07:00
eeaa1a101b
Rename nsIFrame::GetPresContext to nsIFrame::PresContext. Bug 376042, patch byTaras Glek <tglek@mozilla.com>, rs=roc.
2007-03-30 14:11:41 -07:00
cfef5cbbe5
Remove the remainder of the pixel rounding in the table code. b=371187 r=bernd sr=roc
2007-02-22 20:22:12 +00:00
76a64e5c22
Bug 177805: Fix the use of units in Gecko. r+sr=roc
2007-02-07 07:46:44 +00:00
a39ff30284
Kill remainders of ns(XBL|HTML|XUL|Layout)Atoms. r/sr=jst b=368128
2007-01-30 00:06:41 +00:00
baec9bd166
Make mComputedWidth private, with a getter/setter, and make the setter update
...
the resize flags. Bug 367442, r+sr=dbaron
2007-01-26 00:05:12 +00:00
f6245f0ed9
Change the bulk of ascent (baseline) computation to happen on a virtual method on nsIFrame, and remove the redundant descent member from nsHTMLReflowMetrics, primarily to support having both first-line and last-line baselines. b=367332 r+sr=roc
2007-01-23 04:06:56 +00:00
4e651390ef
Bug 355300 There should be only one nsGkAtoms creature
...
r=dbaron
2006-12-26 17:47:52 +00:00
31f1898810
Bug 300030: Move intrinsic width computation out of nsIFrame::Reflow and into its own methods on nsIFrame. Replace reflow reasons, types, and commands with dirty bits/notifications. Thanks to bzbarsky for almost all of the HTML form controls (mozilla/layout/forms) changes, and many others for help testing and patching. For detailed commit logs, see REFLOW_YYYYMMDD_BRANCH, where YYYYMMDD is one of 20061031, 20060830, 20060603, 20060302, 20060119, 20051011, 20050804, 20050429, 20050315, 20050111, and 20041213.
2006-12-08 05:38:33 +00:00
26a1119b47
[Debug only] Add nsTableCaptionFrame::GetFrameName() returning "Caption". b=343386 r+sr=bzbarsky
2006-07-20 08:50:26 +00:00
153ab238ca
Fix crash when recreating <caption> frames. Add ASSERTIONs to detect similar frame construction errors in the future. b=341382 r+sr=bzbarsky
2006-06-29 02:32:36 +00:00
a7f03736a9
Bug 328926. Remove aPresContext parameter from nsIFrame::Destroy, nsIFrame::SetInitialChildList and nsIFrame::RemovedAsPrimaryFrame. patch by Marc Liddell, r+sr=roc
2006-04-10 00:16:29 +00:00
0a10a79f62
Bug 330934. Set a nsIFrame's stylecontext in its constructor, to ensure that there's always one available for GetPresContext() to use even if Init hasn't been called. Patch by Marc Liddell, r+sr=roc
2006-03-26 21:30:36 +00:00
14f0791bf3
insist on an inner table frame, resistance to any other childlist, bug 329768, r/sr=bzbarsky
2006-03-18 07:18:54 +00:00
131e8794e2
backing out roc's patch for bug 328926 due to crash running tests on vc8 machines.
2006-03-15 06:43:36 +00:00
557b089a47
Bug 328926. Remove aPresContext parameter from Destroy and SetInitialChildList. patch by Marc Liddell, r+sr=roc
2006-03-15 03:14:02 +00:00
c2801ebbd7
Bug 328926. Remove aPresContext from nsIFrame::Init and nsIFrame::DidSetStyleContext. r+sr=roc, patch by Marc Liddell
2006-03-09 18:55:21 +00:00
426f83aecc
Bug 298277 remove useless references to nsVoidArray
...
r=dbaron sr=dbaron
2006-02-23 10:30:59 +00:00
77bca74243
Bug 317375. Reorganize frame painting and mouse event targeting around frame display lists. Some review from dbaron, lots of testing help from Martijn, Julien and others
2006-01-26 02:29:17 +00:00
ef5d2c73ea
use scaledpixels to convert from CSS pixels to realword pixels bug=307367 r/sr=roc
2006-01-21 09:54:07 +00:00
5663eeaaaa
Do not prevent the creation of multiple captions, but display only the first one, bug 309322 r/sr=bzbarsky
2005-12-03 15:13:08 +00:00
1c34e68034
Bug 106386 Correct misspellings in source code
...
patch by mats.palmgren@bredband.net r=dbaron sr=dbaron
2005-11-20 22:05:24 +00:00
520b30a7f7
Bug 313817. DeCOMtaminate more NS_New*Frame functions. r+sr=roc, patch by Marc Liddell
2005-11-04 02:38:33 +00:00
8d2cb2369f
handle baseline for empty table cells closer to the new description in CSS2.1, bug 291060 r/sr=dbaron
2005-10-04 15:47:21 +00:00
fed343c43a
Bug 108310. Make GetFrameForPoint take frame-relative coordinates, not bogus relative-to-some-view-or-other, and simplify the signature. r+sr=roc, patch by Eli Friedman.
2005-09-19 02:15:54 +00:00
06ee318b44
Fix too-much-overflow regression by making border-collapse cells store the full width of the border rather than just the inside half of it. Also make BCPixelSize 16-bit instead of 8-bit and use it in more places, and a little other cleanup. b=286794 r=bernd sr=roc a=brendan
2005-04-07 18:04:38 +00:00
dfa6f80fa5
build warnings (shadow + unused variables) bug 287097 r/sr=bzbarsky
2005-03-24 19:02:59 +00:00
50f90a7217
take vertical margins into account during height constrained situations like printing. bug 285006 r/sr=roc
2005-03-19 17:59:11 +00:00
e042c2f571
Move reflow command construction into nsPresShell::AppendReflowCommand, remove
...
some members, switch some callers to the non-COM-ish apis. Bug 267085, r+sr=rbs
2005-02-08 00:59:52 +00:00
54d585f2af
Remove prescontext args for some nsIFrame methods
...
(Append/Insert/Remove/ReplaceFrames) and for some methods in table land. Patch
by Vidar Braut Haarr <bugmail@q1n.org>, r+sr=bzbarsky
2005-02-07 01:58:25 +00:00
74e2aa375a
Bug 276100 GetOriginToView has unused PresContext argument p=bugmail@q1n.org r+sr=dbaron
2005-01-01 17:26:29 +00:00
ca3e9f85c3
remove unused prescontext from PlaceFrameView, PlaceChildsView, ConsiderChildOverflow bug 276092 r/sr=dbaron
2004-12-27 15:05:18 +00:00
22a3945caa
fix flawed reflow logic for empty table cells bug 226637 r/sr=bzbarsky
2004-10-29 17:31:53 +00:00
5be60c13bc
query the reflow path only during incr. reflow bug 264620 r/sr=bzbarsky
2004-10-16 18:21:15 +00:00
44a2fd5b52
Bug 259032. DeCOMtaminate nsIFrame::GetNext/PrevInFlow. r+sr=roc, patch by Will Levine
2004-09-14 02:28:03 +00:00
02de8104c7
don't cause twice a initial reflow on a caption bug 258379 r/sr=bzbarsky
2004-09-11 06:08:53 +00:00
01f5e54ff0
Land bug 72747 in pieces: use new functions for common overflow tests. b=72747 r+sr=roc
2004-09-02 23:27:23 +00:00
879d8114ba
bring condition and action in better sync when oversized nested pct based table frames are reduced in size bug 254344 r/sr=bzbarsky
2004-08-31 18:57:06 +00:00
c200b49750
Back out the rest of bug 72747 due to Tp regression.
2004-08-27 01:26:55 +00:00
Mats Palmgren
Ehsan Akhgari
Michael Wu
Bernd
Zack Weinberg
Jan Küchler
Alexander Surkov
L. David Baron
Ehren Metcalfe
fantasai
Daniel Holbert
Boris Zbarsky
Zack Weinberg
Robert O'Callahan
Benjamin Smedberg
Bernd
Graeme McCutcheon
roc+@cs.cmu.edu
jwalden@mit.edu
aaronleventhal@moonset.net
mats.palmgren@bredband.net
dbaron%dbaron.org
sharparrow1%yahoo.com
cvshook%sicking.cc
bzbarsky%mit.edu
timeless%mozdev.org
mats.palmgren%bredband.net
roc+%cs.cmu.edu
bmlk%gmx.de
pavlov%pavlov.net
neil%parkwaycc.co.uk