Граф коммитов

32 Коммитов

Автор SHA1 Сообщение Дата
Ed Lee 1ec19988e0 Bug 1912564 - More shortcuts triggering and hiding improvements r=tarek
Check for selection change instead of just having a selection. Support inputs/textarea selection. Hide before unload.

Differential Revision: https://phabricator.services.mozilla.com/D219105
2024-08-14 10:53:09 +00:00
Ed Lee 447e7076df Bug 1912080 - Chatbot prompt prefix string missing from localization r=tarek,fluent-reviewers,flod
Allow prefix pref to be json with l10nId that allows localization.

Differential Revision: https://phabricator.services.mozilla.com/D218804
2024-08-08 11:55:10 +00:00
Ed Lee 150938c9f1 Bug 1911748 - Chatbot: too much insistent -> shortcuts Icon every where ( when using the touchpad ) r=tarek
Allow the long press delay to be pref controlled with a higher default 200ms -> 60s effectively turning it off. Record the delay with glean.

Differential Revision: https://phabricator.services.mozilla.com/D218662
2024-08-07 19:41:20 +00:00
Ed Lee 150666d6ce Bug 1911888 - if text selected somewhere on page and a link clicked with middle mouse button/mousewheel (to open it in a new tab), generative AI popup button gets shown but shouldn't r=tarek
Ignore modified clicks to only support plain clicks.

Differential Revision: https://phabricator.services.mozilla.com/D218672
2024-08-07 14:32:37 +00:00
Ed Lee 8edcc06d28 Bug 1911173 - Update the shortcut text selection UX focusing on mouseup instead of keyboard r=tarek
Immediately show shortcuts on mouseup with selection or detect mousedown/mouseup timing for long press.

Differential Revision: https://phabricator.services.mozilla.com/D218417
2024-08-05 07:53:38 +00:00
Ed Lee 61ef38e43f Bug 1905042 - The AI Chat Sidebar stays open when the user disables the AI chat integration feature from the Experiments page r=tarek
Detect enabled switched to false and close sidebar if on chatbot.

Differential Revision: https://phabricator.services.mozilla.com/D218480
2024-08-03 17:12:48 +00:00
Ed Lee 7bd465a902 Bug 1910063 - Avoid perma TV genai_init with matching uninit r=tarek
Differential Revision: https://phabricator.services.mozilla.com/D218475
2024-08-03 07:11:06 +00:00
Ed Lee 9ca4d5dc5a Bug 1907350 - Expose genai-settings-chat-title and other chatbot strings for localization r=tarek,fluent-reviewers,mconley,bolsson
Move featuregate title to features.ftl used by about:preferences and about:support; and other strings to genai.ftl. Allow prompts to use l10nId to get fluent attributes. Convert inline strings for menu and shortcuts to fluent. Update simplify, add explain prompts.

Differential Revision: https://phabricator.services.mozilla.com/D218279
2024-08-03 06:40:26 +00:00
Ed Lee 4c62bb6510 Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 04:19:46 +00:00
Noemi Erli acb6679fdd Backed out changeset c9ad93d58c14 (bug 1910005) for causing bustages in GleanMetrics.h CLOSED TREE 2024-08-03 06:17:37 +03:00
Ed Lee 2d3545acad Bug 1910005 - Expose chat shortcuts pref as part of experimental subitem r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,dao,mstriemer
Switch default shortcuts enabled with labs checkbox to disable and labs visibility. Add metric and event telemetry for shortcuts pref and usage. Bump pip labs ordering up one.

Differential Revision: https://phabricator.services.mozilla.com/D217782
2024-08-03 02:46:23 +00:00
Ed Lee b80ab8c5f1 Bug 1911124 - Support chatbot provider list configuration via pref to hide r=tarek
Add hidden providers pref to reorder and show/hide providers including localhost with its existing pref.

Differential Revision: https://phabricator.services.mozilla.com/D218387
2024-08-02 08:25:15 +00:00
Ed Lee 64e9769cf0 Bug 1909642 - Firefox Labs does not load the AI provider list if the user Starts Firefox and enables the AI chatbot integration right after startup r=tarek
Also check for existing preferences at init to build.

Differential Revision: https://phabricator.services.mozilla.com/D218271
2024-08-01 14:50:55 +00:00
Ed Lee 07fd529ed8 Bug 1910067 - Allow focusing shortcuts chat prompts r=tarek
Add tabindex to make toolbarbuttons focusable via the accessibility API.

Differential Revision: https://phabricator.services.mozilla.com/D218270
2024-08-01 14:16:31 +00:00
Ed Lee 58bc3f5f7a Bug 1910509 - Add nimbus variables for chatbot configuration r=tarek
Allow setting user and default branch prefs specified in the nimbus variable for chatbot.

Differential Revision: https://phabricator.services.mozilla.com/D218045
2024-07-31 17:29:43 +00:00
Ed Lee 3460523677 Bug 1905750 - Display shortcuts on text selection r=tarek
Detect selection to show shortcut icon near the cursor. Open panel with prompts when hovering the icon. Hide these on various events that might move content or no selection.

Differential Revision: https://phabricator.services.mozilla.com/D217545
2024-07-26 07:23:00 +00:00
Ed Lee 0fe599ea69 Bug 1905750 - Stub actors and panel to display content-area shortcuts on text selection r=tarek,desktop-theme-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Add default false shortcuts pref to control GenAI actors initially detecting text selection. Prepare content-area elements that stack on top of tab's browser.

Differential Revision: https://phabricator.services.mozilla.com/D217544
2024-07-26 07:22:59 +00:00
Ed Lee 29e26a6e38 Bug 1907246 - Add Anthropic Claude to chatbot provider list r=tarek,fluent-reviewers
Use ?q= to start while we figure out how to generalize &attachment=.

Differential Revision: https://phabricator.services.mozilla.com/D216242
2024-07-11 20:41:31 +00:00
Ed Lee fc2b51ce6e Bug 1906976 - Treat modified prompts as custom for telemetry r=tarek
Detect user modified preferences to switch to "custom"

Differential Revision: https://phabricator.services.mozilla.com/D216114
2024-07-11 06:48:48 +00:00
Ed Lee 58938381b3 Bug 1895497 - Update chatbot providers and featuregate with more appropriate configuration for initial nightly r=tarek,fluent-reviewers,settings-reviewers,flod,Gijs
Show AI Chatbot integration with providers and links in about:preferences.

Differential Revision: https://phabricator.services.mozilla.com/D214489
2024-06-24 17:42:56 +00:00
Ed Lee 93692d0756 Bug 1903767 - Run browser_genai_init with experimental preferences enabled r=tarek
Avoid perma fail when moving to beta with experimental default off.

Differential Revision: https://phabricator.services.mozilla.com/D214673
2024-06-23 14:34:49 +00:00
Ed Lee f6ab2759ac Bug 1895813 - Add telemetry for chat interactions and state r=tarek
Add new metrics.yaml for various metrics and events with matching logic to set/record. Introduce various ids for providers and prompts.

Differential Revision: https://phabricator.services.mozilla.com/D214470
2024-06-22 17:43:07 +00:00
Ed Lee 1e332bf4b9 Bug 1895433 - Add chat providers to show in preferences with links and menu r=tarek
Not quite adding providers but start with hidden localhost that can test functionality.

Differential Revision: https://phabricator.services.mozilla.com/D214355
2024-06-20 23:15:52 +00:00
Ed Lee d51f63c6dc Bug 1902449 - Rework chat to support contextual prompts and non-contextmenu entry points r=tarek
Refactor building chat menu from prefs and context passing. Reuse message targeting for optional contextual filtering of prompts.

Differential Revision: https://phabricator.services.mozilla.com/D214332
2024-06-20 14:39:24 +00:00
Ed Lee 0c7eea1325 Bug 1903443 - Support providers that accept prompts via headers r=tarek
Allow optional header configuration for providers to decide how to pass the prompt.

Differential Revision: https://phabricator.services.mozilla.com/D214243
2024-06-20 04:51:46 +00:00
Ed Lee 263303ec2a Bug 1895494 - Support more generic handling of custom experimental preferences logic r=tarek,settings-reviewers
Switch from direct import to observer now that GenAI has an init.

Differential Revision: https://phabricator.services.mozilla.com/D214216
2024-06-19 17:01:12 +00:00
Ed Lee b64acc9c38 Bug 1903444 - Detect provider change to auto-open sidebar r=tarek,firefox-desktop-core-reviewers
Add startup init to detect pref changes.

Differential Revision: https://phabricator.services.mozilla.com/D214207
2024-06-19 17:01:12 +00:00
Ed Lee b9a9ab2809 Bug 1900940 - Render chat sidebar content for configured provider r=tarek
Support rendering providers but keep list empty for now. Show selected provider including custom and render content browser.

Differential Revision: https://phabricator.services.mozilla.com/D212836
2024-06-15 17:32:54 +00:00
Ed Lee 9d55a3b2dd Bug 1899827 - Stub initial conditional sidebar depending on chat pref r=tarek,fluent-reviewers,desktop-theme-reviewers,sidebar-reviewers,flod,sclements
Add placeholder chat page that is shown in old sidebar when pref is enabled.

Differential Revision: https://phabricator.services.mozilla.com/D212756
2024-06-15 01:48:55 +00:00
Ed Lee 9c113718ee Bug 1894999 - Expose chat prefs via experiments featuregate r=tarek,fluent-reviewers,settings-reviewers,desktop-theme-reviewers,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D209639
2024-06-07 04:28:22 +00:00
Ed Lee bc3442f25c Bug 1894998 - Add prefs to control chat, provider, prompts r=tarek
Differential Revision: https://phabricator.services.mozilla.com/D209638
2024-06-06 14:21:15 +00:00
Ed Lee 8e7d70c856 Bug 1894994 - Stub initial context menu entrypoint for asking chat r=tarek,mconley
Differential Revision: https://phabricator.services.mozilla.com/D209637
2024-06-05 20:43:12 +00:00