Most of these were probably disabled because of the window occlusion thing making them timeout. We fixed that in this bug so we don't need them anymore. Whatever the reason these all pass now and don't seem to be intermittent failures either.
There is still one test that we must skip on wayland for failure though, dom/media/tests/crashtests/1490700.html, but I think it's related to some webrtc feature that is not implemented on wayland perhaps.
Differential Revision: https://phabricator.services.mozilla.com/D208078
XPCOMShutdownThreads is the phase just after XPCOMShutdown and XPCOMShutdown is when we destory the ImageBitmapShutdownObserver, so we need to not create a new ImageBitmapShutdownObserver if we are in XPCOMShutdown or later.
Differential Revision: https://phabricator.services.mozilla.com/D186852
When DeleteQuery is called, it uses mTarget to determine whether or not
BeginQuery has been called. This is an insufficient condition because
QueryCounter also sets mTarget without calling BeginQuery and occupying
a slot in current query map. This patch fixes the crash by checking if
the slot is empty first.
Differential Revision: https://phabricator.services.mozilla.com/D137070
ImageBitmap::PrepareForDrawTarget overwrites its surface's contents when premultiplying the
data. This code pattern seems to stem all the way back to bug 1239752. It doesn't seem like
we have much control over where this surface comes from, and we have no strong guarantees
that this surface isn't shared by multiple consumers. As such, overwriting the data could
result in another consumer getting premultiplied data in the surface that it didn't expect.
We should just always be cloning the surface first before premultiplying unless we can
otherwise prove the surface isn't shared.
* * *
Bug 1739454 - Remove reftest-wait in reftest. r?emilio
Differential Revision: https://phabricator.services.mozilla.com/D131583
CLOSED TREE
Backed out changeset 3accfa522abb (bug 1739454)
Backed out changeset 18fdb7a13e63 (bug 1739454)
Backed out changeset 1de7d723923a (bug 1739454)
ImageBitmap::PrepareForDrawTarget overwrites its surface's contents when premultiplying the
data. This code pattern seems to stem all the way back to bug 1239752. It doesn't seem like
we have much control over where this surface comes from, and we have no strong guarantees
that this surface isn't shared by multiple consumers. As such, overwriting the data could
result in another consumer getting premultiplied data in the surface that it didn't expect.
We should just always be cloning the surface first before premultiplying unless we can
otherwise prove the surface isn't shared.
Differential Revision: https://phabricator.services.mozilla.com/D131583
There's no guarantee at all that the filter URI is valid, it just so happens
that for regular CSS filters we bail out earlier.
A bogus base URI makes relative uris just invalid, which triggers this assert.
The assert was gracefully handled anyway, so no big deal.
Differential Revision: https://phabricator.services.mozilla.com/D41952
--HG--
extra : moz-landing-system : lando
Changes:
- added skip-If statements for some crashtest items that fail on macosx1014
- removed `crashtest` from `macosx64` test sets, with the consequence that `macosx64-qr-tests` test set is removed, with cascading effects to the test-platforms definitions that used only `macosx64-qr-tests`
Differential Revision: https://phabricator.services.mozilla.com/D34448
--HG--
extra : moz-landing-system : lando
The patch changes the calculation for the allocation size associated with a canvas rendering context to return zero when the width or height are greater than allowed (this will result in an error when creating the target later on) and also if the size calculation overflows (which shouldn't normally happen given the previous check).
Differential Revision: https://phabricator.services.mozilla.com/D31265
Gregory Pappas
Joel Maher
Timothy Nikkel
Andrew Osmond
Robert Longson
Andrew Halberstadt
Cristian Tuns
Jim Blandy
Mathew Hodson
Lee Salzman
Jens Stutte
Ryan VanderMeulen
Alexandru Michis
Emilio Cobos Álvarez
Kris Wright
Bob Owen
Geoff Brown
Kartikaya Gupta
Coroiu Cristina
Edwin Gao
Jon Coppeard
Ehsan Akhgari
sotaro
Xidorn Quan
Jesse Ruderman
Christoph Diehl
Ethan Lin