Граф коммитов

4897 Коммитов

Автор SHA1 Сообщение Дата
Mark Banner ca6826260e Bug 1119282 - Fix the sync bookmark validator cycle detection to correctly get folder contents. r=kitcambridge
MozReview-Commit-ID: BjRD5wKbAoy

--HG--
extra : rebase_source : 9eb28f31351d4e5256e4aa6e3a87af6a9c934568
2017-06-29 10:49:10 -07:00
Carsten "Tomcat" Book 5f00ae3a8b merge mozilla-inbound to mozilla-central a=merge 2017-06-29 15:47:04 +02:00
Benjamin Smedberg 53c93f8449 Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
MozReview-Commit-ID: FD5npJlB24W

--HG--
extra : rebase_source : d30bac5044ecb8d86253e8bca3e8d47371fb9d1f
extra : source : 4f0ee0f75a307095e4a04afe4413e5bb6ea8e502
2017-06-21 15:26:10 -04:00
Edouard Oger 58f16ee440 Bug 1374501 - Allow extra sync engines to be activited using FxA Web Channels. r=markh,stomlinson
MozReview-Commit-ID: HykDad81Ifh

--HG--
extra : rebase_source : d07f048b5f96e7fa9b1fc7130b4f518ac5527075
2017-06-21 13:55:05 -04:00
Bill McCloskey f115503a0b Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-26 14:19:58 -07:00
Mark Hammond 7e61aa8e97 Bug 1373093 - Add operating system information to the desktop Sync ping. r=tcsc
MozReview-Commit-ID: 9ypnosSawxu

--HG--
extra : rebase_source : 8a0192c70917c952431693c6864f96f7fd9b278e
2017-06-21 12:28:25 +10:00
Jeongkyu Kim 728bae404f Bug 1348727 - Write validation summary information to the sync logs r=tcsc
MozReview-Commit-ID: GRf0DeDhFqP

--HG--
extra : rebase_source : de2b49d55f4cbb4926475851deae298a16423ec9
2017-06-24 02:08:43 +09:00
Phil Ringnalda c636da88e0 Backed out changeset 4f0ee0f75a30 (bug 1367813) for Windows opt permaorange in test_worker_basic.html
MozReview-Commit-ID: 2k693yFa28r
2017-06-22 20:43:11 -07:00
Benjamin Smedberg 5cf8c34a94 Bug 1367813 - 1) Add telemetry for prefs.js not existing or being corrupted, and the presence of a user.js file. 2) Rename and change the nsIPrefService.readUserPrefs API. The new API reads user prefs from a file but doesn't remember that location or save changed preferences to that location. r=milan data-r=rweiss
MozReview-Commit-ID: FD5npJlB24W

--HG--
extra : rebase_source : 049275836880f0aa4d19a9af2de9ec4101432b44
2017-06-21 15:26:10 -04:00
Florian Quèze 1e40201f6d Bug 1374282 - script generated patch to remove useless bind calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Florian Quèze 66f6d259bc Bug 1374282 - script generated patch to remove Task.jsm calls, r=Mossop. 2017-06-22 12:51:42 +02:00
Andrew McCreight 3e60ae3dd8 Bug 1375133 - Remove unnecessary imports of btoa and atob in services/ code. r=markh
There are a few places in services/ tests that import btoa and atob,
but this is not necessary, because those are both defined on the
XPCShell global (by glob_functions in XPCShellImpl.cpp). It sounds
like it didn't work at some point on B2G (see bug 937114) but that
isn't relevant any more. I want to fix this because the way these
properties are imported will break with shared JSM globals.

MozReview-Commit-ID: HoxqIS98p7B

--HG--
extra : rebase_source : 7800baee8ebc5e3ab3f52a62e30e5cde8d19876b
2017-06-21 09:56:57 -07:00
Wes Kocher ac0fd2038c Merge inbound to m-c a=merge
MozReview-Commit-ID: 3LXFVwSoMvs
2017-06-21 17:58:17 -07:00
Nathan Froyd b28fcc5c4b Bug 1372670 - part 5 - add nsIThreadManager::spinEventLoopUntilEmpty; r=erahm,florian
A number of places in JS need to drain the current thread's event queue,
which cannot be done with nsIThreadManager::spinEventLoopUntil, since we
need to not wait for an incoming event when attempting to process one.
2017-06-21 12:59:28 -04:00
Nathan Froyd 27c58cf89f Bug 1372670 - part 3 - add spinEventLoopUntil to nsIThreadManager; r=erahm,florian 2017-06-21 12:59:28 -04:00
Carsten "Tomcat" Book 8a1350b5a6 Backed out changeset 4f6302a98ae4 (bug 1372405)
--HG--
extra : rebase_source : 41632f3158e88e692809731394a683d065a73dfb
2017-06-21 13:59:26 +02:00
Mark Hammond a1b09f054d Bug 1374599 - neuter the sync scheduler during some tests to avoid oranges. r=standard8
MozReview-Commit-ID: Ihun5yu3hit

--HG--
extra : rebase_source : 9448411e072d144456e7672b92699cdf288a13fc
2017-06-21 14:53:07 +10:00
Wes Kocher c0e1236f1a Merge autoland to m-c a=merge
MozReview-Commit-ID: LFtpTAueYrF
2017-06-20 18:24:29 -07:00
Paolo Amadini 375f5f7210 Bug 1362970 - Part 3 - Fix indentation and one misuse of "catch". r=florian
MozReview-Commit-ID: 2oFOmye7EUr

--HG--
extra : rebase_source : 1b575a89ff3f0dc7683f1c25bde12de6859c17be
extra : source : eb61cf8f77d22f0cf026056615a475c2e04f932a
2017-06-16 11:16:00 +01:00
Paolo Amadini 10ee6a5c4e Bug 1362970 - Part 2 - Script-generated patch to convert .then(null, ...) to .catch(...). r=florian
Changes to Promise tests designed to test .then(null) have been reverted, and the browser/extensions directory was excluded because the projects it contains have a separate process for accepting changes.

MozReview-Commit-ID: 1buqgX1EP4P

--HG--
extra : rebase_source : 3a9ea310d3e4a8642aabbc10636c04bfe2e77070
2017-06-19 11:32:37 +01:00
Carsten "Tomcat" Book de892834ed Merge mozilla-central to mozilla-inbound 2017-06-20 11:31:34 +02:00
Thom Chiovoloni a208081e56 Bug 1357798 - Ensure URLs don't end up in sync error telemetry. r=markh
MozReview-Commit-ID: AxFzysv0ks3

--HG--
extra : rebase_source : 6b2aa9354ed9540c5cdb8f537eaca7080c97a4eb
2017-06-12 13:38:39 -04:00
Thom Chiovoloni c3972efec6 Bug 1368393 - Handle already synced commands in clients collection duplicate checking r=eoger,markh
MozReview-Commit-ID: Hs0Jh8mMlOp

--HG--
extra : rebase_source : 8a8bae7330210547d128c322abed773cb73895e5
2017-06-09 12:07:43 -04:00
Edouard Oger b599411285 Bug 1369119 - Refresh known stale devices list on FxA device disconnect. r=markh
MozReview-Commit-ID: A2iqas0kP20

--HG--
extra : rebase_source : 15db886e4751885e173a55c561df7ea1a3b2871b
2017-06-06 14:28:00 -04:00
Carsten "Tomcat" Book ea1b86680c Backed out changeset 9846de3bd954 (bug 1372405)
--HG--
extra : rebase_source : 5d4a48e8ec394c329994689d938d2a6e9b2752b0
2017-06-20 08:27:02 +02:00
Bill McCloskey 4592152411 Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-19 22:25:47 -07:00
Bevis Tseng d1637b9c5a Bug 1372453 - Part 2: Name the caller of ProxyReleaseEvent. r=billm
MozReview-Commit-ID: LYhSWnZkq0i
2017-06-14 09:27:17 +08:00
Mark Banner d030707609 Bug 1095426 - Convert JSON backups code to the new async Bookmarks.jsm API. r=mak
MozReview-Commit-ID: FNZZGwWVSI2

--HG--
extra : rebase_source : dacb3c5ddb439d074c66e0baaa7e73044c5dcd46
2017-05-12 08:04:51 +01:00
Marco Bonardo 1d88de7d2f Bug 1371945 - Avoid a possible thread-safety problem with unfinalized statements. r=asuth
Avoids a thread-safety race condition on shutdown where we could try to finalize a statement twice.
Allows the async thread to be referenced until ShutdownAsyncThread, so async finalizers can make use of it.
Removes the no more useful mAsyncExecutionThreadIsAlive.
Nullifies the sqlite3_mutex pointer when the connection is closed, since it would be a dangling pointer.
Use a ScopeExit to ensure the connection and the mutex pointers are always nullified on failure.
Makes asyncClose bailout early if a Close method was already invoked before.
Makes AsyncInitDatabase not use AsyncClose to just shutdown the async thread.
Fixes various unfinalized statements in consumers code.
Makes mConnectionClosed better follow mDBConn status.
Replaces some mutex locking isClosed() calls with lockless isConnectionReadyOnThisThread.

MozReview-Commit-ID: 6sftFehsQTt

--HG--
extra : rebase_source : 2bf3088b500376e58e62e8f078d9950588adc649
2017-06-16 17:43:23 +02:00
Bill McCloskey 6b3e84ed5f Bug 1372405 - Provide names for all runnables in the tree (r=froydnj)
MozReview-Commit-ID: DKR6ROiHRS7
2017-06-20 21:44:11 -07:00
Masatoshi Kimura 3231cb3535 Bug 1372886 - Remove dead parameters from nsIConverterInputStream.init(). r=hsivonen
MozReview-Commit-ID: GliLHLsUWjt

--HG--
extra : rebase_source : 50d3f4680a498125ddf600b0d64f6740b0229f80
2017-06-17 19:30:09 +09:00
Edouard Oger a1f2f47f82 Bug 1363412 - Notify other clients when uploading the local clients record for the first time. r=markh
MozReview-Commit-ID: Ldc3Jrj8RhV

--HG--
extra : rebase_source : 44bdeaa962ddbcb748f9e5a01871fd2ff7d6a676
2017-06-12 14:51:17 -04:00
Edouard Oger 1826fefb4c Bug 1370985 - Change getBatched() to return records directly instead of using a callback. r=markh,tcsc
MozReview-Commit-ID: HfwPe8jSH66

--HG--
extra : rebase_source : 12c8800f1fcc090589c2a94a0fc1608b36c54181
2017-05-30 13:23:57 -04:00
ffxbld 120e57745f Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2017-06-12 13:48:15 +01:00
Edouard Oger adde19d4f4 Bug 1369855 - Update sinon.js to version 2.3.2. r=markh
MozReview-Commit-ID: FPB4HebP3g7

--HG--
extra : rebase_source : 1e55c1dbc8bff59e1a7a097e4a6a58a19bc95688
2017-06-02 15:50:30 -04:00
Mark Hammond 96faa14e58 Bug 1370736 - reset the sync login status after an FxA login event. r=eoger
MozReview-Commit-ID: 6BLj6q8z79i

--HG--
extra : rebase_source : 350bc8d6c6e5581082c9b1a50b3517b93d70db52
2017-06-07 16:41:18 +10:00
tiago 1fdf6c19a7 Bug 1356281 - Remove bookmark contents from sync debug logs. r=tcsc
MozReview-Commit-ID: HsMH5mpCK8C

--HG--
extra : rebase_source : 26853fa867257a6c0a914ed903f9d8e253c86e8f
2017-05-19 04:40:15 -03:00
Mathieu Leplatre 7d9c066f35 Bug 1254099 - Add Telemetry to settings update r=bsmedberg,glasserc,mgoodwin,rhelmer
MozReview-Commit-ID: 8vAuTImx7IH

--HG--
extra : rebase_source : 15995e30bd1fdb697eb2374a0c28c68e0828e1e6
2017-03-22 11:27:17 +01:00
tiago 19362d0bfa Bug 1354016 - Forms validator ignore clientMissing. r=tcsc
MozReview-Commit-ID: C2FD58C9HzS

--HG--
extra : rebase_source : f5b627342e7fa4915914cbfd3e54003fe6d94c1e
2017-06-01 22:32:23 -03:00
Mark Hammond dc01c77702 Bug 1369285 - update how we build the default sync device name. r=tcsc
MozReview-Commit-ID: 6eY8IzKg9kd

--HG--
extra : rebase_source : ae321d48de0144c29fa4f40fd16a02c44539d795
2017-06-01 16:57:02 +10:00
Edouard Oger 9d1dc7c4a7 Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
MozReview-Commit-ID: 74IFsVjZSgz

--HG--
extra : rebase_source : 00f77b7a24a509d5e9fabb8ee7793a59b38f639f
2017-05-29 13:24:01 -04:00
Edouard Oger 2c61cf7eb4 Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
MozReview-Commit-ID: JbzweOMFLpR

--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
Edouard Oger 0c6026b415 Bug 1369092 - Listen to onverified events in UIState. r=markh
MozReview-Commit-ID: 8nfmpaz9obF

--HG--
extra : rebase_source : 736673d0c1245b81ea9f419f08b943c3ce26a8e6
2017-05-31 12:02:28 -04:00
Sebastian Hengst 9768267be1 Backed out changeset bf392a1d0c5a (bug 1368560) for failing xpcshell's test_ext_storage_sync.js and test_ext_storage_sync_crypto.js on Linux. r=backout on a CLOSED TREE 2017-05-31 22:53:16 +02:00
Sebastian Hengst a9f8675d96 Backed out changeset c2d00a8b897b (bug 1368560) 2017-05-31 22:52:14 +02:00
Edouard Oger 275b48a53e Bug 1368560 part 2 - Move Svc.Crypto to Weave.Crypto. r=markh
MozReview-Commit-ID: 74IFsVjZSgz

--HG--
extra : rebase_source : 29833856a9cca178a2b508b6401cdb6bd8ca1bb9
2017-05-29 13:24:01 -04:00
Edouard Oger 198e8ab1d1 Bug 1368560 part 1 - Remove un-used legacy crypto methods. r=markh
MozReview-Commit-ID: JbzweOMFLpR

--HG--
extra : rebase_source : f7cece36dce26c96a740aede6c696deb08345a90
2017-05-29 17:27:13 -04:00
Mark Hammond 71a24b858a Bug 1366994 - prevent appDisabled addons from hanging sync. r=tcsc
MozReview-Commit-ID: 4RRCPlwUZrG

--HG--
extra : rebase_source : 8ab03af402dc15432252b74a120da286b810302f
2017-05-26 12:42:10 +10:00
Edouard Oger f8e13dd94c Bug 1353645 - Record account verification status determination method telemetry. r=bsmedberg,gfritzsche,markh
MozReview-Commit-ID: GETlknx8Fse

--HG--
extra : rebase_source : b56da3d0309b91ee7d908e9246d7921ebd7ed03d
2017-05-16 16:59:51 -04:00
tiago 7386600327 Bug 1366081 - Excise 'mobileGUIDFetchBatchSize' and other mobile sync-related constants. r=kitcambridge
MozReview-Commit-ID: 6JTtpWFFyvD

--HG--
extra : rebase_source : f6ca75e91ca38d0d1ba18ff79a0872d96a878954
2017-05-24 03:28:22 -03:00
Ethan Glasser-Camp f9f6f160da Bug 1364135: Clean up detection/handling of deleted keyrings, r=kmag,MattN
MozReview-Commit-ID: CoOwUazDRSL

--HG--
extra : rebase_source : d027c47f1b5740fa9916420b5dafdac935264ff8
2017-05-11 13:15:20 -04:00
milindl fc8d285e3d Bug 1036440 - Fix tests and consumers for rewritten `PlacesDBUtils`, r=mak
This includes 2 things:
1. Replacing the parts which test the logs for the presence of prefixes by testing
the returned map for `suceeded`.
2. We don't need to wait to observe the topic anymore, we can simply await methods
from `PlacesDBUtils` to know when they are done.

MozReview-Commit-ID: Ct9l9pzUW5x

--HG--
extra : rebase_source : 657e4ac53f8b3785740a5b732d483fad9600f73d
2017-05-24 11:00:47 +05:30
Thom Chiovoloni 85291791fd Bug 1367585 - Add the 'load' event listener before adding the new tab in sync's TPS tests r=markh
MozReview-Commit-ID: HUUHYnLf4m8

--HG--
extra : rebase_source : f0ac2cadf4f5345f854e8ad8ca3e7be37485a0cf
2017-05-24 17:58:55 -04:00
Thom Chiovoloni 1e07d66113 Bug 1367543 - Make sync's TPS tests handle cases where resyncs are triggered r=kitcambridge
MozReview-Commit-ID: 4owlGyLw5jU

--HG--
extra : rebase_source : bdfca8806ed76c2398c845880f4b7c65bd3dffd3
2017-05-24 16:16:23 -04:00
udara d53c05ca28 Bug 1367525 - Remove extra error logging during device disconnect. r=eoger
MozReview-Commit-ID: JgFvBlGwsxZ

--HG--
extra : rebase_source : ef9cfb41112d8974f8e1ef5a138e4cfddfdc6386
2017-05-24 15:19:35 -04:00
Edouard Oger 99947c9c38 Bug 1353307 - Add main process start time to sync ping. r=gfritzsche,markh
MozReview-Commit-ID: DbSZUmO0tuf

--HG--
extra : rebase_source : e13afbd5829b86b7bee5c82a7a1ff09263e9dc3f
2017-05-16 17:43:49 -04:00
Edouard Oger c4e6a8f382 Bug 1365375 - Disconnect Sync on account destroyed. r=markh
MozReview-Commit-ID: EVySp2JOgsT

--HG--
extra : rebase_source : e60612d8dedcf46170cf58f47bde2c979ab99d3f
2017-05-23 19:22:49 -04:00
Ryan VanderMeulen 4202c4feab Merge m-c to autoland. a=merge 2017-05-23 18:13:54 -04:00
Kit Cambridge df2d03a198 Bug 973166 - Only track passwords with changes to synced fields. r=eoger
MozReview-Commit-ID: 8ZOyVCaZIi8

--HG--
extra : rebase_source : 8252c5a9ad718594872d5bda38e04528cd227f44
2017-05-22 17:21:20 -07:00
Ryan VanderMeulen c92175874c Backed out changeset d11aec13b38e (bug 1365375) for eslint failures. 2017-05-23 13:36:50 -04:00
Edouard Oger 69602ba5f2 Bug 1365375 - Disconnect Sync on account destroyed. r=markh
This connects to the fxa-auth-server PR:
https://github.com/mozilla/fxa-auth-server/pull/1900

MozReview-Commit-ID: IIYnytYGIpw

--HG--
extra : rebase_source : 04a6adb81252c0c4aa0eaaa01b68e3943791aadc
2017-05-17 16:25:00 -04:00
Kit Cambridge d2833635e1 Bug 1352233 - Try to preserve synced folder child order in case of conflicts. r=tcsc
For folders, we resolve conflicts by taking the chronologically newer
list, then appending any missing items from the older list. This
preserves the order of those missing items relative to each other, but
not relative to those appearing in the newer list.

MozReview-Commit-ID: 6rimXpV7vLg

--HG--
extra : rebase_source : 10cda7f529cec3f71d9d45d253285d35788cb0b5
2017-04-28 14:08:11 -07:00
Ryan VanderMeulen 1734a80650 Merge m-c to inbound. a=merge 2017-05-23 11:15:49 -04:00
Shane Tomlinson 7a827756f9 Bug 1308038 - Add handshake capability to share state with FxA. r=markh, r=rkelly 2017-02-02 09:16:54 +00:00
tiago 7d0f361ba0 Bug 1356282 - Change Sync's Utils.arraySub to be O(n) using Set. r=tcsc
Sync's Utils.arrayUnion and Utils.arraySub are O(n^2) because Utils.arraySub uses indexOf inside a loop. This patch makes Utils.arraySub use a Set, and by doing so, Utils.arrayUnion and Utils.arraySub become O(n).

MozReview-Commit-ID: DDqjRWalfP9

--HG--
extra : rebase_source : ec90092244e16d3651f0d69ea8db1944301c13fb
2017-05-05 03:16:30 -03:00
Mark Banner 0ce286101c Bug 1359011 - Make the mozilla/recommended eslint configuration the default for the whole tree. r=mossop
MozReview-Commit-ID: HtUW43tCli1

--HG--
extra : rebase_source : 6496bc47860d9c1ab522a78e73b41550700021cb
2017-04-25 20:12:21 +01:00
Mathieu Leplatre 4fc3418733 Bug 1357116 - Load the blocklist updater module lazily r=florian,mgoodwin
Importing the blocklist-updater module on each notification in nsBlocklistService
could cause us to periodically jank the browser UI.

This patch now lazy loads as many dependencies as possible.


MozReview-Commit-ID: HBGjSJi5PwE

--HG--
extra : rebase_source : 4a7c18fe64b810f54d52eee07883d67837b297d3
2017-04-20 10:35:04 +02:00
Wes Kocher 274ba1a154 Merge inbound to central, a=merge
MozReview-Commit-ID: AFMOzsYBEjc
2017-05-15 16:22:21 -07:00
jomer14 fab6e7f663 Bug 1362510 - Remove errors.properties and references. r=eoger
MozReview-Commit-ID: 27kIRQdEHsE
2017-05-15 12:03:55 -04:00
tiago 45fdbb5730 Bug 1355663 - Don't de-duplicate tabs from multiple devices. r=eoger
MozReview-Commit-ID: AciCTECtXJc

--HG--
extra : rebase_source : 82f81f227cf27cf03c4672f0402641010434e74e
2017-05-12 20:54:54 -03:00
Edouard Oger 3d2e65ee7e Bug 1364571 - Delay Weave startup. r=kitcambridge
MozReview-Commit-ID: 4bm1LXLD7lV

--HG--
extra : rebase_source : c1b14b70e4d952870800387f16c7fecab9667b49
2017-05-12 17:01:25 -04:00
Honza Bambas d6d727a69e backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-13 13:55:11 +02:00
Wes Kocher 0a1e1fe23b Backed out changeset 95ff98f1c2e5 (bug 1319111) for talos failures a=backout
MozReview-Commit-ID: Gs09moFm5rQ
2017-05-12 18:24:42 -07:00
Honza Bambas 70f62bdec1 backout of f9abb9c83452 (bug 1319111) for crashes, r=bz 2017-05-12 22:13:49 +02:00
Florian Quèze 4e937e42a2 Bug 1353542 - Cleanup the script output and fix tests, r=Mossop. 2017-05-12 14:54:05 +02:00
Thom Chiovoloni 65e959c068 Bug 1357814 - Changes to sync's TPS tests to allow running from automation r=markh
1. Ensure we wait for browser-delayed-startup-finished
2. Parse the profile we're cleaning up from the cleanup phase name instead of
   using the selectedProfile.
3. Ensure that bookmark repair doesn't run randomly (this isn't necessary, but
   the repair code can make the actual reason for failure much more difficult to
   debug, and could probably cause a test to pass when it should not).
4. Add multiprocessCompatible flags so that TPS can still start in nightly (and
   because it is).

MozReview-Commit-ID: 98UvRoFOdzv

--HG--
extra : rebase_source : ff1f199eafdcc569cfdf9cb373ee4d059b37ec35
2017-05-05 14:54:03 -04:00
Kit Cambridge 103b72ff2f Bug 1335891 - Ensure and test that Sync changes don't bump the score. r=markh
MozReview-Commit-ID: 4dP5oZS3pm

--HG--
extra : rebase_source : ebada671d4aa5feba290f118e370fd7def093c4a
2017-05-09 13:04:50 -07:00
Kit Cambridge 2401fa0477 Bug 1335891 - Trigger another sync if tracked items have changed during the last sync. r=markh
MozReview-Commit-ID: 7EcIX7QrsN4

--HG--
extra : rebase_source : 41f0886f5e40b9b8aaaebc5ebaa40a247bba13ef
2017-05-10 19:21:16 -07:00
Ethan Glasser-Camp 3abedf0d48 Bug 1363430: Update kinto-http.js to 4.3.4, r=MattN
MozReview-Commit-ID: BenayrfXlKC

--HG--
extra : rebase_source : d8b09f46532eba84adbca253f47f434b3fff918e
2017-05-09 12:27:11 -04:00
Thom Chiovoloni 0c6fcd0d50 Bug 1362099 - Make RESTRequest handle GET's where the response is > 8192 bytes and we know the charset r=markh
MozReview-Commit-ID: 6g8hCvr7ZbJ

--HG--
extra : rebase_source : 740e44f4cf6be265e2c04a78d4737a118f0a1b3f
2017-05-05 16:29:01 -04:00
Frederik Braun cd1cbcef0f Bug 1359350: Add no-eval rule to eslint config (and whitelist failures in tests) r=standard8
MozReview-Commit-ID: 4nYlX4sSdbF

--HG--
extra : rebase_source : cf610e7d8bf2b8dbd5a0d40c5b835bc6620c3bba
2017-05-08 14:50:50 +02:00
Kit Cambridge 5fc76a861d Bug 1361171 - Remove CloudSync. r=markh
MozReview-Commit-ID: CjBsEZa6oIP

--HG--
extra : rebase_source : 965db37197242acf63e77dbcca74a2984532b4ff
2017-05-01 14:43:00 -07:00
Carsten "Tomcat" Book fdc689ba16 merge mozilla-inbound to mozilla-central a=merge 2017-05-05 15:17:26 +02:00
Honza Bambas a1b64b4694 Bug 1319111 - Expose URI to make security check against on LoadInfo (no LOAD_REPLACE flag). r=bz 2017-01-27 19:10:01 +01:00
Edouard Oger b3b3ff9cc5 Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : dcba087df94d06b15c9f073ff2df3324fd646c57
2017-04-18 14:15:43 -04:00
Edouard Oger 1df337c9ce Bug 1361572 - Remove Task.jsm/Promise.jsm from services/. r=kitcambridge
MozReview-Commit-ID: BBIkpIkWIYc

--HG--
extra : rebase_source : a0f10b07bad20789e2d1c2c2bca133b32bf671aa
2017-05-02 19:29:33 -04:00
Sebastian Hengst 18253e3fa2 Backed out changeset 0a0138825fb5 (bug 1353571)
--HG--
rename : browser/base/content/test/sync/accounts_testRemoteCommands.html => browser/base/content/test/general/accounts_testRemoteCommands.html
rename : browser/base/content/test/sync/browser_fxa_web_channel.html => browser/base/content/test/general/browser_fxa_web_channel.html
rename : browser/base/content/test/sync/content_aboutAccounts.js => browser/base/content/test/general/content_aboutAccounts.js
2017-05-03 21:56:44 +02:00
Edouard Oger c11e66021d Bug 1353571 part 3 - Refactor browser-syncui and browser-fxaccounts. r=markh
MozReview-Commit-ID: K790Ag8WZgv

--HG--
rename : browser/base/content/test/general/accounts_testRemoteCommands.html => browser/base/content/test/sync/accounts_testRemoteCommands.html
rename : browser/base/content/test/general/browser_fxa_web_channel.html => browser/base/content/test/sync/browser_fxa_web_channel.html
rename : browser/base/content/test/general/content_aboutAccounts.js => browser/base/content/test/sync/content_aboutAccounts.js
extra : rebase_source : aa6cb209d312c6ef3f45589b0fd8fa8a39c612e3
2017-04-18 14:15:43 -04:00
Edouard Oger b80261a3ec Bug 1358648 part 3 - Remove Async, Services and XPCOMUtils from util.js. r=markh
MozReview-Commit-ID: 8na204K9cXp

--HG--
extra : rebase_source : 96e7738aa6612cf67543d50053f50c2bccf1ab7e
2017-05-02 16:57:37 -04:00
Edouard Oger abba8c5b31 Bug 1358648 part 2 - Remove util.js Svc.{DefaultPrefs,Session,Idle, FormHistory} and Str. r=markh
MozReview-Commit-ID: Jc1th8Snvhv

--HG--
extra : rebase_source : dd950a5d7bb0f2cb2ea4f32c7b61eb2a15ae327d
2017-05-02 18:30:23 -04:00
Edouard Oger 712abbc07a Bug 1358648 part 1 - Clean-up some Weave imports. r=markh
MozReview-Commit-ID: 2NK4Mew65UT

--HG--
extra : rebase_source : f515a4c26f2ac515c67d37f4cf01f79427b38221
2017-05-02 18:27:49 -04:00
Sebastian Hengst 43a868766b Backed out changeset 83fe6517d5be (bug 1357116) for eslint failures in blocklist-clients.js. r=backout 2017-05-02 19:59:32 +02:00
Mathieu Leplatre ec15502b47 Bug 1357116 - Load the blocklist updater module lazily r=florian,mgoodwin
MozReview-Commit-ID: IjdpY9JZQPL

--HG--
extra : rebase_source : 1c2968fff0c0a11f0adf68f0bc9b0905ed4ac457
2017-04-27 14:45:57 +02:00
Dan Banner f2a6a685fe Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
MozReview-Commit-ID: D6qH5XtEtHO

--HG--
extra : rebase_source : 8e4c319c7fb8b727ac0193e5dd78411e1ec2785c
2017-04-27 17:24:18 +01:00
Mathieu Leplatre 250807ae85 Bug 1347728 - Fix JSON dump of blocklists r=kjozwiak,mgoodwin
MozReview-Commit-ID: rwX5Nn9d6b

--HG--
extra : rebase_source : ad24a54d4be06028d1af93cfdb31beb3e4124b1b
2017-03-22 15:46:55 +01:00
Carsten "Tomcat" Book 8cb9279791 Backed out changeset e6177d883f37 (bug 1359540) for eslint failures 2017-05-02 09:25:45 +02:00
Dan Banner 0c2aa823c9 Bug 1359540 - Enable the Mozilla ESlint recommended rules for services/. r=markh
MozReview-Commit-ID: D6qH5XtEtHO

--HG--
extra : rebase_source : 3d8d878810c60dc339e196eaac0215f9f72cc829
2017-04-27 17:24:18 +01:00
Kit Cambridge dcce7ae769 Bug 1348699 - Add test to ensure we don't track left pane queries. r=mak,markh
MozReview-Commit-ID: LFoCpvz2rAn

--HG--
extra : rebase_source : c2e927100899b5856d0fc2350efdf0e1ffb52e77
2017-03-20 19:22:15 -07:00
Kit Cambridge 5b32e800fa Bug 1350030 - Extract `serverForEngine` into `serverForEnginesWithKeys`. r=tcsc
MozReview-Commit-ID: 3D1xwv9k76m

--HG--
extra : rebase_source : a27836cea6100fd90e15ed95b08c9f02e6c79605
2017-03-30 18:01:19 -07:00
Thom Chiovoloni 20f27ffe75 Bug 1361818 - Make sure TPS is aware sync's collection.get method is asynchronous now r=markh
Ideally we'd convert this to promises, but this function is already full of
promiseSpinningly's and removing them all is too much work for this bug.

MozReview-Commit-ID: 144JFRwejTb

--HG--
extra : rebase_source : 40371c6cfeee9fddffe4b737cbb98fecb424b719
2017-05-03 15:12:30 -04:00
Alexandre Poirot c90bccb53a Bug 1356231 - Use toolkit EventEmitter.jsm instead of devtools module. r=mossop
MozReview-Commit-ID: 49JI7NtLwKK

--HG--
extra : rebase_source : 7fb015f56be94c4bbe2d56506653f069c9ad8dd3
2017-04-27 17:58:09 +02:00
Florian Queze 4b1556a5f2 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Mark Banner 29c680ad80 Bug 1359140 - Fix various ESLint issues in services/ (mostly automatic). r=markh
This fixes various errors raised in services for the rules: key-spacing, quotes, no-else-return, no-extra-semi, comma-spacing, object-shorthand.

MozReview-Commit-ID: IClwG5rfXfW

--HG--
extra : rebase_source : 81c059dacfc39b5cf8bc85b9b746dcdd494a3629
2017-04-24 18:52:57 +01:00
Edouard Oger 1b936ebd82 Bug 1356112 - Set identity.fxaccounts.settings.devices.uri when using the FxA well-known configuration. r=tcsc
MozReview-Commit-ID: IJaMuIorXHg

--HG--
extra : rebase_source : 9dc1e723632c1821af5299e6f91c54471c4855f6
2017-04-20 13:57:23 -04:00
Mark Hammond 00431016d0 Bug 1355677 - Make all Sync network requests promise based. r=kitcambridge,rnewman,tcsc
MozReview-Commit-ID: JSwAS4Xd1uy

--HG--
extra : rebase_source : 95724c3b59576d40cafd2f380ff42acb4fc3d553
2017-04-11 23:40:53 +10:00
Sebastian Hengst ceb65c045e Backed out changeset 816a2cc1254a (bug 1347728) for failing xpcshell's test_blocklist_certificates.js on Windows r=backout 2017-04-20 19:11:04 +02:00
Mathieu Leplatre 04cf765d30 Bug 1347728 - Fix JSON dump of blocklists r=kjozwiak,mgoodwin
MozReview-Commit-ID: rwX5Nn9d6b

--HG--
extra : rebase_source : 5df03011e57211e6cf2d67f1bda3f71d188c7f91
2017-03-22 15:46:55 +01:00
Thom Chiovoloni 8b9281c90a Bug 1350135 - Fix failing TPS test_history_collision.js test r=markh
There were three issues here: The first is that the TPS's history module didn't
wait for PlacesUtils.history.remove's promise to resolve.

The second is that the SYNC_WIPE_REMOTE in the previous client would cause a
write to the clients collection, which would cause the next client to get a
"sync:collection_changed" push. This caused a sync of *only* the clients
collection upon reciept, which would prevent TPS from explicitly syncing all
engines.

The third is that TPS wasn't correctly handling the cases where logIn would
trigger a sync, which would cause a failure during the first sync of a session.
This would cause failures on other TPS tests as well.

MozReview-Commit-ID: LpqZ7Kt9fyy

--HG--
extra : rebase_source : f1d3c40e2ef4e09cce4d2ce8ae25f2c86ddfee45
2017-04-19 14:38:00 -04:00
Thom Chiovoloni 0bb64306d4 Bug 1346175 - Record AsyncResource.serverTime in sync telemetry events. r=bsmedberg,markh
MozReview-Commit-ID: DG43B9zEHaO

--HG--
extra : rebase_source : 9b16fe1dff50574036fb2e10224d8056fe415ecd
2017-04-04 13:51:16 -04:00
Marco Bonardo 12dcd10d01 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj

--HG--
extra : rebase_source : 55120252e7ea8abb91f21ca2486deddc43795142
2017-04-14 20:34:27 +02:00
Carsten "Tomcat" Book 16969b40e2 Backed out changeset eb94759f0fcf (bug 1356567) for test failures in own test 2017-04-18 12:58:09 +02:00
Marco Bonardo 5238755b71 Bug 1356567 - root icons should still create a page association if the domain differs. r=adw,kitcambridge
Root domain icons are no more associated with their pages, BUT if the page uses
a root domain icon from another domain, it should still get an association with it
or we couldn't relate the two.

This also fixes an overlooked problem in PlacesTestUtils where Date objects
cross a boundary and fail instanceof checks. This causes failures in the same
test that this patch is modifying.
To protect from future similar issues some protection has been added to updatedPlaces
so that it will crash in debug builds.

MozReview-Commit-ID: 3MTKhGj3ehj

--HG--
extra : rebase_source : e36ba1ab41649927f92fee053c10bf43474a0bcf
2017-04-14 20:34:27 +02:00
tiago c05723ef0c Bug 986501 - Avoid unnecessary compartments on Sync startup r=markh
MozReview-Commit-ID: 8Rr3JD4dfVy

--HG--
extra : rebase_source : b18f24229bbd1caf80d9f175a79c1fdb0aeccd0d
2017-04-13 20:36:08 -03:00
Edouard Oger c8bcf1e705 Bug 1351915 - Fire onItemChanged when deduping sync bookmarks. r=kitcambridge
MozReview-Commit-ID: JHaCz42aRwx

--HG--
extra : rebase_source : 38361447a7900c55dc56cc5b528be5045181fee2
2017-04-08 19:57:39 -04:00
Florian Queze 4c6a68d1c9 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze f935ddc4b3 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 37ff4fc7cc Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst 159215e6f4 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst a07223d699 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Sebastian Hengst 738d097aae Backed out changeset 55f3df15eaa6 (bug 1356569) 2017-04-14 23:39:17 +02:00
Florian Queze 3c564a2b02 Bug 1356569 - Remove notifyObservers' last parameter when it is falsy, r=jaws. 2017-04-14 21:51:39 +02:00
Florian Queze 95d4d20c17 Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze a363fb8c8b Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Thom Chiovoloni daf505ef20 Bug 595314 - Add TPS test ensuring that new changes to existing bookmarks are respected by sync r=markh
MozReview-Commit-ID: B2A60B3ufYb

--HG--
extra : rebase_source : bc30afdc09497f9bcdda85493f02faa8fe8afb17
2017-04-05 12:39:00 -04:00
Thom Chiovoloni 3c9fc16ebc Bug 1345744 - Ensure an error log is written when sync (newly) fails to apply records. r=markh
MozReview-Commit-ID: 586faUBtX6n

--HG--
extra : rebase_source : 7e1d0eab656838f3718260a11ef8cd2d9b501d17
2017-04-04 14:18:09 -04:00
hrishikesh ea83c7b70d Bug 1351906 - Moved log.trace before return statement to fix unreachable code issue in history.js. r=Standard8 2017-04-05 11:03:01 +05:30
Nathan Froyd 1a5c10bc46 Bug 1348454 - use a single thread for IdentityCryptoService; r=jesup
Rather than starting a single thread for every key generation and key
signing operation started by IdentityCryptoService, and then leaking
those threads, we can at least start a single thread to be used by all
operations and leak that instead.
2017-04-03 15:41:54 -04:00
Edouard Oger d09f746bfb Bug 1345955 - Update FxA profile when push notification received. r=markh
MozReview-Commit-ID: 4LL6F5Qnnj4

--HG--
extra : rebase_source : 00bc6a445d22fdfb626e7af6ad62fb750f444460
2017-03-16 17:15:18 -04:00
Carsten "Tomcat" Book 74e36e1adb Merge mozilla-central to autoland on a CLOSED TREE
--HG--
extra : amend_source : 5026c19958cdc458c0f0887582fd00b8038fe93e
2017-03-30 16:48:10 +02:00
Florian Queze 0ac961905a Bug 1351659 - Use jwcrypto.jsm with the resource://services-crypto prefix, r=markh. 2017-03-30 09:18:45 +02:00
Edouard Oger 557fa7b36a Bug 1350665 - Disable sync repair tests on beta and release. r=kitcambridge
MozReview-Commit-ID: 6anD2FJ2aQ2

--HG--
extra : rebase_source : 708b1c52d0ecbad5407d3d27db0c5d14c8bfa73e
2017-03-29 15:27:25 -04:00
Thom Chiovoloni f189ba9211 Bug 1349703 - (part 3) Delete a test from TPS that was testing that we made the wrong decision during reconciliation r=kitcambridge
MozReview-Commit-ID: KVRcVNJAKfg

--HG--
extra : rebase_source : c37b394f0a97488f783db0b751ea2f5f9c454f8d
2017-03-23 17:18:32 -04:00
Thom Chiovoloni 250adc135f Bug 1349703 - (part 2) Fix intermittent TPS failures caused by failing cleanup by waiting longer before starting r=kitcambridge
MozReview-Commit-ID: D07eRgqHVOu

--HG--
extra : rebase_source : e08a57c3340cfd22bde9009c8cc960859b719eed
2017-03-23 16:34:04 -04:00
Thom Chiovoloni 908a695b92 Bug 1349703 - (part 1) Fix issue where sync would fail misreconcile special folders in fresh syncs r=kitcambridge
MozReview-Commit-ID: Izy9JgMYpom

--HG--
extra : rebase_source : b740e81aafbabae2947fd26888c677065742db96
2017-03-23 16:32:40 -04:00
Edouard Oger 2f0a83abc1 Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
MozReview-Commit-ID: 9Wxq2wfUnkb

--HG--
extra : rebase_source : 133133eb765a403a77ca3bbd0d8302c0a0be49a0
2017-03-24 11:12:48 -04:00
Sebastian Hengst 7ebbcc1624 Backed out changeset 16d562074791 (bug 1339340) for failing xpcshell test services/sync/tests/unit/test_doctor.js. r=backout 2017-03-24 00:52:29 +01:00
Edouard Oger 125d3015c3 Bug 1339340 - Repair items the bookmark validator reports as missing on the client or server. r=tcsc
MozReview-Commit-ID: 9Wxq2wfUnkb

--HG--
extra : rebase_source : 8dfe36e5c2d75291e07d61341648dec95b5dd213
2017-03-14 18:02:20 -04:00
Kit Cambridge 55c8025ae4 Bug 1349709 - Ensure `PasswordEngine` conforms to the new `pullAllChanges` interface. r=tcsc
This was a regression from bug 1317223. This commit also adds a
password engine sync test to catch future regressions.

MozReview-Commit-ID: 9dq8K39jLwB

--HG--
extra : rebase_source : 346c4abaf639f7781426f4e06e988c76cf552422
2017-03-22 19:21:08 -07:00
Edouard Oger d20541b101 Bug 692700 part 2 - Set X-If-Unmodified-Since when uploading crypto/keys. r=markh
MozReview-Commit-ID: 9qrr8vuvy1I

--HG--
extra : rebase_source : 9c20bdec7a33d0cde2e31c3109bf3cb9665352ba
2017-03-14 15:56:08 -04:00
Edouard Oger 1ee65dc313 Bug 692700 part 1 - Set X-If-Unmodified-Since when uploading meta/global. r=markh
MozReview-Commit-ID: IoiThiDlvCj

--HG--
extra : rebase_source : f78434e661810f9b42da6d58422713fd20687e28
2017-03-14 14:42:24 -04:00
Zibi Braniecki 3d91da8726 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 513ed31d995864939aa893e73c81ffdf591a6617
2017-03-14 16:09:54 -07:00
Sebastian Hengst 0a04f3b9e2 Backed out changeset cc308a73ad05 (bug 1347314) for eslint failure in test_device.html. r=backout 2017-03-22 18:20:26 +01:00
Zibi Braniecki c2cd68a689 Bug 1347314 - Migrate calls to ChromeRegistry::GetSelectedLocale to use LocaleService::GetAppLocale. r=jfkthame,Pike
In cases, where the caller is looking for the locale to be used for JS Intl API,
we can now replace it with `undefined` which causes JS Intl API to use the default
locale which since bug 1346674 is resolved to the app locale.

This allows us to remove a lot of calls for the app locale.

The remaining ones are split between `AsBCP47` and `AsLangTag`.
Here, the `AsLangTag` is used, as described in the API docs, for cases where
the language string is used for localization purposes, such as language negotaition
matching to our language resources etc.
`AsBCP47` is used when the returned value is handed over to ICU API.

MozReview-Commit-ID: DzmFEUvMq3N

--HG--
extra : rebase_source : 13fa4c397ba4c79303a2cd76684b5b8c4bd17331
2017-03-14 16:09:54 -07:00
Kit Cambridge c4565c993a Bug 1343093 - Add integration test for bookmark repair. r=markh
This test replaces the clients engine to simulate two different
clients, and uses `SOURCE_SYNC` to bypass change tracking.

MozReview-Commit-ID: IF3b3WZtain

--HG--
extra : rebase_source : deff5eb74dcbc29d7e7556b4ce6e15590ee4d4a0
2017-03-21 11:54:06 -07:00
Mark Banner bd625e4e9f Bug 1347712 - Change the testing configurations into ESLint configurations within eslint-plugin-mozilla - automatically update .eslintrc.js test config files for new config locations. r=jaws
MozReview-Commit-ID: LH0CQOPfoe6

--HG--
extra : rebase_source : 83eaf40c5cbb5e25cfb3f3b5afadf4fbf0422c92
2017-03-20 12:36:37 +01:00
Thom Chiovoloni f38275a306 Bug 1339163 - Make TPS tests attempt to automatically verify fxa emails when using a restmail account r=markh
MozReview-Commit-ID: LwBrVSXFqyc

--HG--
extra : rebase_source : c09b6afe7ea3827760618d7fa6421bf36bc601bf
2017-03-17 16:41:58 -04:00
Thom Chiovoloni 130ff3a299 Bug 1345754 - Skip sync bookmark repair and validation if we have pending changes r=markh
MozReview-Commit-ID: ClQRXGZGV9p

--HG--
extra : rebase_source : 4ae8ead7a9121dc383fcfc5ebf757f44e46f5679
2017-03-14 14:26:20 -04:00
Carsten "Tomcat" Book 6fd1303c2a merge mozilla-inbound to mozilla-central a=merge 2017-03-21 12:04:43 +01:00
Wes Kocher 5d7c0bee97 Merge m-c to inbound a=merge
MozReview-Commit-ID: 860fBgcgHiy
2017-03-20 18:28:24 -07:00
Florian Queze 25f26ab751 Bug 1348570 - Make chrome://weave/locale/ point to the correct folder, r=markh. 2017-03-21 01:31:21 +01:00
Thom Chiovoloni 4f8d16041f Bug 1342320 - Use PlacesUtils and not PlacesSyncUtils in sync bookmark decline/undecline test r=markh
MozReview-Commit-ID: DgbCeKgSxoE

--HG--
extra : rebase_source : d7a73f871436a3c557e3ea921439da3e6f55e13c
2017-03-14 13:01:10 -04:00
Edouard Oger e4ec1eb1d3 Bug 1343735 - Respect max_record_payload_bytes limit. r=markh
MozReview-Commit-ID: 1aDwl1cq2Hh

--HG--
extra : rebase_source : a29abc5c1f3b9eefea26fe93b5ee82f4b3d12924
2017-03-15 17:12:17 -04:00
Mark Hammond dfa642bc63 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : f13d7ef61b343820347579b76352cd65a322c8eb
2017-03-20 19:13:42 +11:00
Wes Kocher 1a61788cb8 Backed out changeset a2ec162fa051 (bug 1348743) for eslint failures a=backout
MozReview-Commit-ID: 2rfgqYueacf
2017-03-20 16:32:06 -07:00
Mark Hammond 10c7be4d14 Bug 1348743 - avoid running a bookmark validation on every sync. r=tcsc
MozReview-Commit-ID: 49sWR56kfrj

--HG--
extra : rebase_source : e68d0050fb3b6b48e5c61abed98827dbbf449923
2017-03-20 19:13:42 +11:00
David Rajchenbach-Teller d4d95b1155 Bug 1087255 - Convert Sync JS clients of RemovePage(s) to History.remove;r=rnewman 2014-10-31 12:36:19 +01:00
Carsten "Tomcat" Book 3e0a5441c6 Merge mozilla-central to mozilla-inbound 2017-03-17 14:55:15 +01:00
Mark Hammond f13f9ed085 Bug 1347373 - better handling of requests that have only non-existing items and of errors. r=kitcambridge
MozReview-Commit-ID: 7kcky3wJb4j

--HG--
extra : rebase_source : 108dde9145e323410e8799053581dc9bb4b80e42
2017-03-16 20:53:06 +11:00
Florian Quèze 9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Joseph Cameron 4ad85c5308 Bug 1345023 - Changed SYNC_API_VERSION to 1.5 and updated SUPPORTED_PROTOCOL_VERSIONS to reflect this change. r=markh
MozReview-Commit-ID: 98knOLicr9E

--HG--
extra : rebase_source : 1acbb125c0512842abdfab068094cc744ce2d329
2017-03-15 22:18:43 -04:00
David Rajchenbach-Teller 2508d8532a Bug 1086549 - Converting Sync tests from removePage to History.remove. Patch by Yoric, updated by Standard8. r=markh
MozReview-Commit-ID: 3dZljFrvJUA

--HG--
extra : rebase_source : 355265e0dbdc169df308ba15212997373f781ea3
2014-10-24 14:57:02 +02:00
Edouard Oger a014194719 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : d8e1bb4f52723071d395db3ac3c896096ca6df2a
2017-03-10 20:14:51 -05:00
Carsten "Tomcat" Book c1edc7067d merge mozilla-inbound to mozilla-central a=merge 2017-03-13 15:22:26 +01:00
Wes Kocher 77632ccd1b Merge m-c to inbound, a=merge
MozReview-Commit-ID: JXQqoTEXxwz
2017-03-10 17:22:54 -08:00
BharatR123 4e41b48a97 Bug 1332557 - Enable sync success logs by default on Nightly. r=markh
MozReview-Commit-ID: 3c0iIF1ZLr0

--HG--
extra : rebase_source : f074f570dcf2da93ccd73bf4dea3d3a8597d3b54
2017-03-10 15:33:58 +05:30
Joel Maher d1d17eb800 Bug 1345556 - adjust BUG_COMPONENT for services/blocklist/* files. r=leplatrem
MozReview-Commit-ID: LmfXawUVhIn
2017-03-10 12:26:58 -05:00
Wes Kocher 65140a44e3 Merge inbound to central, a=merge CLOSED TREE
MozReview-Commit-ID: Gj4s6DtqKmw
2017-03-09 16:33:31 -08:00
Edouard Oger 682b54d712 Bug 1339861 - Mark Sync clients as stale if not in the FxA device list. r=markh
MozReview-Commit-ID: 84Tl3QTHInO

--HG--
extra : rebase_source : c05a5462be71b9eb0bc1bddc6a6a74f1b13088b7
2017-02-28 16:35:01 -05:00
Ethan Glasser-Camp db142ded6a Bug 1329069: Upgrade kinto-http-client.js to v4.0.0, r=MattN
Version 4.0.0 removes the default five-second timeout for all HTTP
requests. This should hopefully fix bug 1329069, bug 1335519, and bug
1333677. It should also make us more robust "in the wild" against
laggy connections or slow servers. We don't need to worry too much
about instituting our own timeout because Necko will impose a timeout
for us according to the preferences network.http.response.timeout and
network.http.keep-alive.timeout.

Version 3.0.0 updates some dependencies and changes some polyfills
around. See https://github.com/Kinto/kinto-http.js/pull/158 for more
details.

MozReview-Commit-ID: 4eAwghOpqfE

--HG--
extra : rebase_source : 9657c3b3f9f0e905845933c123fe099c4408dd29
2017-03-02 17:44:18 -05:00
BharatR123 56b41b115e Bug 1345009 - remove _migratePrefs() function and related test and references in xpcshell.ini r=markh
MozReview-Commit-ID: CbXXPLNXUet

--HG--
extra : rebase_source : 81ace434bc1ecdff3a84b9c8a978343d052ad1ea
2017-03-07 14:41:46 +05:30
Kit Cambridge 35e400d22b Bug 1345005 - Ensure validation prefs are set for all tests that run a full sync. r=tcsc
Some of our tests call `Svc.Prefs.resetBranch("")` or
`Service.startOver()`, which resets the validation prefs to their
default values. This patch makes it a bit more explicit which tests
perform a full sync, and should run validation.

MozReview-Commit-ID: 7a0wR8nuJeW

--HG--
extra : rebase_source : 18ff025671c9dd5e2e30d441940f5c2fb804cae3
2017-03-06 11:29:19 -08:00
Florian Quèze 7f1b926f29 Bug 1344711 - hand cleanup of cases that were ignored by the script to remove try blocks around get*Pref calls, r=jaws.
--HG--
extra : rebase_source : 4da1e10b87ac37de19e0ca6f79996e8a12492db9
2017-03-07 15:29:48 +01:00
Florian Quèze cd762cc83c Bug 1344711 - script-generated patch to remove try blocks around get*Pref calls, r=jaws.
--HG--
extra : rebase_source : c6e20e6e79b0ca5de751c52712d96cbea9432d26
2017-03-07 15:29:48 +01:00
Carsten "Tomcat" Book 11a63f44ea merge autoland to mozilla-central a=merge 2017-03-07 15:04:48 +01:00
ffxbld cce942762c Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release
MozReview-Commit-ID: GEyM0F1O4hP
2017-03-06 23:53:55 +01:00
Carsten "Tomcat" Book 1bc7720a43 Backed out changeset 0bd17b868a31 (bug 1335877) for causing regression bug 1344760 2017-03-06 17:03:11 +01:00
Edouard Oger 69b317e280 Bug 1321119 - Allow to Sync more tabs and reduce tabs history to 5. r=markh
MozReview-Commit-ID: 7kRg4XQeT4C

--HG--
extra : rebase_source : 7558c92cc3fefe1ade2359008df9102f5ba72322
2017-03-01 13:47:20 -05:00
Zibi Braniecki 4b7b3d4092 Bug 1335877 - Remove resource://services-common/stringbundle.js. r=rnewman
MozReview-Commit-ID: M7V6JS5myy

--HG--
extra : rebase_source : a47d739d3dd67ce563088aaf9fab5421de376cd7
2017-03-02 15:26:53 -08:00
Mark Hammond b86ff30666 Bug 1317223 (part 7) - disable tests on ASAN due to bug 1344085. r=kitcambridge
MozReview-Commit-ID: 6L72ACMcDBq
2017-03-03 10:54:45 +11:00
Mark Hammond 5712360194 Bug 1317223 (part 6) - integration tests for the bookmark repair requestor and responder. r=tcsc
A poor start, but at least it's something.

MozReview-Commit-ID: 8us4v6Y21oM
2017-03-01 23:17:05 +11:00
Mark Hammond 9b6693b8ee Bug 1317223 (part 5) - a bookmark repair responder. r=kitcambridge
This is the "repair responder" - it handles a "repairRequest" command sent
by another client and attempts to take the list of IDs that client lists as
missing and upload whatever records are necessary such that the requesting
client would then be likely to find a complete and valid tree on the server.

MozReview-Commit-ID: 4xw19nH6EfL
2017-02-28 15:34:37 +11:00
Kit Cambridge 46e87ef366 Bug 1317223 (part 4) - formalize weak tracking in `BookmarksChangeset`. r=markh
MozReview-Commit-ID: C6otrtSuhZH
2017-02-06 10:19:27 -08:00
Mark Hammond 8c4e55d022 Bug 1317223 (part 3) - a bookmark repair requestor. r=markh,tcsc
The bookmark repair requestor takes the validation results and possibly
initiates a bookmark repair.

MozReview-Commit-ID: 7rRNbBx8Vo3
2017-03-02 19:21:53 +11:00
Mark Hammond de20e8f357 Bug 1317223 (part 2) - add 'doctor' concept and move bookmark validation logic to it. r=tcsc
This patch defines the concept of a "doctor" for collections. The doctor is
responsible for running all validators and deciding whether or not to initiate
a repair request based on the validation results.

MozReview-Commit-ID: 6NLRE6L0OpA
2017-03-02 17:14:31 +11:00
Mark Hammond fdeace22db Bug 1317223 (part 1) - a collection_repair module (without any repairers) and integration with the clients engine. r=rnewman
This creates a collection_repair module, somewhat analogous to the existing
collection_validator module. This defines the public interface to request a
new repair and respond to a remote repair request, and also includes changes
to clients.js to call this public interface.

MozReview-Commit-ID: 9JPpRrLgFoR
2017-03-02 16:14:51 +11:00
Mark Hammond 79d7981ee8 Bug 1342851 - record the last-modified time of a Sync client record. r=rnewman
MozReview-Commit-ID: 2jtCsl3sy3X

--HG--
extra : rebase_source : f0d24ca1a990abd8499f7f07eb7561840441dd1a
2017-02-27 12:44:12 +11:00
Joel Maher 5708b8f058 Bug 1345556 - add BUG_COMPONENT to services/* files. r=rfkelly, kit
MozReview-Commit-ID: 3QzgxUDL5xa
2017-03-09 05:33:31 -05:00
Zibi Braniecki 100766fec4 Bug 1335877 - Remove resource://services-common/stringbundle.js from gecko. r=gandalf
MozReview-Commit-ID: FNoj7XH71E4

--HG--
extra : rebase_source : 294d3e425ca60e2aac6149998da7f39f62864ae5
2017-03-06 09:39:52 -08:00
Thom Chiovoloni 25c588b7f3 Bug 1321740 - Avoid a full sync after signing in due to fxa reauthentication. r=markh
MozReview-Commit-ID: 8wVq1RYojUS

--HG--
extra : rebase_source : d0ba2c635d1de121476e8f8a1f9d570d7f4dc48a
2017-02-21 16:18:43 -05:00
Kris Maglione 1d0cefff4a Bug 1345345: Fix preference observers reporting changes to arbitrary sub-branches. r=rhelmer
MozReview-Commit-ID: CrGHoTiw4kz

--HG--
extra : rebase_source : b0259975f6f857eb3155e4fcc2b5cc889201384d
2017-03-07 20:10:42 -08:00
Edouard Oger fe217294a0 Bug 1346136 - Add more leeway in backoff testing. r=markh
MozReview-Commit-ID: 4M86B9BVbq9

--HG--
extra : rebase_source : 726bf645306864410f18bac78c3484e347e9ff7d
2017-03-10 15:39:41 -05:00
Wes Kocher 7c2b508df2 Backed out changeset cfe8ab5f1c08 (bug 1269277) for failures in browser_aboutAccounts.js a=backout
MozReview-Commit-ID: FgcSoHPCnoH
2017-03-10 16:55:36 -08:00
Edouard Oger 036a984325 Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 1049da5ecc1a61ef6a042f67ab37b619118eb45a
2017-03-10 15:03:07 -05:00
Edouard Oger 812a782093 Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : e5ace2f6dfd828c14edfd3f3d84da2b5043361b2
2017-03-09 15:53:08 -05:00
Mathieu Leplatre 0d98f89e16 Bug 1343216 - Add blocklist tags in xpcshell tests r=kmag
MozReview-Commit-ID: 8HDgdSSFxyU

--HG--
extra : rebase_source : 49a73ffcd60ea9f770ad7bc600512be19551fe5e
2017-03-02 11:23:24 +01:00
Wes Kocher 0cca2c83d5 Backed out changeset 9c8eac7852f6 (bug 745410) for build failures a=backout
MozReview-Commit-ID: JY6fS63iCwJ
2017-03-10 13:19:34 -08:00
Edouard Oger 5e9bd0d28b Bug 745410 - Remove microsummary support from Sync. r=kitcambridge
MozReview-Commit-ID: BdBgxHeHndj

--HG--
extra : rebase_source : 184b254f3299209f98cfc50f6630050a2ca29ab1
2017-03-10 15:03:07 -05:00
Wes Kocher 4894923a57 Backed out changeset 805da5d5567f (bug 1269277) for failures in browser_device_connected.js and browser_aboutAccounts.js a=backout
MozReview-Commit-ID: 1xafqaoxNWG
2017-03-10 12:31:13 -08:00
Edouard Oger a28ba6f4da Bug 1269277 - Add Manage Device button in Synced Tabs menu/sidebar. r=markh
MozReview-Commit-ID: 2BMgLeI0DNF

--HG--
extra : rebase_source : 048e6b5ede97b4908a65997cb674153c5e34c21d
2017-03-09 15:53:08 -05:00
Thom Chiovoloni 577f26289e Bug 676563 - Add dateAdded field to synced bookmarks r=markh,rnewman
MozReview-Commit-ID: 5dxoTGrypqm

--HG--
extra : rebase_source : 94af07afc4c0ae2faccc33247fa8f2df91683cce
2017-01-17 14:45:08 -05:00
Edouard Oger baba07044d Bug 1317667 - Use dates further in the future in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: 3R3tbbzio2I

--HG--
extra : rebase_source : f87d2261859ff7195e795e2e2ba4c5285536e6cf
2017-02-27 11:44:22 -05:00
Gijs Kruitbosch b0f2da2a20 Bug 1341097 - part 3: don't dispatch oodles of titlechanged notifications for new history entries, r=mak
MozReview-Commit-ID: 7jHOcCQ5ZBb

--HG--
extra : rebase_source : 6dff335e78857e7c860ebe7ec6ea415fe0f9e3f6
2017-02-27 18:26:21 +00:00
Masatoshi Kimura 7be7b11a1c Bug 1342144 - Remove version parameter from the type attribute of script elements. r=jmaher
This patch is generated by the following sed script:
find . ! -wholename '*/.hg*' -type f \( -iname '*.html' -o -iname '*.xhtml' -o -iname '*.xul' -o -iname '*.js' \) -exec sed -i -e 's/\(\(text\|application\)\/javascript\);version=1.[0-9]/\1/g' {} \;

MozReview-Commit-ID: AzhtdwJwVNg

--HG--
extra : rebase_source : e8f90249454c0779d926f87777f457352961748d
2017-02-23 06:10:07 +09:00
Jorg K d3e766737e Bug 1341983 - Skip test_blocklist_certificates.js for Thunderbird. r=leplatrem
--HG--
extra : rebase_source : c8f43e08a21c0f071170834dbba7448c906fe17d
2017-02-22 22:28:00 -05:00
Kit Cambridge ffd9158f97 Bug 1335752 - Disable persistence and clean up after `RotaryEngine` in tests. r=markh
MozReview-Commit-ID: 8feE9O6Dv3W

--HG--
extra : rebase_source : c01eed08e72fd4ff654b3afed0472cb5185aec4e
2017-02-13 13:48:08 -08:00
Kit Cambridge a0eae5b8e4 Bug 1335752 - Remove all observers when finalizing the tracker. r=markh
MozReview-Commit-ID: CKc19VAO9WW

--HG--
extra : rebase_source : 804897e8a18e740483fa96e980ee63a76fa2616a
2017-02-13 13:16:30 -08:00
Thom Chiovoloni c396116b69 Bug 1337993 - Ensure we mark all current bookmarks for reupload when bookmark engine enabled state changes. r=kitcambridge
MozReview-Commit-ID: 4gOmqrzUr77

--HG--
extra : rebase_source : ee645449c2bb08cc13a6b9040a0bbdd506d5c0a3
2017-02-13 14:28:06 -05:00
Edouard Oger 54ace62c98 Bug 1244622 - Add "Show More/All" (tabs) buttons in the Synced Tabs menu. r=markh
MozReview-Commit-ID: 7z9fTVCDGgF

--HG--
extra : rebase_source : 99afed681759d8f65605f6c11a8b0c72e8012888
2017-02-06 16:31:31 -05:00
Thom Chiovoloni 7586d15716 Bug 1336186 - Check separator position in sync bookmark validator. r=markh
This reverts bug 1276152.

MozReview-Commit-ID: Cdv4XPYl4cp

--HG--
extra : rebase_source : 985e68e3908ed2abe080e7d0d9ae0c1ce338f5fe
2017-02-15 16:30:59 -05:00
Mathieu Leplatre 8e621b659c Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
MozReview-Commit-ID: D53xoTa0PZu

--HG--
extra : rebase_source : a4aa143c627df0f70c15fd3589cde7a49e30d80d
2016-12-11 14:37:22 -10:00
Ethan Glasser-Camp bf7f47db2b Bug 1328974: Record metrics for chrome.storage.sync usage, r=bsmedberg,kmag
MozReview-Commit-ID: 7c2CHLuXxS6

--HG--
extra : rebase_source : f56bf58bfdf2f3ecb7fb5dbe8ee22d3a3569ae34
extra : source : c48083c4b41537af44a38722e64d8e10987ba199
2017-01-17 13:25:02 -05:00
Carsten "Tomcat" Book 9857d2af8e merge mozilla-inbound to mozilla-central a=merge 2017-02-20 14:05:25 +01:00
Mark Hammond 7b4704dcc1 Bug 1319972 - write a session ID to sync logs. r=tcsc
MozReview-Commit-ID: GY8tvMVJ0p1

--HG--
extra : rebase_source : 757c31ada9c14633076fc0d4bfac59234913f1b6
2017-02-17 15:38:11 +11:00
Mark Hammond cd73a70071 Bug 1340357 - remove all special eslint rules in services/. r=eoger
MozReview-Commit-ID: 6zMOBoWLOhJ

--HG--
extra : rebase_source : cf546abd9a52230746c0c05f7bb716cae42815bf
2017-02-17 12:34:45 +11:00
Edouard Oger 1f7391754c Bug 1337244 - Delete previous device registration when setting-up a new FxA user. r=markh
MozReview-Commit-ID: wp4OJ1nwKH

--HG--
extra : rebase_source : 31cc6e6c40c9f0b0e6efa76032a5ae5c75281306
2017-02-14 20:07:36 +01:00
Carsten "Tomcat" Book b218b4c6ae merge mozilla-inbound to mozilla-central a=merge 2017-02-16 13:15:55 +01:00
Wes Kocher 0240235e36 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 2KYT7x0b6I1
2017-02-15 19:17:03 -08:00
Phil Ringnalda 8f2ba061cd Backed out changeset 63d0ef447e81 (bug 1224528) for Android permaorange in test_blocklist_certificates.js 2017-02-15 19:07:26 -08:00
Wes Kocher 3797956aa6 Merge m-c to inbound a=merge
MozReview-Commit-ID: BemR756HJnR
2017-02-15 16:33:03 -08:00
Mayank Srivastav dcffae55e6 Bug 1337188 - Remove unused return statement from EngineManager::register. r=kit
--HG--
extra : rebase_source : a8eea63dc3b2c208ed8ffc3ac6d0ae36e8ec8489
2017-02-15 00:42:10 +05:30
Wes Kocher ed4e580ba8 Merge m-c to autoland, a=merge
MozReview-Commit-ID: LcH4J3J7fcL
2017-02-15 19:17:26 -08:00
Ethan Glasser-Camp b228d5b47d Bug 1321570 - use dependency injection for fxAccounts, r=kmag
Get rid of the ugly hack where test code monkeypatches a singleton to
convince the rest of the ExtensionStorageSync code that a fake user is
logged in. Instead, take a handle to the fxAccounts service at
construction time. Test code can provide any kind of fxAccounts it
wants, including one that has a hard-coded user.

This provokes a bunch of changes:

- ExtensionStorageSync is now no longer a singleton, but a class. You
  have to instantiate it in order to do anything with it. A global
  instance extensionStorageSync is provided for use by Sync code as
  well as WebExtension code.

- CryptoCollection is now also a class, and each ExtensionStorageSync
  instance has its own CryptoCollection. This dependency should maybe
  also be injected, but for the time being it doesn't provide us any
  value to do so.

- Converting singletons with asynchronous methods to classes is a pain
  in the neck. We convert async method foo from `foo:
  Task.async(....)` to `async foo() { .... }`. While we're here,
  convert KeyRingEncryptionRemoteTransformer#decode to async/await to
  eliminate a need for `let self = this`.

- Update Sync code and WebExtension code to use extensionStorageSync.

- There's a cyclic dependency where CryptoCollection#sync depends on
  ExtensionStorageSync#_syncCollection which depends on
  CryptoCollection#getKeyRing. As a short-term hack, we now require an
  ExtensionStorageSync argument to CryptoCollection#sync.

- KeyRingEncryptionRemoteTransformer now takes a handle to fxAccounts
  on construction time as well. Because this is the only
  EncryptionRemoteTransformer subclass that accesses fxAccounts, we
  can get rid of the hack where the tests monkeypatch something in the
  EncryptionRemoteTransformer prototype.

- CollectionKeyEncryptionRemoteTransformer now takes a handle to a
  CryptoCollection, rather than relying on a global one.

- A bunch of methods that previously assumed access to fxAccounts now
  check if fxAccounts is present (i.e. if we're on Android). Strictly
  speaking, this isn't required by this change, but it helps make
  certain kinds of failure a little easier to diagnose.

- Update tests, including extracting a domain-specific helper method
  to hide the use of CollectionKeyEncryptionRemoteTransformer. We now
  no longer monkeypatch in our mock fxaService, but pass it to the
  test so that it can do whatever it wants with it. We also provide an
  ExtensionStorageSync instance for convenience. Access to the global
  cryptoCollection is now done through an ExtensionStorageSync
  instance.

To summarize, we've gone from a situation where a bunch of singletons
had implicit dependencies on other singletons in a shared global
namespace, to a situation where dependencies are provided explicitly
using method/constructor arguments. This highlights some of the
dependencies present:

- ExtensionStorageSync depends on CryptoCollection and fxAccounts if
  it needs to sync

- Every collection created via openCollection needs a handle to
  CryptoCollection so it can correctly create its remote transformers

- CryptoCollection needs a handle to fxAccounts so it can create its
  own remote transformer for its special collection

Most of this is only possible, or at least much easier, because we no
longer try to juggle Sqlite connections but just keep one around
forever.

However, please note:

- CryptoCollection needs a handle to ExtensionStorageSync to actually
  perform syncing logic because that's where we foolishly put the
  logic to make requests

- There's still a backing Sqlite store which is shared by everything

- There's still a singleton tracking contexts that opened extensions
  which we manage to try to clean contexts up correctly

MozReview-Commit-ID: DGIzyRTdYZ1

--HG--
extra : rebase_source : 305a98b8e1ece3ae7a5e8a2fdb5c58d8e7c496d9
2017-01-10 16:44:01 -05:00
Ethan Glasser-Camp 4f7afb05a6 Bug 1321570 - Move ExtensionStorageSync crypto out of services/sync, r=kmag
Since services/sync doesn't ship on Android, this meant
conditionally-defining some variables such as `cryptoCollection` and
`CollectionKeyEncryptionRemoteTransformer` depending on whether or not
we were on Android. However, none of these definitions really rely on
functionality that isn't present on Android (although you can't really
use them yet either). Move the dependency together with the dependant
code so we can simplify a bit. This lets us remove conditional uses of
`cryptoCollection` and `CollectionKeyEncryptionRemoteTransformer`.

Because the WebExtensions source directory has more stringent eslint
rules, we end up reformatting and commenting a bit in addition to
moving.

MozReview-Commit-ID: 2ddDeymYFNi

--HG--
rename : services/sync/tests/unit/test_extension_storage_crypto.js => toolkit/components/extensions/test/xpcshell/test_ext_storage_sync_crypto.js
extra : rebase_source : f84c0810b6a447f2104f96c9dc9d6139743f269c
2017-02-13 15:06:02 -05:00
Jonathan Hao ef8f78b212 Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
--HG--
extra : rebase_source : e4a69e18154adf22e045c820ae2b3fd8a77877a6
2017-02-08 11:17:29 +08:00
Mathieu Leplatre 870ef630b6 Bug 1224528 - Load initial JSON files for blocklist r=mgoodwin
MozReview-Commit-ID: D53xoTa0PZu

--HG--
extra : rebase_source : 48481994fc4aa6afcd7ef46ac62861fc1ad6b281
2016-12-11 14:37:22 -10:00
Wes Kocher 3e40dccbed Backed out changeset 174570c9ca6b (bug 1321740) for browser_sanitizeDialog.js failures a=backout
MozReview-Commit-ID: 8zmWz4JBCVk
2017-02-15 15:02:59 -08:00
Thom Chiovoloni f38291dc93 Bug 1321740 - Avoid a full sync after signing in due to fxa reauthentication. r=markh
MozReview-Commit-ID: 8wVq1RYojUS

--HG--
extra : rebase_source : 1ed0c32fa992c7248b096bdd05e9c255930f3746
2017-02-08 16:35:00 -05:00
Phil Ringnalda aa72959f4e Bug 1338439 followup, placate eslint 2017-02-12 20:50:46 -08:00
Mark Hammond e23f30ffed Bug 1338439 - Sync event telemetry should use the same flowID when sending a command to multiple clients, and should include a reason for some commands. r=tcsc
MozReview-Commit-ID: 7a6qjRUswGL

--HG--
extra : rebase_source : a6112f4fb8762f3cde4a85aaa5ef4a8d11b15947
2017-02-10 16:49:33 +11:00
Kit Cambridge e73b9cdef7 Bug 1338668 - Ignore tag query folder IDs when comparing client and server bookmark records. r=tcsc
MozReview-Commit-ID: 2Mz9fTsTou5

--HG--
extra : rebase_source : e2030c91a20356d61677a212fa57f88d680bfb90
2017-02-10 15:03:34 -08:00
Ethan Glasser-Camp 3a3e213b7d Bug 1333810: Hash record IDs during encryption, r=kmag,rnewman
This does a sha256 of record IDs, the same way we do for collection
IDs, during encryption.

The way we compute the new ID (using an overridden method) is a little
bit of a hack, but we use the new ID as part of the HMAC. This also
invalidates a previous assumption, which is that we kept record IDs
the same during decryption.

MozReview-Commit-ID: Gbzlo9OE1he

--HG--
extra : rebase_source : 3a303cce50e60ecf0cd709da4ebef5ff98bff314
extra : intermediate-source : 033163eeac84466553d4f9636093c3b824d7cf2b
extra : source : c5c115baff4a729b064e74e87821f7ee3b9d3edb
2017-01-31 13:09:38 -05:00
Ethan Glasser-Camp e9fb891837 Bug 1333810: Encrypt record deletes, r=kmag,rnewman
Camouflage deletes as updates, according to the rules given by the new
RemoteTransformer contract.

MozReview-Commit-ID: CwVJSs2jOil

--HG--
extra : rebase_source : 88f8e1b4db0b6b7aea4ae5dcfc67af906cb01009
2017-01-27 19:27:10 -05:00
Ethan Glasser-Camp 6128dd8aef Bug 1333810: Update kinto.js version to 8.0.0, r=MattN
This allows us to transform deletes. See
https://github.com/Kinto/kinto.js/pull/640/.

MozReview-Commit-ID: 3EWcxW4Ny6s

--HG--
extra : rebase_source : 67cd78dcde8a220c7939486599f315c93b9092dc
2017-01-27 19:23:05 -05:00
Phil Ringnalda b5acb9b812 Backed out 2 changesets (bug 1336867) for (at least) eslint failures
CLOSED TREE

Backed out changeset 0a4f283638cb (bug 1336867)
Backed out changeset 837766805d75 (bug 1336867)

--HG--
rename : security/manager/ssl/tests/unit/test_sts_parser.js => security/manager/ssl/tests/gtest/STSParserTest.cpp
2017-02-09 19:02:32 -08:00
Jonathan Hao e28cb314a8 Bug 1336867 - Remove unsafeProcessHeader and isSecureHost in nsISiteSecurityService r=keeler,mgoodwin,past
--HG--
extra : rebase_source : 3b14ddfcb4107eeeb15ba5498d0b516310847c58
2017-02-08 11:17:29 +08:00
Wes Kocher 30d9ef4d29 Merge m-c to autoland, a=merge
MozReview-Commit-ID: D76dMYwFRUQ
2017-02-09 17:06:59 -08:00
Aman Dwivedi 8596d20f5f Bug 876002 - Remove nsIFormHistory2 so no synchronous form history code remains, r=markh.
MozReview-Commit-ID: 4hNAqttRddP

--HG--
extra : rebase_source : a206e30f11e8a625c29898f04498e2da628c2b91
2017-02-08 22:50:00 +01:00
Wes Kocher 6ff8201ffe Merge inbound to central, a=merge
MozReview-Commit-ID: 4mN7daXzULJ
2017-02-08 16:08:42 -08:00
Edouard Oger 5aba6580c8 Bug 1332556 - Set correct passwords' timestamps on first Sync. r=markh
MozReview-Commit-ID: Izg9sIeGNJo

--HG--
extra : rebase_source : 079f73e0e09bf9969989bb72d82736291dbe83dc
2017-02-07 12:56:56 -05:00
Ahsan 39fbeac36e Bug 1336282 - Moved bookmark frecency query into `PlacesSyncUtils`. r=kitcambridge
MozReview-Commit-ID: 4DDXOUQ2C8N

--HG--
extra : rebase_source : b4d1785e126b87672fc064dee329a791977b1372
2017-02-09 12:28:26 -08:00
Mayank Srivastav ccf5a4ca8d Bug 1333431 - Fixed ERROR_PARSE thrown on 304 response when fetching profile. r=eoger
MozReview-Commit-ID: KJPvZeU10xP

--HG--
extra : rebase_source : faaa2f7bc49d0aefd85e0f0846076290f71998c8
2017-02-07 23:25:01 +05:30
Phil Ringnalda 3063243dfc Bug 1323867 followup, placate eslint 2017-02-07 16:20:31 -08:00
Kit Cambridge 1e92ba873d Bug 1323867 - Bump bookmark validation threshold to 1k. r=tcsc
This patch also refactors `compareServerWithClient` and
`inspectServerRecords` to periodically yield back to the main thread,
since validating a large number of bookmarks in a tight loop causes
jank. Yielding every 50 records for 50ms is somewhat arbitrary, but
keeps things snappy for my profile (2947 records).

MozReview-Commit-ID: 99DJtNvNeHI

--HG--
extra : rebase_source : cc0991106c17ce906b8779afbe9eced0e27cc4b4
2017-01-12 14:02:45 -07:00
Kit Cambridge 912d625cf7 Bug 1325523 - Persist tracked IDs on finalization, and don't persist IDs in Sync tests. r=markh
MozReview-Commit-ID: CpQP2aM1DO

--HG--
extra : rebase_source : 02fa555cc44bd9d94a6c3beedf00fa1746f0c637
2017-02-07 11:51:06 -08:00
Sebastian Hengst 0264cdf6be Bug 1336311 - Change code comments with http://hg.mozilla.org to https://. r=gps
For components also referencing it in code, see the blockers of bug 1336311.

MozReview-Commit-ID: 4tUZ24HKBWy

--HG--
extra : rebase_source : ec16149f525b9b7eaca7f96f1369929d21497121
2017-02-07 17:52:56 +01:00
Mark Hammond f02fca824e Bug 1310065 - use more reliable preferences for calculating the client count in the sync scheduler. r=eoger
This patch switches to using preferences written by the clients engine to
determine the number of clients so it's correct before the first sync for
a browser session.

It also fixes another bug I discovered - if a mobile device dropped from the
client list, the preference for the number of mobile devices would remain at
1 rather than resetting to zero.

MozReview-Commit-ID: IPythSQcorx

--HG--
extra : rebase_source : 4ce465e3958d037f90312553a0c353cdc161c0fe
2017-01-25 18:11:05 +11:00
Edouard Oger 809b455084 Bug 1332858 - Alternate wording for Sync new device connected notification when device name missing. r=markh
MozReview-Commit-ID: DdwrRGjwI3

--HG--
extra : rebase_source : 9740cd1fb21fd411c73d8a29e5c3ae31bf11bcb0
2017-02-02 15:49:03 -05:00
Mathieu Leplatre 7c91ae078a Bug 1331629 - Handle Backoff header in blocklist updater (r=mossop)
MozReview-Commit-ID: 21KOLxvCC4W

--HG--
extra : rebase_source : fec6948ea0f2cbb18be1fe5f799353ec09e4aa33
2017-01-19 15:40:26 +01:00
Mathieu Leplatre 0291baa3c0 Bug 1331629 - Reuse the same kinto client instance accross syncs (r=mgoodwin)
MozReview-Commit-ID: F8Fhy9TzPTG

--HG--
extra : rebase_source : 039b099e3c6d1a7f312e3cd209e8cea317f58a32
2017-02-06 10:35:26 +01:00
Edouard Oger cfc8f37c1b Bug 1317667 - Use async bookmark methods in test_bookmark_duping. r=kitcambridge
MozReview-Commit-ID: CpvcDXKkfcl

--HG--
extra : rebase_source : 4d143bdf9af7727933a74a9f05c7a56baa5c321b
2017-02-03 13:52:39 -05:00
stefanh@inbox.com 3e60e56c26 Bug 1333485 - Remove LogUtils.jsm from services/crypto/modules/. r=markh. 2017-02-01 20:55:09 +01:00
Edouard Oger f7e895d911 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : 71c2a627bd0291fa2b9448710e6b0eb1fae36719
2017-01-24 17:05:12 -05:00
Sebastian Hengst 573326d526 Backed out changeset 20863de3b8f4 (bug 1329850) for eslint failure: redeclaration of collection in deeper scope in test_syncengine_sync.js. r=backout 2017-01-31 18:46:39 +01:00
Edouard Oger ecdeb55693 Bug 1329850 - Sync records creation failures are reported to telemetry. r=markh
MozReview-Commit-ID: AEOlmkmyIvY

--HG--
extra : rebase_source : bce1d12bf1fdb7867ac0f290fdfe4e6b5d761bcc
2017-01-24 17:05:12 -05:00
Mark Banner 8cf0d4744c Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 72df6ddc457431ae77f953a00712462e4902b5f1
2017-01-23 15:15:05 +00:00
Mark Banner df3fdf012f Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : b93a673073045ddfec6e4b4b347b4e8494425310
2017-01-23 14:07:55 +00:00
Mark Banner 2ecc79b536 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : c4b19fe3714b19b445011ae1c413ca0e624cb46e
2017-01-17 12:25:43 +00:00
Wes Kocher 7cd28f7e5d Merge inbound to central, a=merge
MozReview-Commit-ID: HvoljuLV6Gj
2017-01-27 16:37:18 -08:00
Edouard Oger 1d38375171 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH
2017-01-27 13:31:58 -05:00
Edouard Oger ffa8a4f046 Bug 1296767 part 12 - Remove Weave.fxAccountsEnabled. r=markh
MozReview-Commit-ID: L4dM9xN2ELp
2017-01-27 13:31:58 -05:00
Edouard Oger ad36606986 Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X
2017-01-27 13:31:58 -05:00
Edouard Oger 7314dabc8c Bug 1296767 part 10 - Remove FxA Migration code. r=markh
MozReview-Commit-ID: DamrbblcMmZ
2017-01-27 13:31:58 -05:00
Edouard Oger 3844e92a36 Bug 1296767 part 8 - Remove legacy Sync in-content pref screens. r=markh
MozReview-Commit-ID: Blpdd3jeeww
2017-01-27 13:31:58 -05:00
Edouard Oger f5eb6dc494 Bug 1296767 part 7 - Remove non-in-content legacy Sync pref screens. r=markh
MozReview-Commit-ID: LK9akz4chd1
2017-01-27 13:31:57 -05:00
Edouard Oger ea99e4442d Bug 1296767 part 6 - Remove startOverKeepIdentity pref. r=markh
MozReview-Commit-ID: 7YDYTCRiKZa
2017-01-27 13:30:48 -05:00
Edouard Oger cdce850c10 Bug 1296767 part 5 - Remove add_identity_test helper. r=markh
MozReview-Commit-ID: 12pP01IHRyp
2017-01-27 13:30:48 -05:00
Edouard Oger df80e282e9 Bug 1296767 part 4 - Update tests to work with the BrowserID identity manager. r=markh
MozReview-Commit-ID: AFRyZFW6xZU
2017-01-27 13:30:48 -05:00
Edouard Oger bf4dae4e25 Bug 1296767 part 3 - Make BrowserID the only Sync identity manager. r=markh
MozReview-Commit-ID: IC7kRjgtPp8
2017-01-27 13:30:47 -05:00
Edouard Oger c94655827a Bug 1296767 part 2 - Remove Sync UserApi. r=markh
MozReview-Commit-ID: CdgLxCN52Os
2017-01-27 13:30:47 -05:00
Edouard Oger bb525e4654 Bug 1296767 part 1 - Remove J-PAKE from Sync. r=markh
MozReview-Commit-ID: iD4OJv436i
2017-01-27 13:30:47 -05:00
Florian Quèze b11907c7aa Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Florian Quèze 0cb03c69e1 Bug 1334156 - replace ownerDocument.defaultView usages by hand in a few places, r=jaws. 2017-01-27 10:51:02 +01:00
Phil Ringnalda 39e57631eb Merge m-c to m-i 2017-01-25 20:48:39 -08:00
Kit Cambridge 009412ee92 Bug 1332024 - Finalize tracker storage and consolidate cleanup logic in engine tests. r=markh
MozReview-Commit-ID: 8t9bXFrLA1Z

--HG--
extra : rebase_source : 51e15f6cc8fd44947f42cc59be413df6775291b0
2017-01-24 09:59:09 -08:00
Edouard Oger 8561ffa3a2 Bug 1319433 - Bump tabs engine TTL to 21 days. r=markh
MozReview-Commit-ID: GdEZkQEdZMD

--HG--
extra : rebase_source : 949e172445996b71271788d11cf136bef95254f8
2017-01-23 11:05:41 -05:00
Carsten "Tomcat" Book aaafcb0f0a Backed out changeset f8b29e24280b (bug 1333044) for perma failures in test_load_modules.js
--HG--
extra : rebase_source : ef649da0bb1acaabcb55a42e5df4164f1cf8b6d4
2017-01-25 15:29:53 +01:00
Carsten "Tomcat" Book f868542f9b Backed out changeset 06a658a93aab (bug 1333044)
--HG--
extra : rebase_source : 554fed79a1c36ce418ab95952cde9669a3297cb6
2017-01-25 15:29:35 +01:00
Carsten "Tomcat" Book a6178c3af9 Backed out changeset 9c6b98edac72 (bug 1333044)
--HG--
extra : rebase_source : e81a05f7fa7ffca19ced3e0aca62ada7bde935b2
2017-01-25 15:29:33 +01:00
Carsten "Tomcat" Book 514a5e3a68 Backed out changeset d1f3d30546a1 (bug 1333044)
--HG--
extra : rebase_source : 272f382a06733b065cec30d2bdcec282ef847297
2017-01-25 15:29:31 +01:00
Mark Banner 605ae8736f Bug 1333044 - "Enable eslint no-undef for services/" a=tomcat 2017-01-25 05:09:00 +01:00
Carsten "Tomcat" Book ff34e66ec7 Merge mozilla-central to autoland 2017-01-25 13:52:18 +01:00
Florian Quèze 0e0865f4fc Bug 1331599 - script-generated patch to replace removeEventListener calls with the once option when possible, r=jaws. 2017-01-25 07:01:52 +01:00
Mark Banner eb102a103e Bug 1333044 - Enable no-undef eslint rule for services/. r=markh
MozReview-Commit-ID: IrtWclENDth

--HG--
extra : rebase_source : 19e5895756579ecf88d5be70e8aaaf8c3166ada1
2017-01-23 15:15:05 +00:00
Mark Banner caa2f51ce1 Bug 1333044 - Fix no-shadow issues in services/. r=markh
MozReview-Commit-ID: KqYfpjdR7QS

--HG--
extra : rebase_source : 32511d0a015fe57f0b8262b0faa28dbd4bd7a623
2017-01-23 14:07:55 +00:00
Mark Banner 33c00194c2 Bug 1333044 - Prepare services/ for enabling no-undef eslint rule. r=jaws
MozReview-Commit-ID: 29KwwyZH2jn

--HG--
extra : rebase_source : 9b5edc75897af35754433b6fccfcecf83293c62b
2017-01-17 12:25:43 +00:00
Phil Ringnalda bf98cd4315 Merge m-i to m-c, a=merge 2017-01-24 18:53:29 -08:00
stefanh@inbox.com caff960805 Bug 1313045 - Remove toolkit/identity, part2: Move used files/bits to services/crypto and remove remaining files in toolkit/identity. r=MattN.
--HG--
rename : toolkit/identity/IdentityCryptoService.cpp => services/crypto/component/IdentityCryptoService.cpp
rename : toolkit/identity/nsIIdentityCryptoService.idl => services/crypto/component/nsIIdentityCryptoService.idl
rename : toolkit/identity/LogUtils.jsm => services/crypto/modules/LogUtils.jsm
rename : toolkit/identity/jwcrypto.jsm => services/crypto/modules/jwcrypto.jsm
rename : toolkit/identity/tests/unit/test_crypto_service.js => services/crypto/tests/unit/test_crypto_service.js
rename : toolkit/identity/tests/unit/test_jwcrypto.js => services/crypto/tests/unit/test_jwcrypto.js
2017-01-23 20:43:35 +01:00
stefanh@inbox.com f28e3f1e0d Bug 1313045 - Remove toolkit/identity, part1: Remove unneeded files/bits. r=MattN. 2017-01-23 20:20:54 +01:00
Phil Ringnalda 8a8c8d9816 Merge autoland to m-c, a=merge 2017-01-23 18:42:45 -08:00
ffxbld ed04f7a449 Update configs. IGNORE BROKEN CHANGESETS CLOSED TREE NO BUG a=release ba=release 2017-01-23 15:38:06 +00:00
Thom Chiovoloni c197835bcf Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh
MozReview-Commit-ID: 3ybnskOID1O

--HG--
extra : rebase_source : 3faec9e53939626dc89c039706aaa2f003571d18
2017-01-17 13:15:49 -05:00
Edouard Oger d22c7ab8ed Bug 1332993 - Do not write logs on FxA profile 304 response. r=markh
MozReview-Commit-ID: Hf5d6rz8HNQ

--HG--
extra : rebase_source : f51a3a9b1fb0c4f5e6c56114e289f67ee99b315f
2017-01-23 11:25:04 -05:00
Sebastian Hengst 461878052c Backed out changeset ccc602619a07 (bug 1332993) for failing xpcshell test test_accounts.js at least on Linux. r=backout on a CLOSED TREE 2017-01-24 18:34:08 +01:00
Edouard Oger 274682c188 Bug 1332993 - Do not write logs on FxA profile 304 response. r=markh
MozReview-Commit-ID: Hf5d6rz8HNQ

--HG--
extra : rebase_source : 5861ee29ff229b44f999119d95a94ba673f22e2e
2017-01-23 11:25:04 -05:00
aleth 05bfbf26be Bug 1333692 - Disable nsIIdentityCryptoService and jwcrypto tests for TB as these modules are only used by FxAccounts. r=MattN. 2017-01-25 18:47:57 +01:00
Wes Kocher c3cc3b6407 Backed out 13 changesets (bug 1296767) for xpcshell failures a=backout CLOSED TREE
Backed out changeset 41ed77788333 (bug 1296767)
Backed out changeset 1c0c9289b532 (bug 1296767)
Backed out changeset 50294db1d871 (bug 1296767)
Backed out changeset 26c065f79c54 (bug 1296767)
Backed out changeset 0362a78d6978 (bug 1296767)
Backed out changeset 4e71cf94e4ee (bug 1296767)
Backed out changeset f6f59447d22a (bug 1296767)
Backed out changeset 6c9b792cc296 (bug 1296767)
Backed out changeset 46a52b10a868 (bug 1296767)
Backed out changeset 5d70d87d2a8f (bug 1296767)
Backed out changeset 8219686be6a2 (bug 1296767)
Backed out changeset 0a989b0cea67 (bug 1296767)
Backed out changeset 9f59a0b75c1f (bug 1296767)

MozReview-Commit-ID: 2XBNsd8JrZL

--HG--
extra : amend_source : 1afafaa8127fcebac31ce1d7743dc16872fa0522
2017-01-26 11:16:12 -08:00
Edouard Oger 1595b78c75 Bug 1296767 part 13 - Repair Weave Service getStorageInfo. r=markh
MozReview-Commit-ID: E4S5xYTNDIH

--HG--
extra : rebase_source : 6a98b9503183bbf679622b00073d162fd3e4f5e4
2017-01-23 15:19:04 -05:00
Edouard Oger b0e947451a Bug 1296767 part 12 - Remove Weave.fxAccountsEnabled. r=markh
MozReview-Commit-ID: L4dM9xN2ELp

--HG--
extra : rebase_source : deec727f4fe7c2bc5858e7bfb6f0fecee7b2c45c
2017-01-19 14:53:37 -05:00
Edouard Oger f49ecb465d Bug 1296767 part 11 - Remove Weave.Service.serverURL and friends. r=markh
MozReview-Commit-ID: Kmsxn10sA2X

--HG--
extra : rebase_source : 87bebd2abc19a6b62647d4bcb48193765a3622e2
2017-01-19 13:19:33 -05:00
Edouard Oger 775061c90e Bug 1296767 part 10 - Remove FxA Migration code. r=markh
MozReview-Commit-ID: DamrbblcMmZ

--HG--
extra : rebase_source : 7356a6a99005ae702e90eb5d5e2f0cbee35ff861
2017-01-19 13:03:38 -05:00