Граф коммитов

5529 Коммитов

Автор SHA1 Сообщение Дата
Benjamin Bouvier 3d5c7891a5 Bug 1319203: Fix asm.js profiler test; r=me 2018-02-09 14:47:10 +01:00
Andi-Bogdan Postelnicu 9ca255c241 Bug 1405554 - Merge clang-format with clang-tidy under the same package from toolchains. r=gps
MozReview-Commit-ID: 1XokTUVmVPL

--HG--
extra : rebase_source : bd52ecd720eb3a0a145660c3c5b55922f571f9fb
2018-02-09 09:01:17 +02:00
Edouard Oger a0cec42f04 Bug 1415951 - Extend TPS to support Addresses and Credit Cards. r=tcsc
MozReview-Commit-ID: 8VKBvm60ZSH

--HG--
extra : rebase_source : 88cb7b4145db018517c920907da79c70c46d50d2
2018-02-05 14:39:32 -06:00
Andrew Halberstadt 1805dcb2d3 Bug 1436792 - [py-compat] Fix issue opening the temporary manifest on Windows, r=jmaher
MozReview-Commit-ID: FmA1K8osuqe

--HG--
extra : rebase_source : ee557c78b1c959caa10a7862fbc732b4cf11792e
2018-02-08 14:26:27 -05:00
Andrew Halberstadt 4c232ca311 Bug 1436792 - [py-compat] Improve error messaging when python is missing, r=jmaher
This patch makes a few changes around error handling:

1) Prints the name of the linter that produced non-json output
2) Changes the 'python not found' error to a warning (as this is not fatal)
3) Makes sure said warning only gets printed once (by moving it to the setup function)

MozReview-Commit-ID: Dkq7CulTs91

--HG--
extra : rebase_source : 5d4bd32a62264a88520c09420f5acd90edcdc740
2018-02-08 14:26:15 -05:00
Noemi Erli b6751c929f Backed out changeset c9d150401eea (bug 1436639) for potential local workflow issues r=ahal on a CLOSED TREE 2018-02-08 19:45:07 +02:00
Margareta Eliza Balazs 9ab2f0f44f Backed out changeset 773a25b97a66 (bug 1405554) for f8 lint failure in /builds/worker/checkouts/gecko/tools/mach_commands.py on a CLOSED TREE 2018-02-08 19:36:21 +02:00
Andi-Bogdan Postelnicu 51fc404396 Bug 1405554 - Merge clang-format with clang-tidy under the same package from toolchains. r=gps
MozReview-Commit-ID: 1XokTUVmVPL

--HG--
extra : rebase_source : 13cab9c90d98da10dcafbe788c4e8b67fcd56803
2018-01-31 11:02:23 +02:00
Andrew Halberstadt aaea466286 Bug 1436725 - [lint] Remove obsolete eslintvalidate files, r=standard8
As the eslintvalidate linters haven't been doing anything but printing
an error message for a month, this is just cleanup.

MozReview-Commit-ID: 5dhrSmEv0Gi

--HG--
extra : rebase_source : 30e588f47a69b152f72d29e6aaab7efbd59fbf09
2018-02-08 09:25:14 -05:00
Andrew Halberstadt eced3471fc Bug 1436639 - [lint] Make sure flake8 is run with same python as |mach lint| was, r=jmaher
This fixes a bug which can happen when the default version of python differs from
the version of python used with mach.

For example, mach explicitly looks for python2.7. This means running |mach lint -l flake8|
should also run flake8 with version 2.7. But if the default is python3, and flake8 is also
installed there, the subprocess call that invokes flake8 will run under python3. This can
lead to errors like "undefined name 'basestring'" and other 2to3 gotchas.

This patch ensures that we run:
python2.7 -m flake8

which explicitly runs flake8 against the same interpreter as mach, no matter the default.

MozReview-Commit-ID: HSuMzDsAvsW

--HG--
extra : rebase_source : d39f97ed0f82f4d2c81f044ef1f7dad0953a3d8d
2018-02-07 23:28:33 -05:00
Mark Banner 2fd2fd7199 Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
MozReview-Commit-ID: 1LlfamNvBEM

--HG--
extra : rebase_source : 8e41e5a5f67bfd43444fde25287cb3709452a349
2018-02-07 16:16:09 +00:00
Mark Banner b4f572f5fa Bug 1436389 - Upgrade ESLint to version 4.17.0. r=mossop
MozReview-Commit-ID: I4KBELxhBlM

--HG--
extra : rebase_source : d206fb88f8c70d161cc0541a068db1b2f02e7a37
2018-02-07 16:01:29 +00:00
Markus Stange a91565e4f5 Bug 1433583 - Discard information about old dead threads that no longer have any samples in the buffer. r=mystor
MozReview-Commit-ID: 5ThtN1H1ieA

--HG--
extra : rebase_source : f853ff92147a4d57fd778723eda32c78847e8ca5
extra : source : 61ede7cb13a5de066601492ca34eb97e17e3e6fe
2018-01-30 16:00:29 -05:00
Julien Wajsberg 7642763ce5 Bug 1428072 - 3/3 - Add a mochitest to test profiling better r=mstange
MozReview-Commit-ID: BOoS37yFznU

--HG--
extra : rebase_source : bf5e87333dcfe4eceedc8d904fe49f34ff029aec
2018-01-31 15:11:51 +01:00
Julien Wajsberg dc7beae272 Bug 1428072 - 2/3 - Reorganize mochitest files for the profiler r=mstange
We extract some common framework to run profiler tests.

MozReview-Commit-ID: 7FPcH1NpJ7S

--HG--
extra : rebase_source : a487cb34c50889112eaecc8a20553365cfb70cfa
2018-01-31 10:51:19 +01:00
Julien Wajsberg cf225ab9c6 Bug 1428072 - 1/3 - Change the implementation of isChromeJSScript so that it doesn't crash for workers r=bz,sfink
In this patch we also expose a script's compartment in jsfriendapi.h

MozReview-Commit-ID: LgoN8ANLgxI

--HG--
extra : rebase_source : a9a29e538041ac574b6b44fab166a7838fce54ac
2018-01-18 17:14:09 +01:00
Mark Banner 54c4111311 Bug 1230369 - Add ESLint rules to disallow defining Cc/Ci etc and to prefer the use of Cc/Ci rather than the Components.* equivalents. r=florian
MozReview-Commit-ID: 9eAgUO3iIJW

--HG--
extra : rebase_source : 3208d5f74477733e4c81206613f74d7c7821ac0d
2018-02-06 22:40:12 +00:00
Mark Banner 606beee3f2 Bug 1230369 - Manually fix some remaining instances of Ci/Cc/Cu definitions and switch Components.* to using the shorthand in some places. r=florian
MozReview-Commit-ID: 9SmoR9RlvZE

--HG--
extra : rebase_source : 054e14150921615ed67415ddb91b45169cc868d4
2018-02-07 09:24:15 +00:00
Markus Stange 78b15a3110 Bug 1434968 - Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped. r=njn
MozReview-Commit-ID: L1Lk0sj2Bub

--HG--
extra : rebase_source : 842b53979122b20687b64278c2be6e706c92991e
2018-02-06 17:45:39 -05:00
Andrew McCreight 754a4bcd3c Bug 1432992, part 2 - Manually remove some empty blocks. r=florian
Also, remove a now-obsolete comment from placesOverlay.xul and remove
some now-empty XPCShell test head files.

MozReview-Commit-ID: 6kKVQu8FAL3

--HG--
extra : rebase_source : 7dd05818d68a15bd170af734078db4ba45029d80
2018-01-25 16:52:25 -08:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Markus Stange 7e880fe1f8 Bug 1431179 - Keep all exit profiles that overlap with the parent process's buffer time range. r=mconley
MozReview-Commit-ID: 1DIYQZ70ckR

--HG--
extra : rebase_source : f7f5e8e2d0380b54c50cb20b3d109cb476a2530f
extra : source : 612e54e7001a5907761d831b92aed5cee0deb017
2018-02-06 15:29:05 -05:00
Markus Stange 125c79a8ce Bug 1431179 - Remove the API to obtain the time of the first sample during profile streaming. r=mystor
MozReview-Commit-ID: KfZLNIAx4gy

--HG--
extra : rebase_source : 6b1a2dc19955a3a19877403f36d9dad551a9dc8a
extra : source : 6a241d9b3d1adf1afa72aab53ef8e15ece75fe90
2018-01-26 15:30:55 -05:00
Markus Stange 030cf34ac9 Bug 1431179 - When storing an exit profile, remember the current write position of the parent process's profiler buffer, instead of a TimeStamp. r=mystor
MozReview-Commit-ID: 3SFo9r5VrcZ

--HG--
extra : rebase_source : 2be8143e369de6dab82e1c1ef40a049aa478276c
extra : source : 9531d79fa5c3de2051a31fc475f6bbe3c93659a6
2018-01-30 13:28:35 -05:00
Markus Stange 49d6d03730 Bug 1348959 - Remove wraparound indexing in ProfileBuffer. r=djvj,mystor,njn
MozReview-Commit-ID: LeBFSRE6GXR

--HG--
extra : rebase_source : c46c0cd0dd543a367f72000e3cae65260a25b365
extra : source : 0f2e9dd7d45551d40944e4219e5a9eb92d54b2c4
2018-02-06 00:25:30 -05:00
Markus Stange 519cb27db8 Bug 1348959 - Make profiler_get_buffer_info() return information in a struct instead of using outparams. r=mystor,njn
MozReview-Commit-ID: 1iJ05NxOdou

--HG--
extra : rebase_source : 1c4e654340630b0f21c165b41b8fc1be30743c48
extra : source : 64b1a4108f6c3319cfc74c1246bdd2e895e93e1a
2018-01-18 17:54:57 -05:00
Markus Stange 656fd03724 Bug 1348959 - Make ProfileBuffer fields uint32_t. r=mystor,njn
MozReview-Commit-ID: veIGhEQyK5

--HG--
extra : rebase_source : 2c1853f666afd300ff82a2717f1a7caf9a19cf98
extra : source : e3d8bdc726d6045f69f3c3efa4e91c499a418428
2018-01-18 17:54:33 -05:00
Narcis Beleuzu 0777e2f8f7 Backed out Bug 1428072 for mochitest-chrome leaks
Backed out changeset b39c21c2a7a4 (bug 1428072) for mochitest-chrome leaks
***
Backed out changeset 9acb3d3eb5bc (bug 1428072)
***
Backed out changeset b5a327bb02d4 (bug 1428072)

--HG--
extra : histedit_source : 9de43525a11c34bb0e48c0820857d1731d4e7a08%2Cd3f59b67cd382c41cd0b68fd0f7a521a1051d20c
2018-02-06 15:48:32 +02:00
Julien Wajsberg ca83804232 Bug 1428072 - 3/3 - Add a mochitest to test profiling better r=mstange
MozReview-Commit-ID: 7tNEXHzFzRo

--HG--
extra : rebase_source : 3cb7fe208f6048c286c62be3216d09d5ea4eace4
2018-01-31 15:11:51 +01:00
Julien Wajsberg 163c3aa665 Bug 1428072 - 2/3 - Reorganize mochitest files for the profiler r=mstange
We extract some common framework to run profiler tests.

MozReview-Commit-ID: 7ct5RMhwmOe

--HG--
extra : rebase_source : 01165c506a4325310c23c9be6de2f5e6f958cf00
2018-01-31 10:51:19 +01:00
Julien Wajsberg 51a60aaee4 Bug 1428072 - 1/3 - Change the implementation of isChromeJSScript so that it doesn't crash for workers r=bz,sfink
In this patch we also expose a script's compartment in jsfriendapi.h

MozReview-Commit-ID: JGTLygZ6DK5

--HG--
extra : rebase_source : 585edbdbc74044f2d644f5046513786ee4f42a2f
2018-01-18 17:14:09 +01:00
Andrew Halberstadt eb84bf741c Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown
This allows linters to define a 'setup' method which will automatically be
called by |mach lint| before running the linter. Users can also explicitly run
these methods (without doing any actual linting) by running |mach lint --setup|.

MozReview-Commit-ID: 74aY1pfsaX1

--HG--
extra : rebase_source : e6a7d769ba14c996c7a77316928063fa46358c5a
2018-01-25 13:40:02 -05:00
Nick Alexander 9d65a9cea8 Bug 1435424 - Remove doxygen support from the build system. r=gps
This is ancient and the team that used it (gfx) is no longer using it.

MozReview-Commit-ID: HrDgmAU9QeW

--HG--
extra : rebase_source : c4a64965c4ae1a50888893e881a6e8a9688a58b6
2018-02-02 14:24:18 -08:00
Andrew Halberstadt 4a7ebcb3bb Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 r=rwood
MozReview-Commit-ID: BBtM4TEl4Ve

--HG--
extra : rebase_source : 94d276746401426c9adcae5c962380679ffcb083
2018-01-30 16:43:10 -05:00
Andrew Halberstadt f354075c7a Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN

--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
Andrew Halberstadt 974ae38a52 Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable r=rwood
The flake8 linter requires a specific version of flake8, so that running it
locally vs in CI vs in mozreview will all produce the same results.

Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment
variable, subverts that goal and can result in unexplained errors showing up in
some configurations but not others.

MozReview-Commit-ID: 1s0nC8ZO6Qi

--HG--
extra : rebase_source : f3913e2bce7770edf8deba18890f063975ca0844
2018-01-31 14:05:52 -05:00
Gurzau Raul bb16936244 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-02 00:25:44 +02:00
Gurzau Raul 1315ffda06 Merge inbound to mozilla-central. a=merge 2018-02-02 00:22:39 +02:00
Florian Quèze fcd9a3a0c8 Bug 1339461 - add an eslint rule to detect when indexOf should be replaced with includes, r=Standard8. 2018-02-01 20:47:23 +01:00
Florian Quèze 2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Andrew McCreight cf2f48b80d Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
MozReview-Commit-ID: 4PyMh0WeA4r

--HG--
extra : rebase_source : 868258ad6d98698f13faee5d6af67adcb20b63a2
2018-01-25 09:45:45 -08:00
Bogdan Tara 5c052cc871 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-01-31 12:10:31 +02:00
Bogdan Tara 1a6614b8b5 Merge inbound to mozilla-central. a=merge 2018-01-31 12:00:14 +02:00
Mark Banner 9a2172526a Bug 1434449 - Enable no-unused-vars for the global (as well as local) scope on jsm files, whitelist directories still to be fixed. r=florian.
MozReview-Commit-ID: 3vBWDR3UjGF

--HG--
extra : rebase_source : 61495d14a8d761e71b4072b02e2ca57e77f44059
2018-01-30 22:10:08 +00:00
Dorel Luca aefaa99a3a Backed out 3 changesets (bug 1431755) for Mochitest failure on test_profile_worker_bug_1428076.html on a CLOSED TREE
Backed out changeset c1befb56cf4d (bug 1431755)
Backed out changeset 8116e9cfc3f0 (bug 1431755)
Backed out changeset 1878f143ccda (bug 1431755)
2018-01-31 00:58:04 +02:00
arthur.iakab c4dd80eca3 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Mark Banner 15e66f33ed Bug 1434332 - Add a checklist for adding new linters to the tree. r=ahal
MozReview-Commit-ID: FnYIXS5oZvW

--HG--
extra : rebase_source : 2eba61a24a4ca313f3c1d65adef454e34c57bdb5
2018-01-30 16:55:20 +00:00
Byron Campen [:bwc] da943dc517 Bug 1431755 - Part 3: Remove a redundant dispatch that was causing us to record the duration of _two_ dispatches instead of one. r=mstange
MozReview-Commit-ID: E8lSvMbGjt6

--HG--
extra : rebase_source : b303d66dfedcaa272cd851563a1a7585c4779fac
2018-01-19 10:03:35 -06:00
Byron Campen [:bwc] 44f6431bb0 Bug 1431755 - Part 2: Teach GeckoProfiler to profile responsiveness on nsIThreads. r=mstange
MozReview-Commit-ID: AqpNf9pDzrg

--HG--
extra : rebase_source : d873d9f05115004417b4c0d98dd8dceaef263172
2018-01-19 09:42:47 -06:00
Dorel Luca 0e6d4442ff Backed out 2 changesets (bug 767640) for talos failure on scripts/MozillaFileLogger.js on a CLOSED TREE
Backed out changeset 073aecb9bee5 (bug 767640)
Backed out changeset 6bc5ccfb1bd3 (bug 767640)
2018-01-30 21:53:28 +02:00