It be ideal to have |mach test {findbugs,test}| and |mach lint
{lint,checkstyle}|, but the |mach test| command is very difficult to
extend in a direction orthogonal to the existing direction. The
existing |mach test| is built around in-tree manifests, tagged and
divided into suites, intended to support |mach test
path/to/arbitrary/test|. The Android findbugs task is a global static
analysis that doesn't fit into the path/manifest model. The Android
test task is based on JUnit and not easy to build manifest support
for. The |mach lint| command is intended to be extended, but the
effort to extend it is non-trivial and not worth the effort (at this
time).
Therefore, I've taken the existing, little used |mach android| command
and added subcommands for use by local developers and automation. If
nothing else, this reduces the number of "special Gradle targets" --
the equivalent of "special Make targets" -- sprinkled throughout the
tree, which can only be a good thing!
MozReview-Commit-ID: 24b1vbgykpN
--HG--
extra : rebase_source : 8843a6e3840586fe05a1434484a848d48b2a6e8b
We want HTML reports for humans and XML reports for processing. It's
unfortunate that we need to handle this manually, but here we are.
MozReview-Commit-ID: BKEhl7cInPP
--HG--
extra : rebase_source : 8d48b664903bce32def8f0762a86d31c250c3853
Menu item to pin/unpin items from Bookmarks and History panels is only displayed when
Activity Stream is enabled.
MozReview-Commit-ID: Ko3xmpF2R53
--HG--
extra : rebase_source : 4eefb81224c1cc00ba2eb6147e26119af647d317
No functional change, simply tightening things up.
MozReview-Commit-ID: 43iHr29NyIx
--HG--
extra : rebase_source : 61b8b6c7cb908826835286fac061762d60d2198e
Gecko's mainthread message queue is getting more tasks along with each creation of GeckoHlsPlayer. We should avoid adding extra work load to gecko's main thread.
MozReview-Commit-ID: 2c5fnmG2hfS
--HG--
extra : rebase_source : 892290a6e4d2c9b120b6dec9d0aae51d0dc0c05d
This patch is pretty hard to read and review. It only changes styles in
Photon flavor to match designer's design. Includes layout, dimension,
colors....etc. Australis flavor should not aware of this patch.
MozReview-Commit-ID: 9ROK1NcwJfC
--HG--
extra : rebase_source : e4dcd66c7d62c42996cf2f80353be0b0a9bd8cb7
We draw curve for Toolbar only in Australis flavor.
Also change resource naming for highlight color to be consistent with
Phton flavor.
MozReview-Commit-ID: E7cFuJs3r6h
--HG--
extra : rebase_source : bbb7e980f93c135433e5941bac9d65e751feb5f1
Some views in BrowserToolbar is Themed-view, and should be notified by any
normal/private mode changing.
MozReview-Commit-ID: 8hkizdsf0AO
--HG--
extra : rebase_source : 8a2a62e13b1b48713ece3554c0b9423307e9e213
Stop button is in Awesome bar to stop page loading, to let it becomes
ThemedImageButton to support Private mode.
MozReview-Commit-ID: CzbCyx1Mxc4
--HG--
extra : rebase_source : e21de93ca83eb3ed470bc2ede5a090c9e77ff5f7
PageAction are views which be added to awesomebar dynamically, for
example "Reader mode icon".
Now let it becomes ThemedImageButton to support Private mode.
MozReview-Commit-ID: HQXgJWL19Oz
--HG--
extra : rebase_source : 7cfde97d4f1eba02497d0219e5b3b61273489625
The icon for site-identity of Photon is different from Australis. Even
in Photon there are still two version, one for normal mode, one for
private mode.
We cannot simply use tinting to change color of site-identity. Because
of the lock icon should keep green.
MozReview-Commit-ID: Je7wXrq1gEK
--HG--
extra : rebase_source : 7717b5f68b3b61826583cf400637e2a309c952ef
In Photon flavor, only one view for menu button is enough. This patch is to
merge menu and menu-icon into one ThemedImageButton.
MozReview-Commit-ID: KyjsriirmbA
--HG--
extra : rebase_source : 33a7c083f0b8896fdbf95e1ff891ac4ed3bf76fd
We are going to change action_bar_button but we won't effect Australia
flavor.
MozReview-Commit-ID: A1bR7Dyg0xj
--HG--
rename : mobile/android/app/src/main/res/drawable/action_bar_button.xml => mobile/android/app/src/australis/res/drawable/action_bar_button.xml
extra : rebase_source : 768368e4d1e7f7def0822f1af0ebdde5f8df1ae1
These resource files are for photon only, and might be updated in near
future. Now we add them into repository for basic implementation.
For toolbar action button, to add these files
* ic_mic
* ic_qrcode
* ic_cancel
* ic_overflow
* ic_redermode / on
For site-identity, to add these files
* ic_globe /nm
* ic_lock
* ic_lock_disabled
* ic_warning_minor
--HG--
extra : rebase_source : 56050d212e53481ed0ddaa867ffc6f3da0f86ded
The new, preferred solution for displaying additional web content outside of our normal tab infrastructure and UI is to use a separate GeckoView instance. Therefore, the support for different having additional "tab" types that aren't displayed in the normal UI, as well as for multiple GeckoApp instances displaying different tabs is no longer needed and can be removed.
MozReview-Commit-ID: FNx0gJIKybr
--HG--
extra : rebase_source : 4059e03db9586317c9c2928cef1d6dc98406319b
The crash reason is that our package name [1] is not the same as the name from
packageManager's getPackagesForUid(uid) [2].
Not sure what causes it and how it happen, but we can catch this exception first
to avoid the crash.
[1] https://goo.gl/ezJvWB
[2] https://goo.gl/6Q8b6M
MozReview-Commit-ID: HrTfubxHNSk
--HG--
extra : rebase_source : e1f4bcbbaaf0168550e7ddc3d739de790ad61d1d
This patch introduces a notion of "changed" count during bookmark deletions, and firms up
our deletion logic to ensure we're counting affected records correctly.
Changes are mostly clearer comments describing what's going on, as well tests to ensure
we're doing the right thing.
One logical change is that this patch drops an additional call to updateBookmarks. AFAIK,
that call is unnecessary. It doesn't achieve its stated goal of writing first (it performs
a select first), and since we're doing a deletion, the "bump timestamps of an old parent
in case parent changed" logic is unused).
MozReview-Commit-ID: 9B1FW9pgsf1
--HG--
extra : rebase_source : dd8f10c58fd0042f94072bb99c28dc4545165dd5
This patch is pretty hard to read and review. It only changes styles in
Photon flavor to match designer's design. Includes layout, dimension,
colors....etc. Australis flavor should not aware of this patch.
MozReview-Commit-ID: 9ROK1NcwJfC
--HG--
extra : rebase_source : d280919e2ef43d072b4762e84e80f7bc3002bfdd
We draw curve for Toolbar only in Australis flavor.
Also change resource naming for highlight color to be consistent with
Phton flavor.
MozReview-Commit-ID: E7cFuJs3r6h
--HG--
extra : rebase_source : 1bf7d1557a3b614d7c2b8c3f743d4247353e45c8
Some views in BrowserToolbar is Themed-view, and should be notified by any
normal/private mode changing.
MozReview-Commit-ID: 8hkizdsf0AO
--HG--
extra : rebase_source : 24e5e3a281af23d40dcff766b91d5692633b4ff1
Stop button is in Awesome bar to stop page loading, to let it becomes
ThemedImageButton to support Private mode.
MozReview-Commit-ID: CzbCyx1Mxc4
--HG--
extra : rebase_source : edc17213daae80112602cd8b2d28e546f6a391ab
PageAction are views which be added to awesomebar dynamically, for
example "Reader mode icon".
Now let it becomes ThemedImageButton to support Private mode.
MozReview-Commit-ID: HQXgJWL19Oz
--HG--
extra : rebase_source : 8428d005875c1c1b24e72fb9ef431060b8b02b5a
The icon for site-identity of Photon is different from Australis. Even
in Photon there are still two version, one for normal mode, one for
private mode.
We cannot simply use tinting to change color of site-identity. Because
of the lock icon should keep green.
MozReview-Commit-ID: Je7wXrq1gEK
--HG--
extra : rebase_source : 1d4cfb1b364f3c00818a57febb81f061aebb7250
Nick Alexander
Grigory Kruglov
Nevin Chen
Kilik Kuo
Julian_Chu
Jan Henning
Sebastian Hengst
Alastor Wu
friedger