8240adec88
Bug 1230311 - add annotation to enforce that if a method is overridden also base method is called. r=nfroyd
...
MozReview-Commit-ID: AQ3Kx2qidU0
2016-10-04 17:00:17 +03:00
76b800594e
Backed out changeset d85334f696eb (bug 1285057) for implicitly depending on clang 3.8.
...
--HG--
extra : rebase_source : 472f9411c9d528d63d523c99f4842a1216bdd560
2016-09-23 15:59:55 -07:00
b605dece0c
Bug 1285057 - Blacklist UBSan detection of the GC's generic interfaces; r=sfink
...
--HG--
extra : rebase_source : f5367a8685ec462edb7e30e5ed3d274b4a9bcd0f
2016-07-07 08:59:36 -07:00
5a1fd6c4d4
Bug 525063 - add attribute to mark functions that initialize member variables for their parent class, in order to be scanned by clang-plugin static analysis. r=froydnj
...
MozReview-Commit-ID: 5yTnTUVLpSC
2016-08-30 10:07:03 +03:00
0b2d2c0e55
Bug 1120059 - Remove unnecessary MOZ_EXPLICIT_CONVERSION macros. r=jwalden
...
MozReview-Commit-ID: 7CX1VnBRDpk
--HG--
extra : rebase_source : 36be7e6c91d2767c5a610a2806f89efa69ff1c74
2016-07-13 15:07:52 -07:00
43c2748f66
Bug 1277775 - Replace MOZ_CONSTEXPR{_VAR,_TMPL} with constexpr. r=froydnj
2016-07-08 14:39:53 -07:00
5e3fc1519f
Bug 525063 - renamed MOZ_INITIALIZED_OUTSIDE_CONSTRUCTOR -> MOZ_INIT_OUTSIDE_CTOR. r=nfroyd
...
MozReview-Commit-ID: GPQY8b2OM2V
2016-06-28 16:30:49 +03:00
12bac0f757
Bug 525063 - add attribute to mark member variables that should be skipped by clang plugin initialization checker. r=nfroyd
...
MozReview-Commit-ID: 4V1YcK2thiF
2016-06-09 09:32:11 +03:00
2511b2c327
Bug 1267550 (part 2) - Rename MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. r=froydnj.
...
It's an annotation that is used a lot, and should be used even more, so a
shorter name is better.
MozReview-Commit-ID: 1VS4Dney4WX
--HG--
extra : rebase_source : b26919c1b0fcb32e5339adeef5be5becae6032cf
2016-04-27 14:16:50 +10:00
a5c843fe5f
Bug 1267550 (part 1) - Rename MOZ_MUST_USE as MOZ_MUST_USE_TYPE. r=ehsan.
...
This will allow MOZ_MUST_USE to be used for a different and more common case.
MozReview-Commit-ID: 4dQsdWjJfc6
--HG--
extra : rebase_source : 390ab56ef83d71eb6d28759a0195a79a78b153bd
2016-04-27 08:22:10 +10:00
1999c10d91
Bug 1266294 - Remove unnecessary compiler version checks for gcc <= 4.8.0 in mfbt. r=froydnj
2016-04-17 17:08:10 -07:00
575dbe7dfd
Bug 1264827 - Part 3: Add the MOZ_NEEDS_MEMMOVABLE_MEMBERS annotation to MFBT; r=froydnj
2016-04-18 15:43:48 -04:00
a240a28c7f
Bug 1080968 - Don't use constexpr on clang-cl when emulating MSVC 2013
...
constexpr-ness of things can change the ABI requirements, and MSVC 2013
doesn't support constexpr, so choosing it for clang-cl when emulating
MSVC 2013 will cause ABI incomap issues between object files compiled
with the two compilers.
This reverts part of the commit for the original bug.
2016-01-27 21:10:03 -05:00
2b12d59585
Bug 1226376 - Part 1: Allow non-trivial constexpr constructors in MOZ_TRIVIAL_CTOR_DTOR classes, r=ehsan
2016-01-08 15:34:24 -05:00
3171200ff5
Bug 1235277 - Define MOZ_FALLTHROUGH_ASSERT to workaround -Wunreachable-code warnings about MOZ_FALLTHROUGH in debug builds. r=botond
2015-12-27 13:27:17 -07:00
0308741102
Bug 1215411 - Define MOZ_FALLTHROUGH annotation to suppress clang's -Wimplicit-fallthrough warnings. r=botond
2015-10-04 21:03:26 -07:00
2c245dc4e2
Bug 1201190 - Part 2: Add MOZ_NON_TEMPORARY_CLASS and MOZ_RAII to mfbt, r=ehsan
2015-09-12 16:53:32 -04:00
99df3288e2
Bug 1197734 - Add MOZ_HAVE_CXX11_CONSTEXPR_IN_TEMPLATES on VS2015+. r=Waldo
2015-08-25 16:53:25 +09:00
24406b034a
Bug 1189655 - Define MOZ_HAVE_CXX11_CONSTEXPR on VS2015 or later. r=Waldo
...
--HG--
extra : source : c3fa493499954504073d8abeb7104f46c4f3f953
2015-08-21 09:17:18 +10:00
f8b012d537
Bug 1192130 - Part 2: Use MOZ_NON_AUTOABLE to validate the usage of already_AddRefed, r=ehsan
2015-08-14 17:33:54 -04:00
328b8f083b
Bug 1193298 - Part 3: Delete RefPtr<T>::operator T*()&&. r=froydnj
...
I put MOZ_HAVE_REF_QUALIFIERS in Attributes.h for lack of a better
place. I didn't especially want to make a whole new file for it.
To make the tree compile, support for moving RefPtr to nsRefPtr was
needed. I chose to put the definitions in RefPtr.h instead of
nsRefPtr.h because RefPtr.h looks to be included in fewer files, so I
preferred to bloat fewer files with the extra include.
For some reason operator!() wasn't necessary here, although it seems it
is for nsRefPtr.
2015-08-11 06:45:00 -04:00
c3a87d5439
Bug 885515 - Part 2: Add MOZ_HEAP_CLASS to mfbt, r=ehsan
2015-08-09 12:42:11 -04:00
f75a6aad6a
Bug 1190313 - Set MOZ_HAVE_EXPLICIT_CONVERSION on VS2015. r=nfroyd
2015-08-05 17:14:42 +09:00
e0cec02548
Bug 1187073 - Use MOZ_INHERIT_TYPE_ANNOTATIONS_FROM_TEMPLATE_ARGS to validate the usage of AlignedStorage2. r=ehsan
...
--HG--
extra : rebase_source : 43caddb03d8bf630edd6f8f60f5dff0e8890e7b8
2015-07-31 13:59:00 -04:00
20eee585a6
Bug 1159433 - Part 2: Add the MOZ_NON_MEMMOVABLE and MOZ_NEEDS_MEMMOVABLE_TYPE macros to MFBT; r=froydnj
2015-07-24 19:15:18 -04:00
69cc6fcb31
Bug 1123907 - Part 2: Add MOZ_NEEDS_NO_VTABLE_TYPE to Attributes.h, and use it to verify the EntryType argument of nsTHashtable; r=ehsan
2015-07-24 19:14:09 -04:00
1d1140657d
Bug 1180993 - Part 2: Add the MOZ_MUST_USE attribute to mfbt, and use it to verify usage of already_AddRefed. r=ehsan
2015-07-06 21:42:00 -04:00
e8c55f4a45
Bug 1169337 - Clarify MOZ_{NON_,}OWNING_REF/MOZ_UNSAFE_REF documentation. r=froydnj
2015-06-01 14:44:00 -04:00
6afdd6c96b
Bug 1145051: Use MOZ_WARN_UNUSED_RESULT instead of NS_WARN_UNUSED_RESULT. r=glandium
...
--HG--
extra : rebase_source : d210822225d307f3e3685cb5f95b461c48c0be7e
2015-03-19 00:46:40 -07:00
a778e9f970
Bug 1145051: Replace uses of NS_ATTR_MALLOC with new MOZ_ALLOCATOR from mfbt/Attributes.h. r=glandium
...
--HG--
extra : rebase_source : 294215445f084687ed7fa51b88e7a22e586447a2
2015-03-18 23:56:08 -07:00
b775223668
Bug 1143011 - Extract the has/add/take logic out of the register sets to distinguish between allocatable and live sets. r=jandem,Waldo
2015-03-28 01:08:12 +01:00
f26168deba
Bug 1145631 - Part 6: Remove MOZ_OVERRIDE and MOZ_FINAL; r=froydnj
2015-03-21 12:28:53 -04:00
7a13d87f08
Bug 1131783 - Optimize away null checks in non-POD Vectors too r=waldo
2015-02-12 08:37:01 -08:00
f233dc0d72
Bug 1125185 - Define MOZ_COLD for marking "cold" functions r=waldo
2015-01-26 17:30:19 -08:00
5b86ecf80c
bug 1077549 - remove useless gcc version checks r=glandium
2015-01-15 21:30:05 -05:00
47c67459e2
Backed out changeset 11aebde6e809 (bug 1120059) because of build bustage on Windows
2015-01-13 00:26:16 -05:00
3bbc9f5d8f
Bug 1120059 - Remove MOZ_{HAVE_,}EXPLICIT_CONVERSION. r=Waldo
2015-01-13 06:41:15 +02:00
9e23388ca8
Bug 1118076 - Remove MOZ_THIS_IN_INITIALIZER_LIST. r=Waldo
2015-01-06 21:39:46 -08:00
fdd4d16ff4
Bug 1118486 - Part 2: Remove MOZ_DELETE macro and use `= delete` directly; r=Waldo
2015-01-09 09:44:05 -05:00
039292de5d
Bug 1119071 - Clean up some code used for older unsupported MSVC versions in MFBT; r=froydnj
2015-01-08 10:40:15 -05:00
860da94550
Bug 1114999 - Part 2: Apply MOZ_NO_ADDREF_RELEASE_ON_RETURN to all smart pointer arrow operators that can return refcounted objects; r=jrmuizel
2015-01-06 16:30:03 -05:00
da6750e5e7
Bug 1114987 - Add MOZ_UNSAFE_REF and mark GlobalObject::mGlobalObject as such; r=smaug
2015-01-05 21:01:30 -05:00
9297631e0b
Bug 1114880 follow-up: Rename MOZ_{STRONG,WEAK}_REF to MOZ_{OWNING,NON_OWNING}_REF
...
--HG--
extra : rebase_source : 51fff0785d112b5b87be3c6ff723c8986b37effe
2014-12-23 21:17:50 -05:00
d67ef95234
Bug 1114696 - Add MOZ_STRONG_REF and MOZ_WEAK_REF annotations; r=froydnj
2014-12-22 18:16:55 -05:00
89b6ff71bc
Bug 1114267 - Part 2: Add MOZ_TRIVIAL_CTOR_DTOR to MOZ_ONLY_USED_TO_AVOID_STATIC_CONSTRUCTORS in non-debug builds; r=jrmuizel
2014-12-22 18:16:16 -05:00
d945a5c5ae
Bug 773014 - Part 2: Mark Static{Auto,Ref}Ptr as global-only; r=jrmuizel
2014-12-22 18:10:44 -05:00
93d92d03da
No bug - fix typo r=me
2014-12-19 12:40:30 -06:00
1813ae2d33
Bug 867348 - Part 2: Apply MOZ_NO_ARITHMETIC_EXPR_IN_ARGUMENT to CheckedInt's constructor; r=jrmuizel,cpearce
...
Note that the analysis currently just looks at the AST subtree of the
function call site and is therefore unable to correctly deal with cases
such as the last two hunks of the change to OggCodecState.cpp. Fixing
the analysis to deal with that would be very difficult, so we currently
adjust the code so that it compiles. The first hunk in that file though
is a real bug that this analysis found.
2014-12-18 15:27:05 -05:00
3d7d4af71d
Backed out changesets acb4dd16755c and 40768f723990 (bug 867348) for static analysis bustage.
...
CLOSED TREE
2014-12-18 15:59:51 -05:00
2e80a88820
Bug 867348 - Part 2: Apply MOZ_NO_ARITHMETIC_EXPR_IN_ARGUMENT to CheckedInt's constructor; r=jrmuizel
...
Note that the analysis currently just looks at the AST subtree of the
function call site and is therefore unable to correctly deal with cases
such as the last two hunks of the change to OggCodecState.cpp. Fixing
the analysis to deal with that would be very difficult, so we currently
adjust the code so that it compiles. The first hunk in that file though
is a real bug that this analysis found.
--HG--
extra : rebase_source : b44bb6d90d95551d860e0b5a1afcf2bb35cde084
2014-12-18 15:27:05 -05:00
d5c7fe43fd
Bug 1080968 - Add support for constexpr and explicit conversions on clang-cl; r=froydnj
...
--HG--
extra : rebase_source : ef22967d83577e70d5e6e122bf5322f31eeb97d0
2014-10-10 18:29:56 -04:00
2a0942be41
Bug 1036789 - Convert the third quarter of MFBT to Gecko style. r=Ms2ger.
...
--HG--
extra : rebase_source : 668cd394806203ddfa34bd4f226335ff26c846b5
2014-07-10 19:10:17 -07:00
9439ff268e
Bug 1026319 - Convert the second quarter of MFBT to Gecko style. r=froydnj.
...
--HG--
extra : rebase_source : 98d2557c7fe4648d79143c654e7e31767fca2e65
2014-06-12 23:34:08 -07:00
b65d47a0ad
Bug 1023449 - Try to check for MSVC before clang so that we live in the clang-cl world when building with that compiler; r=froydnj
...
--HG--
extra : rebase_source : dbfcf19afa0aa030d4fc769f29ede4c957af669d
2014-06-10 16:33:39 -04:00
7e98d1c248
Bug 1014377 - Convert the first quarter of MFBT to Gecko style. r=froydnj.
...
--HG--
extra : rebase_source : b3b2da775e2c0e8a6ecbed70e7bd0c8f7af67b47
2014-05-29 22:40:33 -07:00
80e1f6f0e4
Fix a typo in a comment, no bug, DONTBUILD
2014-05-22 09:28:06 -04:00
4ca5ac62f7
Bug 1013662 - Part 1: Add MOZ_IMPLICIT to Attributes.h; r=froydnj
...
--HG--
extra : rebase_source : 4654de918e6f73f40c34a19cfd1b457ba2c734f1
2014-05-21 21:31:29 -04:00
6e74be8757
Bug 997145 - Add a attribute in order to silent a Clang static analyzer check r=nfroyd
...
--HG--
extra : amend_source : 9ef01d8df4e8797981f770621a3885d456db5801
2014-05-06 16:23:08 +02:00
9827caf183
Bug 987253 - Add MOZ_EXPLICIT_CONVERSION - r=Waldo
2014-04-25 22:34:04 -04:00
595322b886
Bug 961394 - update MOZ_ASAN_BLACKLIST to work with recent versions of GCC; r=ehsan
2014-01-21 12:51:03 -05:00
f39213113a
Bug 929200, part 1: Add MOZ_HEAP_ALLOCATOR to stack-only/non-heap analyses, r=Waldo.
...
--HG--
extra : rebase_source : 1ea94cf7a8ab7207d238c65877001549f3f828be
2013-12-06 21:23:06 -06:00
592c2cad36
Bug 933586 - Define MOZ_HAVE_CXX11_DELETE for MSVC 12+. r=waldo
2013-11-02 17:57:40 +09:00
ede451acef
Bug 928210 - Get rid of MOZ_INLINE
2013-10-22 06:34:24 +09:00
6f7607f758
Bug 847350 - Add/Update MOZ_ASAN/TSAN_BLACKLIST macros. r=waldo
...
--HG--
extra : rebase_source : c4c58d30ff0b46ca57093cc0b3bbc37af56f2095
2013-10-17 16:29:11 +02:00
51f391870b
Bug 896341 - Update include guards and modelines in MFBT; r=Waldo
2013-07-24 09:41:39 +02:00
c9c3f11e7c
bug 888493 - add MOZ_CONSTEXPR_VAR r=waldo
2013-06-28 17:34:51 -04:00
7dd50910d4
Backed out changeset 454706720bbc (bug 888493) for build bustage
...
CLOSED TREE
2013-07-04 13:06:07 -07:00
7e27dbafc9
bug 888493 - add MOZ_CONSTEXPR_VAR r=waldo
2013-06-28 17:34:51 -04:00
f7d20e1769
Bug 839998 - Introduce MOZ_THIS_IN_INITIALIZER_LIST macro. r=waldo
2013-06-27 00:15:52 +09:00
b88d6bba0e
Bug 876701 - Static analysis failure in nsMathMLsemanticsFrame.h, r=karlt
2013-05-28 22:20:44 -05:00
f9295075bf
Bug 868285 - Fix static checking builds, part 2: Add MOZ_NONHEAP_CLASS. r=ehsan
...
--HG--
rename : build/clang-plugin/tests/TestStackClass.cpp => build/clang-plugin/tests/TestNonHeapClass.cpp
2013-05-27 16:05:02 -05:00
6a948c71c1
Bug 868285 - Fix static checking builds, part 1: infer MOZ_STACK_CLASS. r=bsmedberg
2013-05-27 16:04:18 -05:00
52b75b6ca8
Bug 863116 - MOZ_ALWAYS_INLINE should not inline in debug builds (r=Waldo)
2013-04-19 10:55:34 -07:00
be07522e81
Bug 856108 - Port static analyses to clang, part 1: stack-class. r=ehsan
2013-04-11 22:20:02 -05:00
5765d5aec4
Bug 767563 - Add a clang static checker, part 3: Move the MOZ_MUST_OVERRIDE macro to MFBT. r=Waldo
2013-03-23 21:14:43 -05:00
a8f5bd4bfb
Bug 839338 - ASan alloc/dealloc mismatch in _M_create_nodes/_M_destroy_nodes. r=waldo.
2013-02-12 08:30:16 -05:00
e171e76319
Bug 833254 - Fix MFBT's gcc version checks. r=waldo
2013-01-21 19:42:15 -08:00
be633156a5
Bug 835648 - Move typed enum support to a new header. r=Ms2ger
2013-01-28 16:33:17 -08:00
11e2a8437f
Backed out changeset 3eb633a97c1f (bug 835648) for suspected Windows orange on a CLOSED TREE.
2013-01-29 19:01:45 -05:00
88df194b4b
Bug 835648 - Move typed enum support to a new header. r=Ms2ger
...
--HG--
extra : rebase_source : 8c912fba889c1c5435e3619714071502fbfb30a3
2013-01-28 16:33:17 -08:00
434446ef94
Bug 831633 - Back out 1c7bdeefa8ee (bug 830315) for introducing hundreds of non-virtual dtor warnings. r=waldo
2013-01-24 22:59:46 -08:00
5c5f92058c
Bug 785918 - Part 2: Add MOZ_HAVE_CXX11_CONSTEXPR check and constexpr version of ArrayLength(). r=waldo
...
--HG--
extra : rebase_source : e826347bfdedc949614c9cca294858b7150dfda1
2013-01-07 23:29:00 -08:00
9609697ceb
Bug 830315 - Don't enable MOZ_FINAL and MOZ_DELETE on clang unless compiling as C++11. r=Waldo
2013-01-15 10:12:49 +01:00
1357e36e62
Bug 823917 - Use C++11 final on MSVC11. r=waldo
2013-01-03 04:47:26 +09:00
801c9b79ba
bug 822717 - remove checks for old gcc r=glandium
2012-12-18 13:22:28 -05:00
e485f90bb4
Bug 808876 - Part 0: Only allow the usage of enum classes in gcc 4.5 and newer; r=bzbarsky
...
Older gccs such as gcc 4.4 cannot handle comparison operators taking
arguments of the enum class type, which would cause valid C++ code
to not compile. So we should just use our fallback enum class
emulation on those platforms.
--HG--
extra : rebase_source : 3cd2fd2faabc36c767e76442efabf55f8a54c83f
2012-11-06 09:38:32 -05:00
fc2126e5b2
Add a comment about MOZ_BEGIN_ENUM_CLASS/MOZ_END_ENUM_CLASS to say that they should not be used for nested enums, no bug
...
DONTBUILD
2012-10-26 13:56:54 -04:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
bceb79b8d5
Bug 782919 - Add zero-arg constructor to enum class workaround; r=ehsan
2012-08-16 14:58:12 +03:00
26dd8a729c
Backout 19ec214f806c (bug 782916), 88b802832f52 (bug 782919), f16429aa2210 (bug 780474) for Android build failures
2012-08-17 12:25:12 +01:00
757baa9a0a
Bug 782919 - Add zero-arg constructor to enum class workaround; r=ehsan
2012-08-16 14:58:12 +03:00
0ad63bfea8
Bug 751554 part 2 - Support strongly-typed enums in MFBT; r=ehsan
2012-08-01 15:19:00 +03:00
4ae33db236
Bug 751554 part 1 - Support explicit underlying enum types in MFBT; r=cjones
2012-08-05 12:11:24 +03:00
986ff95100
Style patrol to make everything conform to mfbt/STYLE. No bug, r=sparky
2012-06-03 20:36:43 -07:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
2e32f290c8
Bug 751195 - Mark GC function unsafe for AddressSanitizer, r=billm
2012-05-05 02:08:32 -04:00
0d2f332e8c
Bug 729952 - Part 1: Add a better hash function to mfbt. r=waldo
2012-03-02 17:18:21 -05:00
b00479bc34
Bug 712129 - Move MOZ*INLINE macros from Util.h into Attributes.h, where they make more sense. r=luke
...
--HG--
extra : rebase_source : f62a21c8833c9d5eb7351b18ba14f14d4286b3c0
2011-12-19 14:45:52 -05:00
9098fa4182
Bug 711775 - Implement MOZ_NORETURN to encapsulate this-function-doesn't-return semantics. r=cjones
...
--HG--
extra : rebase_source : d56f3ef47e11c42b5fe6a442e13fd6202208914f
2011-12-17 16:45:29 -05:00
f108ab9e90
Bug 711683 - Use Clang's feature-detection macros, not its version number, for feature testing. r=cjones
...
--HG--
extra : rebase_source : fdf8e0bff705410a85bd4560f08b226321632bb1
2011-12-17 16:45:29 -05:00
Andi-Bogdan Postelnicu
Terrence Cole
Michelangelo De Simone
Chris Peterson
Nicholas Nethercote
Ehsan Akhgari
Michael Layzell
Makoto Kato
Xidorn Quan
Aryeh Gregor
Jim Blandy
Nicolas B. Pierron
Dan Gohman
Trevor Saunders
Birunthan Mohanathas
Benjamin Peterson
Ryan VanderMeulen
Sylvestre Ledru
Benoit Jacob
Nathan Froyd
Joshua Cranmer
Masatoshi Kimura
Christian Holler
Ms2ger
Phil Ringnalda
Bill McCloskey
Rafael Ávila de Espíndola
Jeff Walden
Mike Hommey
Ed Morley
Gervase Markham
Justin Lebar