Andrea Marchesini
59743dbfbf
Bug 1350933 - Labeling dom/filesystem - part 2 - DispatchTo{Current,Main}Thread, r=billm
2017-04-05 09:47:34 +02:00
Andrea Marchesini
cbea30a731
Bug 1350933 - Labeling dom/filesystem - part 1 - Runnable, r=billm
2017-04-05 09:47:09 +02:00
Andrea Marchesini
9fa58ed270
Bug 1299500 - Get rid of DeviceStorage API - part 11 - FileSystem, r=ehsan
2017-03-08 20:15:45 +01:00
Andrea Marchesini
fb4c8780f3
Bug 1299500 - Get rid of DeviceStorage API - part 9 - Directory::GetRoot, r=ehsan
2017-03-08 20:15:45 +01:00
Andrea Marchesini
30ecbb1c86
Bug 1299500 - Get rid of DeviceStorage API - part 8 - Directory::Get, r=ehsan
2017-03-08 20:15:45 +01:00
Andrea Marchesini
f7dc102b1b
Bug 1336481 - Window is not used in the ErrorCallback runnable in the Entries API, r=qdot
2017-02-03 19:51:24 +01:00
Andrea Marchesini
05dea89997
Bug 1284987 - Entries API - part 4 - Use of DOMException, r=smaug
2016-11-03 07:56:28 +01:00
Andrea Marchesini
d7a6ec8806
Bug 1284987 - Entries API - part 3 - FileSystemEntry.getParent recursion, r=smaug
2016-11-03 07:55:51 +01:00
Andrea Marchesini
3a9551a834
Bug 1284987 - Entries API - part 2 - FileSystemEntry.getParent, r=smaug
2016-11-03 07:55:30 +01:00
Nicholas Nethercote
34dcc7b852
Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
...
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.
In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.
> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.
> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");
This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
be true" sense used in assertions.
A common variation on the side-effect-free case is the following.
> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");
--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Andrea Marchesini
5bf9de08f0
Bug 1295570 - Entries API - part 7 - Split WebIDL files, r=smaug
2016-08-18 09:19:41 +02:00
Andrea Marchesini
87b1535dbc
Bug 1295570 - Entries API - part 6 - Rename Entries Callbacks, r=smaug
2016-08-18 09:19:15 +02:00
Andrea Marchesini
de09eb6947
Bug 1295570 - Entries API - part 4 - Rename DirectoryEntry to FileSystemDirectoryEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/DirectoryEntry.cpp => dom/filesystem/compat/FileSystemDirectoryEntry.cpp
rename : dom/filesystem/compat/DirectoryEntry.h => dom/filesystem/compat/FileSystemDirectoryEntry.h
rename : dom/filesystem/compat/RootDirectoryEntry.cpp => dom/filesystem/compat/FileSystemRootDirectoryEntry.cpp
rename : dom/filesystem/compat/RootDirectoryEntry.h => dom/filesystem/compat/FileSystemRootDirectoryEntry.h
2016-08-18 09:18:05 +02:00
Andrea Marchesini
e06457dcf2
Bug 1295570 - Entries API - part 3 - Rename FileEntry to FileSystemFileEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/FileEntry.cpp => dom/filesystem/compat/FileSystemFileEntry.cpp
rename : dom/filesystem/compat/FileEntry.h => dom/filesystem/compat/FileSystemFileEntry.h
2016-08-18 09:17:48 +02:00
Andrea Marchesini
94d10aeb4c
Bug 1295570 - Entries API - part 2 - Rename Entry to FileSystemEntry, r=smaug
...
--HG--
rename : dom/filesystem/compat/Entry.cpp => dom/filesystem/compat/FileSystemEntry.cpp
rename : dom/filesystem/compat/Entry.h => dom/filesystem/compat/FileSystemEntry.h
2016-08-18 09:17:25 +02:00
Andrea Marchesini
f0c18d080e
Bug 1295570 - Entries API - part 1 - Rename DOMFileSystem to FileSystem, r=smaug
...
--HG--
rename : dom/filesystem/compat/DOMFileSystem.cpp => dom/filesystem/compat/FileSystem.cpp
rename : dom/filesystem/compat/DOMFileSystem.h => dom/filesystem/compat/FileSystem.h
rename : dom/webidl/DOMFileSystem.webidl => dom/webidl/FileSystem.webidl
2016-08-18 09:17:02 +02:00
Andrea Marchesini
64fb238b77
Bug 1265767 - Subset of Blink FileSystem API - patch 6 - getFile and getDirectory, r=smaug
2016-06-07 00:55:17 +02:00