Граф коммитов

484 Коммитов

Автор SHA1 Сообщение Дата
Morgan Reschenberg e45400e5b3 Bug 1644810: Implement accessible subclasses for AXOutline and AXOutlineItem r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D96074
2020-11-12 06:16:58 +00:00
Csoregi Natalia 6ddec72329 Backed out 4 changesets (bug 1198336) for causing leaks. CLOSED TREE
Backed out changeset faa35ea77d35 (bug 1198336)
Backed out changeset 821f94bae182 (bug 1198336)
Backed out changeset ee78c1e8cc3b (bug 1198336)
Backed out changeset 2c56e36b869d (bug 1198336)
2020-11-12 01:46:52 +02:00
Eitan Isaacson 29037361ba Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-11 21:12:46 +00:00
Eitan Isaacson 5950c43ca4 Bug 1198336 - P3: Implement AXLiveRegionSearchKey. r=morgan
I think VoiceOver uses this to pull in all live regions so it
can check for deletions when they change later on.

Differential Revision: https://phabricator.services.mozilla.com/D96293
2020-11-11 21:12:33 +00:00
Eitan Isaacson 61086eeb1a Bug 1198336 - P2: Implement live region AX attributes and AXLiveRegionCreated notification. r=morgan
We use an ivar boolean flag to cache the existance of a live region. This lets us
hide the live region AX attributes and avoid sync round trips to content.

Differential Revision: https://phabricator.services.mozilla.com/D96292
2020-11-11 21:12:26 +00:00
Eitan Isaacson 4757842fcf Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-11 21:12:18 +00:00
Butkovits Atila 7c83560854 Backed out 4 changesets (bug 1198336) for bustages on rules.mk. CLOSED TREE
Backed out changeset 8399406e5f2e (bug 1198336)
Backed out changeset 7a2dbe67b6a6 (bug 1198336)
Backed out changeset fd45661dd659 (bug 1198336)
Backed out changeset 68cf7e4b16f2 (bug 1198336)
2020-11-11 02:40:30 +02:00
Marco Zehe 29d1f9d2c4 Bug 1676344 Part 2: Add a Mac test for correct table properties for a table with intermediary hyperTexts, r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D96575
2020-11-10 23:16:46 +00:00
Eitan Isaacson b7272befe7 Bug 1674215 - Map role=tooltip to AXGroup instead of AXHelpTag. r=morgan
Safari maps role=tooltip to AXGroup/AXUserInterfaceTooltip.
I suspect AXHelpTag is meant for native tooltips.

This fixes an issue when VO encounters a tooltip in read-all it jumps out of the web content.

Differential Revision: https://phabricator.services.mozilla.com/D96626
2020-11-10 23:15:02 +00:00
Eitan Isaacson eb929d7c1e Bug 1676509 - Remove AXTitle from list item groups. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D96632
2020-11-10 23:14:59 +00:00
Eitan Isaacson 75c203c933 Bug 1198336 - P4: Post AXLiveRegionChanged when live regions change. r=morgan
VoiceOver seems to do all the heavy lifting of figuring out what portion of the
live region should be read.

Differential Revision: https://phabricator.services.mozilla.com/D96294
2020-11-10 23:07:45 +00:00
Eitan Isaacson f40a9c9d15 Bug 1198336 - P3: Implement AXLiveRegionSearchKey. r=morgan
I think VoiceOver uses this to pull in all live regions so it
can check for deletions when they change later on.

Differential Revision: https://phabricator.services.mozilla.com/D96293
2020-11-10 23:07:38 +00:00
Eitan Isaacson 5a81554d4c Bug 1198336 - P2: Implement live region AX attributes and AXLiveRegionCreated notification. r=morgan
We use an ivar boolean flag to cache the existance of a live region. This lets us
hide the live region AX attributes and avoid sync round trips to content.

Differential Revision: https://phabricator.services.mozilla.com/D96292
2020-11-10 23:07:30 +00:00
Eitan Isaacson 85740d386d Bug 1198336 - P1: Introduce live region added/removed events. r=Jamie,morgan
VoiceOver pre-caches live region data and does its own deltas to
know what to parts of a subtree changed, and what to announce
based on AXARIAAtomic and AXARIARelevant.

I added a removed event as well. This will help us cache a "live region"
flag in the main process and avoid sync round trips for attributes when not needed.

Differential Revision: https://phabricator.services.mozilla.com/D96291
2020-11-10 23:07:20 +00:00
Eitan Isaacson cbc4bcfaba Bug 1675292 - Add 'application' root group when body gets role of application. r=morgan
Both chrome and safari preserve the AXWebArea with no subroles, and apply the application subrole to the root group. Not doing so apparently breaks web applications badly.

Differential Revision: https://phabricator.services.mozilla.com/D96475
2020-11-10 17:49:01 +00:00
smolnar 17d3157e82 Backed out 1 changesets (bug 1675292) for causing failures in browser_roles_elements. CLOSED TREE DONTBUILD
Backed out changeset f4cdad3fae02 (bug 1675292)
2020-11-10 09:12:15 +02:00
Eitan Isaacson 6ac3c7496b Bug 1675292 - Add 'application' root group when body gets role of application. r=morgan
Both chrome and safari preserve the AXWebArea with no subroles, and apply the application subrole to the root group. Not doing so apparently breaks web applications badly.

Differential Revision: https://phabricator.services.mozilla.com/D96475
2020-11-09 23:53:00 +00:00
Eitan Isaacson e8112d4ccd Bug 1672694 - P2: Don't fire AXSelectedTextChanged if target is not selectable. r=morgan
This causes VoiceOver to mess with `AXFocused` and as a result redirect the VO cursor.

Differential Revision: https://phabricator.services.mozilla.com/D95784
2020-11-09 17:55:20 +00:00
Marco Zehe 82a0456a29 Bug 1673857 - Expose SVGs as images rather than unknown accessibles, r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D96069
2020-11-06 17:31:09 +00:00
Andrey Bienkowski 9985e57c16 Bug 1675094 Replace executeSoon() with waitForTick() in accessible/tests/browser r=Jamie,yzen
Differential Revision: https://phabricator.services.mozilla.com/D95779
2020-11-05 18:27:40 +00:00
Razvan Maries fd7d890c94 Backed out 2 changesets (bug 1672694) for Lint failures on browser_text_selection.js and perma failures on browser_accessibility_node.js. CLOSED TREE
Backed out changeset 0f340ea56805 (bug 1672694)
Backed out changeset b222e4ff438f (bug 1672694)
2020-11-04 03:15:17 +02:00
Eitan Isaacson f80fe575c5 Bug 1672694 - P2: Don't fire AXSelectedTextChanged if target is not selectable. r=morgan
This causes VoiceOver to mess with `AXFocused` and as a result redirect the VO cursor.

Differential Revision: https://phabricator.services.mozilla.com/D95784
2020-11-04 00:26:27 +00:00
Eitan Isaacson 33d5e972fd Bug 1674196 - Don't return children columns in layout tables. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D95228
2020-10-30 04:42:18 +00:00
James Teh 72da707476 Bug 1673919: Make ParagraphBoundaryRule skip over OuterDocAccessibles. r=MarcoZ
The browser test is really a crash test, but it's really difficult to test a11y APIs properly using the crashtest framework.

Differential Revision: https://phabricator.services.mozilla.com/D95107
2020-10-29 06:04:33 +00:00
Eitan Isaacson 0e6061d30d Bug 1672243 - Introduce AXIndexForChildUIElement and implement AXTopLevelUIElement. r=MarcoZ
AXTopLevelUIElement is not really testable because it doesn't give a useful result in
headless mode. Since it is a clone of AXWindow, this shouldn't be much of an issue.

Differential Revision: https://phabricator.services.mozilla.com/D94154
2020-10-22 17:12:39 +00:00
Morgan Reschenberg c5ff480218 Bug 1668101: Support same/different type naviagation with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D91833
2020-10-15 16:42:14 +00:00
Eitan Isaacson 2e476d423a Bug 1671049 - Invalidate cached ARIA role and role in mozAccessible when role changes. r=morgan
Besides the ARIA role invalidation, this fixes an issue where the mozAccessible's role is also incorrect when the aria role changes on a body tag.

Depends on D93439

Differential Revision: https://phabricator.services.mozilla.com/D93440
2020-10-14 00:04:49 +00:00
Eitan Isaacson 7a572196df Bug 1669821 - Implement search predicate API on virtual root. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92820
2020-10-07 20:34:21 +00:00
Eitan Isaacson f050b91638 Bug 1669599 - Support AXEditableAncestor and make it text event target. r=morgan
Depends on D92689

Differential Revision: https://phabricator.services.mozilla.com/D92690
2020-10-07 00:13:34 +00:00
Eitan Isaacson c173a1f486 Bug 1669596 - Allow subdoc GeckoTextMarker to be demarshalled in top document. r=morgan
Depends on D92688

Differential Revision: https://phabricator.services.mozilla.com/D92689
2020-10-06 23:31:32 +00:00
Eitan Isaacson 16d2fdfadc Bug 1669595 - Use top AXWebArea as text event source. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92688
2020-10-07 18:38:52 +00:00
Eitan Isaacson 029b948f0c Bug 1668958 - Don't wrap to first word when getting right word at end of input. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92310
2020-10-06 22:19:13 +00:00
Eitan Isaacson 10dfa8214c Bug 1668936 - Return element when calling AXUIElementForTextMarker in entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92309
2020-10-06 22:19:11 +00:00
Eitan Isaacson 7293c05ee8 Bug 1668933 - Fix get previous marker outside of entry. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92308
2020-10-06 22:19:03 +00:00
Morgan Reschenberg bff9a869c8 Bug 1666380: Add support for AXTextFieldSearchKey to VO rotor r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90941
2020-10-06 18:50:31 +00:00
Eitan Isaacson 68fd6a3f35 Bug 1669359 - Fix GeckoTextMarker lesser-than operator. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D92511
2020-10-06 17:24:19 +00:00
Narcis Beleuzu 818e3aeb0d Bug 1668653 - Fix lint failure in browser_navigate.js. a=lint-fix 2020-10-06 01:13:21 +03:00
Morgan Reschenberg 75caa1c350 Bug 1668655: Add support for AXGraphicSearchKey r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92144
2020-10-05 19:52:15 +00:00
Morgan Reschenberg 3445c53c34 Bug 1668653: Add support for navigating by heading level with VO r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92136
2020-10-05 19:52:15 +00:00
Morgan Reschenberg 8ea7a5cbaf Bug 1668663: Add support for navigation by blockquote r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D92145
2020-10-05 19:52:09 +00:00
Eitan Isaacson 96fe811eb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-02 16:33:42 +00:00
Eitan Isaacson e3bbc94ed8 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-02 16:33:34 +00:00
James Teh 590d7137ee Bug 1668707: When deciding whether to create a div Accessible, skip the first/last child if it's invisible and consider inline-block, etc. r=MarcoZ
1. Text nodes can be created in the DOM just because there was white space in the source, but this isn't always visible.
    We shouldn't create an Accessible in the invisible case.
    However, there could be an inline frame after/before an invisible text node, so we still need to check for that.

2. We should create div Accessibles if there are inline-block children such as buttons.
    Previously, we weren't doing this because these aren't caught by IsInlineFrame.
    We now use IsInlineOutside, which also catches text and br.
    Aside from being a bug, this fix was needed in this patch to fix tests which previously created div Accessibles because of invisible text nodes, but lost the Accessibles once this was fixed.

3. Similarly, we should create div Accessibles if there is a previous text sibling.
    Again, IsInlineFrame wasn't catching these, but IsInlineOutside does.

4. Adjust various tests to fix assumptions based on the previous behaviour.
    Some needed role="none" to force flattening, while some needed an id to force creation.

Differential Revision: https://phabricator.services.mozilla.com/D92170
2020-10-02 07:15:15 +00:00
Butkovits Atila 6a98c9beb2 Backed out 2 changesets (bug 1668142, bug 1668137) for build bustage on MOXSearchInfo.mm. CLOSED TREE
Backed out changeset 05c9cc6dd872 (bug 1668142)
Backed out changeset 4c62dd862ae3 (bug 1668137)
2020-10-02 03:53:25 +03:00
Eitan Isaacson 34f9d53bb7 Bug 1668142 - Support AXDirectionPrevious in rotor with no start element. r=morgan
Depends on D91875

Differential Revision: https://phabricator.services.mozilla.com/D91878
2020-10-01 18:55:57 +00:00
Eitan Isaacson f4182287b4 Bug 1668137 - Use search root for rule's aDirectDescendantsFrom argument. r=morgan
Differential Revision: https://phabricator.services.mozilla.com/D91875
2020-10-01 18:56:52 +00:00
Olli Pettay 8a508eaa66 Bug 1668357 - Disable tests which fail when fission and session-history-in-parent are enabled, r=peterv,marionette-reviewers,whimboo
In many cases with wpt, most of the tests in the file pass, but it is rather time consuming to annotate
.ini files case by case.

Differential Revision: https://phabricator.services.mozilla.com/D91977
2020-10-01 10:23:47 +00:00
Morgan Reschenberg 671ed0bc10 Bug 1665960: Add AXStaticTextSearchKey support r=eeejay
Differential Revision: https://phabricator.services.mozilla.com/D90746
2020-09-29 23:39:49 +00:00
Morgan Reschenberg eef7c76d3c Bug 1665962: Introduce roles::LISTITEM_MARKER to rolemap, add mac mapping to AXListMarker r=eeejay,Jamie
Differential Revision: https://phabricator.services.mozilla.com/D90745
2020-09-29 22:31:58 +00:00
Eitan Isaacson 474e7874b9 Bug 1667262 - Add AXStyleTextMarkerRangeForTextMarker. r=morgan
Depends on D91357

Differential Revision: https://phabricator.services.mozilla.com/D91850
2020-09-29 23:25:35 +00:00