Chris Peterson
71422dcaa9
Bug 1457813 - Part 2: Replace non-asserting NS_PRECONDITIONs with MOZ_ASSERTs. r=froydnj
...
s/NS_PRECONDITION/MOZ_ASSERT/ and reindent
MozReview-Commit-ID: KuUsnVe2h8L
--HG--
extra : source : c14655ab3df2c9b1465dd8102b9d25683359a37b
2018-04-28 12:50:58 -07:00
Emilio Cobos Álvarez
1f9cbf532c
Bug 1454251: Remove nsINode::eATTRIBUTE. r=bz
...
MozReview-Commit-ID: 7HeUbcG6szy
2018-04-20 09:52:26 +02:00
Emilio Cobos Álvarez
d8e55e4596
Bug 1454236: Remove nsINode::eDOCUMENT_FRAGMENT. r=bz
...
MozReview-Commit-ID: D2F3LbQ1pvw
2018-04-20 01:30:12 +02:00
Emilio Cobos Álvarez
83fd987aec
Bug 1454233: Remove nsINode::eDOCUMENT. r=bz
...
MozReview-Commit-ID: ItjdI79zme7
2018-04-20 01:30:11 +02:00
Boris Zbarsky
a517e45add
Bug 1452183 part 4. Remove nsIDOMDocumentFragment. r=mccr8
2018-04-17 21:13:03 -04:00
Andrew McCreight
3f7472aec1
Bug 1449670, part 1 - Convert IsNodeOfType(nsINode::eTEXT) to IsText(). r=bz
...
This method is not a virtual call, and also looks nicer.
This patch was mostly generated by a Python script, but I manually
cleaned up the code in a few places where statements didn't need to be
split across multiple lines any more.
MozReview-Commit-ID: 8JExxqSRc59
--HG--
extra : rebase_source : df6330a89e8d65dfe7a6fda0c8cb9f9732302efc
2018-04-12 15:41:00 -07:00
Brad Werth
19d279bd7d
Bug 1450208: Change nsRange::ExtractRectFromOffset to use simpler, hopefully safer logic to determine whether text is vertical. r=bz
...
Instead of checking nsIFrame::IsTextFrame() and then casting to nsTextFrame,
the new code just checks the writing mode of the frame. Less casts; less
chance of pointer errors.
MozReview-Commit-ID: LrtthZjwYq6
--HG--
extra : rebase_source : 487ed4de272f514fe1f495ed1c2ddb9c8574d0a2
2018-03-30 08:52:53 -07:00
Brad Werth
7c79deb615
Bug 1437509 Part 1: Expand nsRange::ExtractRectFromOffset to correctly generate rects from vertical text runs. r=bz
...
MozReview-Commit-ID: 2n9SCn0eu9B
--HG--
extra : rebase_source : c68c0b8c55e6a177627b48ee1f2e1b6f2ce67aa4
2018-03-08 14:07:54 -08:00
Boris Zbarsky
74e28b0d19
Bug 1447890 part 2. Remove nsISelection::RemoveRange. r=mystor
...
MozReview-Commit-ID: JXq5FYNNXPJ
2018-03-27 00:35:22 -04:00
Boris Zbarsky
f803b0085b
Bug 1447889 part 13. Remove unused nsIDOMRange bits. r=mystor
...
MozReview-Commit-ID: CjtfHTtcviJ
2018-03-27 00:35:22 -04:00
Boris Zbarsky
2367e5d3ff
Bug 1447889 part 12. Remove nsIDOMRange::ToString. r=mystor
...
MozReview-Commit-ID: 8TDYC3f4ENn
2018-03-27 00:35:22 -04:00
Boris Zbarsky
cffc291dfc
Bug 1447889 part 11. Remove nsIDOMRange::CloneRange. r=mystor
...
The GetSelection changes are so we have a Selection that we can get an nsRange
from via GetRangeAt, so we can call nsRange::CloneRange.
MozReview-Commit-ID: 6rqdJ29Yyuc
2018-03-27 00:35:21 -04:00
Boris Zbarsky
86c4629290
Bug 1447889 part 10. Remove nsIDOMRange::DeleteContents. r=mystor
...
MozReview-Commit-ID: IoXz0pS6zAa
2018-03-27 00:35:21 -04:00
Boris Zbarsky
1731f12f9d
Bug 1447889 part 9. Remove nsIDOMRange::CompareBoundaryPoints. r=mystor
...
MozReview-Commit-ID: 29swD9AoqoF
2018-03-27 00:35:21 -04:00
Boris Zbarsky
3906df8d57
Bug 1447889 part 8. Remove nsIDOMRange::SelectNode/SelectNodeContents. r=mystor
...
MozReview-Commit-ID: 2hbF6pT31Xd
2018-03-27 00:35:21 -04:00
Boris Zbarsky
6a7475413e
Bug 1447889 part 7. Remove nsIDOMRange::Collapse. r=mystor
...
MozReview-Commit-ID: LLiXK8IpUdY
2018-03-27 00:35:21 -04:00
Boris Zbarsky
b94366962a
Bug 1447889 part 6. Remove nsIDOMRange::SetStart/End. r=mystor
...
MozReview-Commit-ID: 8yOZMWBexsN
2018-03-27 00:35:21 -04:00
Boris Zbarsky
d03d46b01e
Bug 1447889 part 5. Remove nsIDOMRange::GetCommonAncestorContainer. r=mystor
...
MozReview-Commit-ID: 18bnPYjRld5
2018-03-27 00:35:21 -04:00
Boris Zbarsky
696d273ef4
Bug 1447889 part 4. Remove nsIDOMRange::GetStart/EndContainer/Offset. r=mystor
...
I got a bit carried away with fixing up consumers to use nsINode... But as a
result removing these methods all together made sense.
MozReview-Commit-ID: 2z9Q6D7GY92
2018-03-27 00:35:21 -04:00
Emilio Cobos Álvarez
e341b20ec4
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez
5dd797f154
Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
...
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.
MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez
ca5ac79cca
Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
...
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Boris Zbarsky
29d232e53f
Bug 1447098 part 1. Rename FromContent on various DOM classes to FromNode. r=mystor
...
MozReview-Commit-ID: 202nkbmkwfR
2018-03-21 17:39:04 -04:00
Boris Zbarsky
8dfe726ebb
Bug 1446533
part 11. Remove remaining nsIDOMCharacterData uses in range code. r=mystor
...
MozReview-Commit-ID: 8YLea3SmQQU
2018-03-19 15:45:58 -04:00
Boris Zbarsky
e7e7401bc3
Bug 1446533
part 8. Remove nsIDOMCharacterData::DeleteData. r=mystor
...
MozReview-Commit-ID: 7100YyU5jOG
2018-03-19 15:45:31 -04:00
Boris Zbarsky
c441152ca4
Bug 1446533
part 6.5. Fix some old whitespace bits in range code. r=mystor
...
MozReview-Commit-ID: KTEgqc4Wzjd
2018-03-19 15:35:38 -04:00
Boris Zbarsky
4d10a59d53
Bug 1446533
part 6. Remove nsIDOMCharacterData::GetLength r=mystor
...
MozReview-Commit-ID: FCBGyqPfC4B
2018-03-19 15:33:28 -04:00
Boris Zbarsky
0678b901b6
Bug 1446533
part 4. Remove nsIDOMCharacterData::SubstringData. r=mystor
...
FromContent will be renamed to FromNode in bug 1447098.
MozReview-Commit-ID: DhiN6mCOb34
2018-03-19 15:18:07 -04:00
Boris Zbarsky
971ee6f9cb
Bug 1446533
part 2. Rename nsGenericDOMDataNode.{h,cpp} to CharacterData. r=mystor
...
The DOMMatrix.cpp changes are because it was sneaking in headers via another
unified file.
MozReview-Commit-ID: GPp9WOywI5D
--HG--
rename : dom/base/nsGenericDOMDataNode.cpp => dom/base/CharacterData.cpp
rename : dom/base/nsGenericDOMDataNode.h => dom/base/CharacterData.h
2018-03-19 15:18:07 -04:00
Boris Zbarsky
b06aa7e061
Bug 1446533
part 1. Rename nsGenericDOMDataNode to CharacterData. r=mystor
...
This is not renaming the files yet; that will be a separate changeset.
MozReview-Commit-ID: 5TxkEiQlaKF
2018-03-19 15:18:06 -04:00
Boris Zbarsky
277b5fdef5
Bug 1433566 part 11. Stop using nsIDOMText in range code. r=mystor
...
MozReview-Commit-ID: 2EY6w5YlLCH
2018-03-19 15:15:39 -04:00
Boris Zbarsky
d6f4a41e44
Bug 1433566 part 3. Remove nsIDOMText::SplitText. r=mystor
...
MozReview-Commit-ID: 1jghu75LKDw
2018-03-19 15:15:38 -04:00
Adrian Wielgosik
bb82957302
Bug 1445408 - Remove nsIDOMClientRectList. r=bz
...
MozReview-Commit-ID: 22sQNVs0wFP
--HG--
extra : rebase_source : f96617033678e372a32971517300182dd4c3ac57
2018-03-01 17:14:26 +01:00
Emilio Cobos Álvarez
2988d4e66d
Bug 1442207: Remove unneeded arguments to nsIMutationObserver. r=smaug
...
aDocument is always content->OwnerDoc().
aContainer is always content->GetParent().
Differential Revision: https://phabricator.services.mozilla.com/D664
MozReview-Commit-ID: 4xwPCOnhyIL
2018-03-01 22:45:17 +01:00
Emilio Cobos Álvarez
9f26540cc4
Bug 1441547: Make character data change notifications use a const reference for the info parameter. r=smaug
...
It's not intended to be mutated.
MozReview-Commit-ID: 5nkD1YkidlV
--HG--
extra : rebase_source : 810d429208fa3eaf30e220e77a7d27107cb77346
2018-02-27 15:30:27 +01:00
Emilio Cobos Álvarez
7dffe29d8f
Bug 1432490: Make nsComputedDOMStyle::GetStyleContext / GetStyleContextNoFlush not take a presShell. r=bz
...
Everyone calls them with the shell of the current composed document, and this
allows the multi-presShell stuff to just be in UpdateCurrentStyleSources /
DoGetStyleContextNoFlush.
The only reason we need to use OwnerDoc()->GetShell() instead of the composed
doc in GetStyleContext / GetStyleContextNoFlush is Element::GetBindingURL, which
does expect to get the binding URL for stuff outside of the composed doc (and
changing that gave me a useless browser).
That's technically a behavior change on the cases that used to pass nullptr, but
I think all callers are fine with that. I could also just add a special function
for that particular case, it may be worth it.
MozReview-Commit-ID: 2XlnkgdgDCK
2018-02-25 02:23:59 +01:00
Dorel Luca
f41b03eca9
Backed out changeset 38577c007450 (bug 1424371) for Marionett test failure on testing/marionette/harness/marionette_harness/tests/unit/test_window_maximize.py. CLOSED TREE
2018-02-19 22:15:23 +02:00
Milan Sreckovic
7571df7e7c
Bug 1424371: Use BaseRect access methods instead of member variables in dom/ r=qdot
...
MozReview-Commit-ID: HXWhggOMIEK
--HG--
extra : rebase_source : 9c9eacf80d2b7f78faa82a1549170b98d12cdaa8
2018-02-19 12:56:10 -05:00
Jonathan Kew
7a1f777b90
Bug 1435989 - Add a 'ranges' attribute to the InspectorFontFace object, to expose ranges of text that were rendered with a specific font. r=bz,dholbert
2018-02-15 18:48:22 +00:00
Boris Zbarsky
f60fd673d6
Bug 1432186 part 19. Remove the nsIDOMNode::*_NODE constants. r=mccr8
...
MozReview-Commit-ID: KvKjeKIOB9K
2018-01-29 23:10:53 -05:00
Boris Zbarsky
87cd3b385a
Bug 1432186 part 14. Remove nsIDOMNode's childNodes attribute. r=mccr8
...
MozReview-Commit-ID: JyQjEYngKAT
2018-01-29 23:10:51 -05:00
Boris Zbarsky
3b6d43f65c
Bug 1432186 part 4. Remove nsIDOMNode's nodeValue attribute. r=mccr8
...
MozReview-Commit-ID: Aqt4NDjcdKW
2018-01-29 23:10:50 -05:00
Andrea Marchesini
b8bb98af8c
Bug 1430997 - Rename nsINode::IndexOf to nsINode::ComputeIndexOf, r=catalinb
2018-01-23 14:30:18 +01:00
Andrea Marchesini
43c8e4e21b
Bug 1425440 - Get rid of GetChildAt_Deprecated in nsRange, r=catalinb
2018-01-12 15:33:13 +01:00
Cameron McCormack
c4663ea0f0
Bug 1427419 - Part 22: Move inIDOMUtils.getUsedFontFaces to InspectorUtils. r=bz
...
This also changes the function to return a sequence (JS Array) instead of
an nsFontFaceList object, and converts nsFontFace/nsIDOMFontFace into a
Web IDL implemented object too.
MozReview-Commit-ID: 1iAW3DYe5kO
--HG--
rename : layout/inspector/nsFontFace.cpp => layout/inspector/InspectorFontFace.cpp
2018-01-11 12:38:01 +08:00
Andrea Marchesini
00e79ef07b
Bug 1425321 - Renaming nsINode::GetChildAt to GetChildAt_Deprecated, r=catalinb
...
We want to deprecate nsINode::GetChildAt as the first step of removing DOM node
child array storage. See bug 651120.
2018-01-03 13:59:54 +01:00
Adam Gashlin
a0a93d0d91
Bug 1424839 - Continue checking selections after a collapsed one r=mats
...
MozReview-Commit-ID: 4YXtx2bEprU
--HG--
extra : rebase_source : 3c94d78c9865d31f9c87e713b58922164ac6d805
2017-12-14 14:29:59 -06:00
Edgar Chen
5fedbb92b8
Bug 1422197 - Add fast path to get DocGroup in binding code for [CEReactions]; r=smaug
...
MozReview-Commit-ID: HgbFo9ddr0o
--HG--
extra : rebase_source : 04989782fc7c7ce79e0e65b3dc907c9e174a0809
2017-11-27 16:10:27 +08:00
Masayuki Nakano
bab72d08e8
Bug 1423097 - part 2: Add overloads of nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and nsRange::ComparePoint() to use them with RawRangeBoundary r=smaug
...
nsRange::SetStart(), nsRange::SetEnd(), nsRange::IsPointInRange() and
nsRange::ComparePoint() take a set of container node and offset in it to
specifying a DOM point. However, the caller may not have computed the offset
but may know the child node at the point. In such case, they can avoid
computing the offset with nsINode::IndexOf() if they have overloads which
take RawRangeBoundary.
Therefore, this patch implements the overloads and changes the callers in
editor.
MozReview-Commit-ID: E4DLbAgTTCI
--HG--
extra : rebase_source : 8d1632a030f1e0a0dd2b81c3996c19d427e8b0bd
2017-12-05 17:50:13 +09:00
Adam Gashlin
95018ae790
Bug 1374338 - Search all ranges to avoid filtering r=mats
...
MozReview-Commit-ID: uu35565lfP
--HG--
extra : rebase_source : e7f885b58f172998533c73fd8dff3d27d58c6dd6
2017-12-01 14:53:20 -08:00