812f96aeba
Bug 1697818 - Drop handrolled NEON SIMD wrappers. r=aosmond
...
We require Rust 1.50 now which is new enough to not need these
wrappers anymore.
Differential Revision: https://phabricator.services.mozilla.com/D108337
2021-03-14 19:44:57 +00:00
51f07145b3
Bug 1697858 - Use an additional src profile when fuzzing. r=aosmond
...
Only using sRGB will limit the gamut of XYZ that we explore
which seems to prevent us from finding bug 1697787. Also using the
identity XYZD50 profile should hopefully fix that.
Differential Revision: https://phabricator.services.mozilla.com/D108060
2021-03-11 18:45:05 +00:00
7016de7023
Bug 1697595 - Profile doesn't need to be #[repr(C)]. r=aosmond
...
The members are not used in any C api.
Differential Revision: https://phabricator.services.mozilla.com/D107928
2021-03-11 00:21:45 +00:00
5010c8bfcc
Bug 1695549 - Cleanup modular_transform_create_output a little. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D106741
2021-03-02 00:31:56 +00:00
278f93eac9
Bug 1695549 - Cleanup matrix usage in qcms_transform_data_template_lut. r=aosmond
...
This avoids unsafe pointer math and is much easier to read.
Differential Revision: https://phabricator.services.mozilla.com/D106740
2021-03-02 00:31:55 +00:00
62f4683595
Bug 1695549 - Run cargo fmt on qcms. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D106739
2021-03-02 00:31:54 +00:00
6a023272d5
Bug 1695324 - Cleanup read_tag_lutType. r=aosmond
...
This makes some overflow avoidance more obvious and prepares
for supporting more than 3 input channels.
Differential Revision: https://phabricator.services.mozilla.com/D106665
2021-02-27 19:27:15 +00:00
6217a9ef1a
Bug 1695110 - Make module_transform_alloc infallible. r=aosmond
...
This lets us cleanup a bunch of uses of the transform
because it's not an Option anymore.
Differential Revision: https://phabricator.services.mozilla.com/D106571
2021-02-26 12:37:05 +00:00
e06735bf71
Bug 1695110 - cargo fmt src/chain.rs r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D106570
2021-02-26 12:37:05 +00:00
4428c5ac72
Bug 1694958 - Drop extern "C" from the transform functions. r=aosmond
...
This removes the parts of the gtest that were using these
functions. That specific testing is already happeing in src/gtest.rs
Differential Revision: https://phabricator.services.mozilla.com/D106471
2021-02-26 02:18:32 +00:00
27d0c297fd
Bug 1694956 - qcms: Make read_u32/u16/u8 safe. r=aosmond
...
This removes the last bit of unsafety from iccread.rs.
It also removes the now unused 'be' types and conversion
functions.
Differential Revision: https://phabricator.services.mozilla.com/D106469
2021-02-25 16:49:06 +00:00
22ceddbe92
Bug 1694955 - qcms: make write_u32/u16 safe. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D106466
2021-02-25 15:30:08 +00:00
13e6a365b0
Bug 1694680 - Fix qcms_data_create_rgb_with_gamma.
...
This fixes a number of problems:
1. The check around get_rgb_colorants was inverted. This caused us to
only continue if the colorants were wrong.
2. get_rgb_colorants can just return the Matrix instead of taking
a reference to it.
3. No tests
Differential Revision: https://phabricator.services.mozilla.com/D106463
2021-02-25 13:57:05 +00:00
4ac01c88b7
Bug 1694670. Fix the OOB check in write_u32/u16. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D106362
2021-02-25 13:18:47 +00:00
8e60a5afe5
Bug 1693404 - Add Profile::new_XYZD50(). r=aosmond
...
This will be useful implementing Profile::approx_eq()
Differential Revision: https://phabricator.services.mozilla.com/D105518
2021-02-17 23:19:11 +00:00
519f913527
Bug 1685311 - Flesh out the documentation a little. r=aosmond
...
Also update fuzz/Cargo.lock
Differential Revision: https://phabricator.services.mozilla.com/D100923
2021-01-06 17:11:21 +00:00
a3db045160
Bug 1685214 - Add some documentation to qcms and bump the crate version. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100845
2021-01-06 01:36:30 +00:00
63c64ed972
Bug 1685101 - Fix bytes_per_pixel for GrayA8. r=aosmond
...
This was found by oss-fuzz https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=29235
Differential Revision: https://phabricator.services.mozilla.com/D100785
2021-01-05 15:56:51 +00:00
8dbf596048
Bug 1684797 - Don't enable qcms c_bindings feature by default. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100642
2021-01-04 01:54:14 +00:00
8eec586c99
Bug 1684760 - Drop unneeded 'pub'. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100636
2021-01-03 15:14:51 +00:00
ddce3eff5d
Bug 1684760 - Rename qcms_modular_transform to ModularTransform. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100635
2021-01-03 15:14:49 +00:00
1f3be0afea
Bug 1684760 - Rename qcms_data_type to DataType. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100634
2021-01-03 15:13:21 +00:00
ea48efb477
Bug 1684760 - Rename Intent enum variants. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100633
2021-01-03 15:10:55 +00:00
c1acf8890b
Bug 1684760 - Run cargo fmt. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100632
2021-01-03 15:10:07 +00:00
09895f6d43
Bug 1684760 - Rename precache_output to PrecacheOutput. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100631
2021-01-03 15:09:43 +00:00
d22a451eab
Bug 1684760 - Improve panic message. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100630
2021-01-03 15:09:21 +00:00
a2b8048d70
Bug 1684723 - Make transform functions take a & instead of *const. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100622
2021-01-03 14:12:34 +00:00
931d355c00
Bug 1684706 - Remove unused sig data. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100607
2021-01-03 00:30:14 +00:00
6ea1e0dc6e
Bug 1684706 - Move some comments back to the appropriate places. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100606
2021-01-03 00:29:46 +00:00
0b94364bf6
Bug 1684696. Avoid unnecessasry casts by doing math in f32. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100604
2021-01-02 18:59:59 +00:00
7a8e85b1c2
Bug 1684696. Convert more loops to for loops. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100603
2021-01-02 18:59:42 +00:00
2c180afd0a
Bug 1684696. Drop some unneeded f64 suffixes. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100602
2021-01-02 18:58:48 +00:00
e34a0e3eb1
Bug 1684696. Drop some variable declarations to their definitions. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100601
2021-01-02 18:58:40 +00:00
b9e9b0c225
Bug 1684696. Convert some loops back to for loops. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100600
2021-01-02 18:58:38 +00:00
e18792f41e
Bug 1684696. Rewrite read_nested_curveType in a more Rust like style. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100599
2021-01-02 18:58:35 +00:00
4932fc1402
Bug 1684691 - Make Matrix more Rust like. r=aosmond
...
This makes a bunch of free functions methods
of Matrix.
Differential Revision: https://phabricator.services.mozilla.com/D100598
2021-01-02 15:15:55 +00:00
12fde17482
Bug 1684668 - Rename in_0 to input and out to output. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100590
2021-01-02 13:42:23 +00:00
62c417fe2e
Bug 1684652 - Drop some unneeded casts. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100580
2021-01-01 23:22:17 +00:00
ec219374ca
Bug 1684599 - Make iccv4 support default value a feature. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100571
2020-12-31 23:06:07 +00:00
5136e6e774
Bug 1684599 - Rename qcms_supports_iccv4 to SUPPORTS_ICCV4. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100570
2020-12-31 23:02:29 +00:00
04ba708f6d
Bug 1684571 - Don't allow unused mut in qcms. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100558
2020-12-31 11:18:37 +00:00
1833b8b292
Bug 1684535 - Stop allowing unused variables. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100553
2020-12-31 02:28:15 +00:00
1e96a1abb4
Bug 1684534 - Rename matrix and qcms_profile types. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100551
2020-12-30 18:44:37 +00:00
7f7cf34bf9
Bug 1684517. Make C bindings optional. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100550
2020-12-30 15:14:08 +00:00
5be5a5ffc3
Bug 1684517. Drop remaining usage of libc outside of c_bindings. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100549
2020-12-30 15:13:55 +00:00
9978341405
Bug 1684517. Move qcms_data_create_rgb_with_gamma into c_bindings. r=aosmond
...
This removes other uses of libc types from iccread.rs as well.
Differential Revision: https://phabricator.services.mozilla.com/D100548
2020-12-30 15:13:12 +00:00
3ff01f82d3
Bug 1684491 - Run cargo fmt after clippy changes. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100540
2020-12-30 15:12:28 +00:00
16a7eb6412
Bug 1684486 - Run cargo clippy on qcms. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100539
2020-12-29 23:27:47 +00:00
a63efd9519
Bug 1684483 - Drop some unneeded semicolons. r=aosmond
...
This allows cargo clippy to have more success.
Differential Revision: https://phabricator.services.mozilla.com/D100535
2020-12-29 21:54:40 +00:00
3679707b84
Bug 1684453 - Handle curveType::Curve in a more Rust like fashion. r=aosmond
...
Differential Revision: https://phabricator.services.mozilla.com/D100523
2020-12-29 16:09:33 +00:00
Jeff Muizelaar