Граф коммитов

5762 Коммитов

Автор SHA1 Сообщение Дата
Sylvestre Ledru 3465611f71 Bug 1414628 - ConfigureCodec: Remove private field 'mHardwareH264Enabled' r=dminor
MozReview-Commit-ID: 83U02hqgW6d

--HG--
extra : rebase_source : 5baf00d2a8a3ad239981bb1774743980e3dbc0a6
2017-11-05 16:56:19 +01:00
JW Wang 2e17f2f227 Bug 1414213. P2 - don't continue reading if reader.Read(5) failed. r=jya
MozReview-Commit-ID: 1vNbACa9Vpv

--HG--
extra : rebase_source : 099d2ea1a704e6b2b710b80a273ab9f9d3e3257e
2017-11-06 11:24:16 +08:00
JW Wang e75848012d Bug 1414213. P1 - H264::NumSPS() should return 0 if aExtraData is empty. r=jya
MozReview-Commit-ID: JTzEqYt9mQr

--HG--
extra : rebase_source : 660d93f8088ae3d01ba23c74ee6deef7a0cb34aa
extra : source : 9f971ae67cecbd4d040881b3ed0b1752b6a6e04d
2017-11-03 17:40:32 +08:00
Michael Froman 033ed8ae3a Bug 1415249 - remove unused variables introduced in Bug 1408218. r=drno
Two variables, contains_mac_based_ipv6 and contains_teredo_ipv6, were
added that are set but never used.  This will cause compiler warnings
issues in the future.

MozReview-Commit-ID: C5ZReH94RpM

--HG--
extra : rebase_source : 50e06da3c093a118151d840b7d25a979afce6321
2017-11-07 09:28:47 -06:00
Ralph Giles 05817d3bd3 Bug 1413734 - av1: fix build issues. r=kinetik
This revision of libaom has some conflicts with our vendor script
and build system. A number of new .asm files have the same basename
as .c files, which our build system cannot handle.

To work around this, I ran `./mach vendor aom` with the check for
duplicate filenames disabled, then manually renamed the conflicting
files in the filesystem and sources.mozbuild.

Also add av1_convolve_scale_sse4.c to sources.mozbuild manually.
This is needed by the build but for some reason isn't picked up
by generate_sources_mozbuild.sh.

MozReview-Commit-ID: 2iBo4kSBz1G

--HG--
rename : third_party/aom/aom_dsp/arm/idct16x16_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct16x16_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct16x16_add_neon.asm => third_party/aom/aom_dsp/arm/idct16x16_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct32x32_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct32x32_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct32x32_add_neon.asm => third_party/aom/aom_dsp/arm/idct32x32_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct4x4_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct4x4_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct4x4_add_neon.asm => third_party/aom/aom_dsp/arm/idct4x4_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct8x8_1_add_neon.asm => third_party/aom/aom_dsp/arm/idct8x8_1_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/idct8x8_add_neon.asm => third_party/aom/aom_dsp/arm/idct8x8_add_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_16_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_16_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_4_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_4_neon_asm.asm
rename : third_party/aom/aom_dsp/arm/loopfilter_8_neon.asm => third_party/aom/aom_dsp/arm/loopfilter_8_neon_asm.asm
rename : third_party/aom/aom_dsp/x86/highbd_intrapred_sse2.asm => third_party/aom/aom_dsp/x86/highbd_intrapred_sse2_asm.asm
rename : third_party/aom/aom_dsp/x86/intrapred_sse2.asm => third_party/aom/aom_dsp/x86/intrapred_sse2_asm.asm
rename : third_party/aom/aom_dsp/x86/intrapred_ssse3.asm => third_party/aom/aom_dsp/x86/intrapred_ssse3_asm.asm
extra : rebase_source : 7bf598ac1a925e16e42301839376a963836ae182
2017-11-01 15:49:14 -07:00
Ralph Giles 92f3d837b2 Bug 1413734 - av1: Update decoder library. r=kinetik
Update to upstream commit id e87fb2378f01103d5d6e477a4ef6892dc714e614
from a couple of weeks ago to pick up changes.

MozReview-Commit-ID: H7H69A7qFXD

--HG--
extra : rebase_source : dee676da15b65e4eea612d20529c4fb312bbddfb
2017-11-01 15:36:09 -07:00
Jean-Yves Avenard 2f8b62c59a Bug 1295886 - P16. Enable FLAC C decoder on aarch64 machines. r=mshal
MozReview-Commit-ID: 9i3AaG5CGex

--HG--
extra : rebase_source : 2e6cc87d2e1629d5b44fd67627675c4460201023
2017-11-02 10:51:22 +01:00
Jean-Yves Avenard dae7070b4a Bug 1295886 - P14. Add arm neon and vfp optimized methods to ffmpeg. r=mshal
MozReview-Commit-ID: KMUZoDWoisi

--HG--
extra : rebase_source : a08eae842680b9d475bfc0afd2d569533dba676b
2017-11-02 01:48:00 +01:00
Jean-Yves Avenard 7905dd9c5e Bug 1295886 - P13. Disable FAST_CLZ on Windows. r=gerald
It may not be supported on all CPUs.

See
https://chromium-review.googlesource.com/c/chromium/third_party/ffmpeg/+/344671

MozReview-Commit-ID: 643jBtSS1Fl

--HG--
extra : rebase_source : cdac3d41174b0c2ca99b6e78968577d8750213ea
2017-11-01 21:33:24 +01:00
Jean-Yves Avenard f65bf257be Bug 1295886 - P12. Have a generic C-only FLAC decoder. r=gerald
MozReview-Commit-ID: C6A9YNaZBvZ

--HG--
extra : rebase_source : 635b1c8286078140463e08ca44588c28b50ca993
2017-11-01 21:17:40 +01:00
Jean-Yves Avenard 88e4dfa3e3 Bug 1295886 - P11. Enable FFmpeg small mode. r=gerald
This mostly removes static strings declaration, replacing them with null pointers.

It does cause to switch to algorithms that are more geared toward space saving than speed gain. However, those are mostly in hash calculations, which the FLAC decoder doesn't use.

MozReview-Commit-ID: 6Kl6xxlBOnw

--HG--
extra : rebase_source : 051ac58cd1ed3b617684cda0bd4a93687bbc9924
2017-11-01 19:31:12 +01:00
Jean-Yves Avenard 3f07325414 Bug 1295886 - P10. Add a FLAC only option to ffvpx. r=gerald
Remove the VP8 and VP9 decoder and the subsequently unused functions.

This drops the size to libmozavcodec to around 1MB down from 4MB.

MozReview-Commit-ID: Ge57fauG35L

--HG--
extra : rebase_source : 3f667d7bf89036e9b059727d846af2504ce488b3
2017-11-01 19:01:59 +01:00
Jean-Yves Avenard 391ca166f1 Bug 1295886 - P5. Add flac support on Android. r=gerald
For now this is a C decoder only and FFmpeg isn't optimised to only decode flac (both vp8 and vp9 C decoders code is included, however they aren't enabled).

MozReview-Commit-ID: 7ulwvJDJqVg

--HG--
extra : rebase_source : 7090eee32ba394224ef8c3c1c31abf1543b69975
2017-10-31 14:48:04 +01:00
Jean-Yves Avenard 9a1bda4e02 Bug 1295886 - P4. Ensure HAVE_STDATOMIC_H is properly defined. r=gerald
MozReview-Commit-ID: GDeob2KCAcq

--HG--
extra : rebase_source : 7986205492a16c511670178dfbcc3789119517d8
2017-10-31 14:43:11 +01:00
Jean-Yves Avenard 9212649b5a Bug 1295886 - P3. Remove darwin 32 bits support. r=gerald
OS X 32 bits is no longer supported.

MozReview-Commit-ID: 2SFxDUeQvpB

--HG--
extra : rebase_source : ba68dc79483c2c0191b1168520afbb36f7502418
2017-10-31 13:45:44 +01:00
Jean-Yves Avenard 3252b06662 Bug 1295886 - P2. Extract FFmpeg BSF config options. r=gerald
Will simplify future resync.

MozReview-Commit-ID: CwkIFKYvWsL

--HG--
extra : rebase_source : 8d40fb7c080f087aa076ada231d3556adee615f9
2017-10-31 13:38:23 +01:00
Jean-Yves Avenard 85c82c1a4b Bug 1295886 - P1. Remove unused flac parser. r=gerald
All the flac parser jobs are done by FlacDemuxer

MozReview-Commit-ID: L7VZG64gi52

--HG--
extra : rebase_source : 31cca110abd9f049923bf9d579cb2781ad38bedf
2017-10-30 17:36:39 +01:00
Michael Froman 7eb5cd2f86 Bug 1413709 - add tests to detect improper ice restart by answer. r=bwc
Adding tests that would have shown the issue fixed in Bug 1405940.
If the answer during a renegotiation has modified ICE credentials,
it should cause an error.  These tests check for that error.

MozReview-Commit-ID: 9u8GGpslDdK

--HG--
extra : rebase_source : 6b204cefa96e95abd61d9a57ddd643dd81a41254
2017-11-01 11:56:35 -05:00
Jean-Yves Avenard 96d64e1c44 Bug 1392961 - Add preference to make VP9 the preferred video codec. r=jesup
Behaviour is controlled through the media.navigator.video.vp9_preferred preference.

MozReview-Commit-ID: J06ArFYNmTk

--HG--
extra : rebase_source : a25bd4783fde0acf8291ee440745a619d3fa7db8
2017-10-19 15:18:51 +02:00
Tom Prince e1f007efbe Bug 1413257: Allow disabling ffvpx's AVX2 support on linux64 for Thunderbird's buildbot; r=jya,rillian
MozReview-Commit-ID: 6USzO1GE7dJ

--HG--
extra : rebase_source : 4a25c5e7c1cbe7bb063f615accf6563333c48c9c
2017-10-31 12:42:27 -06:00
Sebastian Hengst 4ff29d14f8 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: GSDYk9wLOAM

--HG--
rename : browser/base/content/test/general/browser_bug561636.js => browser/modules/test/browser/formValidation/browser_form_validation.js
rename : browser/base/content/test/general/browser_bug595507.js => browser/modules/test/browser/formValidation/browser_validation_iframe.js
rename : browser/modules/test/browser/browser_bug1319078.js => browser/modules/test/browser/formValidation/browser_validation_invisible.js
2017-11-01 22:55:12 +01:00
Jim Chen ec08814aaa Bug 1406168 - 2. Remove AndroidJNIWrapper; r=snorp
Remove AndroidJNIWrapper. It was primarily used by JNI.jsm and WebRTC.
Usages in WebRTC are replaced with equivalent uses of JNI templates.

MozReview-Commit-ID: DPSeMOtH2wF
2017-11-01 14:48:48 -04:00
Alfredo.Yang 0dd9f867bb Bug 1407833 - update rust mp4 parser for add overflow. r=kinetik
MozReview-Commit-ID: 8nGLWcXmGCr

--HG--
extra : rebase_source : 36452e27c7a6d9488164defa03f7eea281ddeef3
2017-11-01 14:48:15 +08:00
Alfredo.Yang 3d80dc7ec4 Bug 1412216 - remove unused functions in BufferReader. r=kinetik
MozReview-Commit-ID: 8y6CCe1mleo

--HG--
extra : rebase_source : 99a75aa64e99d30b431c576b8e3b4921028df70a
2017-10-27 15:09:36 +08:00
Alfredo.Yang 952d71b21f Bug 1412216 - remove ByteReader. r=kinetik
MozReview-Commit-ID: 26Pf8GXXoPh

--HG--
extra : rebase_source : f48fe10a9b421968c23d7eb7000b0508cd90537b
2017-10-25 15:42:34 +08:00
Sebastian Hengst f07fc93141 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 4PW6ESqLL73
2017-10-30 23:52:23 +01:00
Attila Craciun 76d19aec36 Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE.
--HG--
extra : amend_source : 43eb53623fe5390c69e92f322f938eb4c956ca00
2017-10-30 12:24:16 +02:00
Jean-Yves Avenard 7838f76570 Bug 1412339 - Enable AVX2 optimizations on Linux x86_64. r=jwwang
MozReview-Commit-ID: 6mMf93LQeRj

--HG--
extra : rebase_source : 531b88872914e02b6924f53c452a22323002d53a
2017-10-27 16:20:39 +02:00
Nicholas Nethercote 9252435548 Bug 1410794 (attempt 2) - Change some |string| occurrences in nsIPrefBranch.idl to |ACString|. r=erahm.
This makes the code nicer. In particular, it removes many getter_Copies()
calls. The patch also converts a lot of nsCStrings to nsAutoCString, which will
avoid heap allocation in the common case.

The patch also renames PREF_CopyCharPref() as PREF_GetCStringPref(), because
it's actually getting a string, not a char, and that matches the existing
GetCString() and GetDefaultCString() methods. Correspondingly, it also renames
PREF_SetCharPref() as PREF_SetCStringPref().

The |aPrefName| arguments in nsIPrefBranch.idl remain as |string| because they
almost always involve passing in C string literals, and passing "foo" is much
nicer than passing NS_LITERAL_CSTRING("foo").

It's worth noting that early versions of this patch used |AUTF8String| instead
of |ACString|. But it turns out that libpref stores prefs internally as Latin1.
And |ACString| is compatible with Latin1 but |AUTF8String| isn't, because
non-ASCII Latin1 strings are not valid UTF-8!

MozReview-Commit-ID: D3f7a1Vl1oE

--HG--
extra : rebase_source : e6e4b15d6d210cfd93686f96400281f02bd1d06b
2017-10-27 10:30:33 +11:00
Matthew Gregan 880b9d2455 Bug 1411849 - Update media/audioipc to d17a7c09. r=kamidphish 2017-10-30 14:40:09 +13:00
Alfredo.Yang 510e47a924 Bug 1412183 - use BufferReader instead of ByteReader in DecoderData. r=kinetik
MozReview-Commit-ID: AgcOuWn7ouo

--HG--
extra : rebase_source : e2aa46b47e848a8d51dc6e48a58e46db6f669b68
2017-10-25 15:40:24 +08:00
Alfredo.Yang c4c528d6c5 Bug 1412183 - use BufferReader instead of ByteReader in H264 parser. r=kinetik
MozReview-Commit-ID: KhwWj1Nr85E

--HG--
extra : rebase_source : 6994f676d9946a38d5577956a4ad33577ef3b535
2017-10-25 15:26:45 +08:00
Alfredo.Yang ae23abee61 Bug 1412183 - use BufferReader instead of ByteReader in AnnexB parser. r=kinetik
MozReview-Commit-ID: YZ4vo7o0Gs

--HG--
extra : rebase_source : 01d7242162cc31dfe1d703e4ded03cd8c5d93748
2017-10-25 09:58:43 +08:00
Alfredo.Yang 86695f2d80 Bug 1412183 - use BufferReader instead of ByteReader in mp4 index parser. r=kinetik
MozReview-Commit-ID: KNfqpgzQleE

--HG--
extra : rebase_source : ef97f84ba308df097097a9ef84e3c3378078d432
2017-10-23 10:43:30 +08:00
Sebastian Hengst 5c15da1f08 merge mozilla-inbound to mozilla-central. r=merge a=merge
--HG--
rename : testing/talos/tests/__init__.py => testing/talos/talos/unittests/__init__.py
rename : testing/talos/tests/browser_output.ts.txt => testing/talos/talos/unittests/browser_output.ts.txt
rename : testing/talos/tests/browser_output.tsvg.txt => testing/talos/talos/unittests/browser_output.tsvg.txt
rename : testing/talos/tests/profile.tgz => testing/talos/talos/unittests/profile.tgz
rename : testing/talos/tests/ps-Acj.out => testing/talos/talos/unittests/ps-Acj.out
rename : testing/talos/tests/test_talosconfig_browser_config.json => testing/talos/talos/unittests/test_talosconfig_browser_config.json
rename : testing/talos/tests/test_talosconfig_test_config.json => testing/talos/talos/unittests/test_talosconfig_test_config.json
rename : testing/talos/tests/xrestop_output.txt => testing/talos/talos/unittests/xrestop_output.txt
2017-10-27 12:45:34 +03:00
Sebastian Hengst d10e26c913 merge mozilla-central to mozilla-inbound. r=merge a=merge 2017-10-27 00:00:25 +02:00
Andi-Bogdan Postelnicu b5bdcb596f Bug 1411605 - don't memset the entire mCodecSpecificInfo. r=dminor
MozReview-Commit-ID: DEJXdfAuZrl

--HG--
extra : rebase_source : 6ebbf8191d02e8b55bf05e9a0df1a47586defbf6
2017-10-26 12:20:26 +03:00
Jean-Yves Avenard f69622c5b0 Bug 1411883 - P2. Update resync documentation. r=gerald
MozReview-Commit-ID: 9L6B8qPsUcR

--HG--
extra : rebase_source : eba16ab6d1e0f58aa9aec6212c1916c7f2788481
2017-10-26 12:55:35 +02:00
Jean-Yves Avenard 1154b74148 Bug 1411883 - P1. Copy files as-is from FFmpeg upstream. r=gerald
r?gerald

MozReview-Commit-ID: J8AZngUJSOb

--HG--
extra : rebase_source : 887f47644b21e00b0b494a51f1f6f83f9b01ae6e
2017-10-26 12:53:30 +02:00
Nils Ohlmeier [:drno] daf7230f6d Bug 1411498: delete unused sipcc states. r=bwc,smaug
MozReview-Commit-ID: DnJrQk4hkYb

--HG--
extra : rebase_source : c615899389154cca4eecdbd6e332986837451d26
2017-10-24 23:40:02 -07:00
Attila Craciun 252daa8e0a Merge mozilla-central to mozilla-autoland. r=merge a=merge CLOSED TREE 2017-10-26 12:32:58 +03:00
Attila Craciun 0cab95ab0f Merge inbound to mozilla-central r=merge a=merge 2017-10-26 12:20:45 +03:00
Nathan Froyd 01b0ad5257 Bug 1411694 - add an override declaration in WebrtcMediaCodecVP8VideoCodec; r=jesup
We have override declarations for lots of other overriden virtual
functions, but not this one.
2017-10-25 16:00:54 -04:00
Alfredo.Yang 41a2709293 Bug 1411525 - use BufferReader in flac/ogg parser. r=kinetik
MozReview-Commit-ID: 5chnxLnpqmY

--HG--
extra : rebase_source : 85e68812f1d354813ae36731a5a36bfe7f58c2e2
2017-10-19 10:16:32 +08:00
Munro Mengjue Chiang eba2fd4463 Bug 1409643 - call GetWindowTextLength() for visble window only. r=jib
MozReview-Commit-ID: CKl1mwV7YHw

--HG--
extra : rebase_source : fe743f735c8c1935d0042279e70d15b289189107
2017-10-19 18:03:05 +08:00
Alfredo.Yang 8da0342978 Bug 1411821 - use BufferReader instead of ByteReader in MP3 parser. r=kinetik
MozReview-Commit-ID: BpfCZUG7C6c

--HG--
extra : rebase_source : 45716111d62faac68499f4c369e3cb948de190ce
2017-10-20 11:54:29 +08:00
Jean-Yves Avenard 4063f63822 Bug 1366201 - P4. Remove no longer necessary files. r=gerald
MozReview-Commit-ID: 8aGXFlw6sR0

--HG--
extra : rebase_source : 4d8e27ad4a81276d5a55cce11e37978fb966ac3b
2017-10-24 21:59:46 +02:00
Jean-Yves Avenard 9bbe2b99fa Bug 1366201 - P3. Update ffvp9/ffvp8 to 3.4 branch. r=gerald
Structure of code was slightly modified so that it should be no longer necessary to re-generate the config_*.h files, greatly simplifying the resync process.

MozReview-Commit-ID: Ap6HpJAANT6

--HG--
extra : rebase_source : 52e5e3b9b2401644dc536d746219e5f3864c600c
2017-10-24 21:44:23 +02:00
Jean-Yves Avenard 07d56f7ff5 Bug 1366201 - P2. Revert "Bug 1292039: [ffmpeg] P1. Remove unused options and dictionary features." r=gerald
This partially reverts commit e99d6caa3a3778c0bb1f2fa9f2b4222bba2eeafereverts

FFmpeg requires specific default values in AVCodecContext to be set. It is quickly becoming too complicated to track what those should be. AVOptions automatically set all the values to their default.

MozReview-Commit-ID: lDFeUvwTMg

--HG--
extra : rebase_source : 04c5df11e485bcbae4fbf41d8b5ed512316b4d1b
2017-10-24 19:33:05 +02:00
Jean-Yves Avenard 24d074b126 Bug 1366201 - P1. Revert "Bug 1274256 - TSan: data race gfx/layers/client/TextureClient.cpp:1161 in mozilla::layers::MappedYCbCrChannelData::CopyInto." r=gerald
This reverts commit f69e779a1903

FFmpeg 3.4 no longer requires this change.

--HG--
extra : rebase_source : 4767a08e886e17df2144e182105a29b0475d6367
2017-10-19 17:13:09 +02:00
Dan Glastonbury f02d2cb4e5 Bug 1410702 - P2: Handle EINTR from recvmsg/sendmsg calls. r=kinetik
MozReview-Commit-ID: juVD61XSzL

--HG--
extra : rebase_source : feb6c51c3259dd2cd64188ab27f83579efc7d1b0
2017-10-25 14:57:26 +10:00
Dan Glastonbury 4f66ebac06 Bug 1410702 - P1: Handle errors in send_recv! r=kinetik
Connection handling code wasn't handling errors from receive()
properly. Attempting to unwrap on an Err was causing a panic.

MozReview-Commit-ID: GURe3FHPbjT

--HG--
extra : rebase_source : 664bf389020feb4a12f43422351c20ab7e804e30
2017-10-25 14:53:03 +10:00
Chris Manchester c86173526a Bug 1403346 - Replace all uses of ALLOW_COMPILER_WARNINGS with a template, remove ALLOW_COMPILER_WARNINGS. r=glandium
MozReview-Commit-ID: 1G2o4fy74cf
2017-10-25 15:12:09 -07:00
Alfredo.Yang ccda6970dd Bug 1410565 - add gtest for mTimescale checking. r=kinetik
MozReview-Commit-ID: JHpbUKIyOkN

--HG--
extra : rebase_source : 34768a30256b2f1e39478049a5009b28beb1d9e5
2017-10-24 16:05:46 +08:00
Alfredo.Yang 5ad617cb8a Bug 1410565 - check mTimescale to avoid dividing by zero. r=kinetik
MozReview-Commit-ID: 7uxgaVAbQds

--HG--
extra : rebase_source : c3976d03877cdd8d1e03ee22ca29f54a9800eb67
2017-10-24 14:44:19 +08:00
Dan Glastonbury 0ac4f5bd34 Bug 1410107 - Grow audioipc server slabs as required. r=kinetik
MozReview-Commit-ID: zFfex3LX7K

--HG--
extra : rebase_source : 2ebbb826c210e05a259bf3376853d1886759dfc1
2017-10-25 09:14:45 +10:00
Tom Ritter 64fa57a006 Bug 1406542 Enable PTHREAD for vpx and aom under MinGW because we do in fact have them. r=rillian
We were getting warnings that HAVE_PTHREAD_H was being redeclared with the wrong value.
Let's correct that.

MozReview-Commit-ID: KVAsYofozIT

--HG--
rename : media/libvpx/config/win/ia32/vp8_rtcd.h => media/libvpx/config/win/mingw32/vp8_rtcd.h
rename : media/libvpx/config/win/ia32/vp9_rtcd.h => media/libvpx/config/win/mingw32/vp9_rtcd.h
rename : media/libvpx/config/win/ia32/vpx_config.asm => media/libvpx/config/win/mingw32/vpx_config.asm
rename : media/libvpx/config/win/ia32/vpx_config.c => media/libvpx/config/win/mingw32/vpx_config.c
rename : media/libvpx/config/win/ia32/vpx_config.h => media/libvpx/config/win/mingw32/vpx_config.h
rename : media/libvpx/config/win/ia32/vpx_dsp_rtcd.h => media/libvpx/config/win/mingw32/vpx_dsp_rtcd.h
rename : media/libvpx/config/win/ia32/vpx_scale_rtcd.h => media/libvpx/config/win/mingw32/vpx_scale_rtcd.h
extra : rebase_source : beb8b369df337ce2a6fcd860bb9437537376e4c5
2017-10-24 16:57:51 -05:00
Ralph Giles cbe716f52a Bug 1411073 - av1: Clean up duplicate filenames check. r=kinetik,mshal
Check for filenames which differ only by .asm vs .c filename
extensions when importing a new version of the libaom reference
implementation of the av1 video codec.

These confuse our build system as well. Also remove the obsolete
vp8 and vp9 search directories, which generate warnings from 'find'.

MozReview-Commit-ID: DRZL7GUrsYh

--HG--
extra : rebase_source : 4bc8708dd3b2e386c19bd6b952ca2587a2284a19
2017-10-17 10:21:58 -07:00
Andrew Gaul 7ee6e2a506 Bug 1382049 - Make inner classes static when possible. r=nalexander, r=sebastian
This avoids an implicit this field and can help GC. Found via error-prone.

--HG--
extra : rebase_source : 6d91bfcb98a05c94c13fc41fd0b5b14f1404ddcf
2017-07-18 16:51:30 -07:00
Alex Chronopoulos 0ae243650c Bug 1411866 - Update cubeb from upstream to cf5ddc5. r=padenot,kinetik
MozReview-Commit-ID: IPgIZ6oBVfg
2017-10-26 10:41:49 +03:00
Dan Minor 93e787c563 Bug 1414632 - Prevent division by zero in webrtc::Merge::SignalScaling; r=jesup
A zero input_length here would be caused by a decoder error in
NetEqImpl::Decode(). Looking at the code in GetAudioInternal() which calls
Decode() it appears that the intention is to continue processing even if no new
audio data is decoded. Based on this, it seems safest to just skip muting in
SignalScaling if the input_length is zero.

The other potential cause of a division by zero here is if fs_mult_ is zero which
should not normally happen. But there's no harm in checking for that as well.


MozReview-Commit-ID: J0pd2wbjeZl

--HG--
extra : rebase_source : 5206abd1f85986d395a7eead148cb06d1d050842
2017-11-08 12:39:53 -05:00
Nika Layzell c223b9ff2d Bug 1414974 - Part 6: Change WebIDL bindings to refer to nsGlobalWindowInner rather than nsGlobalWindow, r=bz
MozReview-Commit-ID: KbCpDFoWyTe
2017-11-09 10:44:49 -05:00
Nika Layzell 3409141758 Bug 1414974 - Part 2: Switch many consumers to nsGlobalWindow{Inner,Outer}, r=smaug
This is a large patch which tries to switch many of the external consumers of
nsGlobalWindow to instead use the new Inner or Outer variants.

MozReview-Commit-ID: 99648Lm46T5
2017-11-09 10:44:47 -05:00
Randell Jesup 97cdc0cf7f Bug 1408523 - Use SyncRunnable instead of Dispatch(...NS_DISPATCH_SYNC) when running on non-nsThreads. r=jib
--HG--
extra : rebase_source : 3b80f942f75e7c36b8f753d09d095793fc440cb8
2017-10-24 00:16:29 -04:00
Sylvestre Ledru d60d69e2cb Bug 1411001 - Remove the +x permissions on cpp & h files r=froydnj
MozReview-Commit-ID: DjDkL20wRg0

--HG--
extra : rebase_source : a343d83d1f4e97e4ba56d0f57fec93079df0b5ea
2017-10-23 20:59:55 +02:00
bechen@mozilla.com c09e4a8ee9 Bug 1183495 - part3: Remove mozSrcObject usage. r=jwwang
MozReview-Commit-ID: Gtpne3O0pBQ

--HG--
extra : rebase_source : 87544aa023e5ac079a8ae02de77e2aeab91e97cf
2017-10-20 11:23:41 +08:00
Dan Minor 20baeb4811 Bug 1404039 - Add a unittest for VideoConduit getting a signal to reduce quality due to load or bandwidth; r=pehrsons
MozReview-Commit-ID: 5J3wINSnStR

--HG--
extra : rebase_source : 0c9518c0501ca579ed9d948bde63159c21d9657c
2017-10-18 15:19:21 -04:00
Jean-Yves Avenard 858f178676 Bug 1410090 - Remove remnant of FFOS OMX code. r=cpearce
For webrtc, the most important part of the code had already been removed in bug 1355048 and could no longer be called

MozReview-Commit-ID: Fx9XI0zR1gn

--HG--
extra : rebase_source : 360996760abab650684440fbeea258b43dccfd83
2017-10-19 16:51:04 +02:00
Nils Ohlmeier [:drno] 75da806f11 Bug 1408218: ignore EUI 64 and Teredo addresses if not needed. r=bwc
MozReview-Commit-ID: 5QHi9iC2e7y

--HG--
extra : rebase_source : 0f4f4afa3edd4153418661d8ef6f3efa12bf6223
2017-10-13 08:32:16 -07:00
James Cheng f0a43c284e Bug 1409670 - Skip decrypting request when receiving an unencrypted sample in Clearkey implementation. r=cpearce
MozReview-Commit-ID: 5XIUeFc3PSD

--HG--
extra : rebase_source : a36e27b385f1622bc7125e8d7e8c1b1b6e930842
2017-10-19 16:45:21 +08:00
Sebastian Hengst 24583b9443 merge mozilla-central to autoland. r=merge a=merge 2017-10-20 01:08:09 +02:00
Dan Minor 5168e78250 Bug 1402334 - Fix static analysis warning in CSFLog.cpp; r=drno
MozReview-Commit-ID: 2m1nKxCsxwg

--HG--
extra : rebase_source : 88b50248bf4b065af5bd893c660bf27ab40dc6dd
2017-10-16 09:03:04 -04:00
Dan Minor 0fd69c4f78 Bug 1408582 - Fix unused variable warning in CSFLog.cpp on Android; r=drno
MozReview-Commit-ID: 2PZyw40eMaF

--HG--
extra : rebase_source : 96f6460593afcfa5bc16ba9cfdb9244965ec6210
extra : amend_source : f18bd495180bbd2d3031fa226433e8f2f29e4a6e
2017-10-16 12:44:26 -04:00
Matthew Gregan 0d6e66757d Bug 1407487 - P5: Support connections from within chrome process in audioipc. r=kamidphish
MozReview-Commit-ID: 9SdUWlJ02DR
2017-10-19 18:02:59 +13:00
Matthew Gregan cb483fa8cf Bug 1407487 - P4: Disable backtrace in error-log to work around bug 1409276. r=kamidphish
MozReview-Commit-ID: KHGTVi6QePx
2017-10-19 18:02:57 +13:00
Ryan VanderMeulen cb612851ed Merge inbound to m-c. a=merge 2017-10-18 21:01:34 -04:00
Nils Ohlmeier [:drno] 8fd8af4c1b Bug 1408371: report AEC log dir through getter. r=ng,smaug
MozReview-Commit-ID: 1Tb8nwYzMFt

--HG--
extra : rebase_source : e44b90749667961771d573da3b9e6d65b3bf554c
2017-10-13 17:57:15 -07:00
Byron Campen [:bwc] 4fda13fafa Bug 1406154: Ensure that we avoid truncating the interface description strings in a couple of corner cases. r+drno
MozReview-Commit-ID: KMTpbkvA4N

--HG--
extra : rebase_source : 377b9ae8c2664d186a496ef04a6e42b00d56883f
2017-10-12 12:12:40 -05:00
Dan Horák a098eb0deb Bug 1408504 - Implement WriteSamples in tests for big endian platforms; r=dminor
Webrtc code supports big endian platforms, but a method in tests lacks a big endian
variant. Add it based on WavReader/WavWriter code.

MozReview-Commit-ID: A4OTnYlGgvU

--HG--
extra : rebase_source : f331c799cea89e6090fd02269d3ee8728cbeca45
2017-10-17 10:27:12 +00:00
Makoto Kato 58ad07f1ee Bug 1402334 - Fix bustage for 10.11 SDK. r=jesup
MozReview-Commit-ID: 3dnZmFEhNBQ

--HG--
extra : histedit_source : 260168a1d04ede514a12bb33ab1ed571ab25e56e
2017-10-18 10:15:45 +09:00
Sebastian Hengst 34714cebde merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 2KL1o3EPUk
2017-10-17 23:52:28 +02:00
Dan Minor 1d0e9fe0b4 Bug 1404250 - Ensure that target bitrate is between minimum and maximum bitrates in VideoConduit; r=pehrsons
MozReview-Commit-ID: Am19abfrETx

--HG--
extra : rebase_source : 7906e80ab0a07cc5ffb7940a4f362b709a4bacbc
2017-10-10 10:43:09 -04:00
Alfredo.Yang a9ea7d485f Bug 1409298 - print log when parse failed. r=kinetik
MozReview-Commit-ID: D02HVh6liJS

--HG--
extra : rebase_source : 5ef37ad35a79050db61e4ada42e40ae634fe8940
2017-10-17 16:51:58 +08:00
Sebastian Hengst 0fde5cb6b5 merge mozilla-central to autoland. r=merge a=merge 2017-10-17 11:46:52 +02:00
Sebastian Hengst 32f7c8fec3 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 1h3kZyrtqSt
2017-10-17 11:45:16 +02:00
Matthew Gregan bc2c40ef4d Bug 1407490 - Update media/audioipc to c466287. r=kamidphish
MozReview-Commit-ID: 8V6k3m2f3lI

--HG--
extra : rebase_source : 9e986d5c4a5b509162ef03ec86b2a95a9cd4ff0c
2017-10-16 15:37:10 +13:00
Alfredo.Yang 2c5201069c Bug 1387798 - remove uncessary check for remaining data and add error log when parsing fails. r=kinetik
MozReview-Commit-ID: Bo6q3ysvktr

--HG--
extra : rebase_source : 2c6f4e2b9475c2c8a8d718f1cb2ef59cde518b71
2017-10-13 14:40:05 +08:00
Alfredo.Yang 136532474c Bug 1387798 - use Result as return value in BufferReader. r=kinetik
MozReview-Commit-ID: uLny8ebSic

--HG--
extra : rebase_source : 964a677865f82f1fa745ffa0530ebe5fb5ebb76b
2017-10-13 09:44:48 +08:00
Alfredo.Yang e707fdfbf4 Bug 1387798 - move initialized codes out of box constructor to another function which could be able to return error. r=kinetik
MozReview-Commit-ID: 5LJVCTYIT7o

--HG--
extra : rebase_source : a87d825abb76b5c9410eee1b996f3559ca7153d7
2017-10-13 10:13:28 +08:00
Alfredo.Yang 9bc0b0adbc Bug 1387798 - rename to BufferReader. r=kinetik
MozReview-Commit-ID: E1zhXdLEPFS

--HG--
extra : rebase_source : d2ef3260a6545c2d8c271126d7917df9443473fd
2017-10-11 15:55:15 +08:00
Alfredo.Yang 1eb3494e1d Bug 1387798 - copy ByteReader. r=kinetik
MozReview-Commit-ID: 6L0A3sEbLKY

--HG--
rename : media/libstagefright/binding/include/mp4_demuxer/ByteReader.h => media/libstagefright/binding/include/mp4_demuxer/BufferReader.h
extra : rebase_source : 4605dadad2be963306277f5c6563c12c62427615
2017-10-11 15:51:35 +08:00
Kris Maglione 9184710ae5 Bug 1404198: Part 2g - Switch to NS_NewTimer* in media. r=njn
MozReview-Commit-ID: 3ydSj5HfYzZ

--HG--
extra : rebase_source : 6d38da71d3c82b900b46e69c12ceb81202dd965d
2017-10-15 23:14:33 -07:00
Michael Froman dd94c4ef01 Bug 1408487 - handle parent process returning 0 STUN addrs. r=drno
1) don't call StartGathering in e10s mode if parent process failed to provide STUN addrs.
2) set ICE connection state to failed if parent process returns 0 STUN addrs

MozReview-Commit-ID: COPr3TavdvM

--HG--
extra : rebase_source : 6e20424cf51fa28311f7f9f6968c2a59333b6729
2017-10-18 14:06:02 -05:00
Michael Froman 90e4564993 Bug 1405940 - Fix Null Pointer dereference in sigslot::lock_block r=bwc
Caused by several issues:
1) We were allowing an answer with modified ufrag/pass to
   begin an ICE restart even if the offer didn't indicate
   it was restarting.
2) This should no longer happen, but in cases where restart logic
   was started inappropriately, TransportLayerIce::SetParameters
   could get a null stream, and we check for that now.

MozReview-Commit-ID: JFQ1zz3l5wY

--HG--
extra : rebase_source : a6d43aabada86669850ddce07ea86da8118a6bec
2017-10-12 22:38:01 -05:00
Sebastian Hengst ffcd2ce160 merge mozilla-central to autoland. r=merge a=merge on a CLOSED TREE
--HG--
extra : amend_source : ef359be373a97cad5a91f0150a46add4c3d8ab7c
2017-10-18 15:54:23 +02:00
Chris Pearce 3a511d931d Bug 1409546 - Use literal strings instead of assigning const char* to TrackInfo::mMimeType in mp4 demuxer. r=gerald
This works around an issue in xpcom strings that causes us to report leaking
a string for some unknown reason, so that we can unblock gecko-media which
wants to run the MP4Demuxer seek test.

We should follow up and try to figure out the root cause at a later time.

MozReview-Commit-ID: C6UlOTAIh1l

--HG--
extra : rebase_source : e9b3bceb28ada6ab0e0c3de5588c07228d722d0e
2017-10-18 08:12:51 +02:00
Dan Minor b66f2f1f6f Bug 1402334 - Build mediapipeline using unified build; r=drno
This replaces MOZ_MTLOG with CSFLog, which is already set up to handle having
a shared LazyLogModule used from difference source files.

MozReview-Commit-ID: KNUKL92aWcw

--HG--
extra : rebase_source : 6a52dfc3c69a98318b26067aa608e5d484c8b8e2
2017-10-02 14:29:20 -04:00
Dan Minor 588a074b49 Bug 1402334 - Add log level test to CSFLog; r=drno
MozReview-Commit-ID: 3EKeDLAmEs0

--HG--
extra : rebase_source : 71a26aa97d20b280b7453e08a389a5b8d10bdcde
2017-10-02 14:33:23 -04:00
Dan Minor 69e58e48d9 Bug 1402334 - Build media-conduit and peerconnection using unified build; r=jesup
This removes the duplicate definition of logTag and fixes a preprocessor related
unified build error.

MozReview-Commit-ID: LP5frg0QZul

--HG--
extra : rebase_source : b3a6d4dbd40545e34b72623e9c976750d7f1d0ca
2017-10-02 11:05:29 -04:00
Byron Campen [:bwc] f651e3ada4 Bug 1404535: Add telemetry that times nr_ice_gather. r+drno r=chutten,drno,liuche
MozReview-Commit-ID: I4nH8sZNX5g

--HG--
extra : rebase_source : 9a7cc3673f68fefb9ed19a58ab896b0d60648b17
2017-09-29 17:49:32 -05:00
Nils Ohlmeier [:drno] 660bb85308 Bug 1407492: remove aec log dir user pref. r=mjf
MozReview-Commit-ID: 5oNuOrSHY2y

--HG--
extra : rebase_source : 4fdf9a7cd4e88dde6b7ac583007ae90fed7fb0fe
2017-10-10 19:43:37 -07:00
Ryan VanderMeulen 0dcd727f08 Merge m-c to autoland. a=merge 2017-10-11 17:55:13 -04:00
Tom Ritter 701ee70a22 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : fe434db73a8da686391462c12b91648348abcdc9
2017-10-09 15:01:48 -05:00
Jeff Walden be56429c85 Bug 1402344 - Update mfbt-double-conversion to the latest upstream rev. r=froydnj
--HG--
rename : mfbt/double-conversion/source/LICENSE => mfbt/double-conversion/double-conversion/LICENSE
rename : mfbt/double-conversion/source/README.md => mfbt/double-conversion/double-conversion/README.md
rename : mfbt/double-conversion/source/bignum-dtoa.cc => mfbt/double-conversion/double-conversion/bignum-dtoa.cc
rename : mfbt/double-conversion/source/bignum-dtoa.h => mfbt/double-conversion/double-conversion/bignum-dtoa.h
rename : mfbt/double-conversion/source/bignum.cc => mfbt/double-conversion/double-conversion/bignum.cc
rename : mfbt/double-conversion/source/bignum.h => mfbt/double-conversion/double-conversion/bignum.h
rename : mfbt/double-conversion/source/cached-powers.cc => mfbt/double-conversion/double-conversion/cached-powers.cc
rename : mfbt/double-conversion/source/cached-powers.h => mfbt/double-conversion/double-conversion/cached-powers.h
rename : mfbt/double-conversion/source/diy-fp.cc => mfbt/double-conversion/double-conversion/diy-fp.cc
rename : mfbt/double-conversion/source/diy-fp.h => mfbt/double-conversion/double-conversion/diy-fp.h
rename : mfbt/double-conversion/source/double-conversion.cc => mfbt/double-conversion/double-conversion/double-conversion.cc
rename : mfbt/double-conversion/source/double-conversion.h => mfbt/double-conversion/double-conversion/double-conversion.h
rename : mfbt/double-conversion/source/fast-dtoa.cc => mfbt/double-conversion/double-conversion/fast-dtoa.cc
rename : mfbt/double-conversion/source/fast-dtoa.h => mfbt/double-conversion/double-conversion/fast-dtoa.h
rename : mfbt/double-conversion/source/fixed-dtoa.cc => mfbt/double-conversion/double-conversion/fixed-dtoa.cc
rename : mfbt/double-conversion/source/fixed-dtoa.h => mfbt/double-conversion/double-conversion/fixed-dtoa.h
rename : mfbt/double-conversion/source/ieee.h => mfbt/double-conversion/double-conversion/ieee.h
rename : mfbt/double-conversion/source/strtod.cc => mfbt/double-conversion/double-conversion/strtod.cc
rename : mfbt/double-conversion/source/strtod.h => mfbt/double-conversion/double-conversion/strtod.h
rename : mfbt/double-conversion/source/utils.h => mfbt/double-conversion/double-conversion/utils.h
extra : rebase_source : 2d03850dcd1db749f0debecffec2e870acd1b958
2017-10-09 22:15:37 -07:00
Philippe Normand 52c9629669 Bug 1407063 - Fix non-unified build in SampleTable.h. r=gerald
nsTArray was previously used without prior declaration. Including the nsTArray.h
header fixes this issue.

MozReview-Commit-ID: 5FmrbjSmZUD

--HG--
extra : rebase_source : d87fd737d3a15067d7106b4fe4ae1f937d799e10
2017-10-05 15:58:16 +02:00
Philippe Normand 6aa2e63f95 Bug 1407063 - Fix non-unified build in MPEG4Extractor.cpp. r=gerald
Calls to fallible need to be prefixed by the mozilla namespace because
it's not declared as globally usable.

MozReview-Commit-ID: CJoAoTjXGUH

--HG--
extra : rebase_source : 81618f26b4f2b16b11998673a6cad67d4bca49d4
2017-10-05 15:57:12 +02:00
Philippe Normand 40d1887a1d Bug 1407063 - Fix non-unified build in ESDS.cpp. r=gerald
Fallible is used in this compilation unit so the corresponding header
needs to be included. The <new> header is also required for new placement
calls.

MozReview-Commit-ID: 2eZ8U1wDYs8

--HG--
extra : rebase_source : 53f17d2ef7f8826ac344a2dc2bb278b7b83cbee5
2017-10-05 15:55:43 +02:00
Philippe Normand b93692bf71 Bug 1407063 - Fix non-unified build in SinfParser.cpp. r=gerald
The Stream class is used in this compilation unit so the Stream.h header needs
to be included.

MozReview-Commit-ID: 54X1UKuydUy

--HG--
extra : rebase_source : 96585c678b163fd7506b60ba3c2390d6f8b51d33
2017-10-05 15:54:08 +02:00
Philippe Normand 71f0559306 Bug 1407063 - Fix non-unified build in DecoderData.cpp. r=gerald
EndianUtils.h include was missing and some function calls required
explicit mention to the mozilla namespace.

MozReview-Commit-ID: CFsr7RJ7IGx

--HG--
extra : rebase_source : 01cde66752d6a71938cd1fe9d5f009158ceb7868
2017-10-05 15:53:07 +02:00
Philippe Normand de1fe404f9 Bug 1407063 - Fix non-unified build in MoofParser.cpp. r=gerald
The stagefright namespace isn't used in this file and because it
wasn't previously declared in this compilation unit, a compiler error was raised.

MozReview-Commit-ID: HoYyrmIIXSV

--HG--
extra : rebase_source : 57ac59c06cdc4f54676c86a109ae404072541555
2017-10-05 15:51:32 +02:00
James Cheng 38c77e80cb Bug 1406080 - Part2 - Reject creating with unsupported cdm version in clearkey cdm and cdm-fake. r=cpearce
MozReview-Commit-ID: JvSsqZekRQ6

--HG--
extra : rebase_source : e80713dbf52aad29a32ff71a083c19479094b9a6
2017-10-07 00:06:06 +08:00
Sebastian Hengst ee63f2e30a Backed out changeset 0317bcff40bc (bug 1406687) for build bustage at testing/gtest/gtest/src/gtest.cc:3871: 'Unused' was not declared in this scope. r=backout 2017-10-09 18:52:39 +02:00
Tom Ritter 22d2cdf063 Bug 1406687 Pass return values from fwrite to Unused to silence the warn-unused-result warning r=njn
MozReview-Commit-ID: 4v6tPF5aMz7

--HG--
extra : rebase_source : c54b129c6815096035e262322f40aa0884b1ae56
2017-10-09 00:26:16 -05:00
Michael Froman 2bb753aa78 Bug 1406434 - fixing ice restart and rollback counts on about:webrtc. r=ng
This is re-adding changes from Bug 1321628 that were overwritten by the
webrtc.org v49 import.

MozReview-Commit-ID: GI4OdFANJ8N

--HG--
extra : rebase_source : ec7af8f7d9c35831b3b58a92ae30bc1da6f43f23
2017-10-06 11:26:22 -05:00
Chris Pearce 47c2e3ae92 Bug 1405697 - Move BaseMediaResource declaration to its own file. r=jwwang
This means we can simplify MediaResource.h to only include the abstract
interface, and MediaResourceIndex.

I also had to add a few includes here and there to fix the non-unified build.


MozReview-Commit-ID: 4R7LTXq25dm

--HG--
rename : dom/media/MediaResource.h => dom/media/BaseMediaResource.h
extra : rebase_source : edef4a65df4dcb92f8536052d170d78f95315753
2017-10-04 20:57:11 +02:00
Sebastian Hengst 7b3f84a66d Backed out changeset 4eb36d1710ca (bug 1402334) for bustage at media/webrtc/signaling/src/media-conduit/AudioConduit.cpp:609: 'logTag' was not declared in this scope. r=backout on a CLOSED TREE 2017-10-04 19:13:56 +02:00
Sebastian Hengst 41b7635dd5 Backed out changeset de7bd38908da (bug 1402334) 2017-10-04 19:12:24 +02:00
Sebastian Hengst f50ee09496 Backed out changeset 978b0400ac3b (bug 1402334) 2017-10-04 19:12:19 +02:00
Dan Minor 85e0a8d5b0 Bug 1402334 - Build mediapipeline using unified build; r=drno
This replaces MOZ_MTLOG with CSFLog, which is already set up to handle having
a shared LazyLogModule used from difference source files.

MozReview-Commit-ID: KNUKL92aWcw

--HG--
extra : rebase_source : 6d9eb3421c364f941c4cdf6d40217d2b853faacb
2017-10-02 14:29:20 -04:00
Dan Minor 5e6e96008c Bug 1402334 - Add log level test to CSFLog; r=drno
MozReview-Commit-ID: 3EKeDLAmEs0

--HG--
extra : rebase_source : 3cd2251011988f7cd5fc9101af9ec9a8e55696c9
2017-10-02 14:33:23 -04:00
Dan Minor 8bfcd583ee Bug 1402334 - Build media-conduit and peerconnection using unified build; r=jesup
This removes the duplicate definition of logTag and fixes a preprocessor related
unified build error.

MozReview-Commit-ID: LP5frg0QZul

--HG--
extra : rebase_source : 64f2d77816c8d3681a7cf795317e8bdcb73c6713
2017-10-02 11:05:29 -04:00
Byron Campen [:bwc] 0c94395051 Bug 1377299: Add packet dump hooks r+drno r=drno,smaug
MozReview-Commit-ID: Jr7n49OOduG

--HG--
extra : rebase_source : 8880b8b6bf842f996f99e86fc45510e59e70a665
2017-06-29 19:14:06 -05:00
Sebastian Hengst 7e81b9743d merge mozilla-central to autoland. r=merge a=merge 2017-10-04 11:15:12 +02:00
Arthur Edelstein 5b21d91dce Bug 1405139 - Fix ubsan runtime error for TrackInfo::TrackType. r=gerald
We're plan to enforce -fsanitize=enum, so no need to test outside
the enum range.
2017-10-03 10:17:00 -04:00
Wes Kocher f4358f1539 Merge inbound to central, a=merge
MozReview-Commit-ID: I1ge4dvWtTB
2017-10-03 14:37:35 -07:00
Glenn Randers-Pehrson 16b91208a6 Bug 1402057 - Update in-tree libpng to version 1.6.34. r=jrmuizel 2017-09-30 16:53:00 -04:00
Michael Froman 5ea6a54fa2 Bug 1402495 - changes to support MID in audio packets. r=drno
MozReview-Commit-ID: BivuIsgNLYI

--HG--
extra : rebase_source : a5b08a2dd4c8c19985bd85f77679e0300c15589f
2017-09-15 13:55:17 -05:00
Michael Froman 6e07c1bbf9 Bug 1361894 - ignore STUN/TURN servers with mis-matched link local addr. r=bwc
MozReview-Commit-ID: FMRWMHCROUf

--HG--
extra : rebase_source : 98d3100010c50a21bd48c474aac140e8e1636271
2017-09-29 09:20:07 -05:00
Michael Froman cd290b865f Bug 1402495 - changes to support MID in video packets. r=drno
MozReview-Commit-ID: E7RoFZBb5C8

--HG--
extra : rebase_source : 863b94fe968f55f86c19b13073b831326e5387bb
2017-08-18 09:53:34 -05:00
Michael Froman 6581f716eb Bug 1402495 - Use constants for the RtpExtension URIs. r=drno
MozReview-Commit-ID: EldtSM9Ygtl

--HG--
extra : rebase_source : 56191da92de7dce56bef3ce3e1beb36a23aff6a2
2017-09-01 16:53:46 -05:00
Paul Adenot 6298126ac4 Bug 1405258 - Update libcubeb to 40cd4ad0 to fix warnings as errors bustage.
MozReview-Commit-ID: 53knVqcswLX

--HG--
extra : rebase_source : 7379c68360a6004da1afcea920195e5dbca4f9c0
2017-10-03 13:40:00 +02:00
Paul Adenot 37bfa43273 Bug 1405258 - Update libcubeb to revision ba2a89611875cd9f2dabae99a362461b03c0dd3d
MozReview-Commit-ID: PngLiVneAh

--HG--
extra : rebase_source : 9f604112fad6cafb0883e3248823f78106ec5e19
2017-10-03 12:18:07 +02:00
Dan Minor 5244e5c40e Bug 1401540 - Allow empty BUNDLE groups; r=bwc
MozReview-Commit-ID: 9IIwUnaMZ1m

--HG--
extra : rebase_source : 87729e9303fe1220f53db2f203efc99d628e020a
2017-09-27 12:49:19 -04:00
Wes Kocher eb9a2ed0f2 Merge inbound to central, a=merge
MozReview-Commit-ID: IqwKWn7ceHC
2017-09-29 14:47:25 -07:00
Dan Minor 5af93e95a8 Bug 1402818 - Set hwnd_ to NULL in PlatformUIThread::Stop(); r=pehrsons
We only create an event window in Start() if hwnd_ is NULL, but Stop() does
not set it to NULL. This causes the thread to no longer be a GUI thread if
Stop() and then Start() is called on the same thread leading to assertion
failures.

MozReview-Commit-ID: 5TpazUCqBuR

--HG--
extra : rebase_source : 461066e576af87b27c82075a15d6b5772282b54c
2017-09-28 16:32:31 -04:00
Alfredo.Yang 0e22fafb90 Bug 1404182 - add testcase for bug 1380468. r=kinetik
MozReview-Commit-ID: Kg9QeszWnNT

--HG--
extra : rebase_source : 110e38299efadd892ffdc0146f83117981b74f54
2017-09-29 10:55:29 +08:00
Andreas Pehrson 516c8198a1 Bug 1403714 - Only regard max_fs when set explicitly. r=dminor
MozReview-Commit-ID: DczP0bq96AW

--HG--
extra : rebase_source : c5ef2418b8e3fd0b236aee07e0628de1d596fed9
2017-09-28 18:34:36 +02:00
Munro Mengjue Chiang 4658732fb4 Bug 1382433 - use fixed fps instead of floating fps to avoid very low fps. r=jib
MozReview-Commit-ID: 2QUWJM2LNkK

--HG--
extra : rebase_source : 5e323539c0d600979726d552938c9f06ed5cf5e2
2017-09-27 18:50:54 +08:00
Andreas Pehrson d918302551 Bug 1319446 - DirectMediaStreamListener, you are dead to me. r=padenot
MozReview-Commit-ID: KwztE5ogSj9

--HG--
extra : rebase_source : e8e6bb3548c5697c5db901c0310ea5067a30c895
2017-09-27 12:01:46 +02:00
Alfredo.Yang 99296b3786 Bug 1388991 - add test case for subtraction underfolw in SampleToChunkIterator. r=kinetik
MozReview-Commit-ID: 8IV0RkDL8r7

--HG--
extra : rebase_source : 196d0af229c3f5181c286999f60c63da5a7ca408
2017-09-28 10:51:18 +08:00
Alfredo.Yang 6b8eff34c3 Bug 1388991 - check subtraction underflow. r=kinetik
MozReview-Commit-ID: DYsqlXyjZs

--HG--
extra : rebase_source : 557265db7fb42fea0b8b9f212c32f854e96a95c7
2017-09-28 10:19:33 +08:00
Alfredo.Yang b0d7f38b36 Bug 1395244 - add gtest for index out of bounds in rust mp4 parser. r=kinetik
MozReview-Commit-ID: HeFwZgOpMdK

--HG--
extra : rebase_source : 69a011964b7e58ac22adc31ffa99051776a67fe8
2017-09-05 15:13:02 +08:00
Dan Minor 6dfaaea25b Bug 1403204 - Code that configures telephone-event should not assume that it is always last in the codec array; r=bwc
Instead, iterate over the values.

MozReview-Commit-ID: KtPmA9fnyIU

--HG--
extra : rebase_source : d0e377be835425e13e76b99b9bab66934cfe29b6
2017-09-26 15:29:22 -04:00
Alfredo.Yang 588fc5b9e0 Bug 1389527 - add testcase for invalid sample table. r=kinetik
MozReview-Commit-ID: 5e4oQPLtcuZ

--HG--
extra : rebase_source : 1a3364037f5fe49e732983d95758a2b670667452
2017-09-25 11:16:29 +08:00
Matthew Gregan 6e690e73d3 Bug 1403048 - Update media/audioipc to b5559d28. r=kamidphish
--HG--
extra : rebase_source : aeb3f0b9a45729fa21248983d34ce956e98a9b79
2017-09-26 15:49:26 +13:00
Dan Glastonbury e0b3ce467e Bug 1399978 - Update cubeb-pulse-rs to git commit 2e22e53. r=kinetik
MozReview-Commit-ID: INksO0nbT1F

--HG--
extra : rebase_source : ea7936f95c44972478878cb54b1e2a83c4fbc4fe
2017-09-25 15:23:30 +10:00
Alfredo.Yang 155d999aa3 Bug 1401071 - move fallible memory allocation github instead of including source and other nits. r=kinetik
MozReview-Commit-ID: 40Yg8wUqZ2g

--HG--
extra : rebase_source : a2c192c06ae85be6e71172702b4bb73eb912fc7b
2017-09-25 09:14:00 +08:00
Dan Minor b73bb761aa Bug 1402348 - fix webrtc.org screen_capturer_unittest and window_capturer_unittest segfault on Linux; r=jesup
We weren't defining USE_X11 when building the tests resulting in inconsistent
versions of the headers depending upon where they were compiled.

MozReview-Commit-ID: 298yRvIjXgb

--HG--
extra : rebase_source : 7406d14db3b41b8b5f579cc572ccb283064dbe29
2017-09-22 14:33:49 -04:00
Dan Minor 099dc8de4f Bug 1382182 - Build signaling common using moz.build; r=ted,jesup
MozReview-Commit-ID: FSqL5enNAZC

--HG--
extra : rebase_source : 0430bc65e869a8215550ab67f03b81668c4ae473
2017-07-24 10:59:20 -04:00
Dan Minor 4643f4ab72 Bug 1382182 - Build peerconnection using moz.build; r=ted,jesup
MozReview-Commit-ID: IvG9Pf0PRfw

--HG--
extra : rebase_source : e5a17ddda32a0fb168f6fd84ae9c65c1cee7d020
2017-07-21 16:28:29 -04:00
Dan Minor 86aeffe744 Bug 1382182 - Build mediapipeline using moz.build; r=ted,jesup
MozReview-Commit-ID: 7yJMgrsCgzO

--HG--
extra : rebase_source : f2a076b9a944795ee18232043f082590134529fc
2017-07-21 15:20:08 -04:00
Dan Minor ae9b639bdd Bug 1382182 - Build media-conduit using moz.build; r=ted,jesup
MozReview-Commit-ID: I0mHRkY4owZ

--HG--
extra : rebase_source : 16e3844f0ccb6ae0a2a557e5b3abe4a777a48f0e
2017-07-21 12:07:07 -04:00
Dan Minor 21da3987a2 Bug 1382182 - Build sdp using moz.build; r=ted,jesup
MozReview-Commit-ID: fZRprTixrc

--HG--
extra : rebase_source : e3823847862d427f752ec581bb3f35e6809f2aec
2017-07-20 11:47:05 -04:00
Dan Minor 30d76b125c Bug 1382182 - Build jsep using moz.build; r=ted,jesup
MozReview-Commit-ID: 9UhlBZi0yO0

--HG--
extra : rebase_source : 7ad69af2dfb61ad88fc5f87f4d17a09abbf23edc
2017-07-20 11:24:08 -04:00
Sebastian Hengst c0dac760d3 merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: It9WfByQfV3
2017-09-23 11:38:06 +02:00
Nils Ohlmeier [:drno] 093afd78ca Bug 1402221: add Telemetry probe to find out rtcp-mux usage. r=bwc,francois
MozReview-Commit-ID: 1XmPbpSmAb1

--HG--
extra : rebase_source : b3ad189b8eec13ce1b75873c36008d371b10797c
2017-09-22 00:09:52 -07:00
Wes Kocher 5d514ba8e9 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 2XyrMOdIWok
2017-09-20 17:39:08 -07:00
Wes Kocher a6b8d9e91b Merge inbound to central, a=merge
MozReview-Commit-ID: JpqY5uEi1nf
2017-09-20 17:18:21 -07:00
Dan Minor 55f5ef6e16 Bug 1373843 - Add -fsanitize-coverage to cflags in nicer.gyp; r=posidron
I missed doing this in the original patch because my mozconfig defined the
CFLAGS globally to include -fsanitize-coverage.

MozReview-Commit-ID: 4QdiIgdfAm2

--HG--
extra : rebase_source : bfd1ef5097b91c23913c0349a04154f18f60eef5
2017-09-20 17:05:07 -04:00
Dan Minor 6e7bc1c221 Bug 1373843: Change assertion about message length to error in stun_codec.c; r=drno
MozReview-Commit-ID: 1oUEQk9vg1L

--HG--
extra : rebase_source : 8ca178eb1e356b06b09582e85a0e91a93648b29c
2017-09-19 15:29:22 -04:00
Michael Froman cfcc1ed74d Bug 1396419 - adding null checks to avoid intermittent crash. r=drno
MozReview-Commit-ID: 3ywGT90q1NQ

--HG--
extra : rebase_source : d759c1e430da4c7c272d835219e69fb238e8205f
2017-09-18 21:36:33 -05:00
Nils Ohlmeier [:drno] a8d005b348 Bug 1373843: Add a libfuzzer test for the stun parser; r=decoder
MozReview-Commit-ID: BWUnBIMhT5C

--HG--
extra : rebase_source : 8d8c6de040601621f5f64c8a7cf5a99486ae9879
2017-06-16 16:01:19 -07:00
Jean-Yves Avenard 53ef359a19 Bug 1389304 - Don't include samples that won't be demuxed in range calculation. r=kikuo
Invalid samples with empty content won't ever be demuxed. As such they can't participate in buffered range calculations.

MozReview-Commit-ID: 9LPhyKKMSyM

--HG--
extra : rebase_source : 229f19f08eba6e59b5585699805df9df9fd482b9
2017-09-19 09:11:26 +02:00
Munro Mengjue Chiang 979c34dc04 Bug 1389534 - Enable continuous auto focus mode. r=jib
MozReview-Commit-ID: DrTkb9CxjlA

--HG--
extra : rebase_source : c65aabcf0939a20814690a4c3349846fde0be00a
2017-09-07 18:25:45 +08:00
Alex Chronopoulos af3b468649 Bug 1400671 - Update cubeb from upstream to ac532ad. r=kinetik
MozReview-Commit-ID: Ek4onH23hPc
2017-09-18 01:56:08 +03:00
Nico Grunbaum a531d080c3 Bug 1393095 - remote audio receiver stats missing;r=dminor,jesup
MozReview-Commit-ID: 9izPPOqybcK

--HG--
extra : rebase_source : 31578d7198929267e423a1c0c4b13cd49f110629
2017-09-13 01:38:35 -07:00
Gregory Szorc 3d5f58d635 Bug 1399878 - Fix case of LOCAL_INCLUDES; r=me
This fixes a typo introduced in 305e742634e5 and that broke
moz.build processing for MacOS.
2017-09-15 14:18:32 -07:00
Ted Mielczarek 0677fcfacf bug 1399878 - Use LOCAL_INCLUDES instead of CFLAGS in some media moz.build files. r=gps
MozReview-Commit-ID: 3PUOniPnt54

--HG--
extra : rebase_source : 01accd7951a4af7018265e91040aa7005b061902
2017-09-14 06:39:27 -04:00
Dan Minor 48f0f26faf Bug 1398820 - Do not add duplicate rtp extensions; r=bwc
MozReview-Commit-ID: G6wLXW7z05d

--HG--
extra : rebase_source : e90ca378082a899a2cb7961121b6822e2ba2a72c
2017-09-14 15:55:33 -04:00
Alex Chronopoulos fce9feacea Bug 1399905 - Update cubeb from upstream to 09a90a7. r=padenot
MozReview-Commit-ID: JoZj8q2nQPb
2017-09-14 18:35:15 +03:00
Ryan VanderMeulen 277d6a438f Merge m-c to inbound. a=merge 2017-09-14 10:52:18 -04:00
Dan Minor c9a33a6e73 Bug 1393687 - Fix handling of max-fr parameter; r=jesup
MozReview-Commit-ID: C30K1Pogm5u

--HG--
extra : rebase_source : e53ed34aed0c59b1495581562901b4e7cc78e3b0
2017-09-07 16:05:52 -04:00
Alfredo.Yang 71448a61d9 Bug 1389470 - fix for zero size memory leak. r=kinetik
MozReview-Commit-ID: F1hBnukiwKN

--HG--
extra : rebase_source : 1a2c4b32d7990d0483a4a78b29a8cd0c3079c68a
2017-09-14 10:29:43 +08:00
Alfredo.Yang 43be656b03 Bug 1389470 - use fallible memory allocation to avoid OOM. r=kinetik
MozReview-Commit-ID: BvqIe685Rfs

--HG--
extra : rebase_source : b030ba607474a285c8fb50e9198f126c36a011f9
2017-09-13 14:59:45 +08:00
Dan Minor ceaff80d1d Bug 1393687 - Use VideoAdapter to handle max-fs; r=jesup
This uses the VideoAdapter to handle the max-fs constraint rather than
attempting to calculate and enforce it manually within the VideoConduit.
The resolution is taken as the small of the max-fs constraint and the
latest request from the video sink.

The old unit tests for max-fs and max-fr are removed as the size
calculation has now been delegated to the VideoAdapter and the tests do
not verify whether or not video has actually been scaled.

MozReview-Commit-ID: 18khmiNageR

--HG--
extra : rebase_source : 9d4c80ab5d426721c5c409d81130f2a586c862ad
2017-09-11 13:43:32 -04:00
Sebastian Hengst e4a2f44531 merge autoland to mozilla-central. r=merge a=merge
MozReview-Commit-ID: 9SALJlvWgoZ
2017-09-13 13:32:44 +02:00
Nils Ohlmeier [:drno] 4ba00c2a5a Bug 1396974: make tests ensure no bundle-only is present in inactive m-swctions. r=bwc
MozReview-Commit-ID: 5pnTygvwTSy

--HG--
extra : rebase_source : 4856491656e8503412a42cafbb8f9af2814a00f3
2017-09-08 13:05:13 -07:00
Nils Ohlmeier [:drno] 7b33b594d5 Bug 1396974: stop bundeling inactive m-sections. r=bwc
MozReview-Commit-ID: AXBtipHlW0Y

--HG--
extra : rebase_source : c1cf7cd11896a757472b47ccf8810cfca7c413d1
2017-09-08 12:26:19 -07:00
Dan Glastonbury 660a0a0bf8 Bug 1399009 - Update cubeb-pulse-rs to a386d91... r=kinetik
MozReview-Commit-ID: BnJpMCuDPOf

--HG--
extra : rebase_source : 37c652b29cc4732153ab5b8a45c0b02837026282
2017-09-12 15:31:18 +10:00
Randell Jesup 62c5b9fbfe Bug 1396107: switch to using the same audio input method upstream webrtc.org does r=dminor,padenot 2017-09-12 10:14:41 -04:00
Chris Manchester fab07bc443 Bug 1386876 - Replace all uses of NO_VISIBILITY_FLAGS with a template and remove NO_VISIBILITY_FLAGS. r=glandium
MozReview-Commit-ID: 194U1WMCAM0

--HG--
extra : rebase_source : 365b68b0a1772d238ae9b84966e53dcd1197fd85
2017-05-01 18:12:35 -07:00
Chris Manchester c0a229d4c3 Bug 1386876 - Replace all uses of DISABLE_STL_WRAPPING with a template, remove DISABLE_STL_WRAPPING. r=glandium
MozReview-Commit-ID: FMEtb5PY7iP

--HG--
extra : rebase_source : 3cdee7528846462c758e623d6bcd2e6e17dbabff
2017-09-11 11:33:26 -07:00
James Cheng 7d08d66397 Bug 1398072 - Fix an obvious leak in Cleakey CDM. r=cpearce
MozReview-Commit-ID: Ee9Me0MKpPU

--HG--
extra : rebase_source : 7a779780865ff00eb6154b3b601eed04541b7ac8
2017-09-08 17:34:48 +08:00
Tom Ritter 66e04df56d Bug 1395418 Revert a previous patch that disabled std::thread on MinGW because we didn't have it. Now we do. r=cpearce
MozReview-Commit-ID: 8ah0Unum1f2

--HG--
extra : rebase_source : 7054f778c0b8a2e4a831e379086243433cd219b8
2017-08-30 20:31:01 -05:00
Sebastian Hengst 8eb249afcc merge mozilla-inbound to mozilla-central. r=merge a=merge
MozReview-Commit-ID: JSRVc5yW6Kx
2017-09-07 12:39:12 +02:00
Wes Kocher a14d71906d Merge m-c to inbound, a=merge
MozReview-Commit-ID: BJ4WkYrJ9g6
2017-09-06 17:24:48 -07:00
Henri Sivonen 1961f9269f Bug 860727 clean-up - Remove mbslen.c/h from the tree. r=bwc
MozReview-Commit-ID: 2sRjpNYX5eA

--HG--
extra : rebase_source : 23b0bf6a5ce470daa7ec5ee951d0cccf43402426
2017-09-06 10:24:54 +03:00
Henri Sivonen 2aa5a465d3 Bug 860727 - Implement UTF-8 code unit counting without setlocale(). r=bwc
Counting the code points in a UTF-8 string is simple enough that that it is
not worthwhile to use the locale-dependent parts of the C standard library
for the task.

MozReview-Commit-ID: 6Tzd5NHub3B

--HG--
extra : rebase_source : d452896317d354ee85c817533cba3116adf5277e
2017-09-05 09:12:02 +03:00
Nils Ohlmeier [:drno] b81119f1e6 Bug 1264479: don't crash on disappearing data channels. r=bwc
MozReview-Commit-ID: 3DmM7teByR8

--HG--
extra : rebase_source : 238054d17ff624eb203f8352493cd2ce99e11402
2017-08-31 14:30:50 -07:00
Jean-Yves Avenard 64a4b87c4c Bug 1394591 - P6. Simplify some internal codec mimetype. r=gerald
The codec mimetype is now shown in the media devtools. May as well make it readable.

MozReview-Commit-ID: 6rccDiTR24m

--HG--
extra : rebase_source : 7b8d1da8f05d0c46d5fd57b5e604ec3aed36a5f2
2017-09-01 23:04:39 +02:00
Sebastian Hengst e9bfcd79f9 Backed out changeset de401d17868d (bug 1394591) 2017-09-04 00:06:51 +02:00
Jean-Yves Avenard 9b2818843f Bug 1394591 - P6. Simplify some internal codec mimetype. r=gerald
The codec mimetype is now shown in the media devtools. May as well make it readable.

MozReview-Commit-ID: 6rccDiTR24m

--HG--
extra : rebase_source : 7b8d1da8f05d0c46d5fd57b5e604ec3aed36a5f2
2017-09-01 23:04:39 +02:00
Nico Grunbaum f9027b2f13 Bug 1381627 - EverySecondTelemetryCallback target r=billm,jib
MozReview-Commit-ID: 2noZLkM4ZjO

--HG--
extra : rebase_source : a5e022b083f7341c26e71314578ea9f0e9023818
2017-08-17 17:39:39 -07:00
Wes Kocher 8b84853ed6 Merge m-c to autoland, a=merge
MozReview-Commit-ID: GcHZLNPPNnI
2017-09-01 16:34:14 -07:00
Dan Minor ed140d9eeb Bug 1395289 - Convert from points to pixels when invalidating rect for screensharing when building on OS X older than 10.8; r=jesup
When we build for versions of OS X below 10.8 it is still necessary to
convert from points to pixels when invalidating rectangles as we use the
CGRegisterScreenRefreshCallback and CGRegisterMoveCallback interfaces.

--HG--
extra : rebase_source : cc3a405c1faaf010922b9acbe0edc21da15bb9ac
2017-08-31 13:29:34 -04:00
Paul Adenot 133d277e4d Bug 1395393 - Fix bustage on a CLOSED TREE.
MozReview-Commit-ID: BI4fIMikA0J
2017-09-01 18:09:48 +02:00
Paul Adenot 54e3972626 Bug 1395393 - Update libcubeb to 2e5814de. r=achronop
MozReview-Commit-ID: JWDv93mjAAE

--HG--
extra : rebase_source : 170547b55d8b04838523a255502c58991da8ffdb
extra : amend_source : c7f5e99b69e27c40e5fa6ed9054a57dbdf1c2f1c
2017-09-01 17:39:06 +02:00
Mike Hommey a03ea28fe8 Bug 1395769 - Don't define MOZ_JEMALLOC_IMPL when building webrtc-gtest. r=froydnj
This define is only meant to be set when building mozjemalloc itself.

--HG--
extra : rebase_source : 5660b691855c3b0be55375ad8d9525ea2288bb69
2017-08-31 16:16:23 +09:00
Tom Ritter 568bd0f7fc Bug 1349912 Do not use win32 local includes for libstagefright on MinGW build r=froydnj
This duplicates all the win32 includes except pthread.h into a new directory
for MinGW. MinGW needs all the same dummy includes _except_ it needs its
own pthread.h for winpthreads.

MozReview-Commit-ID: AlIvHhFoSIS

--HG--
extra : rebase_source : aba50e79b0be3bc7306bd32b4010076a8ca1184b
2017-08-30 20:39:51 -05:00
Nils Ohlmeier [:drno] dfbfc1ccea Bug 1384801 - Improve the sdp base64 parser. r=bwc
MozReview-Commit-ID: 30e64v5vxo8
2017-09-01 15:58:01 -07:00