I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.
I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have. Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
To avoid needless re-renders due to props changing object identity.
Differential Revision: https://phabricator.services.mozilla.com/D2641
--HG--
extra : rebase_source : 8635d8b0365c36fff73ec6eb5d934578185d70c0
Otherwise we will get errors like:
console.error: "Warning: React does not recognize the `menuId` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `menuid` instead. If you accidentally passed it from a parent component, remove it from the DOM element.\n in button (created by MenuButton)\n in MenuButton (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in ToolboxToolbar (created by ToolboxController)\n in ToolboxController"
console.error: "Warning: React does not recognize the `menuPosition` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `menuposition` instead. If you accidentally passed it from a parent component, remove it from the DOM element.\n in button (created by MenuButton)\n in MenuButton (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in ToolboxToolbar (created by ToolboxController)\n in ToolboxController"
console.error: "Warning: React does not recognize the `menuOffset` prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase `menuoffset` instead. If you accidentally passed it from a parent component, remove it from the DOM element.\n in button (created by MenuButton)\n in MenuButton (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in div (created by ToolboxToolbar)\n in ToolboxToolbar (created by ToolboxController)\n in ToolboxController"
It's also not what we intend to do.
Differential Revision: https://phabricator.services.mozilla.com/D2640
--HG--
extra : rebase_source : 00084e91252f40f464bd7694a908180b02966855
We only have this so that ::-moz-placeholder keeps serializing as
::-moz-placeholder, but I don't think anybody really cares.
Edge aliases ::-webkit-input-placeholder to ::-ms-input-placeholder at parse
time as well, as can be seen in:
```
let s = document.createElement('style');
s.innerHTML = `input::-webkit-input-placeholder { color: red };`;
document.body.appendChild(s);
document.body.innerHTML = s.sheet.cssRules[0].cssText;
```
And I think this is more consistent with what we do for CSS properties that are
aliases.
Differential Revision: https://phabricator.services.mozilla.com/D2595
MozReview-Commit-ID: 3ImDWamJhxh
This was causing an empty message to appear in the
browser console when clicking the clear button.
This specific call was introduced 5 years ago without
much explanation, and since the error console is now
gone, I think it's safe to remove the call.
A test is added to make sure we do not print any extra
messages when clearing the browser console.
Differential Revision: https://phabricator.services.mozilla.com/D2551
--HG--
extra : moz-landing-system : lando
Bogdan Tara
Csoregi Natalia
Nicolas Chevobbe
Boris Zbarsky
Brian Birtles
Narcis Beleuzu
Razvan Caliman
Jan de Mooij
Brian Hackett
Jason Laster
Julian Descottes
Alexandre Poirot
Cosmin Sabou
sole
Noemi Erli
Tiberius Oros
dvarga
Emilio Cobos Álvarez
Nicholas Nethercote
Dorel Luca
Dave Townsend
Brad Werth
Panos Astithas