6ab86028d3
Bug 1475515 - Remove member initialization for union Extra::mMessage. r=bz
...
MozReview-Commit-ID: GgJyXg5KxQm
--HG--
extra : rebase_source : 4a0e0137c1545b96aab9c436c42274db1c393a0a
2018-07-13 14:39:12 +03:00
88cc63910d
Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
...
--HG--
extra : rebase_source : 249fc26e50bded4e94f5effa4308af0f1e54b908
2018-06-16 17:21:46 +03:00
818897b5a1
Bug 1471303 Fix CopyableErrorResult::operator==() to actually compile with ipdl types. r=bz
2018-06-27 06:51:24 -07:00
70f3630002
Bug 1343620 - Use JS_HAZ_ROOTED everywhere instead of programmatic annotations, r=pbone
...
--HG--
extra : topic : haz.rooted
extra : rebase_source : 69a2c810ccfecdf7c59fe030a83aad9cb6d5f8ad
2018-06-06 16:28:38 -07:00
1e9c395548
Bug 1466168: Remove mozilla::Forward in favor of std::forward. r=froydnj
...
Same approach as the other bug, mostly replacing automatically by removing
'using mozilla::Forward;' and then:
s/mozilla::Forward/std::forward/
s/Forward</std::forward</
The only file that required manual fixup was TestTreeTraversal.cpp, which had
a class called TestNodeForward with template parameters :)
MozReview-Commit-ID: A88qFG5AccP
2018-06-02 09:33:26 +02:00
fffb25b74f
Bug 1465585: Switch from mozilla::Move to std::move. r=froydnj
...
This was done automatically replacing:
s/mozilla::Move/std::move/
s/ Move(/ std::move(/
s/(Move(/(std::move(/
Removing the 'using mozilla::Move;' lines.
And then with a few manual fixups, see the bug for the split series..
MozReview-Commit-ID: Jxze3adipUh
2018-06-01 10:45:27 +02:00
d4090dc614
Bug 1357463 Add CopyableErrorResult to opt in to auto-cloning ErrorResult values. r=bz
2018-04-26 13:50:56 -07:00
04d21ccac0
Bug 1451248. r=jorendorff, r=bz
...
--HG--
extra : rebase_source : e26439a5954162bdaf332fbd63d623a3810e19e0
2018-04-25 19:40:09 -07:00
0819f35e51
Backed out 4 changesets (bug 525063) on request from Andi. a=backout
...
Backed out changeset 516c4fb1e4b8 (bug 525063)
Backed out changeset 6ff8aaef2866 (bug 525063)
Backed out changeset bf13e4103150 (bug 525063)
Backed out changeset d7d2f08e051c (bug 525063)
2018-04-13 16:01:28 +03:00
a3a77c0312
Bug 525063 - Initialize uninitialized class attributes in m-c. r=ehsan
2018-04-10 21:11:02 +02:00
17509bc9da
Bug 1449019. Actually propagate out exceptions from the innerHTML getter. r=smaug
...
I moved the IgnoreErrors decl so it would come after the OOMReporter decl and I
could add the new conversion operator.
MozReview-Commit-ID: B1S6DXmZfvE
2018-03-26 16:41:43 -04:00
627eb6ae9a
Bug 1411415 - r=bz r=fitzgen
2018-03-05 19:27:02 -05:00
14975c9574
Bug 1434689 - Part 4: Annotate IgnoreErrors as MOZ_TEMPORARY_CLASS. r=bz
...
IgnoreErrors is intended to only be used as a temporary class, this adds an
explicit annotation.
--HG--
extra : rebase_source : 4142429081d3f70097594d200950b74d100ab67b
2018-02-02 13:21:51 -08:00
f7f6285330
Bug 1434686 part 1. Introduce a mozilla::IgnoreErrors which can be used as a temporary to pass to an ErrorResult& arg when the error should be ignored. r=mystor
...
Once bug 1434689 is fixed, we can mark this thing as being required to be a temporary.
MozReview-Commit-ID: 7VX0XSYVOc4
2018-02-01 14:21:14 -05:00
07c97a5afe
Bug 1423773 - Part 1: Remove usage of nsStringGlue.h. r=glandium
...
This removes an unnecessary level of indirection by replacing all
nsStringGlue.h instances with just nsString.h.
--HG--
extra : rebase_source : 340989240af4018f3ebfd92826ae11b0cb46d019
2017-12-06 16:52:51 -08:00
15f2be4d17
Bug 1411034 - Remove the const to fix the -Wignored-qualifiers warning r=froydnj
...
MozReview-Commit-ID: 8BIWJpv9Odz
--HG--
extra : rebase_source : cc7222f056c9eeefd57ecd77f776aa35f080b2ff
2017-10-23 22:40:30 +02:00
fe0bcc3a40
Bug 1338272 - Require that the return value of MaybeSetPendingException is used. r=bz
...
Most of the time, the return value of this method should be checked,
because behavior should depend on whether or not an exception is
thrown. However, if it is called immediately after a throw it doesn't
need to be checked because it will always return true. bz said there
is no public API that lets you assume there is an exception because it
would be "too easy to misuse".
MozReview-Commit-ID: CqyicBbcNjW
--HG--
extra : rebase_source : a5b74ba88a927a90d491ceb8f0b750a67f62b0f4
2017-02-14 16:17:02 -08:00
46ade67ada
Bug 1331434 - Part 2: Add MOZ_MAY_CALL_AFTER_MUST_RETURN and MOZ_MUST_RETURN_FROM_CALLER annotations, r=ehsan
...
MozReview-Commit-ID: 1o2egvdhkqT
2017-03-07 19:06:48 -05:00
41700419ad
Bug 1339540 part 3. Use nsresult values in the ErrorResult error module in place of NS_ERROR_TYPE_ERR/NS_ERROR_RANGE_ERR in ErrorResult code. r=smaug
2017-02-15 00:02:36 -05:00
2816ec4748
Bug 1339540 part 2. Move the three ErrorResult-internal NS_ERROR_DOM_* values over to the ErrorResult error module. r=smaug
2017-02-15 00:02:35 -05:00
15fc53a58f
Bug 1328861. Be a little less trusting about our error codes in ErrorResult. r=smaug
2017-02-10 23:06:34 -05:00
fbf9e7a22b
Bug 1330536 part 3. Add a subclass of FastErrorResult that can be used only to throw OOM. r=smaug
2017-01-17 23:52:13 -05:00
9251e2a1da
Bug 1285649 - Replace an ellipsis function, whose last non-ellipsis argument was subject to integer promotions, with a variadic template function so as not to invoke C++ undefined behavior, because that would be Bad. r=froydnj
2016-07-20 15:06:48 -07:00
d6391c60ea
Backed out changeset 1a2627378a0d, didn't tag the reviewer correctly.
2016-07-26 11:12:21 -07:00
b0edcf1fb1
Bug 1285649 - Replace an ellipsis function, whose last non-ellipsis argument was subject to integer promotions, with a variadic template function so as not to invoke C++ undefined behavior, because that would be Bad. NOT REVIEWED YET
...
--HG--
extra : rebase_source : 4b2fe5fbf7baaf599026f916e8969862c053a64c
2016-07-20 15:06:48 -07:00
c100c511bf
Bug 933378 part 4. Change the ErrorResult destructor to suppress the exception, after asserting that it's already suppressed. r=bkelly
2016-07-15 22:35:13 -04:00
de3dccf7da
Bug 933378 part 2. Introduce a FastErrorResult class that bindings can use internally instead of ErrorResult. r=bkelly
2016-07-15 22:35:13 -04:00
e3b8194f3f
Bug 933378 part 1. Introduce a TErrorResult class that will serve as a base class for various ErrorResult-like subclasses. No actual behavior changes so far. r=bkelly
2016-07-15 22:35:13 -04:00
12929ea07e
Bug 1224664 - Assert if an ErrorResult is accessed on a thread different than the one it's created on, r=khuey
2016-07-15 22:35:13 -04:00
255d05f484
Backed out changeset 03362dd7616d (bug 1224664)
2016-07-16 10:03:12 +02:00
2abd5d3f18
Backed out changeset dd2d38b7c16b (bug 933378)
2016-07-16 10:03:11 +02:00
b2d35d7ca3
Backed out changeset 1c2bd3bdebd6 (bug 933378)
2016-07-16 10:03:10 +02:00
dfb4a51bab
Backed out changeset ed38780a242c (bug 933378)
2016-07-16 10:03:08 +02:00
10cd9bcc48
Backed out changeset 7fef388bc6cf (bug 1224664)
2016-07-16 10:03:07 +02:00
8f9cd3e3f5
Bug 1224664 followup: NS_ASSERT_OWNINGTHREAD needs to be #ifdef DEBUG if our NS_DECL_OWNINGTHREAD is.
2016-07-15 23:40:19 -04:00
a522fa79b7
Bug 933378 part 4. Change the ErrorResult destructor to suppress the exception, after asserting that it's already suppressed. r=bkelly
2016-07-15 22:35:13 -04:00
38d0ae9c0c
Bug 933378 part 2. Introduce a FastErrorResult class that bindings can use internally instead of ErrorResult. r=bkelly
2016-07-15 22:35:13 -04:00
4e44fce24b
Bug 933378 part 1. Introduce a TErrorResult class that will serve as a base class for various ErrorResult-like subclasses. No actual behavior changes so far. r=bkelly
2016-07-15 22:35:13 -04:00
c5ce5bdb84
Bug 1224664 - Assert if an ErrorResult is accessed on a thread different than the one it's created on, r=khuey
2016-07-15 22:35:13 -04:00
291c555f34
Bug 1262671 - void** -> PickleIterator (r=froydnj)
2016-05-27 09:57:38 -07:00
517605b022
Bug 1246804 - Switch to using in-source annotations. Use C++ inheritance information when describing GC types. Add a test suite., r=terrence
...
MozReview-Commit-ID: HCcG2k8Wyb9
--HG--
extra : rebase_source : 732ef6ecc52f0e528d38b8c42e442919eba9b5ae
extra : source : 901b1c651c982ccbf42604231c723d168e1cde69
2015-09-29 13:39:33 -07:00
57bca06b15
Backed out changeset 901b1c651c98 (bug 1246804)
...
--HG--
extra : rebase_source : d80a34f467275bf74672b87fd09a254b39ee20a1
2016-03-14 21:58:31 -07:00
2dada4b1a0
Bug 1246804 - Switch to using in-source annotations. Use C++ inheritance information when describing GC types. Add a test suite., r=terrence
...
MozReview-Commit-ID: HCcG2k8Wyb9
--HG--
extra : rebase_source : 4b048fdcb150662c82e1b623e455551cc7281251
2015-09-29 13:39:33 -07:00
9eea75a6f5
Bug 1252268: If the slow script dialog aborts an interval timer callback, don't schedule it again. r=bz
2016-03-10 01:50:56 -08:00
38ed0f626b
Bug 1249652 part 1. Add a method on ErrorResult to steal an exception, if any, from a JSContext. r=khuey
2016-02-24 10:38:31 -05:00
73208ce2f3
Bug 1228707. Add a away to call Web IDL callbacks while ignoring any errors from them, and use it in a few places. r=smaug
2015-11-30 22:04:09 -05:00
71b052b436
Bug 1224007 part 6. Change MaybeSetPendingException to set the ErrorResult state to "not failed", just like SuppressException and StealNSResult already do, and assert in the destructor that the ErrorResult is not Failed().
...
This is not quite as strong as being able to assert that all codepaths that might
lead to failure call one of the above methods, but being able to assert that
would involve a lot of extra noise at callsites. Or at least changing the
signature of StealNSResult to use an outparam and return a boolean indicating
whether the ErrorResult was failure or not, or something, so StealNSResult
can be usefully called on successful ErrorResults too.
2015-11-20 16:29:41 -05:00
c3bc1cdc40
Bug 1224007 part 5. Get rid of ErrorResult::StealJSException. r=peterv
2015-11-20 16:29:41 -05:00
fb747879e0
Bug 1224007 part 3. Push down WouldReportJSException into MaybeSetPendingException, since anyone calling the latter will propagate the JS exception as needed. r=peterv
2015-11-20 16:29:41 -05:00
8ab5390043
Bug 1224007 part 2. Make the various ErrorResult::Report* methods private, so consumers all go through MaybeSetPendingException and rename them to more clearly indicate what they're actually doing. r=peterv
2015-11-20 16:29:41 -05:00
Andi-Bogdan Postelnicu
Ben Kelly
Steve Fink
Emilio Cobos Álvarez
Jeff Walden
Sebastian Hengst
Tristan Bourvon
Boris Zbarsky
Kannan Vijayan
Eric Rahm
Sylvestre Ledru
Andrew McCreight
Michael Layzell
Emilio Cobos Álvarez
Carsten "Tomcat" Book
Bill McCloskey
Kyle Huey