This makes the correlation between the method names and what they do
more clear, and adds an Entry variant for the entry global.
Depends on D166119
Differential Revision: https://phabricator.services.mozilla.com/D166207
This fixes the main issue, and makes the test pass by avoiding issues with the
window sticking around after test completion, messing up future runs.
Differential Revision: https://phabricator.services.mozilla.com/D166119
lit calls `element.setAttribute("style", "<our styles>")` on first render of an
element so that it will have the style property set in the markup if it is being
server-side rendered. We don't need that, and it causes CSP errors in
about:logins so this patches out the functionality.
https://github.com/lit/rfcs/issues/13
Differential Revision: https://phabricator.services.mozilla.com/D165240
If the printer info returns without a name, or otherwise errors when checking the settings, it will prevent the print dialog from opening and switching to a different printer.
This wraps the intial refreshSettings call and tries to fallback to another printer if the last used one fails.
Differential Revision: https://phabricator.services.mozilla.com/D162437
Updates to using the classes defined in CSS instead of Ids when generating the HTML content for the simplified print mode.
Sets padding to 0 for the body to allow customizing the margins in the print dialog.
Differential Revision: https://phabricator.services.mozilla.com/D162914
These MathML table elements may not have a table display style, in which case
they shouldn't be HTML table accessibles. This revision changes the logic of
MathMLMarkupMap such that mtable, mtr elements create generic ARIA accessibles
if the display style for the element is something other than 'table'. This
revision also adds a test to verify that the roles are still reported correctly,
even with this change.
Differential Revision: https://phabricator.services.mozilla.com/D165980
`QuickSuggestTestUtils.ensureQuickSuggestInit()` was written before Merino, so
it assumes the suggestion objects passed in are remote settings suggestions.
This revision modifies it so Merino and remote settings suggestions can both be
passed in. That makes it a little nicer for tests that need to test Merino
suggestions in particular, like navigational suggestions, dynamic Wikipedia,
etc.
Another motivation for this change is that it makes it clear which type of
suggestion is being passed to `ensureQuickSuggestInit()`. Unfortunately Merino
suggestion objects are slightly different from remote settings result objects
(`block_id` vs. `id` for example), which are both different from UrlbarResult
objects, and it can be confusing when reading tests. Since "result" is the name
of remote settings objects used internally in the remote settings client, I've
used that term here, and I've updated all callers to use it instead of
"suggestion".
This also makes `MerinoTestUtils` and `QuickSuggestTestUtils` singletons.
Otherwise the new `MerinoTestUtils` instance used inside `QuickSuggestTestUtils`
isn't the same as the one used in the test that calls into
`QuickSuggestTestUtils`, which is very confusing. This made me realize it's a
good idea for these test utils objects to be singletons.
Finally I removed `is_top_pick` handling from the remote settings client and
remote settings suggestions, since the related test is now using Merino. I also
removed `_test_is_best_match` since only one test was using it and it's not
necessary.
Depends on D166019
Differential Revision: https://phabricator.services.mozilla.com/D166050
This stops trying to send custom engagement pings for navigational
suggestions. That fixes the JS error that's due to the fact that these
suggestions don't have an advertiser. The purpose of these pings is to report
aggregate engagements to partners, and that's not applicable to navigational
suggestions, so not sending pings for these is OK.
I added browser_telemetry_navigationalSuggestions.js to ensure we're not sending
pings. This test will probably need to be substantially modified when we
implement all the required telemetry for navigational suggestions. That's
tracked in [this Jira ticket](https://mozilla-hub.atlassian.net/browse/SNT-337) and documented in the spec.
Until we implement that new telemetry, navigational suggestions are treated as
non-sponsored suggestions w/r/t telemetry, so I copied this file from
browser_telemetry_nonsponsored.js.
Depends on D164615
Differential Revision: https://phabricator.services.mozilla.com/D166019
Before this patch, this test was using Ahem text with a 25px font-size and a
vertical writing mode. The vertical writing-mode causes the text to be
baseline-aligned using a *central* baseline, which ends up being at a
half-pixel position, since our font-size is odd. Specifically: the central
baseline is 25px/2 = 12.5px inwards from the edge of the glyph.
The UA may choose to round this fractional central baseline to a whole pixel
value when sizing/placing content, which in turn casues this test to fail with
content being 1px away from where the test expects it to be.
This patch addresses this issue by making the test use an even number as the
font-size (30px), which produces a nice whole-number pixel value for the
central basleine. This avoids creating a depending on the UA's choice of
rounding behavior.
This makes the test pass in Firefox, and I believe it continues to pass in
other browsers where it was already passing.
Differential Revision: https://phabricator.services.mozilla.com/D166232
* Use enumerate(...) instead of manual indexing
* It's safe to modify a list we're iterating on as long as we break out
of the iteration right after the modification.
Differential Revision: https://phabricator.services.mozilla.com/D165053
Basic loop invariant code motion. The impact on execution time is not
totally negligible due to the number of tests involved.
Differential Revision: https://phabricator.services.mozilla.com/D165052
This module defines a single, efficient function to deepcopy a task. It
is faster than deepcopy because it doesn't need to track cycles and
duplicate references that don't make sense for tree (and not graph)
structures.
I measure a speedup > 10% on mach taskgraph tasks --fast >/dev/null.
Differential Revision: https://phabricator.services.mozilla.com/D164789
Calling _mouseleave and _mouseenter from _setPositionalAttributes used
to be needed to update the beforehovered and afterhovered attributes,
as the tabs these attributes were set on might have changed.
However, bug 1808661 removed these attributes, so mouseenter/mouseleave
events should be sufficient for updating _hoveredTab itself.
_setPositionalAttributes is a hot code-path, so avoiding the expensive
querySelector("tab:hover") will improve performance when having lots of
tabs.
Depends on D166094
Differential Revision: https://phabricator.services.mozilla.com/D166225
- Images with a data url source should be treated as same-origin requests,
meaning that the image-orientation should be respected.
- Add web platform test for a image with a data url source and
image-orientation: none.
- Fix the blob url test for image-orientation: none.
Differential Revision: https://phabricator.services.mozilla.com/D164237
This patch adds the speedometer 3 benchmark test to raptor enables it for CI. In CI, it'll start by running on Linux, and MacOSX on Firefox, Chrome, and Chromium. The patch also adds a new method for parsing benchmark tests that is more generic and works in conjunction with the `custom_data` option.
Differential Revision: https://phabricator.services.mozilla.com/D165988
They have been disabled since bug 1688695. There's a variety of
table-caption bugs that would be easier to fix if we didn't have to
account for side-captions.
Differential Revision: https://phabricator.services.mozilla.com/D165690
Nika Layzell
Mark Striemer
Peter Van der Beken
Niklas Baumgardner
Marian-Vasile Laza
Emilio Cobos Álvarez
Dana Keeler
Karl Tomlinson
Fred Chasen
Erich Gubler
Nathan LaPre
Alex Jakobi
Narcis Beleuzu
Drew Willcoxon
Randell Jesup
Daniel Holbert
Eitan Isaacson
Jeff Muizelaar
Mozilla Releng Treescript
serge-sans-paille
Oriol Brufau
Edgar Chen
Michael Froman
Dan Robertson
Greg Mierzwinski
alwu
Ben Hearsum
Kelly Cochrane
Bobby Holley