We're trying to store a string in a file open in binary mode which doesn't work :)
I'm guessing this was allowed in Python2 or some older 3 version.
Differential Revision: https://phabricator.services.mozilla.com/D104751
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.
5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.
To produce this patch I did all of the following:
1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.
2. Run ./mach lint --linter black --fix
3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.
4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).
# ignore-this-changeset
Differential Revision: https://phabricator.services.mozilla.com/D94045
* We add a new command line option, `test-filter-file`, which allows the user
to specify a line-delimited list of tests to run;
* When there multiple `test_filters` specified, we accumulate them into a
temporary test filter file in the line-delimited format;
* We push that file to the device and specify it to `am instrument`;
* A single `test_filter` is still passed directly on the command line.
Differential Revision: https://phabricator.services.mozilla.com/D76873
This commit:
- removes sendRpcMessage, which was unused;
- removes the CPOW argument to sendAsyncMessage, broadcastAsyncMessage, and
sendSyncMessage;
- removes the aIsSync argument used internally to distinguish sendRpcMessage
and sendSyncMessage;
- removes CPOW tests;
- updates the few remaining callsites that use more than 2 arguments in
sendAsyncMessage for the removal of the cpows argument.
Differential Revision: https://phabricator.services.mozilla.com/D71514
Add a --setpref option to geckoview-junit with the same meaning and
help description as used in mochitest.
Differential Revision: https://phabricator.services.mozilla.com/D65619
--HG--
extra : moz-landing-system : lando
Stop using mozcrash.check_for_java_exception(), which scans logcat for uncaught
exceptions. Instead, check for java_stack in the extra dump information during
normal crash reporting; if java_stack is present, display the java exception and
stack instead of dumping a full native crash report.
Differential Revision: https://phabricator.services.mozilla.com/D61836
--HG--
extra : moz-landing-system : lando
Historically, mochitest and geckoview-junit tests have used the same profile.
This patch splits out a separate profile type for geckoview-junit, with exactly
the same content for now; the geckoview team can follow-up with whatever
profile changes are required for junit.
Differential Revision: https://phabricator.services.mozilla.com/D59775
--HG--
extra : moz-landing-system : lando
This commit does two things:
- It exposes the error that caused the test to fail in our logs, so it would
appear like so:
```
TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.ExtensionActionTest.setIconSvg[#pageAction] | java.lang.AssertionError: We shouldn't get here
```
- It catches exceptions that are raised before any test code is run and outputs
a different message (since those failures do not depend on the test at all),
like so:
```
ERROR runjunit.py | The previous test failed because of an error in the test harness | org.mozilla.geckoview.test.rule.TestHarnessException: java.lang.RuntimeException: We shouldn't get here
```
This will hopefully help with spurious intermittents and understand when a
failure changes.
Differential Revision: https://phabricator.services.mozilla.com/D58022
--HG--
extra : moz-landing-system : lando
As in bug 1596967, I found that, on the emulator, the check for directory existence
infrequently indicates that a recently created directory does not exist. The following
push() will then adjust its destination directory and push to the wrong location;
without a properly installed profile, geckoview crashes. Let's simplify this sequence
by not creating the directory beforehand and letting the push() create it. The profile
directory is a direct child of the test directory -- no need to create parents either.
Differential Revision: https://phabricator.services.mozilla.com/D56789
--HG--
extra : moz-landing-system : lando
Whereas:
- desktop tests don't make this check;
- the check for directory existence has been troublesome and almost never useful;
- bug classification of this condition has been troublesome;
- if a startup crash actually did occur before crashreporter init, there would still be an indication in logcat and possibly a tombstone, and the "No test summary found" check would definitely be triggered;
Let's stop checking for minidumps directory creation.
Differential Revision: https://phabricator.services.mozilla.com/D54755
--HG--
extra : moz-landing-system : lando
Added a loop for repeating the requested test(s).
With --run-until-failure, loop until a test fails.
With --repeat=N, repeat N times. eg, --repeat=1 implies 2 runs total (same as mochitest).
(Incidentally moved code for --enable-webrender since it was not in the appropriate section.)
Differential Revision: https://phabricator.services.mozilla.com/D50299
--HG--
extra : moz-landing-system : lando
Agi Sferro
Makoto Kato
Bob Clary
Bryce Seager van Dyk
Aaron Klotz
Razvan Maries
Ricky Stewart
Bogdan Tara
Dorel Luca
Csoregi Natalia
Geoff Brown
Narcis Beleuzu
Mihai Alexandru Michis
Coroiu Cristina
Gijs Kruitbosch
James Willcox
Edwin Gao
Gurzau Raul
Kartikaya Gupta