Each line of the edit and resend panel should no longer grow when resizing the panel
But when editing, we fallback to multiline
Differential Revision: https://phabricator.services.mozilla.com/D152006
This allows to pull out target management code out from toolbox back to TargetCommand.
And then allows to more easily share this store in the context of the browser console,
where there is no toolbox.
This is also an interesting example on how commands may populate redux store directly
so that we avoid having each panel translate commands's event into actions.
An alternative here, would be to introduce some generic layer between commands and redux.
Which would be the glue between a command and populating a store.
Differential Revision: https://phabricator.services.mozilla.com/D151493
We directly pass the editor stylesheet in the `location` parameter that is passed
to `jumpToLocation`.
`jumpToLocation` wasn't covered in any test, so we modify `browser_styleeditor_media_sidebar.js`
to add coverage for it.
This is also testing Bug 1779180 which is in the same stack.
Differential Revision: https://phabricator.services.mozilla.com/D151597
For <style> elements, `getRelativeRuleLine` gives us the position of the rule
inside a stylesheet, when `getRuleLine` gives the position of the rule relatively
to the whole HTML source.
The former is more accurate for us when we want to display such line number in
DevTools UI (for example in the StyleEditor media query sidebar).
Test will be added in next patch of this queue.
Differential Revision: https://phabricator.services.mozilla.com/D151596
Enable clearing of network resources on all layers(frontend, resource layer, server) when the
user click the clear button.
Differential Revision: https://phabricator.services.mozilla.com/D148694
We directly pass the editor stylesheet in the `location` parameter that is passed
to `jumpToLocation`.
`jumpToLocation` wasn't covered in any test, so we modify `browser_styleeditor_media_sidebar.js`
to add coverage for it.
This is also testing Bug 1779180 which is in the same stack.
Differential Revision: https://phabricator.services.mozilla.com/D151597
For <style> elements, `getRelativeRuleLine` gives us the position of the rule
inside a stylesheet, when `getRuleLine` gives the position of the rule relatively
to the whole HTML source.
The former is more accurate for us when we want to display such line number in
DevTools UI (for example in the StyleEditor media query sidebar).
Test will be added in next patch of this queue.
Differential Revision: https://phabricator.services.mozilla.com/D151596
There are some uses without `JS::` namespace in `devtools/`. The autofix adds `JS::` everywhere and this patch intentionally keeps that for consistency, given that most of the code uses `JS::`.
Differential Revision: https://phabricator.services.mozilla.com/D151792
This patch introduces animation-composition longhand but we don't
accept it in @keyframe rule for now. I will support this for @keyframe
in the patch series.
Besides, the shorthand of animation doesn't include animation-composition.
The spec issue is: https://github.com/w3c/csswg-drafts/issues/6946.
We could fix the shorthand once this spec issue gets updated.
Differential Revision: https://phabricator.services.mozilla.com/D150299
We are currently duplicated source's framework in symbols and tabs reducers.
This is uncessary and confusing. And this possibly lead to more state/component updates.
This is mostly used to computed the source icon.
I extented test coverage to better cover the behavior of SourceIcon,
while simplifying a few things around this component by unifying the various places
where we compute the final icon, so that now it is only done by getSourceClassnames
and modifier.
Differential Revision: https://phabricator.services.mozilla.com/D151358
While I'm around QuickOpen modal, I also cleanup a few things around formatSources
and avoid computing more formatting than what the modal will display.
Differential Revision: https://phabricator.services.mozilla.com/D151285
This allows to make the reducer Source object fully immutable.
`isBlackBoxed` was the last mutable attribute of it.
Doing this help pass along source object without having to care if it will ever update.
This should also help reduce the number of unecessary update to components
which manipulate sources but ignore their blackbox state.
Differential Revision: https://phabricator.services.mozilla.com/D151005
The first step of parsing custom formatters for objects is checking a website for a global array called `devtoolsFormatters`.
If this array exists, it is looped over to find a custom formatter that can handle the object.
In case there is one, its `header` and `hasBody` methods are executed using `makeSideeffectFreeDebugger()` to ensure to get a result without causing any negative side effects.
Those results are then returned together with the index of the custom formatter.
This index is used in case the custom formatter's body is expandedö. In that case the `body` property is also executed in a safe way and its value then returned.
A test covers basic support of custom formatting for objects. More advanced tests will be added in bug 1752759.
Differential Revision: https://phabricator.services.mozilla.com/D146389
Enable clearing of network resources on all layers(frontend, resource layer, server) when the
user click the clear button.
Differential Revision: https://phabricator.services.mozilla.com/D148694
Julian Descottes
Alexandre Poirot
Nicolas Chevobbe
Hubert Boma Manilla
Bogdan Szekely
Thomas Wisniewski
Kagami Sascha Rosylight
Cristian Tuns
Barret Rennie
Norisz Fay
Boris Chiou
criss
Sebastian Zartner
Tooru Fujisawa
mleclair
Andreea Pavel