Edward Lee
9a15bcc16b
Bug 528343 - Tabs don't sync
...
Set the current client on any tab change for tracker.changedIDs and reset that when sync finishes.
--HG--
extra : rebase_source : 3100141bc1fdfaaa959b5f990a9538527761aace
2009-11-12 14:48:54 -08:00
Edward Lee
00cc35abdf
Bug 527767 - Sync more history items on first sync
...
Syncing 1000 items should be good enough for anybody......
2009-11-12 13:51:28 -08:00
Edward Lee
d2abea3b69
Remove unwanted info logging for bookmark indices.
2009-11-11 15:20:19 -08:00
Edward Lee
9e1ef1c8af
Bug 527766 - Sync history pages with a single visit
...
Backout bug 518972 (6954c93b8903) so now we push all data instead of pages with more than 1 visit.
2009-11-10 15:52:40 -08:00
Mike Connor
516a5f8953
bug 518075 - tweak original patch and item values
2009-11-09 12:57:58 -05:00
Edward Lee
b0552ee55b
Bug 519139 - Weave freezes the browser for 5-10 secs when starting sync
...
Correctly remove the separator getter just like for folders to prevent triggering the lazy loader on every sync.
2009-11-04 16:07:05 -08:00
Mike Connor
c803c9f499
bug 485108 - drop status dialog, show status including engines on statusbar, remove dead status bits
2009-10-28 03:42:35 -04:00
Edward Lee
2df003c9b1
Bug 517598 - Put useful interestingness/index values for bookmark
...
Use places to figure out the frecency of a bookmark and give items (not just bookmarks) a bonus if it's sitting in the toolbar.
2009-10-16 16:19:28 -07:00
Edward Lee
dbc6dadefc
Bug 517598 - Put useful interestingness/index values for history
...
Additionally get the frecency for a history GUID/page when getting the url and title.
2009-10-16 16:18:53 -07:00
Edward Lee
163c93866d
Keep the unsorted bookmark folder unsorted and not worry about the ordering.
2009-10-13 16:27:10 -07:00
Edward Lee
0d568192bf
Bug 518972 - Only upload history records that have more than one visit
...
Allow each engine to provide a custom Collection object and have History provide a collection that filters out certain data. This is inefficient because we have to first create then encrypt the record before we can filter it out.
2009-09-25 16:52:12 -07:00
Edward Lee
f8ce20a6b7
Bug 518958 - Only sync tabs if there has been tab activity
...
Check the score, which gets bumped up on tab open/close/select, to decide if tabs should be marked as changed.
2009-09-25 16:14:26 -07:00
Edward Lee
450c304c35
Bug 514601 - Don't send DELETE for old history/form data on every sync
...
Don't send any deletes as the server will do the delete with bug 518945.
2009-09-25 15:30:26 -07:00
Edward Lee
fcb7e6d648
Land about-weave on weave. Bug 516350 - about:weave round 3 followup fixes. r=thunder
2009-09-17 14:51:00 -07:00
Edward Lee
b21c9b6300
Use trace logging for reporting GUIDs.
2009-09-17 14:41:24 -07:00
Dan Mills
2625b8a1fb
initial patch
...
--HG--
extra : rebase_source : 250c8f0d85483300147a6f0d691e0214db6d837b
2009-09-15 21:54:05 -04:00
Edward Lee
3dfa70a1a9
Merge weave-partial-view to weave. Bug 507429 - Partial sync download support. r=thunder
2009-09-11 16:48:58 -07:00
Edward Lee
a8046d8b8e
Address review comments nits. r=thunder
2009-09-11 16:44:26 -07:00
Edward Lee
3729a2df9c
Be less chatty when showing GUIDs and ignore cases.
2009-09-11 14:39:48 -07:00
Edward Lee
a1a35caae8
Add some comments to partial download code and remove other comments.
2009-09-11 08:24:42 -07:00
Edward Lee
1a4b100a73
Merge weave to weave-partial-view.
2009-09-10 23:18:33 -07:00
Edward Lee
1f9d82f9b7
Use a short-circuiting check to determine if a history visit already exists.
2009-09-10 21:27:47 -07:00
Edward Lee
122062e186
Don't create a GUID when looking for dupes and set the GUID when adding a url.
2009-09-10 20:04:34 -07:00
Edward Lee
e343e595ee
Detect dupe separators by identifying them by their position and generate the lookup lazily with the folder/title mapping for now.
2009-09-08 23:33:58 -07:00
Edward Lee
57b041bbe1
Expose a _handleDupe on engines and provide a custom one for bookmarks that tracks GUID changes so that it can keep an alias mapping to fix incoming item properties (id, parent, predecessor). Move out _reparentOrphans so that it is triggered on update and not just create because folders can change ids to the right parent.
2009-09-08 23:33:15 -07:00
Edward Lee
18a57b6d35
Resolve bookmarks.js merge conflicts switching to batchSync (with trailing comma).
2009-08-31 18:04:40 -07:00
Edward Lee
5f8f947cfd
Merge weave to weave-partial-view w/ conflicts.
2009-08-31 18:03:35 -07:00
Edward Lee
a2c283b591
Detect dupe folders by title for now. Might need to update the hash during sync if titles are added.
2009-08-31 17:54:21 -07:00
Edward Lee
d09d8a37e6
Switch end-of-sync deletes to something SyncEngine is aware of and runs at _syncFinish.
2009-08-31 17:30:34 -07:00
Edward Lee
8df3731ca9
Use places utils to find an existing bookmark dupe for an incoming record.
2009-08-31 17:29:47 -07:00
Edward Lee
6fc3d9dd75
Convert uses of recordLike/findLikeId to findDupe except Bookmarks is unimplemented.
2009-08-31 17:27:30 -07:00
Edward Lee
d439ae6ca8
Bug 512457 - Report errors before they get eaten up by runInBatchMode
...
Save the exception from inside runBatched and not have runInBatchMode return failure, so we can then expose the exception.
2009-08-31 16:28:00 -07:00
Edward Lee
1996dc0246
Bug 506297 - Livemarks with null site/feed uris cause sync to fail
...
It's possible for livemarks to not have a siteURI, so don't assume it to be there.
--HG--
extra : rebase_source : 870bb41c980834ef3e5f302739d20adfed6f7f8d
2009-08-26 14:22:11 -07:00
Edward Lee
fbdd3f2a85
Don't include changes to special places Library "exclude from backup" items.
2009-08-25 16:15:05 -07:00
Edward Lee
5d218c258c
Create records with the correct parent/pred if it's still waiting for them to sync.
2009-08-24 16:17:59 -07:00
Edward Lee
b306cc77ab
Extend Utils.anno to handle pages and clean up GUID code for history engine. Also fix a bug where changeItemID would set annotations to expire on session.
2009-08-21 14:29:37 -07:00
Edward Lee
56a601c631
Remove old dumping code for debugging bug 476903.
2009-08-21 14:29:35 -07:00
Edward Lee
a482f14d1f
Bug 511794 - Always use _view instead of _temp + table or just table
...
Also use subqueries instead of multiple queries and drop the query count down to 2.
2009-08-21 14:29:30 -07:00
Edward Lee
012ffa961f
Handle holes in bookmark folders and fix up bookmarks to be at an earlier position if a hole was detected.
2009-08-19 19:32:05 -07:00
Edward Lee
fffcd82ae9
Attach followers for both created items and updated items (call from applyIncoming) when it's under the right parent. Share logic for attaching followers when creating a folder then fixing the reparented children and when creating/updating an item in the right parent.
2009-08-18 18:42:15 -07:00
Edward Lee
bd6e991aed
Add the successor ids when adding/removing items as well as both old and new successors when moving.
2009-08-18 18:39:10 -07:00
Edward Lee
2e066edaf5
When updating the position of an item, move all of its followers with it. Share chain moving logic used for fixing followers on create and updating positions.
2009-08-18 18:36:31 -07:00
Edward Lee
02653b0e23
For items that have the correct parent, see if there's an item following it and reposition the chain of items to after the correct parented item. A chain of followers starts at the item with the predecessor annotation and goes until the end of the folder, an item that is looking for a predecessor, or ends up at where we started (the predecessor).
2009-08-17 02:34:03 -07:00
Edward Lee
34d7888b13
Simplify the debug output when creating bookmarks and include the parent and position.
2009-08-16 12:39:30 -07:00
Edward Lee
ce014b37ed
Use the predecessorid to figure out where to put the item or save the predecessor as an annotation.
2009-08-16 12:39:15 -07:00
Edward Lee
a899e3fc64
Set the predecessorid when creating records for upload.
2009-08-16 12:39:00 -07:00
Edward Lee
24b24d90a8
Remove the missing parent annotation after reparenting an orphan.
2009-08-15 14:43:10 -07:00
Edward Lee
0930d522d8
Reparent orphans when creating the parent folder.
2009-08-15 01:07:40 -07:00
Edward Lee
3acf0af190
Use a shared setGUID for new items and changing guids so that the item always ends up with the GUID (because conflicts shouldn't have been Weave generated).
2009-08-15 01:04:06 -07:00
Edward Lee
b01244308b
Store the parent GUID as an annotation if the item is missing a parent and share some parent lookup code.
2009-08-15 01:00:46 -07:00
Edward Lee
367213495f
Move _preprocess to before applyIncoming to share code for create/update/remove.
2009-08-15 01:00:32 -07:00
Edward Lee
af37c0bc61
Rename weaveId to just GUID and share a id<->guid function across store and tracker.
2009-08-15 00:59:49 -07:00
Edward Lee
ac3e6b761e
Temporarily append everything and don't use sortindex for ordering within a folder.
2009-08-15 00:57:09 -07:00
Edward Lee
783223115f
Get rid of depth and sort on index instead.
2009-08-15 00:56:27 -07:00
Edward Lee
5f6b7af2ff
Remove meta/mini records. Bye!
2009-08-13 18:50:54 -07:00
Edward Lee
b2bd7b5d10
Put Annotations in Svc and expose a get/set Utils.anno call to use from bookmarks.
2009-08-13 17:59:26 -07:00
Edward Lee
218cdffe7f
Remove unused bookmark annotations/constants.
2009-08-13 17:43:20 -07:00
Edward Lee
a77e420a8a
Bug 507296 - Sync bookmarks and history in batched mode. r=thunder
...
Wrap the original SyncEngine._sync function with a call to runInBatchMode, so SQL disk writes happen at the end of batch mode instead of on every change.
2009-07-30 11:52:26 -07:00
Edward Lee
8c9e2af36c
Change client engine to override findLikeId instead of recordLike to save on some work (iterating over changed ids).
2009-07-28 10:07:07 -07:00
Edward Lee
b0e99b50a1
Bug 506795 - Handle adding duplicate logins. r=thunder
...
Refactor reconcile to call findLikeId that by default will look for recordLike in the outgoing queue as it does now. Override findLikeId for password engine to search local logins.
2009-07-28 10:06:02 -07:00
Edward Lee
6293c974de
Convert various debug messages to trace.
2009-07-22 21:40:18 -07:00
Edward Lee
cb085193e5
Remove pref tracker init debug message.
2009-07-14 18:47:29 -07:00
Edward Lee
c75387d5ab
Bug 504230 - Use Engine's logging level for Store and Tracker
...
Use the log.logger.engine.* prefs to determine what the Store and Tracker should log with. This requires putting the same engine name on each Store/Tracker object, so there's some duplicate string values right now.
2009-07-14 18:34:03 -07:00
Edward Lee
4a7d3fdd7d
Bug 504216 - Force various engines to be disabled
...
Have the disabled engines return null for enabled instead of the pref's true/false.
2009-07-14 17:03:57 -07:00
Anant Narayanan
a5ccf09b4f
Limit form history records (bug 494952, r=thunder)
...
--HG--
extra : rebase_source : c3e983d30a14efd972eea2651a59be76924da256
2009-07-14 12:28:18 -07:00
Edward Lee
8a0fe106d0
Bug 479189 - weave does not sync tag smart folders properly
...
Create a new record type, BookmarkQuery, to handle place: uri smart bookmarks. Store what tag name the query wants and lookup the id for that tag on other machines on create/update.
2009-07-13 17:43:15 -07:00
Edward Lee
2a1d0341a0
Bug 503938 - Tags with a single bookmark keep generating new tag ids
...
Share a tagging code for create/update that will tag a dummy uri temporarily while it untags the bookmark to make sure every tag has at least one child during this untag/tag process.
2009-07-13 13:40:49 -07:00
Edward Lee
0d43caf465
Bug 502482 - error while syncing bookmarks from server
...
Set the item type for generic PlacesItems, but don't do anything when trying to create it.
2009-07-09 17:15:00 -07:00
Edward Lee
8fd525f317
merge weave. resolve comments added to resource.js.
2009-07-09 11:21:20 -07:00
Edward Lee
b6e3b95d2d
Convert a log.info to log.debug for passwords so it doesn't clutter the brief log.
2009-06-25 22:52:28 -07:00
Edward Lee
dd9ce3521e
Bug 500598 - Undefined item in tabContainer.childNodes after closing tabs
...
The childNodes NodeList keeps its indices even after removal, so it's safer to convert the array-like thing into an actual array. Condense the QueryInterface code to the instanceof magic.
2009-06-25 22:46:14 -07:00
Edward Lee
baa6609a31
merge weave. resolve addition of kSpecialIds to bookmarks.js near removal of Async.sugar.
2009-06-23 22:34:57 -07:00
Anant Narayanan
4b5477c640
Change priority of some log messages to trace
2009-06-22 18:19:42 -07:00
Edward Lee
2317e38e54
Bug 487282 - "browser is null" error in tabs.js
...
Share browser detection code for register and unregister tab listeners and better check for tabbrowser windows.
2009-06-22 15:53:42 -07:00
Edward Lee
9be03ab0ef
Bug 498924 - Refactor bookmark special ids out of BookmarksStore
...
Lazily load places ids for a given weave id/place name pair into kSpecialIds and update all consumers. Expose a Svc.Bookmark in utils.
2009-06-17 09:28:15 -07:00
Edward Lee
a24e7341b7
Cleanup/refactor followup to bug 481327.
...
Change _ignore to take itemId to find folderId and pull out addChanged/getItemGUID/upScore to addId.
2009-06-17 08:51:54 -07:00
Edward Lee
99d6016a8f
Bug 481327 - Script gets stuck during startup. r=Mardak
2009-06-17 08:51:54 -07:00
Mikhail Stepura (mishail)
d382bba446
Bug 486042 - "Load this bookmark in the sidebar" status not synced. r=Mardak
2009-06-16 16:16:39 -07:00
Philipp von Weitershausen
0cfda7e528
Bug 652666 - ltm is not defined in prefs engine. r=rnewman
2011-04-25 22:07:47 -07:00
Edward Lee
89dc382760
merge weave
2009-06-06 13:12:03 -07:00
Edward Lee
679e086734
Fix form engine to correctly pass in the engine.
2009-06-05 18:36:31 -07:00
Edward Lee
43b30db17c
Clean up various engines to remove Async.sugar and random self/yields.
2009-06-05 15:34:40 -07:00
Edward Lee
6f2fce527b
Change SyncEngine._reconcile to not be async/yield.
2009-06-04 14:18:04 -07:00
Edward Lee
5220bc6208
Change Resource.get() to be sync (no callback) and fix up call sites used for login + sync now.
2009-06-04 10:16:07 -07:00
Wladimir Palant
5dcfbd267f
Bug 495996 - Bookmark observer doesn't implement onBeforeItemRemoved method. r=Mardak
2009-06-02 21:25:55 +02:00
Wladimir Palant
2441a6d598
Bug 495924 - TabTracker wrongly assumes that "this" pointer will be set correctly for event handlers
2009-06-02 11:25:37 +02:00
Anant Narayanan
a0fa186445
Preference sync (bug #428370 )
2009-05-24 02:11:05 +02:00
Anant Narayanan
08ffd3fefe
Use first login found if there are multiple GUIDs
2009-05-24 00:25:30 +02:00
Anant Narayanan
40a03c75ba
Use searchLogins instead of caching passwords (bug #489268 )
2009-05-24 00:03:53 +02:00
Edward Lee
0b1f211385
Bug 493004 - Create stubs of unimplemented engines to list them as disabled (extension, microformat, plugin, theme)
...
Add the 4 engines with just the base code to set their name and register them for Firefox.
2009-05-14 11:50:59 -05:00
Edward Lee
0348c64b04
Bug 493002 - List partially implemented engines (cookies, input history) as disabled
...
Import the outdated engines, but delete their pref so they show up as disabled. Clean up the old engines a little bit so they don't allocate unnecessarily and to not use syncCore.
2009-05-14 11:43:56 -05:00
Edward Lee
e176e6027b
Fix form engine displayname to displayName
2009-05-14 11:09:08 -05:00
Edward Lee
8cb7b35b4c
Remove old Firefox 3 places DB code.
...
Min version is 3.1/5, so we grab DBConnection from places directly now.
2009-05-13 16:31:42 -05:00
Myk Melez
f22229f58f
bug 492435: work around crasher bug 492442 by not calling isVisited for a history entry without a URL; r=thunder
2009-05-11 16:11:04 -07:00
Edward Lee
f6367261d8
Bug 488190 - Use record properties instead of cleartext properties
...
Switch pretty much all references to cleartext in modules/engines/ to just use the record. Also clean up some references to null cleartext to use deleted. The only reference to cleartext is to iterate over that hash in bookmarks.
2009-04-13 16:39:29 -05:00
Edward Lee
5a136689fb
Bug 488170 - Consistently set record cleartext URIs as text spec uris
...
Switch cleartext properties to Uri that always takes a text spec, so eventually URI refers to nsIURI. GeneratorURIs seems to have been broken either way.. makeURI of an already URI and storing of a URI into cleartext. This landed with changes to keys, so the server wipe also handles the local name changes.
2009-04-13 16:39:29 -05:00
Edward Lee
aff1f185c3
Bug 488142 - Make it easier to add simple deferred cleartext/payload values
...
Add a couple Utils helper to create a pair of simple [gs]etters that use a hash property instead. Apply this to various records: WBORecord, {Priv,Pub}Key, Crypto{Meta,Wrapper}, and every engine's type records. Migrate by making sure key data exists (name change).
2009-04-13 16:39:29 -05:00
Edward Lee
73ea5a7a89
Bug 488182 - Use an Iterator to grab both key and values from cleartext for processing bookmarks
...
Get rid of extra record.cleartext references within the for/each/switch -- even for unused keys like incomingSharedAnno.
2009-04-13 16:18:11 -05:00
Edward Lee
3bd7c7fccf
Bug 488165 - Correct set the record object type when processing records
...
Set _recordObj for Bookmarks/History engines and override PlacesItem.decrypt to switch itself to the right type after CryptoWrapper decrypts the payload.
2009-04-13 14:54:31 -05:00
Dan Mills
ee1dca0813
oops fix missing .prototype
2009-04-10 17:30:05 -07:00
Dan Mills
72fe638ff7
Remove __proto__.__proto__ it's fail-prone
2009-04-10 16:08:31 -07:00
Dan Mills
240a108af3
can't get guid on expiration
2009-04-10 16:04:13 -07:00
Edward Lee
cd2b9e8150
Bug 487541 - form submission caused exception 0x80004002 (NS_NOINTERFACE) [nsISupports.QueryInterface]
...
Get rid of the QueryInterface and just use instanceof while copying the logic of nsFormHistory::Notify to avoid divergent logic until satchel provides a notification.
2009-04-08 22:48:26 -05:00
Dan Mills
9372000a56
don't track history deletes at all; don't built id->guid mapping hash for history tracker
2009-04-08 18:11:14 -07:00
Myk Melez
83c54d2014
switch from --utc to -u flag to enable UTC output for date command so it works on both Linux/Windows (which support --utc in addition to -u) and Mac OS X (which only supports -u)
2009-04-08 15:00:02 -07:00
Edward Lee
a5332e83ca
Bug 487378 - Use the app name as the default client name
...
Use nsIXULAppInfo to get the name and remove Fennec specific bits.
2009-04-08 02:12:57 -05:00
Mikhail Stepura
1bb93a35bc
Bug 486481 - Weird behavior when syncing the bookmark with tags
...
Add the remaining special top level folders and ignore them for certain behavior like getAllIDs and wipe. Have the tracker ignore changes to things in the tags folder.
2009-04-07 23:17:40 -05:00
Edward Lee
03950c261e
Bug 487363 - Share bookmark tracker ignore logic
...
Share the ignore logic that takes a parent folder and ignore if the engine says so or it's a livemark.
2009-04-07 22:56:04 -05:00
Edward Lee
ca8efb5327
Bug 487338 - Track special folder weave GUIDs <-> bookmark id mapping
...
Create a specialIds hash and use it to for getting weaveId/id, determine top level, if a folder is a root, getting all ids, wiping, and tracker ignoring.
2009-04-07 19:22:36 -05:00
Anant Narayanan
21b13a7d8b
Update form sync engine to work with Weave0.3/FF3.5
2009-04-06 19:05:16 +02:00
Edward Lee
a9b1c2cc31
Bug 482670 - WBORecord should implement a .deleted property
...
Expose a .deleted property that engines can set to true to store an even thinner deleted payload (empty string "" instead of "[null]") on the server. Handle deserializing of deleted records by setting the property. Note: Engines must set their payloads to something JSON-able if it's not a delete record.
2009-04-03 12:38:47 -05:00
Edward Lee
c1e5c50285
Bug 486667 - Clients get amnesia -- forget who they are after a wipe
...
Set the local client info after resetting the clients store hash
2009-04-03 09:26:12 -05:00
Edward Lee
c0f5f6c0eb
Bug 480929 - RSS names not synced
...
Set the title in the record just like any other bookmark (folder)
2009-04-01 17:12:08 -05:00
Edward Lee
ff6f758608
Bug 482896 - Unify local client data and remote client data storage
...
Initialize unified client store from disk json and local prefs and update on pref changes + sync. Clean up client engine code (local vs inherited, alphabetical), and create a helper modify() to save snapshots.
2009-04-01 01:56:32 -05:00
Edward Lee
8e8a01356e
Bug 486234 - Give changes json file name for history, passwords
2009-03-31 20:07:43 -05:00
Edward Lee
e9647a3977
Bug 486230 - Share json disk caching with Utils.json{Load,Save}
2009-03-31 19:52:16 -05:00
Edward Lee
3cead7f04b
Bug 481741 - Switch to JSON from nsIJSON
2009-03-31 14:09:38 -05:00
Dan Mills
e22f52680d
Bug 478328: delete old history data from the server
2009-03-30 15:19:00 -07:00
Dan Mills
8c87c983c6
remove dump() debugging from tabs engine
2009-03-30 15:18:20 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a5941f8933
Bug 485539 - added guard to the tab engine to handle the case where there are undefined items in tabContainer.childNodes.
2009-03-27 11:06:43 -07:00
Dan Mills
1d6b73a5d7
Bug 484848: try #3
2009-03-26 10:58:54 -07:00
Dan Mills
fbc81b07ff
Bug 481319: try again
2009-03-25 19:47:37 -07:00
Dan Mills
21a55b22a0
merge upstream changes
2009-03-25 19:33:51 -07:00
Dan Mills
af167b9432
Bug 484848: modifyLogin sends an array of nsILoginMetaInfos to observers
2009-03-25 19:27:24 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4a513caa84
Fixed name of TabStore.changeItemID so that it correctly overrides the abstract base class method. Whoops.
2009-03-25 17:36:11 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
9c85a264a4
Experimenting with getting tab last-used-time data on Fennec
2009-03-18 12:40:27 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
ae7267f46c
Removed unused code from tab tracker.
2009-03-17 18:02:13 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4cbc878b21
TabTracker now keeps track of when each tab was most recently used; tabStore wraps this data for sync, and fennec UI uses it to sort incoming tabs by most-recently-used date. This fixes 481326.
2009-03-17 17:57:53 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
536938dc74
If you click the button to show synced tabs before Weave has been configured, it will now take you straight to the sign-in screen. Fixes bug 482818.
2009-03-16 16:49:56 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
749f5cba2d
The remote-tabs menu (on both firefox and fennec) no longer shows tabs you already have open locally. Fixes bug 480405.
2009-03-12 15:54:26 -07:00
Edward Lee
139205503a
Bug 481266 - Provide a way to perform actions on remote clients. r=thunder
2009-03-03 17:29:35 -06:00
Dan Mills
5e1b7601b4
oops, client was not updating depth/index of records
2009-03-11 02:02:58 -07:00
Dan Mills
f40f88e033
Bug 478327: Send minimal '[null]' payload for deleted records
2009-03-11 01:40:04 -07:00
Edward Lee
e7a623aaec
Bug 482178 - Clean up services -> lazy services. r=thunder
2009-03-10 06:30:30 -05:00
Dan Mills
317e61ebb0
remove dump() debug statements
2009-03-10 01:20:50 -07:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
559cdb74cc
Fennec now launches first run page, and updates extensions.weave.lastversion, so that it's no longer resetting syncId and therefore resetting the server every single time it tries to sync. Also set the download in resource.js to use LOAD_BYPASS_CACHE. Together these changes seem to fix bug 480270.
2009-03-07 00:55:47 -08:00
Edward Lee
1a083160c8
Bug 480457 - Expose a resetClient API for weave service and engines. r=thunder
2009-02-26 22:36:14 -08:00
Dan Mills
125e420233
disable recordLike for clients
2009-03-03 11:53:56 -08:00
Dan Mills
e178c83009
create new records with correct guid set
2009-03-03 01:48:13 -08:00
Dan Mills
a76310f62c
override _recordLike for passwords; add logging calls; make getAllIDs return full nsLoginInfos
2009-03-03 01:32:10 -08:00
Dan Mills
85834524e0
Switch away from __defineGetter__ due to bug 481104; explicitly cache logins in password engine; whitespace fixes
2009-03-02 18:55:26 -08:00
Anant Narayanan
fd1d0e8eef
Remove getter that fixes the 'two-store' problem
2009-03-03 01:15:48 +01:00
Anant Narayanan
0932057beb
Rename methods to be less confusing
2009-03-03 00:57:37 +01:00
Anant Narayanan
33a1012482
Password sync for 0.3 (bug #468697 )
2009-03-03 00:42:57 +01:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4aef6ff6d2
Resource.js now always validates the cache (VALIDATE_ALWAYS) when downloading stuff. This seems to fix bug 480270 on Firefox but not on Fennec.
2009-02-27 18:28:26 -08:00
Dan Mills
65da8b27e8
fix args list for observe()
2009-02-26 17:37:49 -08:00
Dan Mills
c3a4c302ea
track local client data changes so we can upload it as necessary
2009-02-26 15:06:57 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
de060a98d5
Changed how firefox populates tabs-from-other-computers menu and how it opens a tab picked from that menu, so that it can restore the history of the tab and not just the latest URL.
2009-02-25 00:56:46 -08:00
Dan Mills
06c7c8909a
random fixes, actually syncs client data now :)
2009-02-20 01:52:07 -08:00
Dan Mills
ec488dc66b
don't load old crypto module
2009-02-20 01:49:00 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0bbeefc7c8
Tab sync now skips empty tabs. This fixes bug 479216.
2009-02-19 11:20:23 -08:00
Dan Mills
a520825801
go back to storing the local client name and type as prefs. also store a 'syncID' (gets reset upon a server wipe)
2009-02-19 04:07:23 -08:00
Dan Mills
9a6bb0d0f4
pass the cryptoMetaURL to the store's createRecord
2009-02-19 00:36:55 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
c153e03bf0
Fixed a bug with my fix -- I had inadvertently created an infinite loop.
2009-02-18 22:23:48 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
462d10aeec
Fixed a bug in how Firefox gets URL history to save when syncing tabs up. Also some more work on the Fennec tabs UI.
2009-02-18 18:18:50 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
560235a8d3
First pass at Fennec tab UI. There's now a button that opens a fullscren panel from the left, which contains the names of all remote tabs. They're not clickable yet.
2009-02-17 16:28:54 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
92e94b5d94
Tab sync works, and has UI in firefox (though not yet in Fennec)
2009-02-11 19:14:25 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
8e9361f996
Fixed bug in tab encoding in Firefox.
2009-02-10 22:15:25 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
b7258fc04c
Fixed tab encoding bug on Fennec
2009-02-10 21:54:11 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
12db878c5b
Fennec tabs and Firefox tabs now handled in different functions, and the Fennec one at least works.
2009-02-10 19:23:06 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
d6e830ec06
SessionStore not available on Fennec, so now using alternate methods to get the list of tabs.
2009-02-09 21:16:18 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
149b5c8e8a
Fixed some minor problems with TabEngine; identified places where TabEngine will need to use alternate methods to work on Fennec.
2009-02-09 20:23:42 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
47092cd7f9
Switched TabTracker to register listeners on window open and remove them at window close -- need to find an alternate way to make this work on Fennec, where windows don't have tabContainers.
2009-02-06 17:50:12 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
4b7d836c3a
Added debugging info to TabEngine. Instantiated and registered TabEngine in both Firefox weave glue and Fennec weave glue.
2009-02-06 11:19:50 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
370341c284
Rewrote tabs engine to work with 0.3 API. (Not yet tested).
2009-02-04 19:51:20 -08:00
Dan Mills
c723a70134
ignore all events when tracker.ignoreAll is true; ignore most bookmark annotations (except for the ones we sync)
2009-02-02 11:43:06 -08:00
Dan Mills
813afa9b10
set record ID for bookmark deletes too
2009-01-27 17:23:23 -08:00
Dan Mills
4a1427278e
set record ID in history store when creating a record
2009-01-27 17:08:47 -08:00
Dan Mills
ec75cd2b3d
set record IDs inside the store; fix bookmarks tracker, it was ignoring change events (e.g., changed title and such)
2009-01-27 16:54:54 -08:00
Dan Mills
3cedb09d82
Make records not extend Resource, instead they have a serialize() method that can be used to create a Resource for uploading if necessary.
...
Use global service instances under Svc.*
Consolidate various record managers (caches/convenience factories) to extend the same base object
Log exceptions caught by notify wrapper
2009-01-27 13:35:10 -08:00
Dan Mills
7e8166c629
make it so clients list can be modified from any client, and so it doesn't upload client info on every sync; clients list no longer stores data (except the local client's guid) in the firefox prefs
2009-01-23 15:09:21 -08:00
Dan Mills
3dec5d4605
wrap microsummary creation code in try/catch; catch unknown items during onItemMoved (should not happen, but...)
2009-01-21 19:04:13 -08:00
Dan Mills
18c1b82a81
simpler reconciliation for history
2009-01-20 13:13:31 -08:00
Dan Mills
f4fddb65c1
fix url vs uri typo
2009-01-15 18:43:44 -08:00
Dan Mills
3123be1d68
merge upstream changes
2009-01-15 15:53:51 -08:00
Dan Mills
946642420d
fix typo
2009-01-15 15:53:34 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0b5d7072fd
Merged
2009-01-15 14:06:00 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
bb5eead71b
Added a method to historyStore called tempTableExists which does a SELECT (rather than using tableExists) to correctly tell whether a temp table is there or not, so that historyEngine will work correctly on both Fennec and Firefox (See bug 472963)
2009-01-15 14:05:50 -08:00
Dan Mills
476672bf55
Bug 468671: Don't synchronize livemarks. Based on patch by Jorge Alves <jag.alves@gmail.com>
2009-01-15 13:58:59 -08:00
Dan Mills
1420201b13
add some extra log info to engine; have tracker ignore all changes when applying a change to prevent the tracker from generating new guids for new items before the store has a chance to set the right one
2009-01-14 22:01:04 -08:00
Dan Mills
c8f1c3219e
disable unused engines; fix trackers trying to call enable which is gone now; improve bookmarks tracker logging
2009-01-13 16:55:51 -08:00
Dan Mills
2729d012ee
make tracker return true/false when adding a changed ID to indicate if it was a valid add or not; change bookmarks & history trackers to match; fix some problems in bookmarks tracker
2009-01-13 15:55:35 -08:00
Dan Mills
5a6cb633ba
ignore/unignore specific weave IDs instead of a blanket enable/disable of the tracker during sync.
2009-01-13 14:43:21 -08:00
Dan Mills
f5012bd4b8
small getchildren/getsiblings cleanup
2009-01-13 13:40:40 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
0e897fc3cb
History sync now works in Fennec, by simply skipping all the temp tables that don't exist in Fennec. This should also fix bug 472853 for weave in Firefox.
2009-01-09 15:44:27 -08:00
Dan Mills
636534da50
merge upstream changes
2009-01-08 21:34:43 -08:00
Dan Mills
f93e31391a
when an orphan bookmark is found, reparent it to the unfiled bookmarks folder
2009-01-08 21:33:59 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
55d3388e52
Merged
2009-01-08 16:59:56 -08:00
Dan Mills
d96cdb6eb1
commit so hg will let me merge
2009-01-08 16:57:35 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
6bb955a067
The Weave check box on the Fennec preferences screen now logs you in/out when you click it in addition to enabling/disabling the scheduler. Improved the fennec-connect page by making the text fields auto-select when you click in them and turning the 'accept TOS' check box into a button.
2009-01-08 16:37:36 -08:00
Dan Mills
81cdb36c28
set guid when creating history entries
2009-01-07 17:46:31 -08:00
Dan Mills
917ba851d0
Bug 472480: catch errors when changing history item IDs
2009-01-07 15:01:12 -08:00
Dan Mills
3079faacf5
add clients sync (list of clients with names and types); make it simpler to create Engine subclasses; remove the 2nd 'authenticator' parameter for Resources; resetServer is now wipeServer; consider 0 an invalid place ID (fixes bug when calculating item depths); add a Svc global exported from utils.js where commonly used services can live
2009-01-06 13:54:18 -08:00
Dan Mills
244cccbf13
update history engine to work again with latest engine changes, and re-enable history sync
2009-01-03 01:04:17 -08:00
Dan Mills
f706c5158c
fix depth/index record generation
2009-01-02 21:13:32 -08:00
Dan Mills
ff90a20ee7
extra debugging to catch getFolderIdForItem errors
2009-01-02 19:35:23 -08:00
Dan Mills
5968d4080e
fix tracker's onItemRemoved
2009-01-02 16:16:38 -08:00
Dan Mills
3a796fb008
add a _getWeaveParentIdForItem method; fix getAllIDs; add a createMetadataRecord method
2009-01-02 13:49:19 -08:00
Dan Mills
08400bd281
add a generic cache class for storing records during reconciliation. cache has 100 item limit, and is cleared before and after reconciliation so the OS can reclaim memory after GC
2008-12-30 23:52:20 -08:00
Dan Mills
90bae8f088
make engine keep less records in memory by limiting the outgoing queue to a maximum of 100 records, and fetch the rest from the store each time
2008-12-29 23:28:17 -08:00
Dan Mills
bf5efd53ba
switch to generating individual bookmark records directly from the places store, without using a cache (to improve memory performance); create objects for bookmark types; temporarily disable history sync
2008-12-28 19:59:44 -08:00
Dan Mills
7af7fa0571
remove commented-out code
2008-12-26 21:50:07 -08:00
Dan Mills
3bf24e2364
Various engine/bookmark changes:
...
* Rely on the server to sort incoming records, remove all sorting code client-side.
* Streamline sync to be able to process incoming records one at a time, as soon as they are downloaded. This changes reconciliation to be able to process a single incoming record.
* Engine base class will automatically convert parentid, depth, and sortindex into toplevel WBO objects. This is good for now but kinda broken, engine subclasses should really be generating WBO records themselves.
* Since index is now a toplevel WBO property, there is no need for the bookmarks sync code to subclass recordLike.
* Refactor bookmarks store to be a little cleaner and work directly with records instead of "commands".
2008-12-23 11:30:31 -08:00
Dan Mills
c11a364f5a
remove accidentally committed logging calls
2008-12-23 11:23:10 -08:00
Dan Mills
400b30b229
fix typo in history sql queries, clarify valid sort order values for collections
2008-12-19 17:00:12 -08:00
Dan Mills
b043c0298e
change engine to process (download, reconcile, apply changes) incoming records one by one
2008-12-19 11:48:09 -08:00
Dan Mills
18166fe10e
implement the awe (or tears) inducing places-style sql queries -- history sync works pretty well now
2008-12-18 22:39:32 -08:00
Dan Mills
027993146e
typo fix
2008-12-18 01:09:17 -08:00
Dan Mills
93a5c4d1d3
sync visit times and transition types for history
2008-12-17 16:04:03 -08:00
Dan Mills
63dc5d0a58
sync only the last 150 history items (pending some special sauce to sync high-scoring items); various sql fixes. history is syncing now, though there are bugs here and there
2008-12-17 02:32:00 -08:00
Dan Mills
55a9524e8c
override _itemExists, itemExists (no _) checks for cached items, then calls that
2008-12-17 02:29:28 -08:00
Dan Mills
9c65c6203d
api change for stores, deal with records not 'commands'
2008-12-16 17:06:45 -08:00
Anant Narayanan
27365a854c
Make Form history sync work again with new engine
2008-12-13 16:33:04 +01:00
Dan Mills
b1e7e421bc
merge upstream changes
2008-12-12 13:57:05 -08:00
Dan Mills
67ee4ce031
closer to history somewhat working. need to rethink approach because of performance problems
2008-12-12 13:55:58 -08:00
Dan Mills
0b0cd0ecfc
remove slightly misleading comment
2008-12-12 13:54:19 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a5da49ac2f
Merged
2008-12-11 15:19:43 -08:00
jonathandicarlo@jonathan-dicarlos-macbook-pro.local
a77aeb9f4c
On Fennec there is no microsummaries service, so I made the BookmarksEngine catch the exception if the service is undefined, and skip commands that would require it to create a microsummary, logging warnings instead.
2008-12-11 14:26:20 -08:00
Dan Mills
b4ce08d32d
closer to history working
2008-12-10 00:57:27 -08:00
Dan Mills
6bf68420c8
enable history sync (not working yet)
2008-12-09 12:26:14 -08:00
Dan Mills
8e9523ee72
make changeItemID exclusively a store method
2008-12-08 13:21:25 -08:00
Dan Mills
e11a3250a5
remove sync cores, they are no longer used; remove sharing code from bookmarks (we can bring it back when we need it again, needs work); have the engine give hints to the store about when to wrap all items and cache them (to make subsequent calls to wrap one item fast); move serializeItem/getAllIDs into the store
2008-12-08 09:53:32 -08:00
Dan Mills
52ee1c18f5
tracker now caches places id -> guid mappings, since otherwise it can't retrieve the correct guid on item removal (because the callback happens after the item is removed)
2008-12-06 00:12:40 -08:00
Dan Mills
08e95437cf
parentGUID -> parentid
2008-12-05 03:36:27 -08:00
Dan Mills
0d6ea4b75d
disable tracker for entire sync run. make sure tracker is re-enabled at the end
2008-12-05 00:55:19 -08:00
Dan Mills
a7fe7a2dff
use callbacks instead of snapshot diffs to figure out what changes to send to the server
2008-12-05 00:39:54 -08:00
Dan Mills
a068015870
fix bookmarks tracker by removing yield calls (which of course don't work as callbacks for nsIBookmarksObserver)
2008-12-02 16:46:24 -08:00
Dan Mills
a10a4d3bfd
add logic to detect when the same item is in both incoming & outgoing queues, but with different IDs - change the local ID in that case
2008-11-27 00:25:28 +09:00
Dan Mills
669b52e0de
decrypt incoming items all in one go so as to sort them by index (which is inside the payload); don't attempt to change the index of an item if we're also changing its folder; only change index/parent if it's different from current value
2008-11-26 14:07:18 +09:00
Dan Mills
d2b71a81ea
query the bookmarks service to find out if we have an item (instead of our snapshot cache)
2008-11-25 14:49:18 +09:00
Dan Mills
4e0bcf16b3
fix bookmark deletion sync
2008-11-25 01:49:02 +09:00
Dan Mills
529df21f87
work with NewEngine
2008-11-20 09:21:12 +09:00
Dan Mills
bcc82d82b7
remove some sharing code, derive from NewEngine
2008-11-06 19:18:46 -08:00
Dan Mills
777ac672ee
hg merge
2008-11-03 15:02:00 -08:00
Dan Mills
25a8c72d97
fix log4moz calls (new api), fix module imports for renamed modules
2008-11-03 15:00:38 -08:00
Dan Mills
84f34f44c7
disable bookmark sharing hooks
2008-10-16 12:30:30 -07:00
Dan Mills
a9952f3101
Bug 443489: use the correct cookie xpcom interface
2008-10-16 12:29:21 -07:00
Dan Mills
54aa798d98
catch exceptions from microsummaries that don't have a static title set
2008-08-13 15:23:15 -07:00
Dan Mills
2e17c212f4
Bug 450396: password engine does not define a tracker
2008-08-13 15:19:56 -07:00
Dan Mills
949e936ba2
merge upstream changes
2008-08-08 14:43:36 -07:00
Dan Mills
dea1506c58
move some code from the engine to remote.js; rename FileEngine to BlobEngine (since it doesn't actually sync complete files); clean up SyncEngine's sync method
2008-08-08 14:42:57 -07:00
Anant Narayanan
201ede3f4d
Syncing for Awesome bar (bug 437133, r=thunder)
2008-08-07 20:00:35 -07:00
Anant Narayanan
b5905c72cf
Automated merge with ssh://anarayanan@mozilla.com@hg.mozilla.org/labs/weave
2008-08-04 17:23:36 -07:00
Anant Narayanan
b5847e6adf
Asynchronous bookmark sharing (bug 449113, r=thunder)
2008-08-04 17:23:23 -07:00
Dan Mills
92d6278f39
filter out invalid tags when applying edit commands
2008-07-31 00:21:22 -07:00
Dan Mills
40357d6963
more tab sync fixes, only disposing is left to fix; also allow the notify wrapper to pass along an optional data payload
2008-07-30 21:58:13 -07:00
Dan Mills
820b732ed5
get tab sync halfway working again, with fileengine
2008-07-30 00:05:09 -07:00
Dan Mills
856921abd1
sync the *latest* 10 back-button entries per tab (not the earliest ones)
2008-07-29 15:37:59 -07:00
Dan Mills
c9220f8d0f
Implement FileEngine
2008-07-25 17:02:43 -07:00
Dan Mills
cadfaec0d3
split Engine into SyncEngine and FileEngine
2008-07-25 01:06:23 -07:00