Emilio Cobos Álvarez
ff732c2cdf
Bug 1555143 - Remove unused aDeep argument from UnbindFromTree. r=bzbarsky
...
$ for file in $(rg UnbindFromTree | cut -d : -f 1 | sort | uniq); do sed -i 's#UnbindFromTree(bool aDeep = true,#UnbindFromTree(#g' $file; done
$ for file in $(rg UnbindFromTree | cut -d : -f 1 | sort | uniq); do sed -i 's#UnbindFromTree(bool aDeep,#UnbindFromTree(#g' $file; done
$ for file in $(rg UnbindFromTree | cut -d : -f 1 | sort | uniq); do sed -i 's#UnbindFromTree(aDeep,#UnbindFromTree(#g' $file; done
$ ./mach clang-format
And fix the two callers and little use of the aDeep argument (see the "Manual
changes" patch attached to bug).
Differential Revision: https://phabricator.services.mozilla.com/D32898
--HG--
extra : moz-landing-system : lando
2019-05-28 22:47:08 +00:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Nathan Froyd
846d8789ee
Bug 1492894 - part 1 - make the node hierarchy consistently constructed with NodeInfo&&; r=mccr8
...
Various places in dom/ use the pattern:
already_AddRefed<NodeInfo> ni = ...;
which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason. To fix our static analysis code, we need to
eliminate instances of the above pattern.
Unfortunately, eliminating this pattern requires restructuring how Nodes
are created. Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`. We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
2018-09-21 16:45:49 -04:00
Emilio Cobos Álvarez
1fbd784d00
Bug 1481601 - Remove now-useless aPreallocateChildren from nsINode::Clone() and friends. r=bzbarsky
...
Since sed on multiple lines ended up being such a pain and I didn't end up
writing a script for this because I didn't think it'd end up being so boring, I
may have made a couple cleanups here and there as well...
Differential Revision: https://phabricator.services.mozilla.com/D2887
--HG--
extra : moz-landing-system : lando
2018-08-08 23:58:44 +00:00
Boris Zbarsky
cb08b0de7d
Bug 1455676 part 21. Remove nsIDOMNode. r=qdot
2018-05-29 22:58:51 -04:00
Boris Zbarsky
115f652b0b
Bug 1455676 part 20. Remove now-unused AsDOMNode methods. r=qdot
2018-05-29 22:58:50 -04:00
Boris Zbarsky
1cbc813260
Bug 1455674 part 20. Get rid of nsIDOMElement. r=qdot
2018-04-26 23:37:34 -04:00
Boris Zbarsky
248a8c7b00
Bug 1432944 part 13. Remove the NS_FORWARD_NSIDOMELEMENT_TO_GENERIC macro. r=mccr8
...
MozReview-Commit-ID: 8A1VcWArVcP
2018-01-29 23:29:11 -05:00
Boris Zbarsky
b6b8acada6
Bug 1432186 part 18. Remove no-longer-needed nsIDOMNode-forwarding defines. r=mccr8
...
MozReview-Commit-ID: FbP5fVQ3c6m
2018-01-29 23:10:52 -05:00
Kirk Steuber
7fdb378650
Bug 1359556 - Optimize cloneNode by preinitializing attribute and child arrays r=bz
...
Currently, attribute and child arrays (implemented in dom/base/nsAttrAndChildArray.h) start out empty. When cloning, the array ends up being resized multiple times in order to add the attributes and children that are being cloned from the original node. This would be quicker if the array was initialized to the correct size in the first place so that resizes are not necessary.
However, preallocating space for children is only necessary when performing a deep clone. Therefore, an additional parameter is being added to the Clone, CopyInnerTo, and CloneDocHelper methods to indicate whether preallocation of children should happen. Attributes are copied either way, so that part of the array is preallocated in both cases.
MozReview-Commit-ID: 3iVezeAKXnI
--HG--
extra : rebase_source : 9c3deec6d7aafd6411044d623d4863637b45fd58
2017-04-20 12:57:48 -07:00
Emilio Cobos Álvarez
de9ddcaddd
Bug 1355351: Add a node property to access the ::before and ::after pseudo-elements. r=heycam
...
MozReview-Commit-ID: FJxJp2U0Lxh
--HG--
extra : rebase_source : 062f952aafcda95ca3b0eba69389999c20cb4458
2017-04-16 17:29:49 +02:00
Xidorn Quan
92e0c75164
Bug 1323153 - Not include ElementInlines in headers. r=smaug
...
MozReview-Commit-ID: Gusow6LTiJI
--HG--
extra : rebase_source : 89f6c2b02dda7d216dfe6ff4ed27e8d70cd064f3
2016-12-13 18:11:04 +11:00
Andrew McCreight
9e8f4b219e
Bug 1152551, part 2 - Fix mode lines in dom/. r=jst
2015-05-03 15:32:37 -04:00
Ehsan Akhgari
883849ee32
Bug 1145631 - Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree; r=froydnj
...
This patch was automatically generated using the following script:
function convert() {
echo "Converting $1 to $2..."
find . \
! -wholename "*/.git*" \
! -wholename "obj-ff-dbg*" \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert MOZ_OVERRIDE override
convert MOZ_FINAL final
2015-03-21 12:28:04 -04:00
Boris Zbarsky
dc24477d79
Bug 1117172 part 3. Change the wrappercached WrapObject methods to allow passing in aGivenProto. r=peterv
...
The only manual changes here are to BindingUtils.h, BindingUtils.cpp,
Codegen.py, Element.cpp, IDBFileRequest.cpp, IDBObjectStore.cpp,
dom/workers/Navigator.cpp, WorkerPrivate.cpp, DeviceStorageRequestChild.cpp,
Notification.cpp, nsGlobalWindow.cpp, MessagePort.cpp, nsJSEnvironment.cpp,
Sandbox.cpp, XPCConvert.cpp, ExportHelpers.cpp, and DataStoreService.cpp. The
rest of this diff was generated by running the following commands:
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObjectInternal\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapNode\((?:aCx|cx|aContext|aCtx|js))\)/\1, aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(WrapObject\(JSContext *\* *(?:aCx|cx|aContext|aCtx|js))\)/\1, JS::Handle<JSObject*> aGivenProto)/g'
find . -name "*.h" -o -name "*.cpp" | xargs perl -pi -e 'BEGIN { $/ = undef } s/(Binding(?:_workers)?::Wrap\((?:aCx|cx|aContext|aCtx|js), [^,)]+)\)/\1, aGivenProto)/g'
2015-03-19 10:13:33 -04:00
Ehsan Akhgari
0653303071
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
...
--HG--
extra : rebase_source : 01709017e97fdc96d1d53eb881efc1792118edc4
2014-09-01 20:49:25 -04:00
Phil Ringnalda
117bb1a341
Backed out 6 changesets (bug 1060982
, bug 1061058, bug 1060987, bug 1061060, bug 1060930) for build bustage
...
CLOSED TREE
Backed out changeset c23b8418e6be (bug 1060987)
Backed out changeset a8cddc6bdffc (bug 1061060)
Backed out changeset b5af5cbdac3f (bug 1060982
)
Backed out changeset 4912d451011a (bug 1060930)
Backed out changeset bdacbf453238 (bug 1061058)
Backed out changeset da6c71a8f5ae (bug 1060987)
2014-09-01 16:48:51 -07:00
Ehsan Akhgari
6c932dea6c
Bug 1060987 - Fix more bad implicit constructors in DOM; r=baku
2014-09-01 18:00:53 -04:00
Birunthan Mohanathas
0c516988d6
Bug 946065 - Part 6: Move content/xml/ to dom/ and flatten subdirectories. r=jst
...
--HG--
rename : content/xml/content/src/CDATASection.cpp => dom/xml/CDATASection.cpp
rename : content/xml/content/src/CDATASection.h => dom/xml/CDATASection.h
rename : content/xml/content/src/ProcessingInstruction.cpp => dom/xml/ProcessingInstruction.cpp
rename : content/xml/content/src/ProcessingInstruction.h => dom/xml/ProcessingInstruction.h
rename : content/xml/document/src/XMLDocument.cpp => dom/xml/XMLDocument.cpp
rename : content/xml/document/src/XMLDocument.h => dom/xml/XMLDocument.h
rename : content/xml/content/src/XMLStylesheetProcessingInstruction.cpp => dom/xml/XMLStylesheetProcessingInstruction.cpp
rename : content/xml/content/src/XMLStylesheetProcessingInstruction.h => dom/xml/XMLStylesheetProcessingInstruction.h
rename : content/xml/document/crashtests/136896-1.xml => dom/xml/crashtests/136896-1.xml
rename : content/xml/document/crashtests/185285-1.xml => dom/xml/crashtests/185285-1.xml
rename : content/xml/document/crashtests/382636-1.xml => dom/xml/crashtests/382636-1.xml
rename : content/xml/document/crashtests/382636-2.svg => dom/xml/crashtests/382636-2.svg
rename : content/xml/document/crashtests/382636-3.xhtml => dom/xml/crashtests/382636-3.xhtml
rename : content/xml/document/crashtests/382636-4.xul => dom/xml/crashtests/382636-4.xul
rename : content/xml/content/crashtest/420429.xul => dom/xml/crashtests/420429.xul
rename : content/xml/document/crashtests/431703-1.xhtml => dom/xml/crashtests/431703-1.xhtml
rename : content/xml/content/crashtest/453278-frame.xml => dom/xml/crashtests/453278-frame.xml
rename : content/xml/content/crashtest/453278.html => dom/xml/crashtests/453278.html
rename : content/xml/content/crashtest/803586.xhtml => dom/xml/crashtests/803586.xhtml
rename : content/xml/document/crashtests/994740-1.xhtml => dom/xml/crashtests/994740-1.xhtml
rename : content/xml/document/crashtests/crashtests.list => dom/xml/crashtests/crashtests.list
rename : content/xml/document/crashtests/tree.gif => dom/xml/crashtests/tree.gif
rename : content/xml/content/src/htmlmathml-f.ent => dom/xml/htmlmathml-f.ent
rename : content/xml/content/src/moz.build => dom/xml/moz.build
rename : content/xml/document/public/nsIXMLContentSink.h => dom/xml/nsIXMLContentSink.h
rename : content/xml/document/src/nsXMLContentSink.cpp => dom/xml/nsXMLContentSink.cpp
rename : content/xml/document/src/nsXMLContentSink.h => dom/xml/nsXMLContentSink.h
rename : content/xml/content/src/nsXMLElement.cpp => dom/xml/nsXMLElement.cpp
rename : content/xml/content/src/nsXMLElement.h => dom/xml/nsXMLElement.h
rename : content/xml/document/src/nsXMLFragmentContentSink.cpp => dom/xml/nsXMLFragmentContentSink.cpp
rename : content/xml/document/src/nsXMLPrettyPrinter.cpp => dom/xml/nsXMLPrettyPrinter.cpp
rename : content/xml/document/src/nsXMLPrettyPrinter.h => dom/xml/nsXMLPrettyPrinter.h
rename : content/xml/document/resources/XMLMonoPrint.css => dom/xml/resources/XMLMonoPrint.css
rename : content/xml/document/resources/XMLPrettyPrint.css => dom/xml/resources/XMLPrettyPrint.css
rename : content/xml/document/resources/XMLPrettyPrint.xml => dom/xml/resources/XMLPrettyPrint.xml
rename : content/xml/document/resources/XMLPrettyPrint.xsl => dom/xml/resources/XMLPrettyPrint.xsl
rename : content/xml/document/resources/jar.mn => dom/xml/resources/jar.mn
rename : content/xml/document/resources/moz.build => dom/xml/resources/moz.build
rename : content/xml/document/test/file_bug293347.xml => dom/xml/test/file_bug293347.xml
rename : content/xml/document/test/file_bug293347xslt.xml => dom/xml/test/file_bug293347xslt.xml
rename : content/xml/document/test/mochitest.ini => dom/xml/test/mochitest.ini
rename : content/xml/document/test/moz.build => dom/xml/test/moz.build
rename : content/xml/tests/books/bethlehem.gif => dom/xml/test/old/books/bethlehem.gif
rename : content/xml/tests/books/bill.gif => dom/xml/test/old/books/bill.gif
rename : content/xml/tests/books/books.js => dom/xml/test/old/books/books.js
rename : content/xml/tests/books/books.xml => dom/xml/test/old/books/books.xml
rename : content/xml/tests/books/charing.gif => dom/xml/test/old/books/charing.gif
rename : content/xml/tests/books/classic.css => dom/xml/test/old/books/classic.css
rename : content/xml/tests/books/common.css => dom/xml/test/old/books/common.css
rename : content/xml/tests/books/kerouac.gif => dom/xml/test/old/books/kerouac.gif
rename : content/xml/tests/books/list.css => dom/xml/test/old/books/list.css
rename : content/xml/tests/books/road.gif => dom/xml/test/old/books/road.gif
rename : content/xml/tests/books/welville.gif => dom/xml/test/old/books/welville.gif
rename : content/xml/tests/docbook.css => dom/xml/test/old/docbook.css
rename : content/xml/tests/docbooktest.xml => dom/xml/test/old/docbooktest.xml
rename : content/xml/tests/flamer.gif => dom/xml/test/old/flamer.gif
rename : content/xml/tests/load/display.css => dom/xml/test/old/load/display.css
rename : content/xml/tests/load/display.xml => dom/xml/test/old/load/display.xml
rename : content/xml/tests/load/load.html => dom/xml/test/old/load/load.html
rename : content/xml/tests/load/loadauth.html => dom/xml/test/old/load/loadauth.html
rename : content/xml/tests/load/loaddisplay.html => dom/xml/test/old/load/loaddisplay.html
rename : content/xml/tests/load/test.xml => dom/xml/test/old/load/test.xml
rename : content/xml/tests/script.xml => dom/xml/test/old/script.xml
rename : content/xml/tests/simple.xml => dom/xml/test/old/simple.xml
rename : content/xml/tests/toc/book.css => dom/xml/test/old/toc/book.css
rename : content/xml/tests/toc/irslogo.gif => dom/xml/test/old/toc/irslogo.gif
rename : content/xml/tests/toc/minus.gif => dom/xml/test/old/toc/minus.gif
rename : content/xml/tests/toc/plus.gif => dom/xml/test/old/toc/plus.gif
rename : content/xml/tests/toc/rights.xml => dom/xml/test/old/toc/rights.xml
rename : content/xml/tests/toc/toc.css => dom/xml/test/old/toc/toc.css
rename : content/xml/tests/toc/toc.js => dom/xml/test/old/toc/toc.js
rename : content/xml/tests/xlink/auto.xml => dom/xml/test/old/xlink/auto.xml
rename : content/xml/tests/xlink/link.css => dom/xml/test/old/xlink/link.css
rename : content/xml/tests/xlink/manual.xml => dom/xml/test/old/xlink/manual.xml
rename : content/xml/tests/xmlbase/xmlbase.css => dom/xml/test/old/xmlbase/xmlbase.css
rename : content/xml/tests/xmlbase/xmlbase.xml => dom/xml/test/old/xmlbase/xmlbase.xml
rename : content/xml/document/test/test_bug232004.xhtml => dom/xml/test/test_bug232004.xhtml
rename : content/xml/document/test/test_bug293347.html => dom/xml/test/test_bug293347.html
rename : content/xml/document/test/test_bug343870.xhtml => dom/xml/test/test_bug343870.xhtml
rename : content/xml/document/test/test_bug355213.xhtml => dom/xml/test/test_bug355213.xhtml
rename : content/xml/document/test/test_bug392338.html => dom/xml/test/test_bug392338.html
rename : content/xml/document/test/test_bug399502.xhtml => dom/xml/test/test_bug399502.xhtml
rename : content/xml/document/test/test_bug445330.html => dom/xml/test/test_bug445330.html
rename : content/xml/document/test/test_bug691215.html => dom/xml/test/test_bug691215.html
rename : content/xml/document/test/test_viewport.xhtml => dom/xml/test/test_viewport.xhtml
2014-07-25 14:15:35 -07:00