In Bug 1419292, we make sure there is no issue when releasing
actors for the output messages, so the sidebar is probably
good to go on Nighly in order to get more feedback.
The test for context menu entries in the console was updated
since it now shows the "Open in sidebar" entry.
MozReview-Commit-ID: 8R3rhf944Fh
--HG--
extra : rebase_source : 8fa00b58b43dea52fbbbfffc29c2cfb7960b49d0
Take into account node offsets in browser_webconsole_object_inspector_local_session_storage.js.
MozReview-Commit-ID: 73waFejjsF0
--HG--
extra : rebase_source : d34e26c280f777e266ab7f014cfb9b41e07c9a5e
- Refactor the logic for getting the grid highlighter settings into HighlightersOverlay.js
- Refactor the grid area and cell highlight into a single function in grid-inspector.js
- Change the order of the parameters for onHighlighterChange in grid-inspector.js
- Get the last highlighted state from the Redux store instead of storing them in a variable
Extract loading the grid highlighter setting into HighlightersOverlay. This
allows the grid highlighter toggle in the rule view to also show the grid
highlighter with the currently set highlight settings if the grid inspector
has not been initiated yet.
This causes various changes to properties-db.js and also many devtools
tests get updated.
There are two changes affect multiple tests:
* `calc` gets removed from everywhere. We never have it listed in all
properties which deserve it, and doing so without much false positive
(i.e. properties don't deserve but get it) can be pretty tricky.
So they are just removed for now.
* The complete color keyword list is no longer included, and instead,
"COLOR" is prepended to the list directly. We can probably remove
the related code which replaces color keywords with "COLOR" from
devtools. Note that, with stylo enabled, the list is already unrelated
to what the parsing code uses. We should eventually re-enable the
disabled test here after we can get the color list from cssparser
in bug 1456715.
Other changes to properties-db.js seem to be valid, some of them also
affect tests:
* `{-webkit-,}align-{content,items,self}` get `first baseline`, `safe`,
`unsafe`, and lose `left` and `right`.
* `{-moz-,-webkit-,}{animation,transition}{,-timing-function}` has a
new `frame` keyword which is a function value in `<timing-function>`.
* `{background,{-webkit-,}mask}-position-x` lose `top` and `bottom`, and
correspondingly `{background,{-webkit-,}mask}-position-y` lose `left`
and `right`. They don't deserve those values.
* `{background,{-webkit-,}mask}{,-size}` get `auto`.
* `border` shorthand loses `<image>` values as well as other keyword
values for `border-image-*` subproperties, because they aren't parsed
on the shorthand.
* `{-moz-,}border-image{,-width}` get `auto`.
* `-moz-context-properties` gets `none`.
* `cursor` get some -moz-prefixed values as well as `url`.
* `fill` and `stroke` get the color keywords.
* `{-webkit-,}filter` get the keywords and function names.
* `font` shorthand loses values from many of `font-variant-*` properties
because they are not parsed there.
* `font-variant` and `font-variant-alternates` get function values of
the longhand.
* `font-variant-{east-asian,ligatures,numeric}` get `normal`, and
`font-variant-ligatures` in addition gets `none`.
`font-{feature,variation}-settings` also get `normal`.
* `grid` and `grid-template-{areas,columns,rows}` get `none`.
* `grid`, `grid-template`, and `grid-template-{columns,rows}` get
`auto`, `fit-content`, `minmax`, and `repeat`.
* `grid-auto-{columns,rows}` get `auto`, `fit-content` and `minmax`.
* `-moz-image-region` gets `auto` and `rect`.
* `{-webkit-,}justify-content` lose `baseline`, `last baseline`, and
get `safe` and `unsafe`.
* `{justify,place}-items` get `first baseline`, `legacy`, `safe`,
`unsafe` and lose `auto`.
* `{justify,place}-self` and `place-content` get `first baseline`,
`safe`, and `unsafe`.
* `outline{,-style}` get `hidden`.
* `scroll-snap-coordinate` gets `none`, and `scroll-snap-points-{x,y}`
gets `none` and `repeat`.
* `shape-outside`, `text-emphasis{,-style}` get all the keyword values
and function names they deserve.
* `stroke-dasharray` gets `none`.
* `text-combine-upright` drops `digits` which we never implemented.
* `{-moz-,-webkit-,}transform` and `-moz-window-transform` get their
transform function list. `accumulatematrix` and `interpolatematrix`
aren't real CSS value but they have `#[css(function)]` specified.
We should probably remove them at some point.
* `will-change` gets `auto`.
* All properties accept `<image>` value now gets -webkit-prefixed
gradient function names, including
* `background{,-image}`,
* `{-moz-,-webkit-,}border-image{,-source}`, and
* `{-webkit-,}mask{,-image}`.
MozReview-Commit-ID: E7Y0CFUFYgW
--HG--
extra : source : bab732c8c531cfca1bcd233f769c25bb2e373773
Manually-implemented QueryInterface functions don't benefit from the
MozQueryInterface optimizaions, and a lot of them are in hot code, and
implement a large number of interfaces.
MozReview-Commit-ID: 8OzglraowZt
--HG--
extra : rebase_source : 5fff3d9973a0ea976096339a63ce9ff628b68441
This also removes any redundant Ci.nsISupports elements in the interface
lists.
This was done using the following script:
acecb401b7/processors/chromeutils-generateQI.jsm
MozReview-Commit-ID: AIx10P8GpZY
--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
As far as I am aware, we can't create tests to detect whether an error has been thrown... especially if the error has no side affects.
If we really need a test for these simple four fixes you can always insist but I don't think we do.
MozReview-Commit-ID: 7j9N1X4jTHY
--HG--
extra : rebase_source : 95ce1cb4322fad250757db36a57272ccb328897d
- Extract font name and origin (URL + copy URL) into FontMeta component.
- Reuse FontMeta in font overview and font editor.
- Tweak CSS for improved spacing and flex-grow behaviour.
MozReview-Commit-ID: 4W2E48r8Yps
--HG--
extra : rebase_source : 5159468f943cb505fd1ca9aeb50954fbb690af07
This bounced because I was trying to access the toolbox after the ui was destroyed, which fails in tests. I will do a try run this time to make sure there are no issues.
MozReview-Commit-ID: 2iHpPLmm9lY
--HG--
extra : rebase_source : 42b0fbbfc26d43c49b699ef447c7650c94bd81ca
Nicolas Chevobbe
Mike Ratcliffe
Andreea Pavel
Jan Odvarko
Ciure Andrei
Bogdan Tara
Gabriel Luong
Jason Laster
Oriol Brufau
Mark Banner
Daisuke Akatsuka
Xidorn Quan
Kris Maglione
Csoregi Natalia
Dorel Luca
Cosmin Sabou
Boris Zbarsky
shindli
Razvan Caliman
arthur.iakab