d631c2329b
Bug 488417. Need to hold strong refs to ranges across calling RemoveRange. r+sr=roc
2009-04-21 15:57:40 -04:00
bff20cf17a
Bug 486547. Fix build bustage on Windows
2009-04-06 14:39:02 -04:00
15b0e0b5f3
Bug 486547 part 7. Simplify some more of the table code in nsFrameSelection. r+sr=smaug
2009-04-06 13:21:30 -04:00
aa115a4e74
Bug 486547 part 6. Simplify some cell-related code in nsFrameSelection. r+sr=smaug
2009-04-06 13:20:32 -04:00
17796c6f64
Bug 486547 part 5. Switch various table cell selection stuff off nsIDOMRange. r+sr=smaug
2009-04-06 13:20:30 -04:00
fe07c58568
Bug 486547 part 4. Switch some more code off nsIDOMNode/nsIDOMRange r+sr=smaug
2009-04-06 13:17:38 -04:00
75e8ba1c24
Bug 486547 part 3. Eliminate the Fetch*Node methods of nsTypedSelection. r+sr=smaug
2009-04-06 13:17:38 -04:00
f92fc0c496
Bug 486547 part 2. Switch nsFrameSelection::mMaintainRange to storing nsIRange, not nsIDOMRange. r+sr=smaug
2009-04-06 13:17:38 -04:00
081b4b02e7
Bug 486547 part 1. Switch nsTypedSelection to storing nsIRange, not nsIDOMRange, objects. r+sr=smaug
2009-04-06 13:17:37 -04:00
b6cf78a6a8
Bug 478245 - Crash [@ nsEventStateManager::PreHandleEvent], r+sr=dbaron
2009-03-11 17:43:08 +02:00
58e1a51801
Bug 466856 - Crash [@ nsTypedSelection::CopyRangeToAnchorFocus], r+sr=roc
2009-02-26 18:36:34 +02:00
122dcedc98
Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz.
2009-01-14 13:24:10 +01:00
c31332c26a
Back out changeset 9fd8740decb8 (Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles).) to try to fix orange.
2009-01-14 15:12:37 +01:00
2353ea8945
Fix for bug 471126 (leak content nodes (and sometimes dom windows) after clicking on nytimes.com articles). r=bent, sr=bz.
2009-01-14 13:24:10 +01:00
3498a5f86e
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
nsITextControlFrame didn't have an IID the first time around, but this wasn't a compile error because nsITextControlFrame::kFrameIID inherited from nsIFormControlFrame::kFrameIID. I've added a static analysis pass to verify the correct behavior, since I can't figure out a way to make the compiler do it.
--HG--
extra : rebase_source : 4894a2ca0278e2ab92f27459db77165f8348cf41
2009-01-12 14:20:59 -05:00
73a6fab34b
Backed out changeset 4c4df6ed1b41 - Bug 396185 - Make nsIFrame not inherit from nsISupports due to mochitest failures... these appear to be crashes in nsGenericHTMLElement::GetEditorInternal.
2009-01-09 11:35:24 -05:00
802d1a10c7
Bug 396185 - Make nsIFrame derivatives and helper abstract classes use a different dynamic-cast system than nsISupports:
...
* we know all types frames may be cast to at compile time, so instead of extensible GUID IIDs, use a big enum (see nsQueryFrame::FrameIID)
* eliminate all vestiges of refcounting, since frames aren't refcounted
Some frames (SVG frames in particular) still implement nsISupports-derived interfaces, for example nsISVGValue. There is a FrameIID for nsISVGValue that lets you go from a frame to the XPCOM interface, but you can't query back.
r+sr=roc
This patch locally causes two REFTEST-UNEXPECTED-PASS for Bidi stuff. It's possible that I accidentally fixed a bug, but I'm not sure, so I'm going to wait for the tinderboxes to confirm my local results.
2008-11-05 14:25:30 -05:00
030cd64a09
Set mMaintainRange to null when there is no selection. b=470212 r=mats sr=roc
2009-01-08 22:17:49 +01:00
4097da34ae
Don't crash if views were destroyed while flushing notifications. b=421839 r+sr=roc
2008-12-08 00:11:37 +01:00
5ab3bffacb
b=461813, crash in nsFrameSelection::HandleDrag; r+sr=roc
2008-11-04 11:29:13 -08:00
1b2252f6c6
Bug 462793 - Changing listbox selection with keyboard no longer scrolls to make the newly selected item visible, r+sr=roc
2008-11-04 15:38:16 +01:00
bb3bf9ec94
Bug 461212 - deCOM frame traversal (relanding) r=mats.palmgren sr=roc
2008-10-30 10:15:22 -07:00
555c5a8f1c
Backed out changeset affcc1c08bc0 (deCOM frame enumerator) due to regression from it or bug 461410.
2008-10-28 02:47:40 -04:00
2127dcfc13
Bug 461212 - deCOM frame enumerator, r=mats.palmgren sr=roc
2008-10-28 00:47:19 -04:00
2ed96f2ef8
Bug 459921 - Double-click-and-drag selects previous word when dragging to left half of first letter of a word. r+sr=roc.
2008-10-21 11:52:52 +02:00
269b19b637
Bug 415707 - multiple text selection improvement doesn't work with double-click "word-by-word" or triple-click "paragraph" modes. r+sr=roc.
2008-10-17 21:46:33 +02:00
88e1b95b7b
Bug 157546. The 'delete' key should delete an entire cluster. r=peterv,r+sr=roc
2008-10-16 20:44:32 +13:00
3cba110fca
bug 302775 - extractContents doesn't work if start and end node of a Range object is an attribute node, r=peterv, sr=sicking
2008-10-15 12:40:28 +03:00
ce54716f69
Bug 459660: Remove two unused members of nsTypedSelection and their accessors. r+sr=roc.
2008-10-13 23:25:21 +02:00
3f918b6ada
Bug 459588: Kill OLD_SELECTION code. r+sr=roc.
2008-10-13 00:11:51 +02:00
3481ddfc0c
Bug 426766: Cursor keys behave weirdly in "view source" window. r+sr=roc.
2008-10-09 12:07:16 +02:00
361456a3f9
Bug 458089: Kill VISUALSELECTION code. r=smontagu, sr=roc.
2008-10-09 12:05:30 +02:00
5ac5f8dad5
Bug 456944 - Crash when spell checking selection changes, r=smaug, sr=roc
2008-10-08 20:53:14 +08:00
bc94c13609
Bug 451252 - "Highlight All" find selection not visible in elements that have -moz-user-select: none set; r+sr=roc
2008-09-07 16:12:50 +02:00
8c80506f1c
Merge commit for bug 210197
2008-08-09 19:34:08 +03:00
514fbf8ecc
Unconditionally reset mDragSelectingCells to false on mouse-up, so that the system doesn't remain in table selection mode when dragging outside a table. bug=210197. r+sr=mats.palmgren
2008-08-09 18:09:37 +03:00
c9d1d9a951
Bug 263683 - Findbar's Highlight feature should not manipulate the DOM. Patch by Graeme McCutcheon <graememcc_firefox@graeme-online.co.uk>, r=me,roc. sr=roc.
2008-07-30 23:48:56 +03:00
d6ba6d4413
bug 345759 - Spell as you type not accessible, r=aaronlev, r=Olli.Pettay, sr=neil
2008-07-17 14:06:24 +02:00
b006229ae6
Bug 419532 – deCOMtaminate nsICaret. r+sr=roc
2008-07-16 12:52:01 +02:00
556cf36dc9
Bug 442729 - Annotate stack-only classes in layout, r+sr=roc
2008-07-01 15:16:45 -04:00
908c443de8
Bug 423523: Caret can leave div w/ contenteditable = true with repeated arrow keys, patch by Chris Pearce <chris@pearce.org.nz>, r+sr=peterv, a=beltzner
2008-04-23 15:33:14 -07:00
4589e85ab3
Backout bug 157546 (making the delete key delete by clusters) to fix blockers bug 419217 and bug 419406. Instead of removing the added test, mark now-failing tests as todo. a=damons
2008-04-14 18:04:18 -07:00
1f2fa3ef01
When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest (v3) by Martijn Wargers.
2008-03-31 10:47:42 -07:00
8563131a37
reverting fix for 392746 due to unexplained failure of /tests/toolkit/content/tests/widgets/test_colorpicker_popup.xul
2008-03-30 14:55:37 -07:00
06d2ad2c92
When adding a range to the selection, set the anchor focus to the added range, rather than the last range in the selection. bug=392746 r+sr=roc a1.9=beltzner. Mochitest by Martijn Wargers.
2008-03-30 11:13:29 -07:00
1c98c2e245
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) (retry) r+sr=roc, a1.9b4=beltzner
2008-02-28 07:28:37 -08:00
076b8bba8e
backing out the previous patch, becaused qm-centos5-01 dep unit test is orange
2008-02-28 05:59:25 -08:00
600836e7ed
Bug 418470 Go to line in View Source broken (NS_ERROR_UNEXPECTED at nsISelectionController.scrollSelectionIntoView) r+sr=roc, a1.9b4=beltzner
2008-02-28 03:01:56 -08:00
decb9c279b
Make nsTypedSelection ctors initialize all members (fixes an UMR) and reorder members to save space. b=417895 r+sr=roc a=blocking1.9
2008-02-26 07:04:14 -08:00
709741beff
Bug 157546. 'Delete' key should delete entire cluster. patch by Theppitak Karoonboonyanan, r+sr=roc,a=schrep
2008-02-21 18:24:04 -08:00
Boris Zbarsky
Olli Pettay
Peter Van der Beken
Benjamin Smedberg
Uri Bernstein
Mats Palmgren
Vladimir Vukicevic
Markus Stange
Theppitak Karoonboonyanan
Alexander Surkov
Graeme McCutcheon
Asaf Romano
John Daniels
gavin@gavinsharp.com
dbaron@dbaron.org
masayuki@d-toybox.com
roc+@cs.cmu.edu