CRASH_MANAGER_PROCESS_PINGS is modified to substitute only the properties of
the object, in order to let eslint use the `processPings` local variable while
linting CrashManager.in.jsm.
Also applied the eslint --fix.
Differential Revision: https://phabricator.services.mozilla.com/D144788
Since the dumps don't contain tombstones, this prevents situations where the dump would not be reloaded (with `loadDumpIfNewer`) if the last operation on the collection is a delete.
Differential Revision: https://phabricator.services.mozilla.com/D144428
Since the dumps don't contain tombstones, this prevents situations where the dump would not be reloaded (with `loadDumpIfNewer`) if the last operation on the collection is a delete.
Differential Revision: https://phabricator.services.mozilla.com/D144428
Add a property `openDownloadsListOnStart` to the download object
prototype. It is true by default. When passed a false value, it will
prevent the usual behavior of opening the downloads panel when the
download starts. This will allow some (forthcoming) internal code in the
WebExtensions API to prevent showing the downloads panel when a download
is created without any user input (see bug 1759231 for details).
Differential Revision: https://phabricator.services.mozilla.com/D142503
It seems the new tab-modal printing code doesn't actually use this. Instead it
relies on the window being closed (see cancelPrint() in
toolkit/components/printing/content/print.js ).
Differential Revision: https://phabricator.services.mozilla.com/D144821
This increases the minimum resolution to 1080 and dropped the ratio to
1% from 5%. This should give a better video playback experience for
people using resist fingerprinting and better matches the values that
clients without that pref give.
Differential Revision: https://phabricator.services.mozilla.com/D142842
dom/system/PathUtils.cpp(77,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
ipc/chromium/src/chrome/common/ipc_channel_win.cc(479,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return true;
^~~~
mozglue/misc/PreXULSkeletonUI.cpp(1263,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
mozglue/tests/TestPEExportSection.cpp(348,12): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
security/manager/ssl/OSReauthenticator.cpp(428,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return NS_OK;
^~~~~
toolkit/components/maintenanceservice/maintenanceservice.cpp(214,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return 0;
^
widget/windows/WindowsUIUtils.cpp(383,10): error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
return false;
^~~~~
Differential Revision: https://phabricator.services.mozilla.com/D144661
Nearly all the complexity here is abstracted away in the previous patch, so this is quite straightforward other than the one oddity noted in the comments.
Differential Revision: https://phabricator.services.mozilla.com/D143112
Bug 1757395 basically removed the reason for PPrinting to exist. What remained
essentially just added an unnecessary layer of complexity/indirection to the
creation of PRmotePrintJob actors.
Differential Revision: https://phabricator.services.mozilla.com/D143330
The expandable overflow fields in the cert viewer have 0px border and 1px
padding by default, and 1px border and 0px padding on hover. Since subpixel
borders are calculated differently from subpixel padding, this causes different
results when window scaling factor is not an integer multiple of 1.
For 1.5x scaling, an input 1px padding can yield either 2px or 1px output
depending on results of scaling algorithm, but an input 1px border will only
yield a 1px output, in order to keep the border crisp and symmetric on every
edge of the bounding box. So when we hover the long hex field, it may lose 1-2
pixels of height as ~1.5px worth of padding (between 1px and 2px) is replaced
with exactly 1px of border.
Patch will fix this by just replacing the 1px padding with a 1px transparent
border. That way the field's height is a function of the same scaling scheme in
all states, so won't change on hover.
Differential Revision: https://phabricator.services.mozilla.com/D139563
Emilio Cobos Álvarez
Tooru Fujisawa
Mark Banner
Jeff Muizelaar
Noemi Erli
Cristian Tuns
Mathieu Leplatre
Butkovits Atila
Shane Hughes
Luca Greco
Marian-Vasile Laza
Jonathan Watt
Paul Zuehlcke
Molnar Sandor
Tomislav Jovanovic
Tim Giles
Mike Hommey
Ben Hearsum
William Durand
Csoregi Natalia
Calixte
Barret Rennie
Mike Conley
Florian Quèze
Katherine Patenio
Tim Huang
Narcis Beleuzu