Граф коммитов

5820 Коммитов

Автор SHA1 Сообщение Дата
Nathan Froyd 60e1125026 Bug 1448027 - make constructors in the profiler explicit; r=mstange
Attempting to stand up the static analysis for Android builds revealed
that we weren't being explicit enough.
2018-03-27 10:51:32 -04:00
Markus Stange 7b785f663d Bug 1439014 - Add a profiler feature to enable JIT optimization tracking. r=njn,sfink
MozReview-Commit-ID: LDxiLVp7e9v

--HG--
extra : rebase_source : efefa814a050f06217de30704976048eeacc3caa
extra : intermediate-source : b58a6dce6a4e46ccfdbed363c67e2fa79043086b
extra : source : 6d91d0cc7d61af160b2ccd340adf23cb41389eed
2018-02-17 19:38:14 -05:00
Markus Stange 016eb6c26a Bug 1335191 - Position sheets using the NSWindowDelegate method window:willPositionSheet:usingRect:. r=spohl
MozReview-Commit-ID: 1Dwwdvl6Fok

--HG--
extra : rebase_source : 916b639fe3a18af819cb3f680501abbbe0d9bf87
2018-03-23 17:50:02 -04:00
arthur.iakab 5beb4527ab Backed out 2 changesets (bug 1439014) for failing mochitest chrome and test verify on tools/profiler/tests/chrome/test_profile_with_trackopts.html
Backed out changeset 57426696adaf (bug 1439014)
Backed out changeset a13074f87bb0 (bug 1439014)
2018-03-27 06:48:42 +03:00
Markus Stange 7a3f577c15 Bug 1439014 - Add a test that checks for the presence of JS tracked optimization info. r=julienw
MozReview-Commit-ID: ETJGZPhMfLv

--HG--
extra : rebase_source : 5a16a1226357dffa08fb6d348395fef6216488c6
2018-03-26 19:34:50 -04:00
Markus Stange 42fcb730e2 Bug 1439014 - Add a profiler feature to enable JIT optimization tracking. r=njn,sfink
MozReview-Commit-ID: LDxiLVp7e9v

--HG--
extra : rebase_source : b6d0ba745de702a88310278fd9ec0cd56205f463
extra : intermediate-source : b58a6dce6a4e46ccfdbed363c67e2fa79043086b
extra : source : 6d91d0cc7d61af160b2ccd340adf23cb41389eed
2018-02-17 19:38:14 -05:00
arthur.iakab bb69fe14b5 Backed out 2 changesets (bug 1439014) for failing mochitest chrome and test verify on tools/profiler/tests/chrome/test_profile_with_trackopts.html on a CLOSED TREE
Backed out changeset 226c8c740c34 (bug 1439014)
Backed out changeset 84c9b5ab7de9 (bug 1439014)
2018-03-27 02:16:17 +03:00
Andrew Swan eaa4aed34f Bug 1448070 Sign quitter.xpi as privileged r=kmag
MozReview-Commit-ID: FuNNtBSZwc

--HG--
extra : rebase_source : 9426318458d58dccd4352503de27ba2b809e5bb2
2018-03-26 10:57:04 -07:00
Markus Stange c11697a2a1 Bug 1439014 - Add a test that checks for the presence of JS tracked optimization info. r=julienw
MozReview-Commit-ID: ETJGZPhMfLv

--HG--
extra : rebase_source : 9cad953532ceeb41db40978a3ea90fa46874f77e
2018-03-26 17:03:43 -04:00
Markus Stange 6f36cc5745 Bug 1439014 - Add a profiler feature to enable JIT optimization tracking. r=njn,sfink
MozReview-Commit-ID: LDxiLVp7e9v

--HG--
extra : rebase_source : b6d0ba745de702a88310278fd9ec0cd56205f463
extra : intermediate-source : b58a6dce6a4e46ccfdbed363c67e2fa79043086b
extra : source : 6d91d0cc7d61af160b2ccd340adf23cb41389eed
2018-02-17 19:38:14 -05:00
arthur.iakab bfec308dac Backed out 2 changesets (bug 1439014) for failing chrome failures and test verify tests on tools/profiler/tests/chrome/test_profile_with_trackopts.htm on a CLOSED TREE
Backed out changeset f01eb749b3f9 (bug 1439014)
Backed out changeset 6d264bbb2669 (bug 1439014)
2018-03-26 23:26:15 +03:00
Markus Stange 4d16000195 Bug 1439014 - Add a test that checks for the presence of JS tracked optimization info. r=julienw
MozReview-Commit-ID: ETJGZPhMfLv

--HG--
extra : rebase_source : 3725265ca37938481cf4d5f19bf10f60b6cda1fc
2018-03-26 14:32:27 -04:00
Markus Stange dd133bbe22 Bug 1439014 - Add a profiler feature to enable JIT optimization tracking. r=njn,sfink
MozReview-Commit-ID: LDxiLVp7e9v

--HG--
extra : rebase_source : b6d0ba745de702a88310278fd9ec0cd56205f463
extra : intermediate-source : b58a6dce6a4e46ccfdbed363c67e2fa79043086b
extra : source : 6d91d0cc7d61af160b2ccd340adf23cb41389eed
2018-02-17 19:38:14 -05:00
Andi-Bogdan Postelnicu a5f81f6a72 Bug 1448382 - Add js/src/vtune/ to the ThirdPartyPaths and .clang-format-ignore. r=sylvestre
MozReview-Commit-ID: 4Tni5V4K9Tv

--HG--
extra : rebase_source : cd2f899936b5e71211d71e3237d2619365cd63a2
2018-03-23 21:38:55 +02:00
Mark Banner f1ed0a2b70 Bug 1447944 - Enable ESLint rule no-undef for test files in devtools/server/tests/unit/. r=jdescottes
MozReview-Commit-ID: JBtDdAUraQ2

--HG--
extra : rebase_source : 544ada916f5d3fd41f57225b19897d6b21407425
2018-03-22 10:59:26 +00:00
Emilio Cobos Álvarez e341b20ec4 Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt on a CLOSED TREE
MozReview-Commit-ID: JPopq0LudD
2018-03-22 20:06:24 +01:00
Emilio Cobos Álvarez 5dd797f154 Back out changeset b683bb3f22a1 (Bug 1447483) for not landing with all the files. r=me on a CLOSED TREE
This reverts commit 1808914126bb9f9e4a82d2c3d7ac961885fe7d62.

MozReview-Commit-ID: 5skESBseEvo
2018-03-22 20:05:22 +01:00
Emilio Cobos Álvarez ca5ac79cca Bug 1447483: Merge nsStyleContext and ServoStyleContext, rename to ComputedStyle. r=jwatt
MozReview-Commit-ID: JPopq0LudD
2018-03-22 19:48:42 +01:00
Kris Maglione 946e1ef0b5 Bug 1446676: Part 2 - Update non-overlay automation extensions to be bootstrapped. r=Mossop
In order to remove support for non-bootstrapped extensions, the remaining test
automation extensions need to be migrated to bootstrapped extensions. These
extensions all work by loading a single component, either with a
profile-after-change or command line handler. This is a straightforward
conversion of those components to bootstrap.js scripts.

MozReview-Commit-ID: 5uyNSqRPIVR

--HG--
rename : services/sync/tps/extensions/tps/components/tps-cmdline.js => services/sync/tps/extensions/tps/bootstrap.js
rename : testing/talos/talos/pageloader/components/tp-cmdline.js => testing/talos/talos/pageloader/bootstrap.js
rename : testing/talos/talos/startup_test/sessionrestore/addon/SessionRestoreTalosTest.js => testing/talos/talos/startup_test/sessionrestore/addon/bootstrap.js
rename : testing/talos/talos/talos-powers/components/TalosPowersService.js => testing/talos/talos/talos-powers/bootstrap.js
rename : tools/quitter/QuitterObserver.js => tools/quitter/bootstrap.js
extra : rebase_source : 738264d0ec8701aa5cf93c6dac958d88756c1e55
extra : source : 71d65d6b64997bc608a1cb3c924be35bbd460b39
2018-03-16 22:06:22 -07:00
arthur.iakab 5e8092339a Merge mozilla-central to inbound
--HG--
rename : browser/base/content/test/general/bug364677-data.xml => browser/components/feeds/test/bug364677-data.xml
rename : browser/base/content/test/general/bug364677-data.xml^headers^ => browser/components/feeds/test/bug364677-data.xml^headers^
rename : browser/base/content/test/general/test_bug364677.html => browser/components/feeds/test/test_bug364677.html
rename : services/sync/tps/extensions/tps/bootstrap.js => services/sync/tps/extensions/tps/components/tps-cmdline.js
rename : testing/talos/talos/pageloader/bootstrap.js => testing/talos/talos/pageloader/components/tp-cmdline.js
rename : testing/talos/talos/startup_test/sessionrestore/addon/bootstrap.js => testing/talos/talos/startup_test/sessionrestore/addon/SessionRestoreTalosTest.js
rename : testing/talos/talos/talos-powers/bootstrap.js => testing/talos/talos/talos-powers/components/TalosPowersService.js
rename : tools/quitter/bootstrap.js => tools/quitter/QuitterObserver.js
extra : rebase_source : 5801e95a945b54754f27571e7b211e1eac132d67
2018-03-21 22:27:21 +02:00
Sebastian Hengst 65d6e8f735 Backed out 5 changesets (bug 1446676) for timeouts in talos-chrome-profiling on OS X. a=backout
Backed out changeset 5d3eb0526d8b (bug 1446676)
Backed out changeset d6bda91c66d6 (bug 1446676)
Backed out changeset 71d65d6b6499 (bug 1446676)
Backed out changeset aabfc0197692 (bug 1446676)
Backed out changeset ad8214a6cf04 (bug 1446676)

--HG--
rename : services/sync/tps/extensions/tps/bootstrap.js => services/sync/tps/extensions/tps/components/tps-cmdline.js
rename : testing/talos/talos/pageloader/bootstrap.js => testing/talos/talos/pageloader/components/tp-cmdline.js
rename : testing/talos/talos/startup_test/sessionrestore/addon/bootstrap.js => testing/talos/talos/startup_test/sessionrestore/addon/SessionRestoreTalosTest.js
rename : testing/talos/talos/talos-powers/bootstrap.js => testing/talos/talos/talos-powers/components/TalosPowersService.js
rename : tools/quitter/bootstrap.js => tools/quitter/QuitterObserver.js
2018-03-21 20:51:03 +02:00
Tiberius Oros 649398dfd9 Merge inbound to mozilla-central. a=merge 2018-03-21 12:03:08 +02:00
J. Ryan Stinnett 0cee298854 Bug 1446222 - Move DevTools content process startup to new dir. r=jdescottes
Move and rename the server's process script (and accompanying JSM) that starts
DevTools for an entire content process from `content-process-debugger-server.js`
to `startup/content-process.js`.  `connectToContent` also becomes the more
specific `connectToContentProcess`.

These code paths will likely change more as Site Isolation work continues, but
for now, we have this light cleanup to gather startup-related paths together.

MozReview-Commit-ID: 1evbZMB8T7r

--HG--
rename : devtools/server/content-process-debugger-server.js => devtools/server/startup/content-process.js
rename : devtools/server/content-server.jsm => devtools/server/startup/content-process.jsm
extra : rebase_source : e077dd3dc915ec274f866d53d3539909f8440de1
2018-03-19 21:28:26 -05:00
Peter Van der Beken f5754d679a Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz.
--HG--
extra : rebase_source : 5911f91bd7a63cd3603494e087e3858bd0527500
2018-03-01 20:19:56 +01:00
Kris Maglione c69ba360c1 Bug 1446676: Part 2 - Update non-overlay automation extensions to be bootstrapped. r=Mossop
In order to remove support for non-bootstrapped extensions, the remaining test
automation extensions need to be migrated to bootstrapped extensions. These
extensions all work by loading a single component, either with a
profile-after-change or command line handler. This is a straightforward
conversion of those components to bootstrap.js scripts.

MozReview-Commit-ID: 5uyNSqRPIVR

--HG--
rename : services/sync/tps/extensions/tps/components/tps-cmdline.js => services/sync/tps/extensions/tps/bootstrap.js
rename : testing/talos/talos/pageloader/components/tp-cmdline.js => testing/talos/talos/pageloader/bootstrap.js
rename : testing/talos/talos/startup_test/sessionrestore/addon/SessionRestoreTalosTest.js => testing/talos/talos/startup_test/sessionrestore/addon/bootstrap.js
rename : testing/talos/talos/talos-powers/components/TalosPowersService.js => testing/talos/talos/talos-powers/bootstrap.js
rename : tools/quitter/QuitterObserver.js => tools/quitter/bootstrap.js
extra : rebase_source : 2df7dce1afe4e9e4054d12adfc1553e5f5d417e2
2018-03-16 22:06:22 -07:00
Emilio Cobos Álvarez e9676561ce Bug 1446954: Remove support for running tests on automation without stylo configurations. r=froydnj
You can still run them on a --disable-stylo build, as long as that works
(presumably not for long).

I think I haven't missed anything, but please double-check.

MozReview-Commit-ID: 3BIAEjgTLo5
2018-03-20 11:29:08 +01:00
Mark Banner 60f8abf420 Bug 1443093 - Change the update.sh scripts to use in-tree tooltool.py and update the node_modules bundles on the servers. r=mossop
MozReview-Commit-ID: HQLRoOYVjXo

--HG--
extra : rebase_source : 9f2d7925f3f75b6d488056d4e03af92ce63d433c
2018-03-19 10:18:49 +00:00
Mark Banner 0f3ec963be Bug 1443093 - Update eslint-plugin-no-unsanitized to 3.0.0 / eslint to 4.18.2. r=mossop
Also change eslint-plugin-mozilla's globals.js to use eslint-scope rather than escope as
ESLint 4.x changed to eslint-scope. This avoids dependency issues that were masked by the
depedencies of eslint-plugin-no-unsanitized's previous version.

MozReview-Commit-ID: 6wLY7Oj0am3

--HG--
extra : rebase_source : 863313d7907e8246d1f5b0ee83164cc0f943f8f6
2018-03-05 10:34:38 +00:00
Bogdan Tara 7eb4cdd58d Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-03-17 12:34:09 +02:00
Bogdan Tara 4785e99532 Merge inbound to mozilla-central. a=merge 2018-03-17 12:29:57 +02:00
Kris Maglione 313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
2018-03-07 19:31:28 -08:00
Gurzau Raul 3057041352 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-03-16 19:58:27 +02:00
Sylvestre Ledru b5f9522581 Bug 1438839 - Finish the flake8 fixes on tools/ r=ahal
MozReview-Commit-ID: F9c4laxe8Pt

--HG--
extra : rebase_source : ed304bcf485a448e863b9bbc82427ae5a88ea2c2
extra : histedit_source : 2c8e0beefee259fe7a31e0436e7a94519a3e05ae
2018-03-15 11:31:12 +01:00
Sylvestre Ledru a0ab39f145 Bug 1438839 - Fix the remaining flake8 issues by hand r=ahal
MozReview-Commit-ID: Fv1MZIpCL8Z

--HG--
extra : rebase_source : 804567a78a5696997e2aa511814a4f8ff22d9c31
extra : histedit_source : 88401e831d81708b6ed6122666ba9fa8c1de23d5
2018-03-15 11:34:03 +01:00
Sylvestre Ledru ef5ad1811f Bug 1438839 - autopep8 -i --max-line-length 99 on the tools/ r=ahal
MozReview-Commit-ID: KSKbctxjxl0

--HG--
extra : rebase_source : feebd58ff005750face884035f85a55e0ff638c8
extra : histedit_source : 5d7464caeb41bad25bc99d3b2e32ea5285464499
2018-03-15 11:32:42 +01:00
Sebastian Hengst d247fb5f4e Bug 1445763 - Update moz.build meta data with "Firefox Build System". r=froydnj
MozReview-Commit-ID: 3FrWJ6441pe

--HG--
extra : rebase_source : c8f1dc45041132252e28869ada6a386270267431
2018-03-14 21:44:46 +01:00
Andrew Halberstadt 35ace05949 Bug 1369711 - [mozlint] Make sure KeyboardInterrupts are handled well wherever they happen r=gps
There a few pieces needed here to properly handle KeyboardInterrupts.

1. All in-progress work needs to abort. Ideally the underlying linters will be
able to catch KeyboardInterrupt, and return partial results (like the flake8
linter does). Linters may alternatively allow the KeyboardInterrupt to
propagate up. Mozlint will catch and handle this appropriately, though any
results found will be lost. The only change to this behaviour was fixing a bug
in the flake8 linter.

2. Any unstarted jobs need to be canceled. In concurrent.futures, there are two
different queues. First, jobs are placed on the work queue, which is just a list
maintained by the parent process. As workers become available, jobs are moved
off the work queue, and onto the call queue (which is a multiprocessing.Queue).
Jobs that live on the work queue can be canceled with 'future.cancel()', whereas
jobs that live on the call queue cannot. The number of extra jobs that are stored
on the call queue is determined by this variable:
https://hg.mozilla.org/mozilla-central/file/deb7714a7bcd/third_party/python/futures/concurrent/futures/process.py#l86

In this patch, the parent process' sigint handler (which will be called on Ctrl-C)
is responsible for canceling all the jobs on the work queue. For the jobs on the
call queue, the best we can do is set a global variable that tells workers to
abort early.

3. Idle workers should exit gracefully. When there are no more jobs left, workers
will block on the call queue (either waiting for more jobs, or waiting for the
executor to send the shutdown signal). If a KeyboardInterrupt is received while a
worker is blocking, it isn't possible to intercept that anywhere (due to quirks
of how concurrent.futures is implemented). The InterruptableQueue class was
created to solve this problem. It will return None instead of propagating
KeyboardInterrupt. A None value will wake the worker up and tell it to gracefully
shutdown. This way, we avoid cryptic tracebacks in the output.

With all of these various pieces solved, pressing Ctrl-C appears to always exit
gracefully, sometimes even printing partial results.

MozReview-Commit-ID: 36Pe3bbUKmk

--HG--
extra : rebase_source : d4c312ee5cc3679eeee1407c5521aed679f84ad4
extra : source : a93a00141bf62f6bc9e30934c0e56f6b2e434bf0
2018-02-23 08:55:06 -05:00
Tom Prince 3267308b01 Bug 1446110: [update-packaging] Specify prefix for temporary files; r=bhearsum
Thunderbird is currently still building on macOS, where `mktemp` requires an
argument.

MozReview-Commit-ID: DCoZAYA6tTI

--HG--
extra : rebase_source : 48775eba4f934fd244a74da615bc7754370b504e
2018-03-15 14:10:59 -06:00
Sylvestre Ledru fa08b7ce18 Bug 1438839 - Add tools/ as part of the whitelist of flake8 r=ahal
MozReview-Commit-ID: 3J44Yz7rV63

--HG--
extra : rebase_source : 4a270af9cc6c4fa37aba9f328643c66d165df2c3
extra : histedit_source : 5f092731ec6a420efccefbd850bdc937acd24b85
2018-02-16 11:48:12 +01:00
Kit Cambridge bade435150 Bug 1446258 - Expose `MessageChannel` to `System`. r=baku
MozReview-Commit-ID: Bd8pvsDk4Ow

--HG--
extra : rebase_source : af02b4370f847a3ab5caf91e84ef46458c274076
2018-03-16 05:36:50 -07:00
Brendan Dahl 8a6f97c45c Bug 1442302 - Remove placesOverlay.xul. r=Gijs,mak,standard8
The overlay was responsible for script loading and defining three elements
(bhTooltip, placesCommands, placesContext). In the majority of places where
the overlay was included only part of it was used. To remove the overlay, the
elements were each split into include files and moved into where they
were used. For the scripts, a JS file was added that defines all the lazy
modules and then this script, globalOverlay.js and utilityOverlay.js were
inlined to everywhere that would have included them from the overlay.

MozReview-Commit-ID: 8T5D46oYWLn

--HG--
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesCommands.inc.xul
rename : browser/components/places/content/placesOverlay.xul => browser/components/places/content/placesContextMenu.inc.xul
extra : rebase_source : c1071af4ea264a95183cbc65caae98feb23d58e5
2018-03-12 10:43:35 -07:00
Sylvestre Ledru 80b3f60e41 Bug 1445888 - Remove tools/profiler/merge-profiles.py a b2g tool r=julienw
MozReview-Commit-ID: Lt6drB4ncdk

--HG--
extra : rebase_source : 677b30db8f429af16ffaa810408d27542ceb32ad
2018-03-15 11:04:28 +01:00
Xidorn Quan 8031c0838a Bug 1444296 part 2 - Have a separate marker for styles to present stats. r=mstange
MozReview-Commit-ID: FXYnFXDvajw

--HG--
extra : rebase_source : e6b10e1df7d1815afb704b4e6eea812c2affa7fb
extra : source : 1e8a29eb9c2966f458d8019feb9f91323dc4d94a
2018-03-15 11:59:22 +11:00
Brendan Dahl c52106c442 Bug 1444228 - Remove editBookmarkOverlay.xul. r=standard8
Move the main contents of editBookmarkOverlay.xul into an include file and
inline the DTD and CSS files where used. Convert several chrome tests to
browser tests since the preprocessor is hard to use within the testing
framework.


MozReview-Commit-ID: DpPBOpZSuBN

--HG--
rename : browser/components/places/content/editBookmarkOverlay.js => browser/components/places/content/editBookmark.js
rename : browser/components/places/content/editBookmarkOverlay.xul => browser/components/places/content/editBookmarkPanel.inc.xul
rename : browser/components/places/tests/chrome/test_bug427633_no_newfolder_if_noip.xul => browser/components/places/tests/browser/browser_bug427633_no_newfolder_if_noip.js
rename : browser/components/places/tests/chrome/test_bug485100-change-case-loses-tag.xul => browser/components/places/tests/browser/browser_bug485100-change-case-loses-tag.js
rename : browser/components/places/tests/chrome/test_bug631374_tags_selector_scroll.xul => browser/components/places/tests/browser/browser_bug631374_tags_selector_scroll.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_keywords.xul => browser/components/places/tests/browser/browser_editBookmark_keywords.js
rename : browser/components/places/tests/chrome/test_editBookmarkOverlay_tags_liveUpdate.xul => browser/components/places/tests/browser/browser_editBookmark_tags_liveUpdate.js
rename : browser/themes/linux/places/editBookmarkOverlay.css => browser/themes/linux/places/editBookmark.css
rename : browser/themes/osx/places/editBookmarkOverlay.css => browser/themes/osx/places/editBookmark.css
rename : browser/themes/windows/places/editBookmarkOverlay.css => browser/themes/windows/places/editBookmark.css
extra : rebase_source : aca072691251c1a44e82ab8091796abd2b140e22
2018-03-16 09:26:49 -07:00
Dave Hunt 057d540744 Bug 1438250 - Make mozunit pip installable; r=ahal
MozReview-Commit-ID: BT4ciGT82bp

--HG--
rename : config/mozunit.py => config/mozunit/mozunit/mozunit.py
extra : rebase_source : a68fa4f5dce77ccf7c55184c555bb37b3a876278
2018-03-29 14:18:00 +01:00
Andrew Halberstadt d2e75d0ea8 Bug 1436802 - [lint] Add some tests for the flake8 linter integration r=andi
This essentially tests tools/lint/python/flake8.py. Though it also adds
a basic framework for testing all the other linters as well. Getting this
added now will allow others to collaborate on adding more tests without
needing to get to 100% coverage for all linters right off the bat.

All python tests under tools/lint/test will run as part of the 'ml' task
on Linux, and the build task on Windows (OSX coverage is currently missing
for python tests).

The flake8 linter currently has a bug where the 'exclude' argument is
ignored. This is why we need to also exclude 'tools/lint/test/files' in
topsrcdir/.flake8, even though it is already listed in the
'mach_commands.py'. Other linters shouldn't need to do this, the exclusion
in 'mach_commands.py' should be good enough. See bug 1277851 for more
details.

MozReview-Commit-ID: 9ho8C83eeuj

--HG--
extra : rebase_source : 0adb01aa81c06f26cb891ae9f92a17f8f9fdf111
2018-03-22 17:24:15 -04:00
Tom Ritter 069fabef4a Bug 1444167 Add a MinGW Header Capitalization lint job r=ahal
MinGW headers are all lowercase, and because we build FF with MinGW
on Linux - capitalization matters.  But if you're plugging along,
working on Windows, you might forget about that, and wind up
inadvertently breaking the MinGW build because you capitalized
an include file (as is common in Windows development.)

This lint job takes the list of header files from MinGW
(generated by cd mingw-w64/mingw-w64-headers &&
  find . -name "*.h" | xargs -I bob -- basename bob | sort | uniq)
and will alert if they are in an #include statement but not
all-lowercase.

MozReview-Commit-ID: 4QFSdHx5Uak

--HG--
extra : rebase_source : d76c258191d4cbb7665775bd1b8d79028890727f
2018-03-08 13:41:00 -06:00
Sylvestre Ledru 270e2db41d Bug 1445269 - Refresh tools/rewriting/ThirdPartyPaths.txt r=tjr
MozReview-Commit-ID: xui275DKni

--HG--
extra : rebase_source : 8df0979f7a286211f2947e4192fa3b11ec2ac387
2018-03-13 15:59:21 +01:00
Sylvestre Ledru fd2808c467 Bug 1445245 - Add more directories in the codespell whitelist r=ahal
MozReview-Commit-ID: 5dLm1fus7J0

--HG--
extra : rebase_source : b8359df8fc65f3382f37b891f1bbf1ed5c58da1d
2018-03-13 14:50:20 +01:00
Narcis Beleuzu 49a6cb8875 Backed out 3 changesets (bug 1438839) for linting failure on split-profile.py. CLOSED TREE
Backed out changeset 41c11bf05828 (bug 1438839)
Backed out changeset 40fda8b55cf9 (bug 1438839)
Backed out changeset 37a3c981a785 (bug 1438839)
2018-03-13 10:10:16 +02:00
Sylvestre Ledru 482b8f35cc Bug 1438839 - Fix the remaining flake8 issues by hand r=ahal
MozReview-Commit-ID: Fv1MZIpCL8Z

--HG--
extra : rebase_source : ba62df5928d7d882d135c7d51c4b4175c483fd0a
2018-02-27 14:04:50 +01:00
Sylvestre Ledru a5176f006e Bug 1438839 - autopep8 -i --max-line-length 99 on the tools/ r=ahal
MozReview-Commit-ID: KSKbctxjxl0

--HG--
extra : rebase_source : ddce23f3e728e29aab4dbccd616ca8e9f31c0817
2018-02-26 23:29:32 +01:00
Sylvestre Ledru 19776440ab Bug 1438839 - Add tools/ as part of the whitelist of flake8 r=ahal
MozReview-Commit-ID: 3J44Yz7rV63

--HG--
extra : rebase_source : 619bb636e412a01b74663c03dae0257d92a449fa
2018-02-16 11:48:12 +01:00
Sylvestre Ledru 8fe4c9151f Bug 1444048 - Codespell: ignore the ignored typos by moving to quiet-level=4 r=standard8
MozReview-Commit-ID: HpIOkKh6SQQ

--HG--
extra : rebase_source : f849f24324e561fe3452743e91f964ccbb1abad0
2018-03-08 10:51:42 +01:00
manikishan 92de2db258 Bug 1431050 - Replace NS_ASSERT with conditional exceptions/console.assert and remove the debug.js module. r=mak
console.assert keeps the same semantics as NS_ASSERT in that it doesn't throw an exception,
but a lot of the places code was using it in a way that would be better served by throwing
an exception when the condition is false.

MozReview-Commit-ID: DEF5HSfYO36
2018-02-03 11:32:25 +05:30
Tom Ritter f572733682 Bug 1444169 Fix capitalization for a few Windows files r=aklotz
MozReview-Commit-ID: BlWgIVobOBK

--HG--
extra : rebase_source : 71a8052c562aa7be510e3a4c13a0ca698a04a5ac
2018-03-08 14:49:59 -06:00
Greg Tatum 4f7596f26a Bug 1425605 - Add the start/end mark names to performance.measure profiler markers; r=baku,mstange
MozReview-Commit-ID: I8DzSlSi124

--HG--
extra : rebase_source : 5062bf33824284df7346dae15595f8e1e479bc40
2018-03-08 16:36:53 -06:00
Edouard Oger 4aea0be2d6 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : 16b7f01ed6f9b03534945d718c567dad0daa4ff3
2018-02-22 16:30:39 +08:00
Daniel Marshall d337129b4a Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : ea59d03458c0e253201fd2c1476062dfb2e9a3d6
2018-02-10 21:23:19 +00:00
Mark Banner 0722fe3ee3 Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk

--HG--
extra : rebase_source : 0705e96256baf6dc82811297058aa1d820b2f119
2018-03-06 12:01:59 +00:00
Narcis Beleuzu 8c7d795b53 Backed out 2 changesets (bug 1439777) for xpcshell failures on /test_errorhandler_2.js
Backed out changeset d99402ad9ecc (bug 1439777)
Backed out changeset 1af3426dc956 (bug 1439777)
2018-03-06 04:43:41 +02:00
Edouard Oger 934abf11b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : dd7218b5f0bd36dc4c71d2a7c95a92bba4da2d12
2018-02-22 16:30:39 +08:00
Narcis Beleuzu 34b2bf4c13 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall 57b922d77c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I

--HG--
extra : rebase_source : 379bd1db1e50ae415806713878e6b3ef36889e89
2018-02-10 21:23:19 +00:00
shindli 51dcc3d916 Backed out 2 changesets (bug 1439777) for browser chrome in browser/components/customizableui/test/browser_remote_tabs_button.js and xpc-shell failures in services/sync/tests/unit/test_errorhandler_2.js on a CLOSED TREE
Backed out changeset 6e83f07e8f2f (bug 1439777)
Backed out changeset 8856efbc78a7 (bug 1439777)

--HG--
extra : histedit_source : 6472e71267b81d2ed8782eeb900c8e12b3e58e52
2018-03-05 18:59:03 +02:00
Edouard Oger e68b9239b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : e90de5b437cc7fa8afcbe174c7bfb7bdce5b4c90
2018-02-22 16:30:39 +08:00
Markus Stange 0e40b574c1 Bug 1429904 - Remove ProfileBuffer::Reset(). r=njn
MozReview-Commit-ID: AzIyYByoesS

--HG--
extra : rebase_source : bc21f96e01c2bfc9aea0ce90ba43aa8864fb6bbf
2018-02-15 21:49:05 -05:00
Markus Stange 9e2d38db17 Bug 1429904 - Remove unused arguments and return values. r=njn
MozReview-Commit-ID: 9P0TKavkwgA

--HG--
extra : rebase_source : a30467537478805bb0a69bbb016a143555c2dfe8
2018-02-17 19:21:05 -05:00
Markus Stange 28d8be3628 Bug 1429904 - When a JSContext for a thread is about to go away, collect enough information about any JIT entries in the buffer so that the entire buffer can be streamed to JSON. r=njn
This changeset changes behavior.
If the profile is streamed before any JSContext has gone away, we now iterate
over the entire buffer twice (per thread): First, to collect information about
JIT frames, and then again when we build the JSON for the samples. The first
traversal stores small pieces of JSON for JIT fromes in individual strings, and
the second iteration splices those strings into the thread JSON's frame table.

When the JSContext for a thread goes away, we no longer build JSON for samples,
and we don't reset the profiler buffer. We now only build the JSON for JIT
frames. Once the complete profile is requested and we build samples for it, we
iterate over the entire buffer, and look up the cached JIT frame information for
JitReturnAddr entries from the correct range. Different parts of the buffer may
correspond to the life time of different JSContexts: For each JSContext we will
have one range in the JITFrameInfo, and we can look up the correct range based
on the buffer position of the JitReturnAddr entry that we're processing.

This new way of doing things has multiple advantages:
 - We no longer reset the buffer, so we no longer lose information about other
   threads.
 - All threads from a given process now always have sample data for the same
   time range. Before this change, the "partial profile" from a thread that
   lost its JSContext could extend further into the past than the other threads'
   profiles.
 - Requesting profiles multiple times now has more consistent results. Before
   this change, the first requested profile would include the partial profile,
   but then the partial profile was discarded. And the second requested profile
   would not contain any data for the time before the JSContext went away.
 - We now do less work when a thread's JSContext goes away. This should
   decrease the interruption time.

MozReview-Commit-ID: 3KhnPtBijna

--HG--
extra : rebase_source : 2ef5ac933e4db1c98526a2b36147ff031893de9e
extra : intermediate-source : d63b04327077d1ef55f509b365cd2693905b0733
extra : source : f2d8c993aa2c16bc491c55179d545f5a2c727391
2018-02-28 00:17:16 -05:00
Markus Stange 2f171b74fa Bug 1429904 - Add JITFrameInfo. r=njn
MozReview-Commit-ID: DashxIKyzYZ

--HG--
extra : rebase_source : 2c1c01ed2008b0934d27ba10a7ef064453306ee9
2018-02-28 00:13:51 -05:00
Markus Stange a76d2ed393 Bug 1429904 - Put mUniqueStrings into a UniquePtr. r=njn
In an upcoming patch we'll want to initialize mUniqueStrings by stealing
another object's UniqueJSONStrings, but UniqueJSONStrings itself is not
move-constructible. But UniquePtr is.
Making UniqueJSONStrings itself move-constructible would be a bit tricky
because it has a SpliceableChunkedJSONWriter which is not move-constructible;
and making SpliceableChunkedJSONWriter move-constructible is hard because
there's no obvious "empty but valid" state that we could leave a moved-out-of
SpliceableChunkedJSONWriter in; for example, it expects to have a non-null
WriteFunc at all times.

MozReview-Commit-ID: Q6o61HFTiD

--HG--
extra : rebase_source : e1073be9892cf7cfd6ca4f2562ce939690b3b4d7
2018-02-17 15:50:43 -05:00
Markus Stange 79f37c94cf Bug 1429904 - Give UniqueJSONStrings a copy constructor. r=njn
MozReview-Commit-ID: tlh6qkYX7A

--HG--
extra : rebase_source : 115d834c1e0eed80f54da4aec2db04105b91d90c
2018-02-17 15:39:45 -05:00
Markus Stange 721a2ea7b8 Bug 1429904 - Tell the ProfiledThreadData what the buffer position was when the thread received its JSContext. r=njn
This also renames FlushSamplesAndMarkers to NotifyAboutToLoseJSContext.

MozReview-Commit-ID: FWinMi85yDZ

--HG--
extra : rebase_source : 6d8bfd6937ce757108f80f43e878a2dbead318bd
2018-02-17 15:03:30 -05:00
Markus Stange 15b53ded07 Bug 1429904 - Use a Variant to split the FrameKey members into two groups. r=njn
This makes it clear which combinations of fields are possible.

MozReview-Commit-ID: C3PriO7nWsJ

--HG--
extra : rebase_source : 68df01f11121b09b2f2762581dc28184262abfb8
2018-02-27 23:44:02 -05:00
Markus Stange f4f1500202 Bug 1429904 - Add 'using namespace mozilla;' to ProfileBufferEntry.cpp and remove some mozilla:: prefixes. r=njn
I think this file was picking up such a declaration from a different file
already, through unified builds.

MozReview-Commit-ID: 9xTB2QA86U0

--HG--
extra : rebase_source : d7b614524ebdf25a185698b6632d6f925ce08da8
2018-02-17 12:35:57 -05:00
Markus Stange e0cf8ba1ba Bug 1429904 - Remove a comment about std::string. r=njn
nsCString is the idiomatic string class we want to use anyway. There's no need
to think about std::string here.

MozReview-Commit-ID: 1rjZAyqp13d

--HG--
extra : rebase_source : 92c4eb22876c4fc89f00104c56f92a75053284e9
2018-02-28 00:30:55 -05:00
Markus Stange 1362836d13 Bug 1429904 - Make FrameKey members const. r=njn
MozReview-Commit-ID: KTYmCJM9tOH

--HG--
extra : rebase_source : b5009f527bc0cd026e06c8b5da9f3d44fc4ea700
2018-02-27 23:11:34 -05:00
Markus Stange 89eae04310 Bug 1429904 - Add another constructor to FrameKey which initializes mLine and mCategory, and use it in one place. r=njn
MozReview-Commit-ID: 1LliQMGjfjx

--HG--
extra : rebase_source : 82575f4dc270ac0dabccbe5cc667222f137ca8cc
2018-02-27 23:10:06 -05:00
Markus Stange 2927aca3f7 Bug 1429904 - Let the compiler implement the FrameKey copy constructor for us. r=njn
MozReview-Commit-ID: 9e9rMkEAyeL

--HG--
extra : rebase_source : 7bfe088360c891a0c7b364ed3ab4e42516b2b97b
2018-02-27 23:08:19 -05:00
Markus Stange 81b7ec9e0c Bug 1429904 - Remove mHash which is now unused. It was only used by FrameKey::operator<. r=njn
MozReview-Commit-ID: 5Jc6EYmoZfS

--HG--
extra : rebase_source : 20c2c4b0396b0b850066d65e6f7984e4fbe472fa
2018-02-27 23:06:31 -05:00
Markus Stange fa1dbb7812 Bug 1429904 - Remove unused operator< from StackKey and FrameKey. r=njn
nsGenericHashKey never calls this operator, as far as I can tell.

MozReview-Commit-ID: NDybMI8DOA

--HG--
extra : rebase_source : 933c12e2ef4600ea33b6c7026f539e51447fc454
2018-02-27 22:41:35 -05:00
Marco Bonardo b8f68ba5dd Bug 1439315 - 9 - Remove no more necessary placesOverlayModules. r=standard8
MozReview-Commit-ID: Fa7b0qf4mix

--HG--
extra : rebase_source : d6b8ca13e7e9487ea7d8b47b00ab0b00aad69e7a
2018-03-01 14:36:30 +01:00
Marco Bonardo f1d5ac420b Bug 1439315 - 4 - Make ESLint happy. r=standard8
MozReview-Commit-ID: I4Hz0V9UGvI

--HG--
extra : rebase_source : a78d1513e46f85375e4e75377550940d40c25b70
2018-02-28 15:27:04 +01:00
Sebastian Hengst 3a10644021 Backed out 6 changesets (bug 888600) for beta simulation failures: build bustage on Linux and Windows opt (bug 1442036) and devtools failure browser_net_view-source-debugger.js (bug 1441961). a=backout
Backed out changeset 83c87140dc3d (bug 888600)
Backed out changeset 2efb9b1753f6 (bug 888600)
Backed out changeset af5303781961 (bug 888600)
Backed out changeset 79ef59047e63 (bug 888600)
Backed out changeset 30d568d628dd (bug 888600)
Backed out changeset c7bd4c6c9741 (bug 888600)

--HG--
extra : histedit_source : 791b22f6770f4fead2f909478a93d65d85829fe0%2Cbb387309e90f53e1dde45dcf8cf4ebedcc6e5c5e
2018-03-01 11:51:09 +02:00
Simon Fraser 197753c5ed Bug 1441867 Fix stat call for udpate packaging r=bhearsum
MozReview-Commit-ID: LNRHy5fzVsQ

--HG--
extra : rebase_source : 5d9896707cd648a4785bca7b898984907d17e892
2018-02-28 15:37:08 +00:00
Markus Stange fcdbc4f32f Bug 1439168 - Return profiled threads sorted by registration time. r=njn
MozReview-Commit-ID: 6grx6eSLteQ

--HG--
extra : rebase_source : 4a2a7c83f2c77dd9742d4be4047f5224b1759a40
2018-02-12 01:07:59 -05:00
Markus Stange 683997b80b Bug 1437428 - Split ThreadInfo into three classes: ThreadInfo, RegisteredThread and ProfiledThreadData. r=njn
The file copies and renames make this patch look a bit confusing. Here's what
happens:

ThreadInfo.h:
Most of the code gets moved into RegisteredThread.h and ProfiledThreadData.h,
but a small piece remains in ThreadInfo.h.

ThreadInfo.cpp:
Gets split into RegisteredThread.cpp and ProfiledThreadData.cpp.
ThreadInfo.cpp itself goes away.

In the mercurial changeset, I've marked ThreadInfo.h as being copied to both
RegisteredThread.h and to ProfiledThreadData.h, and ThreadInfo.cpp as being
copied to RegisteredThread.cpp and as being renamed to ProfiledThreadData.cpp.

MozReview-Commit-ID: 1j1imAv9cTd

--HG--
rename : tools/profiler/core/ThreadInfo.cpp => tools/profiler/core/ProfiledThreadData.cpp
rename : tools/profiler/core/ThreadInfo.h => tools/profiler/core/ProfiledThreadData.h
rename : tools/profiler/core/ThreadInfo.cpp => tools/profiler/core/RegisteredThread.cpp
rename : tools/profiler/core/ThreadInfo.h => tools/profiler/core/RegisteredThread.h
extra : rebase_source : 91310691d5e46246ec03305511c1b86ab458b0b9
2018-02-16 22:43:51 -05:00
Markus Stange fa1eca48cc Bug 1437428 - Make PseudoStack a member of RacyInfo instead of inheriting from it. r=njn
MozReview-Commit-ID: 3fumT1Livf6

--HG--
extra : rebase_source : fa201a7023ba9ffa5d0d23e2886ad151f4a7930a
2018-01-31 17:42:49 -05:00
Brendan Dahl f4384d768c Bug 1439766 - Replace editMenuOverlay.xul by inlining and preprocessing. r=Gijs
The overlay elements with children of editMenuOverlay.xul are moved into
include files (editMenuCommands.inc.xul and editMenuKeys.inc.xul). For
the other single elements in the overlay, the attributes are inlined
wherever they are used.

MozReview-Commit-ID: 792cuzUvQxT

--HG--
extra : rebase_source : 58e4c05bde16cee873d37c6198de102d048499c2
2018-02-22 15:48:24 -08:00
Brian Grinstead dcf493b621 Bug 1440094 - Allow `console` as a global for eslint;r=mossop
As of Bug 1425463 it's available in all contexts (including JSM). The following
patche is going to remove imports to Console.jsm, so prepare for this by allowing
it to be used as a global in eslint.

MozReview-Commit-ID: 3gCIspnlVgB

--HG--
extra : rebase_source : 6da75d42d7d937b628ef1d9c0d4e349fd76eda36
2018-02-27 11:29:35 -08:00
Andreea Pavel d805787970 Merge mozilla-central to autoland. a=merge on a CLOSED TREE 2018-02-28 00:25:43 +02:00
Andreea Pavel fa0861e443 Merge mozilla-inbound to mozilla-central. a=merge on a CLOSED TREE 2018-02-28 00:24:02 +02:00
Julien Cristau 4bd4017197 Bug 1441484 - fix error handling in make_incremental_updates. r=bhearsum
MozReview-Commit-ID: 4jpZqMW0yYX

--HG--
extra : rebase_source : 60963d642b37a127510e6d9dfad5bd556fc5d3b0
2018-02-27 10:36:15 +01:00
Mark Banner 294979dc32 Bug 1441460 - ESLint's no-define-cc-etc looks at the wrong property item when checking for Cc/Ci/Cu/Cr usage. r=florian
MozReview-Commit-ID: IkSkCWqBHOn

--HG--
extra : rebase_source : 6b3a2977d4b157aea54c6e3f6960d3673e751a34
2018-02-23 20:42:17 +00:00
Peter Van der Beken 6cf0e1c871 Bug 888600 - Move ContentFrameMessageManager to WebIDL. Part 6: Mark some IDL interfaces as non-scriptable. r=bz.
--HG--
extra : rebase_source : f6f781b04923f67f60718706a78b3c4de15eca94
2018-02-22 20:22:29 +01:00
Simon Fraser b2f9f6fd8b Bug 1439860 update-packaging linting fixes and shell style updates r=bhearsum
MozReview-Commit-ID: 2vMbmonkVwD

--HG--
extra : rebase_source : 05e49e5c3013c0dd726c93f5e48e1b81879b97a9
2018-02-21 11:54:21 +00:00
Andreas Tolfsen 612979856b Bug 1441019 - Add testing/marionette to js_source_path. r=gps,nalexander
MozReview-Commit-ID: Lvj7zbnzpLR

--HG--
extra : rebase_source : 84fc2f2cb09d89715cf902152798ccb8f1c14545
2018-02-22 16:32:49 +00:00
Sylvestre Ledru c9e386cafc Bug 1438790 - Remove dead code generatesnippet.py r=Callek
MozReview-Commit-ID: D7lJJbMl8cV

--HG--
extra : rebase_source : 6730cd077cf1134767c5e2d706fb8b5ef6649955
2018-02-16 11:24:49 +01:00
Sylvestre Ledru ec0beeca80 Bug 1436354 - Enable modernize-use-bool-literals at review phase r=Ehsan
This won't warn about existing defects.

MozReview-Commit-ID: Fra6TmTREf2

--HG--
extra : rebase_source : 83a390edfbc68201a39c18cc618b304431163483
2018-02-07 15:14:32 +01:00
Mark Banner 6afe18b30a Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq

--HG--
extra : rebase_source : 483ae0b54b9e781cceac2accdfb2255d725ace6a
2018-02-22 16:55:36 +00:00
Mark Hammond 0ed1cfff09 Bug 1435929 - refactor browserid_identity.js to be less confusing and error prone. r=eoger,tcsc
MozReview-Commit-ID: IJPQv4ZvJlp

--HG--
extra : rebase_source : b3ed7ebfc2ccaf1dd23775372b2f4bb04b526ad8
2018-02-06 14:05:45 +11:00
Ciure Andrei 2a61dd0967 Backed out changeset 2e7cc4dc999c (bug 1435929) for eslint failure at /builds/worker/checkouts/gecko/services/sync/modules/browserid_identity.js a=backout on a CLOSED TREE 2018-02-25 09:37:26 +02:00
Mark Hammond 6afd2c2ec1 Bug 1435929 - refactor browserid_identity.js to be less confusing and error prone. r=eoger,tcsc
MozReview-Commit-ID: IJPQv4ZvJlp

--HG--
extra : rebase_source : d3052d120778dc1e8111ba76ee9df285d5483786
2018-02-06 14:05:45 +11:00
Gurzau Raul 6ef84d63ec Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-04-20 12:15:48 +03:00
Randell Jesup 77b8bbfbe2 Bug 1453387: Add network load status reports to gecko-profiler markers r=mstange 2018-04-19 23:32:17 -04:00
Sylvestre Ledru 1e5d4345d7 Bug 1438471 - Remove dead code: nm-symbolicate.py r=mstange
MozReview-Commit-ID: 7qaYBvLzPZL

--HG--
extra : rebase_source : 32d70ea42c5d286b074dde3f55090f6f2437d734
2018-02-22 08:59:39 +01:00
Mark Banner 8387fb332e Bug 1439949 - Update eslint to 4.18.1 to support async iteration. r=mossop
MozReview-Commit-ID: 6S8Fq7yHISq

--HG--
extra : rebase_source : 719181833e15bd299a20239ac546734dbb11509a
2018-02-21 16:00:24 +00:00
Kit Cambridge 04142e96e3 Bug 1439038 - Merge `Engine` and `SyncEngine`. r=eoger
MozReview-Commit-ID: GbuW3gFLCga

--HG--
extra : rebase_source : b15ea149ff5ddca7cdb45b0ef195c07bf4915411
2018-02-16 16:43:42 -08:00
Cosmin Sabou 768831260e Backed out 2 changesets (bug 1437428) for frequent xpcfailures on marAppApplyUpdateStageOldVersionFailure.js a=backout
Backed out changeset b915e160a690 (bug 1437428)
Backed out changeset 0fcad4eaabb6 (bug 1437428)

--HG--
rename : tools/profiler/core/RegisteredThread.cpp => tools/profiler/core/ThreadInfo.cpp
2018-02-18 23:57:55 +02:00
Chris Peterson c6373306f8 Bug 1436263 - Part 5: Add a mach lint for virtual function declarations with multiple specifiers. r=froydnj r=ahal
Virtual function declarations should specify only one of `virtual`, `final`, or `override`, as per the Mozilla C++ style guide:

https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

This lint warns about:

  virtual void Bad1() final
  void Bad2() final override
  void Bad3() override final

Caveats: This lint doesn't warn about `virtual void NotBad() override` at this time because there are 8000+ instances. It also doesn't warn about function declarations that span multiple lines because the regex can't match across line breaks.

MozReview-Commit-ID: LcBsOAKKgz7

--HG--
extra : rebase_source : 4da72ffac59acdc9796e3f540f24bb97af989cd0
2018-02-15 00:50:02 -08:00
Chris Peterson d09123f248 Bug 1436263 - Part 1: Replace `final override` virtual function specifiers with just `final`. r=froydnj
MozReview-Commit-ID: DE5HkIhsZ6D

--HG--
extra : rebase_source : 94831c1e13a840dd2ea0600f64bcf70c2bf938d9
extra : source : cf9283bf1b0bca3a6311c98e227329d451f80ecb
2018-02-05 22:46:57 -08:00
Markus Stange 9fe1f51348 Bug 1437428 - Split ThreadInfo into three classes: ThreadInfo, RegisteredThread and ProfiledThreadData. r=njn
The file copies and renames make this patch look a bit confusing. Here's what
happens:

ThreadInfo.h:
Most of the code gets moved into RegisteredThread.h and ProfiledThreadData.h,
but a small piece remains in ThreadInfo.h.

ThreadInfo.cpp:
Gets split into RegisteredThread.cpp and ProfiledThreadData.cpp.
ThreadInfo.cpp itself goes away.

In the mercurial changeset, I've marked ThreadInfo.h as being copied to both
RegisteredThread.h and to ProfiledThreadData.h, and ThreadInfo.cpp as being
copied to RegisteredThread.cpp and as being renamed to ProfiledThreadData.cpp.

MozReview-Commit-ID: 1j1imAv9cTd

--HG--
rename : tools/profiler/core/ThreadInfo.cpp => tools/profiler/core/ProfiledThreadData.cpp
rename : tools/profiler/core/ThreadInfo.h => tools/profiler/core/ProfiledThreadData.h
rename : tools/profiler/core/ThreadInfo.cpp => tools/profiler/core/RegisteredThread.cpp
rename : tools/profiler/core/ThreadInfo.h => tools/profiler/core/RegisteredThread.h
extra : rebase_source : 91310691d5e46246ec03305511c1b86ab458b0b9
2018-02-16 22:43:51 -05:00
Markus Stange 8bb2083b22 Bug 1437428 - Make PseudoStack a member of RacyInfo instead of inheriting from it. r=njn
MozReview-Commit-ID: 3fumT1Livf6

--HG--
extra : rebase_source : fa201a7023ba9ffa5d0d23e2886ad151f4a7930a
2018-01-31 17:42:49 -05:00
Andrew Halberstadt f249b70e43 Bug 1437912 - [moztest] Map flavors and subsuites to a suite definition, r=gbrown
The end goal here is to be able to use |mach try fuzzy <path>| with tests that
belong to a subsuite. To do this, we need a unique 'task_regex' value for each
subsuite so that we can map a test path back to a set of tasks.

This removes the TEST_FLAVORS dict (which was mostly just a redefinition of the
data in TEST_SUITES), and instead provides two new private mappings:

<flavor> -> suite definition
(<flavor>, <subsuite>) -> suite definition

To retrieve a suite definition given a flavor/subsuite, consumers can now call
get_suite_definition.

MozReview-Commit-ID: 2pe1v1IHUVy

--HG--
extra : rebase_source : 6fff947ba214112ccf16c894174a6a0e2487111a
2018-02-13 14:16:46 -05:00
Narcis Beleuzu 2d9816273c Merge inbound to mozilla-central. a=merge 2018-02-16 11:49:59 +02:00
Jashank Jeremy 5e7e2c2a06 Bug 1438120 - Fix non-MOZ_GECKO_PROFILER build by adding the missing AUTO_PROFILER_LABEL_FAST declaration. r=mstange
--HG--
extra : amend_source : ba4360be040c3d765f380d3c92e6fabf0cdfd436
2018-02-15 22:27:33 -05:00
Sylvestre Ledru 6062c401f8 Bug 1437891 - Enable readability-redundant-string-cstr & readability-redundant-string-init checkers r=andi
MozReview-Commit-ID: 1QliseFa1mC

--HG--
extra : rebase_source : 0d8038d5678515d11a73e00870a618017348c011
2018-02-13 16:23:29 +01:00
Andrew Halberstadt c731fa1f2c Bug 1436639 - [lint] Make sure flake8 is run with same python as |mach lint| was, r=jmaher
This fixes a bug which can happen when the default version of python differs from
the version of python used with mach.

For example, mach explicitly looks for python2.7. This means running |mach lint -l flake8|
should also run flake8 with version 2.7. But if the default is python3, and flake8 is also
installed there, the subprocess call that invokes flake8 will run under python3. This can
lead to errors like "undefined name 'basestring'" and other 2to3 gotchas.

This patch ensures that we run the flake8 binary (and the pip for installing flake8) from
the same interpreter as mach, no matter the system default.

MozReview-Commit-ID: HSuMzDsAvsW

--HG--
extra : rebase_source : faf4c8c0eb6f46d8b50c2d9be9aa6f6d47e4e0cb
2018-02-07 23:28:33 -05:00
Noemi Erli d03ad8843e Merge inbound to mozilla-central. a=merge 2018-02-13 11:39:36 +02:00
Markus Stange 36b552905a Bug 1434965 - Take 'streaming generation' into account when de-duplicating JIT frames. r=njn
MozReview-Commit-ID: KlhSPY4ZrOR

--HG--
extra : rebase_source : 801fa6a577f7e218c0bd5fd5554f28880c5c5e7c
2018-02-10 20:03:36 -05:00
Markus Stange 01745f4e91 Bug 1434965 - Don't store a JSContext pointer in UniqueStacks; pass it manually to the functions that need it. r=njn
This resolves the bug where we attempted to find information about JitReturnAddr
entries which were collected with a new JSContext by asking an old JSContext.

MozReview-Commit-ID: FQrnAuwwzHU

--HG--
extra : rebase_source : d0a0c7077199dc177123bb54951f4f7238c5eaf6
2018-02-10 19:17:05 -05:00
Markus Stange 655bb7136b Bug 1434965 - Eliminate custom StringKey class by using nsCStringHashKey. r=njn
MozReview-Commit-ID: HRYfXI43wmE

--HG--
extra : rebase_source : c12db1ffc6c4f974676d086f9182b8ce994d2f91
2018-02-10 19:05:19 -05:00
Markus Stange 0fa0457987 Bug 1434965 - Add ForEachTrackedOptimizationTypeInfoLambdaOp. r=njn
This makes the JSON serialization code for optimization type info a little
easier to read.

MozReview-Commit-ID: 2auHVmp7hKw

--HG--
extra : rebase_source : 1fbcf4dc63a24822f5411a7107af0e07a703a4bf
2018-02-12 14:48:44 -05:00
Markus Stange 77e86db941 Bug 1434965 - Create an implementation of JS::ForEachTrackedOptimizationAttemptOp which takes a lambda. r=njn
This moves the meat of the processing from operator() into the lambda, so that
it can be read in the function that calls forEachOptimizationAttempt. Now the
person who wants to understand this code hopefully won't need to scroll up and
down as much.

MozReview-Commit-ID: H9zRf1Vbswg

--HG--
extra : rebase_source : a742fa4c076437c7af6837280f725ee4532cbf2c
2018-02-12 14:48:09 -05:00
Markus Stange 14feaf3477 Bug 1434965 - Add AutoArraySchemaWriter::FreeFormElement so that FillUpTo can be private. r=njn
This may seem like an unnecessary increase in complexity, and it probably is.
But it makes it easier to reason about lifetimes if your mind is accustomed to
Rust, which would enforce a similar solution.

MozReview-Commit-ID: kJZifbjCSU

--HG--
extra : rebase_source : a2906eb296975ca689c2c3a019c33062ba17b0f2
2018-02-10 17:41:35 -05:00
Markus Stange b9043767e5 Bug 1434965 - Remove AutoArraySchemaWriter constructor that doesn't take a string table. r=njn
WriteSamples doesn't really need the ability to write strings, but always passing
a string table means that there's one less thing to worry about (one less piece of
unsafe API).

MozReview-Commit-ID: 386OEibyush

--HG--
extra : rebase_source : 4fa6428b6371cf4c3db5ad77aac06c0113b2e541
2018-02-10 16:54:24 -05:00
Markus Stange 4e334139e5 Bug 1434965 - Remove OnStackFrameKey and solve frame canonicalization differently. r=njn
MozReview-Commit-ID: DITzwF94U64

--HG--
extra : rebase_source : 8d5c40b2bdcd22ee87ca8429d95b026309f932d5
2018-02-12 14:00:05 -05:00
Markus Stange e53f99f34a Bug 1434965 - Split StreamFrame into two different implementations for JIT and non-JIT frames. r=njn
MozReview-Commit-ID: Ap4FVS8FMKh

--HG--
extra : rebase_source : fe827adea0b37f6f60923bdb30d1f4e66653e24e
2018-02-10 15:14:28 -05:00
Markus Stange f0459d39c9 Bug 1434965 - Remove Stack class and use intended-to-be-immutable StackKeys. r=njn
I wasn't comfortable with how Stack had a reference to the UniqueStacks object.
Now we compute new the new stack index after appending a frame by explicitly
calling a method of the UniqueStacks object.

MozReview-Commit-ID: KQAI9JNb4ag

--HG--
extra : rebase_source : 5d4c7a3f637f8e2bbd4e84c3aca65290a731a206
2018-02-09 18:18:34 -05:00
Markus Stange 8fb2503b8a Bug 1434965 - Replace callback-based API ForEachProfiledFrame with an iterator-based API called GetProfiledFrames. r=njn
This also renames ForEachProfiledFrameOp::FrameHandle to ProfiledFrameHandle.

MozReview-Commit-ID: 7Jh1x2QWjXe

--HG--
extra : rebase_source : 8bb0fa15fa20215f03148cfd30ae0e41f82330fd
2018-02-10 20:38:41 -05:00
Andrew Halberstadt 033f64e234 Bug 1437484 - Pin and hash all requirements for |mach doc|, r=gps
Previously we weren't explicitly installing sphinx. Instead, the 'sphinx-js'
package had a dependency on 'sphinx<2.0'. This caused errors when sphinx
released their backwards incompatible version 1.7.

This patch pins sphinx==1.6.7 and adds all other dependencies to the same
requirements.txt (with hashes).

Upgrading to sphinx==1.7 will happen in a follow-up.

MozReview-Commit-ID: 28fKI7T4vfa

--HG--
extra : rebase_source : a9f276586ed08f49c1a26088aae88c363a31c167
2018-02-12 09:36:12 -05:00
Ciure Andrei 3f00808b55 Merge mozilla-central to mozilla-inbound. a=merge CLOSED TREE 2018-02-13 00:14:29 +02:00
Kyle Machulis 173d6a7510 Bug 1437226 - Fix text-disable linter message; r=ahal
MozReview-Commit-ID: KA9y8AwgVj8
2018-02-12 12:28:41 -08:00
Markus Stange e92440806d Bug 785440 - Add AUTO_PROFILER_LABEL_FAST. r=njn
This gets the pseudostack from the JSContext instead of using TLS, and only
pushes a pseudo stack frame if the profiler is active.

MozReview-Commit-ID: IzT4py9H8su

--HG--
extra : rebase_source : 9962455d59e3f8b85a347f4203ac619e654fcb7c
extra : source : f15e6874f6c14f7a5e5b0cb63acd0a95ad34db4e
2018-01-05 14:37:42 +01:00
Markus Stange dee289ad9c Bug 1436924 - Group mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers into a PartialThreadProfile struct that's heap-allocated on demand. r=njn
MozReview-Commit-ID: 5WNrIWLsiM1

--HG--
extra : rebase_source : 3ecf5efc3ce61a642187a1a675e9c014f468eee5
2018-02-09 00:56:55 -05:00
Markus Stange 16a2f41aaa Bug 1355566 - Make sure js::EnableContextProfilingStack(cx, false) is called before shutdown collection. r=njn
MozReview-Commit-ID: 6cPCSeTUdEP

--HG--
extra : rebase_source : 98b6617a3bab4698c03921d451052ff5177ad202
2018-02-08 16:43:23 -05:00
Andreea Pavel 6d6533a2eb Backed out changeset 50705220c972 (bug 1437226) for failing linting opt at tools/lint/test-disable.yml:3:81 on a CLOSED TREE 2018-02-10 12:37:09 +02:00
Kyle Machulis 3f3c0092cd Bug 1437226 - Fix text-disable linter message; r=ahal
MozReview-Commit-ID: KA9y8AwgVj8

--HG--
extra : rebase_source : 825870b68071d6d1c98d654b5ace3911a191c603
2018-02-09 16:42:00 -08:00
Benjamin Bouvier 3d5c7891a5 Bug 1319203: Fix asm.js profiler test; r=me 2018-02-09 14:47:10 +01:00
Andi-Bogdan Postelnicu 9ca255c241 Bug 1405554 - Merge clang-format with clang-tidy under the same package from toolchains. r=gps
MozReview-Commit-ID: 1XokTUVmVPL

--HG--
extra : rebase_source : bd52ecd720eb3a0a145660c3c5b55922f571f9fb
2018-02-09 09:01:17 +02:00
Edouard Oger a0cec42f04 Bug 1415951 - Extend TPS to support Addresses and Credit Cards. r=tcsc
MozReview-Commit-ID: 8VKBvm60ZSH

--HG--
extra : rebase_source : 88cb7b4145db018517c920907da79c70c46d50d2
2018-02-05 14:39:32 -06:00
Andrew Halberstadt 1805dcb2d3 Bug 1436792 - [py-compat] Fix issue opening the temporary manifest on Windows, r=jmaher
MozReview-Commit-ID: FmA1K8osuqe

--HG--
extra : rebase_source : ee557c78b1c959caa10a7862fbc732b4cf11792e
2018-02-08 14:26:27 -05:00
Andrew Halberstadt 4c232ca311 Bug 1436792 - [py-compat] Improve error messaging when python is missing, r=jmaher
This patch makes a few changes around error handling:

1) Prints the name of the linter that produced non-json output
2) Changes the 'python not found' error to a warning (as this is not fatal)
3) Makes sure said warning only gets printed once (by moving it to the setup function)

MozReview-Commit-ID: Dkq7CulTs91

--HG--
extra : rebase_source : 5d4bd32a62264a88520c09420f5acd90edcdc740
2018-02-08 14:26:15 -05:00
Noemi Erli b6751c929f Backed out changeset c9d150401eea (bug 1436639) for potential local workflow issues r=ahal on a CLOSED TREE 2018-02-08 19:45:07 +02:00
Margareta Eliza Balazs 9ab2f0f44f Backed out changeset 773a25b97a66 (bug 1405554) for f8 lint failure in /builds/worker/checkouts/gecko/tools/mach_commands.py on a CLOSED TREE 2018-02-08 19:36:21 +02:00
Andi-Bogdan Postelnicu 51fc404396 Bug 1405554 - Merge clang-format with clang-tidy under the same package from toolchains. r=gps
MozReview-Commit-ID: 1XokTUVmVPL

--HG--
extra : rebase_source : 13cab9c90d98da10dcafbe788c4e8b67fcd56803
2018-01-31 11:02:23 +02:00
Andrew Halberstadt aaea466286 Bug 1436725 - [lint] Remove obsolete eslintvalidate files, r=standard8
As the eslintvalidate linters haven't been doing anything but printing
an error message for a month, this is just cleanup.

MozReview-Commit-ID: 5dhrSmEv0Gi

--HG--
extra : rebase_source : 30e588f47a69b152f72d29e6aaab7efbd59fbf09
2018-02-08 09:25:14 -05:00
Andrew Halberstadt eced3471fc Bug 1436639 - [lint] Make sure flake8 is run with same python as |mach lint| was, r=jmaher
This fixes a bug which can happen when the default version of python differs from
the version of python used with mach.

For example, mach explicitly looks for python2.7. This means running |mach lint -l flake8|
should also run flake8 with version 2.7. But if the default is python3, and flake8 is also
installed there, the subprocess call that invokes flake8 will run under python3. This can
lead to errors like "undefined name 'basestring'" and other 2to3 gotchas.

This patch ensures that we run:
python2.7 -m flake8

which explicitly runs flake8 against the same interpreter as mach, no matter the default.

MozReview-Commit-ID: HSuMzDsAvsW

--HG--
extra : rebase_source : d39f97ed0f82f4d2c81f044ef1f7dad0953a3d8d
2018-02-07 23:28:33 -05:00
Mark Banner 2fd2fd7199 Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
MozReview-Commit-ID: 1LlfamNvBEM

--HG--
extra : rebase_source : 8e41e5a5f67bfd43444fde25287cb3709452a349
2018-02-07 16:16:09 +00:00
Mark Banner b4f572f5fa Bug 1436389 - Upgrade ESLint to version 4.17.0. r=mossop
MozReview-Commit-ID: I4KBELxhBlM

--HG--
extra : rebase_source : d206fb88f8c70d161cc0541a068db1b2f02e7a37
2018-02-07 16:01:29 +00:00
Markus Stange 7a2c359a92 Bug 785440 - Move profiler_is_active() implementation (and RacyFeatures) into GeckoProfiler.h. r=njn
MozReview-Commit-ID: D8y5RK2t6N4

--HG--
extra : rebase_source : 50513145561a1123c47741cb845e9b4adcf104a0
extra : intermediate-source : 85c8d7e4a5eb1616d36d4ec7916e3b077da3b236
extra : source : 5dda2adf525363b32844ea8162235fae3b54d17d
2017-08-02 14:39:55 -04:00
Markus Stange a91565e4f5 Bug 1433583 - Discard information about old dead threads that no longer have any samples in the buffer. r=mystor
MozReview-Commit-ID: 5ThtN1H1ieA

--HG--
extra : rebase_source : f853ff92147a4d57fd778723eda32c78847e8ca5
extra : source : 61ede7cb13a5de066601492ca34eb97e17e3e6fe
2018-01-30 16:00:29 -05:00
Julien Wajsberg 7642763ce5 Bug 1428072 - 3/3 - Add a mochitest to test profiling better r=mstange
MozReview-Commit-ID: BOoS37yFznU

--HG--
extra : rebase_source : bf5e87333dcfe4eceedc8d904fe49f34ff029aec
2018-01-31 15:11:51 +01:00
Julien Wajsberg dc7beae272 Bug 1428072 - 2/3 - Reorganize mochitest files for the profiler r=mstange
We extract some common framework to run profiler tests.

MozReview-Commit-ID: 7FPcH1NpJ7S

--HG--
extra : rebase_source : a487cb34c50889112eaecc8a20553365cfb70cfa
2018-01-31 10:51:19 +01:00
Julien Wajsberg cf225ab9c6 Bug 1428072 - 1/3 - Change the implementation of isChromeJSScript so that it doesn't crash for workers r=bz,sfink
In this patch we also expose a script's compartment in jsfriendapi.h

MozReview-Commit-ID: LgoN8ANLgxI

--HG--
extra : rebase_source : a9a29e538041ac574b6b44fab166a7838fce54ac
2018-01-18 17:14:09 +01:00
Mark Banner 54c4111311 Bug 1230369 - Add ESLint rules to disallow defining Cc/Ci etc and to prefer the use of Cc/Ci rather than the Components.* equivalents. r=florian
MozReview-Commit-ID: 9eAgUO3iIJW

--HG--
extra : rebase_source : 3208d5f74477733e4c81206613f74d7c7821ac0d
2018-02-06 22:40:12 +00:00
Mark Banner 606beee3f2 Bug 1230369 - Manually fix some remaining instances of Ci/Cc/Cu definitions and switch Components.* to using the shorthand in some places. r=florian
MozReview-Commit-ID: 9SmoR9RlvZE

--HG--
extra : rebase_source : 054e14150921615ed67415ddb91b45169cc868d4
2018-02-07 09:24:15 +00:00
Markus Stange 78b15a3110 Bug 1434968 - Clear mUniqueStacks, mSavedStreamedSamples and mSavedStreamedMarkers when the profiler is stopped. r=njn
MozReview-Commit-ID: L1Lk0sj2Bub

--HG--
extra : rebase_source : 842b53979122b20687b64278c2be6e706c92991e
2018-02-06 17:45:39 -05:00
Andrew McCreight 754a4bcd3c Bug 1432992, part 2 - Manually remove some empty blocks. r=florian
Also, remove a now-obsolete comment from placesOverlay.xul and remove
some now-empty XPCShell test head files.

MozReview-Commit-ID: 6kKVQu8FAL3

--HG--
extra : rebase_source : 7dd05818d68a15bd170af734078db4ba45029d80
2018-01-25 16:52:25 -08:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Markus Stange 7e880fe1f8 Bug 1431179 - Keep all exit profiles that overlap with the parent process's buffer time range. r=mconley
MozReview-Commit-ID: 1DIYQZ70ckR

--HG--
extra : rebase_source : f7f5e8e2d0380b54c50cb20b3d109cb476a2530f
extra : source : 612e54e7001a5907761d831b92aed5cee0deb017
2018-02-06 15:29:05 -05:00
Markus Stange 125c79a8ce Bug 1431179 - Remove the API to obtain the time of the first sample during profile streaming. r=mystor
MozReview-Commit-ID: KfZLNIAx4gy

--HG--
extra : rebase_source : 6b1a2dc19955a3a19877403f36d9dad551a9dc8a
extra : source : 6a241d9b3d1adf1afa72aab53ef8e15ece75fe90
2018-01-26 15:30:55 -05:00
Markus Stange 030cf34ac9 Bug 1431179 - When storing an exit profile, remember the current write position of the parent process's profiler buffer, instead of a TimeStamp. r=mystor
MozReview-Commit-ID: 3SFo9r5VrcZ

--HG--
extra : rebase_source : 2be8143e369de6dab82e1c1ef40a049aa478276c
extra : source : 9531d79fa5c3de2051a31fc475f6bbe3c93659a6
2018-01-30 13:28:35 -05:00
Markus Stange 49d6d03730 Bug 1348959 - Remove wraparound indexing in ProfileBuffer. r=djvj,mystor,njn
MozReview-Commit-ID: LeBFSRE6GXR

--HG--
extra : rebase_source : c46c0cd0dd543a367f72000e3cae65260a25b365
extra : source : 0f2e9dd7d45551d40944e4219e5a9eb92d54b2c4
2018-02-06 00:25:30 -05:00
Markus Stange 519cb27db8 Bug 1348959 - Make profiler_get_buffer_info() return information in a struct instead of using outparams. r=mystor,njn
MozReview-Commit-ID: 1iJ05NxOdou

--HG--
extra : rebase_source : 1c4e654340630b0f21c165b41b8fc1be30743c48
extra : source : 64b1a4108f6c3319cfc74c1246bdd2e895e93e1a
2018-01-18 17:54:57 -05:00
Markus Stange 656fd03724 Bug 1348959 - Make ProfileBuffer fields uint32_t. r=mystor,njn
MozReview-Commit-ID: veIGhEQyK5

--HG--
extra : rebase_source : 2c1853f666afd300ff82a2717f1a7caf9a19cf98
extra : source : e3d8bdc726d6045f69f3c3efa4e91c499a418428
2018-01-18 17:54:33 -05:00
Narcis Beleuzu 0777e2f8f7 Backed out Bug 1428072 for mochitest-chrome leaks
Backed out changeset b39c21c2a7a4 (bug 1428072) for mochitest-chrome leaks
***
Backed out changeset 9acb3d3eb5bc (bug 1428072)
***
Backed out changeset b5a327bb02d4 (bug 1428072)

--HG--
extra : histedit_source : 9de43525a11c34bb0e48c0820857d1731d4e7a08%2Cd3f59b67cd382c41cd0b68fd0f7a521a1051d20c
2018-02-06 15:48:32 +02:00
Julien Wajsberg ca83804232 Bug 1428072 - 3/3 - Add a mochitest to test profiling better r=mstange
MozReview-Commit-ID: 7tNEXHzFzRo

--HG--
extra : rebase_source : 3cb7fe208f6048c286c62be3216d09d5ea4eace4
2018-01-31 15:11:51 +01:00
Julien Wajsberg 163c3aa665 Bug 1428072 - 2/3 - Reorganize mochitest files for the profiler r=mstange
We extract some common framework to run profiler tests.

MozReview-Commit-ID: 7ct5RMhwmOe

--HG--
extra : rebase_source : 01165c506a4325310c23c9be6de2f5e6f958cf00
2018-01-31 10:51:19 +01:00
Julien Wajsberg 51a60aaee4 Bug 1428072 - 1/3 - Change the implementation of isChromeJSScript so that it doesn't crash for workers r=bz,sfink
In this patch we also expose a script's compartment in jsfriendapi.h

MozReview-Commit-ID: JGTLygZ6DK5

--HG--
extra : rebase_source : 585edbdbc74044f2d644f5046513786ee4f42a2f
2018-01-18 17:14:09 +01:00
Andrew Halberstadt eb84bf741c Bug 1429457 - [mozlint] Create formal 'setup' mechanism for bootstrapping lint dependencies, r=gbrown
This allows linters to define a 'setup' method which will automatically be
called by |mach lint| before running the linter. Users can also explicitly run
these methods (without doing any actual linting) by running |mach lint --setup|.

MozReview-Commit-ID: 74aY1pfsaX1

--HG--
extra : rebase_source : e6a7d769ba14c996c7a77316928063fa46358c5a
2018-01-25 13:40:02 -05:00
Nick Alexander 9d65a9cea8 Bug 1435424 - Remove doxygen support from the build system. r=gps
This is ancient and the team that used it (gfx) is no longer using it.

MozReview-Commit-ID: HrDgmAU9QeW

--HG--
extra : rebase_source : c4a64965c4ae1a50888893e881a6e8a9688a58b6
2018-02-02 14:24:18 -08:00
Andrew Halberstadt 4a7ebcb3bb Bug 1434430 - [flake8] Upgrade version of flake8 used by |mach lint| to 3.5.0 r=rwood
MozReview-Commit-ID: BBtM4TEl4Ve

--HG--
extra : rebase_source : 94d276746401426c9adcae5c962380679ffcb083
2018-01-30 16:43:10 -05:00
Andrew Halberstadt f354075c7a Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood
This is a new issue that gets linted with flake8 3.5.0. Basically you should
never use a blank except: statement.

This will catch all exceptions, including KeyboardInterrupt and SystemExit
(which is likely not intended). If a catch all is needed, use
`except: Exception`.  If you *really* mean to also catch KeyboardInterrupt et
al, use `except: BaseException`.

Of course, being specific is often better than a catch all.

MozReview-Commit-ID: FKx80MLO4RN

--HG--
extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b
2018-01-31 14:32:08 -05:00
Andrew Halberstadt 974ae38a52 Bug 1434430 - [flake8] Drop support for the FLAKE8 environment variable r=rwood
The flake8 linter requires a specific version of flake8, so that running it
locally vs in CI vs in mozreview will all produce the same results.

Allowing consumers to specify a custom flake8 binary via the FLAKE8 environment
variable, subverts that goal and can result in unexplained errors showing up in
some configurations but not others.

MozReview-Commit-ID: 1s0nC8ZO6Qi

--HG--
extra : rebase_source : f3913e2bce7770edf8deba18890f063975ca0844
2018-01-31 14:05:52 -05:00
Gurzau Raul bb16936244 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-02-02 00:25:44 +02:00
Gurzau Raul 1315ffda06 Merge inbound to mozilla-central. a=merge 2018-02-02 00:22:39 +02:00
Florian Quèze fcd9a3a0c8 Bug 1339461 - add an eslint rule to detect when indexOf should be replaced with includes, r=Standard8. 2018-02-01 20:47:23 +01:00
Florian Quèze 2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Andrew McCreight cf2f48b80d Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
MozReview-Commit-ID: 4PyMh0WeA4r

--HG--
extra : rebase_source : 868258ad6d98698f13faee5d6af67adcb20b63a2
2018-01-25 09:45:45 -08:00
Bogdan Tara 5c052cc871 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-01-31 12:10:31 +02:00
Bogdan Tara 1a6614b8b5 Merge inbound to mozilla-central. a=merge 2018-01-31 12:00:14 +02:00
Mark Banner 9a2172526a Bug 1434449 - Enable no-unused-vars for the global (as well as local) scope on jsm files, whitelist directories still to be fixed. r=florian.
MozReview-Commit-ID: 3vBWDR3UjGF

--HG--
extra : rebase_source : 61495d14a8d761e71b4072b02e2ca57e77f44059
2018-01-30 22:10:08 +00:00
Dorel Luca aefaa99a3a Backed out 3 changesets (bug 1431755) for Mochitest failure on test_profile_worker_bug_1428076.html on a CLOSED TREE
Backed out changeset c1befb56cf4d (bug 1431755)
Backed out changeset 8116e9cfc3f0 (bug 1431755)
Backed out changeset 1878f143ccda (bug 1431755)
2018-01-31 00:58:04 +02:00
arthur.iakab c4dd80eca3 Merge mozilla-central to autoland 2018-01-31 00:41:58 +02:00
Mark Banner 15e66f33ed Bug 1434332 - Add a checklist for adding new linters to the tree. r=ahal
MozReview-Commit-ID: FnYIXS5oZvW

--HG--
extra : rebase_source : 2eba61a24a4ca313f3c1d65adef454e34c57bdb5
2018-01-30 16:55:20 +00:00
Byron Campen [:bwc] da943dc517 Bug 1431755 - Part 3: Remove a redundant dispatch that was causing us to record the duration of _two_ dispatches instead of one. r=mstange
MozReview-Commit-ID: E8lSvMbGjt6

--HG--
extra : rebase_source : b303d66dfedcaa272cd851563a1a7585c4779fac
2018-01-19 10:03:35 -06:00
Byron Campen [:bwc] 44f6431bb0 Bug 1431755 - Part 2: Teach GeckoProfiler to profile responsiveness on nsIThreads. r=mstange
MozReview-Commit-ID: AqpNf9pDzrg

--HG--
extra : rebase_source : d873d9f05115004417b4c0d98dd8dceaef263172
2018-01-19 09:42:47 -06:00
Dorel Luca 0e6d4442ff Backed out 2 changesets (bug 767640) for talos failure on scripts/MozillaFileLogger.js on a CLOSED TREE
Backed out changeset 073aecb9bee5 (bug 767640)
Backed out changeset 6bc5ccfb1bd3 (bug 767640)
2018-01-30 21:53:28 +02:00
Jim Chen 149e502c72 Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward
Modern NDK headers all have <link.h>, so we should always include it,
and still provide shims for anything we need that's not defined in
<link.h>.

MozReview-Commit-ID: GNBDIe73RFm

--HG--
extra : rebase_source : 1246dce8a7ad201cf4f01de8e4912217636f1fc8
2018-01-30 14:08:23 -05:00
Andrew McCreight aa6a1107ab Bug 767640, part 2 - Update eslint rules to take into account the definitions of Ci, Cr, Cc and Cu. r=florian
MozReview-Commit-ID: 4PyMh0WeA4r

--HG--
extra : rebase_source : da3db733d6c682ee137c90f8a5a9afaf85713c48
2018-01-25 09:45:45 -08:00
Kris Maglione 19a956c2c6 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
2018-01-18 16:27:26 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Kris Maglione 6425ff4f8d Bug 1431533: Part 4 - Add ESLint support for ChromeUtils import methods. r=florian
This adds support for detecting globals created by these helpers, as well as a
rule to enforce their use over the older XPConnect variants.

The latter rule also supports fixing code to use the newer variants, and will
be used in the next part to rewrite in-tree ESLint-enabled code that fails it.

MozReview-Commit-ID: 6Bgo6ohQA5j

--HG--
extra : source : fbef09c3e8af1653f270db589f73f2786c23ddc2
extra : intermediate-source : e2674287e57fbf6835729f42b8491359c2c4bfd5
2018-01-18 12:53:01 -08:00
Csoregi Natalia 1d557a2997 Merge mozilla-central to inbound. a=merge CLOSED TREE 2018-01-30 18:24:05 +02:00
Makoto Kato 7b895ca1a7 Bug 1433775 - Add Linux/arm support to Gecko Profiler. r=mstange
We don't support Android for Gecko Profiler extension yet.

So for investigating arm issue, I would like to add initial support of
Gecko Profiler for Linux/arm.

--HG--
extra : rebase_source : f936a97a87b7eea2ebfefe3cbc7f8791bc90d03a
2018-01-29 18:01:23 +09:00
Cosmin Sabou c6a0d55423 Backed out 11 changesets (bug 1428182) for build bustages on pixman-inlines.h:29:10 on a CLOSED TREE
Backed out changeset 84c767de6202 (bug 1428182)
Backed out changeset 429433caa78c (bug 1428182)
Backed out changeset c576e9d1f68f (bug 1428182)
Backed out changeset 092662eab5eb (bug 1428182)
Backed out changeset 4dd7eaff3ab5 (bug 1428182)
Backed out changeset fbbb0745b139 (bug 1428182)
Backed out changeset 1d1278b289b7 (bug 1428182)
Backed out changeset 55891ffb3768 (bug 1428182)
Backed out changeset 4655e1b1b237 (bug 1428182)
Backed out changeset 377eada51b3c (bug 1428182)
Backed out changeset 17c0e373d921 (bug 1428182)

--HG--
rename : ipc/chromium/src/third_party/libevent/patches/android-api-level.patch => ipc/chromium/src/third_party/libevent/patches/android-arc4random-buf.patch
2018-01-30 01:22:33 +02:00
Jim Chen 80635d981e Bug 1428182 - 7. Include <link.h> in LUL for Android; r=jseward
Modern NDK headers all have <link.h>, so we should always include it,
and still provide shims for anything we need that's not defined in
<link.h>.

MozReview-Commit-ID: GNBDIe73RFm

--HG--
extra : rebase_source : f1f2eddc73dc1accb3a1eb8445600b015e9e7d52
2018-01-29 17:38:14 -05:00
George Dan, Ryan Neilsen, Dylan Turner 4cbac2527f Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN
--HG--
rename : browser/extensions/formautofill/ProfileStorage.jsm => browser/extensions/formautofill/FormAutofillStorage.jsm
extra : rebase_source : aa456b06046f1d995d65bec13044cde081559061
extra : histedit_source : 620bdb1c33de4b4b656066ea6432826f3631c3b4
2018-01-30 14:44:59 -08:00
Simon Fraser 5acab0f13e Bug 1432627 Add shellcheck linter to CI r=ahal
MozReview-Commit-ID: 2IYUsXunfab

--HG--
extra : rebase_source : 806ab4abfb1838a1b5eec279f5e93ce5c703685d
2018-01-29 15:27:04 +00:00