Граф коммитов

1107 Коммитов

Автор SHA1 Сообщение Дата
Byron Campen [:bwc] 31d04825a1 Bug 1651601: Filter gathered candidates when their component is obsolete. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D83138
2020-07-10 17:11:32 +00:00
Byron Campen [:bwc] cc064d5d0d Bug 1649314: Null-check before calling memcpy to avoid UBSan warnings. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D82728
2020-07-08 16:09:33 +00:00
Byron Campen [:bwc] 9806d64c46 Bug 1193437: Use config structs in NrIceCtx, and centralize pref lookups some. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D82549
2020-07-09 15:36:07 +00:00
Byron Campen [:bwc] 40f9bf512c Bug 1326005: Make this log at INFO because that's the level we log on the sending side. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D82035
2020-07-08 18:00:20 +00:00
Narcis Beleuzu 0515bebd4d Backed out changeset e1841978b15a (bug 1193437) for bustages on ice_unittest.cpp 2020-07-08 07:52:53 +03:00
Byron Campen [:bwc] ab9a9c5d68 Bug 1193437: Use config structs in NrIceCtx, and centralize pref lookups some. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D82549
2020-07-07 17:14:38 +00:00
Byron Campen [:bwc] f92cc316ae Bug 1649678: Add include needed by OpenBSD. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D82531
2020-07-07 16:33:50 +00:00
Simon Giesecke cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Jean-Yves Avenard 4f53bc5dc3 Bug 1647133 - P3. Use nsISerialEventTarget where it's actually that. r=valentin
All uses are always the main thread and its derivative (obtained via EventTargetFor method) or nullptr.

Depends on D80421

Differential Revision: https://phabricator.services.mozilla.com/D80422
2020-06-22 11:13:24 +00:00
Andrea Marchesini 0f29634160 Bug 1646273 - Add a nullptr check in ns_socket_tcp before sending data, r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D79950
2020-06-18 15:41:36 +00:00
Byron Campen [:bwc] 1c3be2b686 Bug 1644477: Make candidate pair insertion code easier to read/understand. r=mjf
Includes removing an error code for a function that never fails, and removing
an error return when the function successfully did what it said it would.

Differential Revision: https://phabricator.services.mozilla.com/D78929
2020-06-09 19:44:50 +00:00
Byron Campen [:bwc] 3567dc05dc Bug 1643169: Use ifr_ifru.ifru_flags6 instead of the ifr_flags macro, because the latter does not work properly on FreeBSD. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D78319
2020-06-04 15:56:46 +00:00
Byron Campen [:bwc] c5a5efa985 Bug 1183145: Teach platform-specific code to filter out inappropriate IPv6 addresses, and mark temp addresses. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D75962
2020-05-26 15:58:44 +00:00
Byron Campen [:bwc] 395beb03b2 Bug 1183145: Move platform-specific code from addrs.c into separate files. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D75947
2020-05-26 15:26:27 +00:00
Byron Campen [:bwc] 75a91dc755 Bug 1183145: Add a flags field to nr_local_addr so IPv6 addresses can be marked as temporary, and filter non-temp IPv6 if temp IPv6 are available. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D76043
2020-05-26 16:03:38 +00:00
Byron Campen [:bwc] 11d0805c75 Bug 1183145: Rename a function to better reflect what it does, and fix a bug where handling of teredo and mac-based IPv6 was mixed up. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D76042
2020-05-26 16:02:11 +00:00
Dan Minor 9db7328409 Bug 1640668 - Remove unwrap() call from MDNSService start; r=mjf
Unwrap asserts if there is an error, ? will propogate it back to the caller
which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D77291
2020-05-28 16:46:54 +00:00
Dan Minor d7b3697b38 Bug 1638361 - Remove uuid generation code from mdns_service; r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D76708
2020-05-26 18:30:20 +00:00
Dan Minor a090854892 Bug 1638361 - Use nsIUUIDGenerator in NrIceCtx::GenerateObfuscatedAddress; r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D76707
2020-05-26 19:40:26 +00:00
Byron Campen [:bwc] 69fe649c2c Bug 1639916: Clean up pstream if we don't end up using it. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D76359
2020-05-21 19:05:07 +00:00
Simon Giesecke 61ad805d68 Bug 1626570 - Use CopyableTArray in ipdlc as member type for now. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D73685
2020-05-07 08:11:08 +00:00
Byron Campen [:bwc] 213a5cff8c Bug 1634145: Avoid leaking nr_ice_sockets due to various kinds of failure. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D73287
2020-05-04 12:00:26 +00:00
Dan Minor d0b4c7e527 Bug 1626029 - Don't attempt to resend mDNS packets on EPERM; r=mjf
We currently retry sending queries on all failures to write to the socket on
the assumption that write errors represent transient errors. With this change,
we treat EPERM has a permanent error and drop queries if we see it. This is
not a problem when sending answers, as we don't retry in case of errors there,
on the assumption that the other side will retry their query in the future.

We do have code to limit the number of times we attempt an mDNS query, but we
didn't hit it in this case, because it only counts sends that are successful.

Differential Revision: https://phabricator.services.mozilla.com/D73492
2020-05-04 14:19:42 +00:00
Kershaw Chang 4db371a46e Bug 1512478 - Use sync IPC to get client auth data from parent process r=keeler,mccr8
Differential Revision: https://phabricator.services.mozilla.com/D36911
2020-04-28 20:12:43 +00:00
Byron Campen [:bwc] 68ded2fc51 Bug 1629565: Some logging that was helpful. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D72243
2020-04-27 14:38:26 +00:00
Byron Campen [:bwc] ff27555ac8 Bug 1629565: Transition gathering state to "new" if a negotiation leaves us with no transports. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D72242
2020-04-27 14:40:00 +00:00
Byron Campen [:bwc] 638490970c Bug 1629565: Fix bug where rollback of local offer would stomp the pre-existing transport with a new one with the same ufrag/pwd. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D72240
2020-04-27 14:42:13 +00:00
Byron Campen [:bwc] c98c1674f6 Bug 1629565: Do not transition back to "gathering" if no gathering is needed. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D72238
2020-04-27 14:36:39 +00:00
Michael Froman 8f02f0cbfa Bug 1629529 - fix shutdown dispatch assert in WebrtcTCPSocket. r=bwc
If we're shutting down and mSocketThread is no longer accepting work,
this dispatch can fail.  As far as I can see, fully fixing this would
require changes to nsIThread in order to allow checking whether the
thread is shutting down.

Differential Revision: https://phabricator.services.mozilla.com/D71964
2020-04-24 15:37:39 +00:00
Narcis Beleuzu 903cd347ea Backed out changeset 9d1756abffd2 (bug 1629529) for bustages on WebrtcTCPSocket.cpp . CLOSED TREE 2020-04-24 05:14:40 +03:00
Michael Froman eb2222bf34 Bug 1629529 - fix shutdown dispatch assert in WebrtcTCPSocket. r=bwc
If we're shutting down and mSocketThread is no longer accepting work,
this dispatch can fail.  As far as I can see, fully fixing this would
require changes to nsIThread in order to allow checking whether the
thread is shutting down.

Differential Revision: https://phabricator.services.mozilla.com/D71964
2020-04-23 21:42:21 +00:00
Narcis Beleuzu b6a26db6c8 Backed out changeset fabb6fb27e8a (bug 1629529) for being an incorrect fix. CLOSED TREE 2020-04-23 20:54:55 +03:00
Michael Froman b5392b2074 Bug 1629529 - fix shutdown dispatch assert in WebrtcTCPSocket. r=bwc
If we're shutting down and mSocketThread is no longer accepting work,
this dispatch can fail.  As far as I can see, fully fixing this would
require changes to nsIThread in order to allow checking whether the
thread is shutting down.

Differential Revision: https://phabricator.services.mozilla.com/D71964
2020-04-22 14:33:01 +00:00
Dan Minor b4a9997899 Bug 1624253 - Catch panic in mdns_service_generate_uuid; r=mjf
In rare cases, the random number generator can fail to initialize when
generating a v4 UUID, causing a panic and crash. This adds code to catch that
panic and return a nil (all zeros) UUID instead. Using a nil UUID seems better
from a user privacy perspective than failing to obfuscate the host address and
leaking it when it is expected to be hidden.

Longer term, we might want to switch over to using nsIUUIDGenerator, but that
would require changes to how the socket process is initialized.

Differential Revision: https://phabricator.services.mozilla.com/D70172

--HG--
extra : moz-landing-system : lando
2020-04-08 14:20:38 +00:00
Andreas Farre 25ca8d7890 Bug 1620594 - Part 7: Remove TabGroup and SystemGroup. r=nika,bas
TabGroup never really made any difference in which thread something go
dispatched to. This was the intended use, but development of TabGroups
with abstract main threads never made it that far. The good thing is
that thish makes it safe to also remove to the SystemGroup and instead
switch all SystemGroup dispatches to dispatches to main thread.

Timers for setTimeout and workers were the sole users of wrapped and
throttled event targets, that those throttled queues have been moved
to the BrowsingContextGroup and are now accessed explicitly.

The SchedulerEventTarget has been removed, since there are no longer a
separate event target for every TaskCategory. Instead a
LabellingEventTarget has been added to DocGroup to handle the case
where an event is dispatched do DocGroup or when an AbstractThread is
created using a DocGroup. This means that we'll actually label more
events correctly with the DocGroup that they belong to.

DocGroups have also been moved to BrowsingContextGroup.

Depends on D67636

Differential Revision: https://phabricator.services.mozilla.com/D65936

--HG--
extra : moz-landing-system : lando
2020-04-07 15:17:47 +00:00
Valentin Gosu f29e4186dd Bug 1625213 - Make txt records be resolved with onLookupComplete r=dragana
This patch makes nsIDNSByTypeRecord extend nsIDNSRecord, but implementations
will safely forward the nsIDNSRecord methods to `nullptr`, meaning they will
throw an error when called.

Consumers should try to QI the nsIDNSRecord to nsIDNSByTypeRecord (or any
future types) and use that.

Differential Revision: https://phabricator.services.mozilla.com/D69326

--HG--
extra : moz-landing-system : lando
2020-04-07 12:39:45 +00:00
Emilio Cobos Álvarez 4b9fdf3d73 Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828

--HG--
extra : moz-landing-system : lando
2020-04-06 18:57:36 +00:00
Cosmin Sabou d557e2ed22 Backed out 3 changesets (bug 1627707) for build bustages @ mozilla::net::LoadInfo.
Backed out changeset 65d6a90651ce (bug 1627707)
Backed out changeset 378ec30d9979 (bug 1627707)
Backed out changeset 058a19e11b06 (bug 1627707)
2020-04-06 20:07:04 +03:00
Emilio Cobos Álvarez 97872f2fee Bug 1627707 - Rename LoadInfo::LoadingPrincipal to GetLoadingPrincipal as it can return null. r=ckerschb
Mostly a matter of:

  rg -l '\->LoadingPrincipal' | xargs sed -i 's/->LoadingPrincipal/->GetLoadingPrincipal/g'

And then clang-format. But I tweaked manually nsHttpChannelAuthProvider (move
the variable where it's used, don't take a useless strong ref),
AddonContentPolicy (move the declaration of the variable to the if condition),
and BackgroundUtils (same).

Differential Revision: https://phabricator.services.mozilla.com/D69828

--HG--
extra : moz-landing-system : lando
2020-04-06 16:00:43 +00:00
Michael Froman 3973d5ec78 Bug 1609124 - check for associated IP address on interface for ICE dualstack operation. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D69245

--HG--
extra : moz-landing-system : lando
2020-04-01 20:38:26 +00:00
André Bargull a08be4177e Bug 1625138 - Part 17: Replace mozilla::Decay with std::decay. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D68372

--HG--
extra : moz-landing-system : lando
2020-03-28 13:57:15 +00:00
Byron Campen [:bwc] 4d035f7c82 Bug 1624458: Make sure we cancel callbacks in close. r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D68042

--HG--
extra : moz-landing-system : lando
2020-03-24 16:19:42 +00:00
Nils Ohlmeier [:drno] 3961f9751a Bug 1615443: re-add DTLS protocol version telemetry. r=dminor
Differential Revision: https://phabricator.services.mozilla.com/D62827

--HG--
extra : moz-landing-system : lando
2020-03-18 17:59:07 +00:00
Marcin Wojtczak e310487b92 Bug 1622759 - Don't fail when nr_interface_prioritizer_add_interface() returns R_ALREADY r=bwc
This allows us to continue adding remaining interfaces from addrs array and
makes sure nr_interface_prioritizer_sort_preference() is called at the end.

Differential Revision: https://phabricator.services.mozilla.com/D66941

--HG--
extra : moz-landing-system : lando
2020-03-18 16:54:07 +00:00
Sylvestre Ledru acd1b8f246 Bug 1622328 - mdns_service.h: Add the license r=dminor
Depends on D66809

Differential Revision: https://phabricator.services.mozilla.com/D66810

--HG--
extra : moz-landing-system : lando
2020-03-13 21:25:43 +00:00
Kevin Jacobs 1f7860ca02 Bug 1621036 - Enable DTLS 1.3 supported_versions workaround for interop between pre/post-Fx75 WebRTC. r=mt
Enable the NSS workaround introduced in bug 1619102, for DTLS 1.3 WebRTC clients.

Differential Revision: https://phabricator.services.mozilla.com/D66094

--HG--
extra : moz-landing-system : lando
2020-03-11 16:43:31 +00:00
Simon Giesecke 810fd1f507 Bug 1613985 - Use default for equivalent-to-default constructors/destructors in media. r=bwc
Differential Revision: https://phabricator.services.mozilla.com/D65494

--HG--
extra : moz-landing-system : lando
2020-03-06 09:21:47 +00:00
Dan Minor ac11c8363f Bug 1616667 - Fix remaining clippy complaints; r=mjf
Depends on D64381

Differential Revision: https://phabricator.services.mozilla.com/D64382

--HG--
extra : moz-landing-system : lando
2020-02-26 17:28:29 +00:00
Dan Minor d6bac2eaba Bug 1616667 - Add handle_mdns_socket function; r=mjf
Depends on D64380

Differential Revision: https://phabricator.services.mozilla.com/D64381

--HG--
extra : moz-landing-system : lando
2020-02-26 17:22:08 +00:00
Dan Minor 6d49ac2885 Bug 1616667 - Add handle_queries function; r=mjf
Differential Revision: https://phabricator.services.mozilla.com/D64380

--HG--
extra : moz-landing-system : lando
2020-02-26 17:24:17 +00:00