As js has different flags compared to the remaining parts of the
codebase, set a specific variable (namely MOZ_JS_OPTIMIZE_FLAGS) and use
it instead of MOZ_OPTIMIZE_FLAGS using a specific hook in
python/mozbuild/mozbuild/frontend/context.py
Also:
- harmonize moz_optimize_flags type to always return a list.
- moz_optimize now either returns "1" or None (no use case distinguishes
between returning 1 or 2)
Differential Revision: https://phabricator.services.mozilla.com/D216098
As js has different flags compared to the remaining parts of the
codebase, set a specific variable (namely MOZ_JS_OPTIMIZE_FLAGS) and use
it instead of MOZ_OPTIMIZE_FLAGS using a specific hook in
python/mozbuild/mozbuild/frontend/context.py
Also:
- harmonize moz_optimize_flags type to always return a list.
- moz_optimize now either returns "1" or None (no use case distinguishes
between returning 1 or 2)
Differential Revision: https://phabricator.services.mozilla.com/D216098
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40) is not labeled and is missing an interactive role of button, while it is functioning as one.
Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.
Differential Revision: https://phabricator.services.mozilla.com/D204413
This patch modifies the background-resource (formerly background-cpu) android test to collect resource information at distinct times rather than only at the end of the test run.
The collection script is split in two here for cpu, and memory. The python parsing script is also modified to be able to gather the resources from multiple files, and the name is changed to better reflect what it does.
This patch also renames the test to better reflect that it's a resource usage test and not just a cpu test.
Differential Revision: https://phabricator.services.mozilla.com/D217097
One notable change in this patch: a code path that checks for pre-existing distribution.ini and .desktop files.
If you place a distribution.ini or .desktop file in the root of any of the Linux .deb templates directories (paths specified in deb-templates and deb-l10n-templates), the supplied file will be used instead of generating or downloading a default file.
Differential Revision: https://phabricator.services.mozilla.com/D211141
Comma is the separator for values in options. Like in --with-foo=bar,baz.
This is meant to be useful for options with nargs="*", "+", or a fixed
value greater than 1.
Currently, when an option with another nargs is passed a comma, we
reject the value as being multiple values, while one or less is
expected. This causes problems with options with nargs=1 that actually
CAN have legitimate values containing commas. Examples include:
CFLAGS="-Wp,--preprocessor-flag -Wa,--assembler-flag"
LDFLAGS=-Wl,--linker-flag"
Since options with multiple arguments are the exception, not the norm,
let's allow commas in cases where at most a single argument is expected.
An alternative would be to explicitly disable comma-splitting on the set
of options that can take values containing commas, but that's error-prone.
Differential Revision: https://phabricator.services.mozilla.com/D217021
Instead, position MOZ_OPTIMIZE_FLAGS to -O3 under PGO on Linux.
This creates a dependency on PGO from toolchain.configure, break it by
splitting moz_optimize in two functions, one for the optimization status
and one for the optimization flags.
Differential Revision: https://phabricator.services.mozilla.com/D214843
Also instruct `mach` to use the vendored `glean_parser` instead of the one it
would otherwise pull down from `pip` as part of its `glean_sdk` dep.
This unfortunately ties updates of `mach`'s `glean_sdk` to any updates m-c gets
for its `glean_parser`. It's required to ensure `./mach build` always uses the
vendored `glean_parser` (see bug 1908020).
Differential Revision: https://phabricator.services.mozilla.com/D216717