My preference was to annotate most of the failing tests with `fail-if` so that
if they start passing, the `fail-if` needs to be removed and they need to keep
passing. That doesn't work for tests that timeout, or which trigger failures
from their cleanup functions, however, so those tests need skip-if. And tests
with fail in their cleanup functions likely leave the browser in an
inconsistent state for subsequent tests, anyway, so really should be skipped
regardless.
There are some remaining tests which still fail because of crashes. I chose
not to skip them here, but to fix the crashes in separate bugs instead.
Differential Revision: https://phabricator.services.mozilla.com/D38247
--HG--
extra : rebase_source : 39ba8fec2e882cfe577c5f2b58ab7e4b461f1178
Previously `mozvisualscroll` would close the reader dropdown and maybe even
hide the system UI and the 'reader-toolbar' entirely.
Because this would fire for any visual viewport scrolls which might happen when
the user choses any new font options it would inadvertently close that dropdown
and take the options away from the user even if he did not finish configurating
reader mode.
With this patch closing the reader dropdown will be the responsability of other
events firing and `mozvisualscroll` will only hide the 'reader-toolbar' if the
reader dropwdown is not currently opened signifying the user is in the process
of making changes to the reader mode experience.
Differential Revision: https://phabricator.services.mozilla.com/D25596
--HG--
extra : moz-landing-system : lando
Call Reader:ResetZoom only in readermode and make resetFontSize async
***
make resetFontSize async
***
call Reader:ResetZoom only in readermode
***
Differential Revision: https://phabricator.services.mozilla.com/D24445
--HG--
extra : moz-landing-system : lando
Before this change the plain text document in reader mode was not formatted/styled properly.
Differential Revision: https://phabricator.services.mozilla.com/D24541
--HG--
extra : moz-landing-system : lando
Font panel hides on mousedown instead of click, so that it disappears while user is selecting text
Differential Revision: https://phabricator.services.mozilla.com/D23904
--HG--
extra : moz-landing-system : lando
Under certain circumstances, the layout viewport (whose movement triggers the
regular "scroll" events) can end up larger than the visible screen area. In that
case, the scrolling behaviour can become confusing, as small scrolling movements
that aren't affecting the layout viewport's position no longer immediately hide/
show the floating action button and trigger immersive system toolbar mode.
Therefore, AboutReader.jsm needs to watch the *visual* viewport instead, whose
dimensions and position always reflect what is actually visible on-screen.
Differential Revision: https://phabricator.services.mozilla.com/D19263
--HG--
extra : moz-landing-system : lando
***
Bug 1514594: Part 3a - Change ChromeUtils.import to return an exports object; not pollute global. r=mccr8
This changes the behavior of ChromeUtils.import() to return an exports object,
rather than a module global, in all cases except when `null` is passed as a
second argument, and changes the default behavior not to pollute the global
scope with the module's exports. Thus, the following code written for the old
model:
ChromeUtils.import("resource://gre/modules/Services.jsm");
is approximately the same as the following, in the new model:
var {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm");
Since the two behaviors are mutually incompatible, this patch will land with a
scripted rewrite to update all existing callers to use the new model rather
than the old.
***
Bug 1514594: Part 3b - Mass rewrite all JS code to use the new ChromeUtils.import API. rs=Gijs
This was done using the followng script:
https://bitbucket.org/kmaglione/m-c-rewrites/src/tip/processors/cu-import-exports.jsm
***
Bug 1514594: Part 3c - Update ESLint plugin for ChromeUtils.import API changes. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D16747
***
Bug 1514594: Part 3d - Remove/fix hundreds of duplicate imports from sync tests. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16748
***
Bug 1514594: Part 3e - Remove no-op ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16749
***
Bug 1514594: Part 3f.1 - Cleanup various test corner cases after mass rewrite. r=Gijs
***
Bug 1514594: Part 3f.2 - Cleanup various non-test corner cases after mass rewrite. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16750
--HG--
extra : rebase_source : 359574ee3064c90f33bf36c2ebe3159a24cc8895
extra : histedit_source : b93c8f42808b1599f9122d7842d2c0b3e656a594%2C64a3a4e3359dc889e2ab2b49461bab9e27fc10a7
Most of the ReaderMode.jsm and Readability.js code is only needed when we
actually need to render a document in reader mode, but also winds up loaded
into any process where we ever check if a page is readerable. This winds up
wasting a huge amount of memory (and probably a huge amount of CPU time)
loading code which is almost never used.
This patch splits ReaderMode.jsm into two modules, one for checking
readability, one for actually entering reader mode. It also separates out the
isProbablyReaderable checks from Readability.js, since the overhead of loading
that script before it's needed is unsupportable.
This means we're probably going to need some effort to keep Readerable.jsm and
Readability.js in sync, but the code in question is pretty trivial, so it
shouldn't be too difficult.
Differential Revision: https://phabricator.services.mozilla.com/D3687
--HG--
rename : toolkit/components/reader/Readability.js => toolkit/components/reader/Readability-readerable.js
rename : toolkit/components/reader/ReaderMode.jsm => toolkit/components/reader/Readerable.js
extra : rebase_source : 66712057591ae20dd66234e3dc78fbba90a6914e
extra : amend_source : f908f62f49ea54b9099ddb87d9f2fc11f12d4dee
nsISHEntry.index is readonly, but if you pass `true` as getEntryAtIndex()'s
second argument, nsISHEntry.index will be modified. This is pretty gross.
This patch changes `index` so it's not readonly (because it's not!) and removes
getEntryAtIndex()'s second argument.
--HG--
extra : rebase_source : c519d77fcc1c3bda2f260b5888ce9cd0f6cfdab5
Automatic changes by ESLint, except for manual corrections for .xml files.
Differential Revision: https://phabricator.services.mozilla.com/D4439
--HG--
extra : moz-landing-system : lando
Thomas Nguyen
harry
Kris Maglione
Gijs Kruitbosch
Sylvestre Ledru
Andreea Pavel
Jonathan Kingston
Victor Porof
Nicklas Boman
Alexander Surkov
Cosmin Sabou
Andrea Marchesini
Brian Grinstead
Petru Lingurar
berkay.barlas
Trushita
Sonali9
monikamaheshwari
Jan Henning
Myk Melez
Christoph Kerschbaumer
Mike Conley
Brindusan Cristian
arthur.iakab
Tiberius Oros
Christian
Dão Gottwald
Nicholas Nethercote
Mark Banner
Bianca Danforth
vinoth