Граф коммитов

89 Коммитов

Автор SHA1 Сообщение Дата
Boris Zbarsky e4b74becff Bug 1479569 part 2. Use the new messageManager getter on docshell. r=kmag
I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.

I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have.  Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
2018-08-02 23:49:09 -04:00
Csoregi Natalia 08c950712e Backed out 3 changesets (bug 1479569) for devtools/client/responsive.html failures. CLOSED TREE
Backed out changeset e123d0aa911c (bug 1479569)
Backed out changeset b828a58404e5 (bug 1479569)
Backed out changeset 97041ef8f311 (bug 1479569)
2018-08-03 10:39:12 +03:00
Boris Zbarsky 0197de77c0 Bug 1479569 part 2. Use the new messageManager getter on docshell. r=kmag
I generally tried to preserve the behavior of consumers where they treated an
exception from getInterface(Ci.nsIContentFrameMessageManager) as a signal to use
some sort of fallback.

I did change the behavior of consumers that walked up to the root same-type
docshell before getting the message manager to just get it directly from the
docshell they have.  Please review those parts carefully, and let me know if you
want me to ask some subject area experts to review those.
2018-08-02 23:49:09 -04:00
Boris Zbarsky 0fcb24c18d Bug 1446940 part 1. Stop getting docshells from windows via getInterface in toolkit. r=gijs
The change to test_hiddenPrivateWindow.xul is to make sure we pass windows, not
docshells, to an API that expects windows.
2018-08-01 13:07:09 -04:00
Adrian Wielgosik 8c66c095f4 Bug 1418078 - Convert JS users of nsIDOMHTMLInputElement. r=bz
MozReview-Commit-ID: 55aIiNHS0xs

--HG--
extra : rebase_source : cacb9fc29daa5d620d4a0cd6ab3f09cde765036f
2018-04-18 22:29:50 +02:00
Kris Maglione a259026c9d Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY

--HG--
extra : rebase_source : a29c07530586dc18ba040f19215475ac20fcfb3b
2018-04-22 20:55:06 -07:00
Kris Maglione a7b308c3a2 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW

--HG--
extra : rebase_source : cffb1c9762191c579d1397c8169e6e7635d229da
extra : histedit_source : dea59ddd2daaae52069c5faceae9149a4f08dd73
2018-04-24 20:18:09 -07:00
Andrew McCreight 5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Kris Maglione 19a956c2c6 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : 09a90b29837e339eec7bdf8504f86c28e74ca3dd
extra : intermediate-source : a1eca62826a1341ca24d4d2a93d4884d4fc7ad51
extra : histedit_source : eb26e73b531f9a34d3401d39f60b533b27b78540
2018-01-18 16:27:26 -08:00
Kris Maglione 918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou 9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione e050496c59 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
extra : amend_source : d0515fe4eb13b59cc490ca9d964ad9ee15ef3cd3
extra : intermediate-source : 6e56f4c8843ed134b2dba34fb007298fd55be966
extra : histedit_source : 88abf9f4ea4e740a9391278625ef07395205c3f5%2Cc14bc7a71eb413fcb573ed0d030fd7f99a1468f0
2018-01-18 16:27:26 -08:00
Kris Maglione 6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione e70d01a9e9 Bug 1431533: Part 5b - Fix ESLint errors left over after rewrite. r=florian
MozReview-Commit-ID: 7bVI1iM6hor

--HG--
extra : rebase_source : 6286dcfd1a7c970272ac6befaccd3e47e90d2f6b
extra : intermediate-source : d48657228a0b84cf3a37a35227ca3b3d0bd2a017
extra : source : 0b97a30cadb1a96d3cafae6b79ef0d3ec26770cf
2018-01-18 16:27:26 -08:00
Kris Maglione c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Edouard Oger 8cb437aed8 Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7

--HG--
extra : rebase_source : 0557db8a84c98b0fa55b6a4f23fa8001876d559b
2017-09-22 15:19:56 -04:00
Sebastian Hengst dace60c516 Backed out changeset 553d26ab8ee8 (bug 1395427) 2017-09-27 17:10:26 +02:00
Edouard Oger a532988296 Bug 1395427 p2 - Include guid in formhistory-remove notifications. r=markh
MozReview-Commit-ID: Je0rV277d7

--HG--
extra : rebase_source : f2b03b68567a8d075dfbe3921d14bcc86c755d66
2017-09-22 15:19:56 -04:00
Jonathan Guillotte-Blouin d99dbdf74f Bug 1372427 - enforce "comma-dangle". r=MattN
auto --fix

MozReview-Commit-ID: KKmDI0Pt43K

--HG--
extra : rebase_source : 4917dbfc35a03dc0f8171006273b1e555f7b4c9b
2017-06-14 17:46:42 -07:00
Jonathan Guillotte-Blouin 59345808a2 Bug 1372427 - limit lines to a maximum of 100 chars. r=MattN
MozReview-Commit-ID: 3OSKaTMMBot

--HG--
extra : rebase_source : f6d9c00352003674c643089f158a8d116ae36a20
2017-06-13 16:48:31 -07:00
Jonathan Guillotte-Blouin 92bcf669ee Bug 1372427 - add js-doc rule. r=MattN
MozReview-Commit-ID: YgDBHM88PW

--HG--
extra : rebase_source : 449ab51180fdebf2fa6e0b9b6c1ee659a15355dc
2017-06-13 10:48:52 -07:00
Jonathan Guillotte-Blouin 13ec30c445 Bug 1372427 - add semi-colon rule. r=MattN
auto --fix

MozReview-Commit-ID: F9GvxcghPkt

--HG--
extra : rebase_source : f88445b573583d50333249570aa80c3e2314b0c3
2017-06-13 09:51:07 -07:00
Jonathan Guillotte-Blouin 669e2f0d5e Bug 1372427 - Add indentation rules. r=MattN
MozReview-Commit-ID: 62a7RvVlcco

--HG--
extra : rebase_source : 6f2f81af33e14850ab72d64f9b2973f9f06bcfb6
2017-06-12 15:45:00 -07:00
Jonathan Guillotte-Blouin 3935be31a9 Bug 1374427 - remove redundant function names in js-doc. r=MattN
MozReview-Commit-ID: 3EBT7CDl3pC

--HG--
extra : rebase_source : 74fafb71abb6b09f003c87e691f3a050c744c535
2017-06-19 14:11:21 -07:00
Jonathan Guillotte-Blouin 9173319dd6 Bug 1371554 - Change .indexOf(...) == 0 to the more expressive .startsWith(...). r=mattn.
MozReview-Commit-ID: Jr3ALp6v2rM

--HG--
extra : rebase_source : 5e8628e462c5a311ac5ec4e936d0ad38e97659e5
2017-06-06 13:35:34 -07:00
Jonathan Guillotte-Blouin 4eb32a2872 Bug 1365068 - import with destructuring, switch to shorthand function declarations and use array.includes. r=MattN
MozReview-Commit-ID: IfmePvN8WnA

--HG--
extra : rebase_source : 9f7d272ae66bbfde81d777cff9a17eebb1ec98b8
2017-05-16 18:23:56 -07:00
Jonathan Guillotte-Blouin 5aafed5567 Bug 1365068 - normalize indentation to 2 spaces. r=MattN
MozReview-Commit-ID: LeooMk6DVMl

--HG--
extra : rebase_source : b1c92542da7b1e008cf2a42d32839915acba5d97
2017-05-16 17:15:02 -07:00
Jonathan Guillotte-Blouin 969046c009 Bug 1365068 - Added missing brackets & refactored some conditional statements. r=MattN
MozReview-Commit-ID: 1eOkjI06RCJ

--HG--
extra : rebase_source : 18068d1483d9127c06b858ce917f53dc41f4c58f
2017-05-16 15:56:28 -07:00
Jonathan Guillotte-Blouin 92ec4b62b3 Bug 1363184 - Remove unused Deprecated.jsm import from nsFormAutoComplete.js. r=MattN
MozReview-Commit-ID: 1uCS8gfm5Oi

--HG--
extra : rebase_source : 919bf3b8a455415de400160f6c7781c33cc0dc7d
2017-05-08 15:34:16 -07:00
Jared Wein a54eda04ca Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx

--HG--
extra : rebase_source : 61d2aa91bf9474af3d72a5dea41b25dca442c1b7
2017-03-21 14:29:43 -04:00
Florian Quèze b11907c7aa Bug 1334156 - script-generated patch to replace .ownerDocument.defaultView with .ownerGlobal, r=jaws. 2017-01-27 10:51:03 +01:00
Jared Wein 43bac26d30 Bug 1331661 - Enable the 'quotes' rule for eslint and fix most of the errors with --fix. r=Gijs
MozReview-Commit-ID: 6tv0Z06CO4a

--HG--
extra : rebase_source : 014c0b04d8538dc5f15bc6dd4ed6bd220c55c5d4
2017-01-17 09:48:17 -06:00
Jared Wein ecab54a7c9 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje

--HG--
extra : rebase_source : 0572a35415a766a3f31d266760ecd07f0dcc3f72
2016-12-29 18:34:54 -05:00
Wes Kocher 0dfb7c2b5c Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein 7255df4e9a Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR

--HG--
extra : rebase_source : da7172285d43b820421557ed3b05887e091ff939
2016-12-29 15:20:47 -05:00
Dave Townsend c5bb304fd9 Bug 1316882: Turn on space-before-function-paren eslint rule (toolkit). r=jaws
MozReview-Commit-ID: FGFwg6TYkvm

--HG--
extra : rebase_source : 4073cebbef1694393efe312aaafbdb803adbd304
2016-11-11 15:22:34 -08:00
Dave Townsend 0a2c8f9b78 Bug 1316882: Turn on space-infix-ops eslint rule. r=jaws
MozReview-Commit-ID: HBpjT2uHJaZ

--HG--
extra : rebase_source : 78fe71a1d673a1c698520a9c82c6f35959614f8f
2016-11-10 14:48:04 -08:00
Mike Conley 3030fff48c Bug 1311189 - Put back the separator between form history and datalist entries in the autocomplete popup. r=MattN
MozReview-Commit-ID: 2lRauTr9EQA

--HG--
extra : rebase_source : 5364489af1e9647927756eae09d4512f24f57101
2016-10-19 13:55:06 -04:00
Wes Kocher e636b54dfb Backed out changeset 2849f953881f (bug 1311189) for mochitest-5 failures a=backout 2016-10-24 16:49:55 -07:00
Mike Conley b05b4b2b0d Bug 1311189 - Put back the separator between form history and datalist entries in the autocomplete popup. r=MattN
MozReview-Commit-ID: 2lRauTr9EQA

--HG--
extra : rebase_source : cf8f7fa891b7c9adaa9f068771fa0c06f5cffb09
2016-10-19 13:55:06 -04:00
Mike Conley 4714381995 Bug 1294502 - Combine e10s and non-e10s nsFormAutoComplete implementations. r=MattN
MozReview-Commit-ID: 46jM5Q3AfRa

--HG--
extra : rebase_source : 41245b87dba296fec1c58207a6b4e7feba3ffca0
2016-08-11 15:36:22 -04:00
Jared Wein fd84c776c7 Bug 1292042 - Enable the keyword-spacing rule for eslint. Most of this patch was autogenerated by 'eslint --fix'. Files with .xml extension needed to be changed by hand due to limitations of custom plugin. r=markh
MozReview-Commit-ID: EMjJ3yWt9Wt

--HG--
extra : rebase_source : 2b8327e5a7cf0bfd190d696ad5fe475f13faa3cc
2016-08-04 03:28:58 -04:00
Jared Wein 871ed4e3ba Bug 1291855 - Enable the no-else-return rule for eslint. r=Felipe,kmag,mossop
MozReview-Commit-ID: DYOmE6xwMJh

--HG--
extra : rebase_source : bc81b68ea5599fd1815dc34dac7106eef7044483
2016-08-03 18:54:59 -04:00
Marco Bonardo 0223734aed Bug 1252074 - test_form_autocomplete.html and test_form_autocomplete_with_list.html should pass on e10s. r=paolo
MozReview-Commit-ID: CISKztr4p4N

--HG--
extra : rebase_source : 8aa05cc7c358394e8667ad8149cbc4987cd4e412
2016-03-02 14:34:38 +01:00
Blake Kaplan 4da198b998 Bug 1242208 - Fix cached form history results with a datalist present. r=MattN 2016-02-02 13:44:11 -08:00
Dave Townsend 4544dd42d7 Bug 1229519: Fix toolkit/components/satchel to pass eslint checks. r=dolske
--HG--
extra : commitid : 98MSbW7dPZG
extra : rebase_source : e27a1b61f49f5d8651151d91d3b6847ae7468955
extra : amend_source : 91482cefc5b0aedf83cd88578685f6ef4755545b
2015-12-03 10:01:41 -08:00
Marco Bonardo 2cb37ef1e6 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Tooru Fujisawa 65e2703499 Bug 1217082 - Remove for-each from toolkit/. r=Gijs
--HG--
extra : commitid : Ewr7Bixammr
extra : rebase_source : 91e560a7b8b8d4b78debb1db2512867262b18375
2015-10-19 04:57:14 +09:00
Tooru Fujisawa accd89d4fd Bug 1207498 - Part 1: Remove use of expression closure from toolkit/components/, except tests. r=Gijs
--HG--
extra : commitid : 5yrVqfOUmEG
extra : rebase_source : e2ec30261bd76c1966b0e61fd7e08c2924f270b0
2015-09-24 20:32:23 +09:00