This allows Gecko to use the same criteria as Servo for evaluating if a property
should be transitioned and will cause Gecko to exclude discretely animated
properties, including, in future, the 'display' property.
MozReview-Commit-ID: H2wWVo5isKS
--HG--
extra : rebase_source : 34798306aa5f485b0583d3640caf24d123922584
This is no longer needed as of bug 1311257 since we now compose animations on
the Servo side.
MozReview-Commit-ID: 8VbgYjhIQmu
--HG--
extra : rebase_source : 7dc5ea57cd2f0991bc65810c9eb98cc9044c5d77
This is in response to an issue that's affecting the new app
update doorhangers on OSX, where the problem is more obvious.
On OSX, the panel styling makes it so that the doorhanger
overflows the window a little bit. This is fine until you enter
fullscreen with ctrl+command+F. At this point, the doorhanger
should come back onto the screen and the arrow should be rooted
to its anchor element (in our case the hamburger menu icon), but
instead it lags and the panel is not adjusted right away. This
is because right after the window is resized, which ends up
calling SetPopupPosition with aIsMove == false, SetPopupPosition
is called again from CheckForAnchorChange with aIsMove set to
true. There could be other solutions to this particular problem,
but since the aIsMove boolean is intended to limit the visual
noise when moving a window between screens, it seemed appropriate
for it to only prevent sliding or flipping if the panel isn't
already slid or flipped.
There was another issue affecting specifically the arrow, where
the logic for notifying observers of a positioning change in the
panel doesn't account for changes only to the position of the
anchor rect. This change adds tracking of that and sets aNotify
to true when called from ReflowFinished, since this is where
the position of the anchor element relative to the window can
need to change, even when the screen position of the panel rect
doesn't change.
MozReview-Commit-ID: Lpfokwkgl33
--HG--
extra : rebase_source : b05adc0b3f876196ff45499f0d70533f78cafb0e
Setting font-variant-alternates in font-variant shorthand still causes failures,
so move them to the font-variant-alternates section.
MozReview-Commit-ID: FkepxhLWUzk
--HG--
extra : rebase_source : 17d9be31ae18ecc2eda00a8fe114c08052303438
This reftest fails without the first patch.
This test generates animation-only restyle by anim.cancel() and selector
matching by classList.add().
MozReview-Commit-ID: 2EvOWRwr1o7
--HG--
extra : rebase_source : bfa2f94a5726142577f75074f28415caf87cd53a
For the most part, I tried to make less *manual* table invalidations
for non-border-collapse tables and relied the table invalidations on
the comparison of the display items. By doing so, we can avoid the
over-painting issue.
MozReview-Commit-ID: 4w1DUKHXIFO
--HG--
extra : rebase_source : ac5e6de35a2b20318c70f8eed4375a5673ef6c31
This is needed before we can upgrade to flake8 3.3.0, as that version starts flagging these errors.
These files were modified by running:
autopep8 --select E305 --in-place -r <dir>
on the affected directories. I did it one dir at a time and verified the result after each.
MozReview-Commit-ID: FmlsfiKIbtr
--HG--
extra : rebase_source : 9df32258cadff5d27a0e72113c57f782756c0b18
Manish Goregaokar
Cameron McCormack
Wes Kocher
Sebastian Hengst
Andrew Osmond
Carsten "Tomcat" Book
Brian Birtles
Ehsan Akhgari
Doug Thayer
Matt Woodrow
Mats Palmgren
Peter Van der Beken
Boris Chiou
Jeremy Chen
Xidorn Quan
Phil Ringnalda
Mantaroh Yoshinaga
Hiroyuki Ikezoe
Ya-Chieh Wu
Andrew Halberstadt
Ethan Lin
Nazım Can Altınova
Louis Chang
Emilio Cobos Álvarez