Граф коммитов

10060 Коммитов

Автор SHA1 Сообщение Дата
Michael Layzell 0d5232cf03 Bug 1337056 - Part 6: Disable nsPermissionManager::GetEnumerator in the content process, r=kitcambridge
This property allows enumerating over all permissions. As the content
process no longer has access to all permissions, this method cannot be
correctly implemented in the content process anymore.

Because of that, we now error with NS_ERROR_NOT_AVALIABLE when it is
accessed in the content process.

MozReview-Commit-ID: BLNeYYcZhIi
2017-03-21 11:08:03 -04:00
Michael Layzell 9803b986e3 Bug 1337056 - Part 5: Add support for finer-grained permission update messages to ContentParent, r=baku
MozReview-Commit-ID: 6y6eBLWPTue
2017-03-21 11:08:03 -04:00
Michael Layzell 092eeed6cf Bug 1337056 - Part 4: Assert that the ipcKey for a principal is avaliable when creating a PermissionKey in the child process, r=baku
MozReview-Commit-ID: G9TynCKgCVF
2017-03-21 11:08:03 -04:00
Michael Layzell ba95fb3f71 Bug 1337056 - Part 2: Replace the synchronous ReadPermissions API with async APIs, r=baku
These APIs are intended to use the mechanism defined in Part 1.

Part 3 implements the usage of these APIs to synchronize permissions.

MozReview-Commit-ID: HNKyDPtoaHl
2017-03-21 11:08:03 -04:00
Michael Layzell ca0fec349f Bug 1337056 - Part 1: Add a mechanism for grouping permissions into groups to be sent over IPC, r=baku
MozReview-Commit-ID: IQiSsVGaAOQ
2017-03-21 11:08:03 -04:00
Florian Quèze 9c4d40bb54 Bug 1345294 - script generated patch (+ some hand cleanup) to replace {get,set}ComplexValue for nsISupportsString by {get,set}StringPref, r=Mossop. 2017-03-16 19:26:01 +01:00
Sebastian Hengst fcbd8c9861 Backed out changeset 7568383eb18d (bug 1337056) for crashing xpcshell test test_bug930456_child.js on debug. r=backout 2017-03-15 00:47:09 +01:00
Sebastian Hengst 1bb61f6114 Backed out changeset 2d2d603dbdaf (bug 1337056) 2017-03-15 00:46:35 +01:00
Sebastian Hengst 84d3bcc39c Backed out changeset 7a6e7570df3e (bug 1337056) 2017-03-15 00:46:25 +01:00
Sebastian Hengst 59df958663 Backed out changeset 0e4ee0af3ff0 (bug 1337056) 2017-03-15 00:46:20 +01:00
Sebastian Hengst 9e2e9cf66e Backed out changeset 33447647d4e8 (bug 1337056) 2017-03-15 00:46:15 +01:00
Sebastian Hengst e1e7c0d5b1 Backed out changeset 1101f931d2d7 (bug 1345573) 2017-03-15 00:45:51 +01:00
Sebastian Hengst 9e070cfb3a Backed out changeset f5f05a774023 (bug 1345573) 2017-03-15 00:45:46 +01:00
Michael Layzell 12090b6df9 Bug 1345573 - Part 2: Remove old tests for permissions syncing, and add test for new logic, r=baku
MozReview-Commit-ID: A2vYqdCpeu6
2017-03-14 14:56:14 -04:00
Michael Layzell b2dbbeb326 Bug 1345573 - Part 1: Key http, https, and ftp URIs on origin instead of eTLD+1, r=baku
MozReview-Commit-ID: Gihc4QFf11R
2017-03-14 14:56:13 -04:00
Michael Layzell 5aa9ab1a69 Bug 1337056 - Part 6: Disable nsPermissionManager::GetEnumerator in the content process, r=kitcambridge
This property allows enumerating over all permissions. As the content
process no longer has access to all permissions, this method cannot be
correctly implemented in the content process anymore.

Because of that, we now error with NS_ERROR_NOT_AVALIABLE when it is
accessed in the content process.

MozReview-Commit-ID: BLNeYYcZhIi
2017-03-14 14:56:06 -04:00
Michael Layzell 13c3e3acbe Bug 1337056 - Part 5: Add support for finer-grained permission update messages to ContentParent, r=baku
MozReview-Commit-ID: 6y6eBLWPTue
2017-03-14 14:56:05 -04:00
Michael Layzell ce8ac3bacf Bug 1337056 - Part 4: Assert that the ipcKey for a principal is avaliable when creating a PermissionKey in the child process, r=baku
MozReview-Commit-ID: G9TynCKgCVF
2017-03-14 14:56:04 -04:00
Michael Layzell e7fb4ee297 Bug 1337056 - Part 2: Replace the synchronous ReadPermissions API with async APIs, r=baku
These APIs are intended to use the mechanism defined in Part 1.

Part 3 implements the usage of these APIs to synchronize permissions.

MozReview-Commit-ID: HNKyDPtoaHl
2017-03-14 14:55:49 -04:00
Michael Layzell 7acc92de9c Bug 1337056 - Part 1: Add a mechanism for grouping permissions into groups to be sent over IPC, r=baku
MozReview-Commit-ID: IQiSsVGaAOQ
2017-03-14 14:54:11 -04:00
Eric Rahm fab046bdc7 Bug 1344081 - Switch to Base64Decode in nsHttpNegotiateAuth::GenerateCredentials. r=jduell
MozReview-Commit-ID: 4A5tEV5Fb8
2017-03-13 19:09:26 -07:00
Ekanan Ketunuti d8eab65dc1 Bug 1345018 - Add anaphylactic, anaphylaxis and anaphylaxes to the en-US dictionary. r=ehsan 2017-03-08 07:03:13 +07:00
Wei-Cheng Pan 32f9c5e80d Bug 1310127 - Part 8: Use MOZ_MUST_USE in netwerk/protocol/http r=mkaply
MozReview-Commit-ID: Cd7rL6rpy6e

--HG--
extra : rebase_source : 8c0f4b59cf5db745ef073401dc25b43b4f8f7efc
2016-12-20 17:19:46 +08:00
Tim Huang fc6e097c7a Bug 1337893 - Part 4: Updating whole gecko to make all callers of DNS using correct originAttributes. r=baku
MozReview-Commit-ID: D6Vp8ANSzLI

--HG--
extra : rebase_source : f3608b09835040e4a4f8e7675aa53d003f298d32
2017-02-15 10:39:40 +08:00
Valentin Gosu 3eeff608a4 Bug 1340486 - Remove duplication of code at nsHttpNegotiate/NTLMAuth::TestPref and MatchesBaseURI r=mayhemer
MozReview-Commit-ID: L8oS7TFnHJm

--HG--
extra : rebase_source : aac598a3b3722d9bfb370de425d14fbb4960291f
2017-02-27 17:57:59 +01:00
Masatoshi Kimura 47d59c07d5 Bug 1338971 - Stop using non-standard JavaScript in AutoConfig files. r=mkaply
MozReview-Commit-ID: F2dDRHAw02S

--HG--
extra : rebase_source : ca74dd69aa51e4eb8d832161e05f98cc2b42df3c
2017-02-13 22:18:12 +09:00
Wes Kocher a85d979e21 Merge m-c to inbound, a=merge
MozReview-Commit-ID: 18xg2cleATb
2017-02-17 13:51:01 -08:00
Honza Bambas 7c53975ce1 Bug 1328791 - Fix trusted uri list parser for Negotiate/NTLM auth. r=jduell 2017-02-16 13:40:00 -05:00
Ekanan Ketunuti b67b9b8bdc Bug 1340011 - Add inverter to the en-US dictionary. r=ehsan
--HG--
extra : rebase_source : f84e03f6cdd46d7b66a0c34d0cd6dae237107e16
2017-02-16 08:58:14 +07:00
Ekanan Ketunuti 1d6b4bdc87 Bug 1333591 - Add foundational to the en-US dictionary. r=ehsan 2017-02-15 08:16:29 +07:00
Wes Kocher 017c515285 Merge inbound to m-c a=merge
MozReview-Commit-ID: IKI0zVtF1n9
2017-02-15 16:18:13 -08:00
Ben Kelly 0e176007bb Bug 1322111 P1 Add TYPE_INTERNAL_WORKER_IMPORT_SCRIPTS content policy type. r=ckerschb 2017-02-15 09:55:58 -05:00
Sylvestre Ledru 4c352ae1ed Bug 1338086 - Remove useless else blocks in order to reduce complexity in extensions/gio/ r=Dolske
MozReview-Commit-ID: 2OsdUdGgL9O

--HG--
extra : rebase_source : ea0c571993a5509aad330b0fef8cd7c1c8866529
2017-02-09 10:35:39 +01:00
Tom Tromey 5f8f360823 Bug 1060419 - make log_print use Printf.h, r=froydnj
MozReview-Commit-ID: BIZ1GQEZ1vs

--HG--
extra : rebase_source : 2f1f0aa12493c44f352d9a7e8683e7bb72d2d75b
2016-12-15 20:16:31 -07:00
Tom Tromey f8ab4ddf02 Bug 1060419 - remove unneeded includes of prprf.h, r=froydnj
MozReview-Commit-ID: JifhpA3oOeH

--HG--
extra : rebase_source : 08460997dc3fd91f3065c718e17b41bb4acf8bae
2016-12-09 10:00:01 -10:00
Tooru Fujisawa 4529253bd3 Bug 1338253 - Remove remaining legacy generator from extensions/cookie/test/. r=jdm 2017-02-11 11:47:57 +09:00
Tooru Fujisawa 470c96cd31 Bug 1338254 - Remove legacy generator from extensions/spellcheck/hunspell/tests/. r=ehsan 2017-02-11 01:53:24 +09:00
Valentin Gosu fd0c022031 Bug 1275746 - Fix tests that assume a HTTP url without a hostname is valid r=bz,MattN,jdm,markh
MozReview-Commit-ID: DzRenakrcAG
2016-07-07 16:20:47 +03:00
Ehsan Akhgari 1f536efb1e Bug 1337054 - Remove nsIPermissionManager::RefreshPermission(); r=jdm 2017-02-06 19:54:34 -05:00
Joel Maher afe3e6a86e Bug 1332423 - add BUG_COMPONENT to extensions/* files. r=bsmedberg 2017-01-27 08:19:19 -05:00
Ryan VanderMeulen e9ab36bd47 Bug 1333648 - Update the en-US dictionary to SCOWL 2017.01.22. r=ehsan 2017-01-25 11:37:25 -05:00
Mark Banner 16e6d381ac Bug 503613 - Remove old 'tail =' lines from xpcshell.ini files; r=gps
MozReview-Commit-ID: 62Hp5ISxowJ

--HG--
extra : rebase_source : daa8efb3409031fea553f4fd0c9d0746e38dc308
extra : histedit_source : b4c23aacf678ba0d0ac9c09191a7c494ead11a08
2017-01-18 10:30:39 +00:00
Florian Quèze 85611a7b6d Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws.
--HG--
extra : rebase_source : a22344ee1569f58f1f0a01017bfe0d46a6a14602
2017-01-17 11:50:25 +01:00
Johann Hofmann 95370d69a3 Bug 1206232 - Add temporary permission states to SitePermissions.jsm. r=jdm,Paolo
MozReview-Commit-ID: zQVeEHhIax

--HG--
extra : rebase_source : bebcd31cfbd638c51ff21c7e2b62bcc536b026da
2016-09-22 23:09:30 +02:00
Ryan VanderMeulen 605429a73d Bug 1326277 - Update README.mozilla to reflect the correct in-tree Hunspell version. DONTBUILD 2017-01-12 20:24:07 -05:00
Andrea Marchesini 359ae91eac Bug 1328653 - Merging all the various *OriginAttributes to just one, r=huseby 2017-01-12 17:38:48 +01:00
Florian Quèze fc6379e827 Bug 1329182 - remove trailing newURI null parameters in the rest of the tree, r=jaws. 2017-01-09 20:27:26 +01:00
Michael Layzell 085958fee1 Bug 1272623 part.1 Don't destroy nodes during text replacement due to spell checking r=masayuki
Spellchecker shouldn't delete selection with nsIEditor::eStrip before calling nsIPlaintextEditor::InsertText() because it causes removing some parent nodes which may have some style rules.

MozReview-Commit-ID: 2VJhFFbTzrh

--HG--
extra : rebase_source : ffe9cfb47cbae665219c1399875c592f49aff397
2016-12-27 18:41:07 +09:00
Ryan VanderMeulen 7afab1ba7f Bug 1326277 - Upgrade Hunspell to version 1.6.0. r=masayuki
--HG--
extra : rebase_source : dfd3b592a52a708fe62c49c826bfaedea801769d
2017-01-05 23:42:31 -05:00
Carsten "Tomcat" Book 98048f1496 Merge mozilla-central to autoland 2017-01-04 16:20:18 +01:00
Ehsan Akhgari 4d287a0042 Bug 1321912 - Remove the appId field from the moz_cookies table; r=jdm 2017-01-03 22:34:46 -05:00
Mark Banner 3539bc390b Bug 1255149 - Remove unused nsICookiePromptService. r=jdm
MozReview-Commit-ID: IO07pbRqq2I

--HG--
extra : rebase_source : 7c432454f216797a9937f6b6a30dc683439102d6
2017-01-03 12:14:06 +00:00
Ting-Yu Chou f45e9a6e3e Bug 1322465 part 4 - Use explicit/MOZ_IMPLICIT for the unary constructors in extensions/. r=Ehsan
MozReview-Commit-ID: JX7AiJNVFNg

--HG--
extra : rebase_source : e0c2c7934278dcd8cbbcf3c82ceb405f11de31d5
2016-12-16 15:51:26 +08:00
Yoshi Huang 2ceecc22f5 Bug 1324115 - Part 2: replace the callers to use C++ helper. r=smaug 2016-12-21 14:59:21 +08:00
Ryan VanderMeulen 0d5d58913a Bug 1322666 - Change MAXWORDLEN to 100, matching the previous default from Hunspell 1.3. r=masayuki 2016-12-14 21:42:32 -05:00
Ehsan Akhgari 23ab21c6fc Bug 1322995 - Update the en-US dictionary to SCOWL 2016.11.20 2016-12-13 14:46:50 -05:00
Ryan VanderMeulen 29af881512 Bug 1318955 - Upgrade to Hunspell 1.5.4. r=masayuki 2016-07-12 10:37:04 -04:00
Andrea Marchesini 458019a9d8 Bug 1322518 - PermissionKey should propagate the error if nsIPrincipal::GetOrigin fails, r=ehsan 2016-12-08 10:45:52 -10:00
Tomislav Jurin 348bfffc19 Bug 1296189 - Replace NS_RUNTIMEABORT("some string literal message") with MOZ_CRASH(). r=froydnj 2016-12-02 13:46:53 -08:00
Andi-Bogdan Postelnicu d8492c505a Bug 1319703 - Use C++11's override and remove virtual where applicable in extensions/. r=jduell
MozReview-Commit-ID: LsLJ4CnXbJ9
2016-11-23 11:39:13 +02:00
Andi-Bogdan Postelnicu f7cdb1f57b Bug 1319703 - Replace default bodies of special member functions with = default; in extensions/. r=jduell
MozReview-Commit-ID: 9NvziFVvmRS
2016-11-23 11:38:56 +02:00
Jan Beich face87e5ac Bug 1320621 - Make sure --enable-system-hunspell picks up system headers. r=glandium
MozReview-Commit-ID: ALlx4wGuvRH

--HG--
extra : rebase_source : f9cfe08623ea01135eca7961d4eeb3de3fecc5c7
2016-11-28 03:54:39 +00:00
Ryan VanderMeulen 906fc553b2 Backed out changeset 25c7efa29d66 (bug 1318955) for breaking Hungarian spellchecking.
--HG--
extra : rebase_source : 8267bc48037eaf64d26ff93d60cd7998cb26d0ac
2016-11-28 21:44:06 -05:00
Ryan VanderMeulen 08f3aaaca6 Bug 1318955 - Upgrade to Hunspell 1.5.0. r=masayuki
--HG--
extra : rebase_source : e5e0fe0ba11975e0e7bb8d5354561ba0b9f24248
2016-07-12 10:37:04 -04:00
Ehsan Akhgari d07f79a266 Bug 1318210 - Remove nsIAppsService; r=baku 2016-11-17 10:41:36 -05:00
Wes Kocher f9e9d69899 Merge inbound to m-c a=merge CLOSED TREE 2016-11-16 17:07:26 -08:00
Ehsan Akhgari 569f181508 Bug 1311149 - Remove the b2g preallocated app support; r=baku 2016-11-16 09:17:35 -05:00
Ehsan Akhgari eac76d9772 Bug 1310845 - Remove support for mozapp iframes; r=fabrice,jryans,baku,mcmanus
This patch removes support for mozapp iframes, leaving support for
mozbrowser iframes intact.  Some of the code has been rewritten in order
to phrase things in terms of mozbrowser only, as opposed to mozbrowser
or app.  In some places, code that was only useful with apps has been
completely removed, so that the APIs consumed can also be removed.  In
some places where the notion of appId was bleeding out of this API, now
we use NO_APP_ID.  Other notions of appId which were restricted to this
API have been removed.
2016-11-16 09:13:38 -05:00
Kan-Ru Chen f8100451db Bug 1314254 - Add mozilla::ipc::IPCResult type and convert IPDL handlers to use new return type. r=billm
We will use the new type for the generated IPDL message handler
prototype to make sure correct error handling method is called.

MozReview-Commit-ID: AzVbApxFGZ0
2016-11-15 04:26:00 +01:00
Sylvestre Ledru 34c92c780f Bug 1317430 - Avoid a unnecessary copy by passing a const & in extensions/spellcheck/ r=njn
MozReview-Commit-ID: H7V0fap294l

--HG--
extra : rebase_source : d1bd92a379df53e4d239b1f3b2077a1162e7d6d9
2016-11-14 23:16:11 +01:00
Honza Bambas 3a99264fc4 Bug 1313016 - Pref to send default NTLM creds in PB, Always send default creds to proxies in PB. r=jduell
--HG--
extra : rebase_source : 621085462a44307ef018533b04398be9383b9dba
extra : source : d1ef75d52b01dbd1f3185084836f48fda8262691
2016-11-11 03:45:00 -05:00
Ryan VanderMeulen bfd51f89f4 Backed out changeset d1ef75d52b01 for landing with the wrong bug number in the commit message.
--HG--
extra : rebase_source : e7a750411e0c2502e633ef7c0e86cb01fe8528da
2016-11-11 10:44:54 -05:00
Honza Bambas d7498ba353 Bug 1248564 - Pref to send default NTLM creds in PB, Always send default creds to proxies in PB. r=jduell
--HG--
extra : rebase_source : 8740797ecea0659091b98573009b85b97d90d7ce
2016-11-11 03:45:00 -05:00
Masatoshi Kimura bdc9c380b3 Bug 1313280 - Fix invalid non-UTF-8 bytes from Hunspell. r=glandium
MozReview-Commit-ID: ClJbuk6FkfL

--HG--
extra : rebase_source : f41859d20175cb0893d8e1ff8de20136b16a0c7d
extra : source : ced53269c25222bb54e88065ae9fbe19185e2cfd
2016-10-28 21:09:09 +09:00
Phil Ringnalda a7bc94158c Merge m-i to m-c, a=merge
MozReview-Commit-ID: H4VKCYDq5cD

--HG--
rename : xpcom/tests/TestAutoRef.cpp => xpcom/tests/gtest/TestAutoRef.cpp
rename : xpcom/tests/TestCOMArray.cpp => xpcom/tests/gtest/TestCOMArray.cpp
rename : xpcom/tests/TestCOMPtr.cpp => xpcom/tests/gtest/TestCOMPtr.cpp
rename : xpcom/tests/TestCOMPtrEq.cpp => xpcom/tests/gtest/TestCOMPtrEq.cpp
rename : xpcom/tests/TestFile.cpp => xpcom/tests/gtest/TestFile.cpp
rename : xpcom/tests/TestHashtables.cpp => xpcom/tests/gtest/TestHashtables.cpp
rename : xpcom/tests/TestID.cpp => xpcom/tests/gtest/TestID.cpp
2016-11-05 13:36:25 -07:00
Sebastian Hengst a29b7edbc4 Bug 1310297 - Remove test annotations using b2g, mulet or gonk: extensions. r=RyanVM
MozReview-Commit-ID: H0AlYp2iIkp

--HG--
extra : rebase_source : 075e57481d6b986b4c87ddc7fae334a4c3369b14
2016-11-05 11:29:19 +01:00
Jookia 9d1c2e6c7b Bug 1310835 - Look for spellcheck dictionaries in DICPATH. r=smaug
Other applications allow loading dictionaries from DICPATH, so look
there too. A double-pass is required since dictionaries overwrite
each other, and DICPATH intends them to be overridden right-to-left
like any PATH on Unix-like systems.
2016-11-01 08:10:50 +11:00
Valentin Gosu db9440de51 Bug 1305204 - (Part 2) Backout bug 1275746 a=backout
MozReview-Commit-ID: H8aCKdJzEbR
2016-10-23 14:24:45 +02:00
Ehsan Akhgari 9de6bbbaec Bug 1261019 - Part 3: Remove Navigator.mozApps and code depending on it; r=myk,jryans,fabrice,mcmanus,peterv 2016-10-13 13:18:41 -04:00
Ehsan Akhgari d4cf901767 Bug 1308319 - Remove app specific parts of the permission manager; r=baku 2016-10-10 11:11:12 -04:00
Ryan VanderMeulen 38574eeac5 Merge m-c to inbound. a=merge 2016-10-07 09:44:29 -04:00
Yoshi Huang 2a51f65d99 Bug 1237152 - rename clear-origin-data to clear-origin-attributes-data, r=smaug
find \( -name '*.cpp' -o -name '*.h' -o -name '*.js' -o -name '*.jsm' -o -name '*.idl' -o -name '*.html' \) \
-a -type f -exec sed -i 's/clear-origin-data/clear-origin-attributes-data/g' {} \;
2016-10-07 17:45:10 +08:00
Ekanan Ketunuti 79ac78034b Bug 1267325 - Add outlier, outliers and outlier's to the en-US dictionary. r=ehsan 2016-10-06 11:18:22 +07:00
Ekanan Ketunuti 0d6b019139 Bug 1255327 - Add canonicalization, canonicalizations, canonicalization's, canonicalize, canonicalized, canonicalizing and canonicalizes to the en-US dictionary. r=ehsan
MozReview-Commit-ID: 3BwfyUmIzxJ
2016-10-06 10:50:52 +07:00
Jonathan Hao 8a70bfa5fc Bug 1302047 - Ignore userContextId and firstPartyDomain when matching permissions. r=baku
--HG--
extra : rebase_source : da81c21da92810d808ebe865a456cc9d04058ce3
2016-09-20 16:35:21 +08:00
Jonathan Hao 61bd32ab34 Bug 1302047 - Test if permission matches for different userContextId or firstPartyDomain. r=baku
--HG--
extra : rebase_source : ffe4fbd2472fb329c46c7e31dd0f1f3776c525bf
2016-09-13 14:50:25 +08:00
m-r-m-s 04e71c59d2 Bug 1293704 - added adoptee/MS. r=ehsan 2016-09-27 08:11:47 +02:00
Jonathan Hao 43b2addff0 Bug 1301617 - Add tests for firstPartyDomain and userContextId with nsIPermissionManager. r=baku
--HG--
extra : rebase_source : c2cdd6b300b750a8d964f73292d81d2fc74dd9cf
2016-09-11 20:36:00 -04:00
Umesh Panchaksharaiah 056d5a6135 Bug 1301629 - Fix incorrect parameter name in comments. r=ettseng
--HG--
extra : rebase_source : a45c6c9641ceb70301e8bcd957a3e21c95aef423
2016-09-14 19:57:20 +02:00
Yoshi Huang 58f3cc8643 Bug 1301274 - use default firstPartyDomain in PermissionManager. r=baku 2016-09-19 19:36:06 +08:00
Dragana Damjanovic 28e47547d6 Bug 1277895 - Remove one new line from http auth prompt message. r=dolske 2016-09-16 09:24:26 +02:00
Michael Layzell 36e08437d0 Bug 1018486 - Part 8: Various other changes, r=smaug
MozReview-Commit-ID: B0dsomkWgEk
2016-09-07 10:50:45 -04:00
Nicholas Nethercote 34dcc7b852 Bug 1299384 - Use MOZ_MUST_USE with NS_warn_if_impl(). r=erahm.
This change avoids lots of false positives for Coverity's CHECKED_RETURN
warning, caused by NS_WARN_IF's current use in both statement-style and
expression-style.

In the case where the code within the NS_WARN_IF has side-effects, I made the
following change.

> NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));
> -->
> Unused << NS_WARN_IF(NS_FAILED(FunctionWithSideEffects()));

In the case where the code within the NS_WARN_IF lacks side-effects, I made the
following change.

> NS_WARN_IF(!condWithoutSideEffects);
> -->
> NS_WARNING_ASSERTION(condWithoutSideEffects, "msg");

This has two improvements.
- The condition is not evaluated in non-debug builds.
- The sense of the condition is inverted to the familiar "this condition should
  be true" sense used in assertions.

A common variation on the side-effect-free case is the following.

> nsresult rv = Fn();
> NS_WARN_IF_(NS_FAILED(rv));
> -->
> DebugOnly<nsresult rv> = Fn();
> NS_WARNING_ASSERTION(NS_SUCCEEDED(rv), "Fn failed");

--HG--
extra : rebase_source : 58788245021096efa8372a9dc1d597a611d45611
2016-09-02 17:12:24 +10:00
Sebastian Hengst 24761c4c2a Bug 1280775 - null check in removePermission to prevent crash: permission manager change. r=mystor
MozReview-Commit-ID: 1E67oEULEcs

--HG--
extra : rebase_source : 38df1862f185e263175f0f8487fbb9ceca795d68
2016-06-22 21:07:14 +02:00
Nicholas Nethercote b71747b2ac Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.

--HG--
extra : rebase_source : 886e57a9e433e0cb6ed635cc075b34b7ebf81853
2016-09-01 15:01:16 +10:00
Emilio Cobos Álvarez 619cb14d87 Bug 1299066: Make NS_STYLE_DISPLAY_* an enum class. Prefer indexing instead of linear search in the frame constructor r=heycam,bz
The main renaming was generated with the following python script:

```

import sys
import re

CAMEL_CASE_REGEX = re.compile(r"(^|_|-)([A-Z])([A-Z]+)")
DISPLAY_REGEX = re.compile(r"\bNS_STYLE_DISPLAY_([^M][A-Z_]+)\b")

def to_camel_case(ident):
  return re.sub(CAMEL_CASE_REGEX,
                lambda m: m.group(2) + m.group(3).lower(), ident)

def constant_to_enum(constant):
  return "StyleDisplay::" + to_camel_case(constant) + ("_" if constant == "NONE" else "")

def process_line(line):
  return re.sub(DISPLAY_REGEX,
                lambda m: constant_to_enum(m.group(1)), line)

lines = []
with open(sys.argv[1], "r") as f:
  for line in f:
    lines.append(process_line(line))

with open(sys.argv[1], "w") as f:
  for line in lines:
    f.write(line)
```

And the following shell commands:

```
find . -name '*.cpp' -exec python display.py {} \;
find . -name '*.h' -exec python display.py {} \;
```

MozReview-Commit-ID: 91xYCbLC2Vf
2016-09-01 20:41:17 -07:00
Nicholas Nethercote c2306345d5 Bug 1297658 - Avoid unnecessary checking in memory reporters. r=erahm.
This patch removes checking of all the callback calls in memory reporter
CollectReport() functions, because it's not useful.

The patch also does some associated clean-up.

- Replaces some uses of nsIMemoryReporterCallback with the preferred
  nsIHandleReportCallback typedef.

- Replaces aCallback/aCb/aClosure with aHandleRepor/aData for CollectReports()
  parameter names, for consistency.

- Adds MOZ_MUST_USE/[must_use] in a few places in nsIMemoryReporter.idl.

- Uses the MOZ_COLLECT_REPORT macro in all suitable places.

Overall the patch reduces code size by ~300 lines and reduces the size of
libxul by about 37 KiB on my Linux64 builds.

--HG--
extra : rebase_source : e94323614bd10463a0c5134a7276238a7ca1cf23
2016-08-24 15:23:45 +10:00
Tim Huang 19e68da566 Bug 1291652 - Part 3: Update tests for fetching originAttributes from the nsILoadInfo, but not from the nsILoadContext. r=mayhemer
--HG--
extra : rebase_source : ebb2beb2c1c8cde1ecb1f04c151c37ff6705077c
2016-08-22 08:41:00 -04:00
Kan-Ru Chen b6d880aca1 Bug 1297276 - Rename mfbt/unused.h to mfbt/Unused.h for consistency. r=froydnj
The patch is generated from following command:

  rgrep -l unused.h|xargs sed -i -e s,mozilla/unused.h,mozilla/Unused.h,

MozReview-Commit-ID: AtLcWApZfES


--HG--
rename : mfbt/unused.h => mfbt/Unused.h
2016-08-24 14:47:04 +08:00
Honza Bambas d90344d529 Bug 1291700 - Allow negotiate/ntml to work when in the 'Never remember history' mode. r=jduell
--HG--
extra : rebase_source : 179a11fa222061f4c1c1cc2c1485ca49ca226d29
2016-08-16 06:24:00 -04:00
Nicholas Nethercote ca40b738e4 Bug 1294620 - Use infallible XPIDL attribute getters more. r=erahm.
This makes a lot of code more compact, and also avoids some redundant nsresult
checks.

The patch also removes a handful of redundant checks on infallible setters.

--HG--
extra : rebase_source : f82426e7584d0d5cddf7c2524356f0f318fbea7d
2016-08-12 15:19:29 +10:00
Igor 175543fda8 Bug 1293384 - Part 2: Rename Snprintf.h header to Sprintf.h. r=froydnj 2016-08-14 23:43:21 -07:00
Nicholas Nethercote bab6d17ebf Bug 1293117 (part 4) - Change many NS_IMETHODIMP occurrences to NS_IMETHOD. r=froydnj.
This patch makes the following changes on many in-class methods.

- NS_IMETHODIMP F() override;      --> NS_IMETHOD F() override;
- NS_IMETHODIMP F() override {...} --> NS_IMETHOD F() override {...}
- NS_IMETHODIMP F() final;         --> NS_IMETHOD F() final;
- NS_IMETHODIMP F() final {...}    --> NS_IMETHOD F() final {...}

Using NS_IMETHOD is the preferred way of marking in-class virtual methods.
Although these transformations add an explicit |virtual|, they are safe --
there's an implicit |virtual| anyway because |override| and |final| only work
with virtual methods.

--HG--
extra : rebase_source : 386ee4e4ea2ecd8d5001efabc3ac87b4d6c0659f
2016-08-08 10:54:47 +10:00
Junior Hsu 5536544c0b Bug 1288049 - Canonicalize IPv4 for nsStandardURL, r=valentin 2016-08-09 03:18:00 +02:00
Nicholas Nethercote e7f10a07fd Bug 1293603 (part 2) - Make Run() declarations consistent. r=erahm.
This patch makes most Run() declarations in subclasses of nsIRunnable have the
same form: |NS_IMETHOD Run() override|.

As a result of these changes, I had to add |override| to a couple of other
functions to satisfy clang's -Winconsistent-missing-override warning.

--HG--
extra : rebase_source : 815d0018b0b13329bb5698c410f500dddcc3ee12
2016-08-08 12:18:10 +10:00
Gabor Krizsanits 0c23e3d152 Bug 1285885 - Turn off PROMPT_ACTION permission hack for non-b2g builds. r=amarchesini 2016-08-01 14:45:41 +02:00
Sebastian Hengst bf67e4cf3c Backed out changeset 2a22eca82a2d (bug 1285885) for xpcshell failure in extensions/cookie/test/unit_ipc/test_parent.js. r=backout 2016-08-01 14:12:50 +02:00
Gabor Krizsanits 11e4e3f5fd Bug 1285885 - Turn off PROMPT_ACTION permission hack for non-b2g builds. r=amarchesini 2016-08-01 12:27:20 +02:00
Ehsan Akhgari c23cea6e98 Bug 1288977 - Update the en-US dictionary to SCOWL 2016.06.26 2016-07-26 12:43:51 -04:00
Fabrice Desré 7846da76d6 Bug 1287107 - Making transition alive with gaia as chrome:// r=bholley,fabrice
MozReview-Commit-ID: 9uVUrmuVFXQ

--HG--
extra : rebase_source : 20f6f0235667530c21aca4889b5d33e39c2d1a48
2016-03-03 09:58:47 -08:00
Carsten "Tomcat" Book 336105a0de merge mozilla-inbound to mozilla-central a=merge 2016-07-22 11:58:02 +02:00
Carsten "Tomcat" Book c7846e126c Backed out changeset 16aa7041c009 (bug 1287107) for causing xpcshell and mac tests 2016-07-22 11:30:23 +02:00
Fabrice Desré f5b619fb28 Bug 1287107 - Making transition alive with gaia as chrome:// r=bholley,fabrice
MozReview-Commit-ID: 9uVUrmuVFXQ

--HG--
extra : rebase_source : d0c19fcda5c72ecdce3b0d0bbbafa5a7954d7a4c
2016-03-03 09:58:47 -08:00
Tom Tromey 5538d692d3 Bug 1286877 - do not set c-basic-offset for python-mode; r=gps
This removes the unnecessary setting of c-basic-offset from all
python-mode files.

This was automatically generated using

    perl -pi -e 's/; *c-basic-offset: *[0-9]+//'

... on the affected files.

The bulk of these files are moz.build files but there a few others as
well.

MozReview-Commit-ID: 2pPf3DEiZqx

--HG--
extra : rebase_source : 0a7dcac80b924174a2c429b093791148ea6ac204
2016-07-14 10:16:42 -06:00
Chris Peterson b175c9fdd5 Bug 1277106 - Part 2: Expand MOZ_UTF16() strings to u"" string literals. r=Waldo 2016-07-20 22:03:25 -07:00
Nathan Froyd 82f3460a41 Bug 1288390 - avoid a few more warnings in third-party code when compiling with clang; r=mshal 2016-07-21 18:58:37 -04:00
Jan Horak f1cd3790fc Bug 890908 - Move Negotiate auth off main thread. r=mayhemer
--HG--
extra : rebase_source : ca85ad4bb099845b45a276823fe1abca68d384eb
2016-07-14 03:32:00 -04:00
Johann Hofmann 7a9543dd6c Bug 1206252 - Part 3: Add tests for nsIPermissionManager.getAllForURI. r=jdm
MozReview-Commit-ID: 8XQ11wWxZ3F

--HG--
extra : rebase_source : 8d0fda9065805190675bcaef6c11a4d777a8fc9e
2016-07-12 13:58:07 +02:00
Johann Hofmann 261d220621 Bug 1206252 - Part 1: Add a function to get all permissions by URI to nsIPermissionManager. r=jdm
MozReview-Commit-ID: KxnlBbmNJFZ

--HG--
extra : rebase_source : c931b331ea311c21adc8dcac9dbb88fee3a4a05f
2016-07-07 16:27:10 +02:00
Valentin Gosu ef5a976694 Bug 1275746 - Fix tests that assume a HTTP url without a hostname is valid r=jrgm,MattN,jdm,gijs,smaug
MozReview-Commit-ID: DzRenakrcAG
2016-07-13 15:19:34 +03:00
Carsten "Tomcat" Book 0d2c8ddbb2 Merge mozilla-central to autoland 2016-07-11 11:51:22 +02:00
Daniel Holbert ecdc48365b Bug 1285640: Move mozHunspell::CollectReports definition from .h file to .cpp file, to avoid clang 3.9 warning about static variable declared in header. r=njn
MozReview-Commit-ID: 8mUP6zYPhIO

--HG--
extra : rebase_source : 0ab4dbcb933f02451f7557e82f5d2d1967855988
2016-07-08 13:17:27 -07:00
Masayuki Nakano 7f30e926b8 Bug 1260651 part.60 editor/libeditor should export some headers which are required by other modules and other modules shouldn't use local include for them r=mccr8
MozReview-Commit-ID: FZSExwkHH2B
2016-07-08 14:03:31 +09:00
Masayuki Nakano f382711dc3 Bug 1260651 part.59 Rename nsEditor to mozilla::EditorBase (and also their file names) r=mccr8
This patch also renames:

EditorInputEventDispatcher -> mozilla::EditorInputEventDispatcher

And some variable names are renamed from aEditor or mEditor to aEditorBase or mEditorBase for making their types clearer.

MozReview-Commit-ID: 2FCXWpLMn8e

--HG--
rename : editor/libeditor/nsEditor.cpp => editor/libeditor/EditorBase.cpp
rename : editor/libeditor/nsEditor.h => editor/libeditor/EditorBase.h
2016-07-08 13:10:13 +09:00
Masayuki Nakano 28ebbbd99b Bug 1260651 part.13 Rename nsAutoPlaceHolderBatch to mozilla::AutoPlaceHolderBatch r=mccr8
MozReview-Commit-ID: E8IlZjFSFRU
2016-06-23 18:51:19 +09:00
Masayuki Nakano 9771fba160 Bug 1260651 part.1 Rename nsEditorUtils to mozilla::EditorUtils (and their files too) r=mccr8
MozReview-Commit-ID: 7Z48LHQBRo7

--HG--
rename : editor/libeditor/nsEditorUtils.cpp => editor/libeditor/EditorUtils.cpp
rename : editor/libeditor/nsEditorUtils.h => editor/libeditor/EditorUtils.h
extra : rebase_source : e53301378ab6001cdb126c5cc8742b7cadfbbccc
extra : source : 0147a9c79800924614157f1fa74cda3b9397f688
2016-07-07 11:49:42 +09:00
karel-de-macil@wanadoo.fr 38508b4757 Bug 1278281 - add SSL functionnality to ldap query in autoconf. r=mkaply
--HG--
extra : rebase_source : 8bff064dbdbc8b28df1292288b089461e76f6b3c
2016-06-07 18:10:46 +02:00
Dave Huseby 01531fb1f2 Bug 1280497 - fixes bug 1280497 by removing the assert and adding missing code in permission manage. r= baku
fixes bug 1280497 by removing the assert and adding missing code in
permission manager.

--HG--
extra : amend_source : 35cf87cc1a13fbb9cbe135a004373783c681ed6b
2016-06-17 08:18:00 +02:00
Jonathan Watt b15368cfcb Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky 2016-06-07 21:10:18 +01:00
Nicholas Nethercote ba949d4617 Bug 1278452 - Fix a typo in mozEnglishWordUtils::GetLanguage. r=ehsan.
|aLanguage| must be dereferenced when checked.

--HG--
extra : rebase_source : 8e5125c2eb99d66f731d58590a377b8238a81e70
2016-06-07 15:15:56 +10:00
Dragana Damjanovic 1de3e688ca Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi
--HG--
rename : toolkit/components/prompts/test/test_bug625187.html => toolkit/components/prompts/test/test_subresources_prompts.html
2016-06-06 01:06:00 +02:00
Carsten "Tomcat" Book e8d8c705a1 Backed out changeset 490d3460a197 (bug 1230462) for test failures in test_modal_prompts.html
--HG--
rename : toolkit/components/prompts/test/test_subresources_prompts.html => toolkit/components/prompts/test/test_bug625187.html
2016-06-05 11:26:57 +02:00
Dragana Damjanovic 8d4a3a8b49 Bug 1230462 - Change the authentiation dialog message. r=mayhemer,dolske,margaret,tanvi
--HG--
rename : toolkit/components/prompts/test/test_bug625187.html => toolkit/components/prompts/test/test_subresources_prompts.html
extra : rebase_source : f37ed50a558040dee1958c215ccc5559637d2f84
2016-06-03 09:09:00 +02:00
Carsten "Tomcat" Book 71eb3110f9 merge mozilla-inbound to mozilla-central a=merge 2016-06-03 12:00:06 +02:00
Carsten "Tomcat" Book 8f9e440056 Backed out changeset 1fe1c3b03d08 (bug 890908) on developer request 2016-06-03 05:51:06 +02:00
Tim Huang 8ec727cd19 Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 288c9cab8340c5cc06861d4f2c7ee43ae4de608e
2016-05-25 11:54:21 +08:00
Eric Rahm d16e0561bb Bug 1275064 - Use unsigned type in RealWord bitfield. r=froydnj 2016-05-25 12:15:27 -07:00
Jan Horak c623d87906 Bug 890908 - "Move Negotiate auth off main thread". r=mayhemer
--HG--
extra : rebase_source : db273dc19ab332a9c858778d6569c044e2901e93
2016-05-20 06:07:00 +02:00
Carsten "Tomcat" Book 9e3e4f59dc Backed out changeset ac9e8b31ac78 (bug 1275064) for bustage on a CLOSED TREE
--HG--
extra : rebase_source : d810dbef0beaebe2b9434300c0c89f66df84b3e2
2016-05-24 11:51:53 +02:00
Eric Rahm cb88225fa4 Bug 1275064 - Use unsigned type in RealWord bitfield. r=froydnj 2016-05-23 15:05:19 -07:00
Carsten "Tomcat" Book 2bec84cd13 Backed out changeset e3f130f1eb76 (bug 890908) for suspicion that something in this push caused failing Crashtests and Android/Valgrind issues on a CLOSED TREE 2016-05-23 11:37:57 +02:00
Jan Horak 1e1c7080c8 Bug 890908 - "Move Negotiate auth off main thread". r=mayhemer
--HG--
extra : rebase_source : 812c6c2237f01b5ad99f2dc2e0fd3d95a6d9f8c7
2016-05-20 06:07:00 +02:00
Eric Rahm 32c7d12a03 Bug 1261304 - Part 3: Avoid rebuilding real word list if possible. r=ehsan
We can avoid rebuilding the real word list if the begin and end nodes have not
changed. This can help with heap churn and possibly speed things up.
2016-05-21 10:07:16 -07:00
Eric Rahm af7d64ab20 Bug 1261304 - Part 2: Shrink RealWord struct. r=ehsan 2016-05-21 10:07:15 -07:00
Eric Rahm 60cbdf73f4 Bug 1261304 - Part 1: Make word splitting fallible. r=ehsan 2016-05-21 10:07:13 -07:00
Wes Kocher 2596f34110 Backed out 3 changesets (bug 1267910) for reports of it breaking session restore a=backout
Backed out changeset 5962f8e6d030 (bug 1267910)
Backed out changeset f8afc5cf9e0e (bug 1267910)
Backed out changeset cc202e0ac0dd (bug 1267910)
2016-05-20 21:15:17 -07:00
Tim Huang ad550d017f Bug 1267910 - Part 2: Update all existing functions of add() and getCookiesFromHost() to make them origin attributes aware. r=jdm, r=mratcliffe
--HG--
extra : rebase_source : 3d8b306dfa83363c01c4db5d018c55fddf6d1595
2016-05-18 20:42:00 -04:00
David Woodhouse 311f885efd Bug 1270046 - Accept "AF" response from Samba 4.3.8, r=honzab.moz 2016-05-17 12:51:49 -07:00
James Andreou 1d32e86b9c Bug 1269361 - Add mPrivateBrowsingId to OriginAttributes r=ehsan,jdm 2016-06-02 17:03:11 -04:00
Chris Peterson 8a9e2d2bd4 Bug 1272513 - Part 2: Remove redundant -Wshadow CXXFLAGS from moz.build files. r=glandium 2016-05-14 00:54:55 -07:00