The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):
- Never set the buffer's mode.
Years ago, Emacs did not have a good JavaScript mode, so it made sense
to use Java or C++ mode in .js files. However, Emacs has had js-mode for
years now; it's perfectly serviceable, and is available and enabled by
default in all major Emacs packagings.
Selecting a mode in the -*- file variable line -*- is almost always the
wrong thing to do anyway. It overrides Emacs's default choice, which is
(now) reasonable; and even worse, it overrides settings the user might
have made in their '.emacs' file for that file extension. It's only
useful when there's something specific about that particular file that
makes a particular mode appropriate.
- Correctly propagate settings that establish the correct indentation
level for this file: c-basic-offset and js2-basic-offset should be
js-indent-level. Whatever value they're given should be preserved;
different parts of our tree use different indentation styles.
- We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
Remove tab-width: settings, at least in files that don't contain tab
characters.
- Remove js2-mode settings that belong in the user's .emacs file, like
js2-skip-preprocessor-directives.
Every directory with a jar.mn now has JAR_MANIFESTS defined in its
moz.build file.
We also removed the may_skip special consideration of jar.mn files
because this information is now available during tier traversal by the
reader courtesy of the variables being present in moz.build files.
--HG--
extra : rebase_source : 21049b15e6bd9cf65b0805ccaccc4ba5aae93c98
extra : amend_source : 0b1ea866d725beef92d37c6f6d475369ac002e19
This patch does the following:
* It adds nsITransferable::Init(nsILoadContext*). The load context
might be null, which means that the transferable is non-private, but
if it's non-null, we extract the boolean value for the privacy mode
and store it in the transferable.
* It adds checks in debug builds to make sure that Init is always
called, in form of fatal assertions.
* It adds nsIDOMDocument* agruments to nsIClipboardHelper methods which
represent the document that the string is coming from.
nsIClipboardHelper implementation internally gets the nsILoadContext
from that and passes it on to the transferable upon creation. The
reason that I did this was that nsIClipboardHelper is supposed to be a
high-level helper, and in most of its call sites, we have easy access
to a document object.
* It modifies all of the call sites of the above interfaces according to
this change.
* It adds a GetLoadContext helper to nsIDocument to help with changing
the call sites.
Birunthan Mohanathas
Abdelrhman Ahmed
Tim Nguyen
Richard Marti
Jim Blandy
Masayuki Nakano
Marco Zehe
Neil Rashbrook
Gregory Szorc
Kyle Machulis
Trevor Saunders
Florian Quèze
Mike Hommey
Ehsan Akhgari
Ed Morley
Gervase Markham
Johan Charlez
aceman
Phil Ringnalda
Gavin Sharp
Geoff Lankow
Tobias Markus
Boris Zbarsky
Felix Fung
Jezreel Ng
Dão Gottwald
Adam Dane [:hobophobe]
Dave Townsend
David Bolter
Mehdi Mulani
Smokey Ardisson
Steffen Wilberg
Markus Stange
rbs@maths.uq.edu.au