This patch initializes some HAL components greedily so that we can get rid of
lazy initializers within the code. Observers are still lazily initialized
because they can be instanced within content processes but that doesn't always
happen and we don't want to pay the memory price for structures we don't use.
Shutdown is now happening at a fixed time for all HAL components save
WakeLocks. This ensures that we don't destroy an object while still iterating
over it, something that could happen before.
Finally a workaround for a compiler limitation has been removed.
Differential Revision: https://phabricator.services.mozilla.com/D3100
--HG--
extra : moz-landing-system : lando
This patch removes the 'ScreenOrientationInternal' type from
dom/base/ScreenOrientation.h and moves it into the
HalScreenConfiguration.h header, renaming it simply to 'ScreenOrientation'
in the process. This has several knock-off effects:
- It allows files that needed ScreenOrientationInternal to include a much
smaller header than before
- It greatly reduces the number of headers pulled in when including Hal.h
- It clarifies the role of the type. The 'Internal' part in the name had
nothing to do with it being part of the implementation. The type was public
and called that way only to avoid clashing with the 'ScreenOrientation'
class. Since we moved it into a different namespace it can be renamed
safely.
- It allows a file that was manually re-declaring 'ScreenConfigurationInternal'
type to use the original one
- Finally this fixes a few files which were missing headers they actually
required but that would still build because unified compilation put them into
units that already had those headers thanks to ScreenConfiguration.h
Differential Revision: https://phabricator.services.mozilla.com/D4458
--HG--
extra : moz-landing-system : lando
This also replaces the custom logic in ObserverList with an nsTObserverArray
which has all the necessary logic for stable iteration over a potentially
changing list of items. Unused dependencies were also removed.
--HG--
extra : source : 303478f7f248470a1c747f42dad9cb85c3129f0a
This also replaces the custom logic in ObserverList with an nsTObserverArray
which has all the necessary logic for stable iteration over a potentially
changing list of items. Unused dependencies were also removed.
--HG--
extra : source : 1a83516d2ee5939052c5fb226b81563a0d114ff9
Time API is already removed, so hal backend is unnecessary now.
MozReview-Commit-ID: 8R2VRYIX9Vs
--HG--
extra : rebase_source : 4e927dcf0f0d2a3ae802332fff438985b0be14f1
By bug 130884, we removed alarm API, so we should remove alarm backend from HAL.
MozReview-Commit-ID: EBiMJSUfUHu
--HG--
extra : rebase_source : d8c7b3592377702e789ccb1402124f1ecf2cdc01
The new HAL interface allows for starting, stopping, and querying
the status of system services. How these operations are performed
depends on the underlying system.
The current implementation for Gonk already contains a workaround
from Bluetooth, where quickly restarted system services require a
cool-down time between retrys.
Bug 789130 swapped out an assert for a warning, but in the discussion it's clear that the API was intentionally loosened to allow for this condition. Here the warning is removed as this is expected behavior.
The bulk of this commit was generated by running:
run-clang-tidy.py \
-checks='-*,llvm-namespace-comment' \
-header-filter=^/.../mozilla-central/.* \
-fix
Gabriele Svelto
Hiroyuki Ikezoe
Dorel Luca
Randell Jesup
Noemi Erli
Adrian Wielgosik
Ryan Hunt
Makoto Kato
Nicholas Nethercote
Andrea Marchesini
Gabor Krizsanits
Andi-Bogdan Postelnicu
Ehsan Akhgari
Carsten "Tomcat" Book
Michelangelo De Simone
sajitk
Trevor Saunders
Mantaroh Yoshinaga
Kyle Huey
Wes Kocher
Sylvestre Ledru
Thomas Zimmermann
Nigel Babu
Ted Clancy
William Chen
Eric Rahm
Birunthan Mohanathas