4153810bc8
Bug 1521577 - Don't block a MediaStream where at least one track is pulled. r=achronop
...
With the per-track pulling settings we have today it is clearly the intention
of the producer to start consuming a track that has pulling enabled, even if
there are other tracks where pulling is disabled.
This patch fixes that, so that when a stream has at least one pulled track it
will append null data to other tracks (commonly video) if they are lacking
data.
This means that we still block an entire stream if all tracks have pulling
disabled - to maintain the status quo for media element capture, which is
the only push-only producer of data.
Differential Revision: https://phabricator.services.mozilla.com/D17611
--HG--
extra : moz-landing-system : lando
2019-01-28 07:26:03 +00:00
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
8acabc8a13
Bug 1513973 - Log NotifyPull per track instead of per stream. r=jib
...
This better reflects the actual pulling that we do.
Differential Revision: https://phabricator.services.mozilla.com/D15195
--HG--
extra : moz-landing-system : lando
2019-01-04 06:39:58 +00:00
12e4f91411
Backed out 5 changesets (bug 1513973) for browser-chrome failures in browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js. CLOSED TREE
...
Backed out changeset 2ddf61b1db11 (bug 1513973)
Backed out changeset 6c839f548745 (bug 1513973)
Backed out changeset 5669b30f2265 (bug 1513973)
Backed out changeset 6781e633d62c (bug 1513973)
Backed out changeset f1892f178011 (bug 1513973)
2018-12-21 23:28:51 +02:00
37c4490c3b
Bug 1513973 - Log NotifyPull per track instead of per stream. r=jib
...
This better reflects the actual pulling that we do.
Differential Revision: https://phabricator.services.mozilla.com/D15195
--HG--
extra : moz-landing-system : lando
2018-12-21 20:21:24 +00:00
88cb071d63
Bug 1513638 - Rename DispatchToMainThreadAfterStreamStateUpdate to DispatchToMainThreadStableState. r=jya,karlt
...
Differential Revision: https://phabricator.services.mozilla.com/D14421
--HG--
extra : moz-landing-system : lando
2018-12-19 04:34:10 +00:00
7cc33e93cf
Bug 1497175 - Have DOMMediaStream::TrackPort::BlockSourceTrackId() return a promise. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D8010
--HG--
extra : moz-landing-system : lando
2018-11-30 05:14:40 +00:00
f0bf48464f
Bug 1509548 - Make MediaStreamGraph pull data per track instead of per stream. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D13086
--HG--
extra : moz-landing-system : lando
2018-11-29 17:37:42 +00:00
4954a5b020
Bug 1509548 - Remove early PullNewData return. r=padenot
...
Without knownTracksTime, StreamTracks::GetFirstTrackEnd() returns
STREAM_TIME_MAX for an empty StreamTracks, so PullNewData() thinks no new data
is needed.
This circumvents that by always checking whether tracks need data.
Differential Revision: https://phabricator.services.mozilla.com/D12928
--HG--
extra : moz-landing-system : lando
2018-11-29 17:37:35 +00:00
7348d2a804
Bug 1509548 - Rename track-end-time methods in StreamTracks. r=padenot
...
They deserve descriptive names.
Differential Revision: https://phabricator.services.mozilla.com/D12925
--HG--
extra : moz-landing-system : lando
2018-11-29 17:37:17 +00:00
a02fa011f0
Bug 1509548 - Remove the concept of a known tracks time from MediaStreamGraph. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D12923
--HG--
extra : moz-landing-system : lando
2018-11-29 17:37:06 +00:00
d665f43071
Bug 1423241 - Ignore ended tracks when checking for audio tracks in an MSG. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D12569
--HG--
extra : moz-landing-system : lando
2018-11-23 15:03:27 +00:00
60f5d461f2
Bug 1423241 - Remove MediaStreamListener \o/. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D12284
--HG--
extra : moz-landing-system : lando
2018-11-23 15:03:00 +00:00
28dcbfa728
Bug 1423241 - Ignore runnables for main thread after next stream state update, after entering shutdown. r=padenot
...
They may hang on to references causing leaks.
Differential Revision: https://phabricator.services.mozilla.com/D12281
--HG--
extra : moz-landing-system : lando
2018-11-23 15:02:42 +00:00
e80887ac8d
Bug 1423241 - Return appended StreamTime samples appended through AppendToTrack. r=padenot
...
This allows DecodedStream to accurately track how many samples have been
appended to a track, even with resampling enabled.
Differential Revision: https://phabricator.services.mozilla.com/D12272
--HG--
extra : moz-landing-system : lando
2018-11-23 15:01:48 +00:00
80cde33d12
Bug 1423241 - Always add tracks at the stream's current time. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D12271
--HG--
extra : moz-landing-system : lando
2018-11-23 15:01:42 +00:00
84905ffbe9
Bug 1423241 - Expose MSG's GraphTime through main-thread-Watchable and move media element to it. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D9101
--HG--
extra : moz-landing-system : lando
2018-11-23 15:01:13 +00:00
b2d7b962cd
Bug 1423241 - Implement MediaStreamTrackListener::NotifyOutput. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D9094
--HG--
extra : moz-landing-system : lando
2018-11-23 15:00:31 +00:00
e6f44b02af
Bug 1423241 - Fix MediaStreamTrackListener::NotifyEnded. r=padenot
...
Without this, NotifyEnded() happens before the track has been played out, at the
time it's marked ended by its producer. This change will actually make us wait
until the last chunk has been played out and then notify listeners.
Differential Revision: https://phabricator.services.mozilla.com/D12269
--HG--
extra : moz-landing-system : lando
2018-11-23 15:00:26 +00:00
c4ef19aea8
Bug 1423241 - Implement NotifyPull for MediaStreamTrackListener. r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D12267
--HG--
extra : moz-landing-system : lando
2018-11-23 15:00:14 +00:00
804b8b8883
Bug 1204606 - Reformat of dom/media r=jya
...
# skip-blame
Differential Revision: https://phabricator.services.mozilla.com/D12251
--HG--
extra : moz-landing-system : lando
2018-11-19 13:25:37 +00:00
c320ab35f2
Bug 1503132 remove mNonRealtimeProcessing r=padenot
...
Depends on D10171
Differential Revision: https://phabricator.services.mozilla.com/D10172
--HG--
extra : moz-landing-system : lando
2018-10-30 15:01:43 +00:00
0c06d3b60c
Bug 1503132 remove special-case sync dispatch for not-started offline RunAfterPendingUpdates() r=padenot
...
Depends on D10170
Differential Revision: https://phabricator.services.mozilla.com/D10171
--HG--
extra : moz-landing-system : lando
2018-10-30 15:01:28 +00:00
daf9a7dbdc
Bug 1503132 create offline graph thread on receipt of the first message r=padenot
...
With this change, the graph is already running when mEndTime is set and so
this must be done on the graph thread for consistent ordering with in-flight
messages.
Depends on D10168
Differential Revision: https://phabricator.services.mozilla.com/D10169
--HG--
extra : moz-landing-system : lando
2018-10-30 15:00:43 +00:00
fc6b49dc38
Bug 1503132 initialize mEndTime to zero for offline graphs r=padenot
...
This will prevent rendering from starting when the graph thread is started
before StartNonRealtimeProcessing() is called.
Depends on D10167
Differential Revision: https://phabricator.services.mozilla.com/D10168
--HG--
extra : moz-landing-system : lando
2018-10-30 09:51:35 +00:00
95a0d00031
Bug 1503132 remove unused ProcessedMediaStream::QueueFinish() r=padenot
...
Depends on D10166
Differential Revision: https://phabricator.services.mozilla.com/D10167
--HG--
extra : moz-landing-system : lando
2018-10-30 09:51:07 +00:00
583e8af90c
Bug 1503132 do not shut down graph thread on completion of offline rendering r=padenot
...
AudioWorket will need to keep processing events on the graph thread.
The graph thread is instead shut down when the AudioContext is destroyed.
Depends on D10165
Differential Revision: https://phabricator.services.mozilla.com/D10166
--HG--
extra : moz-landing-system : lando
2018-10-30 14:59:52 +00:00
8de2b7d0e5
Bug 1503132 when graph time has not advanced, only ensure another iteration if rendering r=padenot
...
Depends on D10164
Differential Revision: https://phabricator.services.mozilla.com/D10165
--HG--
extra : moz-landing-system : lando
2018-10-30 15:14:35 +00:00
a39a706827
Bug 1503132 update offline main thread state when there is no pending iteration r=padenot
...
Depends on D10163
Differential Revision: https://phabricator.services.mozilla.com/D10164
--HG--
extra : moz-landing-system : lando
2018-10-30 15:14:33 +00:00
b90b8e2060
Bug 1487057 - Part 9 - Make SourceMediaStream::SetEnded go through the message queue so it's in the right order w.r.t. Stop. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D7601
--HG--
extra : rebase_source : 75b9cbcaae6b403b4e7de8a2c979c4e43deebc20
2018-10-01 17:12:14 +02:00
3f4724fcbb
Bug 1487057 - Part 4 - Remove AsyncLatencyLogger and associated code. r=pehrsons
...
It's not maintained and probably does not work anymore.
Differential Revision: https://phabricator.services.mozilla.com/D5438
--HG--
extra : rebase_source : ccd622e40844dda5d16266e49991462d4ea94224
2018-08-30 17:11:57 +02:00
cfcb3f6cae
Bug 1487057 - Part 2 - Remove RegisterForAudioMixing/NeedsMixing, they are unused. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D5436
--HG--
extra : rebase_source : 107c7ff741569744c556ef0583c5c7231b502620
2018-08-29 15:29:08 +02:00
1c154b62b4
Bug 1483926 - Take into account mInputDeviceID is always nullptr on Android for now. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D3899
--HG--
extra : moz-landing-system : lando
2018-08-21 16:32:24 +00:00
3f50ca3b6f
Bug 1480036 - Allow scaling all MSG volume with a pref. r=pehrsons
...
Differential Revision: https://phabricator.services.mozilla.com/D2594
--HG--
extra : rebase_source : 12a931585d95fe190e6fc1e3b4fba9a2f0cd6cd9
extra : histedit_source : 355f316e6eba1feaa0ee3e7750feede92eeae4bc
2018-08-01 12:10:32 +02:00
7803237bca
Bug 1404977 - Exit NotifyInputData early if there's no input listener. r=achronop
...
MozReview-Commit-ID: KMy01D2VjLi
--HG--
extra : rebase_source : 3975d92084815cbc44b3d8bd437f6b838fd1f541
2018-08-03 14:14:36 +02:00
a1777772d7
Bug 1404977 - Part 13 - Remove useless mutex, and assert why they were useless, in WebRTCAudioDataListeners. r=pehrsons
...
MozReview-Commit-ID: 2Mb5WZXbYgS
--HG--
extra : rebase_source : c4a7c8874919901eb11327cfb5f86d6b185be388
2018-05-31 16:44:00 +02:00
ff9c7304e1
Bug 1404977 - Part 12 - Make DeviceChanged() notification thread safe by using the MSG message queue. r=pehrsons
...
This is slightly slower, especially if the main thread is busy, but it's cleaner
and actually safe.
MozReview-Commit-ID: 4C2FalxmE3L
--HG--
extra : rebase_source : 3f1341397bede31fcc35dab5a0cbf59b893f9b81
2018-05-31 16:42:24 +02:00
28fa83d1b5
Bug 1404977 - Part 10 - Make logging uniform, and consistently use GraphImpl() to access the graph impl. r=pehrsons
...
MozReview-Commit-ID: DZ7zhQsBtvy
--HG--
extra : rebase_source : d44599587cc11dccaecf6672fc4ffbaad1a5c14f
2018-04-17 17:11:13 +02:00
6622a3551d
Bug 1404977 - Part 9 - Propagate the changes to the GraphDrivers, simplifying them, and brokering all access through the MSG. r=pehrsons
...
For an AudioCallbackDriver, the number of input channels is immutable, and
passed at construction, so that it's less necessary to rely on global state.
MozReview-Commit-ID: F9TL1H92z3W
--HG--
extra : rebase_source : 5193488592ca97273eb2b6f43d4c7a0e4beb0a33
2018-04-30 16:01:56 +02:00
064d4d9b47
Bug 1404977 - Part 8 - Tell the MSG the MediaEngineAudioSource are now independent and that we can have multiple of them, cleanup the MSG-side API for managing them. r=pehrsons
...
The MSG now can feed microphone data to all its input listeners. This paves the
way for multiple input device, if we feel it's needed at some point, but does
not implement it.
The method for adding/removing inputs are also cleaned up.
MozReview-Commit-ID: 9OX4Da6Gjq2
--HG--
extra : rebase_source : 043c486e53f9220ae61fd788ed86064ba723f1a4
2018-04-30 16:01:38 +02:00
8b155b06b1
Bug 1479027 - Don't announce existing ended tracks when they have no input r=padenot
...
Differential Revision: https://phabricator.services.mozilla.com/D2596
--HG--
extra : moz-landing-system : lando
2018-08-01 14:47:46 +00:00
b06b413c9e
Bug 1471588 - Add details to SourceMediaStream and TrackUnionStream tracing. r=padenot
...
MozReview-Commit-ID: 38UoVtXILBk
--HG--
extra : rebase_source : 0665eb25e3717caa6635cfce3d8e028a252d022d
2018-06-27 18:30:13 +02:00
22e47fbddd
bug 1472925 keep a strong reference to MediaStreamGraph from GraphDriver r=padenot
...
--HG--
extra : rebase_source : 1db73541027a7b8f40365c6dc7977eb6be88c567
2018-07-03 17:23:09 +12:00
8b700896f3
Bug 1460346 - Verify that AudioMixer'callback is removed before the destruction of GraphDriver. r=padenot
...
MozReview-Commit-ID: Jd0PVw7xHDV
--HG--
extra : rebase_source : 2e50404b08778ceadd76691312861d134d7c1a42
2018-06-29 10:05:56 +02:00
cd6f5298c4
Bug 1460346 - Fix a case that ThreadedDriver is started when it is already working. r=padenot
...
MozReview-Commit-ID: 6R6WH3ITw03
--HG--
extra : rebase_source : 0762f709b7b82714f7c3a47ad59984e5bde49238
2018-05-25 11:58:58 +03:00
023dddff06
Bug 1460346 - Assert that driver switch request comes only from audio thread. r=pehrsons
...
MozReview-Commit-ID: B8ZTPE5qqpY
--HG--
extra : rebase_source : 9001972d910e5089c2c2fb72a912c3d18292094f
2018-05-22 19:51:48 +03:00
60732a90a5
Bug 1453795 - DOM/Media - Initialize member fields in classes/ structures. r=jyavenard
...
--HG--
extra : rebase_source : 0c785260497fadf98cf3cff8b9fcae8ea699c2c1
2018-06-15 10:25:02 +03:00
4c85ef17cc
Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
...
MozReview-Commit-ID: HpdFXqQdIOO
--HG--
extra : rebase_source : 1e7eea4f2d4ec16ec0c559a8afb26976ddbf4d07
2018-06-01 17:59:07 +02:00
7e765f798b
Backed out 2 changesets (bug 1465060) for build bustages on security/sandbox/linux/reporter/SandboxReporter.cpp
...
Backed out changeset 7c8905b6b226 (bug 1465060)
Backed out changeset 10446073eca8 (bug 1465060)
2018-06-03 19:25:41 +03:00
8d9dc85cd4
Bug 1465060 - Part 1: Fix warnings for std::move() use r=froydnj
...
MozReview-Commit-ID: HpdFXqQdIOO
--HG--
extra : rebase_source : 619d0e0ff63a2453c80f0c4d9beb906d43fa9b01
2018-06-01 17:59:07 +02:00
Andreas Pehrson
Ehsan Akhgari
Andreas Pehrson
Dorel Luca
Jan-Ivar Bruaroey
Sylvestre Ledru
Karl Tomlinson
Paul Adenot
Alex Chronopoulos
Andi-Bogdan Postelnicu
Miko Mynttinen
arthur.iakab