Fix a mistake in calculating the correct offset for one of the
replacement steps, which caused the IndexOutOfBoundsException. The old
code used `oldEnd` for the second text replacement without taking into
account the offset change as a result of the first text replacement that
was already performed. The new code correctly takes the offset, `delta`,
into account.
We only extract metadata that we'd want to store. For now this is just image_url.
In case we try to store page metadata before corresponding history record has been inserted,
we queue up metadata and wait for an event from GlobalHistory letting us know that history
record is now available, at which point we try inserting metadata again.
MozReview-Commit-ID: 2FpIqc6uHMb
--HG--
extra : rebase_source : 5839e04f82e174f50a61c107d271b4bda3f748c8
Importing 'os' in python configure functions, on Windows, changes the
separate the various os.path functions use, and that can have
unexpected, badly handled, consequences. While on the long term, it is
desirable to make @imports('os') modify os.path to use the same base
functions as if there were no @imports, let's go with the simpler
workaround of restoring the non-{isfile,isdir,exists} os.path functions
from b6be0e9e3e1e.
--HG--
extra : rebase_source : a1857b5dce2aa818c72a77d0d9727ac6ce16cb8f
We'll want to switch to AppCompatResources as soon as it's available (i.e. support library 24.2).
Keeping this call in one central location should make that upgrade slightly easier. (Especially
since there is a good chance we will expand VectorDrawable usage to other parts of the app
before we get round to upgrading the support library.)
MozReview-Commit-ID: CvnLzE0mbwz
--HG--
extra : rebase_source : 07155a0755ea98b311bf5a66c75e65d7fa9acf04
Catching everything is annoying, since we want to be able to see non-JSON related
exceptions that happen during icon loading. Specifically: it was harder to debug
issues during the VectorDrawable support upgrade.
MozReview-Commit-ID: 79j7FRxu2hh
--HG--
extra : rebase_source : 4bb14434fce255fea585072e83e3d3723a72611b
In order to use VectorDrawable's in this code we need to use AppCompatDrawableManager, which
is in the v7 appcompat support library. GeckoView cannot access that library, hence
we should move getDrawable() into the main Fennec jar in order to let us use
VectorDrawable's.
Similarly we need to move DrawableUtil for the same reasons.
(This commit only takes care of moving the code, the following code adds VectorDrawable support.)
MozReview-Commit-ID: CE2yTMLgBlJ
--HG--
rename : mobile/android/geckoview/src/main/java/org/mozilla/gecko/util/DrawableUtil.java => mobile/android/base/java/org/mozilla/gecko/util/DrawableUtil.java
extra : rebase_source : 7f97964f2944c8062ccbcc2439b001a966a287ee
Make the TabsListLayoutAnimator a DefaultItemAnimatorBase.
MozReview-Commit-ID: 4vZ93ACPUq
--HG--
extra : rebase_source : 80a103c9115c4cef76fe65282e448da66ba97401
Enable the rust mp4 parser code like we do on desktop.
MozReview-Commit-ID: 92XLeY2VdIM
--HG--
extra : rebase_source : 755b4b4619ff33f061695df023dd9968cabbac07
I'm not quite sure when this slipped in - and I probably didn't test carefully enough.
MozReview-Commit-ID: Ki1VC693NHQ
--HG--
extra : rebase_source : acde4f9c2cae7eef7b8f6db601fa335677a3ee7c
Not really happy about the change but it addresses the problem.
* Loading the list from disk is much faster than parsing the string (2500ms vs. 30-50ms on a Nexus 6P)
* Because of (potential) disk I/O we are required to extract the label asynchronously on a background thread
* We load the list only once and then keep it in memory - like we did before the change.
MozReview-Commit-ID: 9MPGbmIGRnS
--HG--
extra : rebase_source : 8b31f852c6bb90fd57baeb07ba0066421d5a6e46
Phil Ringnalda
Jim Chen
Dylan Roeh
James Cheng
Grisha Kruglov
Mike Hommey
Andrzej Hunt
Nevin Chen
Kilik Kuo
KuoE0
Alastor Wu
Tom Klein
Ralph Giles
Geoff Brown
Sebastian Kaspari
Jonathan Almeida (:jonalmeida)
Mike Taylor
Wes Kocher
Carsten "Tomcat" Book