This does _not_ convert .disabled selectors on non-<form> elements such as
panel-list-items since presumably in such cases the 'disabled' class is being
used to grey-out a whole chunk of content.
For form elements, however, authors shouldn't be greying out elements with the
'disabled' class without also actually making the form element itself disabled
(e.g. with the disabled attribute).
Differential Revision: https://phabricator.services.mozilla.com/D3856
--HG--
extra : moz-landing-system : lando
This allows JS callers to automatically get the correct types during
interation, without having to explicitly specify them.
Differential Revision: https://phabricator.services.mozilla.com/D3728
--HG--
extra : rebase_source : b708f382d8ea571d199c669bfed5b5a7ca9ffac4
extra : histedit_source : 7df6feb82088c8a5ca45dc28fe4d2b852c177fee
In order to allow JS callers to use nsISimpleEnumerator instances with the JS
iteration protocol, we'll need to additional methods to every instance. Since
we currently have a large number of unrelated implementations, it would be
best if they could share the same implementation for the JS portion of the
protocol.
This patch adds a stub nsSimpleEnumerator base class, and updates all existing
implementations to inherit from it. A follow-up will add a new base interface
to this class, and implement the additional functionality required for JS
iteration.
Differential Revision: https://phabricator.services.mozilla.com/D3725
--HG--
extra : rebase_source : ad66d7b266856d5a750c772e4710679fab9434b1
extra : histedit_source : a83ebffbf2f0b191ba7de9007f73def6b9a955b8
This updates some copy based on UX and legal requirements as well as add a correct
SUMO URL for the "Learn More" link for breakage reporting.
Differential Revision: https://phabricator.services.mozilla.com/D4172
--HG--
extra : moz-landing-system : lando
Moving forward, we’d like the pref “extensions.pocket.settings.test.panelSignUp”
to get set to “control” by default for users that don’t have the pref already set
(e.g. users that haven’t clicked on the Pocket button before).
Differential Revision: https://phabricator.services.mozilla.com/D4151
--HG--
extra : moz-landing-system : lando
Bug 1470910 broke the positioning because it changed the tag name of .urlbar-input-box but didn't update the related rule in browser.css, and then bug 1480355 landed and made it worse. This patch fixes the first problem by updating the tag name in the CSS, and it fixes the second problem (and bug 1480355) by setting `direction: ltr` on .urlbar-input-box.
Differential Revision: https://phabricator.services.mozilla.com/D4015
--HG--
extra : moz-landing-system : lando
The XUL elements were not being created because of the wrong createElement
call.
MozReview-Commit-ID: 54RqUJQAqHq
Differential Revision: https://phabricator.services.mozilla.com/D3998
--HG--
extra : moz-landing-system : lando
nsSHEntry is the only class that instantiates those two interfaces, so the
separation is not useful. This lets us remove numerous pointless QIs.
--HG--
extra : rebase_source : 570b7ade669fb89a789184198bec9da186c5f1d3
- Remove the viewCert method from nsICertificateDialogs
- Remove all associated C++ code
- Directly invoke UI window where it was previous called.
- Update tests
MozReview-Commit-ID: 9b62Go0DjE9
Differential Revision: https://phabricator.services.mozilla.com/D3358
--HG--
extra : moz-landing-system : lando
This updates the Nightly DMG background to high resolution as given
by shorlander.
The image is passed through zopflipng as done in bug 1234008,
with metadata added back using exiftool as described in bug 1454610 comment 13.
Change is verified locally by re-packaging artifact build and inspecting
the resulting DMG.
Differential Revision: https://phabricator.services.mozilla.com/D3564
--HG--
extra : moz-landing-system : lando
Following steps in bug 1435359 comment 2 I have managed to restore the icon
position and the background image of the Developer Edition DMG.
We should uplift this to all affect versions.
Differential Revision: https://phabricator.services.mozilla.com/D3562
--HG--
extra : moz-landing-system : lando
Changes to browser.search.search API:
- Change the positional parameters to an object parameter.
- Rename "engineName" to "engine", and make this an optional parameter.
- Rename "searchTerms" to "query".
Changes to browser.search.search implementation:
- Simplify gBrowser getter. None of the "!gBrowser" conditionals are
necessary, as demonstrated by the new options page+sidebar tests
(which passed even after removing the `if (!gBrowser ...)` blocks).
Use windowTracker.topWindow for consistency with our other code.
Test changes:
- Remove unneeded name / "TEST_ID" in tests
- Use SEARCH_TERM constant in more places.
- New test: Using API from options page.
- New test: Using API from sidebar.
- New test: Using API without explicit "engine" parameter.
Differential Revision: https://phabricator.services.mozilla.com/D3417
--HG--
extra : moz-landing-system : lando
Bug 1438499 added an optional parameter to warnAboutClosingTabs.
In bug 1475427, the arguments to warnAboutClosingTabs changed, and instead
of passing a closing tab reference as the second argument, we now need to
pass the number of tabs as the first argument. The patch in that bug
updated the callsite in nsBrowserGlue.js to add the new argument, but
didn't remove the `null` argument that we were passing for the 'extra' tab.
Additionally, the change in bug 1475427 bails early from
warnAboutClosingTabs if the number of tabs passed is less than 2. That tab
count, too, needs to take into account multiple windows and not just the
last window iterated over.
This patch fixes both of these issues.
Differential Revision: https://phabricator.services.mozilla.com/D3807
--HG--
extra : moz-landing-system : lando
The "select" event handler workaround was originally added in bug 1379270 to make it
possible to focus and select the URL bar a little bit later. This ugly hack was to
workaround an issue with WebExtensions that override about:newtab with the
chrome_url_overrides property (the issue would be that the URL bar would not be
properly focused and selected if about:newtab was overridden).
Back in the day, this was necessary because the overriding URL was fully displayed
in the URL bar (moz-webextension://...). These days, when about:newtab is overridden,
the URL bar is still empty - we just end up showing the information about the
WebExtension overriding about:newtab to the left of the URL bar.
So I think we can remove the old workaround.
Differential Revision: https://phabricator.services.mozilla.com/D3447
--HG--
extra : moz-landing-system : lando
Bug 1314445 removed GMPService::GetPluginVersionForAPI and cleaned up code paths
around this that would notify users if the content decryption module (CDM) did
not satisfy version requirements. Some dead code appears to have been overlooked
and is removed by this patch.
Differential Revision: https://phabricator.services.mozilla.com/D3972
--HG--
extra : moz-landing-system : lando
Re-introduces support for setting remote icons provided a loading principal is
passed. Removes some now defunkt code from sessionstore.
Differential Revision: https://phabricator.services.mozilla.com/D3123
--HG--
extra : moz-landing-system : lando
Initialize WindowsPreviewPerTab later, and make its favicon update code more efficient.
Differential Revision: https://phabricator.services.mozilla.com/D2679
--HG--
extra : moz-landing-system : lando
Everywhere else in this file we match on .disabled or :not(.disabled) but in two
instances we have :not(disabled). That's never going to match since it's already
combined with an `input` or `textarea` type selector (and there's no <disabled>
element).
Differential Revision: https://phabricator.services.mozilla.com/D3743
--HG--
extra : moz-landing-system : lando
This also fixes unintended behavior for which clicking the selected item in the sidebar selector would hide the sidebar.
Differential Revision: https://phabricator.services.mozilla.com/D3145
--HG--
extra : rebase_source : 891c99ab68f4689513801a1957a3d3846b7ffe58
The immediate goal is only to remove the broadcasters, so we still require the labels to be set manually on the "toolbarbutton" and "menuitem" elements. Generating these elements programmatically from the new SidebarUI.sidebars object, both for built-in sidebars and extensions, can be a future improvement.
The autoCheck attribute is also unnecessary since it is only intended for the menu items, and they are already properly updated after their command is invoked. Since the attribute was written with the wrong capitalization, it already had no effect.
The persistence of the label of the sidebar selector is also unnecessary since it is already set on startup. Removing this does not seem to cause any additional flickering.
Differential Revision: https://phabricator.services.mozilla.com/D3143
--HG--
extra : rebase_source : a5712b8e9bbdea29ab9e9a1bbd93217b24c354b4
Kris Maglione
Brian Birtles
Oriol Brufau
Cosmin Sabou
Johann Hofmann
Gurzau Raul
Tiberius Oros
Tomislav Jovanovic
arthur.iakab
Ryan VanderMeulen
Dão Gottwald
Tim Nguyen
Robert Helmer
anthony
ffxbld
Tom Prince
Brindusan Cristian
shindli
Narcis Beleuzu
Drew Willcoxon
Brendan Dahl
Sebastian Hengst
Noemi Erli
Mark Banner
Nicholas Nethercote
Eliza Balazs
Dipen Patel
Ehsan Akhgari
Andreea Pavel
Matthew Noorenberghe
Timothy Guan-tin Chien
Dennis Schubert
Dorel Luca
Rob Wu
Jonathan Kingston
Jan Beich
Gijs Kruitbosch
Michael Kaply
Mike Conley
ExE Boss
Bryce Van Dyk
Mike Hommey
Csoregi Natalia
Brian Grinstead
Haik Aftandilian
Dave Townsend
Paolo Amadini