Граф коммитов

11034 Коммитов

Автор SHA1 Сообщение Дата
Christoph Kerschbaumer 2167936456 Bug 1742780: Update extensions/permissions/test/browser_permmgr_viewsrc.js to work with https-first enabled r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D132004
2021-11-24 10:41:07 +00:00
Benjamin VanderSloot d507f1209f Bug 1731739 part 3 - Migrate permissions for 3rdPartyStorage to site keys, r=pbz,timhuang
- Increment permissions database schema version
- Apply GetSite to origin keys with type prefixed by "3rdPartyStorage^"
  - Done in a transaction
- Add unit test for migration

Differential Revision: https://phabricator.services.mozilla.com/D130676
2021-11-23 18:25:58 +00:00
Benjamin VanderSloot 83bac9db86 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 18:25:58 +00:00
Marian-Vasile Laza 0e7ef02d35 Backed out 3 changesets (bug 1731739) for causing build bustages on PermissionManager.cpp.
Backed out changeset 2f723b6e625b (bug 1731739)
Backed out changeset 7b053cfeab3e (bug 1731739)
Backed out changeset c4a31c29c441 (bug 1731739)
2021-11-23 19:06:14 +02:00
Benjamin VanderSloot 73087d0fec Bug 1731739 part 3 - Migrate permissions for 3rdPartyStorage to site keys, r=pbz,timhuang
- Increment permissions database schema version
- Apply GetSite to origin keys with type prefixed by "3rdPartyStorage^"
  - Done in a transaction
- Add unit test for migration

Differential Revision: https://phabricator.services.mozilla.com/D130676
2021-11-23 16:18:42 +00:00
Benjamin VanderSloot 921cf98880 Bug 1731739 part 2 - Use site as key for 3rdPartyStorage permissions, rather than origin r=anti-tracking-reviewers,pbz,timhuang
- Adding browser tests to verify correct behavior in integration
    - New test that fails on previous version: toolkit/components/antitracking/test/browser/browser_storageAccessScopeSameSiteWrite.js
- Add the ability to store permission by site, use 3rdPartyStorage for this
- No change is made to permission reads. These already proceed recursively, which eventually reach the site.
- When fetching all permissions for a principal, also look for site-scoped permissions on its site's principal

Differential Revision: https://phabricator.services.mozilla.com/D130675
2021-11-23 16:18:42 +00:00
Deian Stefan 26994de326 Bug 1738550 - Clean up RLBox type definitions r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D129970
2021-11-18 19:51:08 +00:00
Luca Greco d9085976ad Bug 1738713 - Fix permission not sent over ipc while non-http/https blob urls exists. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D130857
2021-11-15 17:30:19 +00:00
shravanrn@gmail.com 084c4704b8 Bug 1740399 - Ensure hunspell fails gracefully on rlbox sandbox OOM r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D130827
2021-11-10 05:21:55 +00:00
shravanrn@gmail.com 2ea9e2154b Bug 1740353 - Configure hunspell rlbox sandbox so AMO dictionaries have a smaller footprint r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D130793
2021-11-10 01:24:41 +00:00
shravanrn@gmail.com 5864d16cf7 Bug 1739669 - Configure hunspell rlbox sandbox for higher mem size depending on locale r=bholley
Differential Revision: https://phabricator.services.mozilla.com/D130544
2021-11-09 16:58:26 +00:00
Masayuki Nakano 1034b36c49 Bug 1739545 - part 1: Get rid of `mozInlineSpellChecker::DidJoinNodes()` and `mozInlineSpellChecker::DidSplitNode()` r=m_kato
Currently, they do nothing because they specify empty range to
`SpellCheckBetweenNodes()`, and it makes the method does nothing.  This is
filed as bug 1581714.  However, they are not required because `HTMLEditor`
notifies `mozInlineSpellChecker` at ending handling the top level edit sub
action.
https://searchfox.org/mozilla-central/rev/a12c2c2e59c92d8f969d8f3f290ab16919449c9d/editor/libeditor/HTMLEditSubActionHandler.cpp#675

Therefore, these methods are not necessary anymore.

Differential Revision: https://phabricator.services.mozilla.com/D130457
2021-11-09 01:09:20 +00:00
ssummar 0992acc367 Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-08 08:14:00 +00:00
Cristian Tuns 71486b8924 Backed out changeset 7e8e3747c3f8 (bug 1603127) for causing toolchains build bustages (Bug 1739589). CLOSED TREE 2021-11-05 07:23:45 -04:00
ssummar 508562cc85 Bug 1603127 - Replaced mozilla::Tuple with std::tuple and applied structured bindings in mozilla/Encoding.h. r=hsivonen
Differential Revision: https://phabricator.services.mozilla.com/D129920
2021-11-05 05:33:58 +00:00
shravanrn@gmail.com 2a11cb1f78 Bug 1737733 - Update rlbox wasm configuration to use direct function calls r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D128566
2021-10-26 23:41:11 +00:00
shravanrn@gmail.com 55472298f9 Bug 1737740 - Fix rlbox wasm sandboxed Hunspell mem leak and OOM handling r=glandium,deian
Differential Revision: https://phabricator.services.mozilla.com/D127736
2021-10-26 18:50:19 +00:00
Bobby Holley e9b6e43371 Bug 1737703 - Verify that RLBoxed Hunspell is only ever used on the main thread. r=shravanrn
Differential Revision: https://phabricator.services.mozilla.com/D129451
2021-10-25 22:58:26 +00:00
Narcis Beleuzu 66967cc3e6 Backed out 4 changesets (bug 1733686, bug 1735935) for causing sandboxing crashes with the spellchecker (bug 1736171) . CLOSED TREE
Backed out changeset c981fa4490fe (bug 1735935)
Backed out changeset a6fef4dc35c2 (bug 1733686)
Backed out changeset d52827e69092 (bug 1733686)
Backed out changeset 29ed3620fa91 (bug 1733686)
2021-10-16 18:43:13 +03:00
shravanrn@gmail.com 9d4b974755 Bug 1733686 part 2 - Fix Hunspell memory cleanup and OOM handling r=glandium,deian
Differential Revision: https://phabricator.services.mozilla.com/D127736
2021-10-15 06:37:22 +00:00
Masayuki Nakano 1836c00470 Bug 1729170 - Make all methods of `nsTextFragment` take `uint32_t` for the offset and length of text r=smaug
`nsTextFragment` is a storage of data node and DOM offset is `uint32_t`, but
some methods of `nsTextFragment` takes `int32_t` for the offset/length in
its text.  Therefore, callers need to cast from `uint32_t` to `int32_t` if
the offset value is offset in a DOM node.  Therefore, all methods of it should
take `uint32_t` values as offset/length in its text.

Differential Revision: https://phabricator.services.mozilla.com/D127923
2021-10-12 05:05:12 +00:00
Jens Stutte 25e990ea77 Bug 1731564: Use motivated SpinEventLoopUntil inside extensions/*. r=jesup
Depends on D127225

Differential Revision: https://phabricator.services.mozilla.com/D127226
2021-10-07 08:06:13 +00:00
Marian-Vasile Laza 18fb16c542 Backed out 18 changesets (bug 1731564) for causing build bustages on SpinEventLoopUntil. CLOSED TREE
Backed out changeset 0464dbdc8584 (bug 1731564)
Backed out changeset 0d996df13545 (bug 1731564)
Backed out changeset 5630a0e7a109 (bug 1731564)
Backed out changeset 37b41d187cdb (bug 1731564)
Backed out changeset d37700fa60b6 (bug 1731564)
Backed out changeset b0ce7db44b99 (bug 1731564)
Backed out changeset aa5ec3aa1535 (bug 1731564)
Backed out changeset 73b648f1fa70 (bug 1731564)
Backed out changeset bb8fb0f9833e (bug 1731564)
Backed out changeset 0d8905144f5d (bug 1731564)
Backed out changeset 2cfb094a1ec3 (bug 1731564)
Backed out changeset 78d3b0257a6a (bug 1731564)
Backed out changeset e9d32926e93c (bug 1731564)
Backed out changeset 874cab520ce5 (bug 1731564)
Backed out changeset d8071cc32bd9 (bug 1731564)
Backed out changeset 283c5393cbbc (bug 1731564)
Backed out changeset 317bc38e3de5 (bug 1731564)
Backed out changeset 53e3f4862439 (bug 1731564)
2021-10-07 00:09:19 +03:00
Jens Stutte fb5044cb38 Bug 1731564: Use motivated SpinEventLoopUntil inside extensions/*. r=jesup
Depends on D127225

Differential Revision: https://phabricator.services.mozilla.com/D127226
2021-10-06 19:45:14 +00:00
Agi Sferro fbd2730376 Bug 1714945 - Re-enable permissions tests on Android. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D127295
2021-10-05 22:10:00 +00:00
Agi Sferro b84a0603d7 Bug 1714945 - Allow setting permanent permissions for private browsing r=timhuang,johannh
By default nsIPermissionManager will not persist data in private browsing.

There are cases however, like private-only-browser Firefox Focus, where we
would want to be able to persist tracking protection exceptions permanently.

This patch adds a new method called
`addFromPrincipalAndPersistInPrivateBrowsing` which allows setting permanent
permissions in private browsing..

Differential Revision: https://phabricator.services.mozilla.com/D126544
2021-10-05 22:09:59 +00:00
Mirko Brodesser 2355592bf4 Bug 1731994: part 6) Update `sPermissionsMap`'s documentation. r=baku DONTBUILD
Because of `PermissionDelegateHandler::GetPermissionDelegateInfo`.

Differential Revision: https://phabricator.services.mozilla.com/D126789
2021-09-30 13:11:52 +00:00
Mike Hommey 70b2676ce8 Bug 1733034 - Fix linux bustage. CLOSED TREE 2021-09-30 04:26:22 +03:00
Mike Hommey e80f1e4448 Bug 1733034 - Ignore unreachable-core-return in PermissionManager.cpp. r=baku
extensions/permissions/PermissionManager.cpp:2468:12: error: 'return' will never be executed [-Werror,-Wunreachable-code-return]
    return NS_OK;
           ^~~~~

Differential Revision: https://phabricator.services.mozilla.com/D126875
2021-09-29 21:44:53 +00:00
Masayuki Nakano d7fa9ea462 Bug 1729653 - Make `mozInlineSpellChecker` handle events in the system group at capturing phase r=m_kato
Currently, `mozInlineSpellChecker` handles events in the default group.  This
means that the listener may not run if web app stops the propagation.  For
keeping the event listener order as far as possible, this patch changes to
listen to the event at capturing phase in the system group (editor handles
the events at bubbling phase in the system group).

Additionally, it listens to `keypress` events for handling caret/selection
changes.  However, they should be handled at `keydown` because those keys
are not printable.  Therefore, this patch changes to listen to `keydown`
events, but this could change the race between running the scheduled spellcheck
and following `keypress` event which is dispatched only for chrome code and
C++ event listeners.  However, this may not change it actually because the
race is changed only when the following `keypress` event delays too much.
https://searchfox.org/mozilla-central/rev/2eebd6e256fa0355e08421265e57ee1307836d92/extensions/spellcheck/src/mozInlineSpellChecker.cpp#503-504

Differential Revision: https://phabricator.services.mozilla.com/D126635
2021-09-28 02:47:15 +00:00
Mirko Brodesser b507a6325d Bug 1731994: part 4) Declare more methods around `ContentPermissionRequestBase` `const`. r=edgar
Differential Revision: https://phabricator.services.mozilla.com/D126350
2021-09-23 08:48:18 +00:00
Michelle Goossens d835eb1793 Bug 1727925 - Part 3: Migrate six more windows10-32 test suites from AWS to Azure r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D124192
2021-09-10 11:51:00 +00:00
Nicklas Boman 5f03e76d19 Bug 1308103 - Replace PL_strcmp/PL_strncmp with strcmp/strncmp in extensions/pref/autoconfig r=mkaply
Differential Revision: https://phabricator.services.mozilla.com/D123880
2021-09-09 19:36:11 +00:00
Ben Hearsum 4ca3a60f1d Bug 1714200: annotate tests that fail in regular suites but pass when run in isolation. r=jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D124907
2021-09-08 18:14:00 +00:00
Mark Banner 11bfa90d06 Bug 1602940 - Automated replacements to use Services.uuid. r=Gijs,necko-reviewers,preferences-reviewers,kershaw
Depends on D124391

Differential Revision: https://phabricator.services.mozilla.com/D124392
2021-09-06 09:53:52 +00:00
Henri Sivonen 5397b4f0a9 Bug 1727491 - Remove support for BOMless unlabeled Latin1 Supplement-range UTF-16LE|BE. r=emk
Differential Revision: https://phabricator.services.mozilla.com/D123596
2021-09-01 09:13:29 +00:00
Masayuki Nakano 44fd3a7047 Bug 1726532 - part 2: Make `mozSpellChecker::SetupDoc()` treat succeeded state as error if valid offset/length are not available when they are required r=m_kato
`TextServicesDocument::LastSelectedBlock()` may return `NS_OK` with
`UINT32_MAX` for both offset and length of the block.  The assertions causes
the new test not runnable in debug build.  So, we should make the situation
as an error case if they are required.

Ideally, we should fix the odd behavior, but it's not safe for uplift.
Therefore, this patch just adds the wallpapers.

Depends on D123282

Differential Revision: https://phabricator.services.mozilla.com/D123283
2021-08-24 03:29:21 +00:00
Masayuki Nakano 922488424d Bug 1726532 - part 1: Make `OffsetEntryArray::WillSetSelection()` use offset in text node when it sets a DOM node point r=m_kato
This is a mistake at replacing the argument value `aOffset` to
`aOffsetInTextInBlock`.
https://searchfox.org/mozilla-central/diff/886c96059ef6408618040356017028621bc574b9/editor/spellchecker/TextServicesDocument.cpp#1662

And also make `mozSpellChecker::Replace()` stop replacing if
`TextServicesDocument` fails to set selection or insert text because if
`TextServicesDocument` succeeded to insert text, but failed to delete text,
the loop becomes an infinite loop.

Differential Revision: https://phabricator.services.mozilla.com/D123282
2021-08-24 03:29:21 +00:00
Andi-Bogdan Postelnicu 75ed803f7c Bug 1725145 - fixes for linking in the hybrid build env. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D122344
2021-08-22 10:21:56 +00:00
Andi-Bogdan Postelnicu 250fa0d795 Bug 1725145 - header files fixes in the hybrid build env. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D122343
2021-08-22 10:21:55 +00:00
Paul Zuehlcke a466d4aa0a Bug 1687314 - Improve behavior of GetChannelResultStoragePrincipal and StoragePrincipalHelper::Create when handling NullPrincipal. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D122381
2021-08-17 12:51:22 +00:00
Makoto Kato 329f65c790 Bug 1725593 - Get rid of SendCheckAndSuggest sync IPC. r=masayuki,ipc-reviewers,mccr8
Depends on D122579

Differential Revision: https://phabricator.services.mozilla.com/D122580
2021-08-16 01:40:00 +00:00
Makoto Kato 3401597785 Bug 1725593 - Don't use SendCheckAndSuggest. r=masayuki
By bug 1719110, we replace sync IPC's spell checker suggestion with async
version. So we should remove this sync IPC call.

Differential Revision: https://phabricator.services.mozilla.com/D122579
2021-08-16 01:39:59 +00:00
Valentin Gosu 0cfda7bb4a Bug 1705659 - Static-analysis check auto fix for auth code r=necko-reviewers,dragana
Depends on D112604

Differential Revision: https://phabricator.services.mozilla.com/D112605
2021-08-12 12:39:25 +00:00
Valentin Gosu ae8827c0c3 Bug 1705659 - Avoid flatString in nsHttpNegotiateAuth::GenerateCredentials r=necko-reviewers,dragana
Depends on D112601

Differential Revision: https://phabricator.services.mozilla.com/D112603
2021-08-12 12:39:23 +00:00
Valentin Gosu b3d74be7b8 Bug 1705659 - Make GetAuthenticator work with nsACString r=necko-reviewers,dragana
Depends on D112602

Differential Revision: https://phabricator.services.mozilla.com/D112597
2021-08-12 12:39:22 +00:00
Mike Hommey 0b4372e828 Bug 1721968 - Remove support for lucetc for rlbox. r=firefox-build-system-reviewers,shravanrn,mhentges
Differential Revision: https://phabricator.services.mozilla.com/D120700
2021-08-11 21:58:52 +00:00
Makoto Kato 49cc605308 Bug 1719110 - Don't use sync IPC to show suggestion by spellchecker. r=Gijs
CheckCurrentWord on content process causes sync IPC, so I would like to remove
this call on content process. New nsIEditorSpellChecker.suggest method can
avoid it.

Differential Revision: https://phabricator.services.mozilla.com/D119937
2021-08-10 03:55:25 +00:00
Makoto Kato a6944a1428 Bug 1719110 - Add nsIEditorSpellCheck.suggest to get rid of PRemoteSpellcheckEngine.CheckAndSuggest. r=masayuki
When getting suggestions from spellchecker's result, we use sync IPC
(`PRemoteSpellcheckEngine.CheckAndSuggest`). This is used by showing context
menu only on Gecko. So I think that we can remove this IPC if we add async API
to get spellchecker suggestions.

And in comm-central's code, `CheckCurrentWord` and `GetSuggestedWord` seems to
use on spellchecker dialog (content/dialogs/EdSpellCheck.js in mail and suite)
that runs on parent process. So c-c won't use this IPC method.

So I would like to add the promise version of getting spellchecker's
suggestion.

Differential Revision: https://phabricator.services.mozilla.com/D119936
2021-08-10 03:55:25 +00:00
Paul Zuehlcke f6f5a3bca5 Bug 1721665 - Do not overwrite private browsing permission lifetime when removing permissions. r=timhuang,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D121749
2021-08-09 14:46:07 +00:00