Automatic update from web-platform-testsRevert "[ForeignObject] Paint foreign objects during the foreground phase of normal-flow"
This reverts commit 02a5799e0e02d7e7274d78833f897c81ae2cc434.
Reason for revert: Consistent failure of zoom-foreignObject.svg test on Windows 7.
See list:
https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Win7/
Original change's description:
> [ForeignObject] Paint foreign objects during the foreground phase of normal-flow
> descendants.
>
> When <foreignObject> was made a stacking context, it also had the side-effect of
> painting it at the same time as positioned elements. This is a change to painting
> order and caused a regression. Instead, implement a new mechanism by which a
> "replaced normal-flow stacking" element paints during the foreground phase
> of the LayoutObject paint tree walk.
>
> This is used for now just for <foreignObject>, but may be applied to other
> replaced elements such as iframes or embedded objects in the future.
>
> Bug:842668
>
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I450944986abfb6610084444abf2724e7406145cf
> Reviewed-on: https://chromium-review.googlesource.com/1060333
> Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
> Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559401}
TBR=trchen@chromium.org,pdr@chromium.org,chrishtr@chromium.org
Change-Id: I6742e134dae28a31bcb80fd13eccbc83d03ef332
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 842668
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1064150
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559496}
--
wpt-commits: 9d9ef5545b98e9890bd7a4dccf12c161911ab98a
wpt-pr: 11042
Automatic update from web-platform-tests[ForeignObject] Paint foreign objects during the foreground phase of normal-flow
descendants.
When <foreignObject> was made a stacking context, it also had the side-effect of
painting it at the same time as positioned elements. This is a change to painting
order and caused a regression. Instead, implement a new mechanism by which a
"replaced normal-flow stacking" element paints during the foreground phase
of the LayoutObject paint tree walk.
This is used for now just for <foreignObject>, but may be applied to other
replaced elements such as iframes or embedded objects in the future.
Bug:842668
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I450944986abfb6610084444abf2724e7406145cf
Reviewed-on: https://chromium-review.googlesource.com/1060333
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559401}
--
wpt-commits: 8139e965e11834763593fa8a041884b4d8f3de6b
wpt-pr: 11014
Automatic update from web-platform-testsUpdate LayoutTests to use '%23' instead of '#' in data URIs
This is a (very) partial reland of
https://chromium-review.googlesource.com/c/chromium/src/+/738395,
restoring only the changes to LayoutTests. This should be safe since
'%23' always has been a correct encoding of '#' and so should work with
the data URI code as it is today. It will also make any future re-land
of the core original CL easier.
Bug: 123004
Change-Id: I87126ea0e3fd39756e571a8e6cf966107e7f7209
Reviewed-on: https://chromium-review.googlesource.com/1048287
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559130}
--
wpt-commits: 053e59f6d2b10c58fc1440ca1a7e6383313a4a77
wpt-pr: 11032
Automatic update from web-platform-testsPrevent GitTree logging errors if git fails.
The errors logged when failing to get a git revision cause issues in the gecko infrastructure.
Fix this by passing throught the log_error=False flag to suppress printing the error.
--
wpt-commits: a0bd72dbb7db5f71add0d20ac0d9e2d20270700b
wpt-pr: 11036
Automatic update from web-platform-tests[LayoutNG] Fix min/max sizes during layout and intrinsic passes.
Essentially this boils down to during min/max auto/percent/calc should be
treated the same, either being border+padding or infinity.
And during layout they should be taken into account.
I added some tests which now match FF/Edge (004,005) which LayoutNG matches, but
existing layout fails. The primary difference is change by passing kContent into
ResolveBlockLength during the ComputeBlockSizeForFragment function.
Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I4e0c171a0e29ea5d85a742d85df001647813c1f3
Reviewed-on: https://chromium-review.googlesource.com/1056291
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559171}
--
wpt-commits: b06b08091c6a39d88957db2389727524258a3140
wpt-pr: 10994
Automatic update from web-platform-testsGeneralize subsetTest() in common/ and use for WebCryptoAPI tests (#11028)
Fixes#10890.
--
wpt-commits: e9c44b8cf4d6b3d7c7f2d5d629e83c616ea903e1
wpt-pr: 11028
Automatic update from web-platform-testsFind Chrome binary on more platforms and fail gracefully (#11000)
Also make similar changes to Opera. Fixes#10992.
--
wpt-commits: d516217b8c819b0ecafe1eff8868387892855858
wpt-pr: 11000
Automatic update from web-platform-tests[wptrunner] Add surface tests for `--list-tests`
Ensure that the WPT CLI exits successfully when the `--list-tests`
option is specified (including the case where no test manifest is
present).
--
[wptrunner] Recover from malformed test manifest
If the process of updating the test manifest is interrupted
unexpectedly, the file written to disk may not contain valid JSON.
Update that WPT CLI to recognize this condition and recover by
re-generating the manifest file.
--
wpt-commits: 4ae7daf23b5688e0a08d67ee71e4822b7c0171d3, a3a5824500bdf2515114c6653253a9d8d172d37a
wpt-pr: 10998
Automatic update from web-platform-testsUpdated Edge config to have a default timeout (#11017)
--
wpt-commits: 51ef063aa05b187ea234f4103cca54c91923803c
wpt-pr: 11017
Automatic update from web-platform-tests[css-contain] Layout containment abspos and fixed descendants
An element with "contain: layout" should be the containing block
of any absolutely or fixed positioned descendants.
The spec is very clear regarding this
(https://drafts.csswg.org/css-contain/#containment-layout):
"The element acts as a containing block for absolutely positioned
and fixed positioned descendants."
The patch just adds a new condition to
ComputedStyle::CanContainFixedPositionObjects().
We already had the condition for paint containment before,
so this takes advantage to add WPT tests to verify that case too.
This patch causes that contain-layout-005.html starts to fail,
but that's because of crbug.com/843329.
There are more failing tests related to that bug, so TestExpectations
is modified to reference it.
BUG=785212
TEST=external/wpt/css/css-contain/contain-layout-006.html
TEST=external/wpt/css/css-contain/contain-layout-007.html
Change-Id: I8bb1d637bd7742961a414a5007b8ee8a8d3e66ea
Reviewed-on: https://chromium-review.googlesource.com/1059557
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#559045}
--
wpt-commits: 90f40cbe8452a84496c3e83bbba5b1de3f26455f
wpt-pr: 11026
Automatic update from web-platform-testsAdd test to verify a particular PeerConnection setup does not deadlock
Does the connection setup in a specific sequence that historically
triggered a deadlock (https://crbug.com/736725). The test simply
verifies this specific sequence completes without errors or timeout.
Verified it fails on the deadlock by running the test on the parent commit
(2485344d4e8792bc4f9716deadda41fbc0d89ad9) of the original bug fix.
BUG=chromium:840737
Change-Id: I93d9d8cb50cad9629268971520de489450d8649b
Reviewed-on: https://chromium-review.googlesource.com/1057249
Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Kristoffer Erlandsson <kerl@google.com>
Cr-Commit-Position: refs/heads/master@{#559022}
--
wpt-commits: ad84337c037685845f96d63618bb9b46ae9e9468
wpt-pr: 10997
Automatic update from web-platform-testsAdded dictionary WebGLContextAttributes to avoid no original dictionary error
This PR fixed "Partial dictionary WebGLContextAttributes with no
original dictionary" error in webxr idlharness test
--
wpt-commits: 541c8abaca213664697ee645553245eb2cda7738
wpt-pr: 10947
Automatic update from web-platform-testsTest short regionCode (#11021)
With https://github.com/w3c/payment-request/pull/690 the spec changed
requiring `regionCode` to just be the "code element" of an [[!ISO3166-2]]
country subdivision name (e.g., "CA" for California).
--
wpt-commits: 32a16759d48dae9332763da98f8582bd320d82ea
wpt-pr: 11021
Automatic update from web-platform-testsWorker: Throw an ErrorEvent on a failure of module loading
This behavior is defined in the HTML spec:
Step 13: "If the algorithm asynchronously completes with null, queue a task to
fire an event named error at worker, and return."
https://html.spec.whatwg.org/multipage/workers.html#worker-processing-model
An ErrorEvent is created on a worker thread, and passed to the main thread to
dispatch it on a worker object in a document context.
Bug: 843031
Change-Id: I1fd82cba1e02b1658bb2b556742f7a206ee754a7
Reviewed-on: https://chromium-review.googlesource.com/1058998
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558903}
--
wpt-commits: 92a3d3d14638e8aff86eec3a2b1a6599249ea994
wpt-pr: 11003
Automatic update from web-platform-testsChange mojo manifest interface syntax from foo::mojom::Bar to foo.mojom.Bar.
This updates the bindings generators and hard-coded interface names in
tests and the service_manager.
The remainder of the CL was generated by:
for f in $(find . -name '*.json' -not \( -path './out/*' -o -path './third_party/*' -o -path '*.xcassets/*' \)); do
grep interface_provider_spec "./$f" >/dev/null && gsed -i s/::/./g "$f";
done
Tbr: jam@chromium.org
Bug: 835446
Change-Id: I0bb22615b9c66824c6f95da66e3d7016809d63c7
Reviewed-on: https://chromium-review.googlesource.com/1026419
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558841}
--
wpt-commits: e7a9162535d0e65a31ba79c26542ca865df31197
wpt-pr: 11001
Automatic update from web-platform-testsMerge pull request #11013 from cvazac/master
Server-Timing: clean up service-worker test
--
wpt-commits: 5478850d0df6d1d0f2e8c10f77f62d3c6e2dd589
wpt-pr: 11013
Before this patch, the x86-6.0 and x86-7.0 Android emulators were
unusable on macOS (tested 10.13.4 High Sierra).
The emulator's UI appears (but with black screen), and the launcher
icon in the dock has a default folder icon instead of the emulator.
When I use "mach android-emulator --version=x86-6.0 --verbose",
then the full emulator command is printed. I discovered that
using the newer QEMU 2 engine ("-engine qemu2") fixes the issue, and
that the emulator launches as expected. This option is documented at:
https://developer.android.com/studio/run/emulator-commandline
However, when I modify the source of these commands, then the emulator
fails to start (as before). This is caused by the setpgid call via
preexec_fn in testing/mozbase/mozprocess/mozprocess/processhandler.py .
Passing ignore_children=True to ProcessHandler avoids the setpgid call
and allows the emulator to be used as expected on macOS.
The effect of not using setpgid is that the spawned process will not
be put in the process group of the "mach" Python script. This is not
a big deal. I can confirm that the emulator can still be killed by
quitting or force-quitting it, and did not experience other issues.
MozReview-Commit-ID: 4AKVqtwIoCj
--HG--
extra : rebase_source : df6615a32de666d0f9d4f27c1c6f462120364ee2
This also removes the workerbootstrap test extension, which is no longer used,
and contains the last references to the Worker and ChromeWorker bootstrap
globals.
MozReview-Commit-ID: 8YWReXMqX5W
--HG--
extra : rebase_source : b0aa59b2b5e6a08f4be803e828bd507f894e4a19
Missed some references to run_command_m, get_output_from_command_m when
removing the mock mixin.
--HG--
extra : amend_source : 03626d4f65d06eaffab0ee754a9547d5624baa09
extra : histedit_source : 13bacfc1ccff78a1e17c996f66465439a7aa16dc
This check is already done by the dictionary init method. This function just
makes us do extra non-spec get operations.
For now this introduces more failures due to bug 1419323 and the spec issue at
<https://github.com/whatwg/html/issues/3580>. The tests testing for that stuff
were passing due to exceptions getting thrown from CheckLifeCycleCallbacks.
The geckoview-junit tests require the OSS audio backend for the Android
4.3 ARM emulator, but mochitests don't work well with the OSS audio
backend. Therefore, use a different config file for the geckoview-junit
tests.
MozReview-Commit-ID: 20tzjtVdTuB
Automatic update from web-platform-testsWebCryptoAPI: Use .any.js for generateKey tests and split up slow tests (#10984)
Slow tests test 10 subtests at a time, using the `// META: variant=...`
feature.
Fixes#10794.
--
wpt-commits: b395fb03bf62cbda20a383842b8da1701080ec43
wpt-pr: 10984
Automatic update from web-platform-testswebdriver: properly switching window focus after close of window (#10957)
The test_handle_prompt_accept test for closing a window tests to see if an
alert was handled. It does so by calling the Get Alert Text end point.
However, the Get Alert Text end point requires an active, valid top-level
browsing context to have the focus. The test now switches focus back to
the previous window before checking that an alert was handled. In between
checking the alert, confirm, and prompt cases, it recreates the new window
required so it can be closed.
--
wpt-commits: 973caf595dbfc6f7b101244ba3d8871c0c5bd510
wpt-pr: 10957
Automatic update from web-platform-testsAsync Cookies: Change events in service workers.
While installing, a service worker may call
cookieStore.subscribeToChanges() to express interest in observing the
changes to the list of cookies sent in a request to a specific URL.
After the service worker becomes active, it is notified of changes to
the cookies it is interested in via "cookiechange" events, which are
dispatched to the service worker's global scope.
This CL lays the last piece in the foundation of the Async Cookies API,
which is currently gated by the Experimental Web Platform Features flag.
This CL focuses on the core functionality and plumbing. Follow-up CLs
will add more tests, fix the handling of edge cases, and improve
performance.
Bug: 729800
Change-Id: I52f2e550d7901d746ed1a973426d3181ea091147
Reviewed-on: https://chromium-review.googlesource.com/979334
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558682}
--
wpt-commits: c16fdfb6fe53019649d14179bce3e50acdefa3b4
wpt-pr: 10946
Automatic update from web-platform-tests[wptserve] Correct domain configuration on *nix
Because Windows and UNIX-like systems differ in how they interpret the
IP address `0.0.0.0`, the hosts file contents generated for use with the
WPT server must take the platform into account.
Extend the hosts file generation logic and introduce "infrastructure
assumptions" tests to assert the inavailibility of the domain.
--
[infra] Rename nonexistent domain
Contributors have expressed confusion over the term "nonexistent origin"
to describe a domain that is not intended to exist. Rename the subdomain
to "nonexistent" to clarify its role.
--
wpt-commits: 136154864a88788cb58d6ff079e6d030cbe8c60f, 927cd2216d34dc2f9824a6899476f26b6b11dd31
wpt-pr: 10878
Automatic update from web-platform-testsRename *-expected.html to *-ref.html (#11004)
While there is no rule or lint for the naming, *-expected.html is the
convention in WebKit/Blink, and in WPT *-ref.html is the norm. (These
were the only *-expected.html, and there are 3000+ *-ref.html.)
--
wpt-commits: 7f1de072fc9eac6757d0b0691ad2194894b74a67
wpt-pr: 11004
--HG--
rename : testing/web-platform/tests/css/css-fonts/support/fonts/font-feature-settings-rendering-2-expected.html => testing/web-platform/tests/css/css-fonts/support/fonts/font-feature-settings-rendering-2-ref.html
rename : testing/web-platform/tests/fetch/corb/img-html-correctly-labeled.sub-expected.html => testing/web-platform/tests/fetch/corb/img-html-correctly-labeled.sub-ref.html
rename : testing/web-platform/tests/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub-expected.html => testing/web-platform/tests/fetch/corb/img-png-mislabeled-as-html-nosniff.tentative.sub-ref.html
rename : testing/web-platform/tests/fetch/corb/img-png-mislabeled-as-html.sub-expected.html => testing/web-platform/tests/fetch/corb/img-png-mislabeled-as-html.sub-ref.html
rename : testing/web-platform/tests/svg/extensibility/foreignObject/stacking-context-expected.html => testing/web-platform/tests/svg/extensibility/foreignObject/stacking-context-ref.html
Automatic update from web-platform-testsMerge pull request #10973 from csnardi/parsing-tests
Use getPropertyValue in parsing-testcommon.js
--
wpt-commits: b18d298125b77bb5da7b143500a24bbacea91746
wpt-pr: 10973
Automatic update from web-platform-testsMerge pull request #10991 from cvazac/cvazac/tao
Server-Timing: test TAO:* for cross-origin resource
--
wpt-commits: 8043ae8364ab296e74666dd499c0b257c03134d2
wpt-pr: 10991
Automatic update from web-platform-testsChange how invalid base URLs are tested
Fixes#8707. Supercedes #10917, which it is based on.
This keeps the tests inside urltestdata.json, but adds a new requirement on consumers of that file that they should also test their base URL parsing logic by reusing the data in a different way.
It also rearranges the various cases from 90efdbecfe3c457b36c71cf3e01a72cd5301c163 under several different headings.
--
wpt-commits: 88b75886e68ce5197019a2707fc6f1b9645a4639
wpt-pr: 10955
Automatic update from web-platform-testsTest document.write() on various documents
See https://bugzilla.mozilla.org/show_bug.cgi?id=1444872 for context.
--
wpt-commits: 1fdae86115774466c43ad13bc203eb6207b2e8ff
wpt-pr: 10209
Automatic update from web-platform-testsTeach the linter about // META: variant=
--
Stop making gsnedders glare at me
--
wpt-commits: bd57e8129ec9c06609307fb61011ddfb5c6233dc, c4eab5504321ac2b875fc5bf7a58d99056367379
wpt-pr: 10985
Automatic update from web-platform-tests[Squad] Get rid of MutableStyleRef() in list items.
Clone and reset ComputedStyle When modifying the style of anonymous
layout objects inside list items.
Bug: 813068
Change-Id: Icd0d9d93d0e64fd130cfb5ba151bce7c34bfb234
Reviewed-on: https://chromium-review.googlesource.com/1053727
Reviewed-by: cathie chen <cathiechen@tencent.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558257}
--
wpt-commits: b22e127b0477ecbae77b8a75173b1f93338d0af7
wpt-pr: 10979
Automatic update from web-platform-testsMake fetch_tests_from_worker return a promise that resolves when the remote tests complete.
--
wpt-commits: fcb5082b1653563d214d8ab146fe88cb95ec0cf5
wpt-pr: 10978
Automatic update from web-platform-tests[ServiceWorker] Propagate change for ServiceWorkerRegistration#updateViaCache
This CL propagates change of registration's `updateViaCache` to
corresponding registration objects in the renderer process to set their
ServiceWorkerRegistration#updateViaCache attribute.
BUG=675540
Change-Id: I6bb80dacbdd6a276f7ba8eb95f9f1e5379fbf03b
Reviewed-on: https://chromium-review.googlesource.com/1002732
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558157}
--
wpt-commits: 7baa33480dbd697d3ea5ed81012daef21f655fa7
wpt-pr: 10379
Automatic update from web-platform-testsAdd support for 'x' as a unit of resolution
In https://drafts.csswg.org/css-values-4/#resolution, 'x' is defined as
a synonym for dppx. Add support for parsing 'x' as dots per px.
Intent to Implement and Ship:
https://groups.google.com/a/chromium.org/d/topic/blink-dev/FsD97U77tss
Bug: 630597, 807653
Change-Id: I70c440c89e42cd005a9c58fd89745a5603e0dee6
Reviewed-on: https://chromium-review.googlesource.com/892467
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558119}
--
wpt-commits: 2e894defb9b5df72f6278b68403e01075249c6fe
wpt-pr: 9245
Automatic update from web-platform-testsFix XSS Auditor errors that prevent WebKit from running scripts loaded via inline.py.
Sending 'X-XSS-Protection: 0' in the response headers for the main document will opt
out of the XSS Auditor and allow inline event handlers (i.e., onmousemove) to run.
--
wpt-commits: 389b958c00a4d6b897bfce284c0c88bf451fb6b8
wpt-pr: 10968
Automatic update from web-platform-testsremove createTouch
Removes document.createTouch and related tests
createTouchList has relatively high UseCount(around 0.015%), see
https://www.chromestatus.com/metrics/feature/timeline/popularity/2368
We need to address these use cases before remove it.
Postpone createTouchList removal to M69
intent to deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/GLbUpUUnQzc
PR to touch-events spec:
https://github.com/w3c/touch-events/pull/96
Bug: 518868
Change-Id: If086b51b775e4be59320c4a1329988787ff6f870
Reviewed-on: https://chromium-review.googlesource.com/1041128
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Rick Byers <rbyers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557907}
--
wpt-commits: 6a23e9de469476253e59744a2635d3574bc33e1d
wpt-pr: 10813
Automatic update from web-platform-testsFix ignoring changes under resources in the stability checking script (#10929)
It turns out that this uses different input for excludes than the wpt
tests-affected script. The config file input is turned into a regexp
that tries to match the entire path, so "resources" would just match a
file called "resources" and "resources/**" is needed to match the
entire path.
--
wpt-commits: 3676e24927100849228bcc2fbc1ae1832782f91f
wpt-pr: 10929
Automatic update from web-platform-testsMerge pull request #10593 from csnardi/css-transforms-computed
Correct computed value of transform
--
wpt-commits: fb62383e4e08bcd8b2e902eaa86248d14e66873a
wpt-pr: 10593
Automatic update from web-platform-testsFeature-test global scopes without events and timeouts.
--
Add a ShellTestEnvironment class.
--
wpt-commits: 9d896a92c3c99ddfa356e5db78d92e3d9e0249e7, cb9176baeb50e0ee5a010218388e8120c09bab0f
wpt-pr: 10900
Automatic update from web-platform-testsCompute files-changed better in the face of merges
This finds the first unknown parent, instead of finding the oldest
commit that only exists on the branch
--
wpt-commits: aa1a4a7efb41d849119e013d5fd73fad52929944
wpt-pr: 10950
Automatic update from web-platform-tests[LayoutNG] LayoutNG table-caption implementation
New passes fast/writing-mode/table-hit-test.html and
tables/mozilla_expected_failures/marvin* had been failing in LayoutNG
because the captions were not centered above the table, for some reason.
The rebased test fast/table/multiple-captions-display-expected.png
failed due to differences on the edges of text inside the caption.
New failure accessibility/table-caption.html fails because the js
accessibility controller can no longer see the caption as a table child,
for some reason.
Making tables/mozilla_expected_failures/bugs/bug3166-16.html pass will
need some digging. Legacy and NG before this patch centered the caption
above the table. But after this patch, it is moved left. Further,
hovering over the caption triggers a DCHECK in the hit testing stack, so
maybe we need to set an offset after all.
ng_physical_fragment.h(144)] Check failed: is_placed_.
blink::NGPhysicalFragment::Offset()
blink::NGPaintFragment::Offset()
blink::NGBoxFragmentPainter::NodeAtPoint()
blink::NGBlockFlowPainter::NodeAtPoint()
blink::LayoutNGMixin<>::NodeAtPoint()
blink::LayoutTable::NodeAtPoint()
Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I7fcb33e791a9f0d812674a5f7f63cb5964c02a6e
Reviewed-on: https://chromium-review.googlesource.com/1050414
Commit-Queue: David Grogan <dgrogan@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557632}
--
wpt-commits: c650b3ea9ac78640b1ec4bf7e476db95154a41e5
wpt-pr: 10910
Automatic update from web-platform-testsAccname: Remove two tests (#10956)
One test covers something governed by HTML-AAM rather than Accname.
Plus HTML-AAM doesn't currently have language for the condition in
question.
The other test covers an edge case which should be covered by Accname
but isn't. Fixing the spec for this edge case is complicated, and we
do not yet have consensus on what the correct expected results are.
Therefore, the Working Group will address this in version 1.2.
--
wpt-commits: b5baf01b6cf9ca5ca2cc1945faddc5eeb4223d98
wpt-pr: 10956
Automatic update from web-platform-testsRemove Document#selectedStylesheetSet/preferredStylesheetSet
Document#selectedStylesheetSet/preferredStylesheetSet are non-standard
methods that are only implemented by WebKit and Blink. Their standard
versions are no longer in the spec. Remove them entirely from our
implementation.
Intent to Deprecate and Remove:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/w1Bv7YZxAco
Bug: 690609
Change-Id: I796a6bc0693934eb308a4fe59b52e4a9d1269e6f
Reviewed-on: https://chromium-review.googlesource.com/1049051
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557569}
--
wpt-commits: d1813f80c619a09d74496f2bb33187e8e33cceda
wpt-pr: 10939
Automatic update from web-platform-testsAdd browser version into run_info (and hence wptreport) (#10935)
First of all, `browser_version` is passed to `run_info`. The data flow is:
* wpt.run gets browser_version from wpt.browser during setup_wptrunner
* browser_version is passed to wptrunner.start via kwargs
* wptrunner then passes browser_version to RunInfo
Secondly, the version() methods in some browser setup classes were fixed.
And, `None` is returned by unimplemented version() instead of raising an
exception since the method is now always called.
--
wpt-commits: a87e3675f288170b8fa1d1fe90b44c8c82377856
wpt-pr: 10935
Automatic update from web-platform-testsComplete the migration from marionette-specific scripts.
Previously we removed the wrappedJSObject from
executor_marionette.js. However it turns out that this migration was
incomplete; in order to fully avoid the wrappedJSObject, we need to
ensure that we never create a sandbox on the marionette side. As a
result of this omission we were getting an error trying to call the
timeout() function, causing more EXTERNAL-TIMEOUTs and so performance
issues.
The solution is to ensure that the sandbox is None for all calls
to (content) js.
--
Add a test that should timeout to the infrastructure tests
--
wpt-commits: fce59968b2e620b098536c05c5409f7f6f6e4b66, a1b510cb7b823d741a5edf39d5fd510cf002abe8
wpt-pr: 10691
Automatic update from web-platform-tests[infra] Remove unnecessary configuration
This encrypted value was introduced to authorized the continuous
integration server to post comments to GitHub.com [1]. That
functionality was later relocated to an external application, but the
value was not removed from this project's configuration file [2].
Remove the value as it is no longer necessary.
[1] 50075bf587ceff5608e9a7d3297fdbc5cea35750
[2] 1ba7507b2f364c947b34ea43290573b759fef72f
--
wpt-commits: 01995ce7adccb6144421b351c40b46100e30fac1
wpt-pr: 10937
Automatic update from web-platform-testsWorklet: Change the default credentials mode from 'omit' to 'same-origin'
According to a recent spec change, this CL changes the default credentials mode
on WorkletOptions from 'omit' to 'same-origin'.
Spec issue: https://github.com/w3c/css-houdini-drafts/issues/756
Feature dashboard: https://www.chromestatus.com/feature/6383899018002432
Bug: 838540
Change-Id: I341f9c61e11387fe7192d75e616b4003fa36128f
Reviewed-on: https://chromium-review.googlesource.com/1051307
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557467}
--
wpt-commits: 218c751d92892b7bc271616d6c7c85c731d247a8
wpt-pr: 10943
Automatic update from web-platform-testsMerge pull request #10934 from frivoal/contain-fix-path
[css-contain] Used leveled shortname in references
--
wpt-commits: 17d000078f75e6d9d811b1970718cb235e55a231
wpt-pr: 10934
Automatic update from web-platform-tests[LayoutNG] Avoid false positives for clearance.
Clearance inhibits margin collapsing and thus makes it possible to
resolve the BFC offset of its parent. In that regard we sometimes
incorrectly assumed that a child would get clearance. The only case
where we can tell for sure up front, is when there are adjoining floats
that match the value of the 'clear' property. In all other cases, we
first need to calculate the block-start border edge of the child.
Added a few new tests. Only two of them failed in NG prior to this CL,
but coverage seemed low, so I added them anyway. Two of them fail in the
legacy engine.
Move the code that detects pending child floats a bit further down, to
give HandleInflow() an opportunity to re-layout the child without
aborting container layout. Otherwise clearance on an empty block will
be lost when positioning the float. Added two tests for this
(second-float-inside-empty-cleared-block*), since nothing except a
multicol test (that happened to do complicated clearance stuff)
regressed.
Removed now unused bits from NGExclusionSpace.
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I73b4aa02e5e88d1063f345db271cde1ad31ea9f5
Reviewed-on: https://chromium-review.googlesource.com/1049974
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557282}
--
wpt-commits: 857126e062ef13c28981a9a1a01df4695f74715d
wpt-pr: 10897
Automatic update from web-platform-testsAdd WorkerNavigatorUSB supplement
This change adds a WorkerNavigatorUSB supplement for WorkerNavigator.
The WorkerNavigatorUSB interface contains a usb attribute that returns
a USB object. The constructor for this USB object was also changed to
use an ExecutionContext* parameter to allow a worker to properly
initialize the object.
This change also updates the global interface listing tests to reflect
the new attribute that WorkerNavigator contains and adds web platform
tests to check that the WorkerNavigator does indeed have the usb
attribute defined in the supported contexts.
Due to a bug (https://crbug.com/839117) with the WebIDL bindings
generator, the global-interface-listing-service-worker.html test
exposes the usb attribute of WorkerNavigator. Therefore, a check is
performed in WorkerNavigatorUSB to return a null pointer if the
execution context is a ServiceWorkerGlobalScope. Since the intended
behavior for navigator.usb in a service worker is to be undefined, the
web platform test for this checks that condition instead.
Bug: 837414
Change-Id: I3ca63c9ae0b85e5425134024d2fdd9b29ef7d8c3
Reviewed-on: https://chromium-review.googlesource.com/1024724
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557272}
--
wpt-commits: ede61140b37b59259a3faf48478e7badae90016e
wpt-pr: 10835
Automatic update from web-platform-tests[infra] Correct integration test
By default, "single-page tests" must include an explicit call to the
global `done` function [1]. Insert this invocation to signal completion
and avoid a test timeout when the test's expectation is satisfied.
[1] http://web-platform-tests.org/writing-tests/testharness-api.html
--
[ci] Correct syntax in build script
--
[wptrunner] Allow test failures to be ignored
In a previous commit [1] the WPT CLI was modified to unconditionally
ignore the return value of the `wptrunner.start` method. Although this
behavior is convenient in cases where there is no expectation data, it
obscures errors that are relevant in any context.
Specifically, the `start` method returns a non-zero value when no tests
are run, but this is a reliable indicator of an erroneous configuration.
Because the `wpt run` command is used to validate the infrastructure of
the web-platform-tests project, ignoring this case allows faulty
configurations to go unnoticed [2].
Implement a new CLI option named `--no-fail-on-unexpected` to allow
users to allow test failure while still being alerted to errors that
cause zero tests to be executed. Update the script designed for the
TaskCluster service to enable this option.
[1] 5a1b0365267b540c7f4feac3e0a85e9146997fcd
[2] https://github.com/w3c/web-platform-tests/pull/10721
--
wpt-commits: 28e519569775b44a600ce09bd50320e0d9679db1, 8412dad42a7ca4c963aaa6dba771772dbe8d8c5c, f7a0aa07816a2f5a9af6c569f61a5d877baa3a08
wpt-pr: 10742
Automatic update from web-platform-tests[infra] Validate changes to infra tests in CI
The `infrastructure/` directory contains integration tests for the
project's infrastructure. Ensure that any changes to the files in that
directory are validated by the continuous integration system at the time
they are submitted.
--
[infra] Remove reference to non-existent directory
--
wpt-commits: 0ed30960df05eb1fcf590aa747db0c616b298e61, ef1cdebc46f6a49632a6015bc36b0ca9115b6770
wpt-pr: 10803
Automatic update from web-platform-testsFetch: cleanup api/cors/cors-filtering
I forgot about this one last time around somehow. No .html left in this directory after this one though.
--
wpt-commits: 4f38f7d34855b1cac6de739fa3c32cfdb9a7b7de
wpt-pr: 10932
Automatic update from web-platform-testsSend boundary events rightaway after pointerup
If pointerup implicitly releases the pointer
capture this change sends the boundary events
rightaway after that without waiting for the
next event.
Bug: 834824
Change-Id: I538e0b35d1420574f964666aac394c0bde00f4fb
Reviewed-on: https://chromium-review.googlesource.com/1019347
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Reviewed-by: Ella Ge <eirage@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557184}
--
wpt-commits: 13bef404744b9a16919a5e508c72adfb00b41b04
wpt-pr: 10537
Automatic update from web-platform-testsFix #10875: run parsed lints for visual tests
CSS tests, due to their metadata requirement, default to visual tests,
hence it's important we run all of these lints (to in this case catch
../testharness.js)
--
Extend the previous commit to also check manual tests
Plenty of manual tests use testharness.js so we should check them too,
and indeed there's plenty of broken tests so fix them too
--
wpt-commits: b54c11b055959abeefafcde601853ea4cb247e0b, c327c2747db6b71c8c45f61e0a97785a9be622c2
wpt-pr: 10876
Automatic update from web-platform-testsXHR: reduce try/catch usage
This also improves checking for the correct exception by a bit.
--
wpt-commits: 9b96b146321b9f6cf2391225e3b936e4a68ca5a8
wpt-pr: 10903
Automatic update from web-platform-testsPaymentHandler: Change topLevelOrigin to topOrigin (#10872)
The related spec was changed:
https://github.com/w3c/payment-handler/pull/301
Bug: 840041
Change-Id: Ic76fffe0b974210edc3888378ded197d06e035b7
--
wpt-commits: da28291ff0b1b6ee6a36004e8deef9c2f098935d
wpt-pr: 10872
Automatic update from web-platform-testsPaymentRequest: Apply [Exposed=Window] to the PaymentRequest API (#8641)
There is no behavior change but add a test to check it.
--
wpt-commits: ce44721696b37c0d9c4629435f2d4ca692d8a272
wpt-pr: 8641
Nodes copied from DOMParser document fragment would need to be
created with the proper custom element data.
CustomElementRegistry::IsCustomElementEnabled() is changed to allow
it to run in the test document.
MozReview-Commit-ID: 4GACDR8FIc7
--HG--
extra : rebase_source : 39da41dd1ca56bf62043418c503c526e2895254f
... and before chasing a cname, check if the address record for that
CNAME is actually in fact already provided in the DNS packet that passed
on the CNAME!
Some existing tests ajusted for this. Two new tests added.
MozReview-Commit-ID: CBMO7N7jMEX
--HG--
extra : rebase_source : 1110a8df6d89fcbb0ad2a35b3762b837ce7a1e18
These tests use setTimeout to wait for shape-outside layout to hopefully
complete. This is non-deterministic race condition and leads to intermittent
failures. This change makes those tests instead trigger on the onload event
and removes the setTimeout infrastructure and replaces it with an assert.
Without this change, these tests have no guarantee about whether the rendering
will be complete by the time the test's JS fires.
MozReview-Commit-ID: CHrXUC3yCCT
--HG--
extra : rebase_source : b5642bf24abcbfacb7b94e95d4ca9c8d6486b98b
Until now Marionette assumed that the events `TabClose` and `unload`
indicate that a top-level browsing context or chrome window has been
closed. But both events are fired when the browsing context or chrome
window is about to close. As such a race condition can be seen for
slow running builds.
To clearly wait until the top-level browsing context or chrome window
has been closed, the appropriate message manager needs to be observed
for its destroyed state.
MozReview-Commit-ID: DCdaIiULqey
--HG--
extra : rebase_source : 3f9248ebbdc696ce5e6856ecb167ab144739a52e
Before that we were not notifying the image frame in any way if we ended up not
doing a load, and we were instead relying on the reflow the viewport resize
caused to get the new density in ComputeSize from the content node (but nowhere
else, since that's the bug part 1 fixes).
This was generally unsound, since you can stash random media in a sizes=
attribute, which don't necessarily needs to cause a reflow.
Now we need to notify necessarily because nsImageFrame stores the adjusted
intrinsic size.
mCurrentDensity could also get out of sync as well, when the selected image
density changed, but we ended up returning early because our source hadn't
change in the first early exit.
This patch moves us to a model where we don't re-trigger loads for density
changes if the source doesn't change (unless we pass aAlwaysLoad when we need
to, per spec).
This matches our previous behavior (without the bugginess of not updating the
intrinsic size), and also Chromium, at least.
This changes behavior in one case, which is when we don't load the same source
node, but we have the same source URL, and the density does change. This could
happen with <picture> and two <source>s with same source and different media and
sizes. This makes our behavior consistent with the behavior we have when both
the source and the density doesn't change.
Blink and WebKit do trigger a second image load both when the source changes
without changing density and when density changes. I'll file a spec issue, since
per:
https://html.spec.whatwg.org/#reacting-to-environment-changes
We should be triggering the load when the density changes but the source
doesn't as well, but no UA does that.
I filed https://github.com/whatwg/html/issues/3709 with a little summary of the
situation and what I think the behavior should be (which is what this patch
implements). That being said, I'll update the impl if the spec people think
otherwise :).
MozReview-Commit-ID: Eqy16ygHRLo
Automatic update from web-platform-testsfont-variant descriptor was moved to Fonts 4 (#11035)
* font-variant descriptor was moved to Fonts 4 https://github.com/w3c/csswg-drafts/issues/2531
* font-variant descriptor was moved to Fonts 4
--
wpt-commits: 232137f0fdacdeed99a7df5dd229d23020b0bccc
wpt-pr: 11035
Automatic update from web-platform-testsTest BigInt as keys and values in IndexedDB (#10977)
BigInt and BigInt wrappers are supported in serialization, per
https://github.com/whatwg/html/pull/3480
This support allows them to be used as IndexedDB values.
However, BigInt is not supported as an IndexedDB key; support
has been proposed in the following PR, but that change has not
landed at the time this patch was written
https://github.com/w3c/IndexedDB/pull/231
--
wpt-commits: b2e3e49410657f7bc8adf42070ddef12ce3761d1
wpt-pr: 10977
Automatic update from web-platform-tests[Picture-in-Picture] Add a layout test for detached frame.
This CL adds a test to make sure requesting Picture-in-Picture rejects
when frame is detached.
Bug: 806249
Change-Id: I2f9a029cc03fa8977400f908c87f80ed69674e93
Reviewed-on: https://chromium-review.googlesource.com/1065732
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#560605}
--
wpt-commits: 1895bf86cadabeba81a2280b757f7c0c050dd421
wpt-pr: 11064
Automatic update from web-platform-testsFix crash when setting aliases on computed style.
The incoming CSSPropertyID may be an unresolved property, therefore
CSSUnresolvedProperty::Get must be used rather than CSSProperty::Get.
This bug exists in Chrome stable as well, but it was pretty hard to
discover (by e.g. ClusterFuzz) because aliases were not enumerated until
recently.
R=futhark@chromium.org
Bug: 844816
Change-Id: I97c81764d2027f86004d3b02316cac44412ef0ea
Reviewed-on: https://chromium-review.googlesource.com/1065993
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Anders Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560540}
--
wpt-commits: 94933315da3053196b82bb5d9e7a6a74cb550ce5
wpt-pr: 11100
Automatic update from web-platform-testsCreate WebUSB idlharness test for workers
This change creates an idlharness test for the workers to ensure that
all the interfaces are exposed in the worker. This change also updates
the webusb.idl file to match the exposure of the interfaces.
Bug: 841510
Change-Id: Iad72f242ee0cdbf9a3057828bd4bd5542f6fe063
Reviewed-on: https://chromium-review.googlesource.com/1053063
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560399}
--
wpt-commits: 76c0092916ee8a9171396e62c472d85a0f2623fb
wpt-pr: 11050
Automatic update from web-platform-tests[SessionStorageS13N] Fix key decoding/encoding and site isolation.
Allows namespaces to be bound multiple times for site isolation work,
fixes key encoding & decoding in the renderer, and fixes some tests.
Change-Id: Iac667af7f6edcb4774f9ef49cfc8fd0801060b31
Reviewed-on: https://chromium-review.googlesource.com/1065207
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#560391}
--
wpt-commits: cf00fe1051b58f10f542fe396cc1872d31e37b60
wpt-pr: 11096
Automatic update from web-platform-testsMerge pull request #11086 from w3c/rm-font-feature-settings-rendering-2
Delete font-feature-settings-rendering-2.html with font
--
wpt-commits: bba08e097cb74df656ff55f059757464eb700c91
wpt-pr: 11086
This removes prefs that are already shared between reftest and the 'common' profile from:
testing/profiles/reftest/user.js
And moves prefs that were set in the 'common' profile but not reftest to both:
testing/profiles/unittest/user.js
testing/profiles/perf/user.js
MozReview-Commit-ID: HLfVrd2eD0l
--HG--
extra : rebase_source : ff186d28fa9bb081133bec06ee6689d59e66d41e
This was done in its own commit to make the diffs of the other commits easier
to read and review.
MozReview-Commit-ID: HMAyH8olTaF
--HG--
extra : rebase_source : 5f4b51a04971d12a25d4736ed57ee4c0ffed0832
This moves reftest-preferences.js to:
testing/profiles/reftest/user.js
Developers can also now add extensions to:
testing/profiles/reftest/extensions
MozReview-Commit-ID: IVLsT5MWtcJ
--HG--
rename : layout/tools/reftest/reftest-preferences.js => testing/profiles/reftest/user.js
extra : rebase_source : 1725627d439998d92545e0d4693fbb76a266945f
Usage is:
./profile rm <profile> [<file>]
The file is a list of prefs, one per line, to remove. The file defaults to stdin, so the culmination
of the last three commits is the ability to do:
./profile diff reftest common -f names -k same | ./profile rm reftest
The above command will remove from the reftest profile, the prefs that are identical in both
reftest and common. This method is quicker and less error prone than doing it manually (which
was how I was doing this previously).
MozReview-Commit-ID: Je0JjFXoora
--HG--
extra : rebase_source : 38dae2dcdc3986910cfcd5091f7fc968bf8cc22a
This limits the ./profile diff to a single key (e.g only show keys that are in A but not
B).
MozReview-Commit-ID: ILmbDqgU48o
--HG--
extra : rebase_source : 11fecf18e793ca33e13a7ed9786105e48ae39283
The main purpose of this change is to add some structured formats to the
diff. In future commits, the output of |./profile diff ...| will be used
as inputs to other ./profile commands.
The intent of all this work is to make it easier to programmatically
manipulate the pref files when adding in new suites. For example, I want
to say "Automatically remove all prefs from the reftest profile that are
shared with the common profile".
MozReview-Commit-ID: nf8xOjmd1u
--HG--
extra : rebase_source : 3ef8f55e9222aadefa5565f14ff9a8d671f88467
This lets you compare show or diff multiple profiles joined together. For example:
./profile show common+perf
Or:
./profile diff common+perf unittest
MozReview-Commit-ID: nf8xOjmd1u
--HG--
extra : rebase_source : 73db9638b1b366e4c4580079c547bbb4a12ccfbb
Some notes: this does not fully bring us to compliance to the current spec.
Instead, these are the fixes that I needed to make in order to make
css/geometry/interfaces.html pass with the DOMPoint changes in the previous
patches. I don't fully understand why that patch caused the test to fail the
way it did, but it ended up being easier to fix our code than understand why
the harness was falling over.
The DOMQuad::QuadBounds class was the source of some confusion for me. Now
that DOMRectReadOnly is a concrete class with members, I wanted to avoid
wasting them. However, the spec is unclear as to whether a DOMQuad's bound's
should be live -- that is because DOMQuad exposes DOMPoint, we can set its
points after retrieving a QuadBounds object. Our current code is live, setting
the points changes the QuadBounds. Chromium's current behavior is to never
update the QuadBounds object. I've left our behavior untouched in this patch
(and waste 4 doubles per QuadBounds object), but I am intending to file a bug
to understand what the intent of the spec is. I wonder if the author intended
the points to be DOMPointReadOnly instead. If so, we could simplify the
DOMRectReadOnly code and get rid of the virtual getters, which would be nice.
I also wasn't thrilled to put the DOMMatrix setters on the DOMMatrixReadOnly
class, but for brevity and simplicity of implementation, I've made them
public. I briefly considered making the setters protected on the ReadOnly
version of the class, but I'm not convinced that having to explicitly make
them public on the derived class is worth the extra copies of the names.
MozReview-Commit-ID: CjdW4Nbnc6A
--HG--
extra : rebase_source : 97e9386cfb17319242913d28117c8b1b8b6fbbbe
Marionette uses nsIServerSocket which only allows to create a IPv4
listener. On systems where IPv6 has precedence geckodriver will
automatically use the IPv6 address for `localhost` and will fail
to connect to Marionette. As such we should force geckodriver to
connect to "127.0.0.1".
MozReview-Commit-ID: Dg1n6yYIi2N
--HG--
extra : rebase_source : ed3419a80dbd3101f5d2ee9a469e3e56b189f881
Automatic update from web-platform-testsHandle more html/js polyglots in CORB confirmation sniffing.
Cross-Origin Read Blocking (CORB) tries to protect certain resource
types (e.g. text/html). To be resilient against HTTP responses
mislabeled with an incorrect Content-Type, CORB sniffs the response body
to confirm if it truly is the protected type.
Before this CL the confirmation sniffing logic blocked resources that
are both a valid html and a valid javascript. Blocking of such
resources is undesirable, because it is disruptive to existing websites
that use such polyglot responses in <script> tags.
After this CL, CORB sniffer takes into account the
https://www.ecma-international.org/ecma-262/8.0/index.html#prod-annexB-SingleLineHTMLCloseComment
rule which means that the sniffing doesn't resume immediately after
"-->" characters, but instead also consumes all the characters until the
first line terminator.
Bug: 839945
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I7c8221acc2013adffe8095d188ae22e1c6a2fdab
Reviewed-on: https://chromium-review.googlesource.com/1047851
Commit-Queue: Charlie Reis <creis@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557018}
--
wpt-commits: 8233b0b8f835c970502c2fc6ef61fa51c3d4f6ce
wpt-pr: 10880
Automatic update from web-platform-testsFix resource-timing.https.html test
This CL changes resource-timing-worker.js to use a generated response.
This means Chrome no longer passes the test.
Change-Id: Ib983e4fba9e81ddbee7f9572b6a06b3c1825577a
Reviewed-on: https://chromium-review.googlesource.com/1050383
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556964}
--
wpt-commits: d73901a036e17890987c1593fcaf090d03c3fb66
wpt-pr: 10905
Automatic update from web-platform-testsMove AudioContext tests to WPT
These tests pass on Firefox or fail due to bugs in Firefox.
The remaining tests are somewhat Chrome-specific and aren't moved.
Bug: 745778
Change-Id: Idb1e9ce94339032d7e2866232424c458635db646
Reviewed-on: https://chromium-review.googlesource.com/1042858
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556962}
--
wpt-commits: f9e2b07e0b6f90440d698c8961dff483e34b9ede
wpt-pr: 10852
Automatic update from web-platform-testsMove Analyser tests to WPT
Firefox passes these tests. The remaining tests that weren't moved
all use oac.suspend which Firefox doesn't have (incorrectly), so they
weren't moved.
Bug: 745778
Change-Id: Ic8e758896cfdd2abfccf29b6444c20f13c0be3f2
Reviewed-on: https://chromium-review.googlesource.com/1042853
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556958}
--
wpt-commits: b0edea178f845aefc880cd85b3c74c16ea7e835c
wpt-pr: 10851
Automatic update from web-platform-testsEnable WPT tests for the Generic Sensor classes
This patch introduces mock implementations of the Sensor
and SensorProvider mojo interfaces to the WPT tests
for Chromium.
The ongoing WPT issue for the Generic Sensor tests automation:
https://github.com/w3c/web-platform-tests/issues/9686
Bug: 816462
Change-Id: I8e4880ee5269b07f0bf68a2752038e128d166c55
Reviewed-on: https://chromium-review.googlesource.com/980886
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Alexander Shalamov <alexander.shalamov@intel.com>
Commit-Queue: Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
Cr-Commit-Position: refs/heads/master@{#550586}
--
wpt-commits: b55a93ab1fa441d8998fcfb1173d00dab4b733c0
wpt-pr: 10198
Automatic update from web-platform-testsMerge pull request #10901 from cvazac/cvazac/service-worker
Server-Timing: test PerformanceResourceTiming.idl from Service Worker
--
wpt-commits: 2a099e21421546a037347e0826acd09be9410a87
wpt-pr: 10901
Automatic update from web-platform-testsXHR: sync XMLHttpRequest does not fire an event named progress
For https://github.com/whatwg/xhr/pull/208.
--
wpt-commits: 10f586a6d2f606b86310ba05da18ed13a78c67f4
wpt-pr: 10887
Automatic update from web-platform-testswebrtc wpt: pass test function in more tests
passes the test argument in promise_test and async_test
so it can be used to add cleanup.
followup on
https://chromium-review.googlesource.com/c/chromium/src/+/1047674
using the same codemod but a better, non-regexp way to extract the
script tag content.
BUG=836871
Change-Id: I41905ce25e22121a6e8b53d37af86b073e020b5c
Reviewed-on: https://chromium-review.googlesource.com/1049865
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556795}
--
wpt-commits: 45f9422369ebb560e1705f2c8769bf2ea44ee56e
wpt-pr: 10893
Automatic update from web-platform-testsHTML: <iframe>.contentDocument of a data: URL document is null (#10894)
Fixes#1480.
--
wpt-commits: 0050cfbe145bc9c24981186fa47e714147c1674d
wpt-pr: 10894
Bug reference was accidentally added as commented, and later
automatically removed as part of a WPT import.
MozReview-Commit-ID: HhO0jh2r9Nb
--HG--
extra : rebase_source : d7ccb52ff6ae6723625230ccdf42523b4923f5a3
Bug 1425588 tracks disabled tests for webrender, including a
couple of user prompt tests of the wdspec test suite. The tests
for get_element_property and get_element_tag_name also
intermittently fail, and need to be disabled for now.
MozReview-Commit-ID: AQLxDdqD80p
--HG--
extra : rebase_source : 2d6fd42beb42490f42b1e5de95c060ec15bd07b4
geckodriver should log to which host and port it is trying
to create a connection with Marionette.
MozReview-Commit-ID: DxWSsDDMKCL
--HG--
extra : rebase_source : df870bf956d93aae8d95f70c88c184adc90bf2bf
This patch fixes the addition of baseline tests into self.suites when the suite doesn't exist, and we are iterating over self.suites. Now, we find all baseline tests to run, then add them into self.suites when we are not iterating over self.suites.
MozReview-Commit-ID: GPQeCw1J9P3
--HG--
extra : rebase_source : c6fdfddea15a9e261431f03266784a932318b12f
Following the move to use cargo worktrees in central, the .gitignore
file for mozversion is not used anymore since we no longer generate
testing/mozbase/rust/mozversion/target on building.
MozReview-Commit-ID: 72geBjNxjZl
--HG--
extra : rebase_source : d7f11b33c91407e97416344ca1a2d0f06aa573d3
Mercurial, unlike git, does not pick up .hgignore files in subdirectories.
This file has never been used.
MozReview-Commit-ID: 6HdQJREJkgC
--HG--
extra : rebase_source : 9f69c19aa68b34e32efee6a400653210afe32018
Automatic update from web-platform-testsURL: host setter with default port against URL with non-default port
See https://github.com/nodejs/node/pull/20479.
--
wpt-commits: f0fe4791f5b87491d8d9662832fae543e4edbca1
wpt-pr: 10892
Automatic update from web-platform-testsReadableStreamBytesConsumer should check read results
ReadableStreamBytesConsumer expected that the results from
ReadableStreamReaderDefaultRead should be Promise<Object> because that
is provided from ReadableStream provided by blink, but it's possible to
inject arbitrary values with the promise assimilation.
This CL adds additional checks for such injection.
Bug: 840320
Change-Id: I7b3c6a8bfcf563dd860b133ff0295dd7a5d5fea5
Reviewed-on: https://chromium-review.googlesource.com/1049413
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556751}
--
wpt-commits: fc03b170c13c2377f852b35854682c573067d8d8
wpt-pr: 10886
Automatic update from web-platform-testsAdd support for JS shell tests to the manifest code.
--
wpt-commits: 8b105455a9b1fba8ca4cd7f973c565ca361278f5
wpt-pr: 10769
Automatic update from web-platform-testsHTML: FormData representation of <input type=file> without selection
For https://github.com/whatwg/html/pull/3658.
--
wpt-commits: 11f912ed1d8c8da3cb23f8e77444c4bc03c18e01
wpt-pr: 10865
Automatic update from web-platform-testsWorker: Throw an exception when importScripts() is called on "module" worker
Spec: https://html.spec.whatwg.org/multipage/workers.html#dom-workerglobalscope-importscripts
"1. If worker global scope's type is "module", throw a TypeError exception."
Bug: 831420
Change-Id: I6a1976363435596562689988ed39394a3b735779
Reviewed-on: https://chromium-review.googlesource.com/1038926
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556713}
--
wpt-commits: 42ae4a432d5264eba6c7171c8ecfcb26dc9fa1a8
wpt-pr: 10776
Automatic update from web-platform-testsDOM: non-Text nodes are not touched by normalization
This test makes sure that non-Text nodes are not touched even if they
hold empty text strings. This test was motivated by a bug present in
the jsdom library.
--
wpt-commits: d50825bfd2a2e887c24e63683a03efe5896e2b80
wpt-pr: 10735
Automatic update from web-platform-testswebrtc wpt: pass test in promise_test and async_test
passes the test argument in promise_test and async_test
so it can be used to add cleanup.
Change done with a jscodeshift codemod that detects
there were no arguments to promise_test (or async_test):
export default function transformer(file, api) {
const j = api.jscodeshift;
return j(file.source)
// .find(j.CallExpression)
.find(j.CallExpression, {callee: {type: 'Identifier', name: 'promise_test'}})
.forEach(path => {
if (path.value.arguments[0].params.length === 0) {
path.value.arguments[0].params.push(j.identifier('t'));
}
})
.toSource();
};
BUG=836871
Change-Id: Ie7dd7fb0dd8a4da6c4c00f3616fd41d1d47854ef
Reviewed-on: https://chromium-review.googlesource.com/1047674
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556711}
--
wpt-commits: 9949cb53d1e32bc9c34c687d8b89dc3ecb6d9553
wpt-pr: 10884
Automatic update from web-platform-testsHTML: no longer depend on SVGElement in IDL
See https://github.com/whatwg/html/pull/3671.
--
wpt-commits: fcf42b610c3eec811dc26a09b1404300aeb01ac1
wpt-pr: 10879
Automatic update from web-platform-testsDOM: retarget relatedTarget
relatedTarget gets retargeted. Also use test rather than async_test if possible.
Fixes#10854.
--
wpt-commits: b9f5402f16fa98c88428dace0a7088ef9dae8df3
wpt-pr: 10863
Simon Pieters
moz-wptsync-bot
Finnur Thorarinsson
Chris Harrelson
Stephen McGruer
James Graham
Ian Kilpatrick
Robert Ma
Mike Pennisi
Clayton Martin
Manuel Rego Casasnovas
Kristoffer Erlandsson
Hao, Yunfei
Marcos Cáceres
Hiroki Nakagawa
Robert Sesek
Yoav Weiss
Gurzau Raul
Rob Wu
Kris Maglione
Cosmin Sabou
Chris AtLee
Margareta Eliza Balazs
Michael Kaply
Raymond FOrbes
Ciure Andrei
Olli Pettay
Andreea Pavel
Boris Zbarsky
Mats Palmgren
Emilio Cobos Álvarez
Joel Maher
Andrea Marchesini
Jim Chen
jimevans
Dominic Farolino
Victor Costan
Philip Jägenstedt
youennf
Eric Willigers
Domenic Denicola
Anne van Kesteren
Rune Lillesveen
Jake Archibald
Han Leon
Chris Nardi
Brian Burg
Ella Ge
Florian Rivoal
Ms2ger
Joe Downing
Geoffrey Sneddon
David Grogan
joanmarie
Morten Stenshorne
Ovidio Henriquez
Navid Zolghadr
Shachar Zohar
pyup.io bot
Blink WPT Bot
Dorel Luca
Paolo Amadini
Timothy Guan-tin Chien
Haik Aftandilian
Narcis Beleuzu
Brindusan Cristian
Daniel Stenberg
Brad Werth
Henrik Skupin
Paul Adenot
Johann Hofmann
Xidorn Quan
Chris Lilley
Robin Templeton
Michael[tm] Smith
François Beaufort
Anders Hartvoll Ruud
Daniel Murphy
Philip Jägenstedt
Andrew Halberstadt
Bogdan Tara
Jan-Ivar Bruaroey
Geoff Brown
Blake Kaplan
Jared Wein
shindli
Lukasz Anforowicz
Nicolas Pena
Raymond Toy
Mikhail Pozdnyakov
Adam Rice
Philipp Hancke
Jon Coppeard
Andreas Tolfsen
Kartikaya Gupta
Jonathan Kew
Jan Henning
Marco Bonardo
Gregory Szorc
Csoregi Natalia
Noemi Erli
Andi-Bogdan Postelnicu
AlvaroRe
Gregory Mierzwinski
Maja Frydrychowicz
Aki Sasaki
Ayush Gupta
Yutaka Hirano
Harald Alvestrand
Louis-Dominique Dubeau
David Storey