The patch renames the existing functions (GetBounds(), GetClientBounds(), etc)
by adding an |Untyped| suffix. It then adds typed equivalents, and uses those
typed equivalents in all the call sites where it's easy to do so. The trickier
remaining call sites are converted to use the Untyped-suffix version.
--HG--
extra : rebase_source : 6bfb15bfc4698e2eba7d4db55497299d3dffcd51
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
Warnings fixed include the following.
- Several cases where macros (|LOG| and |ALOGE|) were redefined. I just did a
simple #undef to fix these.
- In GonkMemoryPressureMonitoring.cpp, "the address of NuwaMarkCurrentThread
will never be NULL".
- In OrientationObserver.cpp, several signed/unsigned comparison warnings.
- Several warnings about variables that are unused or set but not used:
in InputDispatcher.cpp, InputReader.cpp.
Also in SpriteController, where several loops were all but empty if
HAVE_ANDROID_OS is undefined; for these I moved the HAVE_ANDROID_OS check
outside the loop.
The patch also disallows the introduction of new warnings by removing the
ALLOW_COMPILER_WARNINGS flag.
--HG--
extra : rebase_source : 6dc19235cf992b929d1308fd98baa03e16701874
Nicholas Nethercote
Nathan Froyd
Fabrice Desré
Masayuki Nakano
Sotaro Ikeda
Juan Gomez
Ryan VanderMeulen
JerryShih
Boris Chiou
Daniel Holbert
Henry Chang
Mason Chang
Viral Wang
Jinho Hwang
Wes Kocher
Doug Sherk
Kartikaya Gupta
Doug Sherk
Anup Kumar
Kershaw Chang
Victor Porof
Birunthan Mohanathas
Star Cheng
John Shih
Eric Rahm