Chris Peterson
2d4ca059e8
Bug 1691889 - Replace MOZ_MUST_USE with [[nodiscard]] in dom/. r=peterv
...
The MOZ_MUST_USE macro is defined as clang's and gcc's nonstandard __attribute__((warn_unused_result)). Now that we compile as C++17 by default (bug 1560664), we can replace MOZ_MUST_USE with C++17's standard [[nodiscard]] attribute.
The [[nodiscard]] attribute must precede a function declaration's declaration specifiers (like static, extern, inline, or virtual). The __attribute__((warn_unused_result)) attribute does not have this order restriction.
Differential Revision: https://phabricator.services.mozilla.com/D107355
2021-03-10 08:19:25 +00:00
Eric Rahm
3d161d547c
Bug 1626446 - Remove nsAutoPtr usage from dom/messagechannel. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D69117
--HG--
extra : moz-landing-system : lando
2020-04-03 21:05:17 +00:00
Andrea Marchesini
f5408828e0
Bug 1610020 - BroadcastChannel + wasm - part 2 - Move SharedMessagePortMessage into dom/ipc, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D60318
--HG--
rename : dom/messagechannel/SharedMessagePortMessage.cpp => dom/ipc/SharedMessageBody.cpp
rename : dom/messagechannel/SharedMessagePortMessage.h => dom/ipc/SharedMessageBody.h
extra : moz-landing-system : lando
2020-01-24 07:59:36 +00:00
Andrea Marchesini
ce553d0097
Bug 1605566 - MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59615
--HG--
extra : moz-landing-system : lando
2020-01-24 07:58:34 +00:00
Andrea Marchesini
94ac5ab147
Bug 1605566 - MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59614
--HG--
extra : moz-landing-system : lando
2020-01-24 07:58:21 +00:00
Narcis Beleuzu
cb54b0227b
Backed out 5 changesets (bug 1605566) for wpt failures on shared.html . CLOSED TREE
...
Backed out changeset 622939cef438 (bug 1605566)
Backed out changeset ab98304e6c84 (bug 1605566)
Backed out changeset 7eab8fd2b62e (bug 1605566)
Backed out changeset 99f61f25ed86 (bug 1605566)
Backed out changeset 77bdf4f86052 (bug 1605566)
2020-01-22 12:58:13 +02:00
Andrea Marchesini
6c0733d2e8
Bug 1605566 - MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59615
--HG--
extra : moz-landing-system : lando
2020-01-22 09:33:29 +00:00
Andrea Marchesini
4da71e81af
Bug 1605566 - MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59614
--HG--
extra : moz-landing-system : lando
2020-01-22 09:33:11 +00:00
Mihai Alexandru Michis
4345a38d0d
Backed out 9 changesets (bug 1607791, bug 1605566) for causing multiple wpt failures.
...
CLOSED TREE
Backed out changeset 39f34852842e (bug 1605566)
Backed out changeset 3427a92445c8 (bug 1605566)
Backed out changeset 36631ec96f1f (bug 1605566)
Backed out changeset 554b2bdce66c (bug 1605566)
Backed out changeset 37026beadbd8 (bug 1605566)
Backed out changeset f15835338319 (bug 1607791)
Backed out changeset 4c92f506cf62 (bug 1607791)
Backed out changeset 80707bcc8427 (bug 1607791)
Backed out changeset 75bc7533c899 (bug 1607791)
2020-01-15 13:45:33 +02:00
Andrea Marchesini
3ad8ed45ed
Bug 1605566 - MessagePort + wasm - part 4 - Implement RefMessageBodyService, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59615
--HG--
extra : moz-landing-system : lando
2020-01-15 10:01:24 +00:00
Andrea Marchesini
a7fa32643f
Bug 1605566 - MessagePort + wasm - part 3 - MessagePort serializes objects using MessageData union, r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D59614
--HG--
extra : moz-landing-system : lando
2020-01-15 10:01:11 +00:00
Karl Tomlinson
49263a8134
Bug 1599952 Introduce UniqueMessagePortId and use it for CloneAndDisentangle() and Create() r=baku
...
Also, StructuredCloneHolder::CustomWriteTransferHandler() no longer appends an
unused element to mPortIdentifiers when MessagePort::CanBeCloned() returns
false.
Differential Revision: https://phabricator.services.mozilla.com/D55213
--HG--
extra : moz-landing-system : lando
2019-12-03 00:37:23 +00:00
Coroiu Cristina
679f321343
Backed out 5 changesets (bug 1599952) for failures at webaudio/the-audio-api/the-audioworklet-interface/audioworklet-messageport.https.html.ini
...
Backed out changeset 78adc22d922a (bug 1599952)
Backed out changeset b07c89cbc212 (bug 1599952)
Backed out changeset 7768d524d914 (bug 1599952)
Backed out changeset 7012927838fe (bug 1599952)
Backed out changeset dbf476d4eab6 (bug 1599952)
2019-12-03 02:33:23 +02:00
Karl Tomlinson
375470f88b
Bug 1599952 Introduce UniqueMessagePortId and use it for CloneAndDisentangle() and Create() r=baku
...
Also, StructuredCloneHolder::CustomWriteTransferHandler() no longer appends an
unused element to mPortIdentifiers when MessagePort::CanBeCloned() returns
false.
Differential Revision: https://phabricator.services.mozilla.com/D55213
--HG--
extra : moz-landing-system : lando
2019-12-03 00:07:33 +00:00
Ehsan Akhgari
e5e885ae31
Bug 1521000 - Part 2: Adjust our clang-format rules to include spaces after the hash for nested preprocessor directives r=sylvestre
...
# ignore-this-changeset
--HG--
extra : amend_source : 7221c8d15a765df71171099468e7c7faa648f37c
extra : histedit_source : a0cce6015636202bff09e35a13f72e03257a7695
2019-01-18 10:16:18 +01:00
Sylvestre Ledru
265e672179
Bug 1511181 - Reformat everything to the Google coding style r=ehsan a=clang-format
...
# ignore-this-changeset
--HG--
extra : amend_source : 4d301d3b0b8711c4692392aa76088ba7fd7d1022
2018-11-30 11:46:48 +01:00
Andrea Marchesini
4817d8d6c8
Bug 1502802 - Implement PostMessageOptions for MessagePort, r=smaug
2018-10-29 16:26:30 +01:00
Andrea Marchesini
d6ce364ced
Bug 1470306 - Adding some MOZ_DIAGNOSTIC_ASSERT in MessagePort, r=smaug
2018-07-13 17:41:34 +02:00
Andi-Bogdan Postelnicu
88cc63910d
Bug 1453795 - DOM - Initialize member fields in classes/ structures. r=peterv
...
--HG--
extra : rebase_source : 249fc26e50bded4e94f5effa4308af0f1e54b908
2018-06-16 17:21:46 +03:00
Andrea Marchesini
9d62f45284
Bug 1467179 - MessagePort should implement DisconnectFromOwner() instead using innerID comparison, r=bkelly
2018-06-13 08:37:26 -07:00
Andrea Marchesini
cb4b451b23
Bug 1441141 - Update the StructuredCloneAlgorithm to follow the latest version of the spec, r=smaug, r=sfink
2018-03-28 09:23:17 +02:00
Andrea Marchesini
3d7e8db1bc
Bug 1441141 - MessagePort cannot be cloned/transferred if disentanged, r=smaug
2018-03-28 09:23:17 +02:00
Andrea Marchesini
d892207595
Bug 1436784 - Use WorkerRef in BroadcastChannel and MessagePort, r=smaug
2018-03-13 21:16:54 +01:00
Andrea Marchesini
063723a1f0
Bug 1432963 - Fixing workers headers - part 13 - WorkerHolder without workers namespace, r=smaug
2018-01-31 08:23:44 +01:00
Andrea Marchesini
1f86f7d2a2
Bug 1411257 - No MOZ_CRASH if BackgroundChild::GetOrCreateForCurrentThread() fails - part 2 - MessagePort, r=asuth
2017-10-25 08:45:52 +02:00
Andrea Marchesini
2d9050c390
Bug 1408333 Get rid of nsIIPCBackgroundChildCreateCallback - part 2 - MessagePort, r=asuth
2017-10-24 12:02:39 +02:00
Andrea Marchesini
ab8673f32d
Bug 1359017 - onmessageerror for MessagePort in case StructuredClone algorithm fails when deserializing, r=masayuki, r=smaug
2017-09-13 05:59:05 +02:00
Sebastian Hengst
643376d693
Backed out changeset a8d6f6fd7bda (bug 1359017) for failing wpt's /html/dom/reflection-forms.html. r=backout
2017-09-13 08:56:53 +02:00
Andrea Marchesini
456461ba4d
Bug 1359017 - onmessageerror for MessagePort in case StructuredClone algorithm fails when deserializing, r=masayuki, r=smaug
2017-09-13 05:59:05 +02:00
Sebastian Hengst
13f018a460
Backed out changeset 78cd991b074f (bug 1359017) for rooting hazards and unexpected passes in wpt's /html/dom/interfaces.html. r=backout on a CLOSED TREE
2017-09-12 14:17:46 +02:00
Andrea Marchesini
df522b457d
Bug 1359017 - onmessageerror for MessagePort in case StructuredClone algorithm fails when deserializing, r=masayuki, r=smaug
2017-09-12 11:57:26 +02:00
Andrea Marchesini
1fd70e0029
Bug 1336020
- transferables should be arrays of objects, r=smaug
2017-02-03 11:00:38 +01:00
Andrea Marchesini
270f257d6b
Bug 1336020
- postMessages should have transferable as [] by default, r=smaug
2017-02-03 11:00:37 +01:00
Andrew Sutherland
16f0e1705b
Bug 1315913 - Part 3: Convert MessageChannel to use StructuredCloneData and ClonedMessageData. r=baku
2016-11-21 04:06:41 -05:00
Andrea Marchesini
aac2306f2c
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
...
--HG--
rename : dom/cache/Feature.cpp => dom/cache/CacheWorkerHolder.cpp
rename : dom/cache/Feature.h => dom/cache/CacheWorkerHolder.h
rename : dom/workers/WorkerFeature.h => dom/workers/WorkerHolder.h
2016-06-23 10:53:14 +02:00
Carsten "Tomcat" Book
47aeb86e2c
Backed out changeset 1c5d78c7ba43 (bug 1269154) for bustage on a CLOSED TREE
...
--HG--
rename : dom/cache/CacheWorkerHolder.cpp => dom/cache/Feature.cpp
rename : dom/cache/CacheWorkerHolder.h => dom/cache/Feature.h
rename : dom/workers/WorkerHolder.h => dom/workers/WorkerFeature.h
extra : rebase_source : 49f9e9ce0500ac441fe97878cf9308804926544f
2016-06-23 10:13:54 +02:00
Andrea Marchesini
45087a7970
Bug 1269154 - Get rid of WorkerFeature: WorkerHolder, r=khuey
...
--HG--
rename : dom/cache/Feature.cpp => dom/cache/CacheWorkerHolder.cpp
rename : dom/cache/Feature.h => dom/cache/CacheWorkerHolder.h
rename : dom/workers/WorkerFeature.h => dom/workers/WorkerHolder.h
2016-06-22 17:24:35 +02:00
Jonathan Watt
b15368cfcb
Bug 1279451 - Remove a lot of unnecessary includes of nsAutoPtr.h. rs=sparky
2016-06-07 21:10:18 +01:00
Andrea Marchesini
9e960ae549
Bug 1250572 - Force a parent object in MessagePort/Channel and in StructuredCloneHolder, r=smaug
2016-03-01 15:21:11 +01:00
Daniel Holbert
a192831f74
backout c42ff6847631 (bug 1250572) for causing aborts during startup
2016-02-24 11:54:35 -08:00
Andrea Marchesini
53c0f726fe
Bug 1250572 - Force a parent object in MessagePort/Channel and in StructuredCloneHolder, r=smaug
2016-02-24 20:04:37 +01:00
Mantaroh Yoshinaga
0d77c71c32
Bug 1174624 - Add the Transferable parameter into SendAsyncMessage of nsFrameMessageManager. r=baku
2016-01-31 22:48:00 +01:00
Andrea Marchesini
6c2f04833f
Bug 1247635 - Unify PostMessageRunnable and DispatchEventRunnable in MessagePort.cpp, r=smaug
2016-02-11 19:42:13 +00:00
Kyle Huey
91efc5a86c
Bug 1241764: Replace nsPIDOMWindow with nsPIDOMWindowInner/Outer. r=mrbkap,smaug
2016-01-30 09:05:36 -08:00
Andrea Marchesini
c29afb56a2
Bug 1224825 - Race condition in MessagePort::close - patch 1, r=smaug
2015-11-17 23:38:01 +00:00
Phil Ringnalda
6e82b3775e
Back out 2 changesets (bug 1221852, bug 1224825) for Android hangs and desktop RunWatchdog crashes in test_upgrade_insecure_reporting.html
...
CLOSED TREE
Backed out changeset 6ad589dcf3c1 (bug 1221852)
Backed out changeset e7aadf89146b (bug 1224825)
2015-11-15 09:56:06 -08:00
Andrea Marchesini
fe475529c5
Bug 1224825 - Race condition in MessagePort::close, r=smaug
2015-11-15 11:46:53 +00:00
Sebastian Hengst
c1f04d5b8c
Backed out 2 changesets (a19876ac309e, 3a1c0923b0d9) (bug 1221852, bug 1224825) for M(3) failures. r=backout on a CLOSED TREE
...
Backed out changeset 3a1c0923b0d9 (bug 1221852)
Backed out changeset a19876ac309e (bug 1224825)
2015-11-15 15:59:24 +01:00
Andrea Marchesini
06fe425d35
Bug 1224825 - Race condition in MessagePort::close, r=smaug
2015-11-15 11:46:53 +00:00
Nathan Froyd
01583602a9
Bug 1207245 - part 6 - rename nsRefPtr<T> to RefPtr<T>; r=ehsan; a=Tomcat
...
The bulk of this commit was generated with a script, executed at the top
level of a typical source code checkout. The only non-machine-generated
part was modifying MFBT's moz.build to reflect the new naming.
CLOSED TREE makes big refactorings like this a piece of cake.
# The main substitution.
find . -name '*.cpp' -o -name '*.cc' -o -name '*.h' -o -name '*.mm' -o -name '*.idl'| \
xargs perl -p -i -e '
s/nsRefPtr\.h/RefPtr\.h/g; # handle includes
s/nsRefPtr ?</RefPtr</g; # handle declarations and variables
'
# Handle a special friend declaration in gfx/layers/AtomicRefCountedWithFinalize.h.
perl -p -i -e 's/::nsRefPtr;/::RefPtr;/' gfx/layers/AtomicRefCountedWithFinalize.h
# Handle nsRefPtr.h itself, a couple places that define constructors
# from nsRefPtr, and code generators specially. We do this here, rather
# than indiscriminantly s/nsRefPtr/RefPtr/, because that would rename
# things like nsRefPtrHashtable.
perl -p -i -e 's/nsRefPtr/RefPtr/g' \
mfbt/nsRefPtr.h \
xpcom/glue/nsCOMPtr.h \
xpcom/base/OwningNonNull.h \
ipc/ipdl/ipdl/lower.py \
ipc/ipdl/ipdl/builtin.py \
dom/bindings/Codegen.py \
python/lldbutils/lldbutils/utils.py
# In our indiscriminate substitution above, we renamed
# nsRefPtrGetterAddRefs, the class behind getter_AddRefs. Fix that up.
find . -name '*.cpp' -o -name '*.h' -o -name '*.idl' | \
xargs perl -p -i -e 's/nsRefPtrGetterAddRefs/RefPtrGetterAddRefs/g'
if [ -d .git ]; then
git mv mfbt/nsRefPtr.h mfbt/RefPtr.h
else
hg mv mfbt/nsRefPtr.h mfbt/RefPtr.h
fi
--HG--
rename : mfbt/nsRefPtr.h => mfbt/RefPtr.h
2015-10-18 01:24:48 -04:00