Automatic update from web-platform-testsIgnore preventDefault() for 'vertical-scroll'
This CL adds the logic to ensure calling event.preventDefault() will
not block vertical scrolling for frames which do not have the feature
policy enabled.
Essentially, the response from dispatching the dom event is overwritten
by "not canceled" and the event is marked as not prevented. In line with
this, and in order to make sure only vertical scroll is enforced, the
allowed touch action is set to 'pan-y'; then any scrolling along the
x-axis can still be blocked by prventDefault()-ing the event.
Bug: 611982
Change-Id: Iba371be063bf064601ecce6e930424c4fb11ac26
Reviewed-on: https://chromium-review.googlesource.com/1053175
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562856}
--
wpt-commits: c2934c9ddd3c9c8e45b987dd75286e2793192306
wpt-pr: 10942
Automatic update from web-platform-tests[Resource-Timing] Fix `initiatorType` values
There were multiple issues with current `initiatorType` implementation:
* `fetch()` resources had an empty value instead of "fetch"
* `<video>` resources had an empty value instead of "video"
* `<audio>` resources had an empty value instead of "audio"
* `<track>` resources had "texttrack" value instead of "track"
* EventSource resources had an empty value instead of "other"
On top of that, the test to make sure the above is all in check had
some values that were not aligned to the spec, and was disabled due to
the flakiness of audio and video loads.
This CL fixes the above values, fixes the test to be more spec
compliant and enables it.
Bug: 649571, 822757
Change-Id: I1dc6fd35e5e4bc570cbbb7d743dc02279bf42b8b
Reviewed-on: https://chromium-review.googlesource.com/1040925
Commit-Queue: Yoav Weiss <yoav@yoav.ws>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562221}
--
wpt-commits: 0d81b471c71053f3b871a47414233c8f06732e78
wpt-pr: 10840
Automatic update from web-platform-tests[Squad] Use UA styling for form inside table elements.
We did not implement UA style as specified for form elements inside
table elements. This CL removes the hardcoded way of not creating layout
objects and instead add display:none to the UA style sheet as specified.
We introduce a new internal pseudo class :-internal-is-html because the
rule should only apply in html documents. This is also what Gecko does
with its :-moz-is-html. The pseudo class is only allowed in UA sheets.
The relationship with Squad is that we get rid of the dependency on
ancestor layout objects in LayoutObjectIsNeeded.
Bug: 847763, 843520
Change-Id: Ibc83b78493843b1a0503fbb65e509090fe295313
Reviewed-on: https://chromium-review.googlesource.com/1078348
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562789}
--
wpt-commits: 2008aa1e26231e627f94c167c2d4498975276198
wpt-pr: 11244
Automatic update from web-platform-tests[css-grid] Disable paint containment for ruby-text elements
Text from the spec
(https://drafts.csswg.org/css-contain/#containment-paint):
"... if the element is an internal ruby element ...
paint containment has no effect."
The patch disables "contain: paint" for ruby-text elements.
We need to modify the reference file for contain-paint-008 test
because of an unrelated issue (see crbug.com/847743).
Other internal ruby elements like ruby-base, ruby-base-container,
and ruby-base-text-container are already inline elements
so they don't need extra checks.
The tests checking those contain-paint-005, contain-paint-006,
and contain-paint-007 do not pass due to a different issue
related to absolute positions and ruby (see crbug.com/847274).
TestExpectations is updated to point to the actual problem.
BUG=843329
TEST=external/wpt/css/css-contain/contain-paint-008.html
Change-Id: I26814598a3b806b67264146386052cbdfff62847
Reviewed-on: https://chromium-review.googlesource.com/1077387
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#562776}
--
wpt-commits: 2812a9c56bf4d38d2ccc09e31765fe8e62d4d743
wpt-pr: 11240
Automatic update from web-platform-tests[LayoutNG] Need to pre-layout legacy orthogonal writing mode roots.
A multicol container disables NG for the entire subtree, so checking the
runtime flag won't do. We need to determine this on an object-to-object
basis and only skip those that are managed by LayoutNG.
Change-Id: I8686511e42300a3028c7f43286cbb4dc7241a7db
Reviewed-on: https://chromium-review.googlesource.com/1073408
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562775}
--
wpt-commits: 4d622d754a3319e726029d7980f3153d7abf8dad
wpt-pr: 11232
Automatic update from web-platform-testsMove input-events IDL to interfaces (#11237)
The input-events IDL was previously directly written in the test. This change moves it to a dedicated file in interfaces.
This change also adds InputEventInit as an untested IDL at the beginning of the test so the test can actually run.
--
wpt-commits: 8ca6c91997a740dc0e070ca9289373951a4d1593
wpt-pr: 11237
Automatic update from web-platform-testsAdd descriptions to scrollIntoView-smooth asserts
Without it you can't tell wether it was the `scrollX` or `scrollY` that failed without modifying the test.
--
wpt-commits: cf261625e2d230ab219eec966f4abe26e3401b64
wpt-pr: 10975
Automatic update from web-platform-testsImprove error message for failed wptserve (#10389)
Bad error messages were highligted by wpt#10388
This change now logs a warning as to the exact command that runs (including
the config file), and the URL that did not load (in case it's a host file or
similar).
--
wpt-commits: e4b0f7a069606efdc0d633a94ae19b71b6dcd748
wpt-pr: 10389
Automatic update from web-platform-testsCSS: ::part invalidation layout tests
Tests for the cases where:
- modify part= on styled element (forwarded and non-forwarded versions)
- modify partmap on outer custom element
- modify another element so that style rule stops match (forwarded and
non-forwarded versions)
Bug: 805271
Change-Id: If8e652436fd053bf76eb6dda99822293cfc55436
Reviewed-on: https://chromium-review.googlesource.com/1071488
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562429}
--
wpt-commits: 274b5082db1caf521b9adb38b2e68dacc20465c8
wpt-pr: 11225
Automatic update from web-platform-testsAllow range headers to pass through a service worker (#10348)
Tests for https://github.com/whatwg/fetch/pull/560
--
wpt-commits: fb6d16d92af29262b6137b79e61f0c4b136c6ac1
wpt-pr: 10348
Automatic update from web-platform-testsMerge pull request #11196 from Loirooriol/css-logical
Simplify the CSS Logical tests and prevent the result log from being rotated
--
wpt-commits: 206f32ac6b61f478c217e52b3dac9328a6884c89
wpt-pr: 11196
Automatic update from web-platform-testsWorker: Clean up tests for module imports on dedicated workers using "export"
This is a clean-up CL for existing tests, and doesn't add new tests.
Before this CL, the tests work as follows: the top-level script imports modules,
each module postMessage('LOADED') to the page on load, and the page waits for
them all. This pattern is easy to write but not easy to read because it's not
clear which modules are expected to be imported. Also, this pattern checks only
the number of imported modules, so a broken test, for example, importing a wrong
module can unexpectedly pass.
To improve the situation, this CL stops using the pattern and instead make tests
propagate the list of imported modules from child scripts to the top-level
script. The top-level script sends the list to the page as a representative.
This is less error-prone and clarifies which modules are expected to be
imported.
Change-Id: I08c4569b6dc69a1ecff6701df932e28dda6dc42a
Bug: 680046
Reviewed-on: https://chromium-review.googlesource.com/1075843
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562380}
--
wpt-commits: dc13e05abcd7ea7a40a813df268e1d229438dd4d
wpt-pr: 11216
Automatic update from web-platform-tests[MSE] Stop firing 'stalled' event.
See Intent to Deprecate
https://groups.google.com/a/chromium.org/d/msg/blink-dev/x54XtrTyOP8/4-5QZlZzDAAJ
MSE's resource is considered 'local' (we don't manage the donwload -
the app does), so the HTML5 spec text around firing 'stalled' does not
apply. See discussion in https://crbug.com/517240
No change to 'stalled' event for 'remote' (src="somefile.webm") resources.
This CL also stops delaying the 'load' event for deferred media player
Load() execution. Load() may be deferred for an arbitrary number of
seconds, so we should not hold up the window's 'load' event. Prior to
this change, 'stalled' was serving the unintended roll of unblocking the
the 'load' event for deferred load()s that took > 3 seconds. With stall
now removed for MSE, this weird behavior was uncovered and remedied.
Bug: 517240, 836951
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I97f2bf972c79582d038e1215f5d630042656bd1c
Reviewed-on: https://chromium-review.googlesource.com/982564
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562371}
--
wpt-commits: bf7e0602947d303a798f09e5b6bbc60b5a4e305d
wpt-pr: 10970
Automatic update from web-platform-testsMerge pull request #11131 from Igalia/webkit_bug_183586
Add a test for connectedCallback
--
wpt-commits: a4d78aa967c23bd610fbad4ea6908aec2ddc858a
wpt-pr: 11131
Automatic update from web-platform-testsFetch: tests for Request's isHistoryNavigation
See whatwg/fetch#718, whatwg/html#3674, and discussion in w3c/ServiceWorker#1167.
--
wpt-commits: 8f805ef0b6a3ddb06c0266cc56557d05e36f3a3d
wpt-pr: 10909
Automatic update from web-platform-tests[Mojo Blob URLs] Handle more navigation cases.
This changes two more IPCs to resolve blob URLs in blink before
sending the request to the browser, hopefully covering all cases.
Still only works with the network service enabled (and that's
probably not going to change), but at least fixes ordering issues
the network service had between resolving and revoking blob URLs.
Design doc: https://docs.google.com/document/d/1DqVcTWE9Qb_3KpIRH2bFV-6hWEr8S92c4ppY67YL1KI/edit#heading=h.n4fzuc6mgziv
Bug: 800901
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iad88fc87264b248d15b03bdad2c24d2c5a46d9df
Reviewed-on: https://chromium-review.googlesource.com/899508
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561670}
--
wpt-commits: 68b2bc73d15159bd98c63807038ed7e6ba011d2f
wpt-pr: 10295
Automatic update from web-platform-testsFix TC: Run gdebi as root
--
fixup! Fix TC: Run gdebi as root
--
wpt-commits: 5b30245516dd7df1d9d98dd6f9c0dd5390e25a8e, f442e740fd7a4201863d56e8cc579e4129280711
wpt-pr: 11199
Automatic update from web-platform-testsMake order of subtests stable in /workers/name-property.html
Fixes#11185.
--
wpt-commits: 30f15165fd105117acf3eb86bf118e5782f2e83d
wpt-pr: 11186
Automatic update from web-platform-testsAdd missing newlines to end of OWNERS files (#11190)
Noticed while trying to concatenate all the files, and fixed by
passing all OWNERS files through git stripspace.
--
wpt-commits: e8c63cf3b9768feaf5d51508940e3a18626e2efa
wpt-pr: 11190
Automatic update from web-platform-testsVibration: remove try/catch usage (#10904)
This is unneeded as testharness.js already takes care of this.
--
wpt-commits: aa846a6e09876ae4378cfcfd2ef13e5da00a47b8
wpt-pr: 10904
Automatic update from web-platform-testsAdd some basic tests for the 'transform-box' property (#7971)
Test for the 'transform-box' 'view-box' value with the viewport being mutated.
--
wpt-commits: 1f89b5e2f33d93631bcc2365124ee7f1f8200e74
wpt-pr: 7971
Automatic update from web-platform-testsOrigin header and 308 redirect
For https://github.com/whatwg/fetch/pull/594.
--
wpt-commits: 89ae808d4ba430f83f8bc185b69108cf10070599
wpt-pr: 11164
Automatic update from web-platform-testsMerge pull request #10274 from fmalita/gradient-color-stops
Add a gradient color-stops parsing test
--
wpt-commits: 7b40de789ad1910e10140bd4dc748b21305e5788
wpt-pr: 10274
Automatic update from web-platform-testsMake deviceorientationabsoluteevent WPT test match spec
The deviceorientationabsoluteevent WPT test currently asserts that the
'absolute' property of the deviceorientationabsolute event is false.
The spec states that:
https://w3c.github.io/deviceorientation/spec-source-orientation.html#deviceorientationabsolute
"The deviceorientationabsolute event is completely analogous to the
deviceorientation event, except additional sensors like the magnetometer can be
used to provide an absolute orientation. The absolute property must be set to
true."
This updates the test to assert that absolute is set to true.
Bug: 774183, 802815
Change-Id: I3694e2b774aa0e4a8a9f7d0328e2aad8b37775e6
Reviewed-on: https://chromium-review.googlesource.com/1062650
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561984}
--
wpt-commits: 3a096dac6f25408dfa53d521f9ffb4dc11b49aaf
wpt-pr: 11038
Automatic update from web-platform-testsUpdate docker image
--
Update taskcluster configuration
--
Add .taskcluster.yml to the script for rebuilding generated code.
This ensures that a CI job fails if it isn't updated when the task definitions change.
--
Add some documentation on updating the docker start script
--
wpt-commits: e601e3a31ef227b967982c1967f4905fa78bd69c, 641499921045f3199305f5741d4407ab61db78eb, 94425f3b8e608786f731a468ce0b8682251660d3, 9ff28376641df0304e9725f0c0025b5962b77996
wpt-pr: 11160
Automatic update from web-platform-testsAdd regression test for https://crbug.com/843523.
Test that document.querySelector(":target") works when called in the
window.load event.
This test is a subset of dom/nodes/Element-matches.html, the difference
is that this test is more lightweight. It causes the window.load event
to be sent earlier. There is a race condition. Currently, it will
only work when FrameLoader::ProcessFragment is called before
Document::ImplicitClose().
Probable fix:
https://chromium-review.googlesource.com/c/chromium/src/+/1057507
Bug: 843523
Change-Id: Ibf7b0d7621b18c3dfefaaa323bbd335d86ce0652
Reviewed-on: https://chromium-review.googlesource.com/1061456
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561916}
--
wpt-commits: f73282e06fe91bd60e188f39887332c63e80a419
wpt-pr: 11030
Automatic update from web-platform-testsFix errors in wpt/css/css-masking/* tests
clip-path-svg-content/clip-path-clip-rule-008.svg:
Add missing reference (reference/clip-path-clip-rule-004-ref.svg).
clip-path-svg-content/clip-path-css-transform-002.svg:
Adjust translation to match reference.
clip-path-svg-content/clip-path-dom-href.svg:
Do setAttribute(...) on the correct <g>.
clip-path/clip-path-element-userSpaceOnUse-002.html:
Shrink the clip-path so that it clips out the border, to match the
reference.
clip-path/clip-path-ellipse-002.html:
clip-path/clip-path-ellipse-003.html:
clip-path/clip-path-ellipse-004.html:
clip-path/clip-path-ellipse-005.html:
Adjust the description text so that it matches the reference.
clip-path/clip-path-ellipse-006.html:
Use a different reference (reference/clip-path-ellipse-ref.html), and
adjust the target <div> such that it matches the reference (replacing
the red border with a margin.)
clip-path/clip-path-ellipse-007.html:
clip-path/clip-path-ellipse-008.html:
Replace red border with a margin.
clip-path/clip-path-polygon-001.html:
clip-path/clip-path-polygon-002.html:
clip-path/clip-path-polygon-003.html:
Adjust the description text so that it matches the reference.
clip-path/clip-path-polygon-004.html:
Fix typo in assertion.
clip-path/clip-path-polygon-005.html:
Adjust the description text so that it matches the reference.
Bug: 626703, 843084
Change-Id: I09c37cbe80ca3b82478bdd994ae027e9a72f280c
Reviewed-on: https://chromium-review.googlesource.com/1071529
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#561880}
--
wpt-commits: f901588ec487b07487f52b15317afd6c4b1fe4ae
wpt-pr: 11142
Automatic update from web-platform-tests[cssom] Add a few more historical tests. (#11163)
Adds tests for getPropertyCSSValue stuff, and also for
https://github.com/w3c/csswg-drafts/issues/2680, while I was here.
--
wpt-commits: 8111e49db7ed5ced2d44e974fcedaba6cd86e4a7
wpt-pr: 11163
Automatic update from web-platform-testsRefresh frameElement.html test.
- Removes unused things like <div id="log"></div>. It probably made
sense at some point, but no more after the semi-automatic conversion
to a WPT test.
- Use more meaningful names.
- Group elements (iframes/embed/objects) by tests.
Bug: 831155
Change-Id: I7bb36132bb3e6be0fc952f4d2d7c1edb847878c1
Reviewed-on: https://chromium-review.googlesource.com/1069089
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561865}
--
wpt-commits: df10c68df5d8c5d4717e28143e749c1f76a9b678
wpt-pr: 11152
Automatic update from web-platform-testsFixed CSP directive value parsing accepted character range
Bug: 845961
Change-Id: Ifc9609058cd7cbd268785db46534e3ed09da6ce3
Reviewed-on: https://chromium-review.googlesource.com/1071510
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561834}
--
wpt-commits: 4fe61b99829d683a9cf0ad1b38f59b9931677531
wpt-pr: 11140
Automatic update from web-platform-tests[css-contain] Disable paint containment in non-atomic inlines
Text from the spec
(https://drafts.csswg.org/css-contain/#containment-paint):
"... if the element's principal box is a non-atomic inline-level box,
paint containment has no effect."
The patch disables "contain: paint" in non-atomic inline-level boxes.
For that a new method LayoutObject::ShouldApplyPaintContainment()
is added, which is used instead of ComputeStyle::ContainsPaint()
all around the code.
It's worth to highlight the change in
ComputedStyle::CanContainFixedPositionObjects() as it doesn't know
if the element is inline or not, it cannot check
if we're in paint containment anymore.
Otherwise it'd make a containing block non-atomic inlines
with "contain: paint", the ones in which we're disabling
paint containment on this patch.
More changes on that new method would be needed to fulfill
the rest of requirements from the spec, as paint containment
shouldn't apply to internal table and ruby elements for example.
Also similar patches for other kind of containment like layout and size
are going to be required.
Regarding tests this patch makes us pass contain-paint-002.html.
On top of that a few extra tests have been added.
BUG=843329
TEST=external/wpt/css/css-contain/contain-paint-011.html
TEST=external/wpt/css/css-contain/contain-paint-012.html
TEST=external/wpt/css/css-contain/contain-paint-013.html
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I140fad061f5cda14e52451aa8f4bc70c9edede3e
Reviewed-on: https://chromium-review.googlesource.com/1071794
Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561832}
--
wpt-commits: 57556a49d4a089f3b9daf8b2348865fba07df7fa
wpt-pr: 11147
Automatic update from web-platform-tests[css-text] Update line-break tests to match i18n test suite (#10860)
* Update line-break tests to match i18n test suite
This commit tests ja and zh line-break behavior with testharness.js.
* Update the paths
* Use "absolute paths"
* Remove U+10AF6 in charlist
* Update the comments (thanks @frivoal)
--
wpt-commits: 52c0a06f671760e73dbbb01b6ede1dfd43f786ad
wpt-pr: 10860
Automatic update from web-platform-testsAvoid using template string in testharness.js
This is to make it work in older browsers.
--
wpt-commits: 7d24703c720f08f472319a7af2ef5bc6dec25346
wpt-pr: 11159
Automatic update from web-platform-testsParameterize domain references
The web-platform-tests server may be configured to run from any host
name. It offers a text substitution feature so that tests can be written
to account for this variability.
Update tests which previously referenced the default host name
(`web-platform.test`) to instead reference a parameterized value.
--
[csp] Parameterize port references
The web-platform-tests server may be configured to run from any TCP/IP
port. It offers a text substitution feature so that tests can be written
to account for this variability.
Update tests which previously referenced a static port number to instead
reference a parameterized value.
--
wpt-commits: ad2e6b7a5a3049bfcdfdd186fb5bf922c3506bf9, ca8f405403de184b168b6bbdbba1d24504f4afd9
wpt-pr: 11011
Automatic update from web-platform-testsCleanup plugin element frames when the layout tree is detached
Unlike frames, plugin elements (<embed> and <object>) are updated
when their layout tree is rebuilt. However, due to an oversight,
<embed> or <object> elements displaying subframes would only have
the associated content view (FrameView) torn down, leaving a
dangling content frame.
This led to some interesting side effects:
- When transitioning from a local frame to a plugin, the content
frame would remain live, with JS still happily running.
- When transitioning from a remote frame to a plugin,
- When navigating a remote frame from one URL to another, the
element would stop updating since the FrameView would be torn
down but a new one would never be created. Note that this was
not (as much of) a problem for local frames, since local frames
re-create the LocalFrameView on every navigation.
With this CL, if a plugin element has an associated content frame,
use that to clean up the state associated with the element when the
layout tree is detached. This can cause the browser context to be
re-created: this matches the behavior of Edge and Firefox.
Note that there is still one edge case where Blink behaves oddly:
if the navigation fails and should display fallback content, the
content frame still remains attached. This will be addressed in
followups.
Link to whatwg issue: https://github.com/whatwg/html/issues/3576
Bug: 776510, 781880
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Id18605fbe602ea6c0076c1d579345cdcf28cc984
Reviewed-on: https://chromium-review.googlesource.com/996314
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561768}
--
wpt-commits: 3391fa43ca730a80b6939476086fafd9ec884ff1
wpt-pr: 10670
Automatic update from web-platform-testsRefactor :focus-visible implementation
- Rename "ShouldShowFocusRingOnMouseFocus" to "MayTriggerVirtualKeyboard"
- Remove UserActionElementSet::WasFocusedByMouse() and replace with Document::LastFocusType()
- Move WillCallDefaultEventHandler() implementation, which checks whether the most recent event was from the keyboard and forces style recalculation if one has occurred, up to Node from HTMLFormControlElement
- Tracks HadKeyboardEvent() on Document as well
- Adds many more tests for the existing :focus-visible behaviour
This lays the groundwork for some future changes:
- Triggering :focus-visible matching on keyboard events when an element is already focused
- Potentially moving the default focus ring drawing logic out of LayoutTheme and delegating to the :focus-visible matching logic instead.
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I5dc0a00c9068dc16bcd36a1c52c706646378ca50
Reviewed-on: https://chromium-review.googlesource.com/1060717
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561746}
--
wpt-commits: 5057b3cee61ca468cd4e8247ea59f5c7d323aa82
wpt-pr: 11114
Automatic update from web-platform-testsFix race condition in frameElement.html.
I am working on https://crbug.com/831155. Some tests that are relying
on how things are scheduled in Blink are failing.
There was a race condition in this test. The iframe "#fr2" was asked to
navigate to a first URL, but soon after, a javascript function
modifies the iframe.src to navigate elsewhere.
What happened when it didn't work?
1) The first navigation starts.
2) The second navigation is scheduled (See blink's NavigationScheduler)
3) The first navigation commits. FrameLoader::CommitProvisionalLoad()
executes: frame_->GetNavigationScheduler().Cancel(). It cancels the
second navigation.
This CL fixes the race condition.
Bug: 831155
Change-Id: I2dd951140b4c5a671c749348ca0247f1901d8b77
Reviewed-on: https://chromium-review.googlesource.com/1069013
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561659}
--
wpt-commits: a89693b62066da0e4808c0bc76c581188398e73d
wpt-pr: 11104
Automatic update from web-platform-tests[css-layout-api] Adds ability to set available sizes on children.
This adds the availableInlineSize, availableBlockSize, to the layout
constriants options dictionary.
This also makes the children "shrink-to-fit" if they are inside a
custom layout pass. Additional logic was needed to *not* "shrink-to-fit"
children during the layout fallback if any occurred, so
LayoutCustomPhaseScope was added to handle this.
The tests that were added test a new BFC with inline children to
see if shrink to fitting works as expected.
Bug: 726125
Change-Id: Ic86d51579b680d871c66040f54e532bc47d79979
Reviewed-on: https://chromium-review.googlesource.com/1069252
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561602}
--
wpt-commits: 127a32efa15d361e0eb4d0db1cbf5a99d26d72d9
wpt-pr: 11107
Automatic update from web-platform-testsFix wpt/css/css-masking/parsing/clip-valid.html subtest
Percentages are not allowed in rect() (arguments are '<length> | auto'.)
Move the old test to clip-invalid.html and replace it with one that
doesn't use percentages.
Bug: 843084
Change-Id: I3cadd99da0d302ac5a0cd012450dd7ade233681c
Reviewed-on: https://chromium-review.googlesource.com/1071469
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561598}
--
wpt-commits: d2db9cd1bfe4a2b5aa5d33d4b11b50d2332ecc9b
wpt-pr: 11141
Automatic update from web-platform-testsRun apt-get update before installing Chrome
There might have been new package releases since the Docker image was
built, and the old packages may no longer exist on the
mirror; therefore, update the package lists before installing Chrome.
--
wpt-commits: a8a5dc635dc73e3ebb10c1162bc3488bfec6ea4d
wpt-pr: 11148
Automatic update from web-platform-testsAdd regression test for ::first-line breaking ::placeholder styles
A bug was reported where ::first-line broke ::placeholder styling, which
seems to have been fixed in https://crrev.com/550589. However, we don't
currently have a test for this bug. Add in a test to make sure we don't
regress with this bug.
Bug: 806247
Change-Id: I5bbcda1ccf5b3ea08a7b66a68071a802f42e9228
Reviewed-on: https://chromium-review.googlesource.com/1071126
Commit-Queue: Chris Nardi <cnardi@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561526}
--
wpt-commits: a381d5590bd6793152ec87c3f195f4bb83550792
wpt-pr: 11136
Automatic update from web-platform-testsSwitch to dedicated wpt taskgroup in taskcluster
--
wpt-commits: 24811101f05b1956a19d465891f3c386c95bf939
wpt-pr: 11071
Automatic update from web-platform-testsAdd a warning about trusting the root CA (#11094)
--
wpt-commits: 5d4f7853b9ae10fe7f4e0321b656ee7afb54aeb3
wpt-pr: 11094
Automatic update from web-platform-testsInline testharness.css into testharness.js for better performance
Loading the stylesheet at the same time as inserting the results
table causes the table to be rendered twice in different layout
modes, which takes a long time for very big tables.
--
wpt-commits: 228b5b229c1ed8b738fc65955d85823a4890aa3d
wpt-pr: 11143
Automatic update from web-platform-testsStop using wpt test-jobs --include.
When the exit code is 1, it is impossible to determine whether that's
because the job should not be run, or because there was an exception.
This ensures we fail on exceptions rather than continuing silently.
--
wpt-commits: a5f0b5c7c29264c73bc034eae09cbedc0161a0e8
wpt-pr: 11139
Automatic update from web-platform-testsTest query encoding of attributes separately
This also changes how we test the ping IDL attribute as the HTML Standard
does not require it to be reflected other than as a string. It also adds
testing for <area>.
Helps with #4934.
--
wpt-commits: e7c35522d8a1e5f3ee180add36ef110bebaf2b6b
wpt-pr: 11129
Automatic update from web-platform-tests[LayoutNG] Rebaseline intrinsic sizing test that actually passes.
Legacy layout is buggy here, so the expected rendering was wrong. Also
wrote a new wpt test for this. When calculating intrinsic size, the
legacy engine makes room for whitespace that is to be collapsed.
Bug: 845902
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I77087577aad68dc249ca33a8ac8a79ef4f35469e
Reviewed-on: https://chromium-review.googlesource.com/1070270
Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561428}
--
wpt-commits: 11638bba9dee05bfdec48264157055a471ff6878
wpt-pr: 11133
Ehsan Karamad
Philip Jägenstedt
moz-wptsync-bot
Yoav Weiss
Rune Lillesveen
Manuel Rego Casasnovas
Morten Stenshorne
Chris Nardi
Stian Didriksen
Luke Bjerring
Fergal Daly
Jake Archibald
Fredrik Söderquist
Hiroki Nakagawa
Anne van Kesteren
Yutaka Hirano
chcunningham
Frédéric Wang
Marijn Kruisselbrink
Harald Alvestrand
Dominic Farolino
Simon Pieters
Geoffrey Sneddon
Fredrik Söderqvist
Emilio Cobos Álvarez
Robbie McElrath
James Graham
arthursonzogni
Andy Paicu
Fuqiao Xue
Mike Pennisi
Alice Boxhall
Ian Kilpatrick
Fernando Serboncini
Chris Nardi
Clay Martin
Lukasz Anforowicz
Chandan Padhi
Ms2ger