d21a5d8004
Bug 792581 - part 23: Replace LL_INIT and LL_UDIVMOD macros. r=ehsan
2012-11-01 20:57:25 -04:00
3f4e29b9f0
Bug 792581 - part 20: Replace LL_UI2L macro with int64_t cast. r=ehsan
2012-10-25 19:25:57 -04:00
8e702f60c5
Backed out 2 changesets (bug 579517)
...
Backed out changeset 5298adc70963
Backed out changeset 86ccf7c918ce (bug 579517)
2012-10-25 12:32:24 -04:00
f3c0ac7a23
Code hygiene: don't use PR_TRUE and PR_FALSE, and use stdint types instead of PRInt types (no bug really, but you could say bug 579517)
2012-10-25 11:48:19 -04:00
9a21ea4912
Bug 794510: Part 6 - Fixups needed to build on Windows and Android and Mac OS X debug, plus shorten comment to be less than 80 columns; r=ehsan
2012-10-18 15:55:48 -04:00
c984edf823
Bug 794510: Part 2: Use more stdint types instead of protypes.h types; r=ehsan
2012-10-11 18:38:04 -05:00
00edc52f9c
Bug 792581 - part 19: Replace LL_I2L macro with int64_t cast. r=ehsan
2012-10-12 13:29:11 -04:00
da3cde276e
Bug 792581 - part 17: Replace LL_L2F macro with a double cast. r=ehsan
2012-10-12 13:29:11 -04:00
3ca8d029a6
Bug 792581 - part 16: Replace LL_L2UI macro with uint32_t cast. r=ehsan
2012-10-12 13:29:11 -04:00
ea5e17dc9c
Bug 792581 - part 15: Replace LL_L2I macro with int32_t cast. r=ehsan
2012-10-12 13:29:10 -04:00
58aa97ec8b
Bug 792581 - part 12: Replace LL_DIV with division operator. r=ehsan
2012-10-05 01:05:28 -04:00
d371ac7c39
Bug 792581 - part 11: Replace LL_MUL macro with multiplication operator. r=ehsan
2012-10-05 01:05:28 -04:00
6a3e28f73b
Bug 792581 - part 10: Replace LL_SUB macro with mathematical minus operator. r=ehsan
2012-10-05 01:05:27 -04:00
ceaa3c8f60
Bug 792581 - part 9: Replace LL_ADD with mathematical plus operator. r=ehsan
2012-10-05 01:05:27 -04:00
ee41e61a85
Bug 792581 - part 6: Replace LL_UCMP macro with standard comparison. r=ehsan
2012-10-03 10:13:19 -04:00
fe71f25457
Bug 792581 - part 3: Replace LL_NE macro with standard relation. r=ehsan
2012-10-03 10:13:18 -04:00
00ccc3bc2e
Bug 795507: Remove usage of PR_BEGIN_EXTERN_C and PR_END_EXTERN_C; r=ehsan
2012-09-30 21:10:22 -05:00
6025716d17
Bug 785321 - Replace PRUptrdiff with uintptr_t, prtdiff_t or etc; r=ehsan,jrmuizel
2012-09-14 16:09:52 -04:00
e368dc9c85
Bug 579517 - Part 1: Automated conversion of NSPR numeric types to stdint types in Gecko; r=bsmedberg
...
This patch was generated by a script. Here's the source of the script for
future reference:
function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
! -wholename "*security/nss*" \
! -wholename "*/.hg*" \
! -wholename "obj-ff-dbg*" \
! -name nsXPCOMCID.h \
! -name prtypes.h \
-type f \
\( -iname "*.cpp" \
-o -iname "*.h" \
-o -iname "*.c" \
-o -iname "*.cc" \
-o -iname "*.idl" \
-o -iname "*.ipdl" \
-o -iname "*.ipdlh" \
-o -iname "*.mm" \) | \
xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}
convert PRInt8 int8_t
convert PRUint8 uint8_t
convert PRInt16 int16_t
convert PRUint16 uint16_t
convert PRInt32 int32_t
convert PRUint32 uint32_t
convert PRInt64 int64_t
convert PRUint64 uint64_t
convert PRIntn int
convert PRUintn unsigned
convert PRSize size_t
convert PROffset32 int32_t
convert PROffset64 int64_t
convert PRPtrdiff ptrdiff_t
convert PRFloat64 double
2012-08-22 11:56:38 -04:00
9c483afff4
Bug 780272 - Audit calls to MozillaUnRegisterDebugFD. r=jlebar.
...
--HG--
extra : rebase_source : 53672602bfd370626916bcd0f5bc71859f8520c2
2012-08-10 12:40:21 -04:00
75ab7efb95
Bug 780387 - Part b: Stop using PRIntn; r=bsmedberg
2012-08-09 09:09:40 +02:00
70d7c821af
Bug 774032 bonus - Use @DEPTH@ and @relativesrcdir@ in Makefile.in. r=ted
2012-08-04 20:26:44 +02:00
d0ad5a7d0c
Bug 777292 part 2 - Change all nsnull to nullptr
2012-07-30 17:20:58 +03:00
325b77e999
Bug 766579 - Part 1: Add SP param to NS_StackWalk. r=dbaron
...
--HG--
extra : rebase_source : dd4905ffadf5fe9327449fffdfbc665b05d74a6a
2012-06-27 16:08:21 -04:00
bc46f77176
Bug 732173 - poison write during shutdown in a debug build. r=ted.
...
With this patch we now patch the write functions during shutdown in a debug
build and abort if a non white listed write is found.
2012-07-03 09:15:34 -04:00
cb3e90214d
Bug 761912 - add VS11 debug dll to trace malloc. r=dbaron
2012-06-06 14:45:45 +09:00
82ff7027aa
Bug 716478 - update licence to MPL 2.
2012-05-21 12:12:37 +01:00
fe881f4ebe
Bug 748001 - Use explicit targets for object files. r=ted
2012-05-15 07:44:32 +02:00
38fd6d3529
Bug 744444 - Part 3: delete CPP_PROG_LINK; r=ted
2012-04-12 16:58:11 -04:00
965cd4527e
Bug 712552. (Av1) Remove MSVC6 support from trace-malloc. r=dbaron.
...
DONTBUILD (comment-only).
2012-03-23 02:58:24 +01:00
69fb6f1047
Bug 731789 - Rename mfbt/StdInt.h to mfbt/StandardInteger.h, so stdint types work from cpp files inside mfbt. r=waldo
2012-02-29 22:56:43 -05:00
a6373ebfc3
Bug 713278 - Teach NS_StackWalk to walk the stack of other threads too on Windows; r=dbaron
2011-12-23 18:14:09 -05:00
d606eeadd6
Bug 711799 - Fix a few implicit-declaration warnings in trace-malloc. r=dbaron
...
--HG--
extra : rebase_source : 16fe9eb68d2db1488d89af4001e7d316cb110330
2011-12-17 22:56:55 -05:00
347ae519fe
Back out bcf9ce858829 and a3bade82ac92 (bug 711799) for build failures
2011-12-19 10:43:08 -08:00
bdbd9b00ac
Bug 711799 - Fix a few implicit-declaration warnings in trace-malloc. r=dbaron
...
--HG--
extra : rebase_source : 67dc7295b8a2022e02f892f7eac74414e61b1c86
2011-12-17 22:56:55 -05:00
16db021217
Bug 711799 - Fix a bunch of unused-variable warnings. r=dholbert
...
--HG--
extra : rebase_source : 91fc77dca316018652d4d99f6d4cc8d0f7195e6e
2011-12-18 01:00:42 -05:00
735580ff0e
Bug 708735 - Use <stdint.h> types in JSAPI and throughout SpiderMonkey. Continue to provide the {u,}int{8,16,32,64} and JS{Uint,Int}{8,16,32,64} integer types through a single header, however, for a simpler backout strategy -- and also to ease the transition for embedders. r=timeless on switching the jsd API to use the <stdint.h> types, r=luke, r=dmandelin
2011-12-08 22:54:10 -05:00
001dce7e90
Bug 696376 - Change how we find critical ranges so that it works on 10.6 too. r=dbaron.
...
Currently we use dlsym on pthread_cond_wait$UNIX2003 to find a
function that indicates that new_sem_from_pool is on the stack. This
works on 10.5, but on 10.6 I could not find a single reliable
indicator that would work with dlsym.
The good news is that dladdr works with any symbol, not just exported
ones. To find the address of new_sem_from_pool, we set up a malloc logger
and force a call to new_sem_from_pool. From the logger callback we walk
the stack trying dladdr on every address.
To force a call to new_sem_from_pool, the initialization code has to be the
first to use semaphores, so it is now run from NS_LogInit.
This works on 10.6 and 10.5 (but we have to look for
"pthread_cond_wait$UNIX2003"). In 10.7 the call to malloc is gone, so we don't
have to worry about critical addresses on it anymore.
--HG--
extra : rebase_source : bba4ac9e3378c88f7037aa884511e473a57121f6
2011-12-02 19:26:04 -05:00
b6c8db3dc8
Backout bug 696376
...
This broke building on android due to requiring a newer version of unwind.h.
2011-12-02 18:00:58 +00:00
083918d344
Bug 696376 - Change how we find critical ranges so that it works on 10.6 too. r=dbaron.
...
Currently we use dlsym on pthread_cond_wait$UNIX2003 to find a
function that indicates that new_sem_from_pool is on the stack. This
works on 10.5, but on 10.6 I could not find a single reliable
indicator that would work with dlsym.
The good news is that dladdr works with any symbol, not just exported
ones. To find the address of new_sem_from_pool, we set up a malloc logger
and force a call to new_sem_from_pool. From the logger callback we walk
the stack trying dladdr on every address.
To for a call to new_sem_from_pool, the initialization code has to be the
first to use semaphores, so it is now run from NS_LogInit.
This works on 10.6 and 10.5 (but we have to look for
"pthread_cond_wait$UNIX2003"). In 10.7 the call to malloc is gone, so we don't
have to worry about critical addresses on it anymore.
2011-12-01 18:22:00 -05:00
9972f0d574
Bug 696376 - If stacks_enabled is false, only walk the stack on OS X 32 bits. r=
...
dbaron.
The 64 bit stack walks lack the InCriticalRange functionality and it looks like
the extra walks are causing an orange on leaktest on the bot.
--HG--
extra : rebase_source : 4c0a75892e30a6e522ed981a1ff12df99d2a0464
2011-11-04 09:49:48 -04:00
1a88fa5343
Bug 696281 - disable trace malloc stacks on OS X too. r=dbaron.
...
This patch disables trace malloc stacks on OS X too. To make this work,
we still have to look on the stack to decide if we must set immediate_abort,
but we can avoid other work like decoding the addresses.
2011-10-28 18:43:49 -04:00
92064e6d3f
Bug 690892 - Replace PR_TRUE/PR_FALSE with true/false on mozilla-central; rs=dbaron
...
Landing on a CLOSED TREE
2011-10-17 10:59:28 -04:00
d2b70213ac
Bug 675553 - Switch from PRBool to bool on a CLOSED TREE , r=bsmedberg,khuey,bz,cjones
...
--HG--
rename : tools/trace-malloc/bloatblame.c => tools/trace-malloc/bloatblame.cpp
2011-09-28 23:19:26 -07:00
f6e7ea13ac
Bug 675485 - Fix PRBool misuses found in a debug build, r=bz,taras
2011-08-01 18:20:52 -07:00
b7ab8c2806
Bug 658995 part 2 - Use static destructors instead of atexit(). r=bsmedberg
2011-06-15 07:32:03 +02:00
e3a9a86a79
Back out 6b23b52e68d6 - e92f98e8a335 (bug 632404, 552864, 658995) because of Tp4 regression.
2011-06-15 09:00:28 -07:00
228b060c2b
Bug 658995 part 2 - Use static destructors instead of atexit(). r=bsmedberg
2011-06-15 07:32:03 +02:00
8aaddd0334
Bug 659621 - Remove EXTRA_DSO_LIBS, EXTRA_DSO_LDOPTS, OS_LIBS from makefiles containing LIBXUL_LIBRARY = 1, now that libxul is always built; r=ted
2011-06-12 03:49:00 -04:00
6eb93f7dd3
Bug 648911 - Remove support for non-libxul builds. r=ted,joedrew
2011-05-23 18:54:47 +02:00
db741ac71c
Make leaksoup not print static ctor/dtor warnings.
2011-04-22 18:36:23 -07:00
c510bc3046
Bug 266236 part 3: Mechanical rename of nsIRenderingContext and nsThebesRenderingContext to nsRenderingContext. Mechanical substitution of nsRefPtr<nsRenderingContext> for nsCOMPtr<nsRenderingContext>.
...
--HG--
rename : gfx/src/nsThebesRenderingContext.cpp => gfx/src/nsRenderingContext.cpp
extra : rebase_source : 34884bfcafd885feaf73300bc7246cd192062a48
2011-04-07 18:04:40 -07:00
2e34091c98
Bug 602245 - Don't build SIMPLE_PROGRAMS during MOZ_PROFILE_GENERATE pass. r=ted
2011-04-14 11:23:13 +02:00
2c92e3ecd5
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 23:29:02 -05:00
699024f868
Backed out changeset 4beec31b9ea9 for increasing frequency of intermittent orange bug 618052
2011-03-31 18:57:38 -05:00
0ce53bb598
Rollup of bug 645263 and bug 646259: Switch to mozilla:: sync primitives. r=cjones,dbaron,doublec,ehsan src=bsmedberg
...
Bug 645263, part 0: Count sync primitive ctor/dtors. r=dbaron
Bug 645263, part 1: Migrate content/media to mozilla:: sync primitives. r=doublec
Bug 645263, part 2: Migrate modules/plugin to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 3: Migrate nsComponentManagerImpl to mozilla:: sync primitives. sr=bsmedberg
Bug 645263, part 4: Migrate everything else to mozilla:: sync primitives. r=dbaron
Bug 645263, part 5: Remove nsAutoLock.*. sr=bsmedberg
Bug 645263, part 6: Make editor test be nicer to deadlock detector. r=ehsan
Bug 645263, part 7: Disable tracemalloc backtraces for xpcshell tests. r=dbaron
Bug 646259: Fix nsCacheService to use a CondVar for notifying. r=cjones
2011-03-31 14:51:19 -05:00
66ddae3bca
Initialize the out param from backtrace(). (Bug 549561) r=bsmedberg a2.0=tests
2010-09-21 19:32:48 -07:00
33464076d6
Bug 591727 - Remove remnant makefile.win in trace-malloc, r=dbaron, a=NPOTB
...
--HG--
extra : rebase_source : 1643431d84ab0e255315b261a1f0bcd86dbfaa42
2010-08-29 18:21:12 -07:00
0104f063dc
Add environment variable NS_TRACE_MALLOC_DISABLE_STACKS for disabling the stack-walking part of trace-malloc to improve performance of tinderbox test machines. (Bug 549561) r=bsmedberg a2.0=tests
2010-08-19 09:37:59 -04:00
4af0a6f409
Avoid a lock/unlock pair for each call to |calltree|. (Bug 549561) r=bsmedberg a2.0=tests
2010-08-19 09:37:59 -04:00
8740898d9f
Bug 586944. Make 'backtrace' static to fix issues with the symbol being overriden by system libraries. r=dbaron,a=bsmedberg
2010-08-19 21:35:08 +12:00
af2f5746b5
Bug 574311 - Build failure with trace malloc when using GCC visibility pragma. r=doug.turner
...
--HG--
extra : rebase_source : 37f6f66319327197e01fc7cac8126a672c873935
2010-07-17 09:52:30 +03:00
29445edb09
Make trace-malloc work again on Linux following mozalloc landing. (Bug 576776) r=cjones
2010-07-16 22:36:34 -07:00
efe3af4f0b
Bug 578565: Remove nsIXBLDocumentInfo. r=jst
...
--HG--
extra : rebase_source : 4d36ecc23ea302563a7b7f84846d8d5e23b29647
2010-07-14 18:53:11 -07:00
ab19d256ae
Remove dead code in intl. Bug 559489, r=smontagu
2010-07-04 15:42:04 +03:00
2f05a6575f
Bug 568467 - trace-malloc support for Windows x64. r=dbaron
2010-06-04 16:53:02 +09:00
318bb339f4
Output the unknown value as a number not a character. b=474800 r=dbaron
2010-04-27 18:15:02 +02:00
ef614431d7
Bug 560969: Teach trace-malloc about VC10. r=dbaron
2010-04-27 00:43:04 -05:00
f317634122
Make trace-malloc malloc hooks work with 64-bit Mac OS X by adjusting types. (Bug 558097, maybe)
2010-04-08 17:21:03 -07:00
a8c5a07cbb
Bug 551254: Allow reviewed+approved STL headers to be included through <foo>. (<algorithm> and <vector> are provisionally in the list because of their use in libpr0n, but need to be reviewed in followup bug 556700 and bug 556701). r=ehsan,ted,zwol
2010-04-02 12:58:11 -05:00
ca65e30e9c
Bug 494117: Mechanically change 'ReParent' to 'Reparent' throughout the tree. r=bzbarsky
2010-04-01 23:07:43 -07:00
082e12c87c
Bug 517553: Remove '=='/'!=' 'PR_FALSE'/'PR_TRUE'
2010-02-07 10:52:43 -05:00
4cc7c33107
Bug 529134: Initialize tracemalloc in NS_LogInit() to ensure that tracemalloc is always thread safe. r=bsmedberg r=dbaron
2009-12-29 16:45:59 -06:00
6fce97e58d
Bug 495228 - Remove checks for mac MOZ_WIDGET_TOOLKIT, r=ted
2009-09-18 19:59:53 -07:00
ba372f3a4c
Followup to bug 398573 - remove REQUIRES from the tree since it is no longer used... automatically generated patch, rs=ted
2009-08-25 08:59:31 -07:00
2aa59235f2
Bug 753 - Remove nsIImage, gfxIImageFrame, and their implementations, and expose an equivalent api on imgIContainer. r=roc,josh,bz,longsonr,vlad,karlt,jimm,bsmedberg,mfinkle,peterw,peterv sr=vlad,roc
...
--HG--
rename : gfx/src/shared/gfxImageFrame.cpp => modules/libpr0n/src/imgFrame.cpp
rename : gfx/src/shared/gfxImageFrame.h => modules/libpr0n/src/imgFrame.h
2009-07-20 18:50:15 -07:00
f210f9be3d
Don't rely on NS_TraceMallocStartupArgs to initialize TLS index. (Bug 442192) r=brendan
2009-03-11 07:51:30 -07:00
2f25e4d199
Bustage fix for bug 478195.
2009-02-17 21:51:50 -08:00
2d11f79424
Bug 478195 - '[Mac] Same-thread deadlock with trace-malloc (causing random red on OS X 10.5.2 mozilla-central leak test build)'. r=dbaron.
2009-02-17 21:11:29 -08:00
4301671b45
Bug 473236 - Remove executable bit from files that don't need it. (Only changes file mode -- no code changes.) r=bsmedberg
2009-01-21 22:55:08 -08:00
424883d380
Bug 466622. Replace nsCStringArray with nsTArray<nsCString> for more consistent code and fewer heap allocations. r+sr=roc,r=bsmedberg
...
--HG--
extra : rebase_source : b963bf5de9d9c445b14620479691482512e0faf2
2009-01-22 17:15:34 +13:00
254745952a
Bug 471087. Kill nsIDKey. r=bsmedberg
...
--HG--
extra : rebase_source : 9d60a541863c545101417cf00a11cb9ceda70a09
2009-01-08 21:43:07 +13:00
c72ef7d248
Bug 456388 - Remove PR_STATIC_CALLBACK and PR_CALLBACK(_DECL) from the tree; r+sr=brendan
2008-10-10 17:04:34 +02:00
5492039225
Bug 458167 - (comments-only changes) Grammar Nazi Vol1: s/it's/its/ for the posessive version of the word, and a few other misc comment-typos, in these directories: accessible browser config profile rdf toolkit tools xpcom xpfe
2008-10-01 23:49:45 -07:00
fee386e2e0
Bug 435122 - "Use TraceMalloc to get stack traces of potential deadlocks". r=bsmedberg+dbaron.
2008-06-26 10:12:42 -07:00
ce9b5c3e85
Fix broken --shutdown-leaks argument handling on Windows by copying the argument out of argv rather than holding a pointer to it. b=433708 r=pavlov
2008-05-14 11:57:32 -07:00
d6f835e602
Allow diffbloatdump to read its own input back in (so that we can run fix-*-stack over its output (which is much faster than running it over a whole log) and still diff that output against different output. Not part of the build.
2008-05-05 21:47:23 -07:00
db479f0ae5
Expose trace-malloc stack tracing. b=422847 r=brendan a=NPOTDB
2008-03-14 17:11:37 -07:00
0b4a15ddfa
And actually get the right bug number. b=415426 (which is what the previous checkin was for as well)
2008-02-03 11:59:07 -08:00
d05c9ec0d8
Switch back to evil casts, which are the only solution that works across SDK version. b=415252
2008-02-03 11:51:14 -08:00
775c2226ec
Match new (more-const) signature for PENUMLOADED_MODULES_CALLBACK and PENUMLOADED_MODULES_CALLBACK64. b=415426 Fixing bustage on Windows tinderbox from SDK upgrade.
2008-02-03 11:34:31 -08:00
b49904959e
Fix race saving/restoring malloc hooks by going back to overriding malloc, etc., plus some additional cleanup. b=392009 r+a1.9=brendan
2007-09-28 15:39:59 -07:00
0926363321
Address brendan's review comments on bug 391141. r=brendan a=not part of release builds
2007-09-27 09:27:12 -07:00
70983c436d
Suppress tracing around calls into original allocators, in case they recur back into our hooks. Fixes most of leak *stats* regression from bug 392009. r+a1.9=brendan
2007-09-25 13:33:37 -07:00
83b6101d31
Reduce code duplication among platforms, support hooking and unhooking (392009, r=dbaron).
2007-09-24 18:13:17 -07:00
4d15a32026
Bug 348748 - Remove cast macros from trace-malloc. r=bsmedberg on the script, a=NPOTDB+no-functionality-change
2007-09-05 15:14:17 -07:00
ce5cbcd62f
Link readers against libxul when trace-malloc is part of libxul (fixing tinderbox bustage).
2007-08-19 18:30:04 -07:00
84c375636f
Revert previous checkin.
2007-08-19 17:59:57 -07:00
5e0e5baefe
Attempt to fix trace-malloc bustage in libxul builds by removing LIBXUL_LIBRARY=1 (fixing tinderbox bustage for newly-enabled test).
2007-08-19 17:50:01 -07:00
d9acf0063d
Force linking with the C++ compiler rather than the C compiler (since we're using SIMPLECPPSRCS rather than CPPSRCS). b=392118 r=bsmedberg a=bzbarsky
2007-08-19 17:00:40 -07:00
Andrew Quartey
Ehsan Akhgari
Brian Smith
Isaac Aggrey
Makoto Kato
Rafael Ávila de Espíndola
Ms2ger
Mike Hommey
Aryeh Gregor
Benoit Girard
Gervase Markham
Nathan Froyd
Serge Gautherie
Justin Lebar
Jeff Walden
Matt Brubeck
Chris Lord
Michael Wu
Ed Morley
Matheus Kerschbaum
L. David Baron
Jan Küchler
Chris Jones ext:(%20and%20Kyle%20Huey%20%3Ckhuey%40kylehuey.com%3E)
Phil Ringnalda
Pirkka Kärenlampi
James Cook
Kyle Huey
Ehren Metcalfe
Mats Palmgren
Zack Weinberg
Jae-Seong Lee-Russo
Benjamin Smedberg
Joe Drew
Ben Turner
Robert O'Callahan
Daniel Holbert
Fred Jendrzejewski
Taras Glek
Arpad Borsos
brendan@mozilla.org