Our `INSTEAD OF INSERT` trigger for local tags reused existing tag
folders if they already existed, but not existing tag entries. This
caused us to insert duplicate tag entries for items whose tags
didn't change, which, in turn, threw unique constraint violations
when we tried to insert rows for tag entries that already existed
into `itemsAdded`. This commit gives tag entries the same treatment as
tag folders.
This commit also improves debug logging during application, so we
can pinpoint errors like this better in the future.
Differential Revision: https://phabricator.services.mozilla.com/D44769
--HG--
extra : moz-landing-system : lando
`WindowsErrorResult` is a class to hold either a value or a Windows error
code based on the `Result` template. We also have `LauncherResult` for the
same purpose, which was introduced as a part of the launcher process feature
afterward. The difference is `LauncherResult` holds a filename and line
number along with an error code.
This patch integrates LauncherResult.h into WinHeaderOnlyUtils.h so that we
can use `LauncherResult` more broadly.
Differential Revision: https://phabricator.services.mozilla.com/D44512
--HG--
extra : moz-landing-system : lando
This define is unused, modulo some apparently dead patches in the
gfx/skia/patches/archive/ directory.
Differential Revision: https://phabricator.services.mozilla.com/D45086
--HG--
extra : moz-landing-system : lando
Add trackingClassification to the details object for proxy.onRequest.
Differential Revision: https://phabricator.services.mozilla.com/D36803
--HG--
rename : toolkit/components/extensions/test/mochitest/test_ext_webrequest_urlClassification.html => toolkit/components/extensions/test/mochitest/test_ext_request_urlClassification.html
extra : moz-landing-system : lando
The repo has seen three notable changes since last time:
- The pdb changes from PR #2, which don't really affect any outward behavior.
- I updated the version of wasm-bindgen.
- I created a WasmMemBuffer abstraction which lets us avoid the buffer copy
without relying on wasm-bindgen implementation details. This is possible due
to the new Uint8Array::view API that wasm-bindgen shipped in April.
The last part is what allowed me to simplify the code in ProfilerGetSymbols-worker.js.
Those changes are the only part that's worth reviewing.
The changes in profiler_get_symbols.js are not worth reviewing; they're
autogenerated by wasm-bindgen. The new version of wasm-bindgen generates
slightly different JS code, and the addition of the WasmMemBuffer struct also
caused some of that JS code to change.
Differential Revision: https://phabricator.services.mozilla.com/D37130
--HG--
extra : moz-landing-system : lando
As of this bug, flex items in a vertical flex container will sometimes be
considered to have "indefinite" sizes, i.e. percent sizes in them will no
longer resolve. To work around this, they need to provide a definite flex-basis
(e.g. as part of the "flex" shorthand property) if we want percent sizes to
resolve (instead of being treated as "auto") inside of them.
Differential Revision: https://phabricator.services.mozilla.com/D44734
--HG--
extra : moz-landing-system : lando
A `popupnotification` could be reused, we should remove/reset optional attributes to avoid unexpected behavior.
Differential Revision: https://phabricator.services.mozilla.com/D44686
--HG--
extra : moz-landing-system : lando
In bug 1568320, we made it so that the PictureInPictureToggleChild attaches handlers to
the toggle, even on videos that have controls by default, so we don't need the
videocontrols UAWidget to call the method for firing the event anymore.
Differential Revision: https://phabricator.services.mozilla.com/D44270
--HG--
extra : moz-landing-system : lando
Remove test manifest annotations that specifically target fennec,
or likely target the android 4.3 emulator.
Differential Revision: https://phabricator.services.mozilla.com/D45018
--HG--
extra : moz-landing-system : lando
Cameron McCormack
Lina Cambridge
Bogdan Tara
Toshihito Kikuchi
Csoregi Natalia
Will Hawkins
Brindusan Cristian
Nathan Froyd
David Walsh
Gurzau Raul
Jonathan Kingston
Abdoulaye O. Ly
Nils Maier
Shane Caraveo
Luke Crouch
Markus Stange
prathiksha
Daniel Holbert
Robert Strong
Mike Conley
Alex
Razvan Maries
Agi Sferro
Nihanth Subramanya
harry
Dorel Luca
Liang-Heng Chen
dlee
Brad Werth
mandy cheang
Gijs Kruitbosch
Dylan Roeh
Geoff Brown
Brian Hackett
Cosmin Sabou
arthur.iakab
Erica Wright