b894acb874
Backed out 4 changesets (bug 1646582) for mochitest failures on test_ext_tabs_create.html . CLOSED TREE
...
Backed out changeset ce5cdfc5d7cf (bug 1646582)
Backed out changeset 2ac69a2b6708 (bug 1646582)
Backed out changeset 74d89cb24414 (bug 1646582)
Backed out changeset 7de0ff1af560 (bug 1646582)
2020-06-23 06:30:03 +03:00
79562a2ca1
Bug 1646582 - Remove DOM(Inner)WindowID from nsIWebProgress. r=nika
...
Differential Revision: https://phabricator.services.mozilla.com/D80128
2020-06-23 01:23:57 +00:00
abd87a6510
Bug 1646776 - Make sure to fire load rather than error events for preload links that hit the CSS cache. r=mayhemer
...
When we hit the stylesheet cache for an existing stylesheet in a
different document:
* There's no existing preload in the PreloadService (because the sheet
was loaded in another document).
* We don't create a PreloaderBase (because we don't trigger a load at
all).
* And thus we believe the load has just errored, which is wrong...
Fix it by properly passing through the "already complete" status from
PreloadStyle.
Note that there's still another issue, which is that we'd still hit this
broken path if two stylesheets with the same URI are loading in
different documents and the CSS loader coalesces them.
For that, I think we'd have to make SheetLoadData the thing that
actually implements PreloaderBase. This is kind of an obscure case, and
SheetLoadData has a pretty complex lifetime already (keeps alive a whole
lot of stuff), so I'd prefer to do this in a separate bug.
Differential Revision: https://phabricator.services.mozilla.com/D80289
2020-06-22 14:18:19 +00:00
6bb08bd490
Bug 1646056 - Use const references as keys instead of raw pointers for PreloadHashKey. r=mayhemer
...
Feels a bit more natural for the callers this way. This should have no
behavior change.
Differential Revision: https://phabricator.services.mozilla.com/D79831
2020-06-18 14:06:34 +00:00
939c7c466b
Bug 1642591 - Don't make referrer policy a cache miss for sub-resource {pre,}loads. r=mayhemer,tnikkel
...
For preload we're already effectively not using it, I think, due to
bug 1642325.
For images, this matches the spec, see earlier comments in this bug and
https://bugzilla.mozilla.org/show_bug.cgi?id=1174921#c17 . I think it
makes sense for other sub-resources to align as well.
Differential Revision: https://phabricator.services.mozilla.com/D79812
2020-06-18 14:06:20 +00:00
79760bfbb6
Bug 1642425: Part 3 - Fix nsDocLoader::GetIsTopLevel under Fission. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77702
2020-06-17 18:01:10 +00:00
22b81ffefa
Backed out 2 changesets (bug 1603542) for causing assertion failures in Loader.cpp CLOSED TREE
...
Backed out changeset cc70c96b63e0 (bug 1603542)
Backed out changeset c3dcacdd97c4 (bug 1603542)
2020-06-17 18:37:45 +03:00
4570854a4c
Bug 1603542 - Log a warning in the web console when a preloaded resource is not used, r=Harald
...
Differential Revision: https://phabricator.services.mozilla.com/D76527
2020-06-17 14:06:50 +00:00
5ce8c5c731
Bug 1646032 - Avoid a silly string copy in PreloadService. r=mayhemer
...
There's no real need to go through a DOMString here.
Differential Revision: https://phabricator.services.mozilla.com/D79815
2020-06-16 14:07:18 +00:00
6ce135fbfc
Bug 1646019 - Make PreloadHashKey don't check referrer for equality for style. r=mayhemer
...
We probably should remove the referrer policy check altogether in
bug 1642591, but the preload code still uses the whole referrer as the
key for css, which the css loader stopped doing in bug 1599160.
So this should be an uncontroversial simplification.
Differential Revision: https://phabricator.services.mozilla.com/D79810
2020-06-16 11:41:18 +00:00
cde53b3bec
Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
...
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.
The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.
Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-15 23:24:07 +00:00
0735ecafd8
Bug 1645382 - Remove unnecessary arguments from NS_OBSERVER_ARRAY_NOTIFY_* macros. r=froydnj
...
Differential Revision: https://phabricator.services.mozilla.com/D79485
2020-06-15 09:05:00 +00:00
a8dde16e58
Backed out 10 changesets (bug 1508306, bug 1640019) for bc failures on browser_autoOpen.js . CLOSED TREE
...
Backed out changeset 8844170ff408 (bug 1508306)
Backed out changeset b750f1d873cf (bug 1508306)
Backed out changeset c7170e76e676 (bug 1640019)
Backed out changeset 5905995e4815 (bug 1640019)
Backed out changeset 7bf86513348e (bug 1640019)
Backed out changeset f7d0605295f7 (bug 1640019)
Backed out changeset 521b4d5a9a89 (bug 1640019)
Backed out changeset 8542edc564bc (bug 1640019)
Backed out changeset 4f6a03152526 (bug 1640019)
Backed out changeset 30d2bf04719b (bug 1640019)
2020-06-12 22:47:50 +03:00
47c0aeb539
Bug 1508306 - Part 1: Migate the Large-Allocation handler to DocumentLoadListener, r=mattwoodrow,necko-reviewers,geckoview-reviewers,agi,valentin
...
This removes the diagnostic warnings which used to be logged when the
Large-Allocation header was present, but failed to switch into a
Large-Allocation process. Due to the low adoption of the header, this shouldn't
be too large of a problem, but we can look into re-adding the diagnostics if
needed in the future.
The new codepath no longer performs multiple network requests for
Large-Allocation resources, and now relies on the battle-tested
DocumentLoadListener codepath for process switching.
Differential Revision: https://phabricator.services.mozilla.com/D78998
2020-06-12 16:52:13 +00:00
9914bb84fe
Bug 1644900 - Remove nsMIMEInfoBase::IsPdf as it's no longer used. r=tkikuchi
...
Depends on D79191
Differential Revision: https://phabricator.services.mozilla.com/D79275
2020-06-11 14:38:43 +00:00
1f583acf67
Bug 1644900 - Open Edge in a toolbar-less window when it is selected as a default handler for any type of file. r=jaws,tkikuchi
...
Differential Revision: https://phabricator.services.mozilla.com/D79191
2020-06-11 14:38:21 +00:00
089a846bd0
Bug 1642303 - Keep channel of FetchPreloader even after the load has finished to let preload consumers use that channel early after opening, r=baku
...
Differential Revision: https://phabricator.services.mozilla.com/D78729
2020-06-10 14:21:56 +00:00
5ea808f2bd
Bug 1642722 - convert the nsURILoader.cpp VarCache prefs to StaticPrefs. r=KrisWright
...
converts:
* dom.largeAllocationHeader.enabled
* general.document_open_conversion_depth_limit
Differential Revision: https://phabricator.services.mozilla.com/D78916
2020-06-09 23:03:55 +00:00
8965ac6edc
Bug 1642325 - Exclude referrer policy from the preload hash key, r=ckerschb
...
Depends on D77664
Differential Revision: https://phabricator.services.mozilla.com/D77665
2020-06-08 17:00:37 +00:00
ce7a61e0dc
Bug 1643673 - Guard against a null default application. r=tkikuchi
...
Differential Revision: https://phabricator.services.mozilla.com/D78551
2020-06-05 18:19:12 +00:00
3e55277036
Bug 1632277 - Part 1: Launch PDFs in app mode when default r=jaws,tkikuchi
...
Differential Revision: https://phabricator.services.mozilla.com/D73774
2020-06-03 18:21:32 +00:00
6c6ab1223a
Bug 1606797 - restrict opening the 'open external protocol' dialog, r=johannh,fluent-reviewers,flod
...
This patch adds the following constraints:
- close the dialog when the originating context navigates;
- close the dialog when the originating context closes / goes away;
- do not allow more than 1 dialog at a time;
Differential Revision: https://phabricator.services.mozilla.com/D77029
2020-06-02 17:12:09 +00:00
a64a69eb7d
Bug 1606797 - do not allow navigating to external URIs in cross-origin disjoint browsing contexts, r=johannh,smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D77028
2020-06-01 21:21:32 +00:00
728702a673
Bug 1606797 - pass the triggering principal when opening external URIs, r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D77027
2020-05-27 12:46:34 +00:00
7adf95e964
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-30 17:19:54 +00:00
2f5607b8d0
Bug 1642221 - Rename SheetLoadData::mLoaderPrincipal to mTriggeringPrincipal. r=jwatt
...
I'm about to introduce the concept of "Loader principal" (as in "the
principal of the CSS loader"), and SheetLoadData already has an
mLoaderPrincipal.
However SheetLoadData's principal is just the triggering principal (the
principal that initiated the load). So name it that with consistency
with SheetInfo::mTriggeringPrincipal etc.
Differential Revision: https://phabricator.services.mozilla.com/D77613
2020-05-31 17:11:57 +00:00
fd5b93e11e
Bug 1640589 - Update the mimeInfo when a download is handled internally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D77144
2020-05-28 16:48:48 +00:00
f163447d48
Bug 1366645 - overwrite image file extensions when initializing file info, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75640
2020-05-27 16:30:43 +00:00
865098cc8b
Bug 1366645 - check builtin extra entries for mimetype information before falling back to the extension, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75639
2020-05-28 13:49:34 +00:00
243b953e9d
Bug 1586630 - Add check to GetURIDirectory r=mayhemer
...
Differential Revision: https://phabricator.services.mozilla.com/D76125
2020-05-27 11:48:07 +00:00
54fd961a29
Bug 1641245 - Make string comparators not virtual. r=froydnj,necko-reviewers,geckoview-reviewers,jgilbert,agi,valentin
...
There's no use case for stateful comparators, so they can be just plain
function pointers.
This is used in some hot places like CSS selector matching.
Differential Revision: https://phabricator.services.mozilla.com/D77084
2020-05-27 18:11:12 +00:00
99ddf6cdc5
Backed out 2 changesets (bug 1366645) for Browser-chrome failures in uriloader/exthandler/tests/mochitest/browser_download_open_with_internal_handler.js. CLOSED TREE
...
Backed out changeset cdfedc4707bd (bug 1366645)
Backed out changeset 666659de5856 (bug 1366645)
2020-05-27 19:25:57 +03:00
d4bceb69bb
Bug 1366645 - overwrite image file extensions when initializing file info, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75640
2020-05-27 14:14:26 +00:00
d5b5be8f99
Bug 1366645 - check builtin extra entries for mimetype information before falling back to the extension, r=mak
...
Differential Revision: https://phabricator.services.mozilla.com/D75639
2020-05-22 08:34:17 +00:00
38ffa87e05
Bug 1640160 - Serialize mRequestContextId with BrowsingContext's IPCInitializer to ensure that we don't try to create a request context with an id of 0. r=nika
...
This was a bit of pain to track down, because some code was allowing an ID of 0, and creating a request context to match, but other code was treating 0 as invalid.
Differential Revision: https://phabricator.services.mozilla.com/D76652
2020-05-26 21:14:27 +00:00
1d2238af48
Backed out 2 changesets (bug 1620679) for perma Reftest failure. CLOSED TREE
...
Backed out changeset 8190c67514cc (bug 1620679)
Backed out changeset 4ca2912d7421 (bug 1620679)
2020-05-26 10:58:42 +03:00
d347ab0ef5
Bug 1620679 - Don't fire load event from within Stop(). r=smaug
...
This matches what the spec says, and what blink does.
Differential Revision: https://phabricator.services.mozilla.com/D73994
2020-05-26 03:08:40 +00:00
0057c96229
Bug 1637039 - Make synchronous open errors of a fetch preloading channel be notified to link preload tags, r=kershaw
...
Differential Revision: https://phabricator.services.mozilla.com/D76367
2020-05-25 18:40:07 +00:00
b10e870a54
Bug 1637039 - Adjust `PreloaderBase::NotifyStart` to read channel tainting also for non-opened preloads, r=edgar
...
Differential Revision: https://phabricator.services.mozilla.com/D76362
2020-05-25 18:38:36 +00:00
c686b5d561
Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-23 16:21:16 +00:00
9afe3180db
Backed out changeset 2708f3e553cb (bug 1639606) for causing xpcshell failures in toolkit/components/downloads
...
CLOSED TREE
2020-05-23 00:26:32 +03:00
1b3310643d
Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 17:43:57 +00:00
404a84e0a6
Backed out changeset ee9c7714e513 (bug 1639606) for browser_download_open_with_internal_handler.js failures CLOSED TREE
...
DONTBUILD
2020-05-22 07:04:45 +03:00
c9919e67e4
Bug 1639606 - Downloads that are set to launchWhenSucceeded with an external application should not get handled internally, unless an attempt has already been made to launch externally. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D76243
2020-05-22 02:09:45 +00:00
b7105cc963
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-21 03:38:37 +00:00
c3b7227771
Bug 1639392 - Merge nsIStyleSheetLinkingElement and nsStyleLinkElement, and call it LinkStyle. r=jwatt
...
Which is the spec term. nsIStyleSheetLinkingElement is even more
confusing since it may not be an element at all (see: processing
instructions).
Differential Revision: https://phabricator.services.mozilla.com/D76071
2020-05-21 03:07:16 +00:00
3adaaeb800
Backed out 3 changesets (bug 1627533) for causing assertions in RequestContextService.cpp CLOSED TREE
...
Backed out changeset 3b35a1852a60 (bug 1627533)
Backed out changeset 70fa5e075269 (bug 1627533)
Backed out changeset 0d1046670534 (bug 1627533)
2020-05-21 04:16:21 +03:00
f8b14e22ba
Bug 1627533 - Create LoadGroups for docshells using the BrowsingContext's request context id. r=dragana,necko-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D75885
2020-05-20 23:41:36 +00:00
f5e23e91eb
Bug 1638683 - When opening a PDF internally, the new tab should appear adjacent to the opening tab. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D75818
2020-05-20 14:28:04 +00:00
d88ed92c5f
Bug 1618548 - Make `Link: rel=preload` response header work with preload-as-speculative-load, r=dragana
...
Differential Revision: https://phabricator.services.mozilla.com/D75133
2020-05-18 17:33:57 +00:00
Narcis Beleuzu
Matt Woodrow
Emilio Cobos Álvarez
Kris Maglione
Noemi Erli
Honza Bambas
Nika Layzell
Simon Giesecke
Marco Castelluccio
Alexis Beingessner
Jared Wein
Mark Striemer
Gijs Kruitbosch
Valentin Gosu
Dorel Luca
Butkovits Atila
Mihai Alexandru Michis
Bogdan Tara