This is a far cry from having good error reporting, but we at least need
to notify the app that the page is no longer loading.
MozReview-Commit-ID: Kbm5MpNbND6
--HG--
extra : rebase_source : 69928ace16dcb87b21b4911af6a86a7f5d8b61b3
This small change is actually very significant. Previously, |mach
package| for mobile/android had two jobs:
1) produce a final APK
2) rebuild parts of the APK that might have been silently modified by
l10n mechanisms, both from multi-locale builds and single-locale
repacks
This second part has never been sensible but has been difficult to
alter until recently, since the l10n mechanisms have been out of
mozilla-central and difficult to modify and test. That's less true
now.
This patch:
a) removes the rebuild parts (the step labeled 2) above (which I
generally refer to as the "nodeps mechanism")
b) uses the APKs produced by Gradle directly, without the copying
indirection from m/a/base/Makefile.in
c) does the rebuild for multi-locale builds as an explicit step in the
appropriate mozharness script
d) does the rebuild for each single-locale repack as another step in
the existing `installers-%` target in m/a/locales/Makefile.in (it's
not easy to remove this from the Makefile, since the repackage is
invoked immediately after (it's the `repackage-zip-$*` target))
The new m/a/gradle.py file will grow additional tasks in tickets to
follow, hence the lock file and pre-factored form.
MozReview-Commit-ID: IKflLdmHR3P
--HG--
extra : rebase_source : fdabe340b6f0896a0ebb9da2951f10753deb5ff5
This should have been a part of Bug 1408710, but alas, here we are.
Patch changes two things:
- serializes process failures in BatchingUploader if record-to-be-uploaded fails sanity checks and server requirements
-- this helps us short-circuit flow in RecordsChannel
- avoids performing any work in ServerSession's storeDone if flow has been aborted
MozReview-Commit-ID: 9qevdzRvHEx
--HG--
extra : rebase_source : 2e30aa7e222916acb791a9803bab0d4d95e5e491
No functional change; added tests to cover the decision tree a bit better, renamed stuff.
MozReview-Commit-ID: LwvyBaAg421
--HG--
extra : rebase_source : 4e46be5f67317f6bd5ea0c4701587908a3628634
On Android, GeckoEditableSupport has already dispatched eKeyDown event and
eKeyUp event even during composition. I.e., the pref which will be enabled
by bug 354358 has already been set to true only on Android.
On the other hand, GeckoEditableSupport does not dispatch them if content
listens to "input", "compositionstart", "compositionupdate" or
"compositionend". So, different from the other platforms, we need additional
pref to make the new behavior behind pref.
Therefore, this patch adds a new pref,
"intl.ime.hack.on_any_apps.fire_key_events_for_composition", to override
existing "intl.ime.hack.on_ime_unaware_apps.fire_key_events_for_composition"
pref. And sets mKeyCode and mKeyNameIndex of the dummy KeyboardEvents to
NS_VK_PROCESSKEY and KEY_NAME_INDEX_Process.
MozReview-Commit-ID: Fuy0Ir2xiO5
--HG--
extra : rebase_source : c76b613ea186458ebdf0d67f4bc984e8ac5f1041
Adding static reduces memory overhead from per-instance to per-class and allows
initialization at compile-time instead of run-time. Found via a proposed
error-prone pull request:
https://github.com/google/error-prone/pull/930
MozReview-Commit-ID: CMj6vqFeCdI
--HG--
extra : rebase_source : 43e91b3d8ff4bd8171ac25bd0b333d09645687a6
At last, another part of our long nightmare bites the dust. We had a
complicated system where m/a/base used a FORCE $(MAKE) to produce
l10n-dependent pieces in m/a/base/locales, foiling sensible recursive
Make dependencies and causing much pain and suffering. Now that
things are in moz.build, we can fold this into m/a/base, simplifying
the dependencies. This gets us one step closer to expressing the APK
generation that consumes the dependencies in moz.build.
MozReview-Commit-ID: FzLtgR8AMue
--HG--
extra : rebase_source : 39a3da192822bea9fa803a2bcae76a89dde41a17
As the comment says, these aren't useful during the final stage of
assembling a multi-locale build (when AB_CD=multi is set -- they're
definitely useful for the initial build, when AB_CD is unset and
implicitly en-US). And single-locale repacks don't do any
compilation, so they're definitely not useful there.
By guarding, we avoid having to be specific about what we're building
in the build invocations that will be moved out of |mach package| and
into different parts of the multi-locale build and single-locale
repack processes.
Subsequent tickets will migrate this whole JNI wrapper generation
mechanism to GENERATED_FILES anyway, moving the JNI wrapper generation
closer to the build steps that need the wrappers and avoiding the
problem entirely: those build steps won't be invoked at all for
multi-locale builds or for single-locale repacks.
MozReview-Commit-ID: Lt2d6uFm5Dq
--HG--
extra : rebase_source : 88cb76a01641a46e21f4e21da86c07a068ee64cc
There's just no need for this: it makes interpreting build logs that
little bit harder.
MozReview-Commit-ID: 7gq73I8I3Bt
--HG--
extra : rebase_source : 1e5be3b243fc785c195c442e162edc8fc1fffc1d
When we reset the old native queue when transferring to another session,
perform the reset right after the transfer() call, instead of in
onTransfer(), which is too late for clearing stale pending calls.
Then, after transferring to a new queue, let Gecko call Window.onReady
to set the new queue's state if needed. That way the Java queue state is
consistent with the Gecko state.
MozReview-Commit-ID: CUXGrhR4FCD
--HG--
extra : rebase_source : a196361f1db1304c178a3471082d586dddfe2a32
Fix a null pointer crash when we fail to preload a child process.
MozReview-Commit-ID: FIJopxOVAEj
--HG--
extra : rebase_source : 600466740c684bfadcfac0e30d5bf2fc075e4d25
Ensure that we unregister and re-register all listeners on
closeWindow, so that the listeners are ready for any new windows that
are subsequently opened.
MozReview-Commit-ID: EKzCRS10odN
--HG--
extra : rebase_source : 80615ef28839d9e76ecc47881d7b47b59ddea563
Add session lifecycle tests for testing behavior for
openWindow/closeWindow, Parcelable support, and how some methods behave
when the session is open.
MozReview-Commit-ID: 4UfBRY1pLv6
--HG--
extra : rebase_source : d5c700b467fe6e812e013ea7f89a4ba3bc99974c
Eugen Sawin
Sylvestre Ledru
Tiberius Oros
Cosmin Sabou
James Willcox
Nick Alexander
Noemi Erli
Sebastian Kaspari
Dylan Roeh
Eitan Isaacson
Andreas Pehrson
Coroiu Cristina
Tim Nguyen
Marco Bonardo
Grigory Kruglov
arthur.iakab
Masayuki Nakano
Narcis Beleuzu
Andrew Gaul
Margareta Eliza Balazs
Geoff Brown
Gijs Kruitbosch
Jim Chen
Csoregi Natalia
Randall Barker