840f75da74
Bug 1168606 - Replaced custom for loops by range-based for or STL algorithms. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D44988
--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:57 +00:00
cd0b6f05a1
Bug 1168606 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43631
--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:45 +00:00
16d87d7487
Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43470
--HG--
extra : moz-landing-system : lando
2019-10-03 07:56:32 +00:00
ae7651951f
Bug 1584323 - Add more object properties to IndexedDBShutdownTimeout and LocalStorageShutdownTimeout crash annotations; r=asuth, dr=chutten
...
Differential Revision: https://phabricator.services.mozilla.com/D47341
--HG--
extra : moz-landing-system : lando
2019-10-02 04:28:23 +00:00
cb31d323be
Backed out 5 changesets (bug 1168606) for xpcshell failures in dom/indexedDB/test/unit/test_temporary_storage.js on a CLOSED TREE
...
Backed out changeset fc5e1bee1332 (bug 1168606)
Backed out changeset 63cf0966cb41 (bug 1168606)
Backed out changeset f844afbebc6a (bug 1168606)
Backed out changeset 9e7a90dcc429 (bug 1168606)
Backed out changeset e493a6b5f125 (bug 1168606)
2019-10-02 02:28:15 +03:00
3feb8e1ebe
Bug 1168606 - Send two records with every ObjectStoreCursorResponse. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43252
--HG--
extra : moz-landing-system : lando
2019-10-01 09:15:49 +00:00
8b0c6aa21d
Bug 1168606 - Replaced custom for loops by range-based for or STL algorithms. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D44988
--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:21 +00:00
a9cf10ae19
Bug 1168606 - Use const where easily possible. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43631
--HG--
extra : moz-landing-system : lando
2019-10-01 09:14:04 +00:00
0438fc4336
Bug 1168606 - Avoid copying keys on cursor creation. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43470
--HG--
extra : moz-landing-system : lando
2019-10-01 08:56:37 +00:00
10d41866a5
Bug 1585156 - Remove useless inclusions of nsIDOMWindow.h and nsIDOMWindowUtils.h r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D47678
--HG--
extra : moz-landing-system : lando
2019-09-30 22:06:47 +00:00
470b2174a1
Bug 1168606 - Allow current key to be provided with PBackgroundIDBCursor::Continue. r=ttung,asuth
...
The key is assumed to be unset for now.
Differential Revision: https://phabricator.services.mozilla.com/D43251
--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:41 +00:00
bd2e4939bc
Bug 1168606 - Remove duplication in uses of IDB_LOG_MARK. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46576
--HG--
extra : moz-landing-system : lando
2019-09-27 10:11:45 +00:00
6214b585a0
Bug 1577107 - Avoid following the prototype chain r=janv
...
With this commit we no longer follow the value's prototype chain when
creating index updates in IndexedDB.
Differential Revision: https://phabricator.services.mozilla.com/D44438
--HG--
extra : moz-landing-system : lando
2019-09-27 13:36:25 +00:00
a1dce92fcd
Bug 1578453 - Correctly calculate response size in IndexGetKeyRequestOp::GetResponse and ObjectStoreGetKeyRequestOp::GetResponse r=ttung,asuth
...
Before this, the response size was always calculated as 0, since it used the swapped-out array.
In addition, make use of std::accumulate to increase idiomacy.
Differential Revision: https://phabricator.services.mozilla.com/D44806
--HG--
extra : moz-landing-system : lando
2019-09-26 21:49:54 +00:00
f892c56fa2
Backed out changeset e91773704fbd (bug 1577107) for wpt crashes/assertions on clone-before-keypath-eval.html. CLOSED TREE
...
--HG--
extra : histedit_source : 65f613208b85a94eef3de04365bc8e4e87585ac8
2019-09-26 20:11:03 +03:00
b9add81961
Bug 1577107 - Avoid following the prototype chain r=janv
...
With this commit we no longer follow the value's prototype chain when
creating index updates in IndexedDB.
Differential Revision: https://phabricator.services.mozilla.com/D44438
--HG--
extra : moz-landing-system : lando
2019-09-13 09:35:09 +00:00
88670a47e9
Bug 1580782 - Change Callsites to use nsIPrincipal->SchemeIs r=ckerschb
...
Differential Revision: https://phabricator.services.mozilla.com/D45654
--HG--
extra : moz-landing-system : lando
2019-09-26 10:47:16 +00:00
4e1448e7e6
Backed out 2 changesets (bug 1510226) for causing xpcshell crashes and xpcshell failures in test_TelemetrySession.js CLOSED TREE
...
Backed out changeset cb739de6606d (bug 1510226)
Backed out changeset b6f670610dc3 (bug 1510226)
2019-09-25 04:25:07 +03:00
65be2b22c1
Bug 1510226 - Remove vestigial references to cooperative scheduling r=froydnj
...
GetCurrentPhysicalThread and GetCurrentVirtualThread are, in practice,
identical, as the TLS override that GetCurrentVirtualThread depends on
is never actually set. This simply removes that and renames some things/
deletes some comments.
Differential Revision: https://phabricator.services.mozilla.com/D41247
--HG--
extra : moz-landing-system : lando
2019-08-20 18:03:11 +00:00
021b9b9087
Bug 1552800 - Instead of assuming success, do proper error checking; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D46600
--HG--
extra : moz-landing-system : lando
2019-09-24 12:39:24 +00:00
e26682d684
Bug 1581173 part 1. Add a way to more easily throw TypeErrors and RangeErrors with custom message strings via ErrorResult. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45932
--HG--
extra : moz-landing-system : lando
2019-09-20 02:19:18 +00:00
89e37616c3
Bug 1168606 - Refactored tests, reduced duplicated code. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43250
--HG--
extra : moz-landing-system : lando
2019-09-18 06:43:08 +00:00
e6e5f01c36
Bug 1168606 - Apply renamings suggested for Cursor::*Key members and related identifiers. r=ytausky,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43249
--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:35 +00:00
27297c9cf8
Bug 1168606 - Inline Key::Assert function to make effective use of MOZ_ASSERT diagnostics. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43039
--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:23 +00:00
8158af97af
Bug 1168606 - Make limit parameter a statement parameter. r=ytausky,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D43038
--HG--
extra : moz-landing-system : lando
2019-09-18 06:41:11 +00:00
6d939ca292
Bug 1168606 - Refactored building of key range and direction clauses. r=ttung,asuth
...
To align with the coding style, GetBindingClauseForKeyRange should return its
result rather than by modifying an output parameter.
Differential Revision: https://phabricator.services.mozilla.com/D42853
--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:53 +00:00
433dbe0b8e
Bug 1168606 - Remove code duplication in DatabaseOperationBase::BindKeyRangeToStatement overloads r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D42852
--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:40 +00:00
19bf854bca
Bug 1168606 - Move the functionality of OpenOp::GetKeyRangeInfo to Cursor::SetOptionalKeyRange r=ttung,asuth
...
Also avoid unnecessary copying of the non-locale-based key in case the locale-based is needed, and reduced code duplication and variable scoping. r=ttung
Differential Revision: https://phabricator.services.mozilla.com/D41404
--HG--
extra : moz-landing-system : lando
2019-09-18 06:40:28 +00:00
f408d617b9
Bug 1580195 - Exclude calls of open(name, {}) and open(name) from telemetry. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D45812
--HG--
extra : moz-landing-system : lando
2019-09-13 16:55:13 +00:00
2bb315d0cf
Bug 1093064 - Repeat garbage collection until ref count becomes 0 r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D42609
--HG--
extra : moz-landing-system : lando
2019-09-13 14:02:20 +00:00
14c30e58d6
Bug 1578173 part 4. Switch event subclasses to constructor operations. r=smaug
...
Differential Revision: https://phabricator.services.mozilla.com/D45391
--HG--
extra : moz-landing-system : lando
2019-09-11 14:35:28 +00:00
76e17f42d9
Bug 1168606 - Extract DatabaseConnection::ExecuteCachedStatement function. r=ytausky,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D41225
--HG--
extra : moz-landing-system : lando
2019-09-11 13:07:05 +00:00
11c156d4b5
Bug 1168606 - Unified handling of literal strings using NS_LITERAL_(C)STRING and removed some duplications. r=ttung,asuth
...
Harmonized and provided a rationale for defining statement parameter names literally vs. by named constant,
and referencing them in binding calls by index vs. by name.
Differential Revision: https://phabricator.services.mozilla.com/D41026
--HG--
extra : moz-landing-system : lando
2019-09-11 13:02:38 +00:00
8612ca8e4b
Bug 1168606 - Extracted methods Cursor::OpenOp::PrepareKeyConditionClauses and PrepareIndexKeyConditionClause. r=ttung,asuth
...
Also reduced duplication within the extracted methods.
Differential Revision: https://phabricator.services.mozilla.com/D41025
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:35 +00:00
95342c2fde
Bug 1168606 - Reduce code duplication for different open cursor variants. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40956
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:24 +00:00
f4cb5f1dee
Bug 1168606 - Change definition of OpenCursorParams subtypes to allow reducing duplicated code r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40955
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:26 +00:00
abad982ec4
Bug 1168606 - Reduce the use of plain pointers, and use const for Cursor data members where possible. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D40954
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:28 +00:00
860d44f9b4
Bug 1168606 - Added comments on almost-const data members r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D42645
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:20 +00:00
024bb0ac16
Bug 1168606 - Added documentation on Cursor data members. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D41403
--HG--
extra : moz-landing-system : lando
2019-09-11 11:51:22 +00:00
b5c83385d6
Backed out 8 changesets (bug 1168606) for failures in idbcursor-continuePrimaryKey.htm
...
Backed out changeset 066bee573945 (bug 1168606)
Backed out changeset 1485cea56f41 (bug 1168606)
Backed out changeset 4858e4e132de (bug 1168606)
Backed out changeset 5be5a3bf0499 (bug 1168606)
Backed out changeset 6078d5a9c010 (bug 1168606)
Backed out changeset f5aee1ae7282 (bug 1168606)
Backed out changeset acae76cea927 (bug 1168606)
Backed out changeset 0133605c6169 (bug 1168606)
--HG--
extra : rebase_source : 27477feb2e52f4149ede2fe5db9d86b5e322046d
2019-09-11 14:36:57 +03:00
409cee8a78
Bug 1168606 - Extract DatabaseConnection::ExecuteCachedStatement function. r=ytausky,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D41225
--HG--
extra : moz-landing-system : lando
2019-09-11 09:04:02 +00:00
0287e643ca
Bug 1168606 - Unified handling of literal strings using NS_LITERAL_(C)STRING and removed some duplications. r=ttung,asuth
...
Harmonized and provided a rationale for defining statement parameter names literally vs. by named constant,
and referencing them in binding calls by index vs. by name.
Differential Revision: https://phabricator.services.mozilla.com/D41026
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:07 +00:00
f7165d415d
Bug 1168606 - Extracted methods Cursor::OpenOp::PrepareKeyConditionClauses and PrepareIndexKeyConditionClause. r=ttung,asuth
...
Also reduced duplication within the extracted methods.
Differential Revision: https://phabricator.services.mozilla.com/D41025
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:11 +00:00
4bfd09c089
Bug 1168606 - Reduce code duplication for different open cursor variants. r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40956
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:15 +00:00
4a9fe9f0a5
Bug 1168606 - Change definition of OpenCursorParams subtypes to allow reducing duplicated code r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D40955
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:09 +00:00
9aa284cb0c
Bug 1168606 - Reduce the use of plain pointers, and use const for Cursor data members where possible. r=ttung
...
Differential Revision: https://phabricator.services.mozilla.com/D40954
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:13 +00:00
a947f3b52f
Bug 1168606 - Added comments on almost-const data members r=ttung,asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D42645
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:01 +00:00
f613dbb67c
Bug 1168606 - Added documentation on Cursor data members. r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D41403
--HG--
extra : moz-landing-system : lando
2019-09-10 15:36:03 +00:00
0d566d73d5
Bug 1577202 - Replace assertion for missing mDirectoryLock by a regular failure. r=janv
...
Differential Revision: https://phabricator.services.mozilla.com/D44681
--HG--
extra : moz-landing-system : lando
2019-09-11 08:17:46 +00:00
2ac78b7c79
Bug 1348682 - Check if it's shutting down at the beginning of the State::FinishOpen; r=asuth
...
Differential Revision: https://phabricator.services.mozilla.com/D44314
--HG--
extra : moz-landing-system : lando
2019-09-02 21:17:14 +00:00
Simon Giesecke
Jan Varga
Oana Pop Rus
Gabriele Svelto
Yaron Tausky
Brindusan Cristian
Sebastian Streich
Mihai Alexandru Michis
Doug Thayer
Ehsan Akhgari
Boris Zbarsky
Tom Tung